[GitHub] karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-04 Thread GitBox
karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r245448110 ## File path: pom.xml ## @@ -0,0 +1,553 @@ +

[GitHub] karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-04 Thread GitBox
karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r245448384 ## File path: pom.xml ## @@ -0,0 +1,553 @@ +

[GitHub] karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r244901802 ## File path: pom.xml ## @@ -0,0 +1,553 @@ +

[GitHub] twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r244900609 ## File path: pom.xml ## @@ -0,0 +1,553 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r244900566 ## File path: pom.xml ## @@ -0,0 +1,553 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
twdsilva commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r244900773 ## File path: pom.xml ## @@ -0,0 +1,553 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] karanmehta93 opened a new pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
karanmehta93 opened a new pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1 @tdsilva @joshelser Please review. This is an automated message

[GitHub] karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-02 Thread GitBox
karanmehta93 commented on a change in pull request #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#discussion_r244901996 ## File path: pom.xml ## @@ -0,0 +1,553 @@ +

[GitHub] karanmehta93 opened a new pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-16 Thread GitBox
karanmehta93 opened a new pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/2 This is an automated message from the Apache Git Service. To

[GitHub] twdsilva commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-16 Thread GitBox
twdsilva commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#issuecomment-454907464 @karanmehta93 Are you able to compile the project? I get the following error ``` [ERROR] [ERROR] Some problems

[GitHub] karanmehta93 commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-16 Thread GitBox
karanmehta93 commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#issuecomment-454968435 Didn't realize that I accidentally committed it to the apache repo. I have reverted it and will push it once

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248471561 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248474075 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248480179 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248479110 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248470101 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248476831 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248472913 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248477351 ## File path:

[GitHub] dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-16 Thread GitBox
dbwong commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248475543 ## File path:

[GitHub] twdsilva commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-16 Thread GitBox
twdsilva commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#issuecomment-454902042 @karanmehta93 We should also just have a single branch master (instead of the current branch 4.x-HBase-1.4)

[GitHub] karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248809669 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248831680 ## File path:

[GitHub] karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248810022 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248824547 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248832558 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-17 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248824547 ## File path:

[GitHub] karanmehta93 merged pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-17 Thread GitBox
karanmehta93 merged pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419 This is an automated message from the Apache Git Service. To

[GitHub] karanmehta93 commented on issue #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-17 Thread GitBox
karanmehta93 commented on issue #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#issuecomment-455364313 Thanks @BinShi-SecularBird @dbwong and @twdsilva for the review. I will push it to this branch. The patch

[GitHub] twdsilva opened a new pull request #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
twdsilva opened a new pull request #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1 @karanmehta93 @joshelser @vincentpoon Can you please review? I tried to clean up the pom to remove dependencies that are not required, but I didn't get

[GitHub] twdsilva commented on a change in pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-17 Thread GitBox
twdsilva commented on a change in pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/2#discussion_r248889812 ## File path: queryserver-client/pom.xml ## @@ -0,0 +1,203 @@ + + +

[GitHub] twdsilva commented on a change in pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-17 Thread GitBox
twdsilva commented on a change in pull request #2: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/2#discussion_r248889882 ## File path: queryserver/pom.xml ## @@ -0,0 +1,188 @@ + + +

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249141342 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248832558 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249149120 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249141342 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249150888 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249146291 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249150355 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249210005 ## File path:

[GitHub] karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-18 Thread GitBox
karanmehta93 commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r249194456 ## File path:

[GitHub] jstanier closed pull request #123: Update performance.py

2019-01-20 Thread GitBox
jstanier closed pull request #123: Update performance.py URL: https://github.com/apache/phoenix/pull/123 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] comnetwork opened a new pull request #431: PHOENIX-5105

2019-01-20 Thread GitBox
comnetwork opened a new pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431 PHOENIX-5105 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ChinmaySKulkarni opened a new pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection

2019-01-15 Thread GitBox
ChinmaySKulkarni opened a new pull request #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection URL: https://github.com/apache/phoenix/pull/428 **[WIP DO NOT MERGE!]** - Using 1 cell per dyn col for metadata storage. Upsert path done. Select path done.

[GitHub] ChinmaySKulkarni commented on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection

2019-01-15 Thread GitBox
ChinmaySKulkarni commented on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection URL: https://github.com/apache/phoenix/pull/428#issuecomment-454492525 PR for discussions on approach. This is WIP. Please let me know your thoughts and if there are any

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-15 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248016990 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache

2019-01-15 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 Use asynchronous refresh to provide non-blocking Phoenix Stats Client Cache URL: https://github.com/apache/phoenix/pull/425#discussion_r248016990 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-14 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r247591466 ## File path:

[GitHub] karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-14 Thread GitBox
karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r247636499 ## File path:

[GitHub] karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-14 Thread GitBox
karanmehta93 commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r247710383 ## File path:

[GitHub] twdsilva opened a new pull request #426: Add test to verify IndexTool can build global view indexes

2019-01-14 Thread GitBox
twdsilva opened a new pull request #426: Add test to verify IndexTool can build global view indexes URL: https://github.com/apache/phoenix/pull/426 @gjacoby126 Can you please review? This is an automated message from the

[GitHub] dbwong opened a new pull request #427: PHOENIX-5093 Support SChema and Table with leading underscore '_' as …

2019-01-14 Thread GitBox
dbwong opened a new pull request #427: PHOENIX-5093 Support SChema and Table with leading underscore '_' as … URL: https://github.com/apache/phoenix/pull/427 …described in documentation. This is an automated message from the

[GitHub] twdsilva closed pull request #426: PHOENIX-5100 Add test to verify IndexTool can build global view indexes

2019-01-15 Thread GitBox
twdsilva closed pull request #426: PHOENIX-5100 Add test to verify IndexTool can build global view indexes URL: https://github.com/apache/phoenix/pull/426 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@phoenix.apache.org

[GitHub] karanmehta93 commented on a change in pull request #427: PHOENIX-5093 Support Schema and Table with leading underscore '_' as …

2019-01-14 Thread GitBox
karanmehta93 commented on a change in pull request #427: PHOENIX-5093 Support Schema and Table with leading underscore '_' as … URL: https://github.com/apache/phoenix/pull/427#discussion_r247748955 ## File path:

[GitHub] BinShi-SecularBird commented on issue #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-14 Thread GitBox
BinShi-SecularBird commented on issue #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#issuecomment-454267989 @karanmehta93, the change looks good to me. Signed off.

[GitHub] twdsilva opened a new pull request #429: Date filter pushdown

2019-01-15 Thread GitBox
twdsilva opened a new pull request #429: Date filter pushdown URL: https://github.com/apache/phoenix/pull/429 …ark connector @c This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ChinmaySKulkarni commented on issue #429: Date filter pushdown

2019-01-15 Thread GitBox
ChinmaySKulkarni commented on issue #429: Date filter pushdown URL: https://github.com/apache/phoenix/pull/429#issuecomment-454612540 lgtm @twdsilva. Will this work with just the default date format or any `SimpleDateFormat`?

[GitHub] twdsilva commented on issue #429: Date filter pushdown

2019-01-15 Thread GitBox
twdsilva commented on issue #429: Date filter pushdown URL: https://github.com/apache/phoenix/pull/429#issuecomment-454615214 This should work with any DateFormat, we are currently converting the java.sql.Date to a String (in the default date format) and then back to a date using TO_DATE

[GitHub] twdsilva commented on issue #429: Date filter pushdown

2019-01-15 Thread GitBox
twdsilva commented on issue #429: Date filter pushdown URL: https://github.com/apache/phoenix/pull/429#issuecomment-454610608 @ChinmaySKulkarni Can you please review? This is an automated message from the Apache Git Service.

[GitHub] ChinmaySKulkarni commented on a change in pull request #427: PHOENIX-5093 Support Schema and Table with leading underscore '_' as …

2019-01-15 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #427: PHOENIX-5093 Support Schema and Table with leading underscore '_' as … URL: https://github.com/apache/phoenix/pull/427#discussion_r248121691 ## File path:

[GitHub] ChinmaySKulkarni commented on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection

2019-01-21 Thread GitBox
ChinmaySKulkarni commented on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection URL: https://github.com/apache/phoenix/pull/428#issuecomment-456281903 Please review @twdsilva, @gjacoby126, @vincentpoon @kadirozde if you have some time.

[GitHub] ChinmaySKulkarni removed a comment on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection

2019-01-21 Thread GitBox
ChinmaySKulkarni removed a comment on issue #428: PHOENIX-374: Enable access to dynamic columns in * or cf.* selection URL: https://github.com/apache/phoenix/pull/428#issuecomment-454492525 PR for discussions on approach. This is WIP. Please let me know your thoughts and if there are any

[GitHub] twdsilva commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
twdsilva commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r249928972 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/SubselectRewriter.java ## @@ -70,12 +69,126 @@ public static boolean

[GitHub] twdsilva commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
twdsilva commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r249996838 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static void

[GitHub] twdsilva commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
twdsilva commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r249993710 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static void

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250034819 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/SubselectRewriter.java ## @@ -70,12 +69,126 @@ public static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037949 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-22 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] twdsilva closed pull request #429: Date filter pushdown

2019-01-23 Thread GitBox
twdsilva closed pull request #429: Date filter pushdown URL: https://github.com/apache/phoenix/pull/429 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] dbwong commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-17 Thread GitBox
dbwong commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r248862620 ## File path:

[GitHub] vincentpoon commented on issue #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
vincentpoon commented on issue #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#issuecomment-455406970 @twdsilva I get an error when compiling phoenix-spark: [INFO] --- scala-maven-plugin:3.4.4:compile (scala-compile-first) @

[GitHub] vincentpoon commented on a change in pull request #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
vincentpoon commented on a change in pull request #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#discussion_r248912714 ## File path: pom.xml ## @@ -0,0 +1,778 @@ +http://maven.apache.org/POM/4.0.0;

[GitHub] vincentpoon commented on a change in pull request #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
vincentpoon commented on a change in pull request #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#discussion_r248912853 ## File path: pom.xml ## @@ -0,0 +1,778 @@ +http://maven.apache.org/POM/4.0.0;

[GitHub] twdsilva commented on issue #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
twdsilva commented on issue #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#issuecomment-455409057 @vincentpoon Did you do a mvn install with the head of the 4.x-HBase-1.4 branch of phoenix?

[GitHub] karanmehta93 opened a new pull request #430: PHOENIX-5091 Add new features to UpdateStatisticsTool

2019-01-17 Thread GitBox
karanmehta93 opened a new pull request #430: PHOENIX-5091 Add new features to UpdateStatisticsTool URL: https://github.com/apache/phoenix/pull/430 @dbwong @BinShi-SecularBird Please review. This is an automated message from

[GitHub] vincentpoon commented on issue #1: Initial commit of existing connectors

2019-01-17 Thread GitBox
vincentpoon commented on issue #1: Initial commit of existing connectors URL: https://github.com/apache/phoenix-connectors/pull/1#issuecomment-455410552 @twdsilva I had some old version, with the latest it now works, thanks

[GitHub] comnetwork opened a new pull request #432: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork opened a new pull request #432: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/432 This patch is mainly for: 1. following the suggestions of @twdsilva at #431 2. omitted more useless code to make it more clear that "the postFilters which are pushed down to

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250179286 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250179286 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250179286 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250179286 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java ## @@ -742,4 +742,112 @@ private static

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] comnetwork commented on a change in pull request #431: PHOENIX-5105

2019-01-23 Thread GitBox
comnetwork commented on a change in pull request #431: PHOENIX-5105 URL: https://github.com/apache/phoenix/pull/431#discussion_r250037849 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/JoinCompiler.java ## @@ -761,13 +761,15 @@ public Expression

[GitHub] joshelser commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-08 Thread GitBox
joshelser commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#issuecomment-452418786 A couple higher-level thoughts: * How do I use this? If I have Phoenix 4.14.1 installed, how do I "install

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached.

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached. URL: https://github.com/apache/phoenix/pull/425#discussion_r246155299 ## File path:

[GitHub] karanmehta93 commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached.

2019-01-08 Thread GitBox
karanmehta93 commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached. URL: https://github.com/apache/phoenix/pull/425#discussion_r246153437 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246160624 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246163557 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246163557 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246157059 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246163422 ## File path:

[GitHub] karanmehta93 commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server

2019-01-08 Thread GitBox
karanmehta93 commented on issue #1: PHOENIX-5063 Create a new repo for the phoenix query server URL: https://github.com/apache/phoenix-queryserver/pull/1#issuecomment-452483590 > How do I use this? If I have Phoenix 4.14.1 installed, how do I "install PQS"? We internally use the

[GitHub] BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached.

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #425: PHOENIX-5069 please go to JIRA to see the detailed design document attached. URL: https://github.com/apache/phoenix/pull/425#discussion_r246099906 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246160624 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246157059 ## File path:

[GitHub] BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on…

2019-01-08 Thread GitBox
BinShi-SecularBird commented on a change in pull request #419: PHOENIX-4009 Run UPDATE STATISTICS command by using MR integration on… URL: https://github.com/apache/phoenix/pull/419#discussion_r246166165 ## File path:

  1   2   3   4   5   6   7   8   9   10   >