[jira] [Updated] (RATIS-244) MD5 file might not exist for snapshot file

[ https://issues.apache.org/jira/browse/RATIS-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-244: -- Component/s: server > MD5 file might not exist for snapshot file >

[jira] [Updated] (RATIS-91) Add multi-raft support

[ https://issues.apache.org/jira/browse/RATIS-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-91: - Component/s: raft-group > Add multi-raft support > -- > >

[jira] [Resolved] (RATIS-159) Deadlock between AppendStreamer and SegmentedRaftLog eviction

[ https://issues.apache.org/jira/browse/RATIS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-159. --- Resolution: Duplicate Thanks for confirming it.  Resolving ... > Deadlock between

[jira] [Commented] (RATIS-159) Deadlock between AppendStreamer and SegmentedRaftLog eviction

[ https://issues.apache.org/jira/browse/RATIS-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548184#comment-16548184 ] Tsz Wo Nicholas Sze commented on RATIS-159: --- [~chrajeshbab...@gmail.com], this Jira probably is

[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors

[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554572#comment-16554572 ] Tsz Wo Nicholas Sze commented on RATIS-265: --- Maintaining a limit in PendingRequests sounds good.

[jira] [Commented] (RATIS-269) Enhance server information reply to add raft node role, raft storage directory status information

[ https://issues.apache.org/jira/browse/RATIS-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554840#comment-16554840 ] Tsz Wo Nicholas Sze commented on RATIS-269: --- The idea is great. Some minor comments: - Let's

[jira] [Updated] (RATIS-253) Segmented Raft log rolls over segment frequently

[ https://issues.apache.org/jira/browse/RATIS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-253: -- Fix Version/s: (was: 0.2.0) Component/s: server > Segmented Raft log rolls

[jira] [Resolved] (RATIS-242) Leader Election not working properly

[ https://issues.apache.org/jira/browse/RATIS-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-242. --- Resolution: Duplicate Fix Version/s: (was: 0.2.0) Resolving this as a

[jira] [Updated] (RATIS-257) Publish ratis related presentations on the ratis web site

[ https://issues.apache.org/jira/browse/RATIS-257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-257: -- Component/s: documentation > Publish ratis related presentations on the ratis web site

[jira] [Commented] (RATIS-257) Publish ratis related presentations on the ratis web site

[ https://issues.apache.org/jira/browse/RATIS-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549906#comment-16549906 ] Tsz Wo Nicholas Sze commented on RATIS-257: --- Sorry for the late response. The link below is my

[jira] [Commented] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596614#comment-16596614 ] Tsz Wo Nicholas Sze commented on RATIS-300: --- I just have filed RATIS-305 and RATIS-306 for these

[jira] [Commented] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596587#comment-16596587 ] Tsz Wo Nicholas Sze commented on RATIS-300: --- Hi [~msingh], thanks for the review. > 1) Should

[jira] [Updated] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-300: -- Attachment: (was: r300_20180822.patch) > Support multiple RaftServerImpl in

[jira] [Updated] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-300: -- Attachment: r300_20180831.patch > Support multiple RaftServerImpl in RaftServerProxy >

[jira] [Commented] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599281#comment-16599281 ] Tsz Wo Nicholas Sze commented on RATIS-300: --- r300_20180831.patch: fixes a bug. > Support

[jira] [Updated] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-300: -- Attachment: (was: r300_20180831.patch) > Support multiple RaftServerImpl in

[jira] [Updated] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-300: -- Attachment: (was: r300_20180831b.patch) > Support multiple RaftServerImpl in

[jira] [Updated] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-300: -- Attachment: r300_20180901.patch > Support multiple RaftServerImpl in RaftServerProxy >

[jira] [Commented] (RATIS-300) Support multiple RaftServerImpl in RaftServerProxy

[ https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599913#comment-16599913 ] Tsz Wo Nicholas Sze commented on RATIS-300: --- Oops, I somehow did not see it previously. Thanks.

[jira] [Commented] (RATIS-309) Add client api's to add/remove peers from a raft group.

[ https://issues.apache.org/jira/browse/RATIS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603749#comment-16603749 ] Tsz Wo Nicholas Sze commented on RATIS-309: --- Hi [~msingh], we may use

[jira] [Updated] (RATIS-305) Replace the reinitialize() API with some group management APIs

[ https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-305: -- Attachment: r305_20180904.patch > Replace the reinitialize() API with some group

[jira] [Commented] (RATIS-305) Replace the reinitialize() API with some group management APIs

[ https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603746#comment-16603746 ] Tsz Wo Nicholas Sze commented on RATIS-305: --- r305_20180904.patch: 1st patch. > Replace the

[jira] [Commented] (RATIS-310) Add support for Retry Policy in Ratis

[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604871#comment-16604871 ] Tsz Wo Nicholas Sze commented on RATIS-310: --- Let's move the RetryPolicy classes and the test to

[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException

[ https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604878#comment-16604878 ] Tsz Wo Nicholas Sze commented on RATIS-303: --- Thanks [~shashikant]. - Could you describe how the

[jira] [Created] (RATIS-314) Use different loggers for different confs.

Tsz Wo Nicholas Sze created RATIS-314: - Summary: Use different loggers for different confs. Key: RATIS-314 URL: https://issues.apache.org/jira/browse/RATIS-314 Project: Ratis Issue Type:

[jira] [Updated] (RATIS-314) Use different loggers for different confs.

[ https://issues.apache.org/jira/browse/RATIS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-314: -- Attachment: r314_20180910.patch > Use different loggers for different confs. >

[jira] [Updated] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException

[ https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-303: -- Component/s: (was: server) test +1 patch looks good. >

[jira] [Updated] (RATIS-310) Add support for Retry Policy in Ratis

[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-310: -- Attachment: (was: RATIS-310.01.patch) > Add support for Retry Policy in Ratis >

[jira] [Commented] (RATIS-310) Add support for Retry Policy in Ratis

[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609775#comment-16609775 ] Tsz Wo Nicholas Sze commented on RATIS-310: --- Thanks, [~shashikant]. Some comments: - Use

[jira] [Commented] (RATIS-314) Use different loggers for different confs.

[ https://issues.apache.org/jira/browse/RATIS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609828#comment-16609828 ] Tsz Wo Nicholas Sze commented on RATIS-314: --- r314_20180910b.patch: some minor bug fixes. > Use

[jira] [Updated] (RATIS-314) Use different loggers for different confs.

[ https://issues.apache.org/jira/browse/RATIS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-314: -- Attachment: (was: r314_20180910.patch) > Use different loggers for different confs.

[jira] [Updated] (RATIS-314) Use different loggers for different confs.

[ https://issues.apache.org/jira/browse/RATIS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-314: -- Attachment: r314_20180910b.patch > Use different loggers for different confs. >

[jira] [Commented] (RATIS-310) Add support for Retry Policy in Ratis

[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609860#comment-16609860 ] Tsz Wo Nicholas Sze commented on RATIS-310: --- In sendRequestWithRetry, it should not sleep if it

[jira] [Created] (RATIS-305) Replace the reinitialize() API with some group management APIs

Tsz Wo Nicholas Sze created RATIS-305: - Summary: Replace the reinitialize() API with some group management APIs Key: RATIS-305 URL: https://issues.apache.org/jira/browse/RATIS-305 Project: Ratis

[jira] [Created] (RATIS-306) Support multiple storage directories

Tsz Wo Nicholas Sze created RATIS-306: - Summary: Support multiple storage directories Key: RATIS-306 URL: https://issues.apache.org/jira/browse/RATIS-306 Project: Ratis Issue Type:

[jira] [Updated] (RATIS-272) LogService: Design ideal API

[ https://issues.apache.org/jira/browse/RATIS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-272: -- Summary: LogService: Design ideal API (was: Design ideal API) > LogService: Design

[jira] [Commented] (RATIS-272) Design ideal API

[ https://issues.apache.org/jira/browse/RATIS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607615#comment-16607615 ] Tsz Wo Nicholas Sze commented on RATIS-272: --- +1 patch looks good. > Design ideal API >

[jira] [Updated] (RATIS-252) Add API to state machine for determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: r252_20180705.patch > Add API to state machine for determining server role

[jira] [Updated] (RATIS-252) Add API to state machine for determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: (was: r252_20180629.patch) > Add API to state machine for determining

[jira] [Commented] (RATIS-252) Add API to state machine for determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533747#comment-16533747 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- Thanks [~ljain] for the review! > ... It might be

[jira] [Commented] (RATIS-252) Add API to state machine for determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533757#comment-16533757 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- r252_20180705.patch: removes the unused imports. >

[jira] [Updated] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: (was: r252_20180709.patch) > Add an API for state machine to

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538197#comment-16538197 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- r252_20180710.patch: some code cleanup. > Add an

[jira] [Updated] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: r252_20180710.patch > Add an API for state machine to determining server

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538785#comment-16538785 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- The patch already has modified

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538987#comment-16538987 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- [~ljain], I like to clarify: # do you think that

[jira] [Comment Edited] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538987#comment-16538987 ] Tsz Wo Nicholas Sze edited comment on RATIS-252 at 7/10/18 5:25 PM:

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538867#comment-16538867 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- > ... Then we can check for the replies in

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539501#comment-16539501 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- Thanks for reviewing and committing RATIS-252. 

[jira] [Commented] (RATIS-252) Add API to state machine for determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535040#comment-16535040 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- Hey [~ljain], your last comment has inspired me to

[jira] [Updated] (RATIS-266) Log Exception thrown during applyTransaction & writeStateMachineData

[ https://issues.apache.org/jira/browse/RATIS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-266: -- Priority: Minor (was: Major) Issue Type: Improvement (was: Bug) > Log Exception

[jira] [Commented] (RATIS-266) Log Exception thrown during applyTransaction & writeStateMachineData

[ https://issues.apache.org/jira/browse/RATIS-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536010#comment-16536010 ] Tsz Wo Nicholas Sze commented on RATIS-266: --- +1 patch looks good. > Log Exception thrown during

[jira] [Commented] (RATIS-267) Add a unique identifier for a ratis ring during initialization/add peers to identify a unique ratis ring

[ https://issues.apache.org/jira/browse/RATIS-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536011#comment-16536011 ] Tsz Wo Nicholas Sze commented on RATIS-267: --- Would it be okay if we use a hash of the ring? >

[jira] [Updated] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: (was: r252_20180705.patch) > Add an API for state machine to

[jira] [Updated] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Summary: Add an API for state machine to determining server role (was: Add API to

[jira] [Updated] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-252: -- Attachment: r252_20180709.patch > Add an API for state machine to determining server

[jira] [Commented] (RATIS-252) Add an API for state machine to determining server role

[ https://issues.apache.org/jira/browse/RATIS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536805#comment-16536805 ] Tsz Wo Nicholas Sze commented on RATIS-252: --- r252_20180709.patch: initializes server role to

[jira] [Updated] (RATIS-259) Ratis waits infinitely with no timout when not able to connect to ozone datanode

[ https://issues.apache.org/jira/browse/RATIS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-259: -- Priority: Major (was: Critical) Issue Type: Improvement (was: Bug) Let's change

[jira] [Updated] (RATIS-263) Deadlock in ratis because of leader election

[ https://issues.apache.org/jira/browse/RATIS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-263: -- Priority: Critical (was: Major) Good catch. Let's change the priority to critical. >

[jira] [Commented] (RATIS-263) Deadlock in ratis because of leader election

[ https://issues.apache.org/jira/browse/RATIS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536653#comment-16536653 ] Tsz Wo Nicholas Sze commented on RATIS-263: --- BTW, this seems to duplicate RATIS-159. > Deadlock

[jira] [Commented] (RATIS-263) Deadlock in ratis because of leader election

[ https://issues.apache.org/jira/browse/RATIS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536652#comment-16536652 ] Tsz Wo Nicholas Sze commented on RATIS-263: --- It seems that we can safely remove "synchronized"

[jira] [Commented] (RATIS-260) Ratis Leader election should try for other peers even when ask for votes fails

[ https://issues.apache.org/jira/browse/RATIS-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536660#comment-16536660 ] Tsz Wo Nicholas Sze commented on RATIS-260: --- In stead of catching ExecutionException, it should

[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors

[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536636#comment-16536636 ] Tsz Wo Nicholas Sze commented on RATIS-265: --- We should limit the number of pending requests in

[jira] [Commented] (RATIS-260) Ratis Leader election should try for other peers even when ask for votes fails

[ https://issues.apache.org/jira/browse/RATIS-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536658#comment-16536658 ] Tsz Wo Nicholas Sze commented on RATIS-260: --- > This happens because of the following lines of

[jira] [Commented] (RATIS-268) Handle committed client requests on leader crash and shutdown

[ https://issues.apache.org/jira/browse/RATIS-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536639#comment-16536639 ] Tsz Wo Nicholas Sze commented on RATIS-268: --- A follower also maintains a retry cache and it will

[jira] [Commented] (RATIS-259) Ratis waits infinitely with no timout when not able to connect to ozone datanode

[ https://issues.apache.org/jira/browse/RATIS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536668#comment-16536668 ] Tsz Wo Nicholas Sze commented on RATIS-259: --- Currently, the ratis client only retries

[jira] [Updated] (RATIS-184) Document how to deploy the snapshot artifacts

[ https://issues.apache.org/jira/browse/RATIS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-184: -- Attachment: r184_20180123.patch > Document how to deploy the snapshot artifacts >

[jira] [Commented] (RATIS-184) Document how to deploy the snapshot artifacts

[ https://issues.apache.org/jira/browse/RATIS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336175#comment-16336175 ] Tsz Wo Nicholas Sze commented on RATIS-184: --- r184_20180123.patch: addresses Mukul's review

[jira] [Commented] (RATIS-184) Document how to deploy the snapshot artifacts

[ https://issues.apache.org/jira/browse/RATIS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336112#comment-16336112 ] Tsz Wo Nicholas Sze commented on RATIS-184: --- Thanks [~msingh] for reviewing and trying it out.

[jira] [Commented] (RATIS-209) StateMachine updater may miss writeLog Request after a new Leader is chosen.

[ https://issues.apache.org/jira/browse/RATIS-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388775#comment-16388775 ] Tsz Wo Nicholas Sze commented on RATIS-209: --- Hey [~msingh], this is a NPE in

[jira] [Updated] (RATIS-210) Refactor client request proto

[ https://issues.apache.org/jira/browse/RATIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-210: -- Attachment: r210_20180306.patch > Refactor client request proto >

[jira] [Commented] (RATIS-210) Refactor client request proto

[ https://issues.apache.org/jira/browse/RATIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388854#comment-16388854 ] Tsz Wo Nicholas Sze commented on RATIS-210: --- r210_20180306.patch: some more refactoring. >

[jira] [Commented] (RATIS-211) Include copyright notices required by a binary release

[ https://issues.apache.org/jira/browse/RATIS-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381167#comment-16381167 ] Tsz Wo Nicholas Sze commented on RATIS-211: --- - There is already a SLF4J section in LICENSE.txt. 

[jira] [Created] (RATIS-213) Typo: ServerInformatonRequest

Tsz Wo Nicholas Sze created RATIS-213: - Summary: Typo: ServerInformatonRequest Key: RATIS-213 URL: https://issues.apache.org/jira/browse/RATIS-213 Project: Ratis Issue Type: Bug

[jira] [Updated] (RATIS-210) Refactor client request proto

[ https://issues.apache.org/jira/browse/RATIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-210: -- Attachment: (was: r210_20180224.patch) > Refactor client request proto >

[jira] [Updated] (RATIS-210) Refactor client request proto

[ https://issues.apache.org/jira/browse/RATIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-210: -- Attachment: r210_20180315.patch > Refactor client request proto >

[jira] [Commented] (RATIS-210) Refactor client request proto

[ https://issues.apache.org/jira/browse/RATIS-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401045#comment-16401045 ] Tsz Wo Nicholas Sze commented on RATIS-210: --- Thanks for the review Mukul. For #1, I tried to add

[jira] [Commented] (RATIS-217) Support timeout for append entry requests(GrpcLogAppender)

[ https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429199#comment-16429199 ] Tsz Wo Nicholas Sze commented on RATIS-217: --- Thanks for the update. A few more nites: - In

[jira] [Commented] (RATIS-217) Support timeout for append entry requests(GrpcLogAppender)

[ https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428180#comment-16428180 ] Tsz Wo Nicholas Sze commented on RATIS-217: --- - If callId == -1, wrapException(..) won't put it to

[jira] [Commented] (RATIS-217) Support timeout for append entry requests(GrpcLogAppender)

[ https://issues.apache.org/jira/browse/RATIS-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429367#comment-16429367 ] Tsz Wo Nicholas Sze commented on RATIS-217: --- +1 the 005 patch looks good. No sure why Jenkins

[jira] [Commented] (RATIS-208) Allow client to specify replication level in a request

[ https://issues.apache.org/jira/browse/RATIS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432074#comment-16432074 ] Tsz Wo Nicholas Sze commented on RATIS-208: --- +1 the r208_20180410b.patch looks good. > Allow

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: r224_20180410b.patch > In RpcTimeout, it should shut down the scheduler if

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: (was: r224_20180410.patch) > In RpcTimeout, it should shut down the

[jira] [Commented] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432088#comment-16432088 ] Tsz Wo Nicholas Sze commented on RATIS-224: --- Thanks Lokesh for reviewing the patch. Here is a

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: r224_20180409.patch > In RpcTimeout, it should shut down the scheduler if

[jira] [Commented] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430644#comment-16430644 ] Tsz Wo Nicholas Sze commented on RATIS-224: --- r224_20180409.patch: first patch. Will add some

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: r224_20180411.patch > In RpcTimeout, it should shut down the scheduler if

[jira] [Commented] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433099#comment-16433099 ] Tsz Wo Nicholas Sze commented on RATIS-224: --- r224_20180411.patch: fixes a bug that the shutdown

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: (was: r224_20180410b.patch) > In RpcTimeout, it should shut down the

[jira] [Commented] (RATIS-208) Allow client to specify replication level in a request

[ https://issues.apache.org/jira/browse/RATIS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425340#comment-16425340 ] Tsz Wo Nicholas Sze commented on RATIS-208: --- Thanks Kit for working on this. Let's also try

[jira] [Commented] (RATIS-219) Add configuration for timeout duration

[ https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434375#comment-16434375 ] Tsz Wo Nicholas Sze commented on RATIS-219: --- Thanks. Some nites - requestTimeoutDuration in

[jira] [Commented] (RATIS-219) Add configuration for timeout duration

[ https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435260#comment-16435260 ] Tsz Wo Nicholas Sze commented on RATIS-219: --- +1 the 003 patch looks good. > Add configuration

[jira] [Commented] (RATIS-225) Grpc LogAppender should update next index on heartbeat reply

[ https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435316#comment-16435316 ] Tsz Wo Nicholas Sze commented on RATIS-225: --- > ... This happens because append entry reply might

[jira] [Commented] (RATIS-225) Grpc LogAppender should update next index on heartbeat reply

[ https://issues.apache.org/jira/browse/RATIS-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437540#comment-16437540 ] Tsz Wo Nicholas Sze commented on RATIS-225: --- +1 the 003 patch looks good. > Grpc LogAppender

[jira] [Commented] (RATIS-219) Add configuration for timeout duration

[ https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430973#comment-16430973 ] Tsz Wo Nicholas Sze commented on RATIS-219: --- One quick comment: - In GRpcLogAppender, read the

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: (was: r224_20180409.patch) > In RpcTimeout, it should shut down the

[jira] [Updated] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-224: -- Attachment: r224_20180410.patch > In RpcTimeout, it should shut down the scheduler if

[jira] [Commented] (RATIS-224) In RpcTimeout, it should shut down the scheduler if there is no tasks

[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430963#comment-16430963 ] Tsz Wo Nicholas Sze commented on RATIS-224: --- r224_20180410.patch: does some refactoring and adds

[jira] [Updated] (RATIS-208) Allow client to specify replication level in a request

[ https://issues.apache.org/jira/browse/RATIS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-208: -- Attachment: (was: r208_20180403.patch) > Allow client to specify replication level

[jira] [Commented] (RATIS-208) Allow client to specify replication level in a request

[ https://issues.apache.org/jira/browse/RATIS-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431644#comment-16431644 ] Tsz Wo Nicholas Sze commented on RATIS-208: --- Thanks for adding the new test.  A minor comment: -

<    4   5   6   7   8   9   10   11   12   13   >