[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1357
  
@SolidWallOfCode Ping? Also, seems this needs to be rebased now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[maskit]

Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
@shenzhang920 This should be fixed on master too, right? If there's the 
same issue on master, we should fix it on master first, and then we can 
cherry-pick the commit for 6.2.x.
Could you make another pull-request for master? Sorry, I should have asked 
earlier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/50/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
You can ignore the clang-analyzer build failures, since 6.2.x branch is 
busted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1299#discussion_r99958838
  
--- Diff: proxy/http/HttpTransact.cc ---
@@ -775,15 +775,15 @@ HttpTransact::EndRemapRequest(State *s)
   // We must close this connection if client_connection_enabled == false //
   /
   if (!s->client_connection_enabled) {
-build_error_response(s, HTTP_STATUS_FORBIDDEN, "Access Denied", 
"access#denied", nullptr);
+build_error_response(s, HTTP_STATUS_FORBIDDEN, "Access Denied", 
"access#denied");
 s->reverse_proxy = false;
 goto done;
   }
   /
   // Check if remap plugin set HTTP return code and return body  //
   /
   if (s->http_return_code != HTTP_STATUS_NONE) {
-build_error_response(s, s->http_return_code, nullptr, nullptr, 
s->internal_msg_buffer_size ? s->internal_msg_buffer : nullptr);
+build_error_response(s, s->http_return_code, nullptr, nullptr);
--- End diff --

What happened to `internal_msg_buffer`? Can that no longer be set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1379/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1486/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/49/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1485/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1378/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are a...

[jablko]

Github user jablko closed the pull request at:

https://github.com/apache/trafficserver/pull/1392


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/48/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1484/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1377/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1381: Lib Scalar

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1381
  
This still has 

1) clang-format issues

2) Compile issues:

```
In file included from ../../../lib/ts/test_Scalar.cc:24:
/var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:68:34: 
error: member reference base type 'S *' (aka 'Scalar *') is not a 
structure or union
return static_cast(this).operator+=(static_cast(n));
   ~~^~~
/var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:74:34: 
error: member reference base type 'S *' (aka 'Scalar *') is not a 
structure or union
return static_cast(this).operator-=(static_cast(n));
   ~~^~~
/var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:80:34: 
error: member reference base type 'S *' (aka 'Scalar *') is not a 
structure or union
return static_cast(this).operator*=(static_cast(n));
   ~~^~~
/var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:86:34: 
error: member reference base type 'S *' (aka 'Scalar *') is not a 
structure or union
return static_cast(this).operator/=(static_cast(n));
   ~~^~~
/var/jenkins/workspace/freebsd-github/src/BUILD/../lib/ts/Scalar.h:912:57: 
error: default initialization of an object of const type 'const 
ApacheTrafficServer::detail::tag_label_B' requires a user-provided default 
constructor
  static ApacheTrafficServer::detail::tag_label_B const b;
```

Also, probably want to rebase again, it's been a while so the list of 
changes is long ;).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1422: YTS-614: Avoid crash due to error during POST req...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1422
  
@SolidWallOfCode Is this something you feel comfortable with, and should be 
a 7.1.x back port?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1420: Improve error message for custom log field...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1420#discussion_r99900589
  
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -615,10 +618,14 @@ LogBuffer::resolve_custom_entry(LogFieldList 
*fieldlist, char *printf_str, char
 }
 
 bytes_written += res;
-field = fieldlist->next(field);
+lastField = field;
+field = fieldlist->next(field);
   } else {
 Note("There are more field markers than fields;"
- " cannot process log entry");
+ " cannot process log entry '%.*s'. Last field = '%s' 
printf_str='%s' pos=%d/%d count=%d alt_printf_str='%s'",
+ bytes_written, write_to, lastField == nullptr ? "*" : 
lastField->symbol(),
--- End diff --

Hmmm, maybe it's completely unrealistic, but couldn't lastField be NULL 
here ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1381: Lib Scalar

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1381
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/47/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1381: Lib Scalar

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1381
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1483/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1381: Lib Scalar

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1381
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1376/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[jablko]

Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99888612
  
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
 AC_MSG_RESULT([$enable_fast_sdk])
 TS_ARG_ENABLE_VAR([use], [fast-sdk])
 
+# Curl support for traffic_top
+AC_MSG_CHECKING([whether to enable CURL])
+AC_ARG_ENABLE([curl],
+  [AS_HELP_STRING([--disable-curl],[turn off CURL support for 
traffic_top])],
+  [],
+  [enable_curl=yes]
+)
+AC_MSG_RESULT([$enable_curl])
+
+if test "x${enable_curl}" = "xyes"; then
+AX_LIB_CURL([7.19], [has_curl=1],[has_curl=0])
+AM_CONDITIONAL([HAS_CURL], [test "x$has_curl" = "xyes"])
+else
+AM_CONDITIONAL([HAS_CURL], [false])
+fi
--- End diff --

Cool, glad it worked! I'm not sure why you were getting that error ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1398: Configure option to disable CURL

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1398
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/46/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1398: Configure option to disable CURL

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1398
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1482/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1398: Configure option to disable CURL

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1398
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1375/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99880264
  
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
 AC_MSG_RESULT([$enable_fast_sdk])
 TS_ARG_ENABLE_VAR([use], [fast-sdk])
 
+# Curl support for traffic_top
+AC_MSG_CHECKING([whether to enable CURL])
+AC_ARG_ENABLE([curl],
+  [AS_HELP_STRING([--disable-curl],[turn off CURL support for 
traffic_top])],
+  [],
+  [enable_curl=yes]
+)
+AC_MSG_RESULT([$enable_curl])
+
+if test "x${enable_curl}" = "xyes"; then
+AX_LIB_CURL([7.19], [has_curl=1],[has_curl=0])
+AM_CONDITIONAL([HAS_CURL], [test "x$has_curl" = "xyes"])
+else
+AM_CONDITIONAL([HAS_CURL], [false])
+fi
--- End diff --

Yes, that worked.  I tried replacing lines 233 to 234 with using the 
AC_DEFINE yesterday and I was getting:
configure: error: conditional "HAS_CURL" was never defined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[jablko]

Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99878821
  
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
 
 # We only build traffic_top if libcurses and libcurl are available.
 if BUILD_TRAFFIC_TOP
-
 AM_CPPFLAGS = \
   $(iocore_include_dirs) \
   -I$(abs_top_srcdir)/lib \
   -I$(abs_top_srcdir)/mgmt/api/include \
   @CURL_CFLAGS@ \
   @CURSES_CFLAGS@
+endif
--- End diff --

Ah, cool. I see what happened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99876962
  
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
 
 # We only build traffic_top if libcurses and libcurl are available.
 if BUILD_TRAFFIC_TOP
-
 AM_CPPFLAGS = \
   $(iocore_include_dirs) \
   -I$(abs_top_srcdir)/lib \
   -I$(abs_top_srcdir)/mgmt/api/include \
   @CURL_CFLAGS@ \
   @CURSES_CFLAGS@
+endif
--- End diff --

Yes, when I added it back in I put it in the wrong place.  I will move it 
and make sure it works like it is supposed to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[jablko]

Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99866474
  
--- Diff: configure.ac ---
@@ -220,6 +220,22 @@ AC_ARG_ENABLE([fast-sdk],
 AC_MSG_RESULT([$enable_fast_sdk])
 TS_ARG_ENABLE_VAR([use], [fast-sdk])
 
+# Curl support for traffic_top
+AC_MSG_CHECKING([whether to enable CURL])
+AC_ARG_ENABLE([curl],
+  [AS_HELP_STRING([--disable-curl],[turn off CURL support for 
traffic_top])],
+  [],
+  [enable_curl=yes]
+)
+AC_MSG_RESULT([$enable_curl])
+
+if test "x${enable_curl}" = "xyes"; then
+AX_LIB_CURL([7.19], [has_curl=1],[has_curl=0])
+AM_CONDITIONAL([HAS_CURL], [test "x$has_curl" = "xyes"])
+else
+AM_CONDITIONAL([HAS_CURL], [false])
+fi
--- End diff --

I haven't yet tested this with/without libcurl installed, but I assume that 
here, you need to use AC_DEFINE vs. AM_CONDITIONAL, because HAS_CURL is a 
preprocessor macro? As it stands, I expect HAS_CURL will be undefined, whether 
libcurl is installed/enabled or not. If so, I'd replace lines 233-236 with the 
following line:

```M4Sugar
AX_LIB_CURL([7.19], [AC_DEFINE([HAS_CURL], [1], [Define if libcurl >= 
7.19.])])
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1398: Configure option to disable CURL

[jablko]

Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1398#discussion_r99871965
  
--- Diff: cmd/traffic_top/Makefile.am ---
@@ -17,13 +17,13 @@
 
 # We only build traffic_top if libcurses and libcurl are available.
 if BUILD_TRAFFIC_TOP
-
 AM_CPPFLAGS = \
   $(iocore_include_dirs) \
   -I$(abs_top_srcdir)/lib \
   -I$(abs_top_srcdir)/mgmt/api/include \
   @CURL_CFLAGS@ \
   @CURSES_CFLAGS@
+endif
--- End diff --

I assume this change will cause build failure if curses isn't installed, 
because bin_PROGRAMS = traffic_top etc. are outside the BUILD_TRAFFIC_TOP 
conditional? If so, I think you can drop this file from the PR (git checkout 
master cmd/traffic_top/Makefile.am).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1392
  
@zwoop Yes -- I'm happy to make any changes, but I think it's ready to 
land. If you approve, I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

[shenzhang920]

Github user shenzhang920 commented on the issue:

https://github.com/apache/trafficserver/pull/1415
  
@maskit I made another commit to fix the clang failure, can you trigger the 
build again?  Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---