[GitHub] trafficserver issue #1475: ASAN issue in traffic_manager metrics Lua binding...

2017-02-20 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1475 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1475: ASAN issue in traffic_manager metrics Lua binding...

2017-02-20 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1475 ASAN issue in traffic_manager metrics Lua bindings ``` root@qa1 616/1 # /opt/ats/bin/traffic_manager [E. Mgmt] log ==> [TrafficManager] using root directory '/opt/

[GitHub] trafficserver pull request #1466: Fixes the type for a few overridables

2017-02-19 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1466 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1466: Fixes the type for a few overridables

2017-02-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1466 Good idea. @jpeach Can you either file an Issue or a PR with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1474: Leak detections when running ASAN on Docs/CI

2017-02-19 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1474 Leak detections when running ASAN on Docs/CI It's likely that many (most?) of these are FPs, and can be avoided with proper exit cleanups. ``` root@qa1 376/0 # ASAN_OPTIONS

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-19 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 This introduced a new Coverity issues: ``` *** CID 1371483: Error handling issues (CHECKED_RETURN) /lib/ts/signals.cc: 173 in signal_format_siginfo(int, siginfo_t *, const

[GitHub] trafficserver pull request #1457: fix TS-4195: crash when stop trafficserver

2017-02-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1457 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 I've tested this with leak detection, and it seems to still work (it reports quite a few leaks). So I'm going to land this :). --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #1455: Set nullptr to ua_session after it is destoryed

2017-02-18 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1455 I cherry-picked this to 7.1.x, so no need to make an additional PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1455: Set nullptr to ua_session after it is dest...

2017-02-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1455 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1467: Adds the OpenSSL license

2017-02-18 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1467 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1467: Adds the OpenSSL license

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1467 @jablko Did any of this OpenSSL code go into 7.1.x? If so, we need this change there as well. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1467: Adds the OpenSSL license

2017-02-17 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1467 Adds the OpenSSL license I believe since we copied the BIO function from OpenSSL, we must include the OpenSSL license as well. I removed the NOTICE thing, since the copyright attribution can

[GitHub] trafficserver issue #1465: Add new testing system to the test subdirectory

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1465 MIT is fine. You should retain the MIT header in any imported source, and also update the NOTICE file accordingly. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1362: If setrlimit() fails, log the details

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1362 Somewhat mixed feelings on this. If someone has requests some particular "limit" and that fails, I'd be concerned that we'd start up in a crippled state. Meaning, I feel it bett

[GitHub] trafficserver issue #1444: issue #1401: Potential fix to the write_to_io_net...

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1444 Fwiw, the fix here (like it or not) prevents the segfaults on docs / Ci. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1442: Doc: Add an example of disabled HTTP/2 ove...

2017-02-17 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1442 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Also, I'm gonna mark this for v7.1.0, because I've experienced these crashers myself, and they are super annoying. --- If your project is set up for it, you can reply to this email and have

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Did we address @jpeach concern re: memory leak debugging? Also, probably would be a good idea if @bryancall chimed in here, since he did a lot of the work around making ASAN etc. function

[GitHub] trafficserver pull request #1466: Fixes the type for a few overridables

2017-02-17 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1466 Fixes the type for a few overridables These are all MgmtByte, so should not use the INT type here. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...

2017-02-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1464#discussion_r101878882 --- Diff: proxy/http/HttpConfig.h --- @@ -563,6 +564,7 @@ struct OverridableHttpConfigParams { // hostdb/dns variables

[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...

2017-02-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1464#discussion_r101878798 --- Diff: proxy/InkAPI.cc --- @@ -8153,6 +8153,10 @@ _conf_to_memberp(TSOverridableConfigKey conf, OverridableHttpConfigParams *overr typ

[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...

2017-02-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1464#discussion_r101804057 --- Diff: mgmt/RecordsConfig.cc --- @@ -518,6 +518,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...

2017-02-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1464#discussion_r101803943 --- Diff: proxy/http/HttpConfig.cc --- @@ -1255,6 +1257,7 @@ HttpConfig::reconfigure() params->oride.parent_connect_attem

[GitHub] trafficserver pull request #1464: TS-4747: make marking parent proxies down ...

2017-02-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1464#discussion_r101803592 --- Diff: mgmt/RecordsConfig.cc --- @@ -518,6 +518,8 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Ah, that fails because you don't have the fixes I made on master. All you have to do is rebase your branch with current master, and push again. --- If your project is set up for it, you can

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 Yeh, this failed because the Intel installation was not correct on one of the VMs. [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1461: Changes debug builds with Intel to just -g

2017-02-16 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1461 Changes debug builds with Intel to just -g This gets rid of debug build warnings with Intel compilers. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1456 Hmmm, how is this different from proxy.process.http.total_incoming_connections ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 @zizhong No need to apologize, this is exactly why we have a CI / build system. :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1460: Removes some unnecessary dependencies on t...

2017-02-16 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1460 Removes some unnecessary dependencies on the public ts/ts.h This also removes the proxy/api/ts directory from all default search paths, to make it more difficult to introduce more bad

[GitHub] trafficserver pull request #1450: Update to latest RAT version

2017-02-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1458: Removed spaces at the end of the line on all file...

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1458 Testing new ICC builds [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

2017-02-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1457 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101584542 --- Diff: lib/ts/signals.cc --- @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) sigact = (void

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101558553 --- Diff: lib/ts/signals.cc --- @@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler) sigact = (void

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-16 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1451#discussion_r101558075 --- Diff: iocore/eventsystem/P_IOBuffer.h --- @@ -694,6 +695,7 @@ TS_INLINE char ::operator[](int64_t i) } ink_release_assert(!&quo

[GitHub] trafficserver issue #1454: Updates to the help output for tsxs

2017-02-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1454 Not sure why the FreeBSD build failed, but rebooting the build VMs now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...

2017-02-15 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1451 Cleans up ICC options, and some build issues This removes a number of the previous warning exclusions that we we used to do. We then also have to clean up the core code in a few places

[GitHub] trafficserver pull request #1449: MemView: Fix coverity issues, constexpr co...

2017-02-15 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1449 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1447: Added some basic contributing guidelines

2017-02-15 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1447 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1447: Added some basic contributing guidelines

2017-02-15 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1447#discussion_r101343473 --- Diff: CONTRIBUTING.md --- @@ -1,2 +1,68 @@ Contributing to Apache Traffic Server += + +All

[GitHub] trafficserver pull request #1450: Update to latest RAT version

2017-02-15 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1450 Update to latest RAT version You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver RAT Alternatively you can review

[GitHub] trafficserver issue #1449: MemView: Fix coverity issues, constexpr correctne...

2017-02-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1449 One more build for good measure [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1447: Added some basic contributing guidelines

2017-02-14 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1447 Added some basic contributing guidelines You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver Contributing Alternatively

[GitHub] trafficserver issue #1445: Issue #1443 - Fix early or duplicate 404 error ha...

2017-02-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1445 What are the symptoms of this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request #1441: Mark the new span metrics as gauges in Epi...

2017-02-13 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1441 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1441: Mark the new span metrics as gauges in Epi...

2017-02-13 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1441 Mark the new span metrics as gauges in Epic plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver EpicSpanMetrics

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-10 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1332 Meh, I didn't mean to approve it, obviously the merge conflicts and build failures and the missing license must be fixed. --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1332: Updates to cache documentation and Cache T...

2017-02-10 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1332#discussion_r100659100 --- Diff: tools/Makefile.am --- @@ -17,6 +17,9 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] trafficserver pull request #1332: Updates to cache documentation and Cache T...

2017-02-10 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1332#discussion_r100659033 --- Diff: lib/ts/MemView.cc --- @@ -0,0 +1,126 @@ +#include --- End diff -- This file is missing the AL2 license. --- If your

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

2017-02-10 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1332 Hmmm, this is still failing builds, and doesn't merge cleanly to master :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1438: BoringSSL doesn't have BIO_sock_non_fatal_error()

2017-02-10 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1438 Did we add the necessary attribution to NOTICES files? If not, please do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request #1433: Get the list of files from Autoconf vs. Gi...

2017-02-09 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1433#discussion_r100366287 --- Diff: configure.ac --- @@ -1937,6 +1939,9 @@ AC_CONFIG_FILES([ tools/tsxs ]) +AC_CONFIG_FILES([tools/check-unused

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

2017-02-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1415 Oh yeah, if this is not a back port from master, then this should be changed / closed, and replaced with a PR against master. We always commit on master, and then suggest back ports to the RMs

[GitHub] trafficserver issue #1335: Deadlock in HostDB

2017-02-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1335 @randall reports that this happens with sync off as well :-/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-02-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode Ping? Also, seems this needs to be rebased now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

2017-02-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1415 You can ignore the clang-analyzer build failures, since 6.2.x branch is busted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1415: isuue #1399 add back partial code of tcp_congesti...

2017-02-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1415 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1381: Lib Scalar

2017-02-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1381 This still has 1) clang-format issues 2) Compile issues: ``` In file included from ../../../lib/ts/test_Scalar.cc:24: /var/jenkins/workspace/freebsd-github

[GitHub] trafficserver issue #1422: YTS-614: Avoid crash due to error during POST req...

2017-02-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1422 @SolidWallOfCode Is this something you feel comfortable with, and should be a 7.1.x back port? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #1420: Improve error message for custom log field...

2017-02-07 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1420#discussion_r99900589 --- Diff: proxy/logging/LogBuffer.cc --- @@ -615,10 +618,14 @@ LogBuffer::resolve_custom_entry(LogFieldList *fieldlist, char *printf_str, char

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-02-06 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1392 Should we land this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1421: Segmentation fault on TLS when destination server...

2017-02-06 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1421 @jacksontj Ping on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1421: Segmentation fault on TLS when destination server...

2017-02-06 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1421 Segmentation fault on TLS when destination server issues Reset Creating this issue, copying from the original Jira to capture all the details. On HEAD as of 16DEC2016

[GitHub] trafficserver pull request #1407: Fix potential spin loop in perl management...

2017-02-03 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1418: Consistently use ink_atoi() (or one of the equiva...

2017-02-03 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1418 Consistently use ink_atoi() (or one of the equivalent functions we provide) (This is moved from https://issues.apache.org/jira/browse/TS-1773). Right now, we have a hotchpotch of various

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

2017-02-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 Looks great. Two issues: 1) Run clang-format on it :). 2) On FreeBSD, it fails with ``` ../../plugins/experimental/ts_lua/ts_lua_http_config.c:244:53: error

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

2017-02-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-02 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1408#discussion_r99240250 --- Diff: iocore/cache/Cache.cc --- @@ -1041,12 +1041,12 @@ CacheProcessor::cacheInitialized() case CACHE_COMPRESSION_FASTLZ

[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

2017-02-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1401 Are you getting a core file / backtrace ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

2017-02-02 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1404#discussion_r99178025 --- Diff: proxy/http/HttpTransact.cc --- @@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request) bool

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

2017-02-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1404 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

2017-02-02 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1408#discussion_r99174413 --- Diff: iocore/cache/Cache.cc --- @@ -1041,12 +1041,12 @@ CacheProcessor::cacheInitialized() case CACHE_COMPRESSION_FASTLZ

[GitHub] trafficserver pull request #1409: Log crc field and psql field correctly wit...

2017-02-02 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1409 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1412: Assertion in HttpSM::tunnel_handler_post

2017-02-02 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1412 Assertion in HttpSM::tunnel_handler_post I think we've seen this before, but filing this again to make sure I don't lose the info: ``` (gdb) bt #0 0x74fed1d7

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1397 Hmmm, not sure, it is for me: ``` [root@fedora ats]# ldd bin/traffic_top | grep -i hwloc libhwloc.so.5 => /lib64/libhwloc.so.5 (0x7f29395a7000) ``` Tha

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @SolidWallOfCode Is this going to go in for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

2017-02-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1404#discussion_r98966326 --- Diff: proxy/http/HttpTransact.cc --- @@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr *incoming_request) bool

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1403 Closing, since we have a PR already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

2017-02-01 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1388 @jablko do we need two commits here? Or can they be squashed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1402: Crash in InactivityCop::check_inactivity with dea...

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1402 If possible, can you test with 7.0 or 7.1x (branch) and see if it happens there too ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1401 you didn't see this crasher in 7.0.0 right ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1388 [approve ci] to get the clang-analyzer build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1400: traffic_via depends on the PCRE library

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1400 Testing again [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1400: traffic_via depends on the PCRE library

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1400 Testing again [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1398: Configure option to disable CURL

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1398 Testing to see if clang-analyzer builds triggers [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1398: Configure option to disable CURL

2017-01-31 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1398 Testing to see if clang-analyzer builds triggers [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1397 Wonder if we should bother back porting these to 7.1.x ? Wdyt ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request #1396: check if any of client cert path or file i...

2017-01-30 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1396 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1396: check if any of client cert path or file is null

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1396 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1248: TS-5070 Add configuration variables to set file p...

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1248 For future references, this really should have been squashed down to one commit before merging. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1393: Trivial Autoconf cleanup

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1393 In fact, taking a quick look, tools like traffic_top is getting all the "optional" libraries, even though they are highly unlikely to use 'em? Like, libhwloc. --- If your project

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

2017-01-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1392 I suspect we might want to backport a fix for this to 7.1.x as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   8   9   >