[GitHub] sijie opened a new pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

sijie opened a new pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315 Descriptions of the changes in this PR: *Problem* Currently we allow fence requests going through

[GitHub] sijie commented on issue #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

sijie commented on issue #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#issuecomment-378521092 need to write tests. but just putting this up to get review comments. @merlimat -

[GitHub] sijie opened a new issue #1316: A bookie with non-writable dirs should be able to start in read-only mode

sijie opened a new issue #1316: A bookie with non-writable dirs should be able to start in read-only mode URL: https://github.com/apache/bookkeeper/issues/1316 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run bookkeeper outage tes

[GitHub] ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r179088671 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockBookKeepe

[GitHub] ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r179088648 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/impl/OpenBuil

[GitHub] ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly commented on a change in pull request #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#discussion_r179086371 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/impl/OpenBuil

[GitHub] ivankelly commented on issue #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

ivankelly commented on issue #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#issuecomment-378550645 @jvrao > What is mockBookKeeper? A mock implementation of the bookkeeper client, that can be used fo

Jenkins build is still unstable: bookkeeper_release_branch #109

See

[GitHub] merlimat commented on a change in pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

merlimat commented on a change in pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#discussion_r179194794 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeepe

[GitHub] merlimat commented on a change in pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

merlimat commented on a change in pull request #1315: (WIP) Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#discussion_r179194064 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeepe

[GitHub] sijie commented on issue #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper

sijie commented on issue #1298: newOpenLedgerOp and ReadHandle implementation for MockBookKeeper URL: https://github.com/apache/bookkeeper/pull/1298#issuecomment-378688775 there are findbugs errors need to be fixed This is an

[GitHub] sijie commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s

sijie commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s URL: https://github.com/apache/bookkeeper/pull/1311#issuecomment-378688928 @reddycharan can you rebase your branch? This is an autom

[GitHub] sijie commented on a change in pull request #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

sijie commented on a change in pull request #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#discussion_r179287067 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/

[GitHub] sijie commented on a change in pull request #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

sijie commented on a change in pull request #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#discussion_r179287085 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/

[GitHub] sijie commented on issue #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies

sijie commented on issue #1315: Issue 1314: Provide a mechanism to allow high priority writes to readonly bookies URL: https://github.com/apache/bookkeeper/pull/1315#issuecomment-378749645 added test cases and also addressed @merlimat 's comments. this PR is ready for review now. --

[GitHub] reddycharan commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s

reddycharan commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s URL: https://github.com/apache/bookkeeper/pull/1311#issuecomment-378757248 rebased it. This is an automated message from the A

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179289148 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -83,18 +

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179290902 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -116,21

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179290558 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -83,18 +

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179290810 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -116,21

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179292220 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java ## @@ -10

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179293507 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -393,12

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179294075 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -802,88

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179294437 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r179294923 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java ## @@ -10

[GitHub] sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation

sijie commented on issue #80: BOOKKEEPER-816: use native fallocate to improve journal allocation URL: https://github.com/apache/bookkeeper/pull/80#issuecomment-378786764 deferring this to 4.8.0. since it has different packing story than NAR. since we are including circe-checksum in 4.7.0 u

[GitHub] jvrao commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s

jvrao commented on issue #1311: Issue #1310: Filter out body and masterKey from ProcessorV3s URL: https://github.com/apache/bookkeeper/pull/1311#issuecomment-378819927 +1 LGTM This is an automated message from the Apache Git