[GitHub] flink issue #4335: [FLINK-7192] Activate checkstyle flink-java/test/operator

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4335 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099762#comment-16099762 ] ASF GitHub Bot commented on FLINK-7190: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-5987) Upgrade zookeeper dependency to 3.4.10

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099763#comment-16099763 ] ASF GitHub Bot commented on FLINK-5987: --- Github user zentol commented on the issue:

[GitHub] flink issue #4319: [FLINK-5987] [build] Upgrade zookeeper dependency to 3.4....

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4319 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4343: [FLINK-7190] Activate checkstyle flink-java/*

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4343 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4293: [FLINK-7141][build] enable travis cache again

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4293 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-7141) enable travis cache again

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099764#comment-16099764 ] ASF GitHub Bot commented on FLINK-7141: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129266693 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java --- @@ -18,20 +18,40 @@ package

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099835#comment-16099835 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099881#comment-16099881 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099873#comment-16099873 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099879#comment-16099879 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129272281 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateSnapshot.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129277176 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -867,81 +845,60 @@ public String toString() {

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099876#comment-16099876 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129278519 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorSubtaskState.java --- @@ -18,20 +18,43 @@ package

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129274874 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointStateRestoreTest.java --- @@ -118,10 +118,22 @@ public void

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099880#comment-16099880 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129269706 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/RoundRobinOperatorStateRepartitioner.java --- @@ -89,6 +89,10 @@ private

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129274620 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java --- @@ -3631,16 +3673,16 @@ public void

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099878#comment-16099878 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129272254 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateSnapshot.java --- @@ -0,0 +1,137 @@ +/* + * Licensed to the

[GitHub] flink pull request #4353: [FLINK-7213] Introduce state management by Operato...

2017-07-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4353#discussion_r129275823 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java --- @@ -208,13 +208,13 @@ public

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099877#comment-16099877 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099874#comment-16099874 ] ASF GitHub Bot commented on FLINK-7213: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #4385: wrong parameter check

2017-07-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4385 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Closed] (FLINK-7228) Harden HistoryServerStaticFileHandlerTest

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7228. --- Resolution: Fixed 1.3: e3e71052efc33e384c916b9960077b21cd2b9ee3 1.4:

[jira] [Commented] (FLINK-7213) Introduce state management by OperatorID in TaskManager

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099827#comment-16099827 ] ASF GitHub Bot commented on FLINK-7213: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Created] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-07-25 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7260: - Summary: Match not exhaustive in WindowJoinUtil.scala Key: FLINK-7260 URL: https://issues.apache.org/jira/browse/FLINK-7260 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-7262) remove unused FallbackLibraryCacheManager

2017-07-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7262: -- Summary: remove unused FallbackLibraryCacheManager Key: FLINK-7262 URL: https://issues.apache.org/jira/browse/FLINK-7262 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-5987) Upgrade zookeeper dependency to 3.4.10

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099886#comment-16099886 ] ASF GitHub Bot commented on FLINK-5987: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7255) ListStateDescriptor example uses wrong constructor

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099889#comment-16099889 ] ASF GitHub Bot commented on FLINK-7255: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7256) End-to-end tests should only be run after successful compilation

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7256. --- Resolution: Fixed 1.4: e5dad7fc8b9a15c667fe8cd31c65a3ed78868612 > End-to-end tests should

[jira] [Closed] (FLINK-7255) ListStateDescriptor example uses wrong constructor

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7255. --- Resolution: Fixed 1.3: 0c9bee69665e00ab17fe0a216c746b0bc8435263 1.4:

[GitHub] flink pull request #4389: [FLINK-7255] [docs] Remove default value from List...

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4293: [FLINK-7141][build] enable travis cache again

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4343: [FLINK-7190] Activate checkstyle flink-java/*

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7256) End-to-end tests should only be run after successful compilation

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099888#comment-16099888 ] ASF GitHub Bot commented on FLINK-7256: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7190. --- Resolution: Fixed 1.4: 8624c2904f2840b901e805f1e0b33b6977e581ca > Activate checkstyle

[jira] [Commented] (FLINK-7190) Activate checkstyle flink-java/*

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099887#comment-16099887 ] ASF GitHub Bot commented on FLINK-7190: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7141) enable travis cache again

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099885#comment-16099885 ] ASF GitHub Bot commented on FLINK-7141: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4319: [FLINK-5987] [build] Upgrade zookeeper dependency ...

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4385: wrong parameter check

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4390: [FLINK-7256] [travis] Only run end-to-end tests if...

2017-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7199) Graph simplification does not set parallelism

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099914#comment-16099914 ] ASF GitHub Bot commented on FLINK-7199: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r129263762 --- Diff: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/GreedyITCase.java --- @@ -0,0 +1,290 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099829#comment-16099829 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dawidwys commented on a diff in the pull

[jira] [Updated] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-07-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7260: -- Description: Here is the warning: {code} [WARNING]

[jira] [Updated] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-07-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7260: -- Description: Here is the warning: {code} [WARNING]

[GitHub] flink pull request #4346: [FLINK-7199] [gelly] Graph simplification does not...

2017-07-25 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4346#discussion_r129282059 --- Diff: flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/InputBase.java --- @@ -32,6 +35,9 @@ extends

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-07-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r129237531 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java --- @@ -1869,13 +1869,23 @@ private RexNode

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-07-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r129239292 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/time.scala --- @@ -355,26 +355,36 @@ case class TemporalOverlaps(

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099711#comment-16099711 ] ASF GitHub Bot commented on FLINK-6429: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099710#comment-16099710 ] ASF GitHub Bot commented on FLINK-6429: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099708#comment-16099708 ] ASF GitHub Bot commented on FLINK-6429: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #4392: [FLINK-7226] [webUI] Properly include UTF-8 in con...

2017-07-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4392 [FLINK-7226] [webUI] Properly include UTF-8 in content-type header This PR corrects the `content-encoding` header introduced in FLINK-5705. As documented

[jira] [Resolved] (FLINK-7187) Activate checkstyle flink-java/sca

2017-07-25 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-7187. - Resolution: Fixed Fix Version/s: 1.4.0 > Activate checkstyle flink-java/sca >

[jira] [Commented] (FLINK-7254) java8 module pom disables checkstyle

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099897#comment-16099897 ] ASF GitHub Bot commented on FLINK-7254: --- Github user dawidwys commented on the issue:

[jira] [Resolved] (FLINK-7181) Activate checkstyle flink-java/operators/*

2017-07-25 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-7181. - Resolution: Fixed Fix Version/s: 1.4.0 > Activate checkstyle

[GitHub] flink issue #4383: [hotfix] [optimizer] Normalize job plan operator formatti...

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4383 I think i prefer the version without a space, but I may just be looking at it from a metrics perspective (yay, one less special character to deal with). --- If your project is set up for it, you can

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-07-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r129240196 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/CorrelateTest.scala --- @@ -43,7 +43,7 @@ class CorrelateTest

[GitHub] flink pull request #4373: [FLINK-6429] [table] Bump up Calcite version to 1....

2017-07-25 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4373#discussion_r129237304 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java --- @@ -1039,7 +1039,7 @@ public boolean

[jira] [Commented] (FLINK-7192) Activate checkstyle flink-java/test/operator

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099707#comment-16099707 ] ASF GitHub Bot commented on FLINK-7192: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...

2017-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4335#discussion_r129242316 --- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java --- @@ -251,32 +254,42 @@ public CustomType

[jira] [Assigned] (FLINK-4565) Support for SQL IN operator

2017-07-25 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-4565: --- Assignee: Timo Walther > Support for SQL IN operator > --- > >

[jira] [Commented] (FLINK-6940) Clarify the effect of configuring per-job state backend

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099744#comment-16099744 ] ASF GitHub Bot commented on FLINK-6940: --- Github user zentol commented on the issue:

[GitHub] flink issue #4136: [FLINK-6940][docs] Clarify the effect of configuring per-...

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4136 will merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] flink issue #4390: [FLINK-7256] [travis] Only run end-to-end tests if no pre...

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4390 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4389: [FLINK-7255] [docs] Remove default value from ListStateDe...

2017-07-25 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4389 merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Created] (FLINK-7261) avoid unnecessary exceptions in the logs in non-HA cases

2017-07-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-7261: -- Summary: avoid unnecessary exceptions in the logs in non-HA cases Key: FLINK-7261 URL: https://issues.apache.org/jira/browse/FLINK-7261 Project: Flink Issue

[GitHub] flink issue #4394: [FLINK-7257] [runtime] Enable checkstyle for test files i...

2017-07-25 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4394 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-7257) Extend flink-runtime checkstyle coverage to tests

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099895#comment-16099895 ] ASF GitHub Bot commented on FLINK-7257: --- Github user dawidwys commented on the issue:

[jira] [Closed] (FLINK-7141) enable travis cache again

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7141. --- Resolution: Fixed Fix Version/s: 1.4.0 > enable travis cache again >

[jira] [Reopened] (FLINK-7141) enable travis cache again

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reopened FLINK-7141: - > enable travis cache again > - > > Key: FLINK-7141 >

[GitHub] flink issue #4393: [FLINK-7254] [java8] Properly activate checkstyle for fli...

2017-07-25 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4393 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Closed] (FLINK-5987) Upgrade zookeeper dependency to 3.4.10

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-5987. --- Resolution: Fixed Fix Version/s: 1.4.0 1.4: 87a1984b5ec93556406264d094b531c40a61aa6b

[jira] [Closed] (FLINK-7141) enable travis cache again

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7141. --- Resolution: Fixed 1.4: 5db492aafa07a45980856bde1eb71bd0dc658a36 > enable travis cache again

[jira] [Commented] (FLINK-6429) Bump up Calcite version to 1.13

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099709#comment-16099709 ] ASF GitHub Bot commented on FLINK-6429: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-7192) Activate checkstyle flink-java/test/operator

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099736#comment-16099736 ] ASF GitHub Bot commented on FLINK-7192: --- Github user zentol commented on the issue:

[jira] [Closed] (FLINK-6940) Clarify the effect of configuring per-job state backend

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-6940. --- Resolution: Fixed Fix Version/s: 1.3.2 1.3: c704adf0ddfb9d8196dd0efbb912ce544680082f

[jira] [Commented] (FLINK-7226) REST responses contain invalid content-encoding header

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099804#comment-16099804 ] ASF GitHub Bot commented on FLINK-7226: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-7254) java8 module pom disables checkstyle

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099807#comment-16099807 ] ASF GitHub Bot commented on FLINK-7254: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #4393: [FLINK-7254] [java8] Properly activate checkstyle ...

2017-07-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4393 [FLINK-7254] [java8] Properly activate checkstyle for flink-java8 This PR modifies the java8 pom to not disable checkstyle. A few changes had to be made to make the module checkstyle compliant. You

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099831#comment-16099831 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dawidwys commented on a diff in the pull

[jira] [Commented] (FLINK-7147) Support greedy quantifier in CEP

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099830#comment-16099830 ] ASF GitHub Bot commented on FLINK-7147: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r129262270 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Pattern.java --- @@ -492,4 +506,10 @@ private void

[GitHub] flink pull request #4296: [FLINK-7147] [cep] Support greedy quantifier in CE...

2017-07-25 Thread dawidwys
Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4296#discussion_r129261577 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/Quantifier.java --- @@ -105,6 +107,14 @@ public void optional() {

[jira] [Updated] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-07-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-7260: -- Component/s: Table API & SQL DataStream API > Match not exhaustive in

[jira] [Updated] (FLINK-7260) Match not exhaustive in WindowJoinUtil.scala

2017-07-25 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-7260: - Component/s: (was: DataStream API) > Match not exhaustive in WindowJoinUtil.scala >

[GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...

2017-07-25 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3829 Hi @lincoln-lil, I think it is a very good idea to strive for consistency with JDBC. Here is what I think about the proposed methods: - `sqlQuery(sql: String): Table`: Looks good to me -

[jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099824#comment-16099824 ] ASF GitHub Bot commented on FLINK-6442: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-7220) Update RocksDB dependency to 5.5.5

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099865#comment-16099865 ] ASF GitHub Bot commented on FLINK-7220: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #4360: [FLINK-7220] [checkpoints] Update RocksDB dependency to 5...

2017-07-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4360 Looks good, +1 with request for minor change: I would pull out the setting of the merge operator from the option factories. We should not allow users to override (or forget to set it),

[jira] [Commented] (FLINK-7258) IllegalArgumentException in Netty bootstrap with large memory state segment size

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099703#comment-16099703 ] ASF GitHub Bot commented on FLINK-7258: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #4390: [FLINK-7256] [travis] Only run end-to-end tests if no pre...

2017-07-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4390 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-7256) End-to-end tests should only be run after successful compilation

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099720#comment-16099720 ] ASF GitHub Bot commented on FLINK-7256: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-6940) Clarify the effect of configuring per-job state backend

2017-07-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099751#comment-16099751 ] ASF GitHub Bot commented on FLINK-6940: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-6940) Clarify the effect of configuring per-job state backend

2017-07-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6940: Affects Version/s: 1.4.0 > Clarify the effect of configuring per-job state backend >

[GitHub] flink issue #4374: repalce map.put with putIfAbsent

2017-07-25 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4374 Although this totally makes sense and would be nice to change, we cannot merge it until Java 7 has been dropped (as you see from the TravisCI runs). --- If your project is set up for it, you can

  1   2   3   >