[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143416#comment-16143416 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-08-28 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 @NicoK , thank you for giving this discussion and comments! Actually I proposed the same way of using fixed-size `LocalBufferPool` for managing exclusive buffers for per

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-08-28 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 For `ResultPartitionType` comment, I expand to add the 'isCreditBased' field temporarily in order not to affect the current process. My initial idea is to remove this field after the whole feature

[jira] [Commented] (FLINK-7410) Add getName method to UserDefinedFunction

2017-08-28 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143474#comment-16143474 ] Timo Walther commented on FLINK-7410: - No, the {{toString}} method is not used yet. We could use it

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143522#comment-16143522 ] Fabian Hueske commented on FLINK-6233: -- Thanks [~xccui], that would be great! :-) > Support rowtime

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143451#comment-16143451 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-7512) avoid unnecessary buffer copies during network serialization

2017-08-28 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143520#comment-16143520 ] Nico Kruber commented on FLINK-7512: Hi [~phoenixjiangnan], no, the error you are seeing is not

[jira] [Commented] (FLINK-7358) Add implicitly converts support for User-defined function

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143500#comment-16143500 ] ASF GitHub Bot commented on FLINK-7358: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4534: [FLINK-7358][table]Add implicitly converts support for Us...

2017-08-28 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4534 The text above `"What is the purpose of the change"` should be removed such that only the relevant info is in the PR description. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143517#comment-16143517 ] Fabian Hueske commented on FLINK-7446: -- I think that's a good plan [~jark]. However, we should

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143560#comment-16143560 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-08-28 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4485 Hi @zhijiangW, regarding the buffer pool implementation, I was just curious about why it was done that way. But it is fine to keep the logic in `RemoteInputChannel` if you make sure, that a

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-08-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r135480975 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java --- @@ -131,6 +133,50 @@ public void

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143556#comment-16143556 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-08-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143558#comment-16143558 ] Aljoscha Krettek commented on FLINK-7129: - I think it should work. > Dynamically changing

[jira] [Commented] (FLINK-7509) Refactorings to AggregateCodeGenerator

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143526#comment-16143526 ] Fabian Hueske commented on FLINK-7509: -- Yes, with more special cases being added it might make sense

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143553#comment-16143553 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-08-28 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r135481583 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java --- @@ -259,17 +267,72 @@ public int

[jira] [Created] (FLINK-7540) submit a job on yarn-cluster mode or start a yarn-session failed,in hadoop cluster with capitalized hostname

2017-08-28 Thread Tong Yan Ou (JIRA)
Tong Yan Ou created FLINK-7540: -- Summary: submit a job on yarn-cluster mode or start a yarn-session failed,in hadoop cluster with capitalized hostname Key: FLINK-7540 URL:

[jira] [Comment Edited] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137425#comment-16137425 ] Fabian Hueske edited comment on FLINK-7465 at 8/28/17 10:20 AM: I'm sorry,

[jira] [Comment Edited] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137425#comment-16137425 ] Fabian Hueske edited comment on FLINK-7465 at 8/28/17 10:20 AM: I'm sorry,

[jira] [Commented] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143673#comment-16143673 ] Fabian Hueske commented on FLINK-7465: -- HyperLogLog does not support retraction, i.e., removal for

[jira] [Updated] (FLINK-7525) Add config option to disable Cancel functionality on UI

2017-08-28 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-7525: Component/s: Webfrontend Web Client > Add config option to disable Cancel

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143681#comment-16143681 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135503957 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -100,6 +108,17 @@ abstract

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135504282 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/DataViewSpec.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143682#comment-16143682 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4608: [FLINK-7227][Table API & SQL]Fix the the TableSour...

2017-08-28 Thread uybhatti
GitHub user uybhatti opened a pull request: https://github.com/apache/flink/pull/4608 [FLINK-7227][Table API & SQL]Fix the the TableSource predicate push… … down issue for OR and AND expression with more than 2 predicates *Thank you very much for contributing to

[jira] [Commented] (FLINK-7227) OR expression with more than 2 predicates is not pushed into a TableSource

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143686#comment-16143686 ] ASF GitHub Bot commented on FLINK-7227: --- GitHub user uybhatti opened a pull request:

[jira] [Assigned] (FLINK-6860) update Apache Beam in page Ecosystem

2017-08-28 Thread Hai Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhou reassigned FLINK-6860: --- Assignee: Hai Zhou > update Apache Beam in page Ecosystem > > >

[jira] [Updated] (FLINK-7542) Some tests in AggregateITCase fail for some Time Zones

2017-08-28 Thread Usman Younas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Usman Younas updated FLINK-7542: Affects Version/s: 1.3.2 > Some tests in AggregateITCase fail for some Time Zones >

[GitHub] flink issue #4609: Assigner

2017-08-28 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4609 @StefanRRichter please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-7130) Remove eventSerializer from NFA

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143787#comment-16143787 ] ASF GitHub Bot commented on FLINK-7130: --- GitHub user dawidwys opened a pull request:

[jira] [Updated] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-7543: -- Description: Currently you have to do: {{ final ParameterTypes.JobIdPathParam jobId =

[jira] [Created] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-7543: - Summary: Simplify REST parameter access. Key: FLINK-7543 URL: https://issues.apache.org/jira/browse/FLINK-7543 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143722#comment-16143722 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4355: [FLINK-7206] [table] Implementation of DataView to suppor...

2017-08-28 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4355 Hi @wuchong, I think we don't need to call `open()` and `close()` in `AggregateAggFunction`. `GeneratedAggregations` is an internal class which is not exposed to users. It would be a bug

[GitHub] flink pull request #4610: [FLINK-7130] Removed event serializer from NFA and...

2017-08-28 Thread dawidwys
GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/4610 [FLINK-7130] Removed event serializer from NFA and SharedBuffer ## What is the purpose of the change * The purpose is to remove usage of event serializer from `NFA` and `SharedBuffer`

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2017-08-28 Thread sjwiesman
Github user sjwiesman commented on the issue: https://github.com/apache/flink/pull/4607 Would you be able to rerun travis, the test failed on a single configuration during the Kafka09ITTest due to a task manager failure. I do not believe any of my code changes touched any of the code

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-08-28 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 Yes, this way also has some advantages, and recycling these exclusive buffers would be covered in next PR with some additional tests. I will consider your suggestions to supplement some

[jira] [Created] (FLINK-7542) Some tests in AggregateITCase fail for some Time Zones

2017-08-28 Thread Usman Younas (JIRA)
Usman Younas created FLINK-7542: --- Summary: Some tests in AggregateITCase fail for some Time Zones Key: FLINK-7542 URL: https://issues.apache.org/jira/browse/FLINK-7542 Project: Flink Issue

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143792#comment-16143792 ] ASF GitHub Bot commented on FLINK-6306: --- Github user sjwiesman commented on the issue:

[GitHub] flink pull request #4609: Assigner

2017-08-28 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4609 Assigner This PR is a pure refactor and shouldn't change any functionality. It should be covered by existing tests like `CheckpointCoordinatorTest` You can merge this pull request into a

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143814#comment-16143814 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-7465) Add build-in BloomFilterCount on TableAPI

2017-08-28 Thread Jacob Park (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143844#comment-16143844 ] Jacob Park commented on FLINK-7465: --- [~fhueske] [~sunjincheng121] Thanks for the context. :) If

[jira] [Created] (FLINK-7544) Make all PathParameters mandatory

2017-08-28 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-7544: --- Summary: Make all PathParameters mandatory Key: FLINK-7544 URL: https://issues.apache.org/jira/browse/FLINK-7544 Project: Flink Issue Type:

[GitHub] flink issue #4607: [FLINK-6306][connectors] Sink for eventually consistent f...

2017-08-28 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4607 We cannot restart Travis ourselves. Only the contributor can schedule another run by adding another commit (even an empty one). However, please don't do that for the sake of getting a picture-perfect

[GitHub] flink pull request #4612: [FLINK-7452] [types] Add helper methods for all bu...

2017-08-28 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4612 [FLINK-7452] [types] Add helper methods for all built-in Flink types ## What is the purpose of the change This PR provides an unified, detailed, and easy to use utility to work with

[jira] [Updated] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-7543: -- Description: Currently you have to do: { final ParameterTypes.JobIdPathParam jobId =

[GitHub] flink issue #4445: [FLINK-7310][core] always use the HybridMemorySegment

2017-08-28 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4445 Thanks! I am currently trying to pinpoint what part of the code exactly suffers most from the regression. If that is for example specific to the microbenchmark, we can merge this

[GitHub] flink issue #4611: [FLINK-7543] [REST] Simplify handler access to path/query...

2017-08-28 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4611 Changes LGTM @zentol ! When Travis gives a green light, feel free to merge! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143915#comment-16143915 ] ASF GitHub Bot commented on FLINK-7543: --- Github user kl0u commented on the issue:

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143938#comment-16143938 ] ASF GitHub Bot commented on FLINK-7452: --- Github user twalthr commented on the issue:

[jira] [Updated] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-7543: -- Description: Currently you have to do: {{ final ParameterTypes.JobIdPathParam jobId =

[jira] [Commented] (FLINK-6306) Sink for eventually consistent file systems

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143881#comment-16143881 ] ASF GitHub Bot commented on FLINK-6306: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4611: [FLINK-7543] [REST] Simplify handler access to pat...

2017-08-28 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4611 [FLINK-7543] [REST] Simplify handler access to path/query parameters ## What is the purpose of the change This PR simplifies the access to path/query parameters by directly returning the

[jira] [Commented] (FLINK-7310) always use HybridMemorySegment

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143910#comment-16143910 ] ASF GitHub Bot commented on FLINK-7310: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-7543) Simplify REST parameter access.

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143904#comment-16143904 ] ASF GitHub Bot commented on FLINK-7543: --- GitHub user zentol opened a pull request:

[jira] [Commented] (FLINK-7452) Add helper methods for all built-in Flink types to Types

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143937#comment-16143937 ] ASF GitHub Bot commented on FLINK-7452: --- GitHub user twalthr opened a pull request:

[GitHub] flink issue #4612: [FLINK-7452] [types] Add helper methods for all built-in ...

2017-08-28 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4612 CC @alpinegizmo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-08-28 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144102#comment-16144102 ] Xingcan Cui commented on FLINK-6233: Hi [~fhueske], the [document|https://goo.gl/VW5Gpd] has been

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-08-28 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144282#comment-16144282 ] Shuyi Chen commented on FLINK-7491: --- Hi [~jark], thanks for the response. However, I am worried with

[jira] [Created] (FLINK-7545) Support MEMBER OF Operator for Multiset SQL type

2017-08-28 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-7545: - Summary: Support MEMBER OF Operator for Multiset SQL type Key: FLINK-7545 URL: https://issues.apache.org/jira/browse/FLINK-7545 Project: Flink Issue Type: New

[jira] [Created] (FLINK-7546) Support SUBMULTISET_OF Operator for Multiset SQL type

2017-08-28 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-7546: - Summary: Support SUBMULTISET_OF Operator for Multiset SQL type Key: FLINK-7546 URL: https://issues.apache.org/jira/browse/FLINK-7546 Project: Flink Issue Type:

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135648347 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -307,6 +312,92 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135587110 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1398,14 +1412,29 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135561193 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/runtime/utils/JavaUserDefinedAggFunctions.java --- @@ -237,9 +248,13 @@ public

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135539685 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -249,7 +258,8 @@ object

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135524948 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -42,6 +46,18 @@ class

[jira] [Created] (FLINK-7547) o.a.f.s.api.scala.async.AsyncFunction is not declared Serializable

2017-08-28 Thread Elias Levy (JIRA)
Elias Levy created FLINK-7547: - Summary: o.a.f.s.api.scala.async.AsyncFunction is not declared Serializable Key: FLINK-7547 URL: https://issues.apache.org/jira/browse/FLINK-7547 Project: Flink

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135528903 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,119 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r13411 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135534660 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,119 @@ class

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135550350 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135541895 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/dataview/ListViewSerializer.scala --- @@ -0,0 +1,115 @@ +/* + *

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135528733 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -161,13 +182,119 @@ class

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1617#comment-1617 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1619#comment-1619 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1611#comment-1611 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1612#comment-1612 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1616#comment-1616 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144439#comment-16144439 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1614#comment-1614 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1615#comment-1615 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1613#comment-1613 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1618#comment-1618 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1610#comment-1610 ] ASF GitHub Bot commented on FLINK-7206: --- Github user fhueske commented on a diff in the pull

[jira] [Updated] (FLINK-7488) TaskManagerHeapSizeCalculationJavaBashTest sometimes fails

2017-08-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7488: -- Description: {code}

[jira] [Commented] (FLINK-7438) Some classes are eclipsed by classes in package scala

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144622#comment-16144622 ] ASF GitHub Bot commented on FLINK-7438: --- Github user tedyu commented on the issue:

[GitHub] flink issue #4570: [FLINK-7438][DataStream API]Remove useless import, avoid ...

2017-08-28 Thread tedyu
Github user tedyu commented on the issue: https://github.com/apache/flink/pull/4570 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-7446) Support to define an existing field as the rowtime field for TableSource

2017-08-28 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144662#comment-16144662 ] Jark Wu commented on FLINK-7446: [~fhueske] yes, I created FLINK-7548 to discuss this. > Support to

[jira] [Created] (FLINK-7548) Support watermark generation for TableSource

2017-08-28 Thread Jark Wu (JIRA)
Jark Wu created FLINK-7548: -- Summary: Support watermark generation for TableSource Key: FLINK-7548 URL: https://issues.apache.org/jira/browse/FLINK-7548 Project: Flink Issue Type: Bug

[GitHub] flink issue #4355: [FLINK-7206] [table] Implementation of DataView to suppor...

2017-08-28 Thread kaibozhou
Github user kaibozhou commented on the issue: https://github.com/apache/flink/pull/4355 All comments addressed. Do you have time to merge it @wuchong @fhueske ? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144771#comment-16144771 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on the issue:

[GitHub] flink pull request #4355: [FLINK-7206] [table] Implementation of DataView to...

2017-08-28 Thread kaibozhou
Github user kaibozhou commented on a diff in the pull request: https://github.com/apache/flink/pull/4355#discussion_r135697894 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/dataview/ListView.scala --- @@ -0,0 +1,133 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7206) Implementation of DataView to support state access for UDAGG

2017-08-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144769#comment-16144769 ] ASF GitHub Bot commented on FLINK-7206: --- Github user kaibozhou commented on a diff in the pull