Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4722#discussion_r141390556
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -190,6 +193,39 @@ protected
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/4722#discussion_r141390478
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java
---
@@ -190,6 +193,39 @@ protected
[
https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182784#comment-16182784
]
ASF GitHub Bot commented on FLINK-7683:
---
Github user StefanRRichter commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182781#comment-16182781
]
ASF GitHub Bot commented on FLINK-7683:
---
Github user StefanRRichter commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141392589
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -0,0 +1,357 @@
+/*
+ *
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141388702
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java
---
@@ -211,10 +210,15 @@ public void
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141392162
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -313,6 +320,49 @@ public int
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182813#comment-16182813
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user NicoK commented on a diff in the pull request:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141392529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -87,6 +88,12 @@
/** The
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141387553
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -313,6 +320,49 @@ public int
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182811#comment-16182811
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user NicoK commented on a diff in the pull request:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141393650
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -87,6 +88,12 @@
/** The
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182815#comment-16182815
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann closed FLINK-7663.
Resolution: Fixed
Fix Version/s: 1.4.0
Fixed via 9a97dcdff6c7d383c3bb9c9aa7b83bde7ea5fd64
>
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141396023
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li reassigned FLINK-7717:
---
Assignee: Bowen Li
> Port TaskManagerMetricsHandler to new REST endpoint
>
[
https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182827#comment-16182827
]
ASF GitHub Bot commented on FLINK-7649:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182840#comment-16182840
]
ASF GitHub Bot commented on FLINK-7446:
---
Github user wuchong commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182850#comment-16182850
]
ASF GitHub Bot commented on FLINK-7487:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182879#comment-16182879
]
ASF GitHub Bot commented on FLINK-7411:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182930#comment-16182930
]
ASF GitHub Bot commented on FLINK-7650:
---
Github user bowenli86 commented on a diff in the pull
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4590
Thanks for your contribution @NicoK and the review @pnowojski. Merging this
PR.
---
[
https://issues.apache.org/jira/browse/FLINK-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182855#comment-16182855
]
ASF GitHub Bot commented on FLINK-7513:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182854#comment-16182854
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user zhijiangW commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r141406439
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobCache.java
---
@@ -0,0 +1,429 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182776#comment-16182776
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141389893
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/JobConfigHandler.java
---
@@ -42,7 +42,7 @@
private
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182778#comment-16182778
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4699
Thanks for the review @zentol. Failing test is unrelated. Merging this PR.
---
[
https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182826#comment-16182826
]
ASF GitHub Bot commented on FLINK-7650:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182828#comment-16182828
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user NicoK commented on a diff in the pull request:
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141396295
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ * Licensed
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4727
Thanks for the review @zentol. Rebasing this commit and waiting on Travis.
---
[
https://issues.apache.org/jira/browse/FLINK-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182844#comment-16182844
]
ASF GitHub Bot commented on FLINK-7695:
---
GitHub user tillrohrmann opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-6950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182768#comment-16182768
]
Mikhail Pryakhin commented on FLINK-6950:
-
[~rmetzger] Hi Robert, yes I am, shall I assign the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141389329
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCache.java
---
@@ -0,0 +1,180 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182790#comment-16182790
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141391659
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -0,0 +1,357 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182817#comment-16182817
]
ASF GitHub Bot commented on FLINK-7663:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4699
---
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182812#comment-16182812
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182814#comment-16182814
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user NicoK commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182831#comment-16182831
]
ASF GitHub Bot commented on FLINK-7667:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182830#comment-16182830
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user NicoK commented on a diff in the pull request:
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141400676
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolTest.java
---
@@ -211,10 +210,15 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182902#comment-16182902
]
ASF GitHub Bot commented on FLINK-7068:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4571
Thanks for your contribution @NicoK. Merging this PR.
---
[
https://issues.apache.org/jira/browse/FLINK-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182858#comment-16182858
]
ASF GitHub Bot commented on FLINK-7514:
---
Github user tillrohrmann commented on the issue:
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4697#discussion_r141409228
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobMessageParameters.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182929#comment-16182929
]
ASF GitHub Bot commented on FLINK-7650:
---
Github user bowenli86 commented on a diff in the pull
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4697#discussion_r141409233
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobMessageParameters.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141376844
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182724#comment-16182724
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182727#comment-16182727
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai reassigned FLINK-7715:
--
Assignee: Tzu-Li (Gordon) Tai
> Port JarRunHandler to new REST endpoint
>
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141377486
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141377976
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182731#comment-16182731
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai reassigned FLINK-7712:
--
Assignee: Tzu-Li (Gordon) Tai
> Port JarDeleteHandler to new REST endpoint
>
[
https://issues.apache.org/jira/browse/FLINK-7714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai reassigned FLINK-7714:
--
Assignee: Tzu-Li (Gordon) Tai
> Port JarPlanHandler to new REST endpoint
>
[
https://issues.apache.org/jira/browse/FLINK-7711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai reassigned FLINK-7711:
--
Assignee: Tzu-Li (Gordon) Tai
> Port JarListHandler to new REST endpoint
>
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141377249
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tzu-Li (Gordon) Tai reassigned FLINK-7713:
--
Assignee: Tzu-Li (Gordon) Tai
> Port JarUploadHandler to new REST endpoint
>
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182734#comment-16182734
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141378307
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182728#comment-16182728
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182739#comment-16182739
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141380052
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -0,0 +1,283 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182740#comment-16182740
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141380483
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -169,95 +182,19 @@ public
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r141380216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
@@ -193,7 +193,8 @@ private void
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4591
rebased to make it mergable again
---
[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182741#comment-16182741
]
ASF GitHub Bot commented on FLINK-7406:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182743#comment-16182743
]
ASF GitHub Bot commented on FLINK-7514:
---
Github user NicoK commented on the issue:
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/4736
[FLINK-7371] [table] Add support for constant parameters in OVER aggregate
## What is the purpose of the change
This PR allows to pass constants to OVER window aggregates. E.g.
[
https://issues.apache.org/jira/browse/FLINK-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182748#comment-16182748
]
ASF GitHub Bot commented on FLINK-7371:
---
GitHub user twalthr opened a pull request:
Stefan Richter created FLINK-7719:
-
Summary: Send checkpoint id to task as part of deployment
descriptor when resuming
Key: FLINK-7719
URL: https://issues.apache.org/jira/browse/FLINK-7719
Project:
Stefan Richter created FLINK-7720:
-
Summary: Centralize creation of backends and state related
resources
Key: FLINK-7720
URL: https://issues.apache.org/jira/browse/FLINK-7720
Project: Flink
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4697
I guess some of the problems like taking a savepoint could still be served
under `/jobs/:jobid/savepoints/:savepointid` because this resource will be
removed upon first request anyway.
[
https://issues.apache.org/jira/browse/FLINK-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182764#comment-16182764
]
ASF GitHub Bot commented on FLINK-7650:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182807#comment-16182807
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182801#comment-16182801
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4728
Thanks for the review @zentol and @tzulitai.
@zentol yes you are right. The Flip-6 `JobMaster` will only return the
`ArchivedExecutionGraph`. I intend to set the `timeToLive` for the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4697
Thanks for the review @zentol. I've rebased it and wait for Travis.
---
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4700
Thanks for the review @zentol. Rebasing onto the latest #4697 version.
---
[
https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li reassigned FLINK-7718:
---
Assignee: Bowen Li
> Port JobVertixMetricsHandler to new REST endpoint
>
[
https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bowen Li reassigned FLINK-7716:
---
Assignee: Bowen Li
> Port JobManagerMetricsHandler to new REST endpoint
>
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4517
Thanks for your contribution @NicoK and the review @pnowojski. Changes look
good to me. Will wait for Travis and then merge this PR.
---
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182797#comment-16182797
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141392208
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java
---
@@ -0,0 +1,357 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nico Kruber updated FLINK-7699:
---
Summary: Define the BufferListener interface to replace EventListener in
BufferProvider (was: Define
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/4710
Looks good to me.
+1
---
[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182849#comment-16182849
]
ASF GitHub Bot commented on FLINK-7699:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141398906
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -87,6 +88,12 @@
/**
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4591
Thanks for your contribution @NicoK and the reviews @pnowojski and @zentol.
Changes look good. If Travis passes, then I'll merge the PR.
---
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4722
LGTM!
One more ask: can you please add comments to both the class and the code
explaining that concurrent modification will fail the iteration?
---
[
https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182944#comment-16182944
]
ASF GitHub Bot commented on FLINK-7683:
---
Github user bowenli86 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182774#comment-16182774
]
ASF GitHub Bot commented on FLINK-7668:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4728#discussion_r141389580
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCache.java
---
@@ -0,0 +1,182 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16182808#comment-16182808
]
ASF GitHub Bot commented on FLINK-7663:
---
Github user tillrohrmann commented on the issue:
1 - 100 of 417 matches
Mail list logo
