[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264930#comment-16264930 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264905#comment-16264905 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152893854 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -475,16 +515,10 @@ public

[jira] [Updated] (FLINK-7795) Utilize error-prone to discover common coding mistakes

2017-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7795: -- Description: http://errorprone.info/ is a tool which detects common coding mistakes. We should incorporate

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264911#comment-16264911 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152894450 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -306,51 +306,88 @@ public

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for your reviews on Thanksgiving day. I have updated the codes addressed your comments. : ) ---

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264969#comment-16264969 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264906#comment-16264906 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152893996 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void

[jira] [Assigned] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-23 Thread Aegeaner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aegeaner reassigned FLINK-8139: --- Assignee: Aegeaner > Check for proper equals() and hashCode() when registering a table >

[jira] [Updated] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7642: -- Description: Surefire 2.19 release introduced more useful test filters which would let us run a subset of the

[jira] [Resolved] (FLINK-7877) Fix compilation against the Hadoop 3 beta1 release

2017-11-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-7877. --- Resolution: Cannot Reproduce The UtilsTest code has been refactored. > Fix compilation against the Hadoop 3

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152899386 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -306,51 +306,88 @@ public

[jira] [Commented] (FLINK-8098) LeaseExpiredException when using FsStateBackend for checkpointing due to multiple mappers tries to access the same file.

2017-11-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264175#comment-16264175 ] Stefan Richter commented on FLINK-8098: --- Parallel scripts was just another option that I have seen

[GitHub] flink pull request #5060: [hotfix][docs] Improve Kafka exactly-once docs

2017-11-23 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5060 [hotfix][docs] Improve Kafka exactly-once docs This is a tiny hotfix improving Kafka 0.11 documentation. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264070#comment-16264070 ] ASF GitHub Bot commented on FLINK-5465: --- GitHub user StefanRRichter opened a pull request:

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 CC @aljoscha ---

[GitHub] flink pull request #5058: [FLINK-5465] [streaming] Wait for pending timer th...

2017-11-23 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/5058 [FLINK-5465] [streaming] Wait for pending timer threads to finish or … …to exceed a time limit in exceptional stream task shutdown ## What is the purpose of the change

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264071#comment-16264071 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the issue:

[GitHub] flink pull request #5053: [FLINK-8132][kafka] Re-initialize transactional Ka...

2017-11-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5053#discussion_r152758371 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafka011Exception.java --- @@ -0,0

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5058 Looks good all in all. I am torn between adding a configuration setting for the timer grace period and not having one. Seems like a setting that is unlikely to ever be used and just

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264177#comment-16264177 ] ASF GitHub Bot commented on FLINK-7748: --- Github user pnowojski commented on the issue:

[GitHub] flink issue #4761: [FLINK-7748][network] properly use the TaskEventDispatche...

2017-11-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4761 Could you resolve conflicts before I start reviewing? ---

[jira] [Created] (FLINK-8139) Check for proper equals() and hashCode() when registering a table

2017-11-23 Thread Timo Walther (JIRA)
Timo Walther created FLINK-8139: --- Summary: Check for proper equals() and hashCode() when registering a table Key: FLINK-8139 URL: https://issues.apache.org/jira/browse/FLINK-8139 Project: Flink

[jira] [Commented] (FLINK-8098) LeaseExpiredException when using FsStateBackend for checkpointing due to multiple mappers tries to access the same file.

2017-11-23 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264222#comment-16264222 ] Shashank Agarwal commented on FLINK-8098: - yes, agree with the scenario. About file cleanup, i

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264061#comment-16264061 ] Stefan Richter commented on FLINK-5465: --- Hi [~dernasherbrezon], it is true that this problem still

[jira] [Commented] (FLINK-7967) Deprecate Hadoop specific Flink configuration options

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264128#comment-16264128 ] ASF GitHub Bot commented on FLINK-7967: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #4946: [FLINK-7967] [config] Deprecate Hadoop specific Flink con...

2017-11-23 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4946 Hello, @greghogan I have updated the code, Could you take a look when you are free ? Thanks. ---

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152763735 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -309,6 +356,51

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152763651 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -309,6 +356,51

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152761700 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -163,14

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152760280 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -121,6 +130,37

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152762409 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -68,6 +71,12

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152763593 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -309,6 +356,51

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152763535 --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java --- @@ -309,6 +356,51

[jira] [Commented] (FLINK-7472) Release task managers gracefully

2017-11-23 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264159#comment-16264159 ] mingleizhang commented on FLINK-7472: - Is it still a valid one ? > Release task managers gracefully >

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4798 +1 also from my side, I will merge this. ---

[jira] [Closed] (FLINK-8098) LeaseExpiredException when using FsStateBackend for checkpointing due to multiple mappers tries to access the same file.

2017-11-23 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashank Agarwal closed FLINK-8098. --- Resolution: Not A Problem > LeaseExpiredException when using FsStateBackend for checkpointing

[jira] [Commented] (FLINK-8050) RestServer#shutdown() ignores exceptions thrown when shutting down netty.

2017-11-23 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264064#comment-16264064 ] Kostas Kloudas commented on FLINK-8050: --- There is an open PR for this

[jira] [Commented] (FLINK-8049) RestClient#shutdown() ignores exceptions thrown when shutting down netty.

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264063#comment-16264063 ] ASF GitHub Bot commented on FLINK-8049: --- GitHub user kl0u opened a pull request:

[GitHub] flink pull request #5057: [FLINK-8049] [FLINK-8050] REST client/server repor...

2017-11-23 Thread kl0u
GitHub user kl0u opened a pull request: https://github.com/apache/flink/pull/5057 [FLINK-8049] [FLINK-8050] REST client/server report netty exceptions on shutdown. As described in the JIRAs, the rest client/server were swallowing exception without any message. This PR changes

[GitHub] flink issue #4798: [FLINK-6505] Proactively cleanup local FS for RocksDBKeye...

2017-11-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4798 +1 to having this in 1.4. @StefanRRichter, can you please merge once you're satisfied? ---

[jira] [Commented] (FLINK-6505) Proactively cleanup local FS for RocksDBKeyedStateBackend on startup

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264094#comment-16264094 ] ASF GitHub Bot commented on FLINK-6505: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8125) Support limiting the number of open FileSystem connections

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264144#comment-16264144 ] ASF GitHub Bot commented on FLINK-8125: --- GitHub user StephanEwen opened a pull request:

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264140#comment-16264140 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5059: [FLINK-8125] [core] Introduce limiting of file sys...

2017-11-23 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/5059 [FLINK-8125] [core] Introduce limiting of file system connections ## What is the purpose of the change This change introduces a way to limit the number of streams that Flink

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264136#comment-16264136 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264141#comment-16264141 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264137#comment-16264137 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264138#comment-16264138 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264139#comment-16264139 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264142#comment-16264142 ] ASF GitHub Bot commented on FLINK-8118: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264154#comment-16264154 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264161#comment-16264161 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 I am actually leaning towards not having a grace period, too. Reason is that actually there are more than one method in the same code path that could also (theoretically) block forever.

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264180#comment-16264180 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264207#comment-16264207 ] ASF GitHub Bot commented on FLINK-5465: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-6505) Proactively cleanup local FS for RocksDBKeyedStateBackend on startup

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264217#comment-16264217 ] ASF GitHub Bot commented on FLINK-6505: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-8132) FlinkKafkaProducer011 can commit incorrect transaction during recovery

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264082#comment-16264082 ] ASF GitHub Bot commented on FLINK-8132: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264091#comment-16264091 ] ASF GitHub Bot commented on FLINK-5465: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5058: [FLINK-5465] [streaming] Wait for pending timer th...

2017-11-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5058#discussion_r152759896 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java --- @@ -122,6 +123,8 @@ /** The logger used

[jira] [Commented] (FLINK-5465) RocksDB fails with segfault while calling AbstractRocksDBState.clear()

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264092#comment-16264092 ] ASF GitHub Bot commented on FLINK-5465: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5058: [FLINK-5465] [streaming] Wait for pending timer th...

2017-11-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5058#discussion_r152759445 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/ProcessingTimeService.java --- @@ -93,4 +94,15 @@ * will

[jira] [Commented] (FLINK-8098) LeaseExpiredException when using FsStateBackend for checkpointing due to multiple mappers tries to access the same file.

2017-11-23 Thread Shashank Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264148#comment-16264148 ] Shashank Agarwal commented on FLINK-8098: - I got the main issue after another crash. I had another

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 So which way can we agree upon? I feel like this is a setting that is very specific and hard to understand for the user. On the other hand, it is nice if we can adjust it by configuration in

[GitHub] flink issue #5058: [FLINK-5465] [streaming] Wait for pending timer threads t...

2017-11-23 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5058 Implemented the configurable timeout, so that we can chose between the two options. ---

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264040#comment-16264040 ] ASF GitHub Bot commented on FLINK-8118: --- GitHub user xccui opened a pull request:

[jira] [Created] (FLINK-8138) Race in TaskAsyncCallTest leads to test time out

2017-11-23 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-8138: -- Summary: Race in TaskAsyncCallTest leads to test time out Key: FLINK-8138 URL: https://issues.apache.org/jira/browse/FLINK-8138 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-8138) Race in TaskAsyncCallTest leads to test time out

2017-11-23 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi updated FLINK-8138: --- Attachment: log.txt > Race in TaskAsyncCallTest leads to test time out >

[jira] [Closed] (FLINK-4716) Add trigger full recovery button to web UI

2017-11-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-4716. Resolution: Won't Fix > Add trigger full recovery button to web UI >

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/5056 [FLINK-8118] [table] Allow specifying reading offsets of KafkaTableSources ## What is the purpose of the change This PR enables the kafka table source builder to specify start reading

[jira] [Commented] (FLINK-4716) Add trigger full recovery button to web UI

2017-11-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263990#comment-16263990 ] Till Rohrmann commented on FLINK-4716: -- I think nothing happened here. Moreover, I think this issue

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263945#comment-16263945 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r152737920 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -301,81 +306,388 @@

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-11-23 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK, I have submitted the updates addressed all the comments. Wish your continued reviews! :) ---

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263966#comment-16263966 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issue:

[GitHub] flink pull request #5055: [FLINK-7718] [flip6] Add JobVertexMetricsHandler t...

2017-11-23 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5055#discussion_r152817079 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/job/metrics/MetricsFilterParameterTest.java --- @@ -0,0 +1,51 @@ +/* + *

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264257#comment-16264257 ] ASF GitHub Bot commented on FLINK-8118: --- Github user xccui commented on the issue:

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5056#discussion_r152795641 --- Diff: docs/dev/table/sourceSinks.md --- @@ -264,6 +288,30 @@ val source: TableSource[_] = Kafka010AvroTableSource.builder() +*

[jira] [Commented] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264354#comment-16264354 ] ASF GitHub Bot commented on FLINK-8118: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-8118) Allow to specify the offsets of KafkaTableSources

2017-11-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8118. - Resolution: Fixed Fix Version/s: 1.4.0 Fixed in 1.5:

[GitHub] flink pull request #5056: [FLINK-8118] [table] Allow specifying reading offs...

2017-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5056 ---

[GitHub] flink issue #5059: [FLINK-8125] [core] Introduce limiting of file system con...

2017-11-23 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5059 It does not yet remove all checkstyle violation, no. ---

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152813679 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[GitHub] flink pull request #4581: [FLINK-7499][io] also let AsynchronousBufferFileWr...

2017-11-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4581#discussion_r152813605 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java --- @@ -192,21 +198,39 @@ public void

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264395#comment-16264395 ] ASF GitHub Bot commented on FLINK-7499: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink issue #4761: [FLINK-7748][network] properly use the TaskEventDispatche...

2017-11-23 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4761 alright - didn't even need to do anything here since git auto-merged them :) ---

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264408#comment-16264408 ] ASF GitHub Bot commented on FLINK-7748: --- Github user NicoK commented on the issue:

[jira] [Updated] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-23 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hai Zhou UTC+8 updated FLINK-8142: -- Affects Version/s: 1.4.0 Fix Version/s: 1.5.0 Component/s: Local Runtime >

[jira] [Commented] (FLINK-8132) FlinkKafkaProducer011 can commit incorrect transaction during recovery

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264452#comment-16264452 ] ASF GitHub Bot commented on FLINK-8132: --- Github user pnowojski closed the pull request at:

[jira] [Created] (FLINK-8143) Port SubtaskMetricsHandler to new REST endpoint

2017-11-23 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8143: --- Summary: Port SubtaskMetricsHandler to new REST endpoint Key: FLINK-8143 URL: https://issues.apache.org/jira/browse/FLINK-8143 Project: Flink Issue Type: Sub-task

[jira] [Assigned] (FLINK-8143) Port SubtaskMetricsHandler to new REST endpoint

2017-11-23 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8143: --- Assignee: Gary Yao > Port SubtaskMetricsHandler to new REST endpoint >

[jira] [Commented] (FLINK-7718) Port JobVertixMetricsHandler to new REST endpoint

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264418#comment-16264418 ] ASF GitHub Bot commented on FLINK-7718: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5060: [hotfix][docs] Improve Kafka exactly-once docs

2017-11-23 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/5060 ---

[GitHub] flink pull request #5053: [FLINK-8132][kafka] Re-initialize transactional Ka...

2017-11-23 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/5053 ---

[jira] [Commented] (FLINK-8132) FlinkKafkaProducer011 can commit incorrect transaction during recovery

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264451#comment-16264451 ] ASF GitHub Bot commented on FLINK-8132: --- Github user pnowojski commented on the issue:

[jira] [Created] (FLINK-8142) Cleanup reference to deprecated constants in ConfigConstants

2017-11-23 Thread Hai Zhou UTC+8 (JIRA)
Hai Zhou UTC+8 created FLINK-8142: - Summary: Cleanup reference to deprecated constants in ConfigConstants Key: FLINK-8142 URL: https://issues.apache.org/jira/browse/FLINK-8142 Project: Flink

[GitHub] flink issue #5060: [hotfix][docs] Improve Kafka exactly-once docs

2017-11-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5060 Thanks! ---

[GitHub] flink issue #5053: [FLINK-8132][kafka] Re-initialize transactional KafkaProd...

2017-11-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5053 Thanks! ---

  1   2   3   >