[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266685#comment-16266685 ] ASF GitHub Bot commented on FLINK-8022: --- GitHub user pnowojski opened a pull request:

[GitHub] flink issue #4594: [FLINK-7517][network] let NettyBufferPool extend PooledBy...

2017-11-27 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4594 Yes @zhijiangW, I kept the original logic. I guess, the reasoning behind using off-heap netty buffers only was to reduce the overhead before transmitting messages over the wire: 1) we reduce GC

[jira] [Commented] (FLINK-7517) let NettyBufferPool extend PooledByteBufAllocator

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266688#comment-16266688 ] ASF GitHub Bot commented on FLINK-7517: --- Github user NicoK commented on the issue:

[jira] [Commented] (FLINK-7530) Port existing REST handlers to support Flip-6 components

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266744#comment-16266744 ] ASF GitHub Bot commented on FLINK-7530: --- GitHub user GJL opened a pull request:

[GitHub] flink pull request #5079: [FLINK-7530][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5079 [FLINK-7530][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log -

[jira] [Created] (FLINK-8159) Add rich support for SelectWrapper and FlatSelectWrapper

2017-11-27 Thread Dian Fu (JIRA)
Dian Fu created FLINK-8159: -- Summary: Add rich support for SelectWrapper and FlatSelectWrapper Key: FLINK-8159 URL: https://issues.apache.org/jira/browse/FLINK-8159 Project: Flink Issue Type:

[jira] [Created] (FLINK-8158) Rowtime window inner join emits late data

2017-11-27 Thread Hequn Cheng (JIRA)
Hequn Cheng created FLINK-8158: -- Summary: Rowtime window inner join emits late data Key: FLINK-8158 URL: https://issues.apache.org/jira/browse/FLINK-8158 Project: Flink Issue Type: Bug

[GitHub] flink pull request #5082: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5082 [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log -

[GitHub] flink pull request #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler ...

2017-11-27 Thread GJL
Github user GJL closed the pull request at: https://github.com/apache/flink/pull/5079 ---

[GitHub] flink issue #5049: [FLINK-8081][metrics] Annotate 'MetricRegistry#getReporte...

2017-11-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5049 merging. ---

[jira] [Commented] (FLINK-8081) Annotate MetricRegistry#getReporters() with @VisibleForTesting

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266693#comment-16266693 ] ASF GitHub Bot commented on FLINK-8081: --- Github user zentol commented on the issue:

[GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...

2017-11-27 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5068#discussion_r153179456 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala --- @@ -60,4 +60,14 @@ trait TableSource[T] {

[jira] [Commented] (FLINK-8122) Name all table sinks and sources

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266715#comment-16266715 ] ASF GitHub Bot commented on FLINK-8122: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #5081: [FLINK-7530][flip6] Migrate TaskManagerMetricsHand...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5081 [FLINK-7530][flip6] Migrate TaskManagerMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[jira] [Commented] (FLINK-8154) JobSubmissionClientActor submited job,but there is no connection to a JobManager

2017-11-27 Thread Patrick Lucas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266782#comment-16266782 ] Patrick Lucas commented on FLINK-8154: -- Is `act-monitor-flink-jobmanager` a Kubernetes Service? If

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-27 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5032 Thanks for the suggestion @aljoscha. The problem is the state type is provided via a generic type parameter `S extends State`, which will be erased in runtime. Thus it's hard to do type

[GitHub] flink pull request #5078: [FLINK-8022][kafka] Bump at-least-once timeout in ...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5078 ---

[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266694#comment-16266694 ] ASF GitHub Bot commented on FLINK-8022: --- Github user aljoscha commented on the issue:

[jira] [Closed] (FLINK-8022) Kafka at-least-once tests fail occasionally

2017-11-27 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8022. --- Resolution: Fixed Assignee: Piotr Nowojski (was: Tzu-Li (Gordon) Tai) Fixed on master

[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266696#comment-16266696 ] ASF GitHub Bot commented on FLINK-8022: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #5078: [FLINK-8022][kafka] Bump at-least-once timeout in tests

2017-11-27 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5078 Thanks! I merged this 👍 ---

[jira] [Closed] (FLINK-8153) Upgrade to JDK 9

2017-11-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8153. --- Resolution: Later There are no plans at the moment to fully switch to JDK 9, that is dropping

[jira] [Created] (FLINK-8160) Extend OperatorHarness to expose metrics

2017-11-27 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-8160: --- Summary: Extend OperatorHarness to expose metrics Key: FLINK-8160 URL: https://issues.apache.org/jira/browse/FLINK-8160 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-5789) Make Bucketing Sink independent of Hadoop's FileSystem

2017-11-27 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-5789: --- Assignee: (was: Gary Yao) > Make Bucketing Sink independent of Hadoop's FileSystem >

[GitHub] flink issue #5032: [FLINK-8090] [DataStream] Improve the error message for d...

2017-11-27 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5032 We could check based on the state descriptor. ---

[GitHub] flink pull request #5049: [FLINK-8081][metrics] Annotate 'MetricRegistry#get...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5049 ---

[jira] [Closed] (FLINK-8081) Annotate MetricRegistry#getReporters() with @VisibleForTesting

2017-11-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8081. --- Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 1.4:

[jira] [Commented] (FLINK-8081) Annotate MetricRegistry#getReporters() with @VisibleForTesting

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266699#comment-16266699 ] ASF GitHub Bot commented on FLINK-8081: --- Github user asfgit closed the pull request at:

[GitHub] flink issue #5077: [docs] fix wrong package name

2017-11-27 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5077 nice catch, merging. ---

[jira] [Commented] (FLINK-7530) Port existing REST handlers to support Flip-6 components

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266765#comment-16266765 ] ASF GitHub Bot commented on FLINK-7530: --- GitHub user GJL opened a pull request:

[jira] [Commented] (FLINK-7716) Port JobManagerMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266800#comment-16266800 ] ASF GitHub Bot commented on FLINK-7716: --- GitHub user GJL opened a pull request:

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266805#comment-16266805 ] ASF GitHub Bot commented on FLINK-8090: --- Github user xccui commented on the issue:

[jira] [Commented] (FLINK-8090) Improve error message when registering different states under the same name.

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266871#comment-16266871 ] ASF GitHub Bot commented on FLINK-8090: --- Github user aljoscha commented on the issue:

[jira] [Updated] (FLINK-8158) Rowtime window inner join emits late data

2017-11-27 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng updated FLINK-8158: --- Description: When executing the join, the join operator needs to make sure that no late data is

[jira] [Commented] (FLINK-8022) Kafka at-least-once tests fail occasionally

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266707#comment-16266707 ] ASF GitHub Bot commented on FLINK-8022: --- Github user pnowojski commented on the issue:

[jira] [Commented] (FLINK-8122) Name all table sinks and sources

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266731#comment-16266731 ] ASF GitHub Bot commented on FLINK-8122: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #5080: [FLINK-8159] [cep] Add rich support for SelectWrap...

2017-11-27 Thread dianfu
GitHub user dianfu opened a pull request: https://github.com/apache/flink/pull/5080 [FLINK-8159] [cep] Add rich support for SelectWrapper and FlatSelectWrapper ## What is the purpose of the change *This pull request add the rich support for SelectWrapper and

[GitHub] flink pull request #5077: [docs] fix wrong package name

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5077 ---

[jira] [Commented] (FLINK-8143) Port SubtaskMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266771#comment-16266771 ] ASF GitHub Bot commented on FLINK-8143: --- Github user GJL closed the pull request at:

[jira] [Commented] (FLINK-8143) Port SubtaskMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266772#comment-16266772 ] ASF GitHub Bot commented on FLINK-8143: --- GitHub user GJL opened a pull request:

[GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...

2017-11-27 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/5068#discussion_r153182297 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala --- @@ -60,4 +60,14 @@ trait TableSource[T] {

[GitHub] flink issue #5079: [FLINK-8143][flip6] Migrate SubtaskMetricsHandler to new ...

2017-11-27 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5079 My branch name is wrong. The commit messages are right. Let me know if this is a problem. ---

[jira] [Commented] (FLINK-8143) Port SubtaskMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266768#comment-16266768 ] ASF GitHub Bot commented on FLINK-8143: --- Github user GJL commented on the issue:

[GitHub] flink pull request #5084: [FLINK-7694][flip6] Migrate JobMetricsHandler to n...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5084 [FLINK-7694][flip6] Migrate JobMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log -

[jira] [Commented] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266819#comment-16266819 ] ASF GitHub Bot commented on FLINK-7694: --- GitHub user GJL opened a pull request:

[GitHub] flink pull request #5078: [FLINK-8022][kafka] Bump at-least-once timeout in ...

2017-11-27 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5078 [FLINK-8022][kafka] Bump at-least-once timeout in tests Increasing timeout for reading the records from 30s to 60s seems to solve the issue for failing at-least-one tests. This is a

[GitHub] flink issue #5078: [FLINK-8022][kafka] Bump at-least-once timeout in tests

2017-11-27 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/5078 Thanks! ---

[jira] [Commented] (FLINK-8159) Add rich support for SelectWrapper and FlatSelectWrapper

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266750#comment-16266750 ] ASF GitHub Bot commented on FLINK-8159: --- GitHub user dianfu opened a pull request:

[jira] [Assigned] (FLINK-8160) Extend OperatorHarness to expose metrics

2017-11-27 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-8160: --- Assignee: (was: Chesnay Schepler) > Extend OperatorHarness to expose metrics >

[GitHub] flink pull request #5083: [FLINK-7716][flip6] Migrate JobManagerMetricsHandl...

2017-11-27 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5083 [FLINK-7716][flip6] Migrate JobManagerMetricsHandler to new RestServerEndpoint ## What is the purpose of the change *FLIP-6 efforts: Migrating HTTP handlers* ## Brief change log

[GitHub] flink issue #4581: [FLINK-7499][io] fix double buffer release in SpillableSu...

2017-11-27 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4581 Still failing with some checkstyle violations in `ResultPartition.java` ---

[jira] [Commented] (FLINK-8154) JobSubmissionClientActor submited job,but there is no connection to a JobManager

2017-11-27 Thread Gregory Melekh (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266949#comment-16266949 ] Gregory Melekh commented on FLINK-8154: --- Ohhh...You are right... I should create headless service to

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153241166 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/CachedCheckpointStreamFactory.java --- @@ -0,0 +1,195 @@ +/* + *

[jira] [Commented] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267023#comment-16267023 ] ASF GitHub Bot commented on FLINK-8161: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5085: [FLINK-8161] [tests] Harden YARNSessionCapacitySch...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5085 [FLINK-8161] [tests] Harden YARNSessionCapacitySchedulerITCase ## What is the purpose of the change Add "Remote connection to [null] failed with

[GitHub] flink pull request #5089: [FLINK-8088] Associate logical slots with the slot...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5089 [FLINK-8088] Associate logical slots with the slot request id ## What is the purpose of the change Before, logical slots like the `SimpleSlot` and `SharedSlot` where associated to the

[jira] [Commented] (FLINK-8088) Bind logical slots to their request id instead of the slot allocation id

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267094#comment-16267094 ] ASF GitHub Bot commented on FLINK-8088: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266992#comment-16266992 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5086: [FLINK-8078] Introduce LogicalSlot interface

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5086 [FLINK-8078] Introduce LogicalSlot interface ## What is the purpose of the change The LogicalSlot interface decouples the task deployment from the actual slot implementation which at

[jira] [Commented] (FLINK-8078) Decouple Execution from actual slot implementation

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267070#comment-16267070 ] ASF GitHub Bot commented on FLINK-8078: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267112#comment-16267112 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267111#comment-16267111 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267113#comment-16267113 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267109#comment-16267109 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267110#comment-16267110 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[jira] [Closed] (FLINK-8154) JobSubmissionClientActor submited job,but there is no connection to a JobManager

2017-11-27 Thread Gregory Melekh (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gregory Melekh closed FLINK-8154. - Resolution: Not A Problem > JobSubmissionClientActor submited job,but there is no connection to

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153234962 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java --- @@ -190,6 +199,11 @@ public static

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266965#comment-16266965 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5074: [FLINK-7873] [runtime] Introduce local recovery

2017-11-27 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5074#discussion_r153235421 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV2Serializer.java --- @@ -510,6 +512,13 @@ private

[jira] [Commented] (FLINK-8087) Decouple Slot from SlotPool

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267088#comment-16267088 ] ASF GitHub Bot commented on FLINK-8087: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5088: [FLINK-8087] Decouple Slot from AllocatedSlot

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5088 [FLINK-8087] Decouple Slot from AllocatedSlot ## What is the purpose of the change This commit introduces the SlotContext which is an abstraction for the SimpleSlot to obtain the

[jira] [Commented] (FLINK-7499) double buffer release in SpillableSubpartitionView

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266940#comment-16266940 ] ASF GitHub Bot commented on FLINK-7499: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-7873) Introduce CheckpointCacheManager for reading checkpoint data locally when performing failover

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266966#comment-16266966 ] ASF GitHub Bot commented on FLINK-7873: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Created] (FLINK-8161) Flakey YARNSessionCapacitySchedulerITCase on Travis

2017-11-27 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8161: Summary: Flakey YARNSessionCapacitySchedulerITCase on Travis Key: FLINK-8161 URL: https://issues.apache.org/jira/browse/FLINK-8161 Project: Flink Issue

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r153253247 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -572,20 +560,53 @@ void

[jira] [Commented] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267037#comment-16267037 ] Greg Hogan commented on FLINK-7642: --- Please stop adding and removing a blank line from the description

[GitHub] flink pull request #5091: [FLINK-7956] [flip6] Add support for queued schedu...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5091 [FLINK-7956] [flip6] Add support for queued scheduling with slot sharing to SlotPool ## What is the purpose of the change This commit adds support for queued scheduling with slot

[jira] [Commented] (FLINK-7956) Add support for scheduling with slot sharing

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267135#comment-16267135 ] ASF GitHub Bot commented on FLINK-7956: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r152985049 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java --- @@ -224,17 +224,9 @@ public void registerTask(Task

[GitHub] flink pull request #5081: [FLINK-7717][flip6] Migrate TaskManagerMetricsHand...

2017-11-27 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5081#discussion_r153243460 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/metrics/TaskManagerMetricsHandler.java --- @@ -0,0 +1,64 @@ +/* + *

[jira] [Commented] (FLINK-7717) Port TaskManagerMetricsHandler to new REST endpoint

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267007#comment-16267007 ] ASF GitHub Bot commented on FLINK-7717: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267030#comment-16267030 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8089) Fulfil slot requests with unused offered slots

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267101#comment-16267101 ] ASF GitHub Bot commented on FLINK-8089: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #:

2017-11-27 Thread zentol
Github user zentol commented on the pull request: https://github.com/apache/flink/commit/c940d5eff9897796625a696ed2989aed52c39ebd#commitcomment-25875079 In tools/releasing/create_source_release.sh: In tools/releasing/create_source_release.sh on line 60: maybe we should have a

[jira] [Commented] (FLINK-7642) Upgrade maven surefire plugin to 2.19.1

2017-11-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267051#comment-16267051 ] Ted Yu commented on FLINK-7642: --- Over in hbase, we use 2.20.1 . SUREFIRE-1255 has been inactive - it seems

[GitHub] flink pull request #5090: [FLINK-8089] Also check for other pending slot req...

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5090 [FLINK-8089] Also check for other pending slot requests in SlotPool#offerSlot ## What is the purpose of the change Not only check for a slot request with the right allocation id but

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266984#comment-16266984 ] ASF GitHub Bot commented on FLINK-7456: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8085) Thin out the LogicalSlot interface

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267082#comment-16267082 ] ASF GitHub Bot commented on FLINK-8085: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5087: [FLINK-8085] Thin out LogicalSlot interface

2017-11-27 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5087 [FLINK-8085] Thin out LogicalSlot interface ## What is the purpose of the change Remove isCanceled, isReleased method and decouple logical slot from Execution by introducing a

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153261175 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -152,6 +170,26 @@ public void

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153269318 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -283,10 +283,13 @@ public String

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153258008 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -88,6 +98,15 @@ void

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153263139 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -274,4 +313,49 @@ private void

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-11-27 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r153266186 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -539,4 +542,60 @@ static CloseRequest

[GitHub] flink issue #5047: Code refine of WordWithCount

2017-11-27 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5047 Do we still want to make this change since the PR is now only adding a single comment? ---

[jira] [Updated] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-8126: -- Fix Version/s: 1.4.0 > Update and fix checkstyle > - > > Key:

[jira] [Commented] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267309#comment-16267309 ] ASF GitHub Bot commented on FLINK-8126: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5061: [hotfix] [docs] Update checkstyle version in docum...

2017-11-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5061 ---

[jira] [Closed] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-8126. - Resolution: Fixed 1.4: 4eae418b410c928b8e4b7893c1f5b9c48a5e3228 > Update and fix checkstyle >

[jira] [Reopened] (FLINK-8126) Update and fix checkstyle

2017-11-27 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan reopened FLINK-8126: --- > Update and fix checkstyle > - > > Key: FLINK-8126 >

  1   2   >