[GitHub] [flink] JingsongLi commented on issue #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with …

2019-12-04 Thread GitBox
JingsongLi commented on issue #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with … URL: https://github.com/apache/flink/pull/10415#issuecomment-561533551 Thanks @docete for you fixing, LGTM after travis passed.

[GitHub] [flink] shuttie commented on a change in pull request #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
shuttie commented on a change in pull request #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#discussion_r353607833 ## File path:

[GitHub] [flink] StephanEwen commented on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0

2019-12-04 Thread GitBox
StephanEwen commented on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0 URL: https://github.com/apache/flink/pull/10363#issuecomment-561535237 Do we need to adjust any NOTICE files due to the changed dependency versions we get, or is this automatically merged from

[jira] [Commented] (FLINK-14572) BlobsCleanupITCase failed on Travis

2019-12-04 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987660#comment-16987660 ] Gary Yao commented on FLINK-14572: -- Unfortunately I don't have any either. > BlobsCleanupITCase failed

[GitHub] [flink] AHeise commented on a change in pull request #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
AHeise commented on a change in pull request #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#discussion_r353626201 ## File path:

[jira] [Updated] (FLINK-15016) Remove unused dependency

2019-12-04 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-15016: - Fix Version/s: 1.10.0 > Remove unused dependency > > >

[GitHub] [flink] flinkbot edited a comment on issue #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation URL: https://github.com/apache/flink/pull/10330#issuecomment-558970102 ## CI report: * 38f2c1c450122cae9aa99258c19c6d07e998 : FAILURE

[GitHub] [flink] flinkbot commented on issue #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor…

2019-12-04 Thread GitBox
flinkbot commented on issue #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor… URL: https://github.com/apache/flink/pull/10418#issuecomment-561557852 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] aljoscha commented on a change in pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions

2019-12-04 Thread GitBox
aljoscha commented on a change in pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#discussion_r353637844 ## File path:

[GitHub] [flink] aljoscha commented on a change in pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions

2019-12-04 Thread GitBox
aljoscha commented on a change in pull request #10286: [FLINK-14890] [tests] Add missing test harnesses for broadcast functions URL: https://github.com/apache/flink/pull/10286#discussion_r353638159 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor…

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor… URL: https://github.com/apache/flink/pull/10418#discussion_r353640867 ## File path:

[jira] [Comment Edited] (FLINK-15047) YarnDistributedCacheITCase is unstable

2019-12-04 Thread Gary Yao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987684#comment-16987684 ] Gary Yao edited comment on FLINK-15047 at 12/4/19 9:57 AM: --- -Running this test

[GitHub] [flink] flinkbot edited a comment on issue #10333: [FLINK-14970]Doomed test for equality to NaN

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-559012637 ## CI report: * c5bd9898fbbeb3d668051475409b52bfb1e2 : UNKNOWN * 44f202263cbb26473b06ea19f293bf0b6afce8e6 :

[GitHub] [flink] zjuwangg commented on issue #10419: [FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client

2019-12-04 Thread GitBox
zjuwangg commented on issue #10419: [FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client URL: https://github.com/apache/flink/pull/10419#issuecomment-561570095 @danny0405 @xuefuz @bowenli86 @KurtYoung to have a review.

[GitHub] [flink] zjuwangg opened a new pull request #10419: [FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client

2019-12-04 Thread GitBox
zjuwangg opened a new pull request #10419: [FLINK-15026][SQL-CLIENT]Support create/drop/alter database in sql client URL: https://github.com/apache/flink/pull/10419 ## What is the purpose of the change *Since we have support create/drop/alter database operation in TableEnvironment,

[GitHub] [flink] flinkbot edited a comment on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions URL: https://github.com/apache/flink/pull/10345#issuecomment-559421343 ## CI report: * 5206399001512006f4b3d7663e7b5be8ea02a4a2 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-559765475 ## CI report: * b106e8b0327fb78ebac1894a8f8fa51718b3bbba : SUCCESS

[GitHub] [flink] StephanEwen commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
StephanEwen commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353679918 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10394: [FLINK-14663]Distinguish catalogColumnStats' unknown value and real values

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10394: [FLINK-14663]Distinguish catalogColumnStats' unknown value and real values URL: https://github.com/apache/flink/pull/10394#issuecomment-561095403 ## CI report: * 68e77528300eadcbeaa62372d676b01e268c39a8 : SUCCESS

[GitHub] [flink] rkhachatryan commented on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions

2019-12-04 Thread GitBox
rkhachatryan commented on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions URL: https://github.com/apache/flink/pull/10345#issuecomment-561605260 @flinkbot run travis This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10345: [FLINK-12484][runtime] synchronize all mailbox actions URL: https://github.com/apache/flink/pull/10345#issuecomment-559421343 ## CI report: * 5206399001512006f4b3d7663e7b5be8ea02a4a2 : FAILURE

[GitHub] [flink] flinkbot edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-559765475 ## CI report: * b106e8b0327fb78ebac1894a8f8fa51718b3bbba : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #10359: [FLINK-14813][metrics] Provide `isBackPressured` Task metric

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10359: [FLINK-14813][metrics] Provide `isBackPressured` Task metric URL: https://github.com/apache/flink/pull/10359#issuecomment-559773427 ## CI report: * b05689f09ee9e5eaa9ceacc223a9027b467143a6 : SUCCESS

[GitHub] [flink] zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle.

2019-12-04 Thread GitBox
zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle. URL: https://github.com/apache/flink/pull/10375#discussion_r353594121 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle.

2019-12-04 Thread GitBox
zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle. URL: https://github.com/apache/flink/pull/10375#discussion_r353594121 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-552307115 ## CI report: * 25f9e4b87846e5a736aa329c834f82962e1f50c4 : FAILURE

[jira] [Commented] (FLINK-14572) BlobsCleanupITCase failed on Travis

2019-12-04 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987647#comment-16987647 ] Zhu Zhu commented on FLINK-14572: - Unfortunately, the detailed logs downloaded are removed already from

[GitHub] [flink] TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments

2019-12-04 Thread GitBox
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#issuecomment-561541292 @aljoscha it would make sense. One concern is about the close actions. For some implementations of JobClient,

[GitHub] [flink] GJL commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode

2019-12-04 Thread GitBox
GJL commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode URL: https://github.com/apache/flink/pull/10406#discussion_r353620416 ## File path:

[GitHub] [flink] Myasuka commented on issue #10402: [FLINK-15034] Bump FRocksDB version for memory control

2019-12-04 Thread GitBox
Myasuka commented on issue #10402: [FLINK-15034] Bump FRocksDB version for memory control URL: https://github.com/apache/flink/pull/10402#issuecomment-561550622 @StephanEwen thanks for your examination, already updated `flink-dist/src/main/resources/META-INF/NOTICE`

[GitHub] [flink] dawidwys opened a new pull request #10417: [FLINK-14910][datastream] Checking for auto generated uids only for PhysicalStreamTransformations

2019-12-04 Thread GitBox
dawidwys opened a new pull request #10417: [FLINK-14910][datastream] Checking for auto generated uids only for PhysicalStreamTransformations URL: https://github.com/apache/flink/pull/10417 ## What is the purpose of the change This PR enables the check for auto generated uids only

[jira] [Updated] (FLINK-12283) In Table API, allow non-static inner class as UDF

2019-12-04 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-12283: - Summary: In Table API, allow non-static inner class as UDF (was: Allow non-static

[GitHub] [flink] zentol commented on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0

2019-12-04 Thread GitBox
zentol commented on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0 URL: https://github.com/apache/flink/pull/10363#issuecomment-561550679 This happens automatically. We don't list flink dependencies in our notice files (that's why flink-dist NOTICE remains unchanged) and

[jira] [Updated] (FLINK-15047) YarnDistributedCacheITCase is unstable

2019-12-04 Thread Aljoscha Krettek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-15047: - Labels: test-stability (was: ) > YarnDistributedCacheITCase is unstable >

[jira] [Updated] (FLINK-14910) disableAutoGeneratedUIDs fails on keyBy

2019-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14910: --- Labels: pull-request-available (was: ) > disableAutoGeneratedUIDs fails on keyBy >

[GitHub] [flink] zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode

2019-12-04 Thread GitBox
zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode URL: https://github.com/apache/flink/pull/10406#discussion_r353638280 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10399: [FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType in blink planner

2019-12-04 Thread GitBox
docete commented on a change in pull request #10399: [FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType in blink planner URL: https://github.com/apache/flink/pull/10399#discussion_r353638560 ## File path:

[GitHub] [flink] docete commented on a change in pull request #10399: [FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType in blink planner

2019-12-04 Thread GitBox
docete commented on a change in pull request #10399: [FLINK-14959][table-planner-blink] Support precision of LocalZonedTimestampType in blink planner URL: https://github.com/apache/flink/pull/10399#discussion_r353642653 ## File path:

[jira] [Updated] (FLINK-15046) Add guideline on how to report security issues

2019-12-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-15046: - Description: As discussed in the

[jira] [Updated] (FLINK-15026) Support database DDLs in SQL CLI

2019-12-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-15026: --- Labels: pull-request-available (was: ) > Support database DDLs in SQL CLI >

[jira] [Assigned] (FLINK-15046) Add guideline on how to report security issues

2019-12-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-15046: Assignee: Dian Fu > Add guideline on how to report security issues >

[jira] [Updated] (FLINK-15046) Add guideline on how to report security issues

2019-12-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-15046: - Environment: (was: As discussed in the

[GitHub] [flink] StephanEwen commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
StephanEwen commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-561580556 This is nice work, thanks a lot :-) Could you add a test case that ensures the

[GitHub] [flink] shuttie commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
shuttie commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-561581049 @AHeise thanks for all the ideas, I've updated the PR with all the proposals applied.

[GitHub] [flink] flinkbot edited a comment on issue #10417: [FLINK-14910][datastream] Checking for auto generated uids only for PhysicalStreamTransformations

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10417: [FLINK-14910][datastream] Checking for auto generated uids only for PhysicalStreamTransformations URL: https://github.com/apache/flink/pull/10417#issuecomment-561567788 ## CI report: * 64b24f882e32caebd6489f890ca477305acf31cc : PENDING

[GitHub] [flink] flinkbot edited a comment on issue #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor…

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor… URL: https://github.com/apache/flink/pull/10418#issuecomment-561567846 ## CI report: * 6951e77dff9c9c4fb1945d79ef4253e5ea2c0f0f : PENDING

[jira] [Commented] (FLINK-13662) FlinkKinesisProducerTest.testBackpressure failed on Travis

2019-12-04 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987742#comment-16987742 ] Till Rohrmann commented on FLINK-13662: --- Do you wanna give it a try and see whether it fixes the

[GitHub] [flink] zentol commented on a change in pull request #10384: [FLINK-13373][docs] Remove Tutorials and Examples sections from Getting Started

2019-12-04 Thread GitBox
zentol commented on a change in pull request #10384: [FLINK-13373][docs] Remove Tutorials and Examples sections from Getting Started URL: https://github.com/apache/flink/pull/10384#discussion_r353675794 ## File path: docs/ops/deployment/local.md ## @@ -0,0 +1,178 @@ +---

[jira] [Assigned] (FLINK-15047) YarnDistributedCacheITCase is unstable

2019-12-04 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-15047: - Assignee: Andrey Zagrebin > YarnDistributedCacheITCase is unstable >

[GitHub] [flink] flinkbot edited a comment on issue #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode URL: https://github.com/apache/flink/pull/10406#issuecomment-561380440 ## CI report: * 0effd7f6b294b7f2da91c7681aa6e8ae51390efc : UNKNOWN *

[GitHub] [flink] jinglining commented on issue #10359: [FLINK-14813][metrics] Provide `isBackPressured` Task metric

2019-12-04 Thread GitBox
jinglining commented on issue #10359: [FLINK-14813][metrics] Provide `isBackPressured` Task metric URL: https://github.com/apache/flink/pull/10359#issuecomment-561604330 @flinkbot run travis This is an automated message from

[GitHub] [flink] JingsongLi commented on issue #10325: [FLINK-14512][table] Introduce listPartitionsByFilter to Catalog

2019-12-04 Thread GitBox
JingsongLi commented on issue #10325: [FLINK-14512][table] Introduce listPartitionsByFilter to Catalog URL: https://github.com/apache/flink/pull/10325#issuecomment-561618185 > Thanks @JingsongLi for the update. It seems the failed test is related? Yes, we should modify python too.

[jira] [Updated] (FLINK-15052) sql client doesn't clear previous job graph

2019-12-04 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-15052: --- Fix Version/s: 1.10.0 > sql client doesn't clear previous job graph >

[GitHub] [flink] TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments

2019-12-04 Thread GitBox
TisonKun commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#issuecomment-561525250 > Thanks @TisonKun I am afraid I could not test it as in Zeppelin I use `ScalaShellRemoteEnvironment` which is not

[GitHub] [flink] zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle.

2019-12-04 Thread GitBox
zhijiangW commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle. URL: https://github.com/apache/flink/pull/10375#discussion_r353595553 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353019073 ## File path: flink-python/pyflink/fn_execution/coder_impl.py ##

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353016856 ## File path: flink-python/pyflink/fn_execution/coder_impl.py ##

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353047775 ## File path: flink-python/pyflink/fn_execution/coder_impl.py ##

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353592042 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353590279 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353093687 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353088625 ## File path: flink-python/pyflink/fn_execution/coders.py ## @@

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353585748 ## File path:

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353024028 ## File path: flink-python/pyflink/fn_execution/coder_impl.py ##

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions

2019-12-04 Thread GitBox
WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python] Support complex data types in Python user-defined functions URL: https://github.com/apache/flink/pull/10086#discussion_r353025966 ## File path: flink-python/pyflink/fn_execution/coder_impl.py ##

[jira] [Commented] (FLINK-14567) Aggregate query with more than two group fields can't be write into HBase sink

2019-12-04 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987644#comment-16987644 ] Jark Wu commented on FLINK-14567: - Hi [~twalthr] [~ykt836], do you mean if the key information of sink

[GitHub] [flink] flinkbot edited a comment on issue #10408: [FLINK-14992][client] Add job listener to execution environments

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#issuecomment-561446399 ## CI report: * 26dba18b2fd51c8df67cc33eace890b5ca34e182 : CANCELED

[GitHub] [flink] flinkbot edited a comment on issue #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with …

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10415: [FLINK-15049][table-planner-blink] Compile error when hash join with … URL: https://github.com/apache/flink/pull/10415#issuecomment-561528911 ## CI report: * e838831b098e3043b6576aec5ba38ee6bdc29422 : PENDING

[GitHub] [flink] flinkbot commented on issue #10416: [FLINK-14484] Enable to control memory usage of RocksDB via Cache and WriteBufferManager

2019-12-04 Thread GitBox
flinkbot commented on issue #10416: [FLINK-14484] Enable to control memory usage of RocksDB via Cache and WriteBufferManager URL: https://github.com/apache/flink/pull/10416#issuecomment-561539660 ## CI report: * 32d4ffce9d515f19045ff5a13a9602f0b52d3196 : UNKNOWN Bot

[GitHub] [flink] zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode

2019-12-04 Thread GitBox
zhuzhurk commented on a change in pull request #10406: [FLINK-15045][runtime] Only log RestartStrategy in legacy scheduling mode URL: https://github.com/apache/flink/pull/10406#discussion_r353616472 ## File path:

[jira] [Commented] (FLINK-14567) Aggregate query with more than two group fields can't be write into HBase sink

2019-12-04 Thread Kurt Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987675#comment-16987675 ] Kurt Young commented on FLINK-14567: Basically yes. But this would involve the discussion about how

[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353634011 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353634713 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353634312 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353628831 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353632499 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353638111 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353625420 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties

2019-12-04 Thread GitBox
JingsongLi commented on a change in pull request #10403: [FLINK-14645][table] Support to keep nullability and precision when converting DataTypes to properties URL: https://github.com/apache/flink/pull/10403#discussion_r353625137 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#issuecomment-544813931 ## CI report: * 6f90b457e56a0a8cb45d63c1b05b47d2e38030a1 : SUCCESS

[GitHub] [flink] flinkbot edited a comment on issue #10333: [FLINK-14970]Doomed test for equality to NaN

2019-12-04 Thread GitBox
flinkbot edited a comment on issue #10333: [FLINK-14970]Doomed test for equality to NaN URL: https://github.com/apache/flink/pull/10333#issuecomment-559012637 ## CI report: * c5bd9898fbbeb3d668051475409b52bfb1e2 : UNKNOWN * 44f202263cbb26473b06ea19f293bf0b6afce8e6 :

[GitHub] [flink] StephanEwen commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString

2019-12-04 Thread GitBox
StephanEwen commented on issue #10358: [FLINK-14346] [serialization] faster implementation of StringValue writeString and readString URL: https://github.com/apache/flink/pull/10358#issuecomment-561582129 Some thoughts for follow-up: - Do you know where exactly the performance

[GitHub] [flink] zentol commented on a change in pull request #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint

2019-12-04 Thread GitBox
zentol commented on a change in pull request #10238: [FLINK-8949] Add dedicated watermarks metric retrieval endpoint URL: https://github.com/apache/flink/pull/10238#discussion_r353664553 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353667305 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353670935 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353669969 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353662612 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353663839 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353672881 ## File path:

[GitHub] [flink] wsry commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle.

2019-12-04 Thread GitBox
wsry commented on a change in pull request #10375: [FLINK-14845][runtime] Introduce data compression to reduce disk and network IO of shuffle. URL: https://github.com/apache/flink/pull/10375#discussion_r353673439 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353673315 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353671065 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353669265 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353667120 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory

2019-12-04 Thread GitBox
carp84 commented on a change in pull request #10329: [FLINK-12785][StateBackend] RocksDB savepoint recovery can use a lot of unmanaged memory URL: https://github.com/apache/flink/pull/10329#discussion_r353670772 ## File path:

[GitHub] [flink] StephanEwen commented on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator

2019-12-04 Thread GitBox
StephanEwen commented on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator URL: https://github.com/apache/flink/pull/10405#issuecomment-561599666 Hmmm, cannot reproduce it any more. There seem to have been some errors in the log files, but apparently not a

[GitHub] [flink] StephanEwen commented on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator

2019-12-04 Thread GitBox
StephanEwen commented on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator URL: https://github.com/apache/flink/pull/10405#issuecomment-561599795 Will merge this... This is an automated message from the

[GitHub] [flink] StephanEwen edited a comment on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator

2019-12-04 Thread GitBox
StephanEwen edited a comment on issue #10405: [FLINK-15044][e2e tests] Clean up TpcdsResultComparator URL: https://github.com/apache/flink/pull/10405#issuecomment-561599666 Hmmm, cannot reproduce it any more. There seem to have been some errors in the log files, but apparently not a

  1   2   3   4   5   6   7   8   9   10   >