[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-26 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r398411208 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-26 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r398412633 ## File path: flink-python/src/test/java/org/apache/flink/python/PythonO

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-26 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r398412276 ## File path: flink-python/src/main/java/org/apache/flink/python/PythonCo

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397888902 ## File path: flink-python/src/main/java/org/apache/flink/python/Abstrac

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397891371 ## File path: flink-python/src/test/java/org/apache/flink/python/PythonO

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397887635 ## File path: flink-python/src/main/java/org/apache/flink/python/Abstrac

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397887074 ## File path: flink-python/src/main/java/org/apache/flink/python/Abstrac

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397644867 ## File path: flink-python/src/main/java/org/apache/flink/python/metric/

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397637386 ## File path: flink-python/src/main/java/org/apache/flink/python/metric/

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397635988 ## File path: flink-python/src/main/java/org/apache/flink/python/PythonO

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397642149 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397577898 ## File path: docs/_includes/generated/python_configuration.html ###

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397592767 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397587599 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397635988 ## File path: flink-python/src/main/java/org/apache/flink/python/PythonO

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397641166 ## File path: flink-python/pyflink/metrics/tests/test_metric_it_case.py

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397597189 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397643391 ## File path: flink-python/src/main/java/org/apache/flink/python/metric/

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397590327 ## File path: flink-python/pyflink/metrics/metricbase.py ## @@

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397630414 ## File path: flink-python/src/main/java/org/apache/flink/python/Abstrac

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397639091 ## File path: flink-python/src/main/java/org/apache/flink/table/runtime/

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397644867 ## File path: flink-python/src/main/java/org/apache/flink/python/metric/

[GitHub] [flink] dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group

2020-03-25 Thread GitBox
dianfu commented on a change in pull request #11470: [FLINK-16671][python] Support for defining scopes and variables on Python metric group URL: https://github.com/apache/flink/pull/11470#discussion_r397637386 ## File path: flink-python/src/main/java/org/apache/flink/python/metric/