[GitHub] incubator-hawq issue #1266: HAWQ-1503 - Fixed ftp link causing build failure...

2017-07-14 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1266 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1260: Hawq 1492. Enable packaging for PXF JDBC ...

2017-06-29 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1260 Hawq 1492. Enable packaging for PXF JDBC plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain/incubator-hawq HAWQ-1492

[GitHub] incubator-hawq issue #1264: HAWQ-1499. Update README.md Travis CI status to ...

2017-07-06 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1264 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-01 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1249 HAWQ-1461. Improve partition parameters validation for PXF-JDBC plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain

[GitHub] incubator-hawq pull request #1249: HAWQ-1461. Improve partition parameters v...

2017-06-09 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-hawq pull request #1233: HAWQ-1454. Exclude certain jars from Rang...

2017-05-05 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1233 HAWQ-1454. Exclude certain jars from Ranger Plugin Service packaging You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain/incubator

[GitHub] incubator-hawq pull request #1293: [HAWQ-1533] Fix compiler warnings when bu...

2017-10-06 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1293 ---

[GitHub] incubator-hawq pull request #1283: HAWQ-1523. Provide ability to bundle PXF ...

2017-10-06 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1283 ---

[GitHub] incubator-hawq pull request #1294: HAWQ-1534. Change user to PXF_USER only f...

2017-10-03 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1294#discussion_r142545598 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -341,6 +358,14 @@ function validateParameters() exit 1 fi

[GitHub] incubator-hawq pull request #1294: HAWQ-1534. Change user to PXF_USER only f...

2017-10-03 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1294#discussion_r142545994 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -72,9 +77,11 @@ function createInstance() return 1 fi

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1301#discussion_r144382742 --- Diff: pxf/build.gradle --- @@ -310,6 +315,7 @@ project('pxf-service') { project.distTar { from('src/main/resources

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1301#discussion_r144383457 --- Diff: pxf/build.gradle --- @@ -310,6 +315,7 @@ project('pxf-service') { project.distTar { from('src/main/resources

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1301#discussion_r144386624 --- Diff: pxf/build.gradle --- @@ -310,6 +315,7 @@ project('pxf-service') { project.distTar { from('src/main/resources

[GitHub] incubator-hawq pull request #1301: Re-added pxf profile default to rpm and t...

2017-10-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1301#discussion_r144388153 --- Diff: pxf/build.gradle --- @@ -310,6 +315,7 @@ project('pxf-service') { project.distTar { from('src/main/resources

[GitHub] incubator-hawq issue #1301: Re-added pxf profile default to rpm and tar task...

2017-10-13 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1301 If pxf-private-default is not needed, then we should remove it. The less number of conf files we have, the better. ---

[GitHub] incubator-hawq pull request #1287: HAWQ-1527 Enabled partition filtering for...

2017-09-26 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1287#discussion_r141147551 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java --- @@ -418,8 +427,15 @@ private boolean

[GitHub] incubator-hawq pull request #1291: HAWQ-1531. Templetized PXF user and log d...

2017-09-28 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1291#discussion_r141679468 --- Diff: pxf/pxf-service/src/main/resources/pxf-log4j.properties --- @@ -23,7 +23,7 @@ log4j.rootLogger=INFO, ROLLINGFILE

[GitHub] incubator-hawq pull request #1293: [HAWQ-1533] Fix compiler warnings when bu...

2017-10-02 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1293 [HAWQ-1533] Fix compiler warnings when building PXF code You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain/incubator-hawq

[GitHub] incubator-hawq pull request #1283: HAWQ-1523. Provide ability to bundle PXF ...

2017-08-29 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1283 HAWQ-1523. Provide ability to bundle PXF artifacts into a single tarball You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain

[GitHub] incubator-hawq issue #1300: HAWQ-1538. Install internal profiles definition ...

2017-10-09 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1300 If the fix is working please feel free to merge. It is hard to review this kind of change. ---

[GitHub] incubator-hawq pull request #1294: HAWQ-1534. Change user to PXF_USER only f...

2017-10-03 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1294#discussion_r142551336 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -72,9 +77,11 @@ function createInstance() return 1 fi

[GitHub] incubator-hawq pull request #1303: HAWQ-1540. PXF should not accept paramete...

2017-10-23 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1303#discussion_r146359219 --- Diff: pxf/pxf-service/src/scripts/pxf-service --- @@ -206,24 +213,13 @@ function doInit() echo WARNING: instance already exists

[GitHub] incubator-hawq pull request #1322: Support Hive OpenCSVSerde

2017-12-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1322#discussion_r156481970 --- Diff: pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveLineBreakAccessor.java --- @@ -43,7 +43,7 @@ public

[GitHub] incubator-hawq pull request #1309: HAWQ-1545. Fix pxf-private.classpath file...

2017-11-07 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1309 HAWQ-1545. Fix pxf-private.classpath file for Cloudera tarball distro You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain

[GitHub] incubator-hawq issue #1365: Adding equals() to Fragment, to facilitate compa...

2018-05-15 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1365 https://ncrcoe.gitbooks.io/java-for-small-teams/content/specifics/100_know_how_to_implement_hashcode_and_equals.html ---

[GitHub] incubator-hawq pull request #1379: WIP: Cache UGI objects and clean them per...

2018-06-29 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1379 WIP: Cache UGI objects and clean them periodically You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain/incubator-hawq

[GitHub] incubator-hawq pull request #1379: WIP: Cache UGI objects and clean them per...

2018-07-02 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r199588824 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java --- @@ -42,8 +52,51

[GitHub] incubator-hawq issue #1379: WIP: Cache UGI objects and clean them periodical...

2018-07-02 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1379 @benchristel Will move the cache code and cleanup logic to a separate class as you suggested. ---

[GitHub] incubator-hawq issue #1304: HAWQ-1541. PXF configs shouldn't be part of pxf ...

2017-10-26 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1304 The profiles that are being included can just be a 2 or 3 profiles that are being used in the test rather than the whole file. This way we don't need to keep them in sync. ---

[GitHub] incubator-hawq pull request #1330: Change PXF port number to 5888

2018-01-17 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1330 Change PXF port number to 5888 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain/incubator-hawq pxf_port_change Alternatively

[GitHub] incubator-hawq issue #1330: Change PXF port number to 5888

2018-01-17 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1330 https://issues.apache.org/jira/projects/HAWQ/issues/HAWQ-1580 ---

[GitHub] incubator-hawq pull request #1334: Don't ignore exceptions during bridge.end...

2018-01-30 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1334#discussion_r164928261 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/WritableResource.java --- @@ -159,20 +159,16 @@ private static Response

[GitHub] incubator-hawq pull request #1334: Don't ignore exceptions during bridge.end...

2018-01-30 Thread lavjain
GitHub user lavjain opened a pull request: https://github.com/apache/incubator-hawq/pull/1334 Don't ignore exceptions during bridge.endIteration when writing to HDFS You can merge this pull request into a Git repository by running: $ git pull https://github.com/lavjain

[GitHub] incubator-hawq pull request #1309: HAWQ-1545. Fix pxf-private.classpath file...

2018-01-30 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1309 ---

[GitHub] incubator-hawq pull request #1330: HAWQ-1580. Change PXF port number to 5888...

2018-01-30 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1330 ---

[GitHub] incubator-hawq pull request #1334: HAWQ-1584. Don't ignore exceptions during...

2018-01-31 Thread lavjain
GitHub user lavjain reopened a pull request: https://github.com/apache/incubator-hawq/pull/1334 HAWQ-1584. Don't ignore exceptions during bridge.endIteration when writing to HDFS You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-hawq pull request #1334: HAWQ-1584. Don't ignore exceptions during...

2018-01-31 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1334 ---

[GitHub] incubator-hawq pull request #1334: HAWQ-1584. Don't ignore exceptions during...

2018-02-06 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1334 ---

[GitHub] incubator-hawq pull request #1334: HAWQ-1584. Don't ignore exceptions during...

2018-02-05 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1334#discussion_r166122917 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/WritableResource.java --- @@ -143,36 +142,38 @@ private static

[GitHub] incubator-hawq issue #1335: Add setting for cloudera manager

2018-02-05 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1335 @yk-st Your change looks good. However, it might be cleaner to create a separate template for CDH manager (eg `pxf-private-cdh-manager.classpath.template`) rather than substituting

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-26 Thread lavjain
Github user lavjain closed the pull request at: https://github.com/apache/incubator-hawq/pull/1379 ---

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-10 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r201510484 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/TimedProxyUGI.java --- @@ -0,0 +1,93 @@ +package

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202108154 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/SessionId.java --- @@ -65,12 +74,15 @@ public int hashCode

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202117665 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202118226 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -61,48 +64,51 @@ * create and destroy

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202118803 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -61,48 +64,51 @@ * create and destroy

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202119803 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202120502 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202121358 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -244,10 +246,10 @@ void setCleaned

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-12 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r202121962 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java --- @@ -52,69 +62,90

[GitHub] incubator-hawq pull request #1379: HAWQ-1622. Cache PXF proxy UGI so that cl...

2018-07-09 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r201091933 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java --- @@ -0,0 +1,129 @@ +package org.apache.hawq.pxf.service

[GitHub] incubator-hawq pull request #1379: WIP: Cache UGI objects and clean them per...

2018-07-04 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r200168483 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java --- @@ -89,32 +182,98 @@ public Boolean run

[GitHub] incubator-hawq pull request #1379: WIP: Cache UGI objects and clean them per...

2018-07-04 Thread lavjain
Github user lavjain commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/1379#discussion_r200169586 --- Diff: pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java --- @@ -89,32 +188,103 @@ public Boolean

[GitHub] incubator-hawq issue #1332: HAWQ-1581. Separate PXF system parameters from u...

2018-01-23 Thread lavjain
Github user lavjain commented on the issue: https://github.com/apache/incubator-hawq/pull/1332 pxf/pxf-service/src/scripts/pxf-service should not be part of this commit. pxf/pxf-jdbc/README.md needs to be updated ---