Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1322#discussion_r156481970
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveLineBreakAccessor.java
---
@@ -43,7 +43,7 @@
public
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1330
Change PXF port number to 5888
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq pxf_port_change
Alternatively
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1330
https://issues.apache.org/jira/projects/HAWQ/issues/HAWQ-1580
---
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1332
pxf/pxf-service/src/scripts/pxf-service should not be part of this commit.
pxf/pxf-jdbc/README.md needs to be updated
---
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1330
---
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1309
---
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1334
Don't ignore exceptions during bridge.endIteration when writing to HDFS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/la
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1334#discussion_r164928261
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/WritableResource.java
---
@@ -159,20 +159,16 @@ private static Response
GitHub user lavjain reopened a pull request:
https://github.com/apache/incubator-hawq/pull/1334
HAWQ-1584. Don't ignore exceptions during bridge.endIteration when writing
to HDFS
You can merge this pull request into a Git repository by running:
$ git pull https://githu
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1334
---
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1335
@yk-st Your change looks good. However, it might be cleaner to create a
separate template for CDH manager (eg
`pxf-private-cdh-manager.classpath.template`) rather than substituting the
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1334#discussion_r166122917
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/rest/WritableResource.java
---
@@ -143,36 +142,38 @@ private static
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1334
---
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1365
https://ncrcoe.gitbooks.io/java-for-small-teams/content/specifics/100_know_how_to_implement_hashcode_and_equals.html
---
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1379
WIP: Cache UGI objects and clean them periodically
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r199588824
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java
---
@@ -42,8 +52,51
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1379
@benchristel Will move the cache code and cleanup logic to a separate class
as you suggested.
---
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r200168483
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java
---
@@ -89,32 +182,98 @@ public Boolean run
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r200169586
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java
---
@@ -89,32 +188,103 @@ public Boolean
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r201091933
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -0,0 +1,129 @@
+package org.apache.hawq.pxf.service
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r201510484
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/TimedProxyUGI.java ---
@@ -0,0 +1,93 @@
+package
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202108154
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/SessionId.java ---
@@ -65,12 +74,15 @@ public int hashCode
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202117665
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202118226
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -61,48 +64,51 @@
* create and destroy
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202118803
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -61,48 +64,51 @@
* create and destroy
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202119803
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202120502
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -129,90 +135,93 @@ public void release(Entry timedProxyUGI
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202121358
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/UGICache.java ---
@@ -244,10 +246,10 @@ void setCleaned
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1379#discussion_r202121962
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/servlet/SecurityServletFilter.java
---
@@ -52,69 +62,90
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1379
---
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1233
HAWQ-1454. Exclude certain jars from Ranger Plugin Service packaging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1249
HAWQ-1461. Improve partition parameters validation for PXF-JDBC plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1249#discussion_r119728946
--- Diff: pxf/build.gradle ---
@@ -477,7 +481,7 @@ def buildNumber() {
}
task wrapper(type: Wrapper) {
-gradleVersion
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1249#discussion_r119774506
--- Diff:
pxf/pxf-jdbc/src/main/java/org/apache/hawq/pxf/plugins/jdbc/JdbcPartitionFragmenter.java
---
@@ -111,30 +110,40 @@ public
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1252
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1249
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1260
Hawq 1492. Enable packaging for PXF JDBC plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq HAWQ-1492
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1264
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1266
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1283
HAWQ-1523. Provide ability to bundle PXF artifacts into a single tarball
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1287#discussion_r141147551
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/HiveDataFragmenter.java
---
@@ -418,8 +427,15 @@ private boolean
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1291#discussion_r141679468
--- Diff: pxf/pxf-service/src/main/resources/pxf-log4j.properties ---
@@ -23,7 +23,7 @@ log4j.rootLogger=INFO, ROLLINGFILE
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1293
[HAWQ-1533] Fix compiler warnings when building PXF code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain/incubator-hawq
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1294#discussion_r142545598
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -341,6 +358,14 @@ function validateParameters()
exit 1
fi
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1294#discussion_r142545994
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -72,9 +77,11 @@ function createInstance()
return 1
fi
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1294#discussion_r142551336
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -72,9 +77,11 @@ function createInstance()
return 1
fi
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1293
---
Github user lavjain closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1283
---
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1300
If the fix is working please feel free to merge. It is hard to review this
kind of change.
---
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1301#discussion_r144380841
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
project.distTar {
from('src
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1301#discussion_r144382742
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
project.distTar {
from('src
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1301#discussion_r144383457
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
project.distTar {
from('src
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1301#discussion_r144386624
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
project.distTar {
from('src
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1301#discussion_r144388153
--- Diff: pxf/build.gradle ---
@@ -310,6 +315,7 @@ project('pxf-service') {
project.distTar {
from('src
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1301
If pxf-private-default is not needed, then we should remove it. The less
number of conf files we have, the better.
---
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1303#discussion_r146359219
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -206,24 +213,13 @@ function doInit()
echo WARNING: instance already exists
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1304
The profiles that are being included can just be a 2 or 3 profiles that are
being used in the test rather than the whole file. This way we don't need to
keep them in sync.
---
Github user lavjain commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1306#discussion_r148859336
--- Diff: pxf/pxf-service/src/scripts/pxf-service ---
@@ -249,6 +206,34 @@ function patchWebapp()
cat $web_file | \
sed
"s:
GitHub user lavjain opened a pull request:
https://github.com/apache/incubator-hawq/pull/1309
HAWQ-1545. Fix pxf-private.classpath file for Cloudera tarball distro
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavjain
60 matches
Mail list logo