[
https://issues.apache.org/jira/browse/HBASE-17397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797016#comment-15797016
]
stack commented on HBASE-17397:
---
Fixed. Thanks [~Apache9]
> AggregationClient cleanup
>
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797167#comment-15797167
]
stack commented on HBASE-17372:
---
Ok. Table specific defaults is good to have.
> Make AsyncTable thread
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar reopened HBASE-16010:
---
> Put draining function through Admin API
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-17315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796993#comment-15796993
]
Enis Soztutar commented on HBASE-17315:
---
Thanks Sudeep for the updated patch.
Is it possible to
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796990#comment-15796990
]
stack commented on HBASE-17372:
---
On the setting of rpc timeout table wide, the hard thing to reason about
[
https://issues.apache.org/jira/browse/HBASE-17409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797072#comment-15797072
]
Ted Yu commented on HBASE-17409:
{code}
235 if (callbackName.matches("[A-Za-z0-9]+")) {
{code}
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797224#comment-15797224
]
ramkrishna.s.vasudevan commented on HBASE-17373:
[~eshcar]
I could spend more time in the
[
https://issues.apache.org/jira/browse/HBASE-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-17390:
--
Attachment: HBASE-17390.master.003.patch
> Online update of configuration for all servers
Eshcar Hillel created HBASE-17407:
-
Summary: Correct update of maxFlushedSeqId in HRegion
Key: HBASE-17407
URL: https://issues.apache.org/jira/browse/HBASE-17407
Project: HBase
Issue Type:
[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794617#comment-15794617
]
Eshcar Hillel commented on HBASE-17407:
---
In HRegion::internalFlushCacheAndCommit() we have the
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794779#comment-15794779
]
Yu Li commented on HBASE-17372:
---
Thanks for the ping [~Apache9]. The latest v3 patch lgtm, good clean up,
[
https://issues.apache.org/jira/browse/HBASE-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794623#comment-15794623
]
Eshcar Hillel commented on HBASE-17379:
---
Moved the discussion to HBASE-17407.
> Lack of
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned HBASE-17227:
-
Assignee: Jan Hentschel
> Backport HBASE-17206 to branch-1.3
>
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-17227:
--
Attachment: HBASE-17227.branch-1.3.001.patch
> Backport HBASE-17206 to branch-1.3
>
[
https://issues.apache.org/jira/browse/HBASE-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794563#comment-15794563
]
Eshcar Hillel commented on HBASE-17379:
---
Thanks for looking into this [~Apache9].
I am opening a
[
https://issues.apache.org/jira/browse/HBASE-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794911#comment-15794911
]
Jan Hentschel commented on HBASE-13060:
---
There is already HBASE-14451 for updating HTrace to 4.0.1.
[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794590#comment-15794590
]
Eshcar Hillel commented on HBASE-17407:
---
Continuing the discussion started at
[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794629#comment-15794629
]
Duo Zhang commented on HBASE-17407:
---
Can we just remove the finalizeFlush method? It does not make
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-17227 started by Jan Hentschel.
-
> Backport HBASE-17206 to branch-1.3
> --
>
>
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-17227:
--
Status: Patch Available (was: In Progress)
> Backport HBASE-17206 to branch-1.3
>
[
https://issues.apache.org/jira/browse/HBASE-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794910#comment-15794910
]
Hadoop QA commented on HBASE-14451:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795336#comment-15795336
]
Hadoop QA commented on HBASE-17373:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795419#comment-15795419
]
Eshcar Hillel commented on HBASE-17373:
---
Last patch removed all unused code.
Please commit.
>
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795329#comment-15795329
]
Appy commented on HBASE-16010:
--
Sorry for late review, was away on vacation. Please consider making
[
https://issues.apache.org/jira/browse/HBASE-17370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795373#comment-15795373
]
Appy commented on HBASE-17370:
--
How about just adding the shell commands, should be sufficient, no? They'll
[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795278#comment-15795278
]
Eshcar Hillel commented on HBASE-17407:
---
Updating the WAL is not done in one atomic step;
It
[
https://issues.apache.org/jira/browse/HBASE-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794980#comment-15794980
]
huzheng commented on HBASE-17381:
-
Yeah, if OOME occur, we can handle it like region server main thread
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795061#comment-15795061
]
Hadoop QA commented on HBASE-17227:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eshcar Hillel updated HBASE-17373:
--
Attachment: HBASE-17373-V05.patch
> Reverse the order of snapshot creation in the
[
https://issues.apache.org/jira/browse/HBASE-17369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Appy updated HBASE-17369:
-
Affects Version/s: 2.0.0
> Add ACL to the new region server drain related API
>
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795026#comment-15795026
]
Duo Zhang commented on HBASE-17372:
---
Thanks [~carp84] for your reviewing. Will add a release note
[
https://issues.apache.org/jira/browse/HBASE-17390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795125#comment-15795125
]
Hadoop QA commented on HBASE-17390:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794967#comment-15794967
]
Duo Zhang commented on HBASE-17227:
---
The backport is straight-forward so I'm +1 on the patch. But
[
https://issues.apache.org/jira/browse/HBASE-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795023#comment-15795023
]
huzheng commented on HBASE-17381:
-
The trouble is: we need to list recoverable and un-recoverable cases ,
[
https://issues.apache.org/jira/browse/HBASE-17403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795688#comment-15795688
]
Ted Yu commented on HBASE-17403:
lgtm
> ClientAsyncPrefetchScanner doesn’t load any data if the
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-17408:
---
Description:
HBASE-16224 introduced hbase.client.max.perrequest.heapsize to limit the amount
of data sent
[
https://issues.apache.org/jira/browse/HBASE-17403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795724#comment-15795724
]
ChiaPing Tsai commented on HBASE-17403:
---
Thanks for your review
> ClientAsyncPrefetchScanner
Ted Yu created HBASE-17408:
--
Summary: Introduce per request limit by number of mutations
Key: HBASE-17408
URL: https://issues.apache.org/jira/browse/HBASE-17408
Project: HBase
Issue Type:
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795755#comment-15795755
]
Ted Yu commented on HBASE-17408:
See HBASE-17387 for some background.
The OOME was likely caused by
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795948#comment-15795948
]
stack commented on HBASE-17372:
---
Patch looks good. Nice cleanup. Only downside is extra API but I think now
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795830#comment-15795830
]
stack commented on HBASE-17372:
---
Thanks [~carp84]. Yes. We need a writeup. I can do it in a new issue.
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795951#comment-15795951
]
stack commented on HBASE-17372:
---
What do we do w/ the read/write rpc timeouts now? Thanks.
> Make
[
https://issues.apache.org/jira/browse/HBASE-15866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795822#comment-15795822
]
stack commented on HBASE-15866:
---
We need a release note here for this significant change. Please make a
[
https://issues.apache.org/jira/browse/HBASE-17394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796647#comment-15796647
]
huaxiang sun commented on HBASE-17394:
--
Update, the current logic is correct, for TimeRangeTracker,
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796815#comment-15796815
]
Enis Soztutar commented on HBASE-16010:
---
I actually want to fix the drain script, move away from it
[
https://issues.apache.org/jira/browse/HBASE-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796230#comment-15796230
]
stack commented on HBASE-17379:
---
[~tedyu], three different folks suggested you NOT work on this patch and
[
https://issues.apache.org/jira/browse/HBASE-17100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvel Thirumoolan updated HBASE-17100:
-
Status: Open (was: Patch Available)
Cancelling the patch, this functionality is
[
https://issues.apache.org/jira/browse/HBASE-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796787#comment-15796787
]
Hadoop QA commented on HBASE-17281:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796251#comment-15796251
]
Ted Yu commented on HBASE-17379:
I have been working with [~eshcar] on a desirable solution.
The latest
Josh Elser created HBASE-17409:
--
Summary: Re-fix XSS request issue in JMXJsonServlet
Key: HBASE-17409
URL: https://issues.apache.org/jira/browse/HBASE-17409
Project: HBase
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/HBASE-17409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-17409:
---
Status: Patch Available (was: Open)
> Re-fix XSS request issue in JMXJsonServlet
>
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796349#comment-15796349
]
stack commented on HBASE-17408:
---
bq. Ted, giving more context definitely helps others to follow along.
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796477#comment-15796477
]
Enis Soztutar commented on HBASE-17372:
---
Plus, Table is NOT thread-safe, should AsyncTable be?
>
[
https://issues.apache.org/jira/browse/HBASE-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796479#comment-15796479
]
Ted Yu commented on HBASE-17290:
[~ashish singhi]:
What do you think ?
> Potential loss of data for
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796779#comment-15796779
]
Jerry He commented on HBASE-16010:
--
bq. Would be great to use Enis's above suggestion. Instead of
[
https://issues.apache.org/jira/browse/HBASE-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796451#comment-15796451
]
Thiruvel Thirumoolan commented on HBASE-17281:
--
Thanks [~toffer]! Updated the latest patch
[
https://issues.apache.org/jira/browse/HBASE-17409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-17409:
---
Attachment: HBASE-17409.001.patch
> Re-fix XSS request issue in JMXJsonServlet
>
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796469#comment-15796469
]
Enis Soztutar commented on HBASE-17372:
---
Do we really need the OperationConfig to be specified
[
https://issues.apache.org/jira/browse/HBASE-17370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796812#comment-15796812
]
Jerry He commented on HBASE-17370:
--
There are existing ruby scrips (draining_servers.rb,
[
https://issues.apache.org/jira/browse/HBASE-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvel Thirumoolan updated HBASE-17281:
-
Attachment: HBASE-17281.master.003.patch
> FN should use datanode port from hdfs
[
https://issues.apache.org/jira/browse/HBASE-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar updated HBASE-17395:
--
Fix Version/s: HBASE-14850
> [C++] Use custom line wrapping in formatting
>
[
https://issues.apache.org/jira/browse/HBASE-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar updated HBASE-17395:
--
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796238#comment-15796238
]
Enis Soztutar commented on HBASE-17408:
---
Ted, giving more context definitely helps others to follow
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796273#comment-15796273
]
Ted Yu commented on HBASE-17408:
Thanks for providing more background, [~enis]
I was waiting for server
[
https://issues.apache.org/jira/browse/HBASE-17409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796832#comment-15796832
]
Hadoop QA commented on HBASE-17409:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jerry He reassigned HBASE-16010:
Assignee: Jerry He (was: Matt Warhaftig)
> Put draining function through Admin API
>
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796975#comment-15796975
]
Duo Zhang commented on HBASE-17372:
---
You can see the discussion in HBASE-17361. I'm neutral on whether
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-17373:
--
Resolution: Fixed
Fix Version/s: 2.0.0
Status: Resolved (was: Patch Available)
> Reverse
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797013#comment-15797013
]
stack commented on HBASE-17373:
---
Pushed to master. Thanks for the patch [~eshcar] (sorry for delay
[
https://issues.apache.org/jira/browse/HBASE-17110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797133#comment-15797133
]
Ted Yu commented on HBASE-17110:
Charlie:
Mind attaching patch for branch-1 (so that we can resolve this
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797225#comment-15797225
]
ramkrishna.s.vasudevan commented on HBASE-17373:
BTW I see that this has already been
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796881#comment-15796881
]
Jerry He commented on HBASE-16010:
--
This is good plan, if I missed it earlier!
Ok. let us change the
[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796938#comment-15796938
]
Duo Zhang commented on HBASE-17407:
---
{quote}
It starts with startCacheFlush(), ends with
[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797114#comment-15797114
]
Duo Zhang commented on HBASE-17372:
---
{quote}
What is happening in AsyncConnectionConfiguration? We are
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797288#comment-15797288
]
Edward Bortnikov commented on HBASE-17373:
--
... And once again, this delicate case should be
[
https://issues.apache.org/jira/browse/HBASE-17381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15794980#comment-15794980
]
huzheng edited comment on HBASE-17381 at 1/4/17 2:00 AM:
-
Yeah, if OOME occur, we
[
https://issues.apache.org/jira/browse/HBASE-17395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797004#comment-15797004
]
Sudeep Sunthankar commented on HBASE-17395:
---
[~enis], There seems to be some issue with this
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797247#comment-15797247
]
stack commented on HBASE-17373:
---
Want me to revert [~ram_krish] ? Or I can apply a follow up if [~anastas]
[
https://issues.apache.org/jira/browse/HBASE-17373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797283#comment-15797283
]
Edward Bortnikov commented on HBASE-17373:
--
Mind not reverting please? Seems that this issue is
[
https://issues.apache.org/jira/browse/HBASE-17370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797365#comment-15797365
]
Appy commented on HBASE-17370:
--
I think we should go the way of making shell THE way of doing such admin
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797412#comment-15797412
]
Appy commented on HBASE-16010:
--
bq. There is currently a slight difference between 'drain mode' and
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795722#comment-15795722
]
ChiaPing Tsai commented on HBASE-17408:
---
bq. We should consider adding per request limit through
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795756#comment-15795756
]
stack commented on HBASE-17408:
---
Yes, why? What was the problem.
> Introduce per request limit by number
[
https://issues.apache.org/jira/browse/HBASE-17218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enis Soztutar reassigned HBASE-17218:
-
Assignee: Enis Soztutar (was: Sudeep Sunthankar)
> [C++] Use Google Style guide and
[
https://issues.apache.org/jira/browse/HBASE-17408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796011#comment-15796011
]
stack commented on HBASE-17408:
---
Suggest that you have evidence stronger than 'likely' before you go about
85 matches
Mail list logo
