[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805505#comment-16805505 ] Sean Busbey commented on HBASE-18995: - closed jira issues don't see much monitoring. You should raise your question on dev@hbase. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4, 2.0.0 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805467#comment-16805467
]
Thomas D'Silva commented on HBASE-18995:
[~ram_krish] In HBase 2.0 since {{CellUtil.setTimestamp}} has been deprecated,
what is the correct way to set the timestamp of a cell from a coprocessor?
Phoenix uses this for our mutable indexing coprocessor (see PHOENIX-5219).
FYI [~abhishek.chouhan] and [~lhofhansl]
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4, 2.0.0
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch,
> HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch,
> HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch,
> HBASE-18995_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236520#comment-16236520 ] Mike Drob commented on HBASE-18995: --- Thanks for the analysis here [~ram_krish]. I'll file a new JIRA for exposing some additional stuff and we can discuss there. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227066#comment-16227066 ] ramkrishna.s.vasudevan commented on HBASE-18995: I read the Crunch projec't hbase-support related code. -> It uses both CellUtil (Public exposed) and KeyValueUtil (@Private) classes for helper methods. -> All methods in CellUtil that are getting used are even now exposed in branch-2's CellUtil and they are very common helper methods. So we are safe here. -> Wrt KeyValueUtil the API is createFirstOnRow(). It is used in test cases and in some core code. In most of the places they are trying to create the splitKeys from the region's start keys and that is also getting persisted. I think here they can safely create a cell out of the given byte[] of the row. But there is one place where they are trying to do some scanning on a HFileScanner directly (@Private) scanner. So this should be changed because it is an internal interface for us. And on this scanner they have copied our seekTo() code into their source files for some scanning purpose. In this code they are actually using the KvUtil.createFirstOnRow() to seek to that first cell of that row. More over I think in branch-2 we are restricting even CPs from accessing some of our internal scanners and they can only use InternalScanner interface. So this code in crunch needs heavy refactoring to work with branch-2 in case they want to fit into the Public/Private exposed semantics that HBase presents to the downstreamers. -> If still they want some APIs like this we can expose CellUtil#createFirstOnRow, createLastOnRow, createFirstOnCol and createLastOnCol at the maximum. I think others are not useful and are more internal stuffs. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227029#comment-16227029 ] ramkrishna.s.vasudevan commented on HBASE-18995: Thanks Stack will check and report back here. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226821#comment-16226821 ] stack commented on HBASE-18995: --- Just check out apache crunch [~ram_krish] > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226301#comment-16226301 ] ramkrishna.s.vasudevan commented on HBASE-18995: bq.We need to help Crunch get up on the factory and builders. Yes. Agree. Can you get us a link to the code base to see what is the use of createFirstOnRow and how it is getting used in their code flow. If it is possible can we suggest alternates? Its good to know people use these APIs even in client side usages. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226275#comment-16226275 ] stack commented on HBASE-18995: --- bq. I think createFirstOnRow is the only one that is missed? Yes. I see too why you'd want to hide the others Crunch is using. We need to help Crunch get up on the factory and builders. It is fair to call it client-side code (MR/Spark and misc). Thanks. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226264#comment-16226264 ] ramkrishna.s.vasudevan commented on HBASE-18995: bq. I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already? I left it because they are still exposed in 2.0. You mean they are left over in 3.0 also? If so it is my mistake. I have to remove them. bq.Are there methods from PrivateCellUtil you want to expose to Coprocessors? As said in the other JIRA. We need to know what others can we expose. We can definitely move some more to the LPCellUtil which needs to be exposed but for now I can see Tag related APIs. But coming to createfirstOnRow(), createLastOnRow() - that is something internal. Why should that be in CellUtil? In one of the review comments it was discussed we need not expose them. I am fine if there is an usage but again there are lot of variants which are not worth exposing we need to see which are really useful and which are internally used. In the list of APIs used by Crunch I think createFirstOnRow is the only one that is missed? All other APIs are still available in Public CellUtil. So this project Crunch is it a CP based project or is it a client side code? bq.(static methods on interfaces is one of the benefits of us being on jdk8 now: ref) I like this idea. How ever I think what needs to go as static methods in Cell interface is still questionable because there are cases like this createFirstOnRow() which goes to IA.Private but Cell does not have it and still it is not helping them. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226208#comment-16226208 ] Sean Busbey commented on HBASE-18995: - Moving stuff into PrivateCellUtil is a bad idea, IMHO. Method level annotations work fine. If someone is going to ignore a method being IA.Private, they're also going to ignore a class being IA.Private. We already hide them from our downstream facing javadocs. If we need more, we can invest the time in making an enforcer rule that folks can opt-into. If we want to make some CellUtil methods "more public" why not just move them to be static methods on the Cell interface and mark all of CellUtil as deprecated / going IA.Private in HBase 3? (static methods on interfaces is one of the benefits of us being on jdk8 now: [ref|https://docs.oracle.com/javase/tutorial/java/IandI/defaultmethods.html#static]) This has the nice side effect of starting to undo all of the FooUtil classes that litter our codebase. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226094#comment-16226094
]
stack commented on HBASE-18995:
---
The use case [~mdrob] ran into was CellUtil.createFirstOnRow. Its not in
CellUtil anymore [~ram_krish]
Here are other uses of CellUtil by Crunch:
{code}
./crunch-hbase/src/it/java/org/apache/crunch/io/hbase/HFileTargetIT.java:
Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c));
./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileOutputFormatForCrunch.java:
InetSocketAddress preferredNodeForRow =
regionLocationTable.getPreferredNodeForRow(CellUtil.cloneRow(cell));
./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:
return ByteBuffer.wrap(CellUtil.cloneRow(input));
./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:
LOG.debug("split row: " + Bytes.toString(CellUtil.cloneRow(kv)));
./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:
emitter.emit(ByteBuffer.wrap(CellUtil.cloneRow(foundCell)));
./crunch-spark/src/it/java/org/apache/crunch/SparkHFileTargetIT.java:
Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c));
{code}
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch,
> HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch,
> HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch,
> HBASE-18995_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226036#comment-16226036 ] stack commented on HBASE-18995: --- [~ram_krish] I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already? Are there methods from PrivateCellUtil you want to expose to Coprocessors? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226026#comment-16226026 ] stack commented on HBASE-18995: --- [~mdrob] Annotating on the method-level is unusual in the codebase. Usual is to annotate on the class. Some methods remain annotated Private in CellUtil even after this change but I think the sense is that this is a failing to be fixed. We are having trouble with CellUtil and TagUtil and a profusion of classes colored by access. Annotation by method might help. Background. Much of the alpha-4 project (and before this) is about shutting down access to internals either removing private classes as parameters to Coprocessors or sorting classes by private and public portions (usually returning an Interface that has the public methods but internally we'll use the implementation that allows access to all methods or populating Coprocessor Environments/Context with methods that have been properly santized). This CellUtil (and TagUtil) are a little difficult. Their static methods generally so options are less. A long running project has been about undoing dependence on our internal Cell representation so we can change it one day. There are Factories and Builders if you want to make Cells. We want to steer folks this direction. CellUtil is peppered with methods that are for nought but internal devs and a particular context. Hiding them from non-devs saves them trouble should the format change. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225805#comment-16225805
]
Mike Drob commented on HBASE-18995:
---
Hold up... right in the CellUtil javadoc it has...
(before the changes)
{noformat}
* Utility methods helpful slinging {@link Cell} instances.
* Some methods below are for internal use only and are marked
InterfaceAudience.Private at the
* method level.
{noformat}
So I don't understand the motivation for moving things to a new class when they
were already annotated?
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch,
> HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch,
> HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch,
> HBASE-18995_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223386#comment-16223386 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-2.0 #759 (See [https://builds.apache.org/job/HBase-2.0/759/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev efb5d7b24df5111cd0f4d4282a1ffd6c98ef405a) * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223324#comment-16223324 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3959 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3959/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev bfaacfdba306061477d3103754fd5c5ac3612e1b) * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223236#comment-16223236 ] ramkrishna.s.vasudevan commented on HBASE-18995: Thanks a ton for taking this through [~saint@gmail.com]. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223169#comment-16223169 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-2.0 #758 (See [https://builds.apache.org/job/HBase-2.0/758/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev 250a8bc7ad05080692b461a28f6fe1fa614b5830) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java * (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java * (edit)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223166#comment-16223166 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3958 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3958/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev f6c2490b82968f33e7d7db0b96896eebdf745e19) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222765#comment-16222765 ] Appy commented on HBASE-18995: -- Good work drawing the boundary in utils. Can move it around in followups if something needs to get out in public or get inside private. +1 > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222665#comment-16222665 ] stack commented on HBASE-18995: --- Should I commit this [~ram_krish]? I can address javadoc and whitespace on commit. We still need this? // TODO : Make Tag IA.LimitedPrivate and move some of the Util methods to CP exposed Util class Is this a follow-on? We can do teething issues w/ this patch in a follow-on? Meantime this is a big change so good to land it? Thanks. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222495#comment-16222495
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 47 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
50s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
54s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
51s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 1s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
17s{color} | {color:red} hbase-common generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
12s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
30s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
28s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m
47s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
48s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
52s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}193m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222173#comment-16222173
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-18995 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18995 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894338/HBASE-18995_2.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9449/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch,
> HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch,
> HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222162#comment-16222162 ] ramkrishna.s.vasudevan commented on HBASE-18995: The same patch which did not run against branch-2 this time ran. I have corrected the whitespace and the javadoc thing in both master and branch-2. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222148#comment-16222148
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 49 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
24s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
13s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
7s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
36s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
18s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
45s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 4 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
45m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
15s{color} | {color:red} hbase-common generated 6 new + 0 unchanged - 0 fixed =
6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
10s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
32s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 93m
1s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
44s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
57s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 37s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221824#comment-16221824
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-18995 does not apply to branch-2. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-18995 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894293/HBASE-18995_002-branch-2.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9446/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch,
> HBASE-18995_002-branch-2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221804#comment-16221804 ] Anoop Sam John commented on HBASE-18995: Can u try with name as HBASE-18995_002-branch-2.patch ? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221761#comment-16221761 ] ramkrishna.s.vasudevan commented on HBASE-18995: I don't know what is wrong with the patch name. So I have to prepare a patch against master now. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221759#comment-16221759
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-18995 does not apply to branch-2. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-18995 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894284/HBASE-18995-branch-2.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9442/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.002.patch,
> HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221753#comment-16221753 ] stack commented on HBASE-18995: --- Thanks for name change Ram. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221748#comment-16221748
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-18995 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18995 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894281/HBASE-18995-branch-2_2.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9441/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221715#comment-16221715 ] ramkrishna.s.vasudevan commented on HBASE-18995: bq.Also, let's commit this to both master and branch-2? Reason being, removing all this stuff now will make backports hard. Let's remove them after 2.0 release. We may need another Util class just for CP and that is where the Tag related things may come in. So I think it is better we push this in first as is and then work on that other tasks to create CPCellUtil. And regarding the commit I think we will commit now to branch-2 and master as is and later work on removing the deprecated methods. File a blocker against 3.0 and work with that JIRA? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221712#comment-16221712 ] ramkrishna.s.vasudevan commented on HBASE-18995: [~appy] and [~saint@gmail.com] Thanks for your comments on RB. I have replied to most of your comments. Let me know what you think. Patch wise nothing much to change except for renaming to InternalCellUtil to privateCellUtil. I am fine with any of these two names. I first named it as PrivatecellUtil but since already @PRivate tag was there I thought InternalCellUtil is better. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221416#comment-16221416 ] stack commented on HBASE-18995: --- I like the @appy review comments on Util naming. PrivateCellUtil to match the IA annotation sounds good. Let me review more up on RB. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221135#comment-16221135 ] Appy commented on HBASE-18995: -- Skimming rest of the patch, looks okay. Confused on the part where we are removing functions which aren't really exposing anything extra/new, they are just convenience functions. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16221031#comment-16221031
]
Appy commented on HBASE-18995:
--
I seem some duplication of code (For eg. {{boolean matchingQualifier(final Cell
left, }}. If we are moving fns to internal one and marking them deprecated
in public one, let's redirect calls to InternalUtil's fns instead.
As for naming, unless you already have a name for LP CellUtil in mind, let's
think it through with future naming needs in perspective. I'd suggest following
naming - CellUtil, LPCellUtil, PrivateCellUtil
(PublicCU, LPCU, and CU would have been better, but hands tied :-( )
Also, let's commit this to both master and branch-2? Reason being, removing
all this stuff now will make backports hard. Let's remove them after 2.0
release.
In fact, i think it'd probably be a better strategy to delete stuff marked for
removal things in version X close to release of X - maximum compat for
backports.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18995-branch-2.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch,
> HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220010#comment-16220010 ] Anoop Sam John commented on HBASE-18995: bq.So any name for the InternalCellUtil ? Will change it and then upload to RB. I think this is ok. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220005#comment-16220005 ] ramkrishna.s.vasudevan commented on HBASE-18995: Ok makes sense. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219994#comment-16219994 ] Anoop Sam John commented on HBASE-18995: I would say make this new Internal Util class as Private for this jira and commit. Tag making LP and making a LP util class can be done as part of another issue. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219960#comment-16219960 ] ramkrishna.s.vasudevan commented on HBASE-18995: For the CP expose thing I agree - like not all would be needed. But still if it is exposed to CP do you think it will be misused? Making Tag LimitedPRivate should be a seperate task and yes when we do that all the related Util APIs also should move. So do you say that for this JIRA itself we need split and first ensure the Tag is made LP and then move related classes to that and then create another PRivate Util class to move all other APIs to it? bq.The ones with offset, length and all, ya lets keep in private util If we are going to have for CPs then we can have all versions and types of matchingXXX in the CP version only IMHO. bq.. Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them Yes this has been done. Infact the API that take byteRange and write to specific byte etc can actually directly removed since I don't think anyone will even use it but since we follow some version control mechanism I thought for 2.0 lets go this way of deprecate and then remove them though it may be unnecessary. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219215#comment-16219215 ] Anoop Sam John commented on HBASE-18995: Just summarizing the points from RB comments and replies. 1. I was saying abt the need for a non public but LP for CP util class.. I did not see the new Util already with LP for CP. Then we will need 3 Utils. CellUtil public, an LP exposed one and a private one. We have many APIs which not even to be given to CPs. 2. Ya we better make Tag also LP and have the related methods moved to CP exposed Util class. May be we can even remove those APIs from public CellUtil with out deprecation cycle? Because no user would have been using it in client side as we never exposed Tags in client side. Ya CP side would have been using but any way lots of BC breaks around CP 3. Matching APIs ya lets keep the ones which take Cells as param and Cell and byte[] as params in LP class. It will be useful for CPs. The ones with offset, length and all, ya lets keep in private util 4. We have APIs like write parts of cells to OS etc. All these can be in private CellUtil. Those which work on ByteRange also. 5. Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them Any other points. Feel free to split this entire thig as a follow on jira also as needed. The hard thing would be to get names for diff levels of exposed classes :-) > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219205#comment-16219205 ] ramkrishna.s.vasudevan commented on HBASE-18995: Resubmitting for QA. I have kept InternalCellUtil as is till I get a better name. CoprocessorCellUtil seems not good to me. This is mainly for QA to see any findbugs warning and test case issues. Because in last run there was a stack overflow exception because of one change. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219149#comment-16219149 ] stack commented on HBASE-18995: --- bq. I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags? Good point. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219128#comment-16219128 ] ramkrishna.s.vasudevan commented on HBASE-18995: bq.License text is mangled in a few files. Will fix them. bq.Or I suppose, it still holds. The Private methods have been Deprecated. Currently some of them have been deprecated. Only in 3.0 we could actually change that comment and remove all the deprecated ones. bq. don't like the name InternalCellUtil but it is explicit as to its use. Any better name? bq.Change this? 47 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd say. I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217732#comment-16217732
]
Hadoop QA commented on HBASE-18995:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 29 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
51s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
29s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
25s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 8m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
6s{color} | {color:red} hbase-server in branch-2 has 1 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
46s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
8s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
16s{color} | {color:red} hbase-common generated 4 new + 0 unchanged - 0 fixed =
4 total (was 0) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
9s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
31s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 41s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 32s{color}
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 49s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
52s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}153m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[
https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217605#comment-16217605
]
stack commented on HBASE-18995:
---
License text is mangled in a few files.
Fix this text on CellUtil:
46 * Utility methods helpful slinging {@link Cell} instances. Some
methods below are for internal use
47 * only and are marked InterfaceAudience.Private at the method level.
Or I suppose, it still holds. The Private methods have been Deprecated.
Deprecation in CellUtil is good.
I don't like the name InternalCellUtil but it is explicit as to its use.
Change this? 47
@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd
say... CPs messing w/ Cells other than Reading is not to be encouraged I'd say
(They can construct over in CellUtil...)
Skimmed... looking good.
> Move methods that are for internal usage from CellUtil to Private util class
>
>
> Key: HBASE-18995
> URL: https://issues.apache.org/jira/browse/HBASE-18995
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0-alpha-3
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18995-branch-2.patch
>
>
> This was brought up long time back. We need to move some of the public APIs
> from CellUtil to internal private Util class because they are used in some
> internal flow and does not make sense to have it in a @public exposed Util
> class.
> The topic again came in HBASE-18945 RB comments also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214746#comment-16214746 ] ramkrishna.s.vasudevan commented on HBASE-18995: Just moved this under HBASE-18169 so that we don't lose track of this JIRa. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-beta-1 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208005#comment-16208005 ] ramkrishna.s.vasudevan commented on HBASE-18995: I have updated the release version. If I can complete it early then fine else let it go into beta1. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-beta-1 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207816#comment-16207816 ] Mike Drob commented on HBASE-18995: --- Does this need to be in a4? I don't see it affecting CP APIs, maybe safe for b1? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205738#comment-16205738 ] Anoop Sam John commented on HBASE-18995: Some of these APIs which need to be moved out of CellUtil might be added in 2.0 only? If so, we can safely move out. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205685#comment-16205685 ] Chia-Ping Tsai commented on HBASE-18995: If the patch will change many files, it would be better to keep branch-2 and master same as much as possible. The conflicts happens on applying master patch to branch-2 can kill us in the future. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205667#comment-16205667 ] ramkrishna.s.vasudevan commented on HBASE-18995: I can see some methods related to createCell have already gone through deprecate cycle for 2.0. Will follow the same. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205541#comment-16205541 ] ramkrishna.s.vasudevan commented on HBASE-18995: Should we follow Deprecation cycle for 2.0 and only in master branch move the API from CellUtil? > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
