[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=444788=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444788
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 12/Jun/20 09:47
Start Date: 12/Jun/20 09:47
Worklog Time Spent: 10m
Work Description: kgyrtkirk merged pull request #1063:
URL: https://github.com/apache/hive/pull/1063
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 444788)
Time Spent: 2h (was: 1h 50m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> {code:java}
> mvn test-compile findbugs:findbugs -pl storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=444502=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-444502
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 11/Jun/20 19:03
Start Date: 11/Jun/20 19:03
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #1063:
URL: https://github.com/apache/hive/pull/1063#issuecomment-642872942
I've made some changes to accept jenkinsfile changes - it should work from
now on
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 444502)
Time Spent: 1h 50m (was: 1h 40m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> {code:java}
> mvn test-compile findbugs:findbugs -pl storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=443209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-443209
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 09/Jun/20 16:42
Start Date: 09/Jun/20 16:42
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436654787
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##
@@ -78,13 +79,21 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuilder sb = new StringBuilder();
if (cacheBuffers != null) {
-for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+Iterator iter = cacheBuffers.iterator();
+while (iter.hasNext()) {
+ MemoryBuffer mb = iter.next();
+ sb.append(mb.getClass().getSimpleName());
+ sb.append(" with ");
+ sb.append(mb.getByteBufferRaw().remaining());
+ sb.append(" bytes");
+ if (iter.hasNext()) {
+sb.append(", ");
Review comment:
Tests passed so this change should be safe.
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/DiskRangeList.java
##
@@ -228,6 +228,16 @@ public long getTotalLength() {
return result;
}
+ @Override
+ public int hashCode() {
+return super.hashCode();
+ }
+
+ @Override
+ public boolean equals(Object other) {
+return super.equals(other);
Review comment:
Addressed as part of 0e40c954e3aa7af7e932b1b26091012707b80fe2
As discussed, let's make sure we update such methods across packages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 443209)
Time Spent: 1h 40m (was: 1.5h)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> {code:java}
> mvn test-compile findbugs:findbugs -pl storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442015=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442015
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:58
Start Date: 05/Jun/20 19:58
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436136581
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##
@@ -78,13 +79,21 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuilder sb = new StringBuilder();
if (cacheBuffers != null) {
-for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+Iterator iter = cacheBuffers.iterator();
+while (iter.hasNext()) {
+ MemoryBuffer mb = iter.next();
+ sb.append(mb.getClass().getSimpleName());
+ sb.append(" with ");
+ sb.append(mb.getByteBufferRaw().remaining());
+ sb.append(" bytes");
+ if (iter.hasNext()) {
+sb.append(", ");
Review comment:
Will have to check this. I think from my own patch experience, that
this change might break a bunch of unit tests because they are checking the
output of `toString()` which previously always adds a comma, even if it's not
really needed. I'm not 100%, but just FYI.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442015)
Time Spent: 1.5h (was: 1h 20m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442011=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442011
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:43
Start Date: 05/Jun/20 19:43
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436127720
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##
@@ -78,13 +78,13 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuffer bufStr = new StringBuffer();
if (cacheBuffers != null) {
for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ bufStr.append(mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ");
Review comment:
Updated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442011)
Time Spent: 1h 20m (was: 1h 10m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442007=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442007
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:38
Start Date: 05/Jun/20 19:38
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436125496
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##
@@ -78,13 +78,13 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuffer bufStr = new StringBuffer();
if (cacheBuffers != null) {
for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ bufStr.append(mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ");
Review comment:
Hey @belugabehr -- I see your point.
Sure, happy to integrate HIVE-23540 here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442007)
Time Spent: 1h 10m (was: 1h)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=442003=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442003
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 19:22
Start Date: 05/Jun/20 19:22
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436118081
##
File path:
storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
##
@@ -78,13 +78,13 @@ public void setIndexBaseOffset(int indexBaseOffset) {
@Override
public String toString() {
- String bufStr = "";
+ StringBuffer bufStr = new StringBuffer();
if (cacheBuffers != null) {
for (MemoryBuffer mb : cacheBuffers) {
- bufStr += mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ";
+ bufStr.append(mb.getClass().getSimpleName() + " with " +
mb.getByteBufferRaw().remaining() + " bytes, ");
Review comment:
I think it's a little bit more than this. There shouldn't be any "+"
concatenation. Should all be `.append()`
I already proposed to addressed this issue (HIVE-23540), but happy to defer
to this PR
https://issues.apache.org/jira/browse/HIVE-23540
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 442003)
Time Spent: 1h (was: 50m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441949=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441949
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:58
Start Date: 05/Jun/20 17:58
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436076795
##
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
If we are defining our own annotation, I would like to put it in a
common to prevent each module having their own copy of the same annotation. I
thought hive-common would be a good candidate but storage-api does not depend
on hive-common either. This looks like the only way then. Thanks for the link.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441949)
Time Spent: 50m (was: 40m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441932=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441932
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:39
Start Date: 05/Jun/20 17:39
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436063677
##
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
Hey @mustafaiman -- in the main pom.xml we are only using the
finbugs-maven-plugin and not the findbugs-annotation package (only hive-ql is
using it as dependency and I would like to remove it eventually).
In order to avoid adding just another dependency (findbugs-annotation), I
implemented the annotation as a separate class, Findbugs doesn't care in which
package the annotation is, so it works pretty well -- we can also reuse it
across hive packages.
https://sourceforge.net/p/findbugs/feature-requests/298/#5e88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441932)
Time Spent: 40m (was: 0.5h)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441926=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441926
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:32
Start Date: 05/Jun/20 17:32
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436063677
##
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
Hey @mustafaiman -- in the main pom.xml we are only using the
finbugs-maven-plugin and not the findbugs-annotation package (only hive-ql is
using it as dependency and I would like to remove it eventually).
In order to avoid adding jsut another dependency (findbugs-annotation), I
implemented the annotation as a separate class, Findbugs doesn't care in which
package the annotation is, so it works pretty well -- ideally we can also reuse
it across hive packages.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441926)
Time Spent: 0.5h (was: 20m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441917=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441917
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 17:01
Start Date: 05/Jun/20 17:01
Worklog Time Spent: 10m
Work Description: mustafaiman commented on a change in pull request #1063:
URL: https://github.com/apache/hive/pull/1063#discussion_r436048066
##
File path:
storage-api/src/java/org/apache/hive/common/util/SuppressFBWarnings.java
##
@@ -0,0 +1,19 @@
+package org.apache.hive.common.util;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+@Retention(RetentionPolicy.CLASS)
+public @interface SuppressFBWarnings {
Review comment:
Isn't there a SuppressFBWarnings annotation in findbugs package? Why do
we need to introduce our own annotation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441917)
Time Spent: 20m (was: 10m)
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Labels: pull-request-available
> Attachments: findbugsXml.xml
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests test-compile findbugs:findbugs -DskipTests=true -pl
> storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23617) Fix FindBug issues in storage-api
[
https://issues.apache.org/jira/browse/HIVE-23617?focusedWorklogId=441813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441813
]
ASF GitHub Bot logged work on HIVE-23617:
-
Author: ASF GitHub Bot
Created on: 05/Jun/20 12:51
Start Date: 05/Jun/20 12:51
Worklog Time Spent: 10m
Work Description: pgaref opened a new pull request #1063:
URL: https://github.com/apache/hive/pull/1063
Change-Id: I077246ec60b59ba6c65fd86e416040a6fab7d12c
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441813)
Remaining Estimate: 0h
Time Spent: 10m
> Fix FindBug issues in storage-api
> -
>
> Key: HIVE-23617
> URL: https://issues.apache.org/jira/browse/HIVE-23617
> Project: Hive
> Issue Type: Sub-task
> Components: storage-api
>Reporter: Panagiotis Garefalakis
>Assignee: Panagiotis Garefalakis
>Priority: Major
> Attachments: findbugsXml.xml
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> mvn -DskipTests -Pitests,findbugs test-compile findbugs:findbugs
> -DskipTests=true -pl storage-api
> {code}
> {code:java}
> mvn findbugs:gui
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
