[jira] [Commented] (SOLR-13934) Documentation on SimplePostTool for Windows users is pretty brief

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014237#comment-17014237 ] ASF subversion and git services commented on SOLR-13934: Commit

[jira] [Resolved] (SOLR-13934) Documentation on SimplePostTool for Windows users is pretty brief

2020-01-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-13934. Fix Version/s: 8.5 Resolution: Fixed Thanks as always for the docs help guys.

[jira] [Resolved] (LUCENE-9130) Failed to match when create PhraseQuery with terms analyzed from long query text

2020-01-13 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved LUCENE-9130. -- Resolution: Invalid > Failed to match when create PhraseQuery with terms analyzed

[jira] [Commented] (LUCENE-9077) Gradle build

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014099#comment-17014099 ] Dawid Weiss commented on LUCENE-9077: - Hi Erick. I think the best way would be to open a sub-task

[GitHub] [lucene-solr] gerlowskija merged pull request #1013: SOLR-13934: Documentation for windows users

2020-01-13 Thread GitBox
gerlowskija merged pull request #1013: SOLR-13934: Documentation for windows users URL: https://github.com/apache/lucene-solr/pull/1013 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (SOLR-13934) Documentation on SimplePostTool for Windows users is pretty brief

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014236#comment-17014236 ] ASF subversion and git services commented on SOLR-13934: Commit

[GitHub] [lucene-solr] gerlowskija merged pull request #1151: SOLR-13890: Add "top-level" DVTQ implementation

2020-01-13 Thread GitBox
gerlowskija merged pull request #1151: SOLR-13890: Add "top-level" DVTQ implementation URL: https://github.com/apache/lucene-solr/pull/1151 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014254#comment-17014254 ] ASF subversion and git services commented on SOLR-13890: Commit

[GitHub] [lucene-solr] sigram commented on a change in pull request #1100: SOLR-13579: Create resource management API

2020-01-13 Thread GitBox
sigram commented on a change in pull request #1100: SOLR-13579: Create resource management API URL: https://github.com/apache/lucene-solr/pull/1100#discussion_r365719144 ## File path: solr/core/src/java/org/apache/solr/managed/DefaultResourceManager.java ## @@ -0,0

[jira] [Comment Edited] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014143#comment-17014143 ] Ishan Chattopadhyaya edited comment on SOLR-13971 at 1/13/20 9:18 AM:

[jira] [Commented] (LUCENE-9125) Improve Automaton.step() with binary search and introduce Automaton.next()

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014183#comment-17014183 ] ASF subversion and git services commented on LUCENE-9125: - Commit

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Sachin Pattan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014191#comment-17014191 ] Sachin Pattan commented on SOLR-13971: -- cool, thanks for the information.  > Velocity custom

[jira] [Commented] (LUCENE-9125) Improve Automaton.step() with binary search and introduce Automaton.next()

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014207#comment-17014207 ] ASF subversion and git services commented on LUCENE-9125: - Commit

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Sachin Pattan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014135#comment-17014135 ] Sachin Pattan commented on SOLR-13971: -- [~ichattopadhyaya], [~ehatcher] did you get a chance to take

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014143#comment-17014143 ] Ishan Chattopadhyaya commented on SOLR-13971: - I'll take a look today. > Velocity custom

[jira] [Assigned] (LUCENE-9125) Improve Automaton.step() with binary search and introduce Automaton.next()

2020-01-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned LUCENE-9125: -- Assignee: Bruno Roustant > Improve Automaton.step() with binary search and introduce

[GitHub] [lucene-solr] asfgit closed pull request #1160: LUCENE-9125: Improve Automaton.step() with binary search

2020-01-13 Thread GitBox
asfgit closed pull request #1160: LUCENE-9125: Improve Automaton.step() with binary search URL: https://github.com/apache/lucene-solr/pull/1160 This is an automated message from the Apache Git Service. To respond to the

[jira] [Resolved] (LUCENE-9125) Improve Automaton.step() with binary search and introduce Automaton.next()

2020-01-13 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved LUCENE-9125. Fix Version/s: 8.5 Resolution: Fixed Thanks [~dweiss] and @wormding for your

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014242#comment-17014242 ] ASF subversion and git services commented on SOLR-13890: Commit

[GitHub] [lucene-solr] gerlowskija commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
gerlowskija commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573779560 I thought about a precommit check, but discarded the idea for a few reasons. It would require duplicating

[GitHub] [lucene-solr] gerlowskija edited a comment on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
gerlowskija edited a comment on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573779560 I thought about a precommit check, but discarded the idea. It would require duplicating the

[GitHub] [lucene-solr] janhoy commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
janhoy commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573821394 I thought it was git itself that enforces gitattributes, not 3rd party tools. If editors would parse and respect

[jira] [Resolved] (LUCENE-9129) Updating from 7.X to 8.X breaks

2020-01-13 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-9129. --- Resolution: Not A Problem > Updating from 7.X to 8.X breaks >

[jira] [Commented] (SOLR-14025) CVE-2019-17558: Velocity response writer RCE vulnerability persists after 8.3.1

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014352#comment-17014352 ] ASF subversion and git services commented on SOLR-14025: Commit

[jira] [Commented] (SOLR-13985) bind to localhost by default

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014383#comment-17014383 ] ASF subversion and git services commented on SOLR-13985: Commit

[jira] [Created] (LUCENE-9131) Correct HTML5 linting errors in javadocs

2020-01-13 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9131: --- Summary: Correct HTML5 linting errors in javadocs Key: LUCENE-9131 URL: https://issues.apache.org/jira/browse/LUCENE-9131 Project: Lucene - Core Issue Type:

[GitHub] [lucene-solr] dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573780909 bq. It would require duplicating the whitelist/blacklist of file types/locations in two separate formats. It

[jira] [Updated] (LUCENE-9077) Gradle build

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9077: Description: This task focuses on providing gradle-based build equivalent for Lucene and Solr

[jira] [Updated] (LUCENE-9126) Javadoc linting options silently swallow documentation errors

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9126: Fix Version/s: master (9.0) > Javadoc linting options silently swallow documentation errors >

[jira] [Updated] (LUCENE-9126) Javadoc linting options silently swallow documentation errors

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9126: Priority: Minor (was: Major) > Javadoc linting options silently swallow documentation errors >

[jira] [Commented] (SOLR-14168) Maintenance of Solr's official Dockerfile (umbrella issue)

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014586#comment-17014586 ] ASF subversion and git services commented on SOLR-14168: Commit

[jira] [Commented] (LUCENE-9126) Javadoc linting options silently swallow documentation errors

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014470#comment-17014470 ] ASF subversion and git services commented on LUCENE-9126: - Commit

[jira] [Updated] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9132: Attachment: (was: repro.zip) > javadoc references source files from classpath entries and

[jira] [Updated] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9132: Attachment: repro.zip > javadoc references source files from classpath entries and fails during

[jira] [Commented] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014510#comment-17014510 ] ASF subversion and git services commented on SOLR-14186: Commit

[jira] [Commented] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014547#comment-17014547 ] ASF subversion and git services commented on LUCENE-9132: - Commit

[jira] [Commented] (SOLR-13890) Add postfilter support to {!terms} queries

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014543#comment-17014543 ] ASF subversion and git services commented on SOLR-13890: Commit

[jira] [Commented] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014545#comment-17014545 ] ASF subversion and git services commented on SOLR-14186: Commit

[jira] [Commented] (LUCENE-9126) Javadoc linting options silently swallow documentation errors

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014546#comment-17014546 ] ASF subversion and git services commented on LUCENE-9126: - Commit

[jira] [Commented] (SOLR-13985) bind to localhost by default

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014544#comment-17014544 ] ASF subversion and git services commented on SOLR-13985: Commit

[jira] [Updated] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9132: Labels: gradle-master (was: ) > javadoc references source files from classpath entries and fails

[jira] [Created] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9132: --- Summary: javadoc references source files from classpath entries and fails during compilation Key: LUCENE-9132 URL: https://issues.apache.org/jira/browse/LUCENE-9132

[jira] [Updated] (LUCENE-9132) javadoc references source files from classpath entries and fails during compilation

2020-01-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9132: Attachment: repro.zip > javadoc references source files from classpath entries and fails during

[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #1002: [docs]: fixed two small errors in JavaDoc

2020-01-13 Thread GitBox
gerlowskija commented on a change in pull request #1002: [docs]: fixed two small errors in JavaDoc URL: https://github.com/apache/lucene-solr/pull/1002#discussion_r365790241 ## File path: lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxQuery.java ## @@ -262,9

[GitHub] [lucene-solr] dweiss commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
dweiss commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573680544 [patch.txt](https://github.com/apache/lucene-solr/files/4053932/patch.txt) I reworked a few things, Mike. Now... rat hangs for me (?). I wonder if we

[jira] [Commented] (LUCENE-9123) JapaneseTokenizer with search mode doesn't work with SynonymGraphFilter

2020-01-13 Thread Kazuaki Hiraga (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014456#comment-17014456 ] Kazuaki Hiraga commented on LUCENE-9123: [~tomoko] Thank you for your reply! You may be right

[jira] [Commented] (SOLR-13992) Refactor code to have collection name shard name in Replica,Slice

2020-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014276#comment-17014276 ] Jan Høydahl commented on SOLR-13992: [~noble.paul] This issue changes the only constructor of Slice.

[GitHub] [lucene-solr] sigram commented on a change in pull request #1100: SOLR-13579: Create resource management API

2020-01-13 Thread GitBox
sigram commented on a change in pull request #1100: SOLR-13579: Create resource management API URL: https://github.com/apache/lucene-solr/pull/1100#discussion_r365806337 ## File path: solr/core/src/java/org/apache/solr/managed/DefaultResourceManager.java ## @@ -0,0

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014356#comment-17014356 ] Ishan Chattopadhyaya commented on SOLR-13971: - Backported. Thanks Sachin! > Velocity custom

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365839483 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365842076 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-01-13 Thread GitBox
mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r365842011 ## File path:

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-01-13 Thread GitBox
mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r365840526 ## File path: solr/core/src/java/org/apache/solr/search/ValueSourceParser.java

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-01-13 Thread GitBox
mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r365841249 ## File path:

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365837334 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-01-13 Thread GitBox
mkhludnev commented on a change in pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet URL: https://github.com/apache/lucene-solr/pull/1161#discussion_r365842780 ## File path:

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365838434 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] dweiss commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
dweiss commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573698185 Once you apply the patch included in my last comment change the hardcoded here: pattern(substring: "Licensed under the Apache License, Version 2.0

[jira] [Commented] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014410#comment-17014410 ] Jason Gerlowski commented on SOLR-14186: I've linked PR #1162 which only changes the line endings

[jira] [Created] (SOLR-14185) add DocSet.getDocIdSetIterator(LeafReaderContext)

2020-01-13 Thread David Smiley (Jira)
David Smiley created SOLR-14185: --- Summary: add DocSet.getDocIdSetIterator(LeafReaderContext) Key: SOLR-14185 URL: https://issues.apache.org/jira/browse/SOLR-14185 Project: Solr Issue Type:

[GitHub] [lucene-solr] gerlowskija merged pull request #1154: SOLR-13985: Bind to localhost interface by default

2020-01-13 Thread GitBox
gerlowskija merged pull request #1154: SOLR-13985: Bind to localhost interface by default URL: https://github.com/apache/lucene-solr/pull/1154 This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (SOLR-13992) Refactor code to have collection name shard name in Replica,Slice

2020-01-13 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014276#comment-17014276 ] Jan Høydahl edited comment on SOLR-13992 at 1/13/20 12:40 PM: -- [~noble.paul]

[jira] [Commented] (SOLR-13992) Refactor code to have collection name shard name in Replica,Slice

2020-01-13 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014284#comment-17014284 ] Noble Paul commented on SOLR-13992: --- I thought about it. But, it would give unexpected errors. Isn't it

[jira] [Created] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-14186: -- Summary: Ensure Windows files retain CRLF endings Key: SOLR-14186 URL: https://issues.apache.org/jira/browse/SOLR-14186 Project: Solr Issue Type:

[jira] [Commented] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014419#comment-17014419 ] ASF subversion and git services commented on SOLR-14186: Commit

[GitHub] [lucene-solr] gerlowskija merged pull request #1162: SOLR-14186: Re-add CRLF line endings to solr.cmd

2020-01-13 Thread GitBox
gerlowskija merged pull request #1162: SOLR-14186: Re-add CRLF line endings to solr.cmd URL: https://github.com/apache/lucene-solr/pull/1162 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
dweiss commented on issue #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163#issuecomment-573735209 This should be a precommit check (in addition to whatever editing magic you specify via .editor, .gitattributes,

[jira] [Commented] (SOLR-14186) Ensure Windows files retain CRLF endings

2020-01-13 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014435#comment-17014435 ] Jason Gerlowski commented on SOLR-14186: PR #1163 includes a pretty minimal gitattributes file

[GitHub] [lucene-solr] a-siuniaev opened a new pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet

2020-01-13 Thread GitBox
a-siuniaev opened a new pull request #1161: SOLR-12325 Added uniqueBlockQuery(parent:true) aggregation for JSON Facet URL: https://github.com/apache/lucene-solr/pull/1161 # Description Added uniqueBlockQuery(parent:true) aggregation for JSON Facet, which is an optimized alternative

[GitHub] [lucene-solr] Sachpat commented on issue #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability

2020-01-13 Thread GitBox
Sachpat commented on issue #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability URL: https://github.com/apache/lucene-solr/pull/1156#issuecomment-573690564 Thanks for merging it @chatman . Will close this PR now.

[GitHub] [lucene-solr] Sachpat closed pull request #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability

2020-01-13 Thread GitBox
Sachpat closed pull request #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability URL: https://github.com/apache/lucene-solr/pull/1156 This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365840761 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit

2020-01-13 Thread GitBox
msokolov commented on a change in pull request #1155: LUCENE-8962: Add ability to selectively merge on commit URL: https://github.com/apache/lucene-solr/pull/1155#discussion_r365837767 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@

[GitHub] [lucene-solr] gerlowskija commented on issue #1002: [docs]: fixed two small errors in JavaDoc

2020-01-13 Thread GitBox
gerlowskija commented on issue #1002: [docs]: fixed two small errors in JavaDoc URL: https://github.com/apache/lucene-solr/pull/1002#issuecomment-573654685 These changes look fine to me. One "typo" was probably intentional ("iff" vs "if"), but the docs work equally well either way (If you

[GitHub] [lucene-solr] gerlowskija commented on issue #1154: SOLR-13985: Bind to localhost interface by default

2020-01-13 Thread GitBox
gerlowskija commented on issue #1154: SOLR-13985: Bind to localhost interface by default URL: https://github.com/apache/lucene-solr/pull/1154#issuecomment-573684995 `solr.cmd` has the wrong line endings again. It looks like SOLR-13977 was fixed and then regressed almost immediately with

[GitHub] [lucene-solr] dweiss commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
dweiss commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573688875 [patch.txt](https://github.com/apache/lucene-solr/files/4054015/patch.txt) Updated patch. Some files still fail; it'd have to be investigated.

[jira] [Commented] (SOLR-13971) Velocity custom template RCE vulnerability

2020-01-13 Thread Sachin Pattan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014398#comment-17014398 ] Sachin Pattan commented on SOLR-13971: -- Thanks Ishan. > Velocity custom template RCE vulnerability

[GitHub] [lucene-solr] gerlowskija opened a new pull request #1162: SOLR-14186: Re-add CRLF line endings to solr.cmd

2020-01-13 Thread GitBox
gerlowskija opened a new pull request #1162: SOLR-14186: Re-add CRLF line endings to solr.cmd URL: https://github.com/apache/lucene-solr/pull/1162 # Description solr.cmd needs CRLF endings, but they were stripped out in a recent commit. # Solution I ran unix2dos to

[GitHub] [lucene-solr] gerlowskija opened a new pull request #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes

2020-01-13 Thread GitBox
gerlowskija opened a new pull request #1163: SOLR-14186: Enforce CRLF in Windows files with .gitattributes URL: https://github.com/apache/lucene-solr/pull/1163 # Description We have nothing that ensures that our Windows files (solr.cmd, etc.) keep the CRLF files they need to run.

[GitHub] [lucene-solr] dweiss commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
dweiss commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573683590 It doesn't hang. It just takes a loong time on the highlighter - don't know why. The two failures are related to extra exclusions present in the ant

[GitHub] [lucene-solr] chatman commented on issue #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability

2020-01-13 Thread GitBox
chatman commented on issue #1156: SOLR-13971: CVE-2019-17558: Velocity custom template RCE vulnerability URL: https://github.com/apache/lucene-solr/pull/1156#issuecomment-573683286 Merged. Thanks. Lets close this PR. This is

[GitHub] [lucene-solr] janhoy commented on issue #1154: SOLR-13985: Bind to localhost interface by default

2020-01-13 Thread GitBox
janhoy commented on issue #1154: SOLR-13985: Bind to localhost interface by default URL: https://github.com/apache/lucene-solr/pull/1154#issuecomment-573694336 See

[jira] [Updated] (SOLR-12930) Add great developer documentation for writing tests.

2020-01-13 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-12930: - Parent: (was: SOLR-12801) Issue Type: Improvement (was: Sub-task) > Add

[GitHub] [lucene-solr] ctargett opened a new pull request #1164: SOLR-12930: Create developer docs in source repo

2020-01-13 Thread GitBox
ctargett opened a new pull request #1164: SOLR-12930: Create developer docs in source repo URL: https://github.com/apache/lucene-solr/pull/1164 # Description Docs for project contributors and committers has historically lived in the wiki (MoinMoin and now Confluence) but there has

[GitHub] [lucene-solr] madrob commented on a change in pull request #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
madrob commented on a change in pull request #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#discussion_r365983304 ## File path: gradle/validation/rat-sources.gradle ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (SOLR-12930) Add developer documentation to source repo

2020-01-13 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-12930: - Summary: Add developer documentation to source repo (was: Add great developer

[jira] [Created] (LUCENE-9133) TermFilteredPresearcher NPE issue with empty fields

2020-01-13 Thread Marvin Justice (Jira)
Marvin Justice created LUCENE-9133: -- Summary: TermFilteredPresearcher NPE issue with empty fields Key: LUCENE-9133 URL: https://issues.apache.org/jira/browse/LUCENE-9133 Project: Lucene - Core

[GitHub] [lucene-solr] madrob commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
madrob commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573905209 One other thought - we probably shouldn't exclude the `*.gradle` files - there's no reason for those not to have license headers like our `build.xml`

[jira] [Commented] (SOLR-12930) Add developer documentation to source repo

2020-01-13 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014653#comment-17014653 ] Cassandra Targett commented on SOLR-12930: -- I converted this sub-task to a full issue in order

[GitHub] [lucene-solr] madrob commented on issue #1157: Add RAT check using Gradle

2020-01-13 Thread GitBox
madrob commented on issue #1157: Add RAT check using Gradle URL: https://github.com/apache/lucene-solr/pull/1157#issuecomment-573887216 Updated based on your patch, pushed latest to this PR. We're missing rat check on `buildSrc` (no ant equivalent), `lucene/tools` (does not have

[jira] [Commented] (SOLR-14185) add DocSet.getDocIdSetIterator(LeafReaderContext)

2020-01-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014629#comment-17014629 ] David Smiley commented on SOLR-14185: - On second thought this method could be named simply

[GitHub] [lucene-solr] mjustice3 opened a new pull request #1165: LUCENE-9133: Fix for potential NPE in TermFilteredPresearcher#buildQuery

2020-01-13 Thread GitBox
mjustice3 opened a new pull request #1165: LUCENE-9133: Fix for potential NPE in TermFilteredPresearcher#buildQuery URL: https://github.com/apache/lucene-solr/pull/1165 # Description Please provide a short description of the changes you're making with this pull request.

[jira] [Created] (LUCENE-9134) Port ant-regenerate tasks to Gradle build

2020-01-13 Thread Erick Erickson (Jira)
Erick Erickson created LUCENE-9134: -- Summary: Port ant-regenerate tasks to Gradle build Key: LUCENE-9134 URL: https://issues.apache.org/jira/browse/LUCENE-9134 Project: Lucene - Core Issue

[jira] [Updated] (SOLR-14184) replace DirectUpdateHandler2.commitOnClose with something in TestInjection

2020-01-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14184: -- Attachment: SOLR-14184.patch Status: Open (was: Open) full patch with all

[jira] [Updated] (SOLR-14184) replace DirectUpdateHandler2.commitOnClose with something in TestInjection

2020-01-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14184: -- Status: Patch Available (was: Open) > replace DirectUpdateHandler2.commitOnClose with

[jira] [Updated] (SOLR-14184) replace DirectUpdateHandler2.commitOnClose with something in TestInjection

2020-01-13 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14184: -- Attachment: SOLR-14184.patch Status: Open (was: Open) Minimal patch for

[jira] [Reopened] (LUCENE-9130) Failed to match when create PhraseQuery with terms analyzed from long query text

2020-01-13 Thread Chen Zhixiang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chen Zhixiang reopened LUCENE-9130: --- i have re-tested by removed some parts of long query text, seems it is not a terms count limit

[GitHub] [lucene-solr] dsmiley opened a new pull request #1166: SOLR-14040: shareSchema support for SolrCloud

2020-01-13 Thread GitBox
dsmiley opened a new pull request #1166: SOLR-14040: shareSchema support for SolrCloud URL: https://github.com/apache/lucene-solr/pull/1166 https://issues.apache.org/jira/browse/SOLR-14040 The essence of this change is that ConfigSetService does schema caching itself (optionally)

[jira] [Commented] (LUCENE-9130) Failed to match when create PhraseQuery with terms analyzed from long query text

2020-01-13 Thread Chen Zhixiang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014901#comment-17014901 ] Chen Zhixiang commented on LUCENE-9130: --- @[~mkhl] What's the reason for marking as INVALID? >

[jira] [Assigned] (SOLR-13845) DELETEREPLICA API by "count" and "type"

2020-01-13 Thread Shalin Shekhar Mangar (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar reassigned SOLR-13845: Assignee: Shalin Shekhar Mangar > DELETEREPLICA API by "count" and "type"

  1   2   >