[
https://issues.apache.org/jira/browse/METRON-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689220#comment-16689220
]
ASF GitHub Bot commented on METRON-1873:
GitHub user sardell opened a pull request:
Github user JonZeolla commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Sounds good, I'm inclined to accept but there is a little bit of
housekeeping to take care of first. Can you please take a look the "For all
changes" section of our PR template
[
https://issues.apache.org/jira/browse/METRON-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689461#comment-16689461
]
ASF GitHub Bot commented on METRON-1815:
Github user justinleet commented on a diff in the pull
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1249#discussion_r234218876
--- Diff: README.md ---
@@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus.
Some high level links to the relevant subparts
[
https://issues.apache.org/jira/browse/METRON-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689572#comment-16689572
]
ASF GitHub Bot commented on METRON-1845:
Github user nickwallen commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1247
I have merged this with master to pull in the changes from #1242. This is
ready for review.
---
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/1268
METRON-1877: Nested IF ELSE statements can cause parse errors in Stellar
## Contributor Comments
When we're dealing with if-else, the existing code would simply say we need
to skip an else.
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689647#comment-16689647
]
ASF GitHub Bot commented on METRON-1874:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689649#comment-16689649
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689635#comment-16689635
]
ASF GitHub Bot commented on METRON-1877:
GitHub user justinleet opened a pull request:
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234289745
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -219,14 +220,23 @@ public Object
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689732#comment-16689732
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234290697
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689756#comment-16689756
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234293803
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234303547
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Babak Abbaschian created METRON-1876:
Summary: Failure Automatic Deploying Metron on Amazon EC2
Key: METRON-1876
URL: https://issues.apache.org/jira/browse/METRON-1876
Project: Metron
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689644#comment-16689644
]
ASF GitHub Bot commented on METRON-1874:
Github user nickwallen commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1265
> @ottobackwards: Can we test parser chains?
I don't think so at the moment. Aggregation/chaining involves multiple
parsers, each reading/writing data from Kafka. These functions work
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1265
> @ottobackwards maybe that can be a follow on, it would be much better to
load from disk -> split lines than to open an editor and cut and past from your
sample log.
Yep, agreed. It
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1268
@cestella You're the mastermind of this, therefore you own it forever.
This look reasonable to you (both in cause and approach)?
---
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689679#comment-16689679
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288056
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.spec.ts ---
@@ -33,6 +33,7 @@ import { PcapStatusResponse } from
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689704#comment-16689704
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288083
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -25,6 +25,7 @@ import { HttpUtil } from '../../utils/httpUtil';
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689711#comment-16689711
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689708#comment-16689708
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288118
--- Diff: metron-interface/metron-alerts/src/app/service/alerts.service.ts
---
@@ -22,14 +22,15 @@ import {Alert} from '../model/alert';
import {
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689706#comment-16689706
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288233
--- Diff:
metron-interface/metron-alerts/src/app/service/global-config.service.ts ---
@@ -21,14 +21,15 @@ import { Injectable } from '@angular/core';
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288029
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-panel/pcap-panel.component.spec.ts
---
@@ -28,6 +28,7 @@ import { PcapRequest } from
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287914
--- Diff: metron-interface/metron-alerts/src/app/app.module.ts ---
@@ -48,13 +48,11 @@ import { GlobalConfigService } from
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287807
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.spec.ts
---
@@ -32,6 +32,14 @@ import { UpdateService }
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689719#comment-16689719
]
ASF GitHub Bot commented on METRON-1874:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
Then maybe a function to evaluate stellar
EVALUATE_TRANSFORM(config,PARSER_PARSE(parser, input)
---
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689733#comment-16689733
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the
[
https://issues.apache.org/jira/browse/METRON-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689511#comment-16689511
]
ASF GitHub Bot commented on METRON-1815:
Github user ottobackwards commented on a diff in the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1249#discussion_r234230655
--- Diff: README.md ---
@@ -132,7 +132,7 @@ component and Apache Kafka as the unified data bus.
Some high level links to the relevant
[
https://issues.apache.org/jira/browse/METRON-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Babak Abbaschian updated METRON-1876:
-
Description:
So I'm trying to deploy Metron on EC2, and I'm following this link:
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1268
This looks good to me. Good catch, +1 by inspection.
---
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689725#comment-16689725
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1266
I addressed the style issues and added a comment about APP_INITIALIZER and
promises. Let me know what you think.
---
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689775#comment-16689775
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on the issue:
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234302996
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java
---
@@ -219,14 +220,23 @@ public Object
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689801#comment-16689801
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689826#comment-16689826
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on a diff in the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1268#discussion_r234305980
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/BasicStellarTest.java
---
@@ -916,6 +916,53 @@ public
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1265
> @ottobackwards: Can we load files from disk? It would be nice to not have
had to setup kafka etc.
There is no requirement to setup Kafka. All you have to do is create a
String that
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689632#comment-16689632
]
ASF GitHub Bot commented on METRON-1874:
Github user nickwallen commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1265
maybe that can be a follow on, it would be much better to load from disk ->
split lines than to open an editor and cut and past from your sample log.
---
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689702#comment-16689702
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689767#comment-16689767
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234296496
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
Justin Leet created METRON-1877:
---
Summary: Nested IF ELSE statements can cause parse errors in
Stellar
Key: METRON-1877
URL: https://issues.apache.org/jira/browse/METRON-1877
Project: Metron
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689654#comment-16689654
]
ASF GitHub Bot commented on METRON-1877:
Github user cestella commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689643#comment-16689643
]
ASF GitHub Bot commented on METRON-1874:
Github user ottobackwards commented on the issue:
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234287609
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.spec.ts
---
@@ -31,12 +31,20 @@ import { UpdateService
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689753#comment-16689753
]
ASF GitHub Bot commented on METRON-1875:
Github user merrimanr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689768#comment-16689768
]
ASF GitHub Bot commented on METRON-1875:
Github user merrimanr commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689808#comment-16689808
]
ASF GitHub Bot commented on METRON-1877:
Github user justinleet commented on a diff in the pull
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1268
+1, great job
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1265
I was also wanting to do a follow-on that would load the parser
configuration from Zk instead of requiring you to define that. In some cases,
you just want to work with whatever the current
[
https://issues.apache.org/jira/browse/METRON-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689658#comment-16689658
]
ASF GitHub Bot commented on METRON-1874:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689714#comment-16689714
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689712#comment-16689712
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689713#comment-16689713
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689716#comment-16689716
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689715#comment-16689715
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288308
--- Diff: metron-interface/metron-alerts/src/app/service/search.service.ts
---
@@ -30,6 +30,7 @@ import { RestError } from '../model/rest-error';
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689709#comment-16689709
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689700#comment-16689700
]
ASF GitHub Bot commented on METRON-1875:
Github user sardell commented on a diff in the pull
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288184
--- Diff:
metron-interface/metron-alerts/src/app/service/authentication.service.ts ---
@@ -22,26 +22,28 @@ import {Router} from '@angular/router';
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288335
--- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts
---
@@ -28,6 +28,7 @@ import {Utils} from '../utils/utils';
import {Patch}
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234288280
--- Diff:
metron-interface/metron-alerts/src/app/service/meta-alert.service.ts ---
@@ -26,14 +26,15 @@ import {Alert} from '../model/alert';
import {
Nick Allen created METRON-1879:
--
Summary: Allow Elasticsearch to Auto-Generate the Document ID
Key: METRON-1879
URL: https://issues.apache.org/jira/browse/METRON-1879
Project: Metron
Issue
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1266
---
[
https://issues.apache.org/jira/browse/METRON-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689984#comment-16689984
]
ASF GitHub Bot commented on METRON-1875:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690028#comment-16690028
]
Nick Allen commented on METRON-1801:
This approach was abandoned. See
Ryan Merriman created METRON-1878:
-
Summary: Add Metron as a Knox service
Key: METRON-1878
URL: https://issues.apache.org/jira/browse/METRON-1878
Project: Metron
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/METRON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689996#comment-16689996
]
ASF GitHub Bot commented on METRON-1677:
GitHub user nickwallen opened a pull request:
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1269
METRON-1677 UUIDv4 GUID is not Lucene friendly
With this change, when documents are written to Elasticsearch the document
ID is no longer set as the Metron GUID, but instead left unset so that
[
https://issues.apache.org/jira/browse/METRON-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689604#comment-16689604
]
ASF GitHub Bot commented on METRON-1871:
Github user nickwallen commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689605#comment-16689605
]
ASF GitHub Bot commented on METRON-1871:
Github user nickwallen closed the pull request at:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1262
This was taken care of in #1242 . No need.
---
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1262
---
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234289363
--- Diff:
metron-interface/metron-alerts/src/app/pcap/service/pcap.service.ts ---
@@ -47,47 +48,47 @@ export class PcapService {
public
[
https://issues.apache.org/jira/browse/METRON-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689830#comment-16689830
]
ASF GitHub Bot commented on METRON-1877:
Github user ottobackwards commented on the issue:
Github user dopheide-esnet commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/18
Please understand that I did that pull request for 20 different packages
precisely because it wasn't too time consuming. If it were a major change,
a new feature or
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1266#discussion_r234293206
--- Diff:
metron-interface/metron-alerts/src/app/service/app-config.service.ts ---
@@ -0,0 +1,40 @@
+/**
+ * Licensed to the Apache Software
89 matches
Mail list logo
