[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r555745253 ## File path: extensions/rocksdb-repos/DatabaseContentRepository.cpp ## @@ -94,7 +97,7 @@ void DatabaseContentRepository::Session::commit() {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r555266906 ## File path: libminifi/include/utils/StringUtils.h ## @@ -159,9 +160,9 @@ class StringUtils { } inline static std::string hex_ascii(const

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r555266004 ## File path: libminifi/include/provenance/Provenance.h ## @@ -360,7 +361,7 @@ class ProvenanceEventRecord : public core::SerializableComponent {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r555265815 ## File path: extensions/rocksdb-repos/FlowFileRepository.cpp ## @@ -15,12 +15,11 @@ * See the License for the specific language governing

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r552482386 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -94,37 +94,39 @@ bool StringUtils::StringToFloat(std::string input, float , FailurePolicy

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r552052405 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -88,7 +88,7 @@ static void setPort(struct SiteToSiteCPeer * peer, uint16_t port) {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551971620 ## File path: nanofi/include/sitetosite/CPeer.h ## @@ -79,15 +79,15 @@ static void setHostName(struct SiteToSiteCPeer * peer, const char *

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551971025 ## File path: libminifi/test/unit/ZlibStreamTests.cpp ## @@ -97,7 +106,8 @@ TEST_CASE("gzip compression and decompression pipeline", "[basic]") {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551970890 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float , FailurePolicy

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551970138 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -95,21 +95,23 @@ bool StringUtils::StringToFloat(std::string input, float , FailurePolicy

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #964: MINIFICPP-1443 Fix 'possible loss of data' warnings

fgerlits commented on a change in pull request #964: URL: https://github.com/apache/nifi-minifi-cpp/pull/964#discussion_r551967884 ## File path: libminifi/src/provenance/Provenance.cpp ## @@ -178,8 +181,8 @@ bool