mrutkows commented on issue #622: Add unit tests to support "in-line" code on
"function" keyword
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/622#issuecomment-338776928
need to assure code "errors out: if typo and exists gracefully with an error
message to user
pritidesai commented on issue #617: Support "project" as a synonym for
"application"
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/617#issuecomment-338777113
Can not update title to indicate Priti working on it ...
mrutkows opened a new issue #622: Add unit tests to support "in-line" code on
"function" keyword
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/622
Need to assure we test for support of in-line code, for example:
```
function: |
function
mdeuser commented on a change in pull request #2877: Better error controller
message for authorization failure
URL:
https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146383888
##
File path:
abaruni commented on issue #101: Trigger management
URL:
https://github.com/apache/incubator-openwhisk-package-alarms/pull/101#issuecomment-338794042
@csantanapr @jasonpet
This is an automated message from the Apache Git
abaruni commented on issue #137: Trigger management
URL:
https://github.com/apache/incubator-openwhisk-package-cloudant/pull/137#issuecomment-338794088
@csantanapr @jasonpet
This is an automated message from the Apache Git
mrutkows commented on issue #614: Add the support to read env variable for
package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338797042
@houshengbo Priti brings up a validate request for an additional test(s) to
assure it works on multiples
mrutkows opened a new issue #624: Document "main" key support on Action
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/624
In theory, we support aliasing a function with a name other than "main" to
"main" as this is what our runtime containers expect.
Verify
dubeejw opened a new pull request #2887: Check for correct number of minimal
arguments on action create
URL: https://github.com/apache/incubator-openwhisk/pull/2887
Currently the argument length check passes successfully when only one
argument is passed to action create. Instead of
alexkli commented on issue #2852: invoker: use locally available image if
docker pull fails
URL:
https://github.com/apache/incubator-openwhisk/pull/2852#issuecomment-338757493
Using a "whisk" prefix alone does not work, for
wsk action create foo foo.js --docker wisk/proxyaction
dubeejw commented on issue #2869: CLI should use filename as action name when
one is not provided
URL:
https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338784689
Good discussion. Actually found a bug in the existing code when looking into
action create
dubeejw commented on issue #2869: CLI should use filename as action name when
one is not provided
URL:
https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338785713
I have started implementing the suggestions here for my own personal usage
as it makes things easier for
rabbah commented on a change in pull request #2877: Better error controller
message for authorization failure
URL:
https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146384623
##
File path:
core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
mrutkows commented on issue #331: Delete dead code - manifestreader.go
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/331#issuecomment-338777340
@pritidesai is this still an issue? dead code still there?
pritidesai commented on issue #331: Delete dead code - manifestreader.go
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/331#issuecomment-338781955
Yup I have updated link in description.
This is an
dubeejw commented on issue #2869: CLI should use filename as action name when
one is not provided
URL:
https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338799316
Looks like we currently allow actions to be created with only the action
name when the creating docker
rabbah commented on issue #2884: health actions can reuse containers and may
not flag an unhealthy invoker
URL:
https://github.com/apache/incubator-openwhisk/issues/2884#issuecomment-338803562
With multiple active controllers and no sharding, a status but flip will
cause multiple
mrutkows opened a new issue #623: Support "blackbox" Docker images
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/623
This has been a discussion since last Sept. and asked Daisy to look into
supporting at that time. Need to track this work via this issue.
```
mrutkows commented on issue #614: Add the support to read env variable for
package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338786406
@houshengbo thanks for adding additional tests for the "concatenation" of
env. variable strings with
abaruni opened a new pull request #137: Trigger management
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/137
this PR is for fetching the current configuration and status of a feed
trigger
This is
abaruni opened a new pull request #101: Trigger management
URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/101
this PR is for the fetching of the current configuration and status of a
feed trigger
This
dubeejw commented on issue #2869: CLI should use filename as action name when
one is not provided
URL:
https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338799316
Looks like we currently allow actions to be created with only the action
name when creating docker
dubeejw commented on issue #2887: Check for correct number of minimal arguments
on action create
URL:
https://github.com/apache/incubator-openwhisk/pull/2887#issuecomment-338805982
@mdeuser, looks like there is more at play here. Will make updates and see
what you think.
houshengbo commented on issue #614: Add the support to read env variable for
package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338811026
@pritidesai @mrutkows I have added the coverage of multiple packages.
dubeejw commented on issue #2887: Check for correct number of minimal arguments
on action create
URL:
https://github.com/apache/incubator-openwhisk/pull/2887#issuecomment-338809287
Currently when providing the sequence and docker flags during action create
or update, an error message is
markusthoemmes commented on issue #2880: Gradle Build Failure (Could not
determine java version from '9.0.1')
URL:
https://github.com/apache/incubator-openwhisk/issues/2880#issuecomment-338563603
Duplicate of #2840.
We'll need to bump our Scala versions to support Java 9. After
markusthoemmes closed pull request #2885: Fix invoker build break
URL: https://github.com/apache/incubator-openwhisk/pull/2885
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
rabbah commented on a change in pull request #2576: Configure components via
pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270132
##
File path: common/scala/transformEnvironment.sh
##
@@ -0,0 +1,32 @@
+#!/bin/bash
+
rabbah commented on a change in pull request #2576: Configure components via
pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146268977
##
File path: common/scala/build.gradle
##
@@ -13,6 +13,8 @@ dependencies {
compile
rabbah commented on a change in pull request #2576: Configure components via
pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146269623
##
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##
rabbah commented on a change in pull request #2576: Configure components via
pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270391
##
File path: core/controller/src/main/resources/application.conf
##
@@ -2,6 +2,13 @@
include
rabbah commented on a change in pull request #2576: Configure components via
pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146269490
##
File path: core/controller/src/main/resources/application.conf
##
@@ -59,26 +66,15 @@ akka.http
markusthoemmes commented on a change in pull request #2576: Configure
components via pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270775
##
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
markusthoemmes commented on a change in pull request #2576: Configure
components via pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270994
##
File path: core/controller/src/main/resources/application.conf
##
@@ -59,26 +66,15 @@
markusthoemmes commented on a change in pull request #2576: Configure
components via pureconfig.
URL:
https://github.com/apache/incubator-openwhisk/pull/2576#discussion_r146270905
##
File path: core/controller/src/main/resources/application.conf
##
@@ -2,6 +2,13 @@
mrutkows commented on issue #612: Allow use of "kind" for "runtime" field
(overloaded semantic) with warning
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/612#issuecomment-338739841
Also, issue a WARNING something like:
""runtime" is the preferred term for
jessealva commented on issue #2869: CLI should use filename as action name when
one is not provided
URL:
https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338746639
Just caught up. I think I agree with @rabbah and @mrutkows . Although the
changes seem small and
gbdrt commented on issue #2736: Update openwhisk javacript SDK to version 3.7.0
URL:
https://github.com/apache/incubator-openwhisk/pull/2736#issuecomment-338752864
@rabbah just did.
This is an automated message from the
gbdrt opened a new pull request #2: Switch to version 3.9.0 of the openwhisk SDK
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/2
This is an automated message from the Apache Git Service.
To respond
mrutkows commented on a change in pull request #607: WIP: JSON Output support
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607#discussion_r146361901
##
File path: parsers/manifest_parser_test.go
##
@@ -339,15 +324,15 @@ func
mrutkows opened a new issue #620: manifest_parser_test needs more dedicated
tests for output parameters...
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/620
Suggest updating the following test files to include outputs
-
gbdrt commented on issue #2: Switch to version 3.9.0 of the openwhisk SDK
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/2#issuecomment-338769138
Ok, just changed it back.
This is an automated message
houshengbo closed pull request #607: JSON Output support
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146340709
##
File path:
mdeuser commented on a change in pull request #2877: Better error controller
message for authorization failure
URL:
https://github.com/apache/incubator-openwhisk/pull/2877#discussion_r146353816
##
File path:
core/controller/src/main/scala/whisk/core/entitlement/Entitlement.scala
pritidesai commented on issue #606: Add the dependency back to validate packages
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/606#issuecomment-338756236
These changes can lead us to build failure on master branch or any of the
PRs, I have seen failures in my local
alexkli commented on issue #2852: invoker: use locally available image if
docker pull fails
URL:
https://github.com/apache/incubator-openwhisk/pull/2852#issuecomment-338757493
Using a "whisk" prefix alone does not work, I get
> Failed to pull container image 'wisk/proxyaction'
mrutkows opened a new issue #619: Support "kind" as a synonym for "runtime" key
under Action
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/619
Also, issue a WARNING something like:
""runtime" is the preferred term for referencing the function's container,
"kind"
mrutkows closed issue #619: Support "kind" as a synonym for "runtime" key under
Action
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/619
This is an automated message from the Apache Git Service.
To
jsanda commented on issue #2389: JVM heap size is not set correctly for Java
actions
URL:
https://github.com/apache/incubator-openwhisk/issues/2389#issuecomment-338742448
Is something like
[this|https://github.com/fabric8io-images/java/tree/master/images/jboss/openjdk8/jdk]
along the
jsanda commented on issue #2389: JVM heap size is not set correctly for Java
actions
URL:
https://github.com/apache/incubator-openwhisk/issues/2389#issuecomment-338742448
Is something like
[this](https://github.com/fabric8io-images/java/tree/master/images/jboss/openjdk8/jdk)
what you
pritidesai commented on issue #614: Add the support to read env variable for
package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338760909
@houshengbo please add a sample manifest file with single and multiple
packages:
```
packages:
pritidesai commented on issue #614: Add the support to read env variable for
package name
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/614#issuecomment-338760909
@houshengbo please add a sample manifest files with single and multiple
packages:
```
packages:
mrutkows commented on issue #108: Change the spec to add the description of
`sequences` for sequences
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/108#issuecomment-338765768
Added in the https://github.com/apache/incubator-openwhisk-wskdeploy/pull/540
mrutkows commented on issue #108: Change the spec to add the description of
`sequences` for sequences
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/108#issuecomment-338765768
Added in the https://github.com/apache/incubator-openwhisk-wskdeploy/pull/540
mrutkows closed issue #108: Change the spec to add the description of
`sequences` for sequences
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/108
This is an automated message from the Apache Git
mrutkows commented on issue #108: Change the spec to add the description of
`sequences` for sequences
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/108#issuecomment-338765903
documentation added on (or before)
houshengbo commented on a change in pull request #607: WIP: JSON Output support
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/607#discussion_r146353673
##
File path: parsers/manifest_parser_test.go
##
@@ -339,15 +324,15 @@ func
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146357053
##
File path:
mrutkows commented on issue #621: Support "public" key (flag) on Package
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/621#issuecomment-338764783
Note: whenever a Package is deployed with "public==true" we SHOULD issue a
clear warning that the package is visible and
csantanapr commented on issue #2: Switch to version 3.9.0 of the openwhisk SDK
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/2#issuecomment-338766152
There is no good thing of using .x more work to figure out what version
actually got installed on the image and
csantanapr commented on issue #2: Switch to version 3.9.0 of the openwhisk SDK
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/2#issuecomment-338766358
It's not like the library is going to be installed and be updated any time
the client lib is release, the npm
mrutkows commented on issue #621: Support "public" key (flag) on Package
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/621#issuecomment-338767163
Related to
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/248
although using the key "shared" is
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146339742
##
File path:
mrutkows opened a new issue #621: Support "public" key (flag) on Package
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/621
Packaging spec. now acknowledges support for "public" packages (but NOT
actions) with the following new key under the Package schema:
rabbah commented on issue #2: Switch to version 3.9.0 of the openwhisk SDK
URL:
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/2#issuecomment-338765561
@csantanapr are you ok with this change?
This is an
houshengbo commented on issue #2621: Replace the test cases of action and
package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#issuecomment-338688497
PG 2174 in 1.
This is an
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146300612
##
File path: tests/build.gradle
##
@@ -24,6 +24,17 @@ task
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146300959
##
File path: tests/build.gradle
##
@@ -24,6 +24,17 @@ task
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146302647
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
mrutkows commented on issue #606: Add the dependency back to validate packages
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/606#issuecomment-338699145
@houshengbo I would like @pritidesai to be able to review and comment as she
has been identifying and addressing
ddragosd commented on a change in pull request #62: added redis host for invoker
URL:
https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146179323
##
File path: docker-compose/docker-compose.yml
##
@@ -81,12 +82,15 @@ services:
-
ddragosd commented on a change in pull request #62: added redis host for invoker
URL:
https://github.com/apache/incubator-openwhisk-devtools/pull/62#discussion_r146184088
##
File path: docker-compose/docker-compose.yml
##
@@ -116,6 +116,8 @@ services:
image:
markusthoemmes closed pull request #2858: Make Docker action container cleanup
during invoker startup / shutdown more robust
URL: https://github.com/apache/incubator-openwhisk/pull/2858
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is
sven-lange-last opened a new pull request #2885: Fix invoker build break
URL: https://github.com/apache/incubator-openwhisk/pull/2885
This is an automated message from the Apache Git Service.
To respond to the message,
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146309883
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146301732
##
File path: tests/src/test/scala/common/WskTestHelpers.scala
##
cfjedimaster opened a new issue #2886: Add a quick status utilility
URL: https://github.com/apache/incubator-openwhisk/issues/2886
It would be nice if there was a quick way to get stats about an action. So
something like:
wsk stats ACTIONNAME
Which would report a very
mrutkows opened a new issue #616: Test if action, trigger or rule already
exists before deployment
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/616
Can we in unit/integration tests have a convention some functional code that
between tests cases being run (or by
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146309883
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146311087
##
File path: tests/build.gradle
##
@@ -24,6 +24,17 @@ task
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146311087
##
File path: tests/build.gradle
##
@@ -24,6 +24,17 @@ task
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146311087
##
File path: tests/build.gradle
##
@@ -24,6 +24,17 @@ task
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146311845
##
File path: tests/src/test/scala/common/WskTestHelpers.scala
houshengbo commented on a change in pull request #2621: Replace the test cases
of action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146311845
##
File path: tests/src/test/scala/common/WskTestHelpers.scala
mrutkows commented on issue #617: Support "project" as a synonum for
"application"
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/617#issuecomment-338734360
See related issue:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/618 for
discussion which
mrutkows commented on issue #618: Allow "headless" yaml tree for "projects"
(f.k.a. "applications")
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/618#issuecomment-338734535
Please see related issue
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/617
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146338270
##
File path: tests/src/test/scala/common/WskTestHelpers.scala
##
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146338536
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
dubeejw commented on a change in pull request #2621: Replace the test cases of
action and package with REST implementation
URL:
https://github.com/apache/incubator-openwhisk/pull/2621#discussion_r146338536
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
90 matches
Mail list logo
