Maven flatten plugin in incrementals profile

2024-05-18 Thread Ullrich Hafner
It seems that the Maven SpotBugs and the Maven Flatten plugin are not 
compatible when used together. I am using a SpotBugs exclusion filter from 
another jar file and SpotBugs seems to create a zero length copy of that file 
when the flatten plugin is active. 

So before digging deeper into the sources or reporting a bug I wanted to ask 
why we need the maven flatten plugin for the incremental builds? Is this plugin 
optional? Or what happens if I set the property -Dflatten.flatten.skip in my 
Jenkinsfile? Are then incremental builds still created? Or is this relevant for 
CD only?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C0EE89FF-8B5C-467D-A194-2ED667E35EE8%40gmail.com.


Re: Plugin with Java 17 minimum dependencies

2024-04-27 Thread Ullrich Hafner


> Am 27.04.2024 um 09:24 schrieb Valentin Delaye (jonesbusy) 
> :
> 
> Hi,
> 
> I'm a bit confused on the minimum required Java version for plugins
> 
> I maintain the https://github.com/jenkinsci/flyway-api-plugin which is an API 
> plugin for flyway dependencies.
> 
> Since flyway 10 Java 17 is required.
> 
> I open a PR https://github.com/jenkinsci/flyway-api-plugin/pull/9/files
> 
> And changing the
> 
> 17 
> 17
> 
> And tested using bom the plugin against known consumer. No issue found
> 
> However is looks I cannot release the plugin 
> https://github.com/jenkinsci/flyway-api-plugin/actions/runs/8858031719/job/24326194647
>  due to JDK11 used on CD.
> 
> - Is it expected ?
> - Does this mean the plugin need a Java 17 runtime or only for compile ?
> - Show I rollback until the toolchain is adapted for Java 17 ?
> 

At least it makes sense to rise an issue for the CD toolchain so this problem 
will not be forgotten when we switch to Java 17 in September.

You can do JDK 17 releases using the manual release process though, an example 
is available at https://github.com/jenkinsci/autograding-plugin. This plugin 
also has a dependency to a Java 17 library so I needed to switch to Java a 17 
for the plugin as well.

Ulli 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3A4518C7-1FD3-4564-8CBE-E2B60C996225%40gmail.com.


Re: Building Jenkins core and plugins with Java 22

2024-04-02 Thread Ullrich Hafner
Thanks!

Is it intentional that you are using "Jenkins Developers“ as mail from (and not 
your name Alex anymore)? It is somewhat strange to not see who actually sent 
the mail in the thread (without looking at all the headers)... 

> Am 01.04.2024 um 17:46 schrieb 'Alexander Brandes' via Jenkins Developers 
> :
> 
> Hey everyone,
> 
> I released an update for the Jenkins parent poms for plugins (>= 4.80) and 
> libraries (>= 1.112), making sure, that building a component on Java 22 via 
> `mvn clean verify package` does no longer fail on the “license” step, which 
> was a blocker before.
> 
> Plugins and Jenkins core I built with Java 21 before, I can now build and run 
> with Java 22, and I didn’t locate any issues yet.
> 
> Don’t forget to merge your dependabot PRs, when you’re moving on with your 
> tests :)
> 
> ~ Alex
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/A1D5D458-5303-4B3E-B008-A40A0352823E%40notmyfault.dev.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/831BBE9B-F6E9-43AA-9615-8D0D1DB89A3B%40gmail.com.


Re: Remove Suggestimate from issues.jenkins.io?

2024-03-11 Thread Ullrich Hafner
+1

> Am 11.03.2024 um 14:48 schrieb Mark Waite :
> 
> The Jenkins Jira instance  uses a Jira datacenter 
> license that is donated to the Jenkins project by Atlassian.
> 
> The Suggestimate plugin 
> 
>  is installed on the Jenkins Jira instance and is reporting that its license 
> has expired.  The Suggestimate pricing page 
> 
>  says that the plugin would cost $4500 per year based on the number of users 
> of our Jira instance.  The question and answer section indicates that our 
> donated Jira Datacenter license does not include the license for the plugin.
> 
> I propose that we should remove that plugin from issues.jenkins.io rather 
> than pay a licensing fee for the plugin.
> 
> Any objections to the removal of that plugin from issues.jenkins.io?
> 
> Mark Waite
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/a96f9c00-ff28-47fb-a3eb-210826ae5d7dn%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/87EA7F1C-77D7-4D93-9892-0744A6DE54AD%40gmail.com.


Re: 2.440 as Feb 21, 2024 LTS baseline?

2024-01-13 Thread Ullrich Hafner
+1

> Am 13.01.2024 um 10:27 schrieb Tim Jacomb :
> 
> +1
> 
> On Sat, 13 Jan 2024 at 08:51, 'Alexander Brandes' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> 
> wrote:
>> I’m +1 for 2.440 :)
>> 
>> 
>>> On 13. Jan 2024, at 02:32, Mark Waite >> > wrote:
>>> 
>>> Wednesday Jan 10, 2024 is the day that we should select the baseline for 
>>> the long term support release that will be delivered February 21, 2024.
>>> 
>>> I propose Jenkins 2.440  as the 
>>> next LTS baseline.  It was released Tuesday Jan 9, 2024.  It includes user 
>>> interface improvements, configuration as code improvements, and 
>>> improvements to the remoting library that communicates with agents.
>>> 
>>> Feedback is positive on the release.  It is running on weekly.jenkins.io 
>>>  and I'm using on my weekly installation.
>>> 
>>> Mark Waite
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>>> .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/bea3f5b4-bea7-41b4-8344-6bdcb56bc33en%40googlegroups.com
>>>  
>>> .
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/A48D3272-E4E5-4203-86BD-BE106F0A1CAB%40notmyfault.dev
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bidx1khZUc_-mey-W3A%2BzcasCi%3DzKRu8p05z9DD%3D5wdL3A%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6DD7ED0E-3A21-45CE-A0BE-83B74A2247A1%40gmail.com.


Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread Ullrich Hafner
The correct setting is:

17
17

> Am 13.12.2023 um 12:55 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Wed, Dec 13, 2023 at 5:56 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> I think our tool chain will accept Java 17 dependencies if you explicitly 
>> declare it as supported by setting the java.version in you pom.
> 
> If you meant java.level, no, this is gone as of 
> https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.40
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0H-T7OQ8bUcw7KUFkA7bi8YZMXeY-n%2B4O_xkP%2BR5-%3DvA%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0H-T7OQ8bUcw7KUFkA7bi8YZMXeY-n%2B4O_xkP%2BR5-%3DvA%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2E8001E0-E92B-4FC2-A6BE-023279F600FE%40gmail.com.


Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread Ullrich Hafner
I think our tool chain will accept Java 17 dependencies if you explicitly 
declare it as supported by setting the java.version in you pom. But this makes 
no sense in your case, as you are just using a wrong dependency.
(I have a plugin distributed that is based on Java 17 as the underlying library 
uses Java 17 as a minimum version.)

> Am 12.12.2023 um 22:08 schrieb Basil Crow :
> 
> As of v6.x, pac4j requires Java 17 or newer. The Jenkins plugin
> development toolchain will not accept Java 17 bytecode as long as
> Jenkins core still supports Java 11. You will need to stay on v5.x of
> pac4j until around fall of next year when Jenkins requires Java 17 or
> newer.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrCoZb186jw%2BOOXtF2JzBVw7X%2BUZw_LT2D0r7ngYdxeOQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/A05A5786-F19B-4FD5-AC29-3D63E045CC11%40gmail.com.


Re: does not have help

2023-11-14 Thread Ullrich Hafner
Is your source code public? I never needed to override getHelpFile(). 



> Am 14.11.2023 um 10:26 schrieb tzach solomon :
> 
> Thanks Ullrich,
> 
> Yes, I have those but still it doesn't work.
> My jenkins version is: 2.303.3
> 
> From what I can see, checkbox.jelly has the following
> 
>   Used for databinding. TBD.
> 
> I've also overridden the getHelpFile() method in my descriptor to see which 
> fieldName are passed and I do see all other fields besides the checkbox.
> Is there a way to troubleshoot this?
> 
> 
> 
> On Tue, Nov 14, 2023 at 10:44 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> A checkbox has a help as well. Maybe your Java field name does not match? 
>> E.g. in my plugin I have a help-file help-ignoreFailedBuilds.html that is 
>> mapped to the checkbox ignoreFailedBuilds with a getter 
>> getIgnoreFailedBuilds and setIgnoreFailedBuilds.
>> 
>> 
>> 
>>> Am 14.11.2023 um 09:20 schrieb tzach solomon >> <mailto:tzach.solo...@gmail.com>>:
>>> 
>>> Hi,
>>> 
>>> If I'm not mistaken, there is no help working for jelly form checkbox entry.
>>> Is there  a way to have help displayed for a checkbox?
>>> 
>>> Thanks,
>>> Tzach
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAC19wgL95_VxCBrrpnUwRZUo4TTYpHq%2BFyM1PQYbstt6B4NVxQ%40mail.gmail.com
>>>  
>>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAC19wgL95_VxCBrrpnUwRZUo4TTYpHq%2BFyM1PQYbstt6B4NVxQ%40mail.gmail.com?utm_medium=email_source=footer>.
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/47445CF5-7E60-4228-8AEC-46175AE2FAD6%40gmail.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/47445CF5-7E60-4228-8AEC-46175AE2FAD6%40gmail.com?utm_medium=email_source=footer>.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAC19wgLL9w1mkLudgC9PQ9CXoM%2BUN%2BhzeKs7zt7p5ow3epPhQA%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAC19wgLL9w1mkLudgC9PQ9CXoM%2BUN%2BhzeKs7zt7p5ow3epPhQA%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ADB3F3F4-ACC6-4655-8C85-B791713045A3%40gmail.com.


Re: does not have help

2023-11-14 Thread Ullrich Hafner
A checkbox has a help as well. Maybe your Java field name does not match? E.g. 
in my plugin I have a help-file help-ignoreFailedBuilds.html that is mapped to 
the checkbox ignoreFailedBuilds with a getter getIgnoreFailedBuilds and 
setIgnoreFailedBuilds.



> Am 14.11.2023 um 09:20 schrieb tzach solomon :
> 
> Hi,
> 
> If I'm not mistaken, there is no help working for jelly form checkbox entry.
> Is there  a way to have help displayed for a checkbox?
> 
> Thanks,
> Tzach
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAC19wgL95_VxCBrrpnUwRZUo4TTYpHq%2BFyM1PQYbstt6B4NVxQ%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/47445CF5-7E60-4228-8AEC-46175AE2FAD6%40gmail.com.


Re: Tests are failing with Unable to inject class hudson.model.UserIdMapper after upgrading the build from java 8 to java 11

2023-11-07 Thread Ullrich Hafner
Does it fail locally? Did you try Java 17 (we are currently in the process of 
testing Java 21, so nobody is looking at Java 11 JDK anymore).

> Am 06.11.2023 um 22:01 schrieb Anna Karyakina :
> 
> Hi everyone,
> 
> I got stuck with upgrading my plugin build from java 8 to java 11. It 
> compiles, but several tests that used to pass with java 8 now fail with 
> "org.jvnet.hudson.reactor.ReactorException: 
> java.lang.IllegalArgumentException: Unable to inject class 
> hudson.model.UserIdMapper". Here's a link to the complete stack trace: 
> Plugins » fortify-plugin » master #2 Console [Jenkins] 
> . 
> Could someone please share their thoughts/experience?
> 
> I have a suspicion that it has something to do with the more restrictive 
> classloading security, and something like add-opens (what package?) might 
> help, but the strange thing is that I can't find any reference to others 
> running into the same issue. I searched this group's archive as well.
> 
> Here's my pom.xml: fortify-plugin/pom.xml at master · 
> jenkinsci/fortify-plugin (github.com) 
> . 
> I've already tried updating parent pom and jenkins versions to the latest. I 
> also tried to rewrite the JCASC test to the new @ConfiguredWithCode way. 
> Here's the pull request with the recent updates:  <>Jenkins latest version 
> upgrade by akaryakina · Pull Request #71 · jenkinsci/fortify-plugin 
> (github.com)  None of 
> these actions really changed anything, so I am feeling a little stuck. <>  <>
> 
> Thanks,
> Ann.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAGST4yi5zBN9vW%3DF-Se9zGLick1rkuA0KW8wAMJbaoV9PpRrsA%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CC977D0A-8C09-4067-BC21-06913D8AD752%40gmail.com.


Re: October 30, 2023 Governance Board Agenda

2023-10-30 Thread Ullrich Hafner
Hmm, it seems that I missed the meeting. It was not adapted to the winter time, 
sorry. Can we move it again back to the same local time?


> Am 30.10.2023 um 18:04 schrieb Mark Waite :
> 
> News
> Jenkins elections 2023 nominations have closed - Alexander Brandes and Ulli 
> Hafner
>  <https://hackmd.io/6mgEkr1rS7Ca4j4a5YxZfA?view#Action-Items>Action Items
> Alexander Brandes and Ullrich Hafner run the officer and board elections for 
> 2023
> 57 registered voters
> Timeline
> Nominations are closed (September 18 - October 27)
> All roles have at least one nominee
> If role is uncontested, then no need to vote
> If candidates agree to accept the nomination and they are only nominee, then 
> they are elected
> Voter registration (September 18 - November 05)
> Voting (November 06 - December 1)
> Results announcement (December 11)
> Mark Waite submit jenkins.io <http://jenkins.io/> pull request to combine 
> subprojects and SIGs into a single concept - “working groups”
> More pull requests needed
> Retire the Chinese Jenkins site - deadline for 4 weeks to close (Kevin 
> Martens)
> Chinese site link removed from www.jenkins.io <http://www.jenkins.io/> header
> Kevin Martens (Docs Officer) tracking help desk ticket 
> <https://github.com/jenkins-infra/helpdesk/issues/3379> to replace the 
> Chinese pages with redirects to the English pages
> Need a redirect from https://www.jenkins.io/zh/ to https://www.jenkins.io/ 
> <https://www.jenkins.io/zh/>
> Kevin to work with the infrastructure team on the Helm charts implementing 
> the Chinese site
> Mark Waite draft a proposal to the board for license policy and phrasing 
> changes
> Discussed briefly at Linux Foundation Member Summit
> Linux Foundation legal team is willing to review proposal
> No further progress
> Allow other licenses like the JSON license
> Some other approach?
> What license should be used for a library plugin?
> License of the wrapped library (if wrapped library has no separate code, then 
> seems likely)
> MIT license as used by Jenkins plugins (if abstraction layer in the plugin, 
> then MIT for ours?)
> Review responses from other projects to license mixture (e.g. PyPI)
> Mostly focuses on OSI approved licenses but include a separate category for 
> other licenses
> Have categories for freeware, public domain, and more
> Reasonable precedent for allowing a wider range of licenses
> Needs more discussion, but being more permissive is working for PyPI
> Newer licenses may be more controversial
>  <https://hackmd.io/6mgEkr1rS7Ca4j4a5YxZfA?view#Community-activity>Community 
> activity
> Java 11, 17, and 21 in Jenkins - Mark Waite
> 2+2+2 Java support plan - Jenkins enhancement proposal 
> <https://github.com/MarkEWaite/jep/tree/java-adoption-plan/jep/#java-11> 
> submitted
> Ready to assign a JEP number and mark as a Draft
> Mark Waite to assign the JEP and mark as a Draft
> Summary of discussions
> Jenkins developers mailing list 
> <https://groups.google.com/g/jenkinsci-dev/c/RaAloTTM9CQ/m/kag1KJSVAwAJ> - 
> quiet
> Jenkins users mailing list 
> <https://groups.google.com/g/jenkinsci-users/c/NGDRrNsaDYY/m/zj5RpSNSAQAJ> - 
> quiet
> Jenkins enhancement proposal 
> <https://github.com/MarkEWaite/jep/tree/java-adoption-plan/jep/#java-11> 
> - needs review
> Key dates
> Oct 3, 2023 - Java 11 end of life monitor visible in Jenkins weekly
> Nov 15, 2023 - Java 11 end of life monitor visible in Jenkins LTS
> Oct 2, 2024 - Last Jenkins LTS release to support Java 11
> Oct 30, 2024 - First Jenkins LTS to require Java 17
> Oct 31, 2024 - end of Java 11 support by Jenkins project
> Hacktoberfest nearing its end
> Jean-Marc Meessen message to developer list 
> <https://groups.google.com/g/jenkinsci-dev/c/wwtLLHNYAjo/m/ZcnRpsRUAAAJ>
> Friendly Jira issues list 
> <https://issues.jenkins.io/secure/Dashboard.jspa?selectPageId=19342>
> GitHub good first issues 
> <https://github.com/search?q=org%3Ajenkinsci+good-first-issues=issues>
> Infrastructure good first issues 
> <https://github.com/search?q=org%3Ajenkins-infra+good-first-issues=issues>
> Gitter requests that look for “where to start?”
>  <https://hackmd.io/6mgEkr1rS7Ca4j4a5YxZfA?view#Governance-Topics>Governance 
> Topics
> Board and officer elections - Alexander Brandes *
> 
> Processing the Azure credits donation - Mark Waite
> 
> Damien Duportal outlined alternatives in email message to the board
> Donation of Oracle Cloud costs by CloudBees - Mark Waite
> 
> Oracle Cloud account remains open until Oracle agrees all invoices are 
> resolved
> Total CloudBees donation - $1800 or less
> Jenkins project expenses on O

Re: auto release form branch or manual release of multimodule project

2023-10-27 Thread Ullrich Hafner
Our developer documentation is part of the website:
https://github.com/jenkins-infra/jenkins.io/


> Am 27.10.2023 um 16:02 schrieb Jiri Vanek :
> 
>> That is the trick which did the trick!
>> Tyvm for providing such direct solution. I would not found those 
>> attributes...
>> The build needed more tweek, but I think I'm nearly done. It now fails in 
>> final upload:
>> [INFO] [INFO] Uploading to maven.jenkins-ci.org: 
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/2.4/report-jtreg-plugin-2.4.pom
>> [INFO] [INFO] Uploading to maven.jenkins-ci.org: 
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/2.4/report-jtreg-plugin-2.4.hpi
>> [INFO] [INFO] Uploading to maven.jenkins-ci.org: 
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/2.4/report-jtreg-plugin-2.4.jar
>> [INFO] [INFO] I/O exception (java.net.SocketException) caught when 
>> processing request to {s}->https://repo.jenkins-ci.org:443: Connection or 
>> outbound has closed
>> [INFO] [INFO] Retrying request to {s}->https://repo.jenkins-ci.org:443
>> [INFO] [INFO] Uploading to maven.jenkins-ci.org: 
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/2.4/report-jtreg-plugin-2.4-sources.jar
>> [INFO] [INFO] I/O exception (java.net.SocketException) caught when 
>> processing request to {s}->https://repo.jenkins-ci.org:443: Connection or 
>> outbound has closed
>> [INFO] [INFO] Retrying request to {s}->https://repo.jenkins-ci.org:443
>> [INFO] [INFO] Uploading to maven.jenkins-ci.org: 
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/2.4/report-jtreg-plugin-2.4-javadoc.jar
>> Where the reason is wrong base url:
>>   
>> https://repo.jenkins-ci.org/releases/io/jenkins/plugins/report-jtreg-plugin/
>> whcih should have been
>>   
>> https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugins/report-jtreg/
>> This is yet again decalred in parent pom.
>> Any similar trick to the  one?
> 
> Also, is there some wikipage I can update for this? Alhough multimodule 
> plugins are not common, they do exists, and it is quite hard to walk through
>> TYVMS guys!
>>   J.
>> On 10/26/23 17:54, Basil Crow wrote:
>>> On Thu, Oct 26, 2023 at 7:04 AM Jiri Vanek  wrote:
 
 I was fiddling with 
 https://github.com/jenkinsci/report-jtreg-plugin/blob/master/pom.xml#L27  
 (mostly reset to jenkinsci but it did not did the 
 job.
>>> 
>>> Just replace  with >> child.scm.connection.inherit.append.path="false"
>>> child.scm.developerConnection.inherit.append.path="false"
>>> child.scm.url.inherit.append.path="false">.
>>> 
> 
> -- 
> Jiri Vanek Mgr.
> Principal QA Software Engineer
> Red Hat Inc.
> +420 775 39 01 09
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/6c4642c0-7ca6-4bf6-82c4-638719e07ea8%40redhat.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/E4EB84EC-CF0E-452F-9D3A-151D8EEB4746%40gmail.com.


Re: auto release form branch or manual release of multimodule project

2023-10-26 Thread Ullrich Hafner
I think the incremental tools do not work with multi-module projects. I always 
cd to my plugin folder and start mvn release from there.

> Am 26.10.2023 um 12:10 schrieb Jiri Vanek :
> 
> Hello!
> 
> I have a plugin - https://github.com/jenkinsci/report-jtreg-plugin/ -  where 
> main branch is aligned with future, prototypeJS-less  jenkins, and so it have 
> another branch, which is compatible with current live jenkinses.
> In this setup, I was able to do the only live version of this plugin - 2.1. 
> IIRC, I had released this one via `mvn release:prepare release:perform`
> Recently, we had heavily refactored the plugin, so ti is now multi-module 
> maven plugin, with lib, plugin (with bundled lib), and two standalone 
> services which depends on lib, and - if manually started - can comunicate 
> with plugin. The release here, of course counts only with the hpi plugin.
> 
> Today I wished to release 2.3 but I underestimated it, and (after quite a 
> struggling), only top level pom.xml got uploaded to artifactory.
> However, the commits to master, seems to be (via GHactions autorelease) 
> correctly propagated to artifactory as incremental per-merge binaries, 
> including lib, plugin and also both services.
> So,encouraged by this, I had manually pushed to  not-main branch, and tagged, 
> and hoped that incremntalify will pick it up and  release. Nope.
> 
> I guess best would be to setup incrementalify to release only from my 
> non-main branch (until prototypejs-less jenkins reaches LTS), is ti possible?
> If not, any hint on how can I manually release, or jsut upload, binaries from 
> the branch to artifactory?
> 
> 
> Thanx!
>  J.
> 
> 
> 
> 
> -- 
> Jiri Vanek Mgr.
> Principal QA Software Engineer
> Red Hat Inc.
> +420 775 39 01 09
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/3527668e-9cf3-4f91-834c-5270b1a6d7ea%40redhat.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/FB5D50EB-F5F1-43F2-8659-6D8DEBC0C466%40gmail.com.


Re: Splitting a plugin into a legacy and supported part

2023-10-15 Thread Ullrich Hafner
> Am 13.10.2023 um 15:02 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Fri, Oct 13, 2023 at 2:38 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> there might be still some users that use the old and deprecated steps
> 
> Like, Pipeline steps? So you cannot confidently delete this code without 
> potentially breaking user workflows?
>  

Yes exactly. Users tend to not change a running system if they do not need to. 
They can update their pipelines later when they want to make use of the new 
step and the new features. And this is something I want to support.

>> Move the old code to a new plugin with new plugin id. Make that new plugin a 
>> dependency of the code-coverage-api plugin.
> 
> I think this is backwards—then you are permanently locking the deprecated 
> code into the dependency chain.

Yes, you are right. I thought I can remove the dependency in a couple of months 
when everybody made the transition but it makes sense to use the opposite 
direction.

> 
> `workflow-cps-global-lib-plugin` originally contained an in-Jenkins Git 
> server that you could push Pipeline Groovy libraries to. Later we added an 
> option to pull libraries from the SCM of your choice, and deprecated the 
> original code, but it stuck around and was a maintenance burden. So finally 
> we introduced `pipeline-groovy-lib-plugin` containing just the newer code (in 
> the same package structure and everything), made `workflow-cps-global-lib` 
> depend on `pipeline-groovy-lib`, and deprecated the whole 
> `workflow-cps-global-lib` plugin. Thus existing servers with 
> `workflow-cps-global-lib` installed would upgrade plugins, which would 
> automatically install `pipeline-groovy-lib` as a dependency, but see no 
> behavioral change. Admins could then at their leisure uninstall 
> `workflow-cps-global-lib` assuming they were not in fact using the old Git 
> server. New servers need never install `workflow-cps-global-lib` to begin 
> with (no longer a dep of `workflow-aggregator` or otherwise offered in the 
> setup wizard, etc.).


This is the way I also used for the warnings next generation plugin. I created 
a new plugin that was added as a dependency to the old and deprecated warnings 
plugin. It has the disadvantage that the new plugin has a new plugin ID and 
name. But I think the benefits are much bigger as you also mentioned in your 
example. 

Another advantage of your suggested approach is that I can remove the API 
suffix of the new plugin as it does not provide any extension points for other 
plugins anymore. That means no other old and deprecated plugins will depend on 
the new plugin.

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/EDD77542-E9E4-4F58-ABCB-A8A97ACC0B61%40gmail.com.


Splitting a plugin into a legacy and supported part

2023-10-13 Thread Ullrich Hafner
Hi,

I want to retire a lot of old and legacy code in the code-coverage-api plugin 
in order to simplify the development experience (e.g., there are duplicate 
classes and jelly views). It is difficult for new contributors to start 
development when they do not know which classes and views are actually still 
used. Since there might be still some users that use the old and deprecated 
steps I am wondering how to do that in the best way.

1) Move the old code to a new plugin with new plugin id. Make that new plugin a 
dependency of the code-coverage-api plugin. Benefits: Everything is out of 
sight, not-used dependencies can be moved as well. Clean restructuring of the 
plugin.
2) Move the old code to a different source folder. Maven does support that but 
I am not sure if our maven-hi plugin does. Benefits: no new plugin is required, 
but dependencies need to be shared for both parts of the code.
3) Move the old code to a maven sub module in a new folder. Maven does support 
that but I am not sure if the rest of our build infrastructure does.

Or is there even anotheroption that I do not see?

My favorite is option 1), but that requires to create a new plugin in the 
jenkinsci organization.

Ulli 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5D44F363-6A45-4430-B82F-581CF815E14B%40gmail.com.


Re: 2.426 as Nov 15, 2023 LTS baseline?

2023-10-04 Thread Ullrich Hafner
+1

> Am 04.10.2023 um 17:27 schrieb Basil Crow :
> 
> +1
> 
> We'll likely need to backport the fix for JENKINS-71937.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpVnas%2BsRLfP1BPW02vCu%3DF97_My6KyVP55%2B0Mc-TH_ZQ%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/52197261-83A1-4A85-ADBB-925C7B03F91E%40gmail.com.


Re: Jelly dropdown list with filter?

2023-09-08 Thread Ullrich Hafner
You can use a  


> Am 08.09.2023 um 04:56 schrieb Michael Carter :
> 
>  
> 
> Is there an option or variant that has a filter in it?   Some of the 
> dropdowns I have can get quite large and before I go writing something wanted 
> to see if there was something out there available to plugin developers.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/94458145-6100-452c-a0fb-2d8c6cbd1cd1n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1EE62CF2-97A4-4428-A73B-9C2000EF4CE9%40gmail.com.


Re: JSON license

2023-07-26 Thread Ullrich Hafner
> 
> 
> On Tuesday, July 25, 2023 at 4:24:04 PM UTC-6  Filipe Roque wrote:
> I have not found any discussion on the mailing list about this.
> 
> JSON License has not been considered an open source license by Apache [1], 
> Debian [2] and FSF [3] and is not OSI approved [4].
> 
> Douglas Crockford has relicensed org.json:json java library to be Public 
> Domain starting with version 20220924 [5].
> 
> Jenkins requires plugins and its dependencies to be free and open source 
> software [6][7].
> 
> I did some analysis on the latest Jenkins plugins usage of org.json:json [8]. 
> I have found a total of 473 plugins that depend on org.json:json (directly or 
> transitively), with 104 plugins being free versions, 67 plugins directly 
> depend on non free versions of org.json:json. 
> 
> Is this an actual concern for the Jenkins project ? If so, how to proceed ?
> 
> I think it is a concern for the Jenkins project.  Thanks for noting the 
> issue.  I don't think the risk is high, but it is a concern that is worth 
> some effort to assure that Jenkins remains free and open source.
> 
> I believe one concern is related to software that is in the public domain not 
> using an OSI approved license.  We could extend the definition of licenses 
> accepted by the Jenkins project to include OSI approved licenses and public 
> domain software.  That would address the concerns of those who worry that 
> "public domain" is not a license.

That would make sense, yes.

> 
> The other concern is how do we reduce the number of versions and encourage 
> use of the public domain version instead of the not quite OSI approved 
> license of the earlier versions.  I think that Basil's observation that the 
> org.json:json should be made into a library plugin is the way to reduce the 
> number of versions and encourage use of the public domain version.

I think it would be easier when the plugins (if they are still maintained) 
would bump their version to the latest public domain version. Using a library 
plugin needs someone to maintain the library and all plugins need to upgrade 
their baselines and modernize the plugins (so it would be better to use a 
library but will cause more work). Maybe this is something for Hacktoberfest?

> 
> With regards to the list of plugins, only 7 of the 67 plugins that directly 
> depend on versions prior to 20220924 have more than 1000 installations.  
> Those seem like the first candidates to consider for either an upgrade of the 
> library version or replacement of the library dependency with a plugin 
> dependency.
> 
> With regards to the analysis, I'm not confident in my understanding of the 
> specific details of the analysis.  Maybe you can help me understand more 
> clearly.
> 

What do the colors mean in the spreadsheet?

> I maintain the elastic axis plugin and it is on the list as having a 
> transitive dependency on an older version of the json library.  The elastic 
> axis plugin depends on the matrix project plugin.  The matrix project plugin 
> depends on the junit plugin.  The junit plugin depends on the jackson2 api 
> plugin.  The jackson2 api plugin bundles the jackson2 api jar file and the 
> json-20230227.jar inside its hpi file.  I think that would cause jackson2 api 
> calls to use the the json-20230227.jar that is bundled in the hpi file.
> 
> However, the analysis indicates that there is a dependency on json-20190722.  
> Is the analysis not detecting that the jackson2 api plugin already includes a 
> newer version of the json library?  Am I misunderstanding how libraries are 
> resolved?
> 
> I'll put the topic on the next agenda for the Jenkins governing board.
> 
> Thanks,
> Mark Waite
>  
> 
> Filipe Roque
> 
> [1] https://lwn.net/Articles/707510/
> [2] https://wiki.debian.org/qa.debian.org/jsonevil
> [3] https://www.gnu.org/licenses/license-list.html#JSON
> [4] https://opensource.org/licenses/
> [5] https://github.com/stleary/JSON-java/issues/686
> [6] https://www.jenkins.io/doc/developer/publishing/preparation/#license
> [7] 
> https://www.jenkins.io/project/governance/#3rd-party-library-licenses-in-the-plugins
> [8] 
> https://docs.google.com/spreadsheets/d/1MWNi796iAovFa6GK7LJ0gilbQRwvb8Su3c7YgpH_fuc/edit?usp=sharing
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/d84bbf01-6d3c-495c-81fb-a715377c89e4n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving 

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-07-17 Thread Ullrich Hafner
Is there a reason that we are still bundling the JUnit plugin in our war? It 
has been removed from core quite some years ago...

> Am 17.07.2023 um 20:33 schrieb Basil Crow :
> 
> On Mon, Jun 12, 2023 at 10:39 AM Basil Crow  > wrote:
> >
> > Then 
> > https://github.com/jenkinsci/jenkins/blob/c886642632d81091c17d93f16b50c97ffb04d146/war/pom.xml#L406-L412
> > needs to be adjusted.
> 
> JENKINS-71666  FTR
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrev6_AbRXZpgf_%3Dx6iRU%2Bwo2eAicsWY-iiUTihBBGoww%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2008F9A2-CA63-4276-87CF-36FD4390939D%40gmail.com.


Re: July 10, 2023 Governance Board Agenda

2023-07-10 Thread Ullrich Hafner
I got stuck in a train and will not make it today…Ulli-- Ulli - Typed with big thumbs on small phoneAm 10.07.2023 um 18:14 schrieb Mark Waite :The Jenkins governance board meets today at 6:00 PM UTC on Zoom.  The Zoom URL is https://zoom.us/j/91564716663?pwd=R3A2RDFGcU1wTVdoVTErYm1jNzVWdz09Current meeting agenda is:Agenda:NewsReleasesJenkins 2.401.2 released Wednesday June 28, 2023Next LTS baseline to be selected by Wednesday July 12, 2023Jenkins 2.401.3 releases Wednesday July 26, 2023 - Kris Stern release leadInfrastructureUpgrade from Jira 8 to Jira 9 is completeCDF Technical Oversight Committee now includes Mark WaiteAction ItemsMark Waite archive the governance meeting notes to a GitHub repository, use the Google doc as the working document, then publish final notes (done)Mark updated the archive and submitted a pull request to the governance meeting archives repositorySee the infra help desk ticket tracking the discussionAlexander recommended using a new repository, separate from the governance meeting archives repositoryMark Waite proposes to stay with the existing repository, add more content as meetings happenMark Waite submit jenkins.io pull request to combine subprojects and SIGs into a single concept - “working groups”More pull requests neededRetire the Chinese Jenkins siteChinese site link removed from www.jenkins.io headerKevin Martens (Docs Officer) tracking help desk ticket to replace the Chinese pages with redirects to the English pagesNeed a redirect from https://www.jenkins.io/zh/ to https://www.jenkins.io/Mark Waite retrospective on signing certificate renewal process and its improvementsCode signing certificate update for MSI and WAR filesPGP signing key update for RPM and DEB filesDebian key packaging improvements (some other projects use that technique now)Notification and process improvementsReimbursement improvementsDetails being gathered in the retrospective documentCommunity activity4 Google Summer of Code projects midterm presentations complete, evaluations due this weekMid-term presentations recording is availableArtifactory bandwidth reduction project https://repo.jenkins-ci.org JFrog has asked that we switch our mirrored repositories (repo-1, jgit, etc.) from public to private so that they are not misused as caches by othersChanges to be evaluated to test the switchAdjust parent poms to declare multiple repositoriesPrototype.js removal blog post guides new contributorsPrototype.js removal epic making progressPlugin progress visible in the tracking sheetPull requests submitted for most popular pluginsFeature flag available to disable prototype in Jenkins core 2.406 and laterHTMLUnit 3 upgrades proceeding through 250+ plugin pull requestsCompleted for test harness, core 2.409, tools, plugin pom 4.66, and plugin bom 2163See the tracking sheet for latest statusThanks to Tim Jacomb and Basil Crow, see Tim’s replacement script



-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/341cb75e-76dd-486f-8a74-5c9f5b6e06ebn%40googlegroups.com.




-- 
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8D1E0474-EECE-42C4-A3BC-398D1ECCC10D%40gmail.com.


Re: Requesting Admin access to the jenkinsci organization

2023-06-05 Thread Ullrich Hafner
+1 from me

> Am 05.06.2023 um 09:50 schrieb Alexander Brandes :
> 
> Hey everyone,
> 
> I would like to increase my involvement within the Jenkins project beyond a 
> maintainer scope, and would like to request admin access to the jenkinsci 
> GitHub organization.
> 
> Besides my seat on the Jenkins governance board, I am one of the core 
> maintainers within the jenkinsci GitHub organization.
> The recent sponsorship of the project coming from GitHub and the adoption of 
> enterprise features, like autolink references you can find in core 
> repositories already, are one of the examples of my work, which wouldn't be 
> possible without me bothering Tim Jacomb constantly to click the right 
> buttons for me.
> I have admin access to various core component and plugin repositories within 
> the jenkinsci organization, plus the jenkins-infra organization, including 
> jenkins.io  or the plugin site. Having admin permissions 
> in the jenkinsci organization would allow me to help to facilitate 
> contributions of these kinds to the Jenkins project.
> 
> My GitHub account is configured securely, and I have an ICLA signed.
> 
> Would the project be fine with such a request?
> 
> Thanks in advance,
> Alexander Brandes
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAP9joaHYsQEvPKLQpxdWPW_OR92O98F8Xt1AWMyDsO-03tYiQg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/E1D85BB2-8BC6-4346-B134-5035E20B4B32%40gmail.com.


Re: Permission to upload new Sonargraph Jenkins plugin release 5.0.2 to plugin repository

2023-06-01 Thread Ullrich Hafner
> The colleague who was working on our plugin before no longer maintains that 
> plugin. He left the company (hello2morrow).
> 
> I submitted a PR (pull request) to obtain authorization. I got feedback, that 
> I would  need the authorization of 3 developers, which all no longer work for 
> our company, They no longer maintain any Sonargraph related open source 
> component. 
> 
> So I am kind of stuck here - help is appreciated.

Did you try to reach out to these developers? 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/8870AEA7-0F41-48C3-B470-DC62B53EB65B%40gmail.com.


Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-25 Thread Ullrich Hafner
> I strongly feel the solution is to have more jelly or web components, that do 
> the standard ui behavior with encapsulation and contracts, and those that 
> want to be able to do custom logic, should include their own dependencies via 
> a bundler. 

Rather than reinventing the wheel we should use more of those rock-solid 
component that are already on the market. We have so limited development 
resources in Jenkins in the moment that it does not make sense to create our 
own version of ECharts, or Bootstrap, etc.  


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/414E3000-AB3B-4E36-AA78-17D7146C46F5%40gmail.com.


Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Ullrich Hafner
> Am 24.05.2023 um 18:57 schrieb Basil Crow :
> 
> On Tue, May 23, 2023 at 10:18 AM 'Gavin Mogan' via Jenkins Developers
>  wrote:
>> I tried accessing "Popper.createPopper" on ci.jenkins.io and it doesn't seem 
>> to be defined, so I don't think its exposed?
> 
> Then why was https://github.com/jenkinsci/bootstrap5-api-plugin/pull/213 
> needed?
> 

The dependency to popper2 has been removed from bootstrap a couple of months 
ago, but not the include. Therefore I removed the include as well. 

Popper is now part of the Bootstrap plugin. (So somehow in my own Jenkins UI 
"core“ to create rich user interfaces without hassle.) 

> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjqd2pooJbPtZkfeVKN%2Byu4xE%2Bf7ZD2w8aMVpyfS5hxEuw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/E87719E5-6C6F-4FBD-889B-BC0FB5F8B058%40gmail.com.


Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Ullrich Hafner
I would not consider Popper as a standalone library an artifact. Now we need to 
configure and load it twice.

I understand that this is the best thing from an architectural view. But 
sometimes you need to make tradeoffs otherwise development costs will increase 
too much…

> Am 23.05.2023 um 21:04 schrieb 'Gavin Mogan' via Jenkins Developers 
> :
> 
> I totally agree for jenkins components to be exposed, but not artifacts of 
> those ui components because it leads to the 15 years of trying to get rid of 
> prototype because people used it directly.
> 
> On Tue, May 23, 2023 at 11:57 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> > 
>> >> I think that users also will benefit from views that do not load the same
>> >> library multiple times (loading time of a page). Also it duplicates the
>> >> development effort if we create a plugin API for each JS library that we 
>> >> are
>> >> using in core.
>> > 
>> > These are indeed benefits, but I think the maintenance costs of exposing 
>> > core
>> > libraries to plugins are higher. This is a serious problem in every modular
>> > system that fails to hide its internal implementation details from 
>> > consumers;
>> > see, for example:
>> > 
>> > http://dtrace.org/blogs/wesolows/2014/04/10/libsunw_ssl-or-how-smartos-avoids-sadness/
>> > 
>> 
>> I’m a little biased as a plugin developer but for me Jenkins core is not a 
>> system on its own that needs to be encapsulated. Jenkins core should provide 
>> all required components to create rich user interface for plugins. Providing 
>> the same JS libraries for my plugins feels a little bit like providing my 
>> own core to create value for my users. When we create new form elements in 
>> core (and tooltips like tippy) I want to use them in my plugins as well. 
>> That means core should be the basis for all other development and not a 
>> parallel component side by side with plugins. 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> <mailto:jenkinsci-dev%2bunsubscr...@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/1A740EFF-B3BA-4891-AEF0-9F3804B63A8B%40gmail.com.
>> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duvx%2BdamT5QFvKoyOO4Og7FFkD1rELW%2BUF%2BfFNyNHh7zCw%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duvx%2BdamT5QFvKoyOO4Og7FFkD1rELW%2BUF%2BfFNyNHh7zCw%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/37F195C4-B0D3-4D06-B83E-7CCC93D61F93%40gmail.com.


Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-23 Thread Ullrich Hafner
> 
>> I think that users also will benefit from views that do not load the same
>> library multiple times (loading time of a page). Also it duplicates the
>> development effort if we create a plugin API for each JS library that we are
>> using in core.
> 
> These are indeed benefits, but I think the maintenance costs of exposing core
> libraries to plugins are higher. This is a serious problem in every modular
> system that fails to hide its internal implementation details from consumers;
> see, for example:
> 
> http://dtrace.org/blogs/wesolows/2014/04/10/libsunw_ssl-or-how-smartos-avoids-sadness/
> 

I’m a little biased as a plugin developer but for me Jenkins core is not a 
system on its own that needs to be encapsulated. Jenkins core should provide 
all required components to create rich user interface for plugins. Providing 
the same JS libraries for my plugins feels a little bit like providing my own 
core to create value for my users. When we create new form elements in core 
(and tooltips like tippy) I want to use them in my plugins as well. That means 
core should be the basis for all other development and not a parallel component 
side by side with plugins. 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/1A740EFF-B3BA-4891-AEF0-9F3804B63A8B%40gmail.com.


Re: CDF Project Representative nominations

2023-05-23 Thread Ullrich Hafner
I am also +1 that Mark would be a good representative person of the Jenkins 
project for the CDF TOC. 

> Am 22.05.2023 um 21:14 schrieb Alyssa Tong :
> 
> Thank you Oleg for your role in the CDF TOC.  
> I am +1 for Mark as TOC candidate for Jenkins.
> 
> BR,
> alyssa
> 
> On Mon, May 22, 2023 at 11:42 AM Oleg Nenashev  > wrote:
>> Hi all,
>> 
>> As it was announced in the CDF today, the nominations for CDF project 
>> representatives are open: 
>> https://github.com/cdfoundation/foundation/issues/442 . The nomination 
>> period starts on May 22, 2023 and ends on June 5, 2023. 4 of the 9 CDF TOC 
>> seats are elected from CDF Project representatives per charter. Each CDF 
>> Project may nominate a maximum of one project representative to run for 
>> these seats. Nominations must be made under this GitHub issue
>> 
>> I've represented the project since July 2021, and was a TOC chair from 
>> August 2021 until December 2022. It is a weird situation at the moment, 
>> because I am taking a long break in the Jenkins community because of the war 
>> in Ukraine and personal matters. I'm also not very interested in the TOC 
>> position at the moment, because the foundation cannot back the TOC by 
>> project management resources to organize sustainable evolution of 
>> initiatives like CDEvents. I would like to remain the CDF ambassador and 
>> help the foundation from the advocacy point, but I doubt I could represent 
>> Jenkins and achieve something positive for the project in the foundation in 
>> the current state. It would be better if somebody else steps up.
>> 
>> We had a preliminary discussion with Mark Waite, who regularly participates 
>> in the CDF TOC meetings, and he is interested in taking this role. So I 
>> would propose to nominate Mark as a single candidate from the Jenkins 
>> project, unless there are other contributors who want to step up in the 
>> foundation. Anyone? :) 
>> 
>> Best regards,
>> Oleg Nenashev
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/245fd452-d3e4-48b5-bcfd-8e09d04666can%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAC9wNawWNsEXhssarOg457bwg9MtoRvAbgXYOAFb4XO-6ib-Lg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/AF4899E3-B76A-4868-9C68-5495ED0EC7C7%40gmail.com.


Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-23 Thread Ullrich Hafner
In JS and CSS and Jelly we have no concepts of encapsulation and APIs in the 
moment. Everything what is available in the browser is public by default. In JS 
this is even more complex to hide than in Java.

I think that users also will benefit from views that do not load the same 
library multiple times (loading time of a page). Also it duplicates the 
development effort if we create a plugin API for each JS library that we are 
using in core.  

> Am 22.05.2023 um 22:58 schrieb Basil Crow :
> 
> https://github.com/jenkinsci/bootstrap5-api-plugin/pull/213 (comment)
> concerns me:
> 
>> Popper2 is now part of Jenkins core.
> 
> As far as I can tell the Popper dependency was added when replacing
> YUI tooltips with Tippy in
> https://github.com/jenkinsci/jenkins/pull/6408. Has this abstraction
> now leaked as an implementation detail that plugins are starting to
> depend on?
> 
> Any recent JavaScript dependencies of Jenkins core like Tippy and
> Popper should be built and packaged in such a way that they are not
> exposed to plugins. Plugins that want to use Popper should be using
> the Popper plugin. Both should be able to coexist at the same time.
> Ignoring this separation of concerns leads to maintenance problems in
> the future.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpLEVif3Es6yJafE29zkW6gxSROTLH0dV-cJ5sBrr5Gzw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3FE63006-128C-44CE-8DD5-E6BD2C9ADDE4%40gmail.com.


Re: Default selection in jelly with cookies

2023-05-22 Thread Ullrich Hafner
Ah, you want to use it on the server side. Sorry, then there is no equivalent 
available.

> Am 22.05.2023 um 17:03 schrieb Michael Carter :
> 
> Turns out I was thinking way to complicated:
> 
>value="${h.getCookie(request,'project').getValue()}" />
>value="${h.getCookie(request,'repo').getValue()}" />
>value="${h.getCookie(request,'branch').getValue()}" />
> 
> Then on the object:
>   
> 
> So on the local storage front.   Is there a h. function equivalent?  How 
> would I change the set?
> 
> On Monday, May 22, 2023 at 10:57:18 AM UTC-4 ullrich...@gmail.com wrote:
>> Why do you want to use cookies? This is better implemented by storing the 
>> value in the browser's local storage.
>> 
>> Example: 
>> https://github.com/jenkinsci/data-tables-api-plugin/blob/831d74b746337e6990c6aae5bff2591b2308103d/src/main/webapp/js/table.js#L148
>> 
>>  
>> 
>> 
>>> Am 22.05.2023 um 16:36 schrieb Michael Carter >:
>>> 
>> 
>>> Got a page with some  with filldependson set.   Trying to use 
>>> cookies to remember the last selection.
>>> 
>>> So few questions.  Is there an example of this I can follow in some plugin 
>>> somewhere?  
>>> 
>>>  I can use jquery to select using 
>>> 
>>> jQuery('#object').val(cookie.select1)
>>>   .trigger("change")
>>> 
>>> It selects the object but can't seem to get it to trigger the dependant 
>>> fill for the next object.  What event is it listening triggering on?
>>> 
>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-de...@googlegroups.com <>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/67cb3eb3-f2bb-49a4-959d-57683083a3den%40googlegroups.com
>>>  
>>> .
>> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/0c02494d-ba97-4022-9105-4a909e712338n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/48408A46-87A6-49A8-91E6-1FEB9B010630%40gmail.com.


Re: Default selection in jelly with cookies

2023-05-22 Thread Ullrich Hafner
Why do you want to use cookies? This is better implemented by storing the value 
in the browser's local storage.

Example: 
https://github.com/jenkinsci/data-tables-api-plugin/blob/831d74b746337e6990c6aae5bff2591b2308103d/src/main/webapp/js/table.js#L148

 

> Am 22.05.2023 um 16:36 schrieb Michael Carter :
> 
> Got a page with some  with filldependson set.   Trying to use 
> cookies to remember the last selection.
> 
> So few questions.  Is there an example of this I can follow in some plugin 
> somewhere?  
> 
>  I can use jquery to select using 
> 
> jQuery('#object').val(cookie.select1)
>   .trigger("change")
> 
> It selects the object but can't seem to get it to trigger the dependant fill 
> for the next object.  What event is it listening triggering on?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/67cb3eb3-f2bb-49a4-959d-57683083a3den%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/771EA298-0223-428C-B79A-7BA0B674AC38%40gmail.com.


Re: Revise "Bug" template fields on Jira

2023-04-17 Thread Ullrich Hafner
I think it makes sense to make the description mandatory. 

I’m not sure if the same should be done for the environment property (at least 
not globally). Wouldn’t it make more sense to make the affected core version 
selectable with something like a list box?

> Am 17.04.2023 um 18:39 schrieb Mark Waite :
> 
> 
> 
> On Monday, April 17, 2023 at 3:01:10 AM UTC-6 Alexander Brandes wrote:
> Hey everyone,
> 
> Commonly, when I'm triaging (core) issues, I almost always face submissions 
> like JENKINS-71064  and 
> JENKINS-70732 .
> These two figures are prime examples of how issue submissions are not 
> supposed to look like. The list is long, and based on my observation, getting 
> longer by day.
> 
> I don't believe it's healthy to continuously bug submitters to provide 
> details on their setup, when they could - and are supposed to - do that 
> during the submission form.
> That's part of the issue reporting documentation, we link on the issue form, 
> but is commonly ignored.
> 
> I would like to propose making the "Environment" and "Description" fields 
> mandatory for "Bug" type issues on Jira, to go a bit against issue 
> submissions without any useful information at all and stop us playing 
> guessing games.
> 
> 
> No objection from me to making those fields mandatory, especially the 
> description field.  I'd like the Jira experts like Basil Crow and Daniel Beck 
> to voice their opinions.  I think that it makes sense, but they better 
> understand the interactions between Jira components and can guide us if there 
> is a compelling reason not to make those fields mandatory.
> 
> Mark Waite
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/b0d6b0f0-4ab3-4afe-a8dc-bbd1b09e9fban%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C07A2A84-A0FE-4199-A15A-6D9EB294A8FD%40gmail.com.


Re: Jenkins JSON API

2023-04-17 Thread Ullrich Hafner
Please use the users mailing list or our community forum to post questions on 
how to use Jenkins. And please use an internet search before asking such 
questions. 

This is a developer mailing list. 

> Am 17.04.2023 um 07:45 schrieb selvavi...@gmail.com 
> :
> 
> Thanks for the update.
> Can you please let me Is it possible to get permission to start a build, 
> stop/cancel a build
> and able to create new job from Jenkins API? Kindly assist
> 
> On Monday, April 17, 2023 at 2:30:16 AM UTC+5:30 ullrich...@gmail.com wrote:
>> No, this is not possible. 
>> 
>> 
>> 
>>> Am 16.04.2023 um 16:16 schrieb selvavi...@gmail.com <> 
>>> >:
>>> 
>> 
>>> Hi,
>>> I have below doubts on Jenkins JSON based API,
>>> 1) Is it possible to apply filter on Jenkins Jobs API, like fetch success 
>>> build alone or fetch build take more than 2ms 
>>> 2) is it possible to fetch Builds which are triggered only by particular 
>>> User.
>>> 
>>> Can anyone assist on this.
>>> Thanks in advance.
>>> 
>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-de...@googlegroups.com <>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/8fb8001a-d03e-49ff-b8ba-dc29c1cdcb96n%40googlegroups.com
>>>  
>>> .
>> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/d226fde8-17a7-4414-9548-0a82c1c5a965n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/AC3AA1BC-0E3A-4224-93A8-0A19994902AE%40gmail.com.


Re: Jenkins JSON API

2023-04-16 Thread Ullrich Hafner
No, this is not possible. 


> Am 16.04.2023 um 16:16 schrieb selvavi...@gmail.com 
> :
> 
> Hi,
> I have below doubts on Jenkins JSON based API,
> 1) Is it possible to apply filter on Jenkins Jobs API, like fetch success 
> build alone or fetch build take more than 2ms 
> 2) is it possible to fetch Builds which are triggered only by particular User.
> 
> Can anyone assist on this.
> Thanks in advance.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/8fb8001a-d03e-49ff-b8ba-dc29c1cdcb96n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/87D996DF-5090-4208-A5BD-B921517D80E6%40gmail.com.


Re: script to configure repository labels

2023-03-31 Thread Ullrich Hafner
I am using the action

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/.github/workflows/sync-labels.yml

With the configuration in 

https://github.com/jenkinsci/warnings-ng-plugin/blob/master/.github/labels.yml

In all my repositories.

It uses https://github.com/micnncim/action-label-syncer internally.


> Am 31.03.2023 um 14:13 schrieb 'Herve Le Meur' via Jenkins Developers 
> :
> 
> > I was wondering if the infra team or anyone else had already written a 
> > script to set the labels to the 
> > https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.yml
> >  ones
> 
> Not that I know but I think it's a good idea! I encountered the same need on 
> jenkins-infra repositories.
> 
> > Additionally if the standard colours for the labels had been defined 
> > somewhere to avoid having conflicting label colours.
> 
> Same.
> 
> Do you mind opening a help desk issue with this request?
> 
> On Fri, Mar 31, 2023 at 1:46 PM 'jn...@cloudbees.com 
> ' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> 
> wrote:
>> Hi all,
>> 
>> When modernising a plugin I find the tedious part is to create all the 
>> labels for both CD releases and the release notes.
>> 
>> it's time consuming to find a reference repo and then duplicate the labels 
>> (and their colours) to the repo I am updating.
>> 
>> As this is not an uncommon task I was wondering if the infra team or anyone 
>> else had already written a script to set the labels to the 
>> https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.yml 
>> ones that I was unaware?
>> Additionally if the standard colours for the labels had been defined 
>> somewhere to avoid having conflicting label colours.
>> 
>> /James
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/2e3f2933-00be-4bf7-b340-6be50484e0a9n%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAL-Lwjwm7gOXg9%3DE2e1du2F%2BpRVypWH1zK%3DZE2Zib9CvQop6ew%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6BEDA057-4C9C-4E9B-BDFD-E6899314F1E9%40gmail.com.


Re: What shall be the main building block for such a plugin

2023-03-18 Thread Ullrich Hafner
Your use case sounds familiar, isn’t it already supported by the 
https://plugins.jenkins.io/promoted-builds/?

Ulli

> Am 16.03.2023 um 15:05 schrieb Tamás Mucs :
> 
> Dear Community,
> 
> I have been struggling hard with implementing a new plugin. While some of the 
> core concepts are more or less clear to me (ExtensionPoint, @Extension  
> annotation, Descriptor, Describable and jenkins.model package), I could not 
> get my project get started. I spent so much time already.
> I know of the Jenkins developer , 
> o'reilly book of extending jenkins 
> 
>  and some youtube videos from the masters Plugin development 
>  and its second part 
> .
> 
> So what's the goal?
> This plugin adds a button to each build (Run class?) to mark it "as release 
> build"
> When the user presses this button, some basic data is written to the 
> build.xml of the corresponding build (for example, isReleaseBuild -> true). 
> Even better. this could not just be a plain button on the build but rahter an 
> Action on the sidebar which brings to a page (jelly view?) that has a form 
> and the user can enter specific data about the deployment. Say, a general 
> description (String), url etc.
> When a build is marked as release build, it keeps the build forever (as if 
> the user pressed "keep this build forever" button.
> If a build is marked as release build there's a small badge next to the build 
> (like in badge plugin )
> On Job level there's a section (Action) that lists all builds that are marked 
> as release, with hyperlinks to the build itself.
> Optionally (nice to have) there's a button on the Dashboard level that lists 
> all deployments grouped by Jobs.
> Nice to have: Pipeline (workflow) method that marks the build as release 
> build right at build time. 
> Reference plugins, learn materials are also appreciated. I am also up for a 
> pair programming session. I also published my plguin to github here 
>  though it is quite empty now. 
> Pull requests are appreciated if it is easier done than explained though 
> don't get me wrong, it is not like I want someone to the work. 
> I'd really like to gain knowledge so that I can later on contribute to the 
> ecosystem of JenkinsCI plugins.
> 
> Tamas
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/d9ae5142-be88-435c-a006-719e1fa30a37n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/262894B3-F681-4C42-B9AD-C35D60D914ED%40gmail.com.


Re: Prototype.js replacing JSON.stringify

2023-03-11 Thread Ullrich Hafner
I think I also have some problems with this ugly dependency. Seems that other 
JS libraries that rely on JSON stringify (datatables, echarts) break in some 
places as well :-( 

But this JS code is so deeply nested in Jenkins UI code that I have no clue on 
how to fix that...


> Am 02.03.2023 um 23:15 schrieb 'Gavin Mogan' via Jenkins Developers 
> :
> 
> I vaguely remember some javascript code somewhere deleting 
> Object.prototype.toJSON() or something
> 
> A quick search found 
> https://github.com/jenkinsci/jenkins/blob/e41aeaacf434b9ff93c8848f8eddbfcbb27ed462/war/src/main/js/util/jenkins.js#L20-L54
> In theory that makes JSON.stringify work again, but would make the other 
> prototype js fail, so would have to be done temporarily.
> 
> 
> On Thu, Mar 2, 2023 at 1:59 PM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>>> 
>>> Hi!
>>> I was looking at some javascript that was behaving differently on Jenkins 
>>> than it does on other apps. I boiled it down to the simplest reproducible 
>>> test case.
>>> It turned out that serialization was behaving differently when calling 
>>> JSON.stringify.
>>> 
>>> This is the sample code you can run on the Chrome DevTools
>>> 
>>> JSON.stringify({ a: [1, 2, 3] });
>>> 
>>> On Jenkins, this is the behavior
>>> 
>>> '{"a":"[1, 2, 3]"}'
>>> 
>>> On other apps, this is the behavior
>>> 
>>> '{"a":[1, 2, 3]}'
>>> 
>>> When I attempt to debug the code, stepping into `JSON.stringify` on Jenkins 
>>> takes me to prototype.js.
>>> 
>>> I've seen some threads here attempting not to rely on prototype.js for 
>>> functionality, but how far are we from removing it?
>> 
>> Very far. A couple of years ago I even tried to upgrade prototype.js to the 
>> latest version but failed, since some plugins are depending on prototype.js 
>> as well. All UI stuff is tightly coupled to prototype.js, this will be very 
>> hard to remove.
>> 
>>> 
>>> - Rahul
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/708c6498-e0d4-481e-9ad7-e0a8e5af65ffn%40googlegroups.com
>>>  
>>> <https://groups.google.com/d/msgid/jenkinsci-dev/708c6498-e0d4-481e-9ad7-e0a8e5af65ffn%40googlegroups.com?utm_medium=email_source=footer>.
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/76FFAC15-B00C-4528-8AB1-68ED0E6D7055%40gmail.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/76FFAC15-B00C-4528-8AB1-68ED0E6D7055%40gmail.com?utm_medium=email_source=footer>.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duv8NOUT%2BzGfEoww2bf11kdNAkkT8HCwG%3DUoRuCB6J5ktQ%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Duv8NOUT%2BzGfEoww2bf11kdNAkkT8HCwG%3DUoRuCB6J5ktQ%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/A41F2DC5-1DC0-406A-8E37-95A59C196381%40gmail.com.


Re: Download local files from jenkins plugin page

2023-03-05 Thread Ullrich Hafner


> Am 06.03.2023 um 02:37 schrieb Young CJ :
> 
> Here are more details. I have a mac mini for iOS app packaging, and I 
> installed jenkins on this computer so we can access jenkin by localhost:8080. 
> After finishing iOS packaging, it will produce some files in local 
> folder(include IPA file).

What do you mean with „I will produce"? Do you mean a Jenkins build produces 
these artifacts? Then you do not need to write a plugin, your artifacts are 
automatically available in Jenkins UI via 
https://www.jenkins.io/doc/pipeline/steps/core/#archiveartifacts-archive-the-artifacts

When you are producing the artifacts outside of Jenkins then you are using 
Jenkins the wrong way.

> After this, I will provide this jenkins url to other user by some tools like 
> ngrok. They need IPA file that we generated,so I write a plugin to handle 
> this. But I don't know how to provide these files  to users in plugin. (As 
> said above, these files are stored in my mac mini.)

As mentioned above, you do not need to write a plugin for such things. What 
else does your plugin?

> 
> 在2023年3月6日星期一 UTC+8 04:16:54 写道:
>> I think you need to add some more details. What do you mean with local 
>> files? Do you want to have files uploaded from your local computer to the 
>> Jenkins controller? Or the other way round, provide a link to a file that is 
>> stored in a folder of the Jenkins controller? Where are these files stored, 
>> how doing you create these file...
>> 
>> 
>>> Am 03.03.2023 um 10:19 schrieb Young CJ >:
>>> 
>> 
>>> Hi everyone, I'm developing an iOS package plugin, I need to provide IPA 
>>> file to users, So I
>>> want to show a entrance on my plugin page. But I don't know how to access 
>>> local files in jelly. Can someone help me. Thanks a lot
>>> 
>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-de...@googlegroups.com <>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/639aecbc-0755-42e8-a851-7ca37241be39n%40googlegroups.com
>>>  
>>> .
>> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/cf98b8f6-035d-4f3b-b6c1-741b3eb41b22n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/387036F3-BA1B-419F-9F6B-80A2A2335831%40gmail.com.


Re: Download local files from jenkins plugin page

2023-03-05 Thread Ullrich Hafner
I think you need to add some more details. What do you mean with local files? 
Do you want to have files uploaded from your local computer to the Jenkins 
controller? Or the other way round, provide a link to a file that is stored in 
a folder of the Jenkins controller? Where are these files stored, how doing you 
create these file...

> Am 03.03.2023 um 10:19 schrieb Young CJ :
> 
> Hi everyone, I'm developing an iOS package plugin, I need to provide IPA file 
> to users, So I
> want to show a entrance on my plugin page. But I don't know how to access 
> local files in jelly. Can someone help me. Thanks a lot
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/639aecbc-0755-42e8-a851-7ca37241be39n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5040FE8B-7CA6-4FE1-82F2-D05BD5D54996%40gmail.com.


Re: Prototype.js replacing JSON.stringify

2023-03-02 Thread Ullrich Hafner
> 
> Hi!
> I was looking at some javascript that was behaving differently on Jenkins 
> than it does on other apps. I boiled it down to the simplest reproducible 
> test case.
> It turned out that serialization was behaving differently when calling 
> JSON.stringify.
> 
> This is the sample code you can run on the Chrome DevTools
> 
> JSON.stringify({ a: [1, 2, 3] });
> 
> On Jenkins, this is the behavior
> 
> '{"a":"[1, 2, 3]"}'
> 
> On other apps, this is the behavior
> 
> '{"a":[1, 2, 3]}'
> 
> When I attempt to debug the code, stepping into `JSON.stringify` on Jenkins 
> takes me to prototype.js.
> 
> I've seen some threads here attempting not to rely on prototype.js for 
> functionality, but how far are we from removing it?

Very far. A couple of years ago I even tried to upgrade prototype.js to the 
latest version but failed, since some plugins are depending on prototype.js as 
well. All UI stuff is tightly coupled to prototype.js, this will be very hard 
to remove.

> 
> - Rahul
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/708c6498-e0d4-481e-9ad7-e0a8e5af65ffn%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/76FFAC15-B00C-4528-8AB1-68ED0E6D7055%40gmail.com.


Re: Press Contacts

2023-02-10 Thread Ullrich Hafner
+1 for me as well

> Am 10.02.2023 um 13:25 schrieb Baptiste Mathus :
> 
> +1 to remove/rework this and just point to the board's email. 
> 
> 1) I did receive many such sollications in the past, many legitimate. But in 
> 99% of the cases, I have mostly just forwarded requests to the board when 
> being contacted through this.
> 2)  I do not think I have received anything in the last 1+ year at least 
> anyway
> 
> Cheers
>  
> 
> Le ven. 10 févr. 2023 à 13:10, Alexander Brandes  > a écrit :
>> +1 from me, a rework is overdue.
>> 
>> On Friday, 10 February 2023 at 12:55:11 UTC+1 Oleg Nenashev wrote:
>>> +1 too. We can just drop everything and offer a Jenkins Board and Security 
>>> team contacts instead
>>> 
>>> 
>>> On Friday, February 10, 2023 at 1:09:32 AM UTC+1 Alyssa wrote:
 +1 for dropping the contacts. IIRC as long as i've been with the project 
 there hasn't really been press request(s) either. 
 Alternatively there's CDF, perhaps they can be that fitler (contact) for 
 Jenkins.  Just a thought.
 
 alyssa
 
 On Thu, Feb 9, 2023 at 12:30 PM 'Gavin Mogan' via Jenkins Developers 
 > wrote:
> Re 
> https://github.com/jenkins-infra/jenkins.io/blob/master/content/press.adoc#press-contacts
> 
> I'm planning on a putting in a PR to remove myself from the contacts. In 
> the almost two years of me being on the list, i've never had a legitimate 
> email, its all spam about having sponsored posts.
> 
> I also think most (maybe 50%) of the people listed are no longer actively 
> engaged with the project, so probably not the best to a filter for press.
> 
> My vote is to just drop the contacts section and use the forum or 
> something. Private communication isn't really great for the 
> projectanyways.
> 
> Gavin
> 
 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-de...@googlegroups.com <>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DuuKa%2Boqh-O-xinqv1K2T%2BietBgtoNe%2B75Au2_mmvgZSkQ%40mail.gmail.com
>  
> .
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/f5f38ef9-5d19-4dcf-b81f-bc6233c8a639n%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5WMfyStjeidNstq0rudf-ddJRSbfR1a914BhB_9-T1nQ%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2966456C-41A6-4A5A-9275-AAEDD39B3FD6%40gmail.com.


Re: Adoption request JQuery Detached

2023-02-02 Thread Ullrich Hafner
Indeed, for jquery 3.x we already have a plugin: 
https://plugins.jenkins.io/jquery3-api/ 

> Am 02.02.2023 um 22:06 schrieb Alexander Brandes :
> 
> Hello,
> 
> As far as I am aware, the jquery-detached plugin is not up for adoption. In 
> fact, it's deprecated according to its plugin page. 
>  
> 
> Best regards,
> Alex
> 
> On Thursday, 2 February 2023 at 21:38:23 UTC+1 Samuel wrote:
>> Hi everyone,
>> 
>> I updated the jquery detached plugin to v3. I would be more than happy to 
>> adopt that plugin. You can find the updated plugin on 
>> [GitHub](https://github.com/SamTV12345/jquery-detached) and 
>> [NPM](https://www.npmjs.com/package/jquery-detached2).
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/17fbe2ff-6c9a-4b52-b6cc-736b28552d35n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7E55E586-4940-43C5-B2B8-6A63EBE3BB10%40gmail.com.


Re: Artifact caching proxy activation

2023-02-02 Thread Ullrich Hafner
Sorry, false alarm :-) Now everything is back to normal...

> Am 02.02.2023 um 16:36 schrieb Ullrich Hafner :
> 
> Does this affect local builds as well? 
> 
> I now get failures while trying to fetch incremental releases:
> 
> [ERROR] Failed to execute goal on project warnings-ng: Could not resolve 
> dependencies for project io.jenkins.plugins:warnings-ng:hpi:10.0.0-SNAPSHOT: 
> The following artifacts could not be resolved: 
> io.jenkins.plugins:analysis-model-api:jar:11.0.0-rc645.3b_6973434c0b, 
> io.jenkins.plugins:plugin-util-api:jar:3.0.0-rc676.39c5d554b_82f, 
> io.jenkins.plugins:prism-api:jar:1.29.0-3-rc205.6b_6980cca_b_76, 
> io.jenkins.plugins:forensics-api:jar:2.0.0-rc1380.c93c627cd828, 
> io.jenkins.plugins:forensics-api:jar:tests:2.0.0-rc1380.c93c627cd828, 
> edu.hm.hafner:analysis-model:jar:tests:11.0.0-rc4947.d37dc2873c20, 
> io.jenkins.plugins:plugin-util-api:jar:tests:3.0.0-rc676.39c5d554b_82f: Could 
> not find artifact 
> io.jenkins.plugins:analysis-model-api:jar:11.0.0-rc645.3b_6973434c0b in 
> repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]
> [
> 
>> Am 01.02.2023 um 16:18 schrieb 'Herve Le Meur' via Jenkins Developers 
>> :
>> 
>> Hello dear contributors,
>> As explained in this "Artifact caching proxy activation" helpdesk issue 
>> <https://github.com/jenkins-infra/helpdesk/issues/3369>, we're planning to 
>> activate the artifact caching proxy for all plugins.
>> 
>> The artifact caching proxy 
>> <https://github.com/jenkins-infra/helpdesk/issues/2752> is a mechanism we've 
>> put in place using nginx proxy in front of repo.jenkins-ci.org 
>> <http://repo.jenkins-ci.org/> (our JFrog sponsored Artifactory instance) and 
>> Maven Central to cache artifacts download requests.
>> 
>> The main goals are to decrease the consumed bandwidth (many terabytes per 
>> month) and to increase Jenkins infrastructure reliability and resilience.
>> 
>> I'm writing this mail to check if it's OK for everyone, and if there is no 
>> major objection after a delay of 24 hours, we'll merge this PR 
>> <https://github.com/jenkins-infra/pipeline-library/pull/577> around 14:00 
>> UTC on Thursday February 2 to switch this feature as opt-out for all plugins 
>> using the buildPlugin function 
>> <https://github.com/jenkins-infra/pipeline-library/blob/master/vars/buildPlugin.groovy?rgh-link-date=2023-02-01T09%3A53%3A32Z>
>>  from the shared pipeline library.
>> 
>> As the caches of these ACPs are warming up, the first plugin builds might 
>> take a little bit more time, but the following ones should be quicker.
>> 
>> In case you'll need for whatever reason to disable this mechanism 
>> (discouraged), you will have two possibilities:
>> 
>> on your pull request, add a skip-artifact-caching-proxy label
>> in your Jenkinsfile, add useArtifactCachingProxy: false to the recommanded 
>> buildPlugin configuration 
>> <https://github.com/jenkinsci/archetypes/blob/master/common-files/Jenkinsfile?rgh-link-date=2023-02-01T09%3A53%3A32Z>,
>>  ex:
>> buildPlugin(
>>   useContainerAgent: true,
>>   useArtifactCachingProxy: false, // Add this line to opt-out of this 
>> functionality and bypass the artifact caching proxy
>>   configurations: [
>> [platform: 'linux', jdk: 17],
>> [platform: 'windows', jdk: 11],
>> ])
>> If you've got any questions or issues, please add them to the helpdesk issue.
>> 
>> 
>> Kind regards,
>> 
>> Hervé for the Jenkins Infrastructure team
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAL-Lwjw1_BV2y4VuoN%2Bon5G5dVABzkUi20h%3Do2%2BOE59oWYPcnA%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/CAL-Lwjw1_BV2y4VuoN%2Bon5G5dVABzkUi20h%3Do2%2BOE59oWYPcnA%40mail.gmail.com?utm_medium=email_source=footer>.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ADD45AF0-8924-41C7-A516-993ECC8712EF%40gmail.com.


Re: Artifact caching proxy activation

2023-02-02 Thread Ullrich Hafner
Does this affect local builds as well? 

I now get failures while trying to fetch incremental releases:

[ERROR] Failed to execute goal on project warnings-ng: Could not resolve 
dependencies for project io.jenkins.plugins:warnings-ng:hpi:10.0.0-SNAPSHOT: 
The following artifacts could not be resolved: 
io.jenkins.plugins:analysis-model-api:jar:11.0.0-rc645.3b_6973434c0b, 
io.jenkins.plugins:plugin-util-api:jar:3.0.0-rc676.39c5d554b_82f, 
io.jenkins.plugins:prism-api:jar:1.29.0-3-rc205.6b_6980cca_b_76, 
io.jenkins.plugins:forensics-api:jar:2.0.0-rc1380.c93c627cd828, 
io.jenkins.plugins:forensics-api:jar:tests:2.0.0-rc1380.c93c627cd828, 
edu.hm.hafner:analysis-model:jar:tests:11.0.0-rc4947.d37dc2873c20, 
io.jenkins.plugins:plugin-util-api:jar:tests:3.0.0-rc676.39c5d554b_82f: Could 
not find artifact 
io.jenkins.plugins:analysis-model-api:jar:11.0.0-rc645.3b_6973434c0b in 
repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]
[

> Am 01.02.2023 um 16:18 schrieb 'Herve Le Meur' via Jenkins Developers 
> :
> 
> Hello dear contributors,
> As explained in this "Artifact caching proxy activation" helpdesk issue 
> , we're planning to 
> activate the artifact caching proxy for all plugins.
> 
> The artifact caching proxy 
>  is a mechanism we've 
> put in place using nginx proxy in front of repo.jenkins-ci.org 
>  (our JFrog sponsored Artifactory instance) and 
> Maven Central to cache artifacts download requests.
> 
> The main goals are to decrease the consumed bandwidth (many terabytes per 
> month) and to increase Jenkins infrastructure reliability and resilience.
> 
> I'm writing this mail to check if it's OK for everyone, and if there is no 
> major objection after a delay of 24 hours, we'll merge this PR 
>  around 14:00 UTC 
> on Thursday February 2 to switch this feature as opt-out for all plugins 
> using the buildPlugin function 
> 
>  from the shared pipeline library.
> 
> As the caches of these ACPs are warming up, the first plugin builds might 
> take a little bit more time, but the following ones should be quicker.
> 
> In case you'll need for whatever reason to disable this mechanism 
> (discouraged), you will have two possibilities:
> 
> on your pull request, add a skip-artifact-caching-proxy label
> in your Jenkinsfile, add useArtifactCachingProxy: false to the recommanded 
> buildPlugin configuration 
> ,
>  ex:
> buildPlugin(
>   useContainerAgent: true,
>   useArtifactCachingProxy: false, // Add this line to opt-out of this 
> functionality and bypass the artifact caching proxy
>   configurations: [
> [platform: 'linux', jdk: 17],
> [platform: 'windows', jdk: 11],
> ])
> If you've got any questions or issues, please add them to the helpdesk issue.
> 
> 
> Kind regards,
> 
> Hervé for the Jenkins Infrastructure team
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAL-Lwjw1_BV2y4VuoN%2Bon5G5dVABzkUi20h%3Do2%2BOE59oWYPcnA%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/A8180F8D-B4A5-464D-9EF3-57AA8784F7EC%40gmail.com.


Re: Migration to Java11 and modules

2023-01-03 Thread Ullrich Hafner


> Am 03.01.2023 um 15:42 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Tue, Jan 3, 2023 at 8:08 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> Do we already have some guidelines on how to migrate a plugin to Java 11?
> 
> Yes; normally there is very little to do.
>  
>> Do we need to create module-info.java files for plugins?
> 
> No.
>  
>> How do we access libraries that use modules?
> 
> Jenkins does not use the Java module system, so there should be no change 
> from Java 8 usage modes. If there is some incompatibility in Java 11 in this 
> regard, then you may be the first to encounter it so you will need to debug 
> accordingly.

Ok, thanks for the info. Actually a bug in my own build chain. Somehow a 
module-info.class from one of my dependencies went into my classes folder and 
that caused the confusion for the Java compiler. Now everything works fine!

> Is this failure during the build itself, or in Surefire test runs? Without 
> any details it is hard to even guess what is wrong.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr15XHaVQ%3Dz0wVe_n%2B-bOZcA3rZ9d7muGiy3mZ%3D7JZTq_g%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr15XHaVQ%3Dz0wVe_n%2B-bOZcA3rZ9d7muGiy3mZ%3D7JZTq_g%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CBE28160-442A-46EE-A473-1531D182AB37%40gmail.com.


Migration to Java11 and modules

2023-01-03 Thread Ullrich Hafner
I’m currently starting the Java 11 migration of my plugins and my local builds 
are failing due to several Java modules failures (package x.y.z is declared in 
the unnamed module, but a.b.c does not use it,  error: module not found: 
x.y.z). 

Do we already have some guidelines on how to migrate a plugin to Java 11? Do we 
need to create module-info.java files for plugins? How do we access libraries 
that use modules? Or has someone already finished the the migration so I can 
have a look at the necessary steps?



-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/B889703A-0666-413D-A413-CEE697B9E36B%40gmail.com.


Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Ullrich Hafner


> Am 14.12.2022 um 21:51 schrieb Basil Crow :
> 
> On Wed, Dec 14, 2022 at 12:37 PM Ullrich Hafner
>  wrote:
>> 
>> I would suggest to always update the major version of our plugin-pom if we 
>> make breaking changes. This is the second time that we deliver incompatible 
>> changes with the same major version.
> 
> Perhaps; we do not officially use semantic versioning or any other
> scheme where breaking changes are tied to the version number, nor did
> we bump the major version number of Jenkins core itself when making
> the breaking change to require Java 11 or newer there (a decision made
> after discussion on this mailing list). I could see both sides to this
> one: while a new major version number would have been a more clear
> signal to consumers that adaptations are needed, it also might have
> implied a major feature release (which was not the case).

> The last
> major version number bump in the plugin parent POM (4.0) was done by
> James Nord, and that _was_ a major feature release.
> 

I don’t think that you need to deliver new features when you increment the 
major version in an API (actually we delivered the new feature Java 11 with 
tons of changes) - at least semantic versioning does not require that. But they 
clearly define the following rule which makes sense for other version schemes 
as well: 1. increment the MAJOR version when you make incompatible API changes.


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2F84465D-F9CB-4452-A87E-D96BBD13EA3B%40gmail.com.


Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Ullrich Hafner
Thanks for the checklist!

> Easily overlooked, the bump of plugin from 4.51 to 4.52 
>  has a 
> breaking change. The plugin build toolchain now requires at least Java 11 and 
> at least Jenkins 2.361.
> 
I would suggest to always update the major version of our plugin-pom if we make 
breaking changes. This is the second time that we deliver incompatible changes 
with the same major version. 


> Am 14.12.2022 um 18:31 schrieb Jean-Marc Meessen :
> 
> (cross post 
> 
>  from community.jenkins.io )
> 
> If you are like me,
> 
> wondering why your dependabot PR builds are suddenly failing,
> unsure of the full implications of the latest plugin parent pom upgrade,
> and fear to waste time solving a problem that others have already solved,
> don’t trust your memory when having several plugins to maintain.
> 
> 
> Here are my notes on how to move ahead.
> 
> 
> 
> Background:
> Easily overlooked, the bump of plugin from 4.51 to 4.52 
>  has a 
> breaking change. The plugin build toolchain now requires at least Java 11 and 
> at least Jenkins 2.361.
> 
> 
> 
> Solution:
> 
> Make sure to use the correct Jenkins baseline
> Disable builds with Java 8
> 
> 
> Checklist:
> 
> In the plugin’s pom.xml,
> 
> Update the parent.pom (in the  section) to 4.52
> Change the Jenkins base version ( property) to 2.361.4
> Make sure that 2.361.x BOM is used (bom-2.361.x and 
> 1723.vcb_9fee52c9fc)
> Make sure that the pom.xml doesn’t force a Java 1.8 compilation
> Make sure that Jenkinsfile specifies builds with the supported JDKs. (Relying 
> on unknown defaults can bite you.) Your Jenkinsfile should look like this:
> 
> buildPlugin(
>useContainerAgent: true,
>configurations: [
>   [platform: 'linux', jdk: 17],
>   [platform: 'windows', jdk: 11],
>]
> )
> 
> 
> Note:
> If you don’t find the above mentioned elements in the pom.xml of the plugin 
> you maintain, it is probably up for some tidying and “modernization”. See the 
> Improve a Plugin Tutorial 
>  for hints.
> 
> If you have doubts or this checklist doesn’t work for you, don’t hesitate to 
> discuss the matter on the developer mailing list.
> 
> /- Jmm
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CABLvyXxOFqBAA1FGJSPQqE-LQmwViTvdtVK%3DZtpw9JqwpqCPvA%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/F36E39D7-5C02-467A-A669-CF8A6FADD16B%40gmail.com.


Re: Zoom account access for Alex Brandes of governance board

2022-12-05 Thread Ullrich Hafner
+1

> Am 05.12.2022 um 19:23 schrieb 'Bruno Verachten' via Jenkins Developers 
> :
> 
> +1 from me too.
> 
> On Mon, Dec 5, 2022 at 7:03 PM 'Alyssa Tong' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> 
> wrote:
>> +1 from me
>> 
>> On Mon, Dec 5, 2022 at 9:24 AM Mark Waite > > wrote:
>>> Alex Brandes is a newly elected member of the Jenkins governance board.  
>>> He's agreed to host the Jenkins UX SIG meeting on Dev 7, 2022 when I am 
>>> away.
>>> 
>>> I'd like to share the Zoom account password with him so that he can start 
>>> the meeting and record it.
>>> 
>>> Mark Waite
>>> 
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>>> .
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/c5ef8de9-83d7-4b6f-80e3-ff37f9b353cbn%40googlegroups.com
>>>  
>>> .
>> 
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAMBsfbuZ0D4-xPbtSAWHwEEX7FwPX-G2NBeyF9%2BCY4BenajJ1A%40mail.gmail.com
>>  
>> .
> 
> 
> -- 
> Bruno Verachten
> Sr Developer Relations
> CloudBees, Inc.
> 
> P: +33.632.934.165 | GMT+1
> E: bverach...@cloudbees.com 
> Twitter: https://twitter.com/Poddingue
> LinkedIn: https://www.linkedin.com/in/poddingue/
> Pronouns: he/his
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFbR2rovTQR_S%2B9n5qJaeORZ3phGAMW26K32VGUD1eAnjh51aQ%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/B11C253B-34C9-4648-B19B-D6732C71BD60%40gmail.com.


Re: Next baseline shift

2022-11-29 Thread Ullrich Hafner
+1 from me as well (after release of 2.375.1)

> Am 28.11.2022 um 19:50 schrieb Basil Crow :
> 
> Historically we have supported old baselines for a long time in the
> build toolchain. The current build toolchain supports baselines as far
> back as 2.249. This provides a high degree of flexibility for plugin
> maintainers and ultimately end users.
> 
> Sustaining this level of compatibility across complex transitions like
> the move to Java 11 and Jetty 10 comes at significant build toolchain
> complexity, either in the form of conditional logic in a single-branch
> build toolchain scheme (the current status quo) or in the form of
> multiple branches (a hypothetical scenario). For example, the test
> harness needs to support Java 8 in order to support 2.249, the need to
> support Java 8 means the test harness cannot move to Jetty 10 (which
> requires Java 11), and the test harness' continued use of Jetty 9
> requires core to retain support both Jetty 9 and 10 (even though only
> Jetty 10 is used in production use cases). Similarly, conditional
> logic is required to set the Maven compiler release version to 11 for
> plugins when newer baselines are in use, and even then that
> conditional logic tends to trip up IDEs.
> 
> For these reasons, it is desirable to require a baseline of 2.361 or
> later (and therefore Java 11) for plugins in the build toolchain
> sooner rather than later. The advantage is that this allows us to
> simplify and clean up conditional logic that is increasingly becoming
> less relevant and a maintenance burden. The disadvantage of requiring
> a baseline of 2.361 or later for plugins in late 2022 or early 2023
> (as opposed to our usual timeline of e.g. late 2023 or early 2024) is
> that it is more of an imposition on plugin maintainers and users of
> older LTS lines. I believe that the advantages outweigh the
> disadvantages and that we should do this sooner rather than later,
> ideally in late 2022.
> 
> If the consensus is that we are OK with requiring a baseline of 2.361
> or later for plugins in late 2022 (i.e., after the release of 2.375.x
> LTS) or early 2023 (i.e., after the release of the next major LTS line
> after 2.375), then I explicitly commit to implement the change in the
> plugin parent POM (e.g., with regard to Java 8), test harness (e.g.,
> with regard to Unicode properties files), HPI plugin (e.g., with
> regard to the Maven compiler release version), core (e.g., with regard
> to Jetty 9), annotation indexer, symbol annotation library, version
> number library, and access modifier library, noting in the release
> notes for all eight (8) components that this is a breaking change for
> plugin maintainers and that plugin maintainers must use a baseline of
> 2.361 or later when upgrading to the latest build toolchain.
> 
> If you are in favor of requiring a baseline of 2.361 or later for
> plugins in late 2022 or early 2023 and with me implementing this
> transition in the manner described, please reply with your timeline
> preference (either late 2022 or early 2023). If you are in favor of
> maintaining a stable branch of the abovementioned eight (8) components
> for older LTS lines, please reply stating whether you are willing to
> do the implementation and release work (noting that I explicitly
> decline to do this implementation and release work). If you are in
> favor of any other proposal, please reply stating the alternative
> proposal and whether you are willing to do the implementation work.
> 
> Thanks,
> Basil
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjo4AV%3DuY-f1R%3DjTFTfwe-m8TdxONt4Ly7yhU3JpPTJj6w%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/20659570-9976-440F-8B34-C37318AA43D8%40gmail.com.


Re: Allow up to 2 elected board members from a single company

2022-11-28 Thread Ullrich Hafner
I am currently -1 for this change, but I do not yet have access to the full 
governance board discussion yet. 

Basically, the reasoning for this change is not clear for me. Looking back in 
the history of the governance board, we are 4 active members making all the 
decisions. As far as I remember, Kohsuke did not participate in a decision in 
the last couple of years. So in practice we have 4 votes in our meetings, and 
if 2 of these votes are from one company this company can block any decision. 
They have not majority, but we have a stalemate which is a potential risk. So I 
would prefer to not change the current situation. It would even make sense to 
update the current rule so that no company can get 50% of the 4 elected seats. 
Then we do not need discuss if Kohsuke is affiliated with Cloudbees or not.  

If the reasoning for the change is, that we do not have enough people that want 
to help with the governance of the Jenkins project (no election for all 
positions of the officers and board members required) we should also rethink if 
the number of board members is too large? The number of active community 
members in Jenkins is getting smaller year by year (the number of new Jenkins 
features as well), so maybe it would make sense to reduce the number of seats 
as well? The number of board members should reflect the number of active 
community members as well. 

> The board needs more active participants to assist with the work of the 
> board. Allowing 1 more board member from CloudBees or any other company that 
> already has a member on the board will strengthen the board and its work to 
> serve the Jenkins project.

Here it would help to elaborate, what these work items are? From my 
understanding and from our statement, the board is 

> The decision-making ability of the board is more symbolic and honorific


So if there is too much work we should rethink if this work could be delegated 
to other roles in the Jenkins project.  

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/9A147D91-4B25-4F75-A9E5-A8C67B4F6508%40gmail.com.


Re: Permission Request for the community Google Document "Jenkins Social Media Covers / Artwork"

2022-11-23 Thread Ullrich Hafner
Are you asking for approval or for someone adapting the permissions? 

I am +1 for your request but have no rights to change the permissions.

> Am 23.11.2022 um 12:40 schrieb Alexander Brandes :
> 
> +1 from me :)
> 
> On Wednesday, 23 November 2022 at 12:08:51 UTC+1 damien@gmail.com wrote:
>> Hello there,
>> 
>> Both Bruno Verachten (goun...@gmail.com <>) and I (damien@gmail.com <>) 
>> would like to get write access to the Community Google Document named 
>> "Jenkins Social Media Covers / Artwork" 
>> (https://docs.google.com/presentation/d/1Q1PgNnRTgzBpVRXPqQo3PudzCa2eoc6_1_NRjFRMLrU/edit#slide=id.g876094df05_0_11
>>  ) in order to be able to update and generate social media covers when we 
>> upload SIG meeting videos to Youtube (at least).
>> 
>> Cheers,
>> 
>> Damien Duportal
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e89b7a17-d73a-419d-9ee4-a625ad04b751n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5101D818-FD8B-44A8-ABEB-EFC172B2FE06%40gmail.com.


Re: Removing security vulnerability warning from CloudFormation plugin

2022-11-19 Thread Ullrich Hafner
Please follow our guidelines when reporting vulnerabilities, please see 
https://www.jenkins.io/security/ for details!

> Am 19.11.2022 um 20:50 schrieb Damir Suleymanov :
> 
> Hi,
> I recently addressed vulnerability CVE-2019-1003061 in the CloudFormation 
> plugin (https://plugins.jenkins.io/jenkins-cloudformation-plugin/)
> 
> Here's the PR that fixes it: 
> https://github.com/jenkinsci/jenkins-cloudformation-plugin/pull/58
> 
> Here's a PR to update the warning: 
> https://github.com/jenkins-infra/update-center2/pull/657
> 
> I tested this release on my production instance of Jenkins and I can see that 
> the secret is now encrypted.
> 
> Thanks,
> Damir.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/923b08db-b23c-4c22-a3d4-8705843db612n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4D2F2BC0-0358-453C-A366-1A6D084D4311%40gmail.com.


Re: BOM compiles plugins with target 11

2022-11-10 Thread Ullrich Hafner

> Am 10.11.2022 um 16:00 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Thu, Nov 10, 2022 at 2:03 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
>> This causes a failure of:
>> 
>> [ERROR] Failed to execute goal 
>> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) 
>> on project checks-api: Execution default-cli of goal 
>> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test failed: 
>> org.junit.platform.commons.JUnitException: TestEngine with ID 'archunit' 
>> failed to discover tests: ExceptionInInitializerError: class 
>> com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule cannot be cast to 
>> class com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction 
>> (com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule and 
>> com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction are in 
>> unnamed module of loader 
>> org.apache.maven.surefire.booter.IsolatedClassLoader @5cf39df6) -> [Help 1]
> 
> I just tried `mvn -f checks-api-plugin clean verify` locally using JDK 11 and 
> it passed.
> 

The plugin compiles with JDK11 and JDK17 fine on my machine as well. 

It is just my BOM PR that fails (also locally when I start it with 
PLUGINS=checks-api bash local-test.sh)

It seems to set the target JDK to 11 which is not what I want, the target 
should still be JDK8 (at least for now). 

>> Is there a toggle to define in the BOM that the plugin build is not ready 
>> for JDK11?
> 
> No, I think all plugins are expected to be buildable on JDK 11 even if their 
> runtime baseline remains Java 8.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1mpAeos5ZC2%3D%3DiFpCXta6z-Dc9-PT7pY%3D50cb-wA8fAQ%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1mpAeos5ZC2%3D%3DiFpCXta6z-Dc9-PT7pY%3D50cb-wA8fAQ%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CFC23496-5A16-4DC5-82ED-EF80B2166CCA%40gmail.com.


BOM compiles plugins with target 11

2022-11-09 Thread Ullrich Hafner
I’m struggling with the BOM builds of some plugins:
https://github.com/jenkinsci/bom/pull/1513
Bump versions of JS libs by uhafner · Pull Request #1513 · jenkinsci/bom
github.com


It seems that the BOM compiles and builds plugins with target JDK 11 even 
though the plugin is not yet ready for JDK target (due to some missing `opens` 
directives during testing). (The baseline still is for JDK8) 

During the PCT I get:

[INFO] --- maven-hpi-plugin:3.33:initialize (default-initialize) @ checks-api 
---
[INFO] Setting maven.compiler.release to 11
[INFO] Setting maven.compiler.testRelease to 11
[INFO]


Which I do not have when running the plugin build locally.

This causes a failure of:

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-cli) on 
project checks-api: Execution default-cli of goal 
org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test failed: 
org.junit.platform.commons.JUnitException: TestEngine with ID 'archunit' failed 
to discover tests: ExceptionInInitializerError: class 
com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule cannot be cast to 
class com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction 
(com.tngtech.archunit.lang.ArchRule$Factory$SimpleArchRule and 
com.tngtech.archunit.lang.syntax.elements.ClassesShouldConjunction are in 
unnamed module of loader org.apache.maven.surefire.booter.IsolatedClassLoader 
@5cf39df6) -> [Help 1]


Is there a toggle to define in the BOM that the plugin build is not ready for 
JDK11? 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6420B71F-F7C0-41C3-BF5A-262DDE68D20B%40gmail.com.


Re: Request for access to YouTube account

2022-10-26 Thread Ullrich Hafner
+1

> Am 26.10.2022 um 14:42 schrieb timja...@gmail.com :
> 
> +1
> 
> On Wednesday, 26 October 2022 at 13:18:13 UTC+1 goun...@gmail.com wrote:
> Hi group,
> 
> I sometimes run the Platform SIG meeting (like 
> https://www.youtube.com/watch?v=R2322YxIciQ 
> ) and would like to be able to 
> post the resulting video to YouTube when Mark is on PTO for example.
> Therefore I'm asking the authorization to be granted access to the Youtube 
> account/channel (to upload the recording to the channel).
> 
> Best wishes,
> 
> Bruno Verachten
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/77f08589-693b-46cd-96e4-cb665587b9a9n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/A04049AF-06CA-43CC-BE1D-DF8D0B1F2D76%40gmail.com.


XStream Serialization: SortedSet vs. NavigableSet vs. TreeSet

2022-10-17 Thread Ullrich Hafner
In one of my serialized instances I am using a TreeSet to store some 
properties. 

When I declare the Java field as SortedSet (interface) or TreeSet (class), the 
Jenkins XStream correctly serializes the model. However, when I declare my 
field as NavigableSet (interface), then the serialization resolves the field to 
null. 

Shouldn’t XStream always pick the correct dynamic type (and not the static 
type) when serializing things? Or did we specify a specific converter that uses 
a static type?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C254A748-02A8-4204-A667-970F2CC38044%40gmail.com.


Re: ATH broswer supprt

2022-10-14 Thread Ullrich Hafner
I don’t think that it makes much sense to use HTMLUnit with ATH. I’m fine with 
deleting the support.

> Am 14.10.2022 um 16:43 schrieb 'jn...@cloudbees.com' via Jenkins Developers 
> :
> 
> Hi all,
> 
> Does anyone use the HTMLUnit browser in the jenkins acceptance-test-harness 
> suite?
> 
> I am doing some cleaning and I know that chrome and firefox are used, but 
> looking at the others also.
> 
> I think it is safe to nuke InternetExplorer support from orbit, and I would 
> be amazed if HTMLUnit actually worked correctly in the ATH - but surprises do 
> happen.
> 
> /James
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/ff761284-6811-4bb4-8902-cf7e14dfd4f0n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/05D234E9-F4F3-486F-96DB-B6C9A412685E%40gmail.com.


Re: Found the changeset View

2022-10-06 Thread Ullrich Hafner
Isn’t the component that contains the view shown in the issue? Which issue are 
you referring to? 

> Am 06.10.2022 um 17:19 schrieb Elton Alves :
> 
> I'm starting to contribute with jenkins core and I got a noobie issue. 
> 
> I need to change the icon placed in changeset view but i can't found the 
> view, there's an image showing the icon that i mentioned before. 
> 
> changeset-view-image 
> 
> 
> anyone could guide me in it?
> 
> cheers!
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/a7a2f284-364f-46f4-9a08-979989116d4fn%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/78487A00-9287-495C-9D66-0C7CFF1C0226%40gmail.com.


Re: argLine when running integration tests with Java 17

2022-09-19 Thread Ullrich Hafner
I do not mean the bug that Basil explained in 
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.40 
<https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.40>
This has been fixed already in IntelliJ. 

IntelliJ now correctly runs the integration tests with an argLine like:
-Djava.awt.headless=true -Xmx1024m -Djenkins.test.timeout=1000 
--add-opens java.base/sun.reflect.annotation=ALL-UNNAMED --add-opens 
java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED 
--add-opens java.base/java.util=ALL-UNNAMED --add-opens 
java.base/java.util.concurrent=ALL-UNNAMED
The problem is, that the argLine seems to be used for `Run With` only but not 
for `Debug With`.


> Am 19.09.2022 um 16:32 schrieb Alex Earl :
> 
> Hi Ullrich,
> 
> There is a known bug in IntelliJ, check out this post on Stackoverflow for 
> the workaround.
> 
> https://stackoverflow.com/questions/24115142/intellij-error-when-running-unit-test-could-not-find-or-load-main-class-suref
>  
> <https://stackoverflow.com/questions/24115142/intellij-error-when-running-unit-test-could-not-find-or-load-main-class-suref>
> 
> Regards,
> 
> Alex
> 
> On Mon, Sep 19, 2022 at 2:54 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
> I recently switched my development to Java 17 and most things work flawlessly 
> now.
> 
> One thing that I can’t get to work is debugging of integration tests in 
> IntelliJ. It seems that the argLine command (that opens Java modules) is not 
> sent to the debugging process. 
> However, the same tests run correctly when I am simply running the tests in 
> IntelliJ (without debugger). Is there an additional option one can set in 
> IntelliJ for the debugger? Or is this a bug in IntelliJ (I did not find 
> something existing in their issue tracker)?  I am using IntelliJ 2022.2.2 RC. 
> 
> (I checked the option to pass the Arline to the run tests process)
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev%2bunsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/F4A29762-4EC8-471A-A8EA-626A677AB5C3%40gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/F4A29762-4EC8-471A-A8EA-626A677AB5C3%40gmail.com>.
> 
> 
> -- 
> Website: http://earl-of-code.com <http://earl-of-code.com/>
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVesoLr%2BmteK1J4vq9GCL7TGx3yC57tr5JkEWi6qB1YAhw%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVesoLr%2BmteK1J4vq9GCL7TGx3yC57tr5JkEWi6qB1YAhw%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6B1CCF4B-C11D-40F0-8AAB-E4A267573775%40gmail.com.


argLine when running integration tests with Java 17

2022-09-19 Thread Ullrich Hafner
I recently switched my development to Java 17 and most things work flawlessly 
now.

One thing that I can’t get to work is debugging of integration tests in 
IntelliJ. It seems that the argLine command (that opens Java modules) is not 
sent to the debugging process. 
However, the same tests run correctly when I am simply running the tests in 
IntelliJ (without debugger). Is there an additional option one can set in 
IntelliJ for the debugger? Or is this a bug in IntelliJ (I did not find 
something existing in their issue tracker)?  I am using IntelliJ 2022.2.2 RC. 

(I checked the option to pass the Arline to the run tests process)


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/F4A29762-4EC8-471A-A8EA-626A677AB5C3%40gmail.com.


Re: maven-jellydoc-plugin and maven-stapler-plugin

2022-07-28 Thread Ullrich Hafner
+1

> Am 29.07.2022 um 00:49 schrieb Basil Crow :
> 
> I would like to request a transfer of
> https://github.com/kohsuke/maven-jellydoc-plugin from the kohsuke
> GitHub organization to the jenkinsci GitHub organization and
> permissions for both that repository and
> https://github.com/jenkinsci/maven-stapler-plugin in order to release
> new versions that are compatible with current Maven APIs. If and when
> a consensus is reached that we would like to proceed with this plan, I
> will reach out to Kohsuke to begin the transfer.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrRGSbTdSqZuD2VtkJPyELSqYostw4kZQz5tY9_pp9YZg%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/109CA0F9-DD72-4CBA-ADDC-6BEAC0D030A1%40gmail.com.


Re: GSoC Project - Plugin Health Score Survey for Maintainers

2022-07-12 Thread Ullrich Hafner
Maybe it would help to post in https://community.jenkins.io as well?

It would be also helpful to ask the users what they think, so the users mailing 
list may increase the number of return answers?

> Am 12.07.2022 um 17:24 schrieb Adrien Lecharpentier 
> :
> 
> Hello everyone, 
> 
> just a reminder that the feedback that you can give us is really important 
> for us. The idea is, when we will be in the "grading" phase of the project, 
> to be fair to the community. 
> By that I mean we don't want to say "Rule A is 90% of the grade" when in fact 
> the community disagree with that. 
> 
> Here is the link to the survey: https://forms.gle/T6LLqQGYgKke2b8e9 
> 
> 
> For the moment, we have 11 responses. Thank you for those who responded. 
> Please be sure that it's really quick and your time is really important to us.
> 
> Regards,
> -- Adrien
> 
> Le jeu. 30 juin 2022 à 14:38, Adrien Lecharpentier 
> mailto:adrien.lecharpent...@gmail.com>> a 
> écrit :
> Hello Wadeck,
> 
> let me answer here for Dheeraj (as mentor of the GSoC project).
> 
> At the moment, we don't have any probes in actions and we don't have a lot of 
> data. I know that we have for example, 52 plugins out of the 1872 currently 
> in the update-center that don't have any SCM link. Out of the others, some 
> don't have a valid SCM link as well. We still haven't implemented anything 
> that could tell us which is the parent pom version used by each plugin, but 
> it is in the plan.
> 
> The plan here, is to get a sense of what make sense for the community, but 
> the weight of each rule will have to evolve with time. For example, if we say 
> "having a Jenkinsfile" is very important, but in 6months we have all plugins 
> with one, then we can lower the rule (new plugins don't come often) and just 
> have a warning if / when the Jenkinsfile disappear. 
> Same thing, for new probes, we don't intend to have all the probes in 
> September and be done with it. We want this project to serve the community 
> for the years to come. So, the probes and weight will have to evolve with the 
> community.
> 
> I know I haven't answered your question specifically, but that's the best I 
> can offer you.
> -- Adrien
> 
> Le jeu. 30 juin 2022 à 08:58, 'wfoll...@cloudbees.com 
> ' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> a 
> écrit :
> Hello Dheeraj,
> 
> Are you able to share the data distribution for the individual probes you 
> already have in place? This will greatly help us understanding what should be 
> done with the rules.
> 
> E.g. if all plugins have a code coverage of 50%+, the weight should take that 
> into consideration, in opposition to the situation where only the top 5% of 
> the plugin have more than 5% of coverage.
> From my PoV the project has two goals, showing the current situation and also 
> providing guidance about what to improve on a plugin, to follow the good 
> practices.
> 
> Thanks in advance,
> 
> Wadeck
> 
> On Wednesday, June 29, 2022 at 8:15:08 PM UTC+2 jodhadhe...@gmail.com 
>  wrote:
> Hello Jenkins Contributors!
> 
> My name is Dheeraj Singh Jodha and I'm selected as a Google Summer Of Code 
> 2022 student for the Jenkins project where I'm part of a group of 4 people 
> currently working on the project that is titled Plugin Health Scoring System 
> .
> 
> Briefly, the Plugin Health Score is a composite score of various different 
> probes related to Jenkins Plugins. These different probes will have different 
> weights(value) and focus on different areas(think administrative metrics, 
> code quality, best practices, and security) and we will generate a final 
> score for each plugin within the Jenkins ecosystem.
> 
> As communicated earlier in one of the previous emails, we're now very happy 
> to share with you the Community-wide Survey link!
> 
> Please find the link here: https://forms.gle/T6LLqQGYgKke2b8e9 
> 
> 
> Your 5 mins spent on this survey would help us deliver the best results for 
> our project. Thank you in advance!
> 
> Regards,
> Dheeraj
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/cc2dc61a-03a8-4695-8f6b-4436189f9690n%40googlegroups.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this 

Re: spotbugsXml.xml

2022-06-17 Thread Ullrich Hafner
Do you mean SUPPORTED_FORMATS?
- 
https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md
 

- https://github.com/jenkinsci/analysis-model/blob/master/SUPPORTED-FORMATS.md 


There are two launchers:
- 
https://github.com/uhafner/warnings-ng-plugin-devenv/blob/main/.idea/runConfigurations/Update_supported_analysis_parsers.xml
 

- 
https://github.com/uhafner/warnings-ng-plugin-devenv/blob/main/.idea/runConfigurations/Update_supported_tools.xml
 


I fixed that in your PR.

> Am 16.06.2022 um 20:31 schrieb Simon Matthews :
> 
> I just spotted this file in the analysis-model. There are two instances of it 
> and it lists the parsers. 
> 
> It appears to be automatically generated, but my new parser is not listed in 
> it. What's the process to update it?
> 
> Simon
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1462b73d-637c-4f09-bc35-3170a14d94e5n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/BB6893D9-988F-4888-B462-8C8CBEA8FAC2%40gmail.com.


Re: BOM build errors due to conflict of baseline 2.319.3 and 2.319.1

2022-06-13 Thread Ullrich Hafner
I see, thanks! 

Shouldn’t the BOM also follow our guidelines and support only releases 2.303.3 
and 2.319.3 and newer? There is a 2.289.x folder in there as well.

> Am 13.06.2022 um 17:47 schrieb Tim Jacomb :
> 
> Hi Ulli
> 
> Since you've bumped past a baseline that is still supported in bom you need 
> to pin the previous version of the dependency in the bom that your plugin 
> doesn't support now.
> 
> i.e. add
> 
> echarts-api 5.3.2-1
> to
> https://github.com/jenkinsci/bom/blob/master/bom-2.303.x/pom.xml 
> 
> 
> Thanks
> Tim
> 
> 
> On Mon, 13 Jun 2022 at 11:49, 'jn...@cloudbees.com 
> ' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> 
> wrote:
> > There was quite a long and controversial discussion around that topic in 
> > this mailing list (and the associated PR). 
> 
> Thanks Ulli, for some reason I missed that, which is a shame.
> 
> I can not help you wrt the BOM specifics, perhaps Jesse/Basil or Tim can help.
> 
> /James
> 
> On Monday, June 13, 2022 at 10:38:36 AM UTC+1 ullrich...@gmail.com 
>  wrote:
>> Am 13.06.2022 um 11:11 schrieb 'jn...@cloudbees.com ' 
>> via Jenkins Developers >:
>> 
>> Hi Ulli,
>> 
>> Can you clarify what these guidelines are and where they are (I did not see 
>> anything in a scan of the ML, nor on jenkins.io )?
>> 
>> With my Jenkins user hat on I would be somewhat annoyed if I had to upgrade 
>> Jenkins to get a small bug fix for a plugin.
>> 
>> Upgrading to every  `.1`  LTS is ok - but I am surprised there is any 
>> guideline saying to update to a `.2` and a `.3`?
>> 
>> /James
>> 
> 
> https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
>  
> 
> 
> There was quite a long and controversial discussion around that topic in this 
> mailing list (and the associated PR). 
> 
> 
>> On Friday, June 10, 2022 at 5:49:14 PM UTC+1 ullrich...@gmail.com 
>>  wrote:
>> I recently updated my plugins to follow the new guidelines to use 2.319.3 
>> rather than 2.319.1 as a plugin baseline. But now all my plugin upgrade PRs 
>> fail in the BOM project (https://github.com/jenkinsci/bom/pulls 
>> ). What do I need to do to get those 
>> PR builds working?
>> 
> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com <>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/38dccdf2-2b81-422c-9202-74f2584b410bn%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/ae9415ea-6764-4b21-ae87-217f185e5af4n%40googlegroups.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bic1AiFfzHRGkE_gKqf2ioF32iu5ZgnUkntuKoqB5H-7zg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/65BA8274-8A54-448A-A53D-1FFCF27B22B2%40gmail.com.


Re: BOM build errors due to conflict of baseline 2.319.3 and 2.319.1

2022-06-13 Thread Ullrich Hafner
> Am 13.06.2022 um 11:11 schrieb 'jn...@cloudbees.com' via Jenkins Developers 
> :
> 
> Hi Ulli,
> 
> Can you clarify what these guidelines are and where they are (I did not see 
> anything in a scan of the ML, nor on jenkins.io)?
> 
> With my Jenkins user hat on I would be somewhat annoyed if I had to upgrade 
> Jenkins to get a small bug fix for a plugin.
> 
> Upgrading to every  `.1`  LTS is ok - but I am surprised there is any 
> guideline saying to update to a `.2` and a `.3`?
> 
> /James
> 

https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
 


There was quite a long and controversial discussion around that topic in this 
mailing list (and the associated PR). 

> On Friday, June 10, 2022 at 5:49:14 PM UTC+1 ullrich...@gmail.com wrote:
> I recently updated my plugins to follow the new guidelines to use 2.319.3 
> rather than 2.319.1 as a plugin baseline. But now all my plugin upgrade PRs 
> fail in the BOM project (https://github.com/jenkinsci/bom/pulls 
> ). What do I need to do to get those 
> PR builds working?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/38dccdf2-2b81-422c-9202-74f2584b410bn%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/702C521E-E5D5-4568-AF63-6321FFF33AC4%40gmail.com.


BOM build errors due to conflict of baseline 2.319.3 and 2.319.1

2022-06-10 Thread Ullrich Hafner
I recently updated my plugins to follow the new guidelines to use 2.319.3 
rather than 2.319.1 as a plugin baseline. But now all my plugin upgrade PRs 
fail in the BOM project (https://github.com/jenkinsci/bom/pulls 
). What do I need to do to get those PR 
builds working?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/9636E3C8-F4C3-4E11-8133-F6431A1EE8D2%40gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-08 Thread Ullrich Hafner


> Am 08.06.2022 um 19:56 schrieb Simon Matthews :
> 
> More on what is stopping deploy.sh
> 
> I see this error message, which I had erroneously ignored previously:
> cp: cannot stat 'code-coverage-api-plugin/target/*hpi': No such file or 
> directory
> 

Ups, the path has been changed. I fixed that now. 

> The directory 'code-coverage-api-plugin/target/' doesn't exist, yet 
> everything looks good building the warnings-ng:
> 
> [INFO] --- maven-install-plugin:2.4:install (default-install) @ 
> warnings-ng-plugin-devenv ---
> [INFO] Installing /jenkins/warnings-ng-plugin-devenv/pom.xml to 
> /home/simon/.m2/repository/edu/hm/hafner/warnings-ng-plugin-devenv/UNVERSIONED/warnings-ng-plugin-devenv-UNVERSIONED.pom
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Java coding style 2.24.0-SNAPSHOT .. SUCCESS [ 19.703 
> s]
> [INFO] Static Analysis Model and Parsers 10.11.0-SNAPSHOT . SUCCESS [ 49.094 
> s]
> [INFO] Analysis Model API Plugin 10.11.0-SNAPSHOT . SUCCESS [ 12.007 
> s]
> [INFO] Code Coverage API Plugin 3.0.0-SNAPSHOT  SUCCESS [ 15.591 
> s]
> [INFO] UI Tests of Code Coverage Plugin UNVERSIONED ... SUCCESS [ 13.469 
> s]
> [INFO] Aggregator for Code Coverage Plugin UNVERSIONED  SUCCESS [  0.051 
> s]
> [INFO] Forensics API Plugin 1.14.0-SNAPSHOT ... SUCCESS [  9.788 
> s]
> [INFO] Git Forensics Plugin 1.9.0-SNAPSHOT  SUCCESS [ 10.822 
> s]
> [INFO] UI Tests of Git Forensics Plugin UNVERSIONED ... SUCCESS [ 12.355 
> s]
> [INFO] Aggregator for Git Forensics Plugin UNVERSIONED  SUCCESS [  0.007 
> s]
> [INFO] Warnings Next Generation Plugin 9.13.0-SNAPSHOT  SUCCESS [ 44.076 
> s]
> [INFO] UI Tests of Warnings Plugin UNVERSIONED  SUCCESS [ 15.580 
> s]
> [INFO] Aggregator for Warnings Plugin UNVERSIONED . SUCCESS [  0.008 
> s]
> [INFO] Warnings plugin development environment UNVERSIONED  SUCCESS [  0.006 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time:  03:27 min
> [INFO] Finished at: 2022-06-08T10:51:29-07:00
> [INFO] 
> 
> Removing plugins in docker/volumes/jenkins-home
> 

Ok, that looks good. (You just need the plugins analsis-model-api and 
warnings-ng, the other ones are not required in your PR).

You can try to create a test in 
https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/src/test/java/io/jenkins/plugins/analysis/warnings/steps/ParsersITest.java#L80
 

 
Then you see if the parser already works.

> On Wednesday, June 8, 2022 at 10:04:44 AM UTC-7 Simon Matthews wrote:
> Update: I manually ran the copy:
> cp -fv warnings-ng-plugin/plugin/target/*hpi 
> $JENKINS_HOME/plugins/warnings-ng.jpi
> 
> Something is triggering the "set -e" in the deploy.sh script to make it exit 
> before this copy happens. 
> 
> 
> 
> 
> Still no sign of my new parser:
> 
> On Wednesday, June 8, 2022 at 9:30:03 AM UTC-7 Simon Matthews wrote:
> Looks like I am missing the updated warnings-ng plugin:
> 
> 
> On Wednesday, June 8, 2022 at 4:00:48 AM UTC-7 ullrich...@gmail.com <> wrote:
> When you look at the installed plugins in your Jenkins, are there the correct 
> snapshot versions deployed?
> 
> It should look like:
> 
> 
> 
> The analysis-model code looks good (it should not be part of your master 
> branch, it should be be part of a new branch though).
> The warnings plugin fork has no changes yet?
> 
> 
> 
>> Am 08.06.2022 um 03:21 schrieb Simon Matthews >:
>> 
> 
>> 
>> 
>> On Tuesday, June 7, 2022 at 12:10:22 PM UTC-7 ullrich...@gmail.com 
>>  wrote:
>> Workaround 1: use a pipeline and not a Freestyle Job
>> 
>> Workaround 2: register your parser in the warnings plugin, see:
>> - documentation: 
>> https://github.com/jenkinsci/warnings-ng-plugin/blob/master/doc/Custom-Plugin.md#register-the-tool
>>  
>> 
>> - examples: 
>> https://github.com/jenkinsci/warnings-ng-plugin/tree/master/plugin/src/main/java/io/jenkins/plugins/analysis/warnings
>>  
>> 
>> 
>> 
>> I tried to follow  Workaround 2. 
>> 
>> I created a file to register the tool in warnings-ng by creating the file: 
>> warnings-ng-plugin/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/>  parser>.java 
>> 
>> I copied another file from the same directory and modified to reference my 
>> parser.  I note that almost all the 

Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Ullrich Hafner
Workaround 1: use a pipeline and not a Freestyle Job

Workaround 2: register your parser in the warnings plugin, see:
- documentation: 
https://github.com/jenkinsci/warnings-ng-plugin/blob/master/doc/Custom-Plugin.md#register-the-tool
 

- examples: 
https://github.com/jenkinsci/warnings-ng-plugin/tree/master/plugin/src/main/java/io/jenkins/plugins/analysis/warnings
 




> Am 07.06.2022 um 19:54 schrieb Simon Matthews :
> 
> 
> 
> On Tuesday, June 7, 2022 at 2:45:58 AM UTC-7 ullrich...@gmail.com wrote:
> In your Jenkinsfile of your job where you want to use the parser. Or are you 
> using a Freestyle project? 
> 
> I think in Freestyle projects I forgot to add a dynamic selection of the 
> parser ID in the UI up to now. I should file an issue for this bug. In this 
> case you need to register your parser in the warnings plugin as well...
> 
> Can you tell me how to work around this? At least to show that my parser is 
> working?
> 
> Simon 
> 
> 
>> Am 07.06.2022 um 03:03 schrieb Simon Matthews > >:
>> 
> 
>> 
>> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com 
>>  wrote:
>> 
>> Thanks for your reply. 
>> 
>> To update on progress, I had not previously added the 
>> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/> parser>ParserTest.java file. I have now added that and the unit tests are 
>> passing. 
>> 
>> The parser is not listed in the UI, because the parser is not registered in 
>> the warnings plugin yet. 
>> But you can invoke the parser already using:
>> 
>> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
>> analysisModelId: 'your-id')
>> Does that work?
>> 
>> 
>> It's not clear to me how I run that command, or what file I add it to. 
>> 
>> Simon
>> 
>> 
>> 
> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com 
>> .
> 
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/ef235a57-19bf-48e5-b875-a9aa24106f50n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/693F946D-E2C3-407C-9B78-3B053F5EA81A%40gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Ullrich Hafner
In your Jenkinsfile of your job where you want to use the parser. Or are you 
using a Freestyle project? 

I think in Freestyle projects I forgot to add a dynamic selection of the parser 
ID in the UI up to now. I should file an issue for this bug. In this case you 
need to register your parser in the warnings plugin as well...

> Am 07.06.2022 um 03:03 schrieb Simon Matthews :
> 
> 
> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com wrote:
> 
> Thanks for your reply. 
> 
> To update on progress, I had not previously added the 
> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/ parser>ParserTest.java file. I have now added that and the unit tests are 
> passing. 
> 
> The parser is not listed in the UI, because the parser is not registered in 
> the warnings plugin yet. 
> But you can invoke the parser already using:
> 
> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
> analysisModelId: 'your-id')
> Does that work?
> 
> 
> It's not clear to me how I run that command, or what file I add it to. 
> 
> Simon
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/640FA544-D6B8-42B9-82A1-39A9E85FB446%40gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-06 Thread Ullrich Hafner
The parser is not listed in the UI, because the parser is not registered in the 
warnings plugin yet. 
But you can invoke the parser already using:

recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
analysisModelId: 'your-id')
Does that work?

> Am 03.06.2022 um 20:35 schrieb Simon Matthews :
> 
> 
> 
> On Friday, June 3, 2022 at 1:15:35 AM UTC-7 ullrich...@gmail.com wrote:
> 
>> Looking at the first and second second go.sh, neither appear to actually 
>> copy any files from the file "analysis-model-api.jar" (or any 
>> "analysis-model-*SNAPSHOT.jar" file)  to the JENKINS_HOME directory. 
>> 
> 
> The first go.sh calls mvn install that installs the jar in your local maven 
> repository.
> 
> It looks like the Jenkins running under Docker is not picking up my modified 
> version of analysis-model. I don't see the parser that I added. 
> 
> I assume that I have missed a step somewhere. 
> 
> I have added files for the SoftwareDescriptor.java, I have added 
> the reference in the ParserRegistry.java, I have added the reference in 
> ParsersTest.java and an appropriate log file. 
> 
> In analysis-model, I have run "./bin/go.sh" and in warnings-ng-plug, I have 
> run "./bin/go.sh", then in the warnings-ng-plugin-devenv directory, I have 
> re-started "./jenkins.sh". 
> 
> If I configure a job, I can add "Record compiler warnings and static analysis 
> results" as a post-build step, but my new parser is not in the list. What 
> could I have missed?
> 
> Simon
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/990c3ff9-a200-4f1b-abdd-dfdb98ffeab8n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/D7C8F359-6F0D-468D-8114-504488E83730%40gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-03 Thread Ullrich Hafner

> Am 03.06.2022 um 00:34 schrieb Simon Matthews :
> 
> I have now got this to build and run in Jenkins (I installed the latest 
> version of Docker and the docker-compose-plugin so that I could use the 
> scripts without modification),

Good to see. I need to spend some time to investigate why docker compose does 
not work in the same way as docker-compose.

> however, when I modify the analysis-model (to add a parser) and run 
> ./bin/go.sh in the analysis-model directory, the script seems to be missing a 
> step. 
> 
> The script has:
> ...
> echo Copying module analysis-model version ${version} to 
> analysis-model-api-plugin Jenkins plugin
> 
> cd ../analysis-model-api-plugin || { echo "Wrong directory"; exit 1; }
> 
> exec ./go.sh $version
> ...
> 
> Looking at the first and second second go.sh, neither appear to actually copy 
> any files from the file "analysis-model-api.jar" (or any 
> "analysis-model-*SNAPSHOT.jar" file)  to the JENKINS_HOME directory. 
> 

The first go.sh calls mvn install that installs the jar in your local maven 
repository.

The second go.sh packages the jar from the local maven repository as Jenkins 
JPI file and deploys it to JENKINS_HOME using the deploy.sh command 

> Note that the documentation refers to running "go.sh" in the analysis-model 
> directory, but the only "go.sh" file in this directory is actually 
> "./bin/go.sh". 

Thanks for spotting. I forgot to update the documentation after reorganizing 
the scripts. Should be fixed now by 
https://github.com/uhafner/warnings-ng-plugin-devenv/commit/e6040034dfb7cffa1e761b12c0e007264380db8b

> 
> Simon
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/5fbb2fb1-f9de-4b83-b8e9-84650fcd5ca0n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/AFC836AB-FE55-42CD-A0B2-B75F6A3413BB%40gmail.com.


Re: warnings-ng-plugin-devenv won't build

2022-06-02 Thread Ullrich Hafner
I think that I replaced all HTTP references quite some time ago. If you find 
one, please let me know.

> Am 02.06.2022 um 09:16 schrieb 'Daniel Beck' via Jenkins Developers 
> :
> 
> That URL hasn't worked in a long time. Cloning the devenv repo and running 
> the clone script, including build, works for me. Are you sure you don't have 
> a Maven settings.xml file or something that specifies custom URLs?
> 
> On Thu, Jun 2, 2022 at 2:18 AM Simon Matthews  > wrote:
> I am running on a fresh install of Ubuntu 22.04 and it won't build (last part 
> of clone_repos.sh) for me. I think the error is this line (and similar):
> 
> Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could 
> not transfer artifact org.jvnet.hudson.plugins:analysis-pom:pom:5.23.0 
> from/to repo.jenkins-ci.org  
> (http://repo.jenkins-ci.org/public/ ): 
> Transfer failed for 
> http://repo.jenkins-ci.org/public/org/jvnet/hudson/plugins/analysis-pom/5.23.0/analysis-pom-5.23.0.pom
>  
> 
>  308 Permanent Redirect
> 
> Any ideas? 
> 
> Simon
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/a3f06f34-bdf8-492b-8d83-506fe38c3667n%40googlegroups.com
>  
> .
>   
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLGJiQOCQzq2dzo4jE4hQb_d8U02413u_boty9r%3DxkoDg%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/D0BC5E27-6688-4DC9-9AA7-4FC50FF454C5%40gmail.com.


Re: Trying to use the warnings-ng-plugin-devenv

2022-06-02 Thread Ullrich Hafner
Yes, the script is from the time before the integration of docker-compose into 
docker. 

I tried to replace docker-compose with docker compose in the script but it 
seems that the implementation is different and does not update the Jenkins 
version to the latest one so I finally did not change it. If you find a way to 
make that working without docker-compose please let me know!

> Am 02.06.2022 um 01:26 schrieb 'Gavin Mogan' via Jenkins Developers 
> :
> 
> Docker compose v2 is a docker plugin instead of a standalone CLI.
> 
> I personally recommend upgrading the cli as its way faster but you could 
> probably edit the scripts to the gym he hypenated one
> 
> 
> On Wed., Jun. 1, 2022, 4:01 p.m. Simon Matthews,  > wrote:
> I forked the warnings-ng-plugin-devenv and cloned it locally. Then I ran  
> ./clone-repos.sh, which completed successfully, however, when I try to run 
> "jenkins.sh", I get:
> alpine: Pulling from jenkins/jenkins
> Digest: 
> sha256:a7dd40264e04592ba0d759f7d75fb52fdd5f0fcb9ae5939fef7cbf23b4a6a944
> Status: Image is up to date for jenkins/jenkins:alpine
> docker.io/jenkins/jenkins:alpine 
> docker: 'compose' is not a docker command.
> See 'docker --help'
> Running docker compose with user ID 1010:441
> docker: 'compose' is not a docker command.
> See 'docker --help'
> 
> This is on an unbuntu 22.04 with "docker-compose" installed. I think the 
> command should be:
> docker-compose build
> not docker compose build
> Simon
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/6dedab15-7c78-48d6-89c4-6bc97b4b9e26n%40googlegroups.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusVHsOSZ1oBiKZaQeB2Mmz8sp7jtu41QTkRc9qm8L_wnQ%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C353BAFF-38D1-4DCA-A7EF-CB7413E7B108%40gmail.com.


Re: Building an hpi file?

2022-05-26 Thread Ullrich Hafner
Yes, using the development environment is the recommended way, since the setup 
simplifies the build steps.

The analysis-model is split into two modules: 
- analysis-model: a Java library (jar file) that is used in Jenkins or in 
GitHub Actions
- analysis-model-ap-plugin: a Jenkins Plugin Wrapper to provide the 
analysis-model jar for Jenkins plugins (actually for the only know dependency 
warnings-ng).

In my dev environment I have a script (analysis-model/etc/go.sh ) that builds 
the Jenkins Plugin *and* the Java library:
1) Build analysis-model jar with your new parser
2) Build analysis-model-api hpi (I.e., Jenkins Plugin wrapper), that wraps the 
SNAPSHOT jar into a Jenkins Plugin


> Am 25.05.2022 um 22:15 schrieb Simon Matthews :
> 
> I am trying to add another parser. The intent is that the warnings-ng plugin 
> will show (and use) my new additional parser and I believe that they way to 
> achieve that is through adding the parser to analysis-model. 
> 
> Simon
> 
> On Wednesday, May 25, 2022 at 12:33:46 PM UTC-7 bma...@gmail.com wrote:
> analysis-model is a jar, not a plugin. So it will create a jar as expected.
> It is used by other plugins I think (cannot check just now).
> 
> What are you trying to achieve?
> 
> Le mer. 25 mai 2022 à 21:18, Simon Matthews  > a écrit :
> I am attempting to build a modified version of the analysis-model plugin.I 
> think that I need to create an hpi file which I can then install in my 
> jenkins installation, but if this is not correct, please tell me. 
> 
> It's not clear to me how to do this from the command line: I think it has 
> changed over time, so there are plenty of old pages that are now incorrect. 
> 
> I think that I need to use maven to build the "hpi:hpi" target, but this may 
> be wrong. In any case, attempts to do this result in an error: I have tried 
> other targets, such as "package" and "install". They appear to complete the 
> build successfully, but don't create an hpi file. 
> 
> Running: 
> ~/bin/apache-maven-3.8.5/bin/mvn hpi:hpi
> results in:
> [ERROR] Failed to execute goal 
> org.jenkins-ci.tools:maven-hpi-plugin:3.29-rc1263.227a_29289ce3:hpi 
> (default-cli) on project analysis-model: Failed to determine Jenkins version 
> this plugin depends on. -> [Help 1]
> I have tried adding the following to my pom.xml file:
> 2.332.3
> but it doesn't help. 
> 
> What am I doing wrong? 
> 
> Simon
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-de...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/549954d3-3d28-46dd-a3b8-2d450474c87an%40googlegroups.com
>  
> .
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/1a70187a-1ead-4607-bce9-acdcf2348819n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/52FAF50C-8107-489E-A9A0-FC03A4F2EF9F%40gmail.com.


Re: Proposal: Move Jenkins Test Harness issue tracker to GitHub Issues

2022-05-23 Thread Ullrich Hafner
As mentioned several times before I think that using or allowing 2 different 
issue tracker systems for *any* Jenkins component (core and plugins) is a mess 
for users and developers.   

> Am 23.05.2022 um 20:54 schrieb Basil Crow :
> 
> On Thu, Apr 28, 2022 at 1:22 AM 'Daniel Beck' via Jenkins Developers 
> mailto:jenkinsci-dev@googlegroups.com>> 
> wrote:
> > Not part of the core deliverable, but core team repos. Projects still 
> > likely cross issue trackers.
> 
> Yes. In jenkins-infra/helpdesk#2819 
>  it was suggested that 
> "we could use something like core, unsorted, or something more specific that 
> means this is a tracking issue only for use in a larger project." Not only 
> does this add additional (and unwanted!) burden on project managers to create 
> the tracking issues, but also it does not address the regression that I 
> reported in jenkins-infra/helpdesk/issues/2819 (comment) 
> :
>  prior to the archiving of the packaging component, I could have easily moved 
> JENKINS-68600  to the correct 
> component, but now the functionality to correct the component of a misfiled 
> issue is not available to me. The suggested workaround is both burdensome and 
> incomplete. In short, the suggested workaround is not acceptable to me.
> 
> The migration of core components to GitHub issues was incomplete. It was 
> incomplete in the sense that it only established the use of GitHub for new 
> core component issues but did not migrate existing core component issues from 
> Jira to GitHub. It was incomplete because it covered core components but not 
> itself, breaking project management use cases. It was incomplete because it 
> broke the existing workflow documented in the Issue Reporting 
>  page in the documentation 
> without documenting the proposed new workflow, leading to confusion for end 
> users. It was incomplete because it did not describe a way to move issues 
> filed in an incorrect component to the correct component, breaking existing 
> issue triage use cases.
> 
> Completing this migration is a formidable task. The incomplete migration is 
> causing problems for me as I work on issue triage and project management, and 
> it is causing confusion for end users who have filed packaging tickets in the 
> wrong place multiple times. Pending the delivery of a complete migration, 
> please restore the status quo and move core components back to Jira. This is 
> a simple action that would resolve all of the problems that I have reported 
> and does not preclude a complete migration from taking place in the future.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpYjyzk6bhuzQZTSe6PePDRbBaN2gbgLc4%2B7BzpPVoSSw%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/FBC7E4F7-90B7-4D36-A568-B342EF2DAE0D%40gmail.com.


Re: Moving ATH tests closer to the code under test

2022-04-27 Thread Ullrich Hafner


> Am 26.04.2022 um 18:28 schrieb Basil Crow :
> 
> On Tue, Apr 26, 2022 at 7:45 AM Ullrich Hafner  
> wrote:
> 
>> Those tests will run in a special docker container with a headless browser 
>> (chrome or firefox).
> 
> Ideally, I think we would want to support both Dockerized and
> non-Dockerized builds if possible. 

You can run the build locally without Docker. Docker is just used in CI (GitHub 
Action or Jenkins). I am locally using a different Maven profile and run the 
tests without Docker in Firefox or Chrome. You can even run it from IntelliJ 
and set breakpoints.

> 
>> […] run them as real system tests using a real browser and a real Jenkins 
>> instance and not as part of our integration tests with a fake UI (HTMLUnit) 
>> and a fake Jenkins (started via JTH) […]
> 
> Regarding the use of a "real Jenkins instance," I wonder how the ATH
> implementation compares to RealJenkinsRule, which is at a high level
> doing something very similar; namely, starting Jenkins in a separate
> Java process and tearing it down at the end of the test. If the
> RealJenkinsRule implementation is more efficient while still remaining
> compatible with the goal of frontend testing with a headless browser,
> it may be worth looking into unifying the two implementations in order
> to reduce maintenance and/or increase performance.
> 
>> not all plugins have UI tests yet, so there is an initial ramp up time 
>> required
> 
> I think if we build it they will come.
> 
>> […] UI tests are more fragile
> 
> Has this ever not been the case in the decades you and I have been
> programming? I guess the benefit of this idea depends on _how_
> fragile. If the fragility is occasional and a retry chases the problem
> away, that could be tolerable. On the other hand, if the fragility is
> frequent and requires one or more retries, this could undermine the
> idea.
> 
>> build execution times of PRs will increase since the initialization is slow
> 
> I wonder if some targeted optimization couldn't be done through the
> use of techniques such as the ones used in RealJenkinsRule.
> 
> Basil
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjphex3uXLfjsAfCpEaFvMNpXgBocgnX5tHaSuqTV1iZ7w%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/644842DF-A9B1-4D27-81F7-AE5598E3325B%40gmail.com.


Re: Moving ATH tests closer to the code under test

2022-04-27 Thread Ullrich Hafner



> Am 27.04.2022 um 12:37 schrieb 'Antonio Muñiz' via Jenkins Developers 
> :
> 
> I was working/planning with Oliver for some time on this. One of the 
> identified downsides of this approach is that the Jenkins UI does often 
> evolve in a backward incompatible way (ie. table to divs change, plugin 
> manager recent changes, etc), all those potential breaking changes would not 
> be caught by acceptance tests running at plugin build/release time (unless 
> the plugin maintainer updates the `jenkins.version` to the latest very often).

When you run the ATH tests in a plugin then you run the tests agains the latest 
Jenkins version, not the baseline version defined in the plugin. I’m using 
Dependabot to make sure that this version is up to date. (It is still too late 
since the Jenkins release is already published, but at least you will see it 
one day after the release)

> The current ATH approach runs all acceptance tests against a specific Jenkins 
> version, so possible regressions are caught at Jenkins core release time, as 
> desired.
> The alternative would be to define the plugin build/release pipeline in a way 
> that ATHs are run against a dynamic Jenkins version (could be the latest 
> weekly at the time of the build), but that leads to unreproducible builds, 
> which is IMO quite bad. And it does not address the issue of checking for 
> regressions caused on plugins at core release time (unless some complicated 
> pipeline is put in place to run ATHs from some key plugins as part of the 
> Jenkins core build).
> 
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C060C521-3E3A-4186-84EC-673A779FAFB2%40gmail.com.


Re: Moving ATH tests closer to the code under test

2022-04-27 Thread Ullrich Hafner
>> Although ATH uses RESTish endpoints for a few purposes, for the most part 
>> the test setup (not just the actual assertions) uses the browser. In all 
>> cases the whole test run is “black-box”. This has its appeal (stronger 
>> coverage) but GUI setup makes tests much slower and either REST or GUI setup 
>> can also make it a lot more awkward to write tests than when using 
>> `[Real]JenkinsRule`, which are “white-box” and let you quickly set up an 
>> environment and run some assertions at the Java level. JTH also lets you 
>> write test-only extensions, which ATH does not.
> 
> I see; very interesting. I wonder how many parts of the test setup
> process are common to many tests/plugins versus unique to each
> test/plugin. For example, I could imagine that things like going
> through the setup wizard, creating a freestyle project, or adding an
> agent are common to many tests (and therefore pointless from the
> perspective of test coverage to repeat them multiple times), while
> other parts of the test setup process, like configuring a specific
> plugin, might be unique to each test/plugin. If true, and if the test
> time is dominated by the parts of the test setup process that are
> common to many tests/plugins, perhaps we could, for each portion of
> the test setup process that is common to many tests/plugins, run that
> portion with the GUI/REST API in one "primary" repository (e.g., core,
> Workflow: Job, etc) and (without loss of test coverage at a macro
> level) run that portion with JCasC/REST or even Java/JTH in the
> "secondary" repositories as a way of speeding up and de-flaking the
> setup process to get to the unique/interesting part.

This will depend on the type of the plugins. In my analysis plugins my tests 
start by creating a freestyle job or pipeline. There is no previous setup 
required. I don't think that this can be speed up with job-dsl or something 
different.  

> 
> In other words, I wonder if a middle ground between test coverage and
> performance couldn't be found. Or maybe I am hopelessly naive and this
> is an exercise in futility in the long term. I will discuss this with
> my friend who has experience in this domain.
> 
>> ATH installs plugins, and selects plugin versions, using user-mode tools. 
>> `[Real]JenkinsRule` follow the Maven test classpath. Possibly ATH could be 
>> given an option to define a mock UC based on a test classpath.
> 
> Yes, a great example of the "middle ground" approach from the previous
> paragraph!

This is already possible. In my UI tests I am starting the Jenkins under test 
with the same set of plugins that I am using in the integration tests (JTH). 
These plugins are just copied from the target folder of the plugin maven module 
to the target folder of the ui module and the JUT starts with them without 
installing them.

> 
>> Also whether the fragility is in the actual assertions, or test setup (point 
>> #1 above).
> 
> I think your point is that fragility in the test setup would undermine
> the idea at its core, while fragility in the actual assertions could
> be tolerated on a case-by-case basis in individual test suites. If so,
> I concur, and I think that finding a way to mitigate the fragility of
> test setup by factoring out that logic as described in the preceding
> paragraphs could be one solution.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpmQLNRwhJSGYc3wT28P32gHvt2aF_CJtkDtX47iwBGzw%40mail.gmail.com.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CCF7B65B-3986-4C78-B66C-1417C01264F5%40gmail.com.


Re: Moving ATH tests closer to the code under test

2022-04-26 Thread Ullrich Hafner
Thanks Basil for bringing this topic to attention! 

I am all in for this new approach! I think when we spend time to write UI tests 
(which are expensive to write and maintain, and slow to run, see test pyramid 
of Mike Cohen) then we should consider to run them as real system tests using a 
real browser and a real Jenkins instance and not as part of our integration 
tests with a fake UI (HTMLUnit) and a fake Jenkins (started via JTH). 

Since I already converted several plugins in the way you are suggesting I can 
give some more insights about the things that need to be done, the advantages, 
and disadvantages. I can only speak for plugins but in theory the same process 
should be possible for core as well. 

First of all, the credits for this approach go to Oliver Gondža! He created the 
building blocks in the acceptance test harness and his own plugins. If we 
follow this approach, a plugin will have three different types of tests:
1) Unit tests that test classes in isolation.
2) Integration tests that test one or more classes together in a running 
Jenkins instance (started by JTH). These tests will solely work on Jenkins' 
object model and will not use the browser HTML output anymore.
3) UI tests as end-to-end tests for one or more scenarios of the plugin use 
cases.

These tests will then be started using maven-surefire (1) and maven-failsafe 
(2) in our normal pipelines (buildPlugin() or GitHub Actions). Those results 
will visible in the usual way in a pull request. The UI tests (3) need to be 
started as a separate process since they work on the created artifacts. I’m 
using GitHub Actions in my plugins to start the individual UI tests, but it 
should be possible to run on Jenkins as well. Those tests will run in a special 
docker container with a headless browser (chrome or firefox).

All three types of tests are started for every pull request. So if a committer 
breaks something in the UI it will be visible as a PR check failure. Even if 
Jenkins core changes from 1.n to 1.(n+1), a Dependabot PR will be triggered and 
evaluated. 

If you want to use that approach in your plugin you need the following steps:
1) Change the folder structure of a plugin: we need a maven sub-module for the 
plugin and one for the corresponding ui-tests. Basically, all existing files 
need to be moved below the plugin folder.
2) Create a new ui-test project for the plugin.
3) Move existing Selenium page objects and test cases from the ATH to the 
plugin.  

Then you will have the previous ATH tests as part of your plugin. Here are some 
working examples:
- a feature PR in the Warnings Plugin 
(https://github.com/jenkinsci/warnings-ng-plugin/pull/1206 
)
- Jenkins upgrade PR in the Code Coverage Plugin 
(https://github.com/jenkinsci/code-coverage-api-plugin/pull/377 
)

Here are two work-in-progress PRs:
- JUnit Plugin (https://github.com/jenkinsci/junit-plugin/pull/355 
 or 
https://github.com/jenkinsci/junit-plugin/pull/342 
)
- PIT Plugin (https://github.com/jenkinsci/pitmutation-plugin/pull/129 
)

So I think that it something that each plugin author can do without much effort 
in each plugin. 

So as a summary the advantages:
- UI tests work with a real browser (and do not break due to HTMLUnit 
incompatibilities)
- integration tests are fast and work with assertions on the Jenkins object 
model. 
- when you do not use HTMLUnit anymore you will also find better ways to test 
you Java side models. This will lead to a better Java model! The UI layer 
should be as thin as possible and the logic will be part of Java that can be 
tested with Unit tests in Java.
- both types of tests are evaluated for each pull request

The disadvantages:
- not all plugins have UI tests yet, so there is an initial ramp up time 
required
- ATH based UI tests are more fragile
- build execution times of PRs will increase since the initialization is slow


> Am 25.04.2022 um 21:19 schrieb Basil Crow :
> 
> Hi all,
> 
> It seems to me that a number of problems are caused by ATH tests being
> in a separate repository from the code under test. When regressions
> occur, they are not discovered until much later. This causes pain for
> those who investigate ATH test failures. If the ATH tests were moved
> to the same repository as the code under test (i.e., core or plugins),
> then these issues would be caught prior to the problematic change
> being merged and released. This would be a win for those who
> investigate ATH failures.
> 
> Related is the fact that ATH provides a more realistic execution
> environment than JTH. ATH supports modern JavaScript frameworks, but
> JTH does not. Being able to easily write ATH tests in core and plugins
> would be a win for 

Re: Need Jenkins Jira access to create a Support ticket

2022-04-08 Thread Ullrich Hafner
https://accounts.jenkins.io/login

> Am 08.04.2022 um 08:49 schrieb Vinothkumaar Venkataraman 
> :
> 
> Hi Team,
> 
> We would need to create a support Jenkins JIRA ticket for about a Security 
> Vulnerability. Could you please provide the access to create an account for 
> my mail id - v.vinothkum...@gmail.com?
> 
> Thanks & Regards,
> V.Vinothkumaar
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/b54e2e11-0027-431b-8352-fdff5b5cd838n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/65544B6D-B935-4DEB-A7A3-65A07E6B3890%40gmail.com.


Re: Intellij Stapler Framework Support compatibility

2022-03-30 Thread Ullrich Hafner
Currently 2022.1 is in beta so I think it would be save to use 2021.1 as 
minimum baseline. Stapler plugin users are developers which typically use 
latest versions rather than outdated versions. So please go ahead and change 
the baseline.

> Am 30.03.2022 um 06:41 schrieb Denys Digtiar :
> 
> I don't have much time to develop this IntelliJ plugin but at least I want to 
> keep doing some maintenance on it.
> 
> It currently raises quite a few deprecation warnings from jetbrain verifiers. 
> Also it cannot support hot reload. And latest gradle build plugin is not 
> easily usable.
> 
> All of above is due to compatibility target of IntelliJ 2016.2. It's rather 
> old. Pre Java 9. I don't think it's of much use at all on latest OS and Java 
> versions. 
> 
> Would anybody be opposed if I bump compatibility to some newer version? Maybe 
> 2020.x or something like that?
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAO%2BCqDg4z5%2BtsvXcsmi9mYwWwAxjA%3Dhgs-WGM6HLTmmPzKtvDw%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4C9E6759-0E44-40B6-840C-169C3D77E57A%40gmail.com.


Re: Using data-tables-api-plugin

2022-03-29 Thread Ullrich Hafner
You can add actions to your build. See 
https://www.jenkins.io/doc/developer/extensibility/action-for-all-projects/ 
<https://www.jenkins.io/doc/developer/extensibility/action-for-all-projects/>
Or what do you mean with extend?

> Am 29.03.2022 um 13:59 schrieb Marit M :
> 
> Thanks, I fixed the layout and able to retrieve the data table now.
> I did include an empty side panel, how do I extend the default side panel 
> that is associated to a build?
> 
> Thanks, 
> Marit.
> 
> ב-יום חמישי, 24 במרץ 2022 בשעה 18:27:17 UTC+2, ullrich...@gmail.com כתב/ה:
> Your layout is broken. Do not use Jenkins default layouts when using BS. It 
> seems that the side panel is missing and so some JS libs are not loaded.
> 
> Example:
> 
> https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/resources/io/jenkins/plugins/forensics/miner/ForensicsViewModel/index.jelly
>  
> <https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/resources/io/jenkins/plugins/forensics/miner/ForensicsViewModel/index.jelly>
> 
> https://github.com/jenkinsci/bmc-cfa-plugin/tree/stat 
>> <https://github.com/jenkinsci/bmc-cfa-plugin/tree/stat>
> 
>> 
>> 
>> 
>> 
>> ב-יום שלישי, 15 במרץ 2022 בשעה 22:47:28 UTC+2, timja...@gmail.com 
>> <http://gmail.com/> כתב/ה:
>> If you can share your code / a branch with what you have you might get 
>> better help if that's possible
>> 
>> On Tue, 15 Mar 2022 at 19:44, Ullrich Hafner > wrote:
>> 
>> 
>>> Am 11.03.2022 um 07:31 schrieb Marit M >:
>>> 
>>> Hi,
>>> 
>>> I'm trying to implement tables with dynamic model based content in my 
>>> plugin.
>>> Only the table columns are displayed, while the the content is missing, and 
>>> instead the following message is displayed: "Loading - please wait ...".
>>> 
>>> I tried to debug with a breakpoint at getRows() and it seems like it's not 
>>> being called.
>>> 
>>> Looking at the browser console:
>>> 
>>>  Uncaught ReferenceError: Prototype is not defined
>>> at no-prototype.js:2:1
>>> :8080/jenkins/$stapler/bound/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows:1
>>>   Failed to load resource: the server responded with a status of 
>>> 403 (Forbidden)
>>> 
>>> 404 Not Found
>>> Stapler processed this HTTP request as follows, but couldn't find the 
>>> resource to consume the request
>>> 
>>> -> evaluate( 
>>> :org.kohsuke.stapler.bind.BoundObjectTable,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>>  -> 
>>> evaluate(((StaplerFallback)).getStaplerFallback(),"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>>  -> evaluate( 
>>> :org.kohsuke.stapler.bind.BoundObjectTable$Table,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>>  -> 
>>> evaluate(.getDynamic("7c9ca447-e432-4e0c-8aac-d6a208329a5b",...),"/getTableRows")
>>>  -> evaluate( 
>>> :com.bmc.ims.BmcCfaAction,"/getTableRows") -> No matching rule was found on 
>>>  for "/getTableRows"
>>>  has the following URL mappings, in the 
>>> order of preference:
>>> 
>>> If path ends without '/' insert it
>>> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(...)
>>>  for url=/getTableRows/...
>>> VIEW.groovy for url=/VIEW
>>> VIEW.gsp for url=/VIEW
>>> VIEW.jelly for url=/VIEW
>>> index view of org.kohsuke.stapler.jelly.groovy.GroovyFacet@163d95c0 for 
>>> url=/
>>> index view of org.kohsuke.stapler.jelly.JellyFacet@41be6b24 for url=/
>>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getDisplayName() for 
>>> url=/displayName/...
>>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getIconFileName() for 
>>> url=/iconFileName/...
>>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getUrlName() for 
>>> url=/urlName/...
>>> BLOCKED: java.io.File com.bmc.ims.BmcCfaAction.getRelatedJob() for 
>>> url=/relatedJob/...
>>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getCommitModel() for 
>>> url=/commitModel/...
>>> BLOCKED: io.jenkins.plugins.datatables.TableModel 
>>> com.bmc.ims.BmcCfaAction.getTableModel(String) for url=/tableModel/TOKEN/...
>>> BLOCKED: java.lang.String 
>>> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(String)
>>>  for url=/tableRows/TOKEN/...
&g

Re: Using data-tables-api-plugin

2022-03-24 Thread Ullrich Hafner
Your layout is broken. Do not use Jenkins default layouts when using BS. It 
seems that the side panel is missing and so some JS libs are not loaded.

Example:

https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/resources/io/jenkins/plugins/forensics/miner/ForensicsViewModel/index.jelly
 
<https://github.com/jenkinsci/forensics-api-plugin/blob/master/src/main/resources/io/jenkins/plugins/forensics/miner/ForensicsViewModel/index.jelly>

https://github.com/jenkinsci/bmc-cfa-plugin/tree/stat
> 
> 
> 
> 
> ב-יום שלישי, 15 במרץ 2022 בשעה 22:47:28 UTC+2, timja...@gmail.com כתב/ה:
> If you can share your code / a branch with what you have you might get better 
> help if that's possible
> 
> On Tue, 15 Mar 2022 at 19:44, Ullrich Hafner  > wrote:
> 
> 
>> Am 11.03.2022 um 07:31 schrieb Marit M > >:
>> 
>> Hi,
>> 
>> I'm trying to implement tables with dynamic model based content in my plugin.
>> Only the table columns are displayed, while the the content is missing, and 
>> instead the following message is displayed: "Loading - please wait ...".
>> 
>> I tried to debug with a breakpoint at getRows() and it seems like it's not 
>> being called.
>> 
>> Looking at the browser console:
>> 
>>  Uncaught ReferenceError: Prototype is not defined
>> at no-prototype.js:2:1
>> :8080/jenkins/$stapler/bound/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows:1
>>   Failed to load resource: the server responded with a status of 403 
>> (Forbidden)
>> 
>> 404 Not Found
>> Stapler processed this HTTP request as follows, but couldn't find the 
>> resource to consume the request
>> 
>> -> evaluate( 
>> :org.kohsuke.stapler.bind.BoundObjectTable,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>  -> 
>> evaluate(((StaplerFallback)).getStaplerFallback(),"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>  -> evaluate( 
>> :org.kohsuke.stapler.bind.BoundObjectTable$Table,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>>  -> 
>> evaluate(.getDynamic("7c9ca447-e432-4e0c-8aac-d6a208329a5b",...),"/getTableRows")
>>  -> evaluate( 
>> :com.bmc.ims.BmcCfaAction,"/getTableRows") -> No matching rule was found on 
>>  for "/getTableRows"
>>  has the following URL mappings, in the 
>> order of preference:
>> 
>> If path ends without '/' insert it
>> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(...)
>>  for url=/getTableRows/...
>> VIEW.groovy for url=/VIEW
>> VIEW.gsp for url=/VIEW
>> VIEW.jelly for url=/VIEW
>> index view of org.kohsuke.stapler.jelly.groovy.GroovyFacet@163d95c0 for url=/
>> index view of org.kohsuke.stapler.jelly.JellyFacet@41be6b24 for url=/
>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getDisplayName() for 
>> url=/displayName/...
>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getIconFileName() for 
>> url=/iconFileName/...
>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getUrlName() for 
>> url=/urlName/...
>> BLOCKED: java.io.File com.bmc.ims.BmcCfaAction.getRelatedJob() for 
>> url=/relatedJob/...
>> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getCommitModel() for 
>> url=/commitModel/...
>> BLOCKED: io.jenkins.plugins.datatables.TableModel 
>> com.bmc.ims.BmcCfaAction.getTableModel(String) for url=/tableModel/TOKEN/...
>> BLOCKED: java.lang.String 
>> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(String)
>>  for url=/tableRows/TOKEN/...
>> 
>> Any idea?
>> 
> 
> Does your class implement the AsyncTableContentProvider Interface? Or why is 
> the method call blocked?
> 
> 
>> Thanks,
>> Marit.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/7d49b425-2339-4755-9f20-b4ed90128d41n%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/7d49b425-2339-4755-9f20-b4ed90128d41n%40googlegroups.com?utm_medium=email_source=footer>.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to

Re: Using data-tables-api-plugin

2022-03-15 Thread Ullrich Hafner


> Am 11.03.2022 um 07:31 schrieb Marit M :
> 
> Hi,
> 
> I'm trying to implement tables with dynamic model based content in my plugin.
> Only the table columns are displayed, while the the content is missing, and 
> instead the following message is displayed: "Loading - please wait ...".
> 
> I tried to debug with a breakpoint at getRows() and it seems like it's not 
> being called.
> 
> Looking at the browser console:
> 
>  Uncaught ReferenceError: Prototype is not defined
> at no-prototype.js:2:1
> :8080/jenkins/$stapler/bound/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows:1
>   Failed to load resource: the server responded with a status of 403 
> (Forbidden)
> 
> 404 Not Found
> Stapler processed this HTTP request as follows, but couldn't find the 
> resource to consume the request
> 
> -> evaluate( 
> :org.kohsuke.stapler.bind.BoundObjectTable,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>  -> 
> evaluate(((StaplerFallback)).getStaplerFallback(),"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>  -> evaluate( 
> :org.kohsuke.stapler.bind.BoundObjectTable$Table,"/7c9ca447-e432-4e0c-8aac-d6a208329a5b/getTableRows")
>  -> 
> evaluate(.getDynamic("7c9ca447-e432-4e0c-8aac-d6a208329a5b",...),"/getTableRows")
>  -> evaluate( 
> :com.bmc.ims.BmcCfaAction,"/getTableRows") -> No matching rule was found on 
>  for "/getTableRows"
>  has the following URL mappings, in the 
> order of preference:
> 
> If path ends without '/' insert it
> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(...)
>  for url=/getTableRows/...
> VIEW.groovy for url=/VIEW
> VIEW.gsp for url=/VIEW
> VIEW.jelly for url=/VIEW
> index view of org.kohsuke.stapler.jelly.groovy.GroovyFacet@163d95c0 for url=/
> index view of org.kohsuke.stapler.jelly.JellyFacet@41be6b24 for url=/
> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getDisplayName() for 
> url=/displayName/...
> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getIconFileName() for 
> url=/iconFileName/...
> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getUrlName() for 
> url=/urlName/...
> BLOCKED: java.io.File com.bmc.ims.BmcCfaAction.getRelatedJob() for 
> url=/relatedJob/...
> BLOCKED: java.lang.String com.bmc.ims.BmcCfaAction.getCommitModel() for 
> url=/commitModel/...
> BLOCKED: io.jenkins.plugins.datatables.TableModel 
> com.bmc.ims.BmcCfaAction.getTableModel(String) for url=/tableModel/TOKEN/...
> BLOCKED: java.lang.String 
> io.jenkins.plugins.datatables.DefaultAsyncTableContentProvider.getTableRows(String)
>  for url=/tableRows/TOKEN/...
> 
> Any idea?
> 

Does your class implement the AsyncTableContentProvider Interface? Or why is 
the method call blocked?


> Thanks,
> Marit.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/7d49b425-2339-4755-9f20-b4ed90128d41n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/96821D23-0034-4341-A48A-5FC0725866CE%40gmail.com.


Re: webhook plugin development for multibranchPipelineJob

2022-02-08 Thread Ullrich Hafner
You should upgrade the plugin to a recent Jenkins Version like 2.303.1, then 
the BOM will provide a solution for all of these problems 
(https://github.com/jenkinsci/bom).

> Am 08.02.2022 um 20:17 schrieb John Patrick :
> 
> Hi,
> 
> I'm looking adding support for `multibranchPipelineJob` to a webhook plugin 
> for jenkins.
> 
> Using `mvn hpi:run` it boots a jenkins v1.625.3 instance and I have been able 
> to debug the current plugin to see it working. But that jenkins instance 
> lacks support for 'multibranchPipelineJob'.
> 
> So I'm trying to add those plugins, but am going around in circles with a 
> plugin dependency mismatch hell.
> 
> As the plugin is 4 years old, I'm trying to pick other releases from the same 
> timeframe, so my current list is;
> 
>   org.jenkins-ci.plugins
>   scm-api
>   2.2.1
>   test
> 
> 
>   org.jenkins-ci.plugins
>   job-dsl
>   1.65
>   test
> 
> 
>   org.jenkins-ci.plugins.workflow
>   workflow-multibranch
>   2.17
>   test
> 
> 
>   org.jenkins-ci.plugins.workflow
>   workflow-aggregator
>   2.5
>   test
> 
> 
> But I'm now basically getting mismatch errors and the solutions are all 
> install the correct version.
> 
> Anyone able to help, Ideally I don't want the answer I want to understand the 
> magic I can work it out. i.e. start with plugin x as this is the base, then 
> look at dependency tree for that.
> 
> Cheers,
> John
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH9u10n9dA1UXr%2BjhkNEZ708W7kv4DmAUGY1qi6TttUsxWS8Zw%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/AEB21C67-2938-46AB-B54C-54B769DAA9E8%40gmail.com.


Re: Plugin BOM upgrade, 2.289.1 vs. 2.289.3

2022-01-31 Thread Ullrich Hafner
The docs are here: 
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
 


While I understand the reasoning for using the latest patch version of an LTS I 
think this increases the number of unneeded version upgrades for plugin 
authors. Due to this unnecessary version change in configuration as code the 
git plugin needs to increase the version. When Mark releases this change in the 
git plugin as well, I need to change my git-forensics plugin as well, … and so 
on. The number of plugin upgrades increases just because the LTS patch version 
increases, this is just a lot of additional work for nothing.

> Am 31.01.2022 um 16:02 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> I am not sure there is a consensus yet in this area; see discussion in 
> https://github.com/jenkinsci/archetypes/pull/376#discussion_r781199364 
>  and 
> elsewhere. My inclination is to require 2.289.3; there does not seem to be 
> much point in testing against an outdated LTS point release, especially one 
> that predates a security advisory and which no one should be running in 
> production. I will file a docs PR making that policy change and see where the 
> discussion goes.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3xQW9u%2B-7jBjvqoiqO%2B283ZNJ0HYvkweR2-Gh_%2By1bjA%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/19511F6A-0237-4286-9E1D-F5DD1899172E%40gmail.com.


Re: Plugin BOM upgrade, 2.289.1 vs. 2.289.3

2022-01-31 Thread Ullrich Hafner


> Am 31.01.2022 um 15:46 schrieb Mark Waite :
> 
> Dependabot proposed a git plugin pull request 
>  to update the 
> 2.289.x bom from 1117.v62a_f6a_01de98 to 1135.va_4eeca_ea_21c1.
> 
> The pull request CI build 
>  fails because 
> configuration as code plugin requires Jenkins 2.289.3 or higher but the git 
> plugin only requires 2.289.1 or higher.

We should inform the configuration as code plugin team to use the recommended 
Jenkins baseline versions, i.e., 2.289.1 or 2.303.1. 

> 
> I'm interested in recommendations for actions I should take in this case.  I 
> could:
> Use dependabot to ignore the proposed upgrade and remain with the previous 
> version of the plugin bom
> Increase the minimum required Jenkins version from 2.289.1 to 2.289.3
> Increase the minimum required Jenkins version from 2.289.1 to 2.303.1 and use 
> the matching plugin bom for 2.303.1
> Do something else that I've not considered
> Are there particular strengths of one of those options over the others?  
> 
> Are there weaknesses in one or more of those options that would guide me to 
> not choose that option?
> 
> Mark Waite
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/04973ee4-fcc0-4fd9-a3ea-f95bc7311aa9n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/768A8894-8926-4B41-9F73-4F5B13D06617%40gmail.com.


Re: Help needed with a stuck PR merge

2022-01-19 Thread Ullrich Hafner
Is your PR up to date with master branch (merge or rebase?)?

> Am 20.01.2022 um 05:36 schrieb Konstantin Voin :
> 
> Hello,
> 
> Can someone help with the last check on this PR: 
> https://github.com/jenkinsci/fortify-on-demand-uploader-plugin/pull/108 
>  ?
> 
> It's been sitting on 
> continuous-integration/jenkins/pr-merge Expected — Waiting for status to be 
> reported 
> and we are not sure how to proceed?
> 
> Thanks!
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/b20d8808-7d8d-4031-ab85-5c16ceceb331n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/C46DC159-341B-40C2-9AFA-49CDD0029EBE%40gmail.com.


Re: Plugin for adoption: OWASP Dependency Check

2022-01-18 Thread Ullrich Hafner
And please note:

Since a couple of releases an OWASP dependency check parser is part of the 
warnings plugin as well 
(https://github.com/jenkinsci/warnings-ng-plugin/blob/master/SUPPORTED-FORMATS.md
 
).
 
So if you are just interested in showing the results of the analysis no 
additional plugin is required anymore. And you do need to duplicate development 
of mostly the same feature set (and you do not need to fix security issues that 
have been fixed already in the warnings plugin).

Ulli 


> Am 17.01.2022 um 22:33 schrieb kudos-dude :
> 
> 
> Hello,
> 
> I would like to pass off the maintainer role. Please let me know if you 
> require anything additional to complete the process.
> On Monday, January 17, 2022 at 3:35:08 PM UTC-5 mr.danie...@gmail.com 
>  wrote:
> Hi Jean-Marc,
> 
> I understood that "kudos-dude" (who wrote here on 10 November that he can no 
> longer be maintainer) is the same person as "Wes" (see the last previous mail 
> by "kudos-dude" and also the Jira profile: 
> https://issues.jenkins.io/secure/ViewProfile.jspa?name=kudos_dude 
> ).
> 
> Nonetheless, he filed an issue 4 December asking for the security warning to 
> be removed, because it is fixed in the newest version: 
> https://issues.jenkins.io/browse/JENKINS-67321 
> 
> 
> I do not yet know what the process is to handle this issue, but it seems to 
> be pretty clear that kudos-dude/Wes does not see himself in the 
> maintainer-role any longer. I'll write to his e-mail address listed on Jira 
> anyway to confirm that once more.
> 
> Best regards,
> Daniel
> 
> Jean-Marc Meessen schrieb am Montag, 17. Januar 2022 um 21:02:21 UTC+1:
> Hello Daniel,
> 
> Thank you for your interest in maintaining this plugin.
> 
> The situation of that plugin is a little blurry right now: there was a recent 
> adoption request by Wes that has been approved. But the plugin is still 
> marked for adoption. Did Wes forget to remove the flag or did he give up 
> after a couple of weeks?
> 
> Could you please reach out to him to assess the exact situation and come back 
> to this group? Hint: look at the git log for the email.
> 
> Apparently, this plugin needs some love and attention: there is an XSS 
> vulnerability detected on it.
> 
> /- Jmm
> 
> Le lun. 17 janv. 2022 à 19:08, Daniel Warmuth > a 
> écrit :
> Hi,
> 
> I'd like to become maintainer of this plugin 
> (https://plugins.jenkins.io/dependency-check-jenkins-plugin/ 
> ). I understand 
> that Wes (kudos-dude) can no longer be maintainer and is looking for someone 
> to take over.
> 
> My GitHub username is "danile42" and my Jenkins infrastructure account id is 
> also "danile42".
> 
> I do not have pull requests open, but work at a company that wants to use 
> this plugin - therefore, I have a special interest and time available to do 
> maintenance work.
> 
> Please let me know how we can proceed.
> 
> Best regards,
> Daniel
> 
> Jean-Marc Meessen schrieb am Samstag, 18. Dezember 2021 um 21:43:03 UTC+1:
> Hello Wes,
> 
> Thank you for adopting this plugin.
> 
> I am working with Mark Waites and a couple of others on various initiatives 
> to improve the contributors and maintainers experience (especially newcomers).
> 
> It is in that context that I believe that it would be great if we could we 
> discuss your experience by mail of even is a short call (if time zones are 
> favorable). I'd like to know things, among others, like:
> was the adoption successful?
> what were the friction points? 
> Did you get (or needed) help? In what form? 
> what were your motives for adoption?
> what is your previous experience as Jenkins/OSS contributor and in java dev?
> 
> If interested to share your experience, you can contact me at 
> jean...@meessen-web.org <>.
> 
> /- Jmm
> Jean-Marc Meessen
> Brussels, Belgium
> 
> Le jeudi 11 novembre 2021 à 21:36:50 UTC+1, kudos-dude a écrit :
> I want to apologize for the tone in my original post. Just feeling a bit 
> overwhelmed at the moment.
> 
> The plugin on Github still contains the `adopt-this-plugin` tag and the 
> "Seeking a new maintainer" section.
> 
> https://github.com/jenkinsci/dependency-check-plugin 
> 
> 
> Please let me know if there is anything else I need to do.
> 
> Wes
> On Thursday, November 11, 2021 at 9:10:37 AM UTC-5 ullrich...@gmail.com <> 
> wrote:
> As a side note for this plugin: if someone is willing to refactor the 
> existing parser so that it rather writes the output to the object model of 
> the analysis-model plugin then we simply can integrate it into the parser 
> collections of the warnings plugin. Then the whole OWASP Dependency Check 
> plugin will become obsolete and the visualization 

Re: INFRA project issues migration from Jira to Github

2022-01-13 Thread Ullrich Hafner
> 
> My regret is the fact I've learned about the "notifyUsers=false" Jira REST 
> API parameter too late.
> 

Well, I think it is very important to notify reporters that their issues have 
been moved to a new system. 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/BF7840EA-1A0D-4D6C-8FCD-253C08947C92%40gmail.com.


Re: INFRA project issues migration from Jira to Github

2022-01-13 Thread Ullrich Hafner

> Am 13.01.2022 um 08:46 schrieb Tim Jacomb :
> 
> The information was included in the import
> 
> All of them have the reporter, and the ones assigned have it in the expanded 
> details section, e.g 
> https://github.com/jenkins-infra/helpdesk/issues/2690 
> <https://github.com/jenkins-infra/helpdesk/issues/2690>
> 
> GitHub doesn’t let you report as another user,

I see, this is a real drawback of the import. I am using a „reporter" filter 
quite often in Jira. 

> and assignee would require a Jira -> GitHub mapping, which might work for the 
> INFRA project as it’s unlikely to be many people assigned to, but also not 
> very valuable info IMO.

I think it is a very valuable information who actually fixed a bug. But since 
the information is at least visible in the description text at least a 
workaround is available... 

> 
> There’s hundreds of old issues to review and likely close which should end up 
> with a much more manageable backlog
> 
> On Wed, 12 Jan 2022 at 23:42, Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
> It seems that the reporters (and assignees) of the issues have not been 
> mapped. Is this planned? 
> 
> 
>> Am 12.01.2022 um 14:50 schrieb 'Herve Le Meur' via Jenkins Developers 
>> mailto:jenkinsci-dev@googlegroups.com>>:
>> 
>> Hello!
>> 
>> As some of you might have already noticed, all issues related to the 
>> Infrastructure project have been migrated from Jira 
>> (https://issues.jenkins.io/projects/INFRA/issues 
>> <https://issues.jenkins.io/projects/INFRA/issues>) to Github 
>> (https://github.com/jenkins-infra/helpdesk/issues?q=label%3Aimported-jira-issue
>>  
>> <https://github.com/jenkins-infra/helpdesk/issues?q=label%3Aimported-jira-issue>)
>> 
>> It's almost done, several docs linking to the jira project still have to be 
>> updated to point to this Github repository.
>> 
>> You can find more details and the related infra meeting notes here: 
>> https://github.com/jenkins-infra/helpdesk/issues/9 
>> <https://github.com/jenkins-infra/helpdesk/issues/9>
>> 
>> Regards,
>> 
>> Hervé
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-dev+unsubscr...@googlegroups.com 
>> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/e564ed63-3fd7-4888-a8b5-6630974ed91cn%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/jenkinsci-dev/e564ed63-3fd7-4888-a8b5-6630974ed91cn%40googlegroups.com?utm_medium=email_source=footer>.
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/DB75232C-4F54-4BC7-AD27-94F2D5292C87%40gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/DB75232C-4F54-4BC7-AD27-94F2D5292C87%40gmail.com?utm_medium=email_source=footer>.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidW%2BDzstqjgj7-MvkuPFYLSwFTeWF1%3DKxfOjkrMpa8jqQ%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidW%2BDzstqjgj7-MvkuPFYLSwFTeWF1%3DKxfOjkrMpa8jqQ%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/B814ACB6-60B9-4048-84B6-1641ED586075%40gmail.com.


Re: INFRA project issues migration from Jira to Github

2022-01-12 Thread Ullrich Hafner
It seems that the reporters (and assignees) of the issues have not been mapped. 
Is this planned? 

> Am 12.01.2022 um 14:50 schrieb 'Herve Le Meur' via Jenkins Developers 
> :
> 
> Hello!
> 
> As some of you might have already noticed, all issues related to the 
> Infrastructure project have been migrated from Jira 
> (https://issues.jenkins.io/projects/INFRA/issues) to Github 
> (https://github.com/jenkins-infra/helpdesk/issues?q=label%3Aimported-jira-issue)
> 
> It's almost done, several docs linking to the jira project still have to be 
> updated to point to this Github repository.
> 
> You can find more details and the related infra meeting notes here: 
> https://github.com/jenkins-infra/helpdesk/issues/9
> 
> Regards,
> 
> Hervé
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e564ed63-3fd7-4888-a8b5-6630974ed91cn%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/DB75232C-4F54-4BC7-AD27-94F2D5292C87%40gmail.com.


Incremental releases show not up as GitHub action result anymore

2022-01-05 Thread Ullrich Hafner
Since a couple of days, incremental releases do not show up as GitHub action 
result anymore. 
Is this a know problem in our infrastructure?

E.g.
Pull Request: https://github.com/jenkinsci/prism-api-plugin/pull/2

Available incrementals from this PR:
https://repo.jenkins-ci.org/incrementals/io/jenkins/plugins/prism-api

Latest commit with GitHub action result: aedfa8f
First commit without GitHub action result: bc0c623

I’m not sure if that started with commits in this year...

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/B6DC0454-CCC1-48B4-8A00-55D71F228292%40gmail.com.


Re: Setting up automated plugin release

2021-12-28 Thread Ullrich Hafner
Maybe you can inline the existing Abstract form the JEP before the section 
‚Prerequisites‘? And add an example that shows the old and new versions in the 
abstract as well? 

> Am 28.12.2021 um 14:58 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Tue, Dec 28, 2021 at 5:50 AM Marit M  > wrote:
> now I understand that Incrementals appends a commit number, plus a SHA, to 
> version numbers.
> 
> https://www.jenkins.io/doc/developer/publishing/releasing-cd/#pom-file-modifications
>  
> 
>  says so; is there a way we could make this more prominent? 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr04RcPDC8UQh5xKV2fQ1coQThNjR7AxSrnQ7Veay4rq7g%40mail.gmail.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6DF2C911-A203-440A-8D28-754CD8FFB09E%40gmail.com.


Re: Expose data to API from Jenkins Shared library

2021-12-15 Thread Ullrich Hafner
Does your action implement a method:

public Api getApi();
?

> Am 15.12.2021 um 02:12 schrieb Oscar Arevalo Loyola :
> 
> Hi,
> 
> I'm trying to expose internal Run data to the REST API.
> Currently I'm using a Shared Library to create an object containing data 
> about downstream builds in multiple levels
> 
> Is it possible to expose the data to the REST API from Shared library code?
> I was checking several methods but still not able to achieve it.
> So, I tried with Run.addAction and I'm able to see my action in in the 
> url/api/json but it doesn't expose the properties of my action (I added 
> @ExportedBean to the class and @Exported to the properties)
> 
> Basically, I want to achieve this:
> https://wiki.jenkins-ci.org/display/JENKINS/Exposing+data+to+the+remote+API
> but from a Shared Library, not from a plugin.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/7997e32b-cf5f-42a2-8879-880fbaa11d44n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/F06292D1-E6FA-4FD1-974D-5C88A730E371%40gmail.com.


Re: StaplerProxy getTarget

2021-12-15 Thread Ullrich Hafner
I found the problem. Seems that during my merge the index.jelly file has been 
deleted. 

It would be nice though if Stapler would actually print the thing that is not 
found rather than writing just "Not Found“.

> Am 15.12.2021 um 10:21 schrieb 'Daniel Beck' via Jenkins Developers 
> :
> 
> 
> 
> On Wed, Dec 15, 2021 at 1:13 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote: 
> (Code https://github.com/jenkinsci/warnings-ng-plugin/pull/1145/ 
> <https://github.com/jenkinsci/warnings-ng-plugin/pull/1145/>)
> 
> Is this the correct PR? Looking at the plugin, only ResultAction has a 
> getTarget returning an IssuesDetail, and neither is involved in the PR.

Sorry, this was indeed the wrong PR. I should not write mails after midnight :-(

> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNhNKk1ZN162Lp0nATWw%2BUZD6DbW_CdfQQwk%3DN_P5Qug%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNhNKk1ZN162Lp0nATWw%2BUZD6DbW_CdfQQwk%3DN_P5Qug%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7BCC818D-F50E-4804-ADBE-AAA390AFA9A4%40gmail.com.


StaplerProxy getTarget

2021-12-14 Thread Ullrich Hafner
I am implementing StaplerProxy for some of my detail views. When I am returning 
a new view object in the getTarget method that is part of my plugin then 
everything shows up correctly. When I return an object from another plugin I 
get a 404 error. Is this some restriction (class loader?) that I cannot return 
objects from other plugins?

(Code https://github.com/jenkinsci/warnings-ng-plugin/pull/1145/)

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/EB970D1D-DB27-40ED-B1B8-13E395C77F9F%40gmail.com.


Re: ConcurrentModificationException during pipeline serialization (MAX_SURVIVABILITY)

2021-11-17 Thread Ullrich Hafner


> Am 17.11.2021 um 16:36 schrieb 'Devin Nusbaum' via Jenkins Developers 
> :
> 
> > As far as I understood the problem in JENKINS-67145 
> > <https://issues.jenkins.io/browse/JENKINS-67145> my step is somehow 
> > serialized during the execution in lines 205-215.
> 
> Kind of, but I was talking about the publishIssues step, not the 
> scanForIssues step. I think the scanForIssues steps in the parallel branches 
> have already completed when the problem manifests and can be ignored based on 
> the information in the Jira ticket.
> 
> > Or can I view the code in a step as an atomic unit? 
> 
> You only need to worry about the serialized state of the Pipeline, and in 
> this case I think you just need to worry about local variables in the 
> Pipeline (e.g. AnnotatedReport objects returned by scanForIssues) and the 
> StepExecution object for currently-running steps (e.g. publishIssues). Local 
> variables in PublishIssuesStep.Execution.run and other Java code can be 
> ignored. Also, since you are using SynchronousNonBlockingStepExecution, 
> PublishIssuesStep.Execution is not resumable 
> <https://github.com/jenkinsci/workflow-step-api-plugin/blob/58b25c2420773a1a6686da4b87990926cae994e9/src/main/java/org/jenkinsci/plugins/workflow/steps/SynchronousNonBlockingStepExecution.java#L75>
>  and you may as well mark Execution.step as transient (but I don't think that 
> would fix the issue!).
> 

Ah ok, this is what I thought initially.  Then I can continue using my approach 
here :-) I totally misunderstood the problem.

> In your case, I think the main issue is with the AnnotatedReport objects that 
> are returned by scanForIssues that end up being local variables in the 
> Pipeline. You need to be careful about the ways in which you modify those 
> objects in the pubishIssues step, since local Groovy variables are serialized 
> as part of the Pipeline's state, and PublishIssuesStep.Execution.run is 
> running on a background thread. My original message describes the only way 
> that I noticed that publishIssues might modify one of those existing 
> AnnotatedReport objects (on a background thread separate from the CPS VM 
> thread that will serialize the Pipeline) that was returned by a previous 
> scanForIssues step.
> 
> My best guess as to minimally fixing the problem is to introduce a copy 
> constructor for FileStatistics and use it here 
> <https://github.com/jenkinsci/forensics-api-plugin/blob/d0dc4ec448ca6c9a0d5ce8a6d39e238ba07e8c30/src/main/java/io/jenkins/plugins/forensics/miner/RepositoryStatistics.java#L242>
>  like this:
> 
> statisticsMapping.merge(additionalStatistics.getFileName(), new 
> FileStatistics(additionalStatistics), this::merge);
> 
> This way, if one of the FileStatistics from one of the other AnnotatedReport 
> instances returned by a scanIssues step has the same file name, 
> RepositoryStatistics.merge will only end up modifying the copied 
> FileStatistics rather than the original object.
> 

This is the problem, thanks! I thought that I am creating a new object but 
actually I am doing not. I’m changing the existing ones, that is a design flaw 
that I did overlook. I think a simple solution is to create new objects as you 
already mentioned. Thanks!   

> A more robust change would be to make AnnotatedReport and all of its fields 
> (and their fields recursively) immutable like Jesse mentioned.
> 
> On Wed, Nov 17, 2021 at 10:02 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
> 
> 
>> Am 17.11.2021 um 14:42 schrieb 'Jesse Glick' via Jenkins Developers 
>> mailto:jenkinsci-dev@googlegroups.com>>:
>> 
>> On Wed, Nov 17, 2021 at 5:57 AM Ullrich Hafner > <mailto:ullrich.haf...@gmail.com>> wrote:
>> […] is stored in a CopyOnWriteArrayList. If your background thread 
>> serializes my instance during the loop it can happen that the loop variable 
>> is already set, but the list with the results is not.
>> 
>> Hard to follow what you are saying without a code reference, but a 
>> `CopyOnWriteArrayList` is designed to be safe to save from another thread; 
>> that is its whole purpose.
>> 
>> I need some lock around the whole block of variables
>> 
>> Block of fields? Again hard to discuss without a concrete example, but in 
>> general if there is a block of data that should be replaced atomically, best 
>> to keep it all in its own object with `final` fields, and refer to that one 
>> object with a `volatile` field. 
>> 
> 
> Actually I do not have fields anymore in the step:
> https://github.com/jenkinsci/warnings-ng-plugin/blob/089ad6c3aac292bc926503e644b892371f609e88/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps

Re: ConcurrentModificationException during pipeline serialization (MAX_SURVIVABILITY)

2021-11-17 Thread Ullrich Hafner


> Am 17.11.2021 um 14:42 schrieb 'Jesse Glick' via Jenkins Developers 
> :
> 
> On Wed, Nov 17, 2021 at 5:57 AM Ullrich Hafner  <mailto:ullrich.haf...@gmail.com>> wrote:
> […] is stored in a CopyOnWriteArrayList. If your background thread serializes 
> my instance during the loop it can happen that the loop variable is already 
> set, but the list with the results is not.
> 
> Hard to follow what you are saying without a code reference, but a 
> `CopyOnWriteArrayList` is designed to be safe to save from another thread; 
> that is its whole purpose.
> 
> I need some lock around the whole block of variables
> 
> Block of fields? Again hard to discuss without a concrete example, but in 
> general if there is a block of data that should be replaced atomically, best 
> to keep it all in its own object with `final` fields, and refer to that one 
> object with a `volatile` field. 
> 

Actually I do not have fields anymore in the step:
https://github.com/jenkinsci/warnings-ng-plugin/blob/089ad6c3aac292bc926503e644b892371f609e88/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/ScanForIssuesStep.java#L205-L215
 
<https://github.com/jenkinsci/warnings-ng-plugin/blob/089ad6c3aac292bc926503e644b892371f609e88/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/ScanForIssuesStep.java#L205-L215>

As far as I understood the problem in JENKINS-67145 
<https://issues.jenkins.io/browse/JENKINS-67145> my step is somehow serialized 
during the execution in lines 205-215. Or can I view the code in a step as an 
atomic unit? 

> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> <mailto:jenkinsci-dev+unsubscr...@googlegroups.com>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0ouBxhg1arOFwosdrit-O9WdBeiiAbgSAA00%3DPnbBkPQ%40mail.gmail.com
>  
> <https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0ouBxhg1arOFwosdrit-O9WdBeiiAbgSAA00%3DPnbBkPQ%40mail.gmail.com?utm_medium=email_source=footer>.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/80549ED3-122A-49E6-9327-0B2D3A376EB9%40gmail.com.


Re: ConcurrentModificationException during pipeline serialization (MAX_SURVIVABILITY)

2021-11-17 Thread Ullrich Hafner
After thinking about the problem in more detail have an additional question:

I can replace all of those list modifying operations with a 
CopyOnWriteArrayList. What is still not clear for me is, how this works if 
multiple objects are affected? E.g. I have a loop over a number of files that 
should be post-processed. The result of the post-processing is stored in a 
CopyOnWriteArrayList. If your background thread serializes my instance during 
the loop it can happen that the loop variable is already set, but the list with 
the results is not. That means I need some lock around the whole block of 
variables, or how is this handled?

> Am 16.11.2021 um 18:09 schrieb Ullrich Hafner :
> 
> Thanks for this in depth description of the problem! I see how much work is 
> required in order to rewrite that part of the code.
> 
>> Am 16.11.2021 um 17:42 schrieb 'Devin Nusbaum' via Jenkins Developers 
>> mailto:jenkinsci-dev@googlegroups.com>>:
>> 
>> The CPS VM thread is responsible for saving the Pipeline's execution state, 
>> so if you are using a non-blocking step execution (and it looks like you are 
>> <https://github.com/jenkinsci/warnings-ng-plugin/blob/e6f0b7a542d4f10c71b93925eba83e20d7caa95b/plugin/src/main/java/io/jenkins/plugins/analysis/core/steps/AnalysisExecution.java#L26>),
>>  it is possible that your step is executing on a background thread while the 
>> Pipeline program is being saved on the CPS VM thread. You should account for 
>> this in any mutable data reachable from non-blocking step executions that is 
>> part of the execution's serialized state, for example by using 
>> CopyOnWriteArrayList, replacing fields rather than mutating them, using 
>> writeReplace, etc.
>> 
>> The exception in the Jira ticket suggests that one of the objects inside of 
>> one of the AnnotatedReport instances returned by a scanIssues step, which is 
>> stored a local variable in the user's Pipeline, is being modified. Perhaps 
>> the issue is that there is a filename match in the FileStatistics between 
>> the issues collected by the user's different parallel branches, so when this 
>> code 
>> <https://github.com/jenkinsci/forensics-api-plugin/blob/d0dc4ec448ca6c9a0d5ce8a6d39e238ba07e8c30/src/main/java/io/jenkins/plugins/forensics/miner/RepositoryStatistics.java#L242>
>>  runs for the first time inside of AnnotatedReport.addAll in 
>> PublishIssuesStep.Execution.Run it uses the exact FileStatistics instance 
>> from an existing AnnotatedReport instance, but when it runs after that it 
>> modifies the previous FileStatistics instance here 
>> <https://github.com/jenkinsci/forensics-api-plugin/blob/d0dc4ec448ca6c9a0d5ce8a6d39e238ba07e8c30/src/main/java/io/jenkins/plugins/forensics/miner/RepositoryStatistics.java#L256>,
>>  and then since the FileStatistics instance is also reachable via one of the 
>> AnnotatedReport local variables in the Pipeline you have a potential 
>> ConcurrentModificationError depending on the serialization timing.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/56D693ED-8A35-427F-8BDF-AA50057AB7DC%40gmail.com.


  1   2   3   4   5   6   >