Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-18 Thread Alan Bateman
On 18/10/2016 17:43, Mandy Chung wrote: : I agree we should do the validation early. I think this should take the exclude plugins into consideration and whether there is a way to filter out duplicated resource files to allow the image be created. I’m inclinded to keep the current jlink

Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-18 Thread Mandy Chung
> On Oct 18, 2016, at 9:29 AM, Alan Bateman wrote: > > > > On 17/10/2016 19:24, Mandy Chung wrote: >> Updated webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.01/ >> >> This updates the exclude-jmod-section plugin not to filter specific

Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-17 Thread Mandy Chung
Updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.01/ This updates the exclude-jmod-section plugin not to filter specific modules. Also clean up DefaultImageBuilder further and improve the exception message when it detects duplicated resource entries. Mandy >

Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-14 Thread Mandy Chung
> On Oct 14, 2016, at 5:55 AM, Alan Bateman wrote: > > On 13/10/2016 03:22, Mandy Chung wrote: > >> Webrev: >>http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.00/ >> >> Header files and man pages are currently copied to the image. The header >>

Re: Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-14 Thread Alan Bateman
On 13/10/2016 03:22, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.00/ Header files and man pages are currently copied to the image. The header files are modularized and in the following directory: src/$MODULE/share/native/include The man

Review Request: JDK-8167558 Add new JMOD section for header files and man pages

2016-10-12 Thread Mandy Chung
Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8167558/webrev.00/ Header files and man pages are currently copied to the image. The header files are modularized and in the following directory: src/$MODULE/share/native/include The man page for the corresponding tool should also