[GitHub] [kafka] vvcephei commented on pull request #10119: Kip 695 revert

2021-02-11 Thread GitBox
vvcephei commented on pull request #10119: URL: https://github.com/apache/kafka/pull/10119#issuecomment-778006301 Hey @guozhangwang , unfortunately, the revert wasn't clean. I kept the two commits separate (and intend to merge them separately). I'm pretty sure I resolved the

[GitHub] [kafka] vvcephei opened a new pull request #10119: Kip 695 revert

2021-02-11 Thread GitBox
vvcephei opened a new pull request #10119: URL: https://github.com/apache/kafka/pull/10119 Reverts both commits in KIP-695, which is being postponed until after 2.8 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] showuon commented on pull request #10118: KAFKA-10192: increase starting up waiting time

2021-02-11 Thread GitBox
showuon commented on pull request #10118: URL: https://github.com/apache/kafka/pull/10118#issuecomment-777994389 @C0urante @kkonstantine , could you help review this simple PR? Thanks. This is an automated message from the

[GitHub] [kafka] showuon opened a new pull request #10118: KAFKA-10192: increase starting up waiting time

2021-02-11 Thread GitBox
showuon opened a new pull request #10118: URL: https://github.com/apache/kafka/pull/10118 Recently, we saw some errors: `org.opentest4j.AssertionFailedError: Condition not met within timeout 3. Worker did not complete startup in time ==> expected: but was: ` And after

[GitHub] [kafka] dongjinleekr commented on pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #9930: URL: https://github.com/apache/kafka/pull/9930#issuecomment-777990061 Good job, @chia7712! :congratulations: This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2021-02-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283513#comment-17283513 ] Luke Chen commented on KAFKA-10192: --- Error happened in tests in BlockingConnectorTests. ex:

[jira] [Reopened] (KAFKA-10192) Flaky test BlockingConnectorTest#testBlockInConnectorStop

2021-02-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reopened KAFKA-10192: --- Assignee: Luke Chen (was: Chris Egerton) {code:java}

[GitHub] [kafka] cmccabe merged pull request #10114: MINOR: KIP-631 KafkaConfig fixes and improvements

2021-02-11 Thread GitBox
cmccabe merged pull request #10114: URL: https://github.com/apache/kafka/pull/10114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on pull request #10114: MINOR: KIP-631 KafkaConfig fixes and improvements

2021-02-11 Thread GitBox
cmccabe commented on pull request #10114: URL: https://github.com/apache/kafka/pull/10114#issuecomment-777983504 Failing test is `org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationTest.testReplication()` which is not related

[GitHub] [kafka] hongshaoyang opened a new pull request #10117: MINOR: Fix Javadoc strings in Serdes.java

2021-02-11 Thread GitBox
hongshaoyang opened a new pull request #10117: URL: https://github.com/apache/kafka/pull/10117 ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation - [x] Verify test coverage and CI build status - [x] Verify documentation (including upgrade

[GitHub] [kafka] dengziming commented on pull request #10116: MINOR: Add entityType for metadata record definitions

2021-02-11 Thread GitBox
dengziming commented on pull request #10116: URL: https://github.com/apache/kafka/pull/10116#issuecomment-777940172 Hello, @cmccabe PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming opened a new pull request #10116: MINOR: Add entityType for metadata record definitions

2021-02-11 Thread GitBox
dengziming opened a new pull request #10116: URL: https://github.com/apache/kafka/pull/10116 *More detailed description of your change* As title *Summary of testing strategy (including rationale)* QA ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] dengziming commented on a change in pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

2021-02-11 Thread GitBox
dengziming commented on a change in pull request #10097: URL: https://github.com/apache/kafka/pull/10097#discussion_r574955279 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -126,9 +126,16 @@ *gracefully resign from the current epoch.

[GitHub] [kafka] dengziming commented on a change in pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

2021-02-11 Thread GitBox
dengziming commented on a change in pull request #10097: URL: https://github.com/apache/kafka/pull/10097#discussion_r574955279 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -126,9 +126,16 @@ *gracefully resign from the current epoch.

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574942006 ## File path: core/src/main/scala/kafka/server/AutoTopicCreationManager.scala ## @@ -91,11 +91,14 @@ class DefaultAutoTopicCreationManager(

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574941168 ## File path: core/src/main/scala/kafka/server/Server.scala ## @@ -91,4 +95,12 @@ object Server { reporters } + sealed trait

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574940891 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -975,7 +975,7 @@ public void handleClaim(int epoch) {

[GitHub] [kafka] mumrah commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
mumrah commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574930226 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -78,12 +79,17 @@ class SocketServer(val config: KafkaConfig,

[GitHub] [kafka] mjsax commented on pull request #10102: KAFKA-12272: Fix commit-interval metrics

2021-02-11 Thread GitBox
mjsax commented on pull request #10102: URL: https://github.com/apache/kafka/pull/10102#issuecomment-777898035 Merged to `trunk` and cherry-picked to `2.8` branch. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ableegoldman merged pull request #10115: MINOR: set copyright year to 2021

2021-02-11 Thread GitBox
ableegoldman merged pull request #10115: URL: https://github.com/apache/kafka/pull/10115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax merged pull request #10102: KAFKA-12272: Fix commit-interval metrics

2021-02-11 Thread GitBox
mjsax merged pull request #10102: URL: https://github.com/apache/kafka/pull/10102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman opened a new pull request #10115: MINOR: set copyright year to 2021

2021-02-11 Thread GitBox
ableegoldman opened a new pull request #10115: URL: https://github.com/apache/kafka/pull/10115 2020 is over (thank god) so we need to bump the year for the 2.6.2 release This is an automated message from the Apache Git

[GitHub] [kafka] cmccabe opened a new pull request #10114: MINOR: KIP-631 KafkaConfig fixes and improvements

2021-02-11 Thread GitBox
cmccabe opened a new pull request #10114: URL: https://github.com/apache/kafka/pull/10114 Add the new KIP-631 configs to KafkaConfigTest. Rename InitialBrokerRegistrationTimeoutMs to InitialBrokerRegistrationTimeoutMsProp for consistency with the other properties. Add

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-02-11 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574909648 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -237,14 +317,80 @@ class FetchSession(val id: Int, type TL =

[GitHub] [kafka] C0urante commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-02-11 Thread GitBox
C0urante commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-777865163 Yeah, that's fair. I found

[GitHub] [kafka] hachikuji merged pull request #10107: MINOR: Improve confusing admin client shutdown logging

2021-02-11 Thread GitBox
hachikuji merged pull request #10107: URL: https://github.com/apache/kafka/pull/10107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574884637 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -57,15 +57,16 @@ default void handleClaim(int epoch) {} /**

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574884637 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftClient.java ## @@ -57,15 +57,16 @@ default void handleClaim(int epoch) {} /**

[GitHub] [kafka] rondagostino commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574875932 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -160,7 +160,7 @@ class TestRaftServer(

[GitHub] [kafka] cmccabe commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574870941 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -160,7 +160,7 @@ class TestRaftServer(

[GitHub] [kafka] cmccabe commented on a change in pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10113: URL: https://github.com/apache/kafka/pull/10113#discussion_r574870159 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -207,13 +207,17 @@ class DynamicBrokerConfig(private val kafkaConfig:

[GitHub] [kafka] rondagostino opened a new pull request #10113: MINOR: Add KIP-500 Broker

2021-02-11 Thread GitBox
rondagostino opened a new pull request #10113: URL: https://github.com/apache/kafka/pull/10113 THis PR adds the KIP-500 `BrokerServer` class. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[jira] [Commented] (KAFKA-12323) Record timestamps not populated in event

2021-02-11 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283409#comment-17283409 ] Adam Bellemare commented on KAFKA-12323: Hi [~ableegoldman] I am trying to reproduce it all on

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-02-11 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574846728 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-02-11 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r574846728 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +76,25 @@ public FetchSessionHandler(LogContext

[jira] [Updated] (KAFKA-12325) Is Kafka affected by Scala security vulnerability (CVE-2017-15288)?

2021-02-11 Thread John Stacy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Stacy updated KAFKA-12325: --- Summary: Is Kafka affected by Scala security vulnerability (CVE-2017-15288)? (was: Update to

[jira] [Commented] (KAFKA-12323) Record timestamps not populated in event

2021-02-11 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283378#comment-17283378 ] A. Sophie Blee-Goldman commented on KAFKA-12323: Hey [~abellemare], thanks for

[GitHub] [kafka] C0urante commented on pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-02-11 Thread GitBox
C0urante commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-82791 @gharris1727 @tombentley @chia7712 anyone got a moment?  This is an automated message from the Apache Git

[GitHub] [kafka] C0urante opened a new pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-02-11 Thread GitBox
C0urante opened a new pull request #10112: URL: https://github.com/apache/kafka/pull/10112 [Jira](https://issues.apache.org/jira/browse/KAFKA-12226) When a task fails to commit offsets because all outstanding records haven't been ack'd by the broker yet, it's better to retry that

[jira] [Created] (KAFKA-12325) Update to secure versions of scala libraries due to CVE-2017-15288

2021-02-11 Thread John Stacy (Jira)
John Stacy created KAFKA-12325: -- Summary: Update to secure versions of scala libraries due to CVE-2017-15288 Key: KAFKA-12325 URL: https://issues.apache.org/jira/browse/KAFKA-12325 Project: Kafka

[GitHub] [kafka] cmccabe merged pull request #10111: MINOR: Add BrokerMetadataListener

2021-02-11 Thread GitBox
cmccabe merged pull request #10111: URL: https://github.com/apache/kafka/pull/10111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-12324) Upgrade jetty to fix CVE-2020-27218

2021-02-11 Thread John Stacy (Jira)
John Stacy created KAFKA-12324: -- Summary: Upgrade jetty to fix CVE-2020-27218 Key: KAFKA-12324 URL: https://issues.apache.org/jira/browse/KAFKA-12324 Project: Kafka Issue Type: Bug Affects

[GitHub] [kafka] mumrah opened a new pull request #10111: Add BrokerMetadataListener and related classes

2021-02-11 Thread GitBox
mumrah opened a new pull request #10111: URL: https://github.com/apache/kafka/pull/10111 Replaces #10090 This adds BrokerMetadataListener which is responsible for processing metadata records received by the broker when running in Raft mode. This also moves some classes that

[GitHub] [kafka] mumrah closed pull request #10090: Add BrokerMetadataListener and related classes

2021-02-11 Thread GitBox
mumrah closed pull request #10090: URL: https://github.com/apache/kafka/pull/10090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-12323) Record timestamps not populated in event

2021-02-11 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Bellemare updated KAFKA-12323: --- Description: Upgraded a kafka streams application from 2.6.0 to 2.7.0. Noticed that the

[jira] [Created] (KAFKA-12323) Record timestamps not populated in event

2021-02-11 Thread Adam Bellemare (Jira)
Adam Bellemare created KAFKA-12323: -- Summary: Record timestamps not populated in event Key: KAFKA-12323 URL: https://issues.apache.org/jira/browse/KAFKA-12323 Project: Kafka Issue Type: Bug

[GitHub] [kafka] ableegoldman commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-11 Thread GitBox
ableegoldman commented on a change in pull request #10072: URL: https://github.com/apache/kafka/pull/10072#discussion_r574782591 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -32,6 +33,7 @@ public final int topicGroupId; /**

[GitHub] [kafka] ableegoldman commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-11 Thread GitBox
ableegoldman commented on a change in pull request #10072: URL: https://github.com/apache/kafka/pull/10072#discussion_r574781150 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -32,6 +33,7 @@ public final int topicGroupId; /**

[GitHub] [kafka] ableegoldman commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

2021-02-11 Thread GitBox
ableegoldman commented on a change in pull request #10072: URL: https://github.com/apache/kafka/pull/10072#discussion_r574778749 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java ## @@ -32,6 +33,7 @@ public final int topicGroupId; /**

[GitHub] [kafka] aadubey opened a new pull request #10110: KAFKA-12297 - Make MockProducer return RecordMetadata with values as per contract

2021-02-11 Thread GitBox
aadubey opened a new pull request #10110: URL: https://github.com/apache/kafka/pull/10110 This is a simple change to MockProducer as per request in KAFKA-12297. MockProducer currently returns a null RecordMetadata on Exception. The fix will make MockProducer return the right value as

[GitHub] [kafka] cmccabe merged pull request #10093: MINOR: Support Raft-based metadata quorums in system tests

2021-02-11 Thread GitBox
cmccabe merged pull request #10093: URL: https://github.com/apache/kafka/pull/10093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on a change in pull request #10107: MINOR: Improve confusing admin client shutdown logging

2021-02-11 Thread GitBox
hachikuji commented on a change in pull request #10107: URL: https://github.com/apache/kafka/pull/10107#discussion_r574694145 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -657,7 +657,7 @@ public void close(Duration timeout) {

[GitHub] [kafka] hachikuji commented on a change in pull request #10107: MINOR: Improve confusing admin client shutdown logging

2021-02-11 Thread GitBox
hachikuji commented on a change in pull request #10107: URL: https://github.com/apache/kafka/pull/10107#discussion_r574689734 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -756,6 +756,11 @@ protected Node curNode() {

[GitHub] [kafka] chia7712 closed pull request #9686: KAFKA-10804 add more subsets and exclude performance tests

2021-02-11 Thread GitBox
chia7712 closed pull request #9686: URL: https://github.com/apache/kafka/pull/9686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 closed pull request #9864: MINOR: system tests can't parse version of JDK 15

2021-02-11 Thread GitBox
chia7712 closed pull request #9864: URL: https://github.com/apache/kafka/pull/9864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe merged pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
cmccabe merged pull request #10106: URL: https://github.com/apache/kafka/pull/10106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe merged pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

2021-02-11 Thread GitBox
cmccabe merged pull request #10095: URL: https://github.com/apache/kafka/pull/10095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mumrah commented on a change in pull request #10095: MINOR: Introduce the KIP-500 Broker lifecycle manager

2021-02-11 Thread GitBox
mumrah commented on a change in pull request #10095: URL: https://github.com/apache/kafka/pull/10095#discussion_r574644427 ## File path: core/src/main/scala/kafka/server/BrokerLifecycleManager.scala ## @@ -0,0 +1,457 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574639391 ## File path: metadata/src/main/java/org/apache/kafka/metalog/metalog/MetaLogManager.java ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574638269 ## File path: metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574638178 ## File path: metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
cmccabe commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574637676 ## File path: metadata/src/main/java/org/apache/kafka/metalog/metalog/LocalLogManager.java ## @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah commented on a change in pull request #10097: MINOR: Add FetchSnapshot API doc in KafkaRaftClient

2021-02-11 Thread GitBox
mumrah commented on a change in pull request #10097: URL: https://github.com/apache/kafka/pull/10097#discussion_r574630121 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -126,9 +126,16 @@ *gracefully resign from the current epoch. This

[GitHub] [kafka] mumrah commented on a change in pull request #10063: KAFKA-12258: Add support for splitting appending records

2021-02-11 Thread GitBox
mumrah commented on a change in pull request #10063: URL: https://github.com/apache/kafka/pull/10063#discussion_r574622499 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -79,24 +80,69 @@ public BatchAccumulator( } /**

[GitHub] [kafka] mumrah commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
mumrah commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574602989 ## File path: metadata/src/main/java/org/apache/kafka/metadata/BrokerRegistration.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 merged pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

2021-02-11 Thread GitBox
chia7712 merged pull request #9930: URL: https://github.com/apache/kafka/pull/9930 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] dongjinleekr commented on a change in pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

2021-02-11 Thread GitBox
dongjinleekr commented on a change in pull request #9930: URL: https://github.com/apache/kafka/pull/9930#discussion_r574578473 ## File path: streams/test-utils/src/test/java/org/apache/kafka/streams/test/TestRecordTest.java ## @@ -166,6 +166,9 @@ public void

[GitHub] [kafka] rajinisivaram merged pull request #10108: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-11 Thread GitBox
rajinisivaram merged pull request #10108: URL: https://github.com/apache/kafka/pull/10108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-10630) State Directory config could be improved

2021-02-11 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283068#comment-17283068 ] Dongjin Lee commented on KAFKA-10630: - Hi [~vvcephei], I inspected this issue a little bit. If I

[GitHub] [kafka] rondagostino commented on pull request #10105: Kip500 full

2021-02-11 Thread GitBox
rondagostino commented on pull request #10105: URL: https://github.com/apache/kafka/pull/10105#issuecomment-777517133 There are 6 failing tests across these 3 test classes: **kafka.server.KafkaConfigTest** ``` KafkaConfigTest > testFromPropsInvalid() FAILED

[GitHub] [kafka] chia7712 commented on pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

2021-02-11 Thread GitBox
chia7712 commented on pull request #9930: URL: https://github.com/apache/kafka/pull/9930#issuecomment-777505081 @dongjinleekr Please take a look at this comment (https://github.com/apache/kafka/pull/9930#discussion_r561021090)

[GitHub] [kafka] chia7712 commented on a change in pull request #10099: MINOR: Updated the package name to correct one.

2021-02-11 Thread GitBox
chia7712 commented on a change in pull request #10099: URL: https://github.com/apache/kafka/pull/10099#discussion_r574547061 ## File path: core/src/test/scala/integration/kafka/server/IntegrationTestUtils.scala ## @@ -15,7 +15,7 @@ * limitations under the License. */

[GitHub] [kafka] ch4rl353y commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
ch4rl353y commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777482442 alright @dongjinleekr thx for your fast response! we'll keep an eye on this PR :) This is an automated message

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777469267 @ch4rl353y Great. :+1: As soon as I complete the custom release, I will have a look at strimzi docker image. I guess it will take at least one week.

[GitHub] [kafka] ch4rl353y commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
ch4rl353y commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777461164 @dongjinleekr we're using strimzi/kafka / 0.21.0-kafka-2.7.0 Our SCA scanning Tool (JFrog XRay) found this CVE among many others (speaking of third party lib CVEs only).

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777454845 @ch4rl353y which version are you using? I am now working for a customized patch for 2.6.0 and 2.7.0, with docker image.

[GitHub] [kafka] ch4rl353y commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
ch4rl353y commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777453160 Regarding the CVE-2019-17571 from https://issues.apache.org/jira/browse/KAFKA-9366: is there another way to mitigite the risk? we're looking for a temporary solution

[GitHub] [kafka] dongjinleekr commented on pull request #9457: MINOR: Trivial Cleanups

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #9457: URL: https://github.com/apache/kafka/pull/9457#issuecomment-777439755 ping @chia7712 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dongjinleekr commented on pull request #7891: MINOR: Group KafkaController, ReplicaManager metrics in documentation

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #7891: URL: https://github.com/apache/kafka/pull/7891#issuecomment-777439495 Rebased onto the latest trunk. @hachikuji This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr commented on pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #9421: URL: https://github.com/apache/kafka/pull/9421#issuecomment-777437606 Closing for it won't work with Scala 2.12. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dongjinleekr closed pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'

2021-02-11 Thread GitBox
dongjinleekr closed pull request #9421: URL: https://github.com/apache/kafka/pull/9421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dongjinleekr commented on pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #9930: URL: https://github.com/apache/kafka/pull/9930#issuecomment-777435284 ping @chia7712 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dongjinleekr removed a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr removed a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777418543 Retest this please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777418543 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chia7712 commented on a change in pull request #10024: KAFKA-12273 InterBrokerSendThread#pollOnce throws FatalExitError even…

2021-02-11 Thread GitBox
chia7712 commented on a change in pull request #10024: URL: https://github.com/apache/kafka/pull/10024#discussion_r574460737 ## File path: core/src/main/scala/kafka/common/InterBrokerSendThread.scala ## @@ -78,6 +77,9 @@ abstract class InterBrokerSendThread(

[GitHub] [kafka] dongjinleekr removed a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr removed a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777407099 Retest this please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr removed a comment on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr removed a comment on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-739132477 Rebased onto the latest trunk. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-02-11 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-777407099 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dajac merged pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-11 Thread GitBox
dajac merged pull request #9430: URL: https://github.com/apache/kafka/pull/9430 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-11 Thread GitBox
dajac commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-777366970 Failed tests are not related. Merging to trunk. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac removed a comment on pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

2021-02-11 Thread GitBox
dajac removed a comment on pull request #9958: URL: https://github.com/apache/kafka/pull/9958#issuecomment-777366399 Failed tests are not related. Merging to trunk. This is an automated message from the Apache Git Service.

[GitHub] [kafka] dajac commented on pull request #9958: MINOR: Clean up group instance id handling in `GroupCoordinator`

2021-02-11 Thread GitBox
dajac commented on pull request #9958: URL: https://github.com/apache/kafka/pull/9958#issuecomment-777366399 Failed tests are not related. Merging to trunk. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dajac commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

2021-02-11 Thread GitBox
dajac commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-777365424 All the `kafkatest.tests.core.get_offset_shell_test` system tests passed. This is an automated message from the

[GitHub] [kafka] dajac commented on a change in pull request #10107: MINOR: Improve confusing admin client shutdown logging

2021-02-11 Thread GitBox
dajac commented on a change in pull request #10107: URL: https://github.com/apache/kafka/pull/10107#discussion_r57446 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -657,7 +657,7 @@ public void close(Duration timeout) {

[GitHub] [kafka] rondagostino commented on a change in pull request #10106: MINOR: add the MetaLogListener, LocalLogManager, and Controller interface.

2021-02-11 Thread GitBox
rondagostino commented on a change in pull request #10106: URL: https://github.com/apache/kafka/pull/10106#discussion_r574402728 ## File path: metadata/src/main/java/org/apache/kafka/controller/Controller.java ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-10526) Explore performance impact of leader fsync deferral

2021-02-11 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282971#comment-17282971 ] Sagar Rao commented on KAFKA-10526: --- [~hachikuji], I have looked at the codebase and also the KIP-595

[GitHub] [kafka] rajinisivaram commented on pull request #10108: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-11 Thread GitBox
rajinisivaram commented on pull request #10108: URL: https://github.com/apache/kafka/pull/10108#issuecomment-777325634 will run the build once more since both failed last time (unrelated to this PR). This is an automated

[GitHub] [kafka] rajinisivaram merged pull request #10109: KAFKA-12193: Re-resolve IPs after a client disconnects

2021-02-11 Thread GitBox
rajinisivaram merged pull request #10109: URL: https://github.com/apache/kafka/pull/10109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-10383) KTable Join on Foreign key is opinionated

2021-02-11 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282949#comment-17282949 ] Marco Lotz commented on KAFKA-10383: I have just requested confluence access to create the KIP >

[jira] [Assigned] (KAFKA-10383) KTable Join on Foreign key is opinionated

2021-02-11 Thread Marco Lotz (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Lotz reassigned KAFKA-10383: -- Assignee: Marco Lotz > KTable Join on Foreign key is opinionated >

  1   2   >