chia7712 commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608350408
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1385,7 +1385,7 @@ private void
chia7712 opened a new pull request #10498:
URL: https://github.com/apache/kafka/pull/10498
Reference: https://github.com/apache/kafka/pull/10470#discussion_r608347559
This PR includes following task
1. rewrite the checksum of `DumpLogSegments`
2. remove `checksumOrNull`
cmccabe edited a comment on pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#issuecomment-814612546
@ijuma : I added a comment as you suggested.
Thanks for the reviews, @ijuma & @chia7712 .
--
This is an automated message from the Apache Git Service.
To respond
cmccabe merged pull request #10496:
URL: https://github.com/apache/kafka/pull/10496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
cmccabe commented on pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#issuecomment-814612546
I added a comment. Thanks for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608349100
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -208,8 +208,7 @@ public QuorumController build() throws
ijuma commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608348438
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -208,8 +208,7 @@ public QuorumController build() throws
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608347559
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1385,7 +1385,7 @@ private void
chia7712 commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608345818
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1385,7 +1385,7 @@ private void
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608343399
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -1385,7 +1385,7 @@ private void
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608342700
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RecordMetadata.java
##
@@ -42,20 +41,26 @@
private final int
chia7712 commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608341991
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -208,8 +208,7 @@ public QuorumController build() throws
ijuma commented on a change in pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#discussion_r608341480
##
File path: core/src/main/scala/kafka/server/KafkaRequestHandler.scala
##
@@ -64,14 +65,14 @@ class KafkaRequestHandler(id: Int,
req match {
chia7712 commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608332079
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/RecordMetadata.java
##
@@ -42,20 +41,26 @@
private final int
[
https://issues.apache.org/jira/browse/KAFKA-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ketul Gupta reassigned KAFKA-12344:
---
Assignee: Ketul Gupta
> Support SlidingWindows in the Scala API
>
chia7712 commented on a change in pull request #10465:
URL: https://github.com/apache/kafka/pull/10465#discussion_r608328844
##
File path: core/src/test/java/kafka/test/MockController.java
##
@@ -77,8 +82,28 @@ private MockController(Collection initialTopics) {
}
chia7712 commented on a change in pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#discussion_r608321139
##
File path: core/src/main/scala/kafka/server/RequestLocal.scala
##
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on pull request #9229:
URL: https://github.com/apache/kafka/pull/9229#issuecomment-814579521
> Yes, it's worth exploring. I think MemoryPool is intended to be a
thread-safe cache, so it's not trivial, but it may be possible. Are you
interested in looking into that?
Chia-Ping Tsai created KAFKA-12627:
--
Summary: Unify MemoryPool and BufferSupplier
Key: KAFKA-12627
URL: https://issues.apache.org/jira/browse/KAFKA-12627
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10769.
Fix Version/s: 3.0.0
Resolution: Fixed
> Remove
chia7712 merged pull request #9851:
URL: https://github.com/apache/kafka/pull/9851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
chia7712 merged pull request #10389:
URL: https://github.com/apache/kafka/pull/10389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12384.
Fix Version/s: 3.0.0
Resolution: Fixed
> Flaky Test
hachikuji opened a new pull request #10497:
URL: https://github.com/apache/kafka/pull/10497
This patch removes the temporary shim layer we added to bridge the interface
differences between `MetaLogManager` and `RaftClient`.
- Reverse dependency between :raft and :metadata modules.
cmccabe opened a new pull request #10496:
URL: https://github.com/apache/kafka/pull/10496
Move NoOpSnapshotWriter and NoOpSnapshotWriterBuilder out of the test
directory and into the main directory, until we implement the KRaft
integration.
--
This is an automated message from the
Justine Olshan created KAFKA-12626:
--
Summary: RaftClusterTest and ClusterTestExtensionTest failures
Key: KAFKA-12626
URL: https://issues.apache.org/jira/browse/KAFKA-12626
Project: Kafka
ijuma commented on a change in pull request #10393:
URL: https://github.com/apache/kafka/pull/10393#discussion_r608289621
##
File path: raft/src/main/java/org/apache/kafka/raft/CandidateState.java
##
@@ -235,6 +240,15 @@ public int epoch() {
return highWatermark;
ijuma commented on a change in pull request #10393:
URL: https://github.com/apache/kafka/pull/10393#discussion_r608289621
##
File path: raft/src/main/java/org/apache/kafka/raft/CandidateState.java
##
@@ -235,6 +240,15 @@ public int epoch() {
return highWatermark;
dengziming commented on a change in pull request #10393:
URL: https://github.com/apache/kafka/pull/10393#discussion_r608286550
##
File path: raft/src/main/java/org/apache/kafka/raft/CandidateState.java
##
@@ -235,6 +240,15 @@ public int epoch() {
return highWatermark;
[
https://issues.apache.org/jira/browse/KAFKA-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-5146.
Fix Version/s: 3.0.0
Resolution: Fixed
> Kafka Streams: remove compile dependency
mjsax commented on pull request #10131:
URL: https://github.com/apache/kafka/pull/10131#issuecomment-814523321
Thanks for the PR @MarcoLotz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax merged pull request #10131:
URL: https://github.com/apache/kafka/pull/10131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315899#comment-17315899
]
Aviral Srivastava commented on KAFKA-12506:
---
Hi [~ableegoldman] , a test is failing due to
ncliang commented on a change in pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#discussion_r608251616
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java
##
@@ -61,12 +61,24 @@ public Plugins(Map props) {
mageshn commented on a change in pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#discussion_r608248447
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java
##
@@ -61,12 +61,24 @@ public Plugins(Map props) {
ncliang commented on pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#issuecomment-814500889
Thanks for review @mageshn and @gharris1727 . I think I've addressed all
comments. Please take another look?
--
This is an automated message from the Apache Git Service.
To
ncliang commented on a change in pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#discussion_r608245568
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java
##
@@ -61,12 +61,24 @@ public Plugins(Map props) {
jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r605142418
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
jolshan commented on a change in pull request #10282:
URL: https://github.com/apache/kafka/pull/10282#discussion_r608243332
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1892,8 +1892,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog:
guozhangwang commented on a change in pull request #10495:
URL: https://github.com/apache/kafka/pull/10495#discussion_r608230323
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -874,6 +874,7 @@ public void abortTransaction()
mjsax opened a new pull request #10495:
URL: https://github.com/apache/kafka/pull/10495
Call for review @guozhangwang @abbccdda @hachikuji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cmccabe opened a new pull request #10494:
URL: https://github.com/apache/kafka/pull/10494
Implement the existing Kafka replica placement algorithm for KRaft.
This also means implementing rack awareness. Previously, we just chose
replicas randomly in a non-rack-aware fashion. Also,
guozhangwang commented on pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#issuecomment-814481396
@spena could you also take a look at the failed tests and see if they are
related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to
guozhangwang commented on a change in pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#discussion_r608220386
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the
ijuma commented on a change in pull request #10470:
URL: https://github.com/apache/kafka/pull/10470#discussion_r608214927
##
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##
@@ -614,18 +613,3 @@ class NoOpMessageFormatter extends MessageFormatter {
def
ijuma commented on a change in pull request #10445:
URL: https://github.com/apache/kafka/pull/10445#discussion_r608212051
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java
##
@@ -107,7 +108,7 @@ Long checksumOrNull() {
ijuma commented on a change in pull request #10393:
URL: https://github.com/apache/kafka/pull/10393#discussion_r608209771
##
File path: raft/src/main/java/org/apache/kafka/raft/CandidateState.java
##
@@ -235,6 +240,15 @@ public int epoch() {
return highWatermark;
ijuma commented on a change in pull request #10445:
URL: https://github.com/apache/kafka/pull/10445#discussion_r608208702
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java
##
@@ -107,7 +108,7 @@ Long checksumOrNull() {
ijuma commented on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814456621
Thanks for the PR! Looks like the build failed:
> [2021-04-06T20:21:12.201Z] * What went wrong:
>
> [2021-04-06T20:21:12.201Z] A problem occurred evaluating settings
jolshan commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608188681
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##
@@ -113,6 +113,7 @@
static final int
hachikuji commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608187610
##
File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java
##
@@ -113,6 +113,7 @@
static final int
jolshan commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608181552
##
File path: clients/src/main/java/org/apache/kafka/common/Uuid.java
##
@@ -27,6 +27,10 @@
*/
public class Uuid implements Comparable {
+/**
+
jolshan commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608181552
##
File path: clients/src/main/java/org/apache/kafka/common/Uuid.java
##
@@ -27,6 +27,10 @@
*/
public class Uuid implements Comparable {
+/**
+
jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r608180796
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software
jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r608180796
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/SerdeRecordsIterator.java
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software
hachikuji commented on a change in pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#discussion_r608177108
##
File path: clients/src/main/java/org/apache/kafka/common/Uuid.java
##
@@ -27,6 +27,10 @@
*/
public class Uuid implements Comparable {
+/**
[
https://issues.apache.org/jira/browse/KAFKA-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315845#comment-17315845
]
Ismael Juma commented on KAFKA-12383:
-
The PR for this Jira was merged, so I closed it. We should
mjsax opened a new pull request #10493:
URL: https://github.com/apache/kafka/pull/10493
Observed a failing build with
```
Failed to execute goal
org.apache.maven.plugins:maven-archetype-plugin:3.2.0:generate (default-cli) on
project standalone-pom: A Maven project already exists in
jolshan commented on pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#issuecomment-814431608
@hachikuji I wasn't sure if I should mention the metadata topic/KRaft in the
javadoc. I did for now, but let me know if I should change it.
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-12602.
--
Resolution: Fixed
> The LICENSE and NOTICE files don't list everything they should
>
[
https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315841#comment-17315841
]
John Roesler commented on KAFKA-12602:
--
Just filed
John Roesler created KAFKA-12625:
Summary: Fix the NOTICE file
Key: KAFKA-12625
URL: https://issues.apache.org/jira/browse/KAFKA-12625
Project: Kafka
Issue Type: Task
Reporter:
[
https://issues.apache.org/jira/browse/KAFKA-12622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-12622:
-
Description:
In https://issues.apache.org/jira/browse/KAFKA-12602, we manually constructed a
[
https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315839#comment-17315839
]
John Roesler commented on KAFKA-12602:
--
I created subtasks for 2.7 and 2.6.
Also created
[
https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-12602:
-
Fix Version/s: (was: 2.6.2)
(was: 2.7.1)
> The LICENSE and NOTICE
jolshan edited a comment on pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#issuecomment-814417281
@hachikuji we defined it and have a check, but it is internal/private. I can
add a public constant.
--
This is an automated message from the Apache Git Service.
To
John Roesler created KAFKA-12624:
Summary: Fix LICENSE in 2.6
Key: KAFKA-12624
URL: https://issues.apache.org/jira/browse/KAFKA-12624
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315832#comment-17315832
]
Matthias J. Sax commented on KAFKA-12383:
-
Observed a timeout issue
{quote}
John Roesler created KAFKA-12623:
Summary: Fix LICENSE in 2.7
Key: KAFKA-12623
URL: https://issues.apache.org/jira/browse/KAFKA-12623
Project: Kafka
Issue Type: Sub-task
John Roesler created KAFKA-12622:
Summary: Automate LICENCSE file validation
Key: KAFKA-12622
URL: https://issues.apache.org/jira/browse/KAFKA-12622
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jibitesh Prasad updated KAFKA-12621:
Summary: Kafka setup with Zookeeper- specifying an alternate znode creates
the
[
https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315831#comment-17315831
]
Matthias J. Sax commented on KAFKA-9013:
Timeout issue (observed twice):
{quote}
[
https://issues.apache.org/jira/browse/KAFKA-12621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jibitesh Prasad updated KAFKA-12621:
Description:
While configuring kafka with an znode apart from "/", the configuration is
Jibitesh Prasad created KAFKA-12621:
---
Summary: Kafka setup with Zookeeper specifying an alternate znode
as root fails
Key: KAFKA-12621
URL: https://issues.apache.org/jira/browse/KAFKA-12621
jolshan commented on pull request #10492:
URL: https://github.com/apache/kafka/pull/10492#issuecomment-814417281
@hachikuji we defined it and have a check, but it is internal. I can add a
public constant.
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on pull request #9944:
URL: https://github.com/apache/kafka/pull/9944#issuecomment-814408153
currently blocked on https://github.com/apache/kafka/pull/10492
(Need to add topic IDs to the metadata topic for fetching)
--
This is an automated message from the Apache
vvcephei merged pull request #10474:
URL: https://github.com/apache/kafka/pull/10474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
jolshan opened a new pull request #10492:
URL: https://github.com/apache/kafka/pull/10492
KIP-516 introduces topic IDs to topics, but there is a small issue with how
the metadata topic will interact with topic IDs.
For example, https://github.com/apache/kafka/pull/9944 aims to
hachikuji commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r608140887
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -395,31 +393,35 @@ private void resetConnections() {
spena commented on a change in pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#discussion_r608133301
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java
##
@@ -1173,14 +1173,23 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-12620:
-
Issue Type: Improvement (was: New Feature)
> Producer IDs generated by the controller
>
David Arthur created KAFKA-12620:
Summary: Producer IDs generated by the controller
Key: KAFKA-12620
URL: https://issues.apache.org/jira/browse/KAFKA-12620
Project: Kafka
Issue Type: New
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814378302
Full disclosure: I'm an engineer that works for Gradle (on [Gradle
Enterprise](https://gradle.com/), and I found these optimizations while using
the project to test out Gradle
jthurne commented on pull request #10491:
URL: https://github.com/apache/kafka/pull/10491#issuecomment-814377383
@ijuma another one for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jthurne opened a new pull request #10491:
URL: https://github.com/apache/kafka/pull/10491
The Gradle RAT plugin properly declares inputs and outputs and is also
cachable. This also relieves the Kafka developers from maintaining the build
integration with RAT.
The generated RAT
jthurne edited a comment on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814375110
These changes are compatible with Gradle 7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jthurne edited a comment on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814375110
One last comment: these changes should are compatible with Gradle 7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jthurne commented on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814375110
One last comment: these changes should be compatible with Gradle 7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jthurne commented on pull request #10490:
URL: https://github.com/apache/kafka/pull/10490#issuecomment-814374883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
ijuma merged pull request #10485:
URL: https://github.com/apache/kafka/pull/10485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jthurne opened a new pull request #10490:
URL: https://github.com/apache/kafka/pull/10490
Applies various build optimizations to take full advantage of Gradle's
incremental build feature, and Gradle's local build caching feature. The
optimizations will help to reduce build times for
spena commented on a change in pull request #10331:
URL: https://github.com/apache/kafka/pull/10331#discussion_r606336280
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSegmentedBytesStore.java
##
@@ -0,0 +1,57 @@
+/*
+ *
cmccabe commented on a change in pull request #10465:
URL: https://github.com/apache/kafka/pull/10465#discussion_r608067488
##
File path: core/src/test/scala/unit/kafka/server/ControllerApisTest.scala
##
@@ -32,10 +32,13 @@ import org.apache.kafka.common.Uuid.ZERO_UUID
import
cmccabe commented on a change in pull request #10465:
URL: https://github.com/apache/kafka/pull/10465#discussion_r608065815
##
File path: core/src/test/java/kafka/test/MockController.java
##
@@ -77,8 +82,28 @@ private MockController(Collection initialTopics) {
}
cmccabe commented on a change in pull request #10465:
URL: https://github.com/apache/kafka/pull/10465#discussion_r608065053
##
File path: core/src/test/java/kafka/test/MockController.java
##
@@ -77,8 +82,28 @@ private MockController(Collection initialTopics) {
}
satishd commented on pull request #10489:
URL: https://github.com/apache/kafka/pull/10489#issuecomment-814306289
@junrao Raised this PR as you suggested earlier about moving client classes
to a separate module. I created `storage-api` submodule and moved all the
remote storage API classes
satishd opened a new pull request #10489:
URL: https://github.com/apache/kafka/pull/10489
MINOR Moved tiered storage API classes from "clients" module to a new
"storage-api" module.
Created storage and storage-api modules
### Committer Checklist (excluded from commit
[
https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315739#comment-17315739
]
Justine Olshan commented on KAFKA-12457:
I'm going to start with the sentinel ID for now. I'll
chia7712 commented on pull request #10389:
URL: https://github.com/apache/kafka/pull/10389#issuecomment-814296573
> Is the test still flaky with the latest changes?
yep. I loop this patch 100 times and all pass
--
This is an automated message from the Apache Git Service.
To
C0urante commented on pull request #9826:
URL: https://github.com/apache/kafka/pull/9826#issuecomment-814294461
@tombentley any plans to revisit this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
1 - 100 of 165 matches
Mail list logo
