[GitHub] [kafka] lkokhreidze commented on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

2022-03-09 Thread GitBox
lkokhreidze commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-1063755741 @cadonna done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ableegoldman commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823421770 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/RemoveNamedTopologyResult.java ## @@ -52,34 +60,54

[GitHub] [kafka] ableegoldman commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823421009 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -264,48

[GitHub] [kafka] cadonna commented on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

2022-03-09 Thread GitBox
cadonna commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-1063745684 @lkokhreidze Could you please rebase this PR on latest trunk? Some system tests fail probably due to the absence of a fix on the PR branch. -- This is an automated message

[GitHub] [kafka] ableegoldman commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823417406 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -239,12

[GitHub] [kafka] RivenSun2 commented on pull request #11819: MINOR: Optimize the generateFieldToString method of MessageDataGenerator

2022-03-09 Thread GitBox
RivenSun2 commented on pull request #11819: URL: https://github.com/apache/kafka/pull/11819#issuecomment-1063741527 Hi @dajac @cmccabe Could you help to review the PR ? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-13722) Update internal interfaces that use ProcessorContext to use StateStoreContext instead

2022-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13722: Component/s: streams > Update internal interfaces that use ProcessorContext to use

[jira] [Assigned] (KAFKA-8065) Forwarding modified timestamps does not reset timestamp correctly

2022-03-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-8065: -- Assignee: Matthias J. Sax > Forwarding modified timestamps does not reset timestamp

[GitHub] [kafka] guozhangwang commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
guozhangwang commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1063695247 > Anyways I'll push a fix for this, and then we should be good to go  Thanks @wcarlson5 for the report! @ableegoldman please feel free to move on afterwards. --

[GitHub] [kafka] peterwanner commented on pull request #11855: MINOR: Clarify producer batch.size in upgrade docs

2022-03-09 Thread GitBox
peterwanner commented on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1063660862 > @peterwanner , since it's reaching the end of the release. Please let me know if you can't work on it before next weekend. Thank you. @showuon ok I will finish

[GitHub] [kafka] ableegoldman commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1063651734 Ah good catch @wcarlson5 , I need to move the offset reset logic out of the actual `removeNamedTopology` call and make sure we don't block on the offsets being removed

[GitHub] [kafka] wcarlson5 commented on pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
wcarlson5 commented on pull request #11868: URL: https://github.com/apache/kafka/pull/11868#issuecomment-1063618150 `shouldAllowRemovingAndAddingNamedTopologyToRunningApplicationWithMultipleNodesAndResetsOffsets` is deadlocking. We need to be able to have its be async a little or else it

[GitHub] [kafka] guozhangwang commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
guozhangwang commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823308917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -266,46

[GitHub] [kafka] showuon merged pull request #11863: KAFKA-13689: Revert AbstractConfig code changes

2022-03-09 Thread GitBox
showuon merged pull request #11863: URL: https://github.com/apache/kafka/pull/11863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-13717) KafkaConsumer.close throws authorization exception even when commit offsets is empty

2022-03-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13717. --- Fix Version/s: 3.2.0 Assignee: Vincent Jiang Resolution: Fixed >

[GitHub] [kafka] showuon commented on pull request #11855: MINOR: Clarify producer batch.size in upgrade docs

2022-03-09 Thread GitBox
showuon commented on pull request #11855: URL: https://github.com/apache/kafka/pull/11855#issuecomment-1063601218 @peterwanner , since it's reaching the end of the release. Please let me know if you can't work on it before next weekend. Thank you. -- This is an automated message from

[GitHub] [kafka] showuon merged pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
showuon merged pull request #11864: URL: https://github.com/apache/kafka/pull/11864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
showuon commented on pull request #11864: URL: https://github.com/apache/kafka/pull/11864#issuecomment-1063598542 Failed tests are unrelated. ``` Build / PowerPC / kafka.network.SocketServerTest.testIdleConnection() Build / JDK 11 and Scala 2.13 /

[jira] [Commented] (KAFKA-10160) Kafka MM2 consumer configuration

2022-03-09 Thread Harsha Madduri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503939#comment-17503939 ] Harsha Madduri commented on KAFKA-10160: Is there a reason we are holding this from going into

[GitHub] [kafka] showuon commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
showuon commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r823268006 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1000,8 +1000,11 @@ void

[GitHub] [kafka] showuon commented on a change in pull request #11874: Fix typos in configuration docs

2022-03-09 Thread GitBox
showuon commented on a change in pull request #11874: URL: https://github.com/apache/kafka/pull/11874#discussion_r823265635 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -404,8 +404,8 @@

[GitHub] [kafka] showuon edited a comment on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

2022-03-09 Thread GitBox
showuon edited a comment on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-1063569496 I'll start to take a look this week. Sorry for late response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #10802: KAFKA-6718 / Update SubscriptionInfoData with clientTags

2022-03-09 Thread GitBox
showuon commented on pull request #10802: URL: https://github.com/apache/kafka/pull/10802#issuecomment-1063569496 I'll start to take a look this week. Sorry for late. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-13690) Flaky test EosIntegrationTest.shouldWriteLatestOffsetsToCheckpointOnShutdown[at_least_once]

2022-03-09 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503932#comment-17503932 ] Guozhang Wang commented on KAFKA-13690: --- May cover

[GitHub] [kafka] ableegoldman commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823239035 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -266,46

[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-09 Thread GitBox
ableegoldman commented on pull request #11867: URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520672 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman merged pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-09 Thread GitBox
ableegoldman merged pull request #11867: URL: https://github.com/apache/kafka/pull/11867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ableegoldman commented on pull request #11867: KAFKA-12648: fix #getMinThreadVersion and include IOException + topologyName in StreamsException when topology dir cleanup fails

2022-03-09 Thread GitBox
ableegoldman commented on pull request #11867: URL: https://github.com/apache/kafka/pull/11867#issuecomment-1063520314 Found a somewhat more involved bug that was responsible for this test failing, so I opened a second bugfix PR you can find here Without this followup PR, the test

[GitHub] [kafka] lihaosky commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
lihaosky commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r823220988 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,405 @@ +/* + * Licensed to the

[jira] [Comment Edited] (KAFKA-10690) Produce-response delay caused by lagging replica fetch which affects in-sync one

2022-03-09 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503911#comment-17503911 ] Haruki Okada edited comment on KAFKA-10690 at 3/10/22, 12:14 AM: - Thanks

[GitHub] [kafka] guozhangwang commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
guozhangwang commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r823215870 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,405 @@ +/* + * Licensed to

[GitHub] [kafka] vincent81jiang commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
vincent81jiang commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r823215546 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -2483,6 +2483,20 @@ class AuthorizerIntegrationTest

[jira] [Commented] (KAFKA-10690) Produce-response delay caused by lagging replica fetch which affects in-sync one

2022-03-09 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503911#comment-17503911 ] Haruki Okada commented on KAFKA-10690: -- Thanks for the comment.    [~showuon]    > Are you sure

[GitHub] [kafka] guozhangwang commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
guozhangwang commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r823200925 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java ## @@ -0,0 +1,271 @@

[GitHub] [kafka] guozhangwang commented on pull request #11796: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-03-09 Thread GitBox
guozhangwang commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1063494691 cc @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] guozhangwang commented on pull request #11796: KAFKA-13152: Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2022-03-09 Thread GitBox
guozhangwang commented on pull request #11796: URL: https://github.com/apache/kafka/pull/11796#issuecomment-1063494547 Re-triggered jenkins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] wcarlson5 edited a comment on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-09 Thread GitBox
wcarlson5 edited a comment on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1063493748 @vvcephei @cadonna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] wcarlson5 commented on pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-09 Thread GitBox
wcarlson5 commented on pull request #11873: URL: https://github.com/apache/kafka/pull/11873#issuecomment-1063493748 @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] norwood closed pull request #6508: MINOR: replication factor is short

2022-03-09 Thread GitBox
norwood closed pull request #6508: URL: https://github.com/apache/kafka/pull/6508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #11858: [Emit final][3/N] add emit final param to relevant windows

2022-03-09 Thread GitBox
guozhangwang commented on pull request #11858: URL: https://github.com/apache/kafka/pull/11858#issuecomment-1063480596 BTW since this is an API change, I think the above should happen on the email thread than on just this PR as well. So the sooner we put up a KIP for public discussion the

[GitHub] [kafka] joel-hamill opened a new pull request #11874: Fix typos in configuration docs

2022-03-09 Thread GitBox
joel-hamill opened a new pull request #11874: URL: https://github.com/apache/kafka/pull/11874 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Commented] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-09 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503891#comment-17503891 ] Randall Hauch commented on KAFKA-12879: --- The approach we decided to take was to revert the

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

2022-03-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Description: The {{org.apache.kafka.common.security.oauthbearer.secured}} package from KIP-768

[GitHub] [kafka] kirktrue commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-09 Thread GitBox
kirktrue commented on pull request #11811: URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063442392 I have filed KAFKA-13725 to address the package layout bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

2022-03-09 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Description: The {{org.apache.kafka.common.security.oauthbearer.secured}} package from KIP-768

[GitHub] [kafka] wcarlson5 opened a new pull request #11873: MINOR: Revert "KAFKA-13542: add rebalance reason in Kafka Streams (#11804)"

2022-03-09 Thread GitBox
wcarlson5 opened a new pull request #11873: URL: https://github.com/apache/kafka/pull/11873 This reverts commit 2ccc834faa3fffcd5d15d2463aeef3ee6f5cea13. We were seeing serious regressions in our state heavy benchmarks. Not yet sure how this was causing it but reverting it fixed the

[jira] [Created] (KAFKA-13726) Fix Vulnerability CVE-2022-23181 -Upgrade org.apache.tomcat.embed_tomcat-embed-core

2022-03-09 Thread Chris Sabelstrom (Jira)
Chris Sabelstrom created KAFKA-13726: Summary: Fix Vulnerability CVE-2022-23181 -Upgrade org.apache.tomcat.embed_tomcat-embed-core Key: KAFKA-13726 URL: https://issues.apache.org/jira/browse/KAFKA-13726

[jira] [Created] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

2022-03-09 Thread Kirk True (Jira)
Kirk True created KAFKA-13725: - Summary: KIP-768 OAuth code mixes public and internal classes in same package Key: KAFKA-13725 URL: https://issues.apache.org/jira/browse/KAFKA-13725 Project: Kafka

[jira] [Created] (KAFKA-13724) Fix Vulnerability CVE-2021-43859 - Upgrade com.thoughtworks.xstream_xstream

2022-03-09 Thread Chris Sabelstrom (Jira)
Chris Sabelstrom created KAFKA-13724: Summary: Fix Vulnerability CVE-2021-43859 - Upgrade com.thoughtworks.xstream_xstream Key: KAFKA-13724 URL: https://issues.apache.org/jira/browse/KAFKA-13724

[GitHub] [kafka] guozhangwang commented on a change in pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
guozhangwang commented on a change in pull request #11868: URL: https://github.com/apache/kafka/pull/11868#discussion_r823130503 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java ## @@ -266,46

[jira] [Comment Edited] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503865#comment-17503865 ] Chris Egerton edited comment on KAFKA-12879 at 3/9/22, 9:51 PM: Are

[jira] [Comment Edited] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503865#comment-17503865 ] Chris Egerton edited comment on KAFKA-12879 at 3/9/22, 9:50 PM: Are

[jira] [Commented] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-03-09 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503865#comment-17503865 ] Chris Egerton commented on KAFKA-12879: --- Are there any practical use cases for listing the offsets

[jira] [Commented] (KAFKA-13723) max.compaction.lag.ms implemented incorrectly

2022-03-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503854#comment-17503854 ] Jun Rao commented on KAFKA-13723: - [~xiongqiwu] : Thanks for the explanation. Make sense. So, this is

[jira] [Resolved] (KAFKA-13723) max.compaction.lag.ms implemented incorrectly

2022-03-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-13723. - Resolution: Not A Problem > max.compaction.lag.ms implemented incorrectly >

[GitHub] [kafka] rhauch merged pull request #11872: KAFKA-12879: Remove extra sleep

2022-03-09 Thread GitBox
rhauch merged pull request #11872: URL: https://github.com/apache/kafka/pull/11872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rhauch opened a new pull request #11872: KAFKA-12879: Remove extra sleep

2022-03-09 Thread GitBox
rhauch opened a new pull request #11872: URL: https://github.com/apache/kafka/pull/11872 Tests didn't catch the extra sleep kept in #11871 after optimization ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[jira] [Commented] (KAFKA-13723) max.compaction.lag.ms implemented incorrectly

2022-03-09 Thread xiongqi wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503847#comment-17503847 ] xiongqi wu commented on KAFKA-13723: [~junrao]  Hi Jun, this function is supposed to capture

[GitHub] [kafka] rhauch merged pull request #11871: KAFKA-12879: Addendum to reduce flakiness of tests

2022-03-09 Thread GitBox
rhauch merged pull request #11871: URL: https://github.com/apache/kafka/pull/11871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lihaosky commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
lihaosky commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r823057006 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PrefixedWindowKeySchemas.java ## @@ -0,0 +1,405 @@ +/* + * Licensed to the

[GitHub] [kafka] philipnee commented on pull request #11871: Addendum to KAFKA 12879 to fix flaky tests

2022-03-09 Thread GitBox
philipnee commented on pull request #11871: URL: https://github.com/apache/kafka/pull/11871#issuecomment-1063324518 Note: See the commit https://github.com/apache/kafka/commit/28393be6d7416f51eb51f7fe2b075570b45ef09f -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] philipnee opened a new pull request #11871: Addendum to KAFKA 12879 to fix flaky tests

2022-03-09 Thread GitBox
philipnee opened a new pull request #11871: URL: https://github.com/apache/kafka/pull/11871 This is an addendum to the KAFKA12879 to fix the flaky tests introduced in the pull request. - Add an if check to void sleep(0) - Increase timeout in the tests ### Committer Checklist

[jira] [Commented] (KAFKA-13723) max.compaction.lag.ms implemented incorrectly

2022-03-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503813#comment-17503813 ] Jun Rao commented on KAFKA-13723: - [~xiongqiwu] and [~jjkoshy]  : Could you check if this is a real

[jira] [Created] (KAFKA-13723) max.compaction.lag.ms implemented incorrectly

2022-03-09 Thread Jun Rao (Jira)
Jun Rao created KAFKA-13723: --- Summary: max.compaction.lag.ms implemented incorrectly Key: KAFKA-13723 URL: https://issues.apache.org/jira/browse/KAFKA-13723 Project: Kafka Issue Type: Bug

[GitHub] [kafka] guozhangwang commented on a change in pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
guozhangwang commented on a change in pull request #11802: URL: https://github.com/apache/kafka/pull/11802#discussion_r822940645 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java ## @@ -0,0 +1,271 @@

[GitHub] [kafka] junrao commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-09 Thread GitBox
junrao commented on pull request #11811: URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063288699 @kirktrue : We could just make the changes to expose the proper public API and send an update to the original KIP-768 voting thread so that people are aware of the minor public

[GitHub] [kafka] blcksrx commented on pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-09 Thread GitBox
blcksrx commented on pull request #11838: URL: https://github.com/apache/kafka/pull/11838#issuecomment-1063283897 @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-10690) Produce-response delay caused by lagging replica fetch which affects in-sync one

2022-03-09 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503785#comment-17503785 ] Jun Rao commented on KAFKA-10690: - [~ocadaruma] : Thanks for filing the jira. Have you tried enabling

[GitHub] [kafka] rhauch merged pull request #11797: KAFKA-12879: Revert changes from KAFKA-12339 and instead add retry capability to KafkaBasedLog

2022-03-09 Thread GitBox
rhauch merged pull request #11797: URL: https://github.com/apache/kafka/pull/11797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] bbejeck edited a comment on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-09 Thread GitBox
bbejeck edited a comment on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1063212582 @ijuma - that was a while ago I can't remember exactly, but swelling compiler errors is not good. So I think we should go ahead with @lbradstreet's changes. -- This

[GitHub] [kafka] bbejeck commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-09 Thread GitBox
bbejeck commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1063212582 @ijuma - that was a while ago I can't remember exactly, but I think we should go ahead with @lbradstreet's changes. -- This is an automated message from the Apache Git

[jira] [Created] (KAFKA-13722) Update internal interfaces that use ProcessorContext to use StateStoreContext instead

2022-03-09 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13722: - Summary: Update internal interfaces that use ProcessorContext to use StateStoreContext instead Key: KAFKA-13722 URL: https://issues.apache.org/jira/browse/KAFKA-13722

[GitHub] [kafka] guozhangwang commented on pull request #11802: [RFC][1/N]add new RocksDBTimeOrderedWindowStore

2022-03-09 Thread GitBox
guozhangwang commented on pull request #11802: URL: https://github.com/apache/kafka/pull/11802#issuecomment-1063193852 @lihaosky there are some `streams:checkstyleTest` failures in jenkins which should be resolved. Could you take a look into this? -- This is an automated message from

[GitHub] [kafka] kirktrue commented on pull request #11811: (docs) Add JavaDocs for org.apache.kafka.common.security.oauthbearer.secured

2022-03-09 Thread GitBox
kirktrue commented on pull request #11811: URL: https://github.com/apache/kafka/pull/11811#issuecomment-1063190001 No, all of the classes (public and non-public) are in the package together. Separating them out should be trivial from a code standpoint but please advise on what is needed

[GitHub] [kafka] kirktrue edited a comment on pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-09 Thread GitBox
kirktrue edited a comment on pull request #11838: URL: https://github.com/apache/kafka/pull/11838#issuecomment-1063188384 Thanks for the PR! It looks good to me. You need to get a committer to look at this in order to get it merged in. Perhaps a `git blame` can turn up someone who's

[GitHub] [kafka] kirktrue commented on pull request #11838: KAFKA-1372: separate 400 error from 500 error in RestClient

2022-03-09 Thread GitBox
kirktrue commented on pull request #11838: URL: https://github.com/apache/kafka/pull/11838#issuecomment-1063188384 You need to get a committer to look at this for merging. Perhaps a `git blame` can turn up someone who's worked on this that you can ping. -- This is an automated message

[GitHub] [kafka] ijuma commented on pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-09 Thread GitBox
ijuma commented on pull request #11870: URL: https://github.com/apache/kafka/pull/11870#issuecomment-1063182074 @bbejeck Do you recall why we did this originally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-13721) Left-join still emit spurious results in stream-stream joins in some cases

2022-03-09 Thread Nollet (Jira)
Nollet created KAFKA-13721: -- Summary: Left-join still emit spurious results in stream-stream joins in some cases Key: KAFKA-13721 URL: https://issues.apache.org/jira/browse/KAFKA-13721 Project: Kafka

[GitHub] [kafka] lbradstreet opened a new pull request #11870: MINOR: jmh.sh swallows compile errors

2022-03-09 Thread GitBox
lbradstreet opened a new pull request #11870: URL: https://github.com/apache/kafka/pull/11870 jmh.sh runs tasks in quiet mode which swallows compiler errors. This is a pain and I frequently have to edit the shell script to see the error. -- This is an automated message from the Apache

[jira] [Assigned] (KAFKA-8065) Forwarding modified timestamps does not reset timestamp correctly

2022-03-09 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-8065: - Assignee: (was: Josep Prat) > Forwarding modified timestamps does not reset timestamp

[jira] [Assigned] (KAFKA-8065) Forwarding modified timestamps does not reset timestamp correctly

2022-03-09 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-8065: - Assignee: Josep Prat (was: Matthias J. Sax) > Forwarding modified timestamps does not reset

[GitHub] [kafka] dajac commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
dajac commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r822676784 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1000,8 +1000,11 @@ void

[GitHub] [kafka] ijuma merged pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-03-09 Thread GitBox
ijuma merged pull request #11722: URL: https://github.com/apache/kafka/pull/11722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-03-09 Thread GitBox
ijuma commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r822653150 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -448,40 +448,48 @@ public ReadyCheckResult

[GitHub] [kafka] showuon commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
showuon commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r822634915 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1000,8 +1000,11 @@ void

[jira] [Commented] (KAFKA-10690) Produce-response delay caused by lagging replica fetch which affects in-sync one

2022-03-09 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503574#comment-17503574 ] Luke Chen commented on KAFKA-10690: --- [~ocadaruma] , thanks for resporing. One question: Are you sure

[GitHub] [kafka] dajac commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
dajac commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r822622560 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1000,8 +1000,11 @@ void

[GitHub] [kafka] showuon commented on a change in pull request #11864: KAFKA-13717: skip coordinator lookup in commitOffsetsAsync if offsets is empty

2022-03-09 Thread GitBox
showuon commented on a change in pull request #11864: URL: https://github.com/apache/kafka/pull/11864#discussion_r822620734 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1000,8 +1000,11 @@ void

[GitHub] [kafka] soarez commented on pull request #9577: KAFKA-9837: KIP-589 new RPC for notifying controller log dir failure

2022-03-09 Thread GitBox
soarez commented on pull request #9577: URL: https://github.com/apache/kafka/pull/9577#issuecomment-1062889765 @mumrah @hachikuji @bbejeck can anyone review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] abdulshaikh76 commented on pull request #8831: KAFKA-8657:Client-side automatic topic creation on Producer

2022-03-09 Thread GitBox
abdulshaikh76 commented on pull request #8831: URL: https://github.com/apache/kafka/pull/8831#issuecomment-1062882178 is this changes available ? In which version of kafka-client jar ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] sunshujie1990 commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-09 Thread GitBox
sunshujie1990 commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1062864985 @hachikuji Jason, please help to review it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-13720) Few topic partitions remain under replicated after broker lose connectivity to zookeeper

2022-03-09 Thread Dhirendra Singh (Jira)
Dhirendra Singh created KAFKA-13720: --- Summary: Few topic partitions remain under replicated after broker lose connectivity to zookeeper Key: KAFKA-13720 URL: https://issues.apache.org/jira/browse/KAFKA-13720

[jira] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-09 Thread Shujie Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13719 ] Shujie Sun deleted comment on KAFKA-13719: was (Author: sunshujie): https://github.com/apache/kafka/pull/11869 > connector restart cause duplicate tasks >

[jira] [Commented] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-09 Thread Shujie Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503502#comment-17503502 ] Shujie Sun commented on KAFKA-13719: https://github.com/apache/kafka/pull/11869 > connector restart

[jira] [Updated] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-09 Thread Shujie Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shujie Sun updated KAFKA-13719: --- Attachment: (was: image-2022-03-09-18-57-09-467.png) > connector restart cause duplicate tasks

[GitHub] [kafka] sunshujie1990 opened a new pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-09 Thread GitBox
sunshujie1990 opened a new pull request #11869: URL: https://github.com/apache/kafka/pull/11869 When kafka Connect restarts connector with includeTasks=true, DistributedHerder start all task without filter the currentAssignments. This results in duplicate tasks and duplicate data。 --

[jira] [Created] (KAFKA-13719) connector restart cause duplicate tasks

2022-03-09 Thread Shujie Sun (Jira)
Shujie Sun created KAFKA-13719: -- Summary: connector restart cause duplicate tasks Key: KAFKA-13719 URL: https://issues.apache.org/jira/browse/KAFKA-13719 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-13699) ProcessorContext does not expose Stream Time

2022-03-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503493#comment-17503493 ] Mickael Maison commented on KAFKA-13699: Even if it was voted and partly landed in 3.0.0, I

[GitHub] [kafka] mimaison commented on pull request #11817: KAFKA-13438: Replace EasyMock and PowerMock with Mockito in WorkerTest

2022-03-09 Thread GitBox
mimaison commented on pull request #11817: URL: https://github.com/apache/kafka/pull/11817#issuecomment-1062783063 Thanks for the update. There's an unused import that is failing

[GitHub] [kafka] ableegoldman opened a new pull request #11868: KAFKA-12648: fix flaky #shouldAddToEmptyInitialTopologyRemoveResetOffsetsThenAddSameNamedTopologyWithRepartitioning

2022-03-09 Thread GitBox
ableegoldman opened a new pull request #11868: URL: https://github.com/apache/kafka/pull/11868 This test has started to become flaky at a relatively low, but consistently reproducible, rate. Upon inspection, we find this is due to IOExceptions during the #cleanUpNamedTopology call --

  1   2   >