[
https://issues.apache.org/jira/browse/KAFKA-13991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13991:
--
Assignee: dengziming
> Add Admin.updateFeatures() API.
> ---
>
>
dengziming commented on code in PR #12103:
URL: https://github.com/apache/kafka/pull/12103#discussion_r860398372
##
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java:
##
@@ -333,6 +339,34 @@ private void handleCommitImpl(MetadataRecordType type,
ApiMessage
dengziming commented on code in PR #12103:
URL: https://github.com/apache/kafka/pull/12103#discussion_r953285444
##
shell/src/main/java/org/apache/kafka/shell/MetadataNodeManager.java:
##
@@ -333,6 +357,36 @@ private void handleCommitImpl(MetadataRecordType type,
ApiMessage
[
https://issues.apache.org/jira/browse/KAFKA-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13981.
---
Resolution: Duplicate
> metadata shell doesn't recognize some new record types
>
showuon commented on code in PR #12103:
URL: https://github.com/apache/kafka/pull/12103#discussion_r953271661
##
shell/src/test/java/org/apache/kafka/shell/MetadataNodeManagerTest.java:
##
@@ -336,4 +403,43 @@ public void testProducerIdsRecord() {
11000 + "",
showuon closed pull request #12334: KAFKA-13981: Adding new record type handler
in metadata shell
URL: https://github.com/apache/kafka/pull/12334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on PR #12103:
URL: https://github.com/apache/kafka/pull/12103#issuecomment-1225101791
@jsancio , I think we should make this fix into v3.3, WDYT?
@dengziming , could you help confirm if this patch contain all record types
we have now? Thanks.
--
This is an automated
showuon commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953262169
##
raft/src/test/java/org/apache/kafka/raft/LeaderStateTest.java:
##
@@ -302,21 +302,112 @@ public void
testGetNonLeaderFollowersByFetchOffsetDescending() {
}
dengziming commented on PR #12294:
URL: https://github.com/apache/kafka/pull/12294#issuecomment-1225097010
This is an issue of big influence since it will prevent us from upgrading
KRaft cluster, also ping @hachikuji @mumrah
--
This is an automated message from the Apache Git Service.
dengziming opened a new pull request, #12553:
URL: https://github.com/apache/kafka/pull/12553
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
We have
guozhangwang commented on PR #12552:
URL: https://github.com/apache/kafka/pull/12552#issuecomment-1225023208
cc @hachikuji @vcrfxia for reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
guozhangwang opened a new pull request, #12552:
URL: https://github.com/apache/kafka/pull/12552
Our docs for offset retention has been outdated and hence needs to be
updated.
Also I think it's better to indicate how we handle offsets when
delete-topics and delete-groups.
###
hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953193355
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -125,15 +135,15 @@ public long logEndOffset() {
* @return The value of the
jsancio commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953190262
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -125,15 +135,15 @@ public long logEndOffset() {
* @return The value of the
[
https://issues.apache.org/jira/browse/KAFKA-14177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14177:
---
Fix Version/s: 3.3.0
> Correctly support older kraft versions
[
https://issues.apache.org/jira/browse/KAFKA-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13950:
---
Fix Version/s: 3.4.0
(was: 3.3.0)
[
https://issues.apache.org/jira/browse/KAFKA-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio reassigned KAFKA-14178:
--
Assignee: David Arthur
> NoOpRecord incorrectly causes high
mdedetrich commented on PR #12475:
URL: https://github.com/apache/kafka/pull/12475#issuecomment-1224985118
@ijuma So I have some good news, I managed to completely the solve the
underlying problem upstream (see
https://github.com/diffplug/spotless/issues/1273#issuecomment-1224978741). The
hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953181785
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -313,43 +312,70 @@ private ReplicaState getReplicaState(int remoteNodeId) {
return state;
hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953179732
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -359,31 +385,46 @@ private boolean isVoter(int remoteNodeId) {
private static class
hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953178449
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -204,50 +198,80 @@ private boolean updateHighWatermark() {
return false;
}
+
hachikuji commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953176589
##
clients/src/main/java/org/apache/kafka/clients/admin/QuorumInfo.java:
##
@@ -125,15 +135,15 @@ public long logEndOffset() {
* @return The value of the
jsancio commented on code in PR #12548:
URL: https://github.com/apache/kafka/pull/12548#discussion_r953171207
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -313,43 +312,70 @@ private ReplicaState getReplicaState(int remoteNodeId) {
return state;
hachikuji commented on PR #12548:
URL: https://github.com/apache/kafka/pull/12548#issuecomment-1224954292
Just a general note, I'm repurposing this patch as a general cleanup of the
new DescribeQuorum APIs. I changed my mind about `HighWatermarkUpdateTimeMs`. I
think it can be inferred
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r952893463
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583873#comment-17583873
]
Divij Vaidya commented on KAFKA-13950:
--
This is not a release blocking bug. Please feel free to
mumrah opened a new pull request, #12551:
URL: https://github.com/apache/kafka/pull/12551
Adds a simple "deferred" boolean to ControllerWriteEvent which will prevent
the event from updating the controller queue time upon running.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-14178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583854#comment-17583854
]
Colin McCabe commented on KAFKA-14178:
--
it seems like in general, deferred events should not
David Arthur created KAFKA-14178:
Summary: NoOpRecord incorrectly causes high controller queue time
metric
Key: KAFKA-14178
URL: https://issues.apache.org/jira/browse/KAFKA-14178
Project: Kafka
jsancio commented on PR #12550:
URL: https://github.com/apache/kafka/pull/12550#issuecomment-1224875175
> LGTM. We also need to upgrade docs/upgrade.html. Do you plan to do it
separately?
Thank you @dajac . I updated `docs/upgrade.html` in this PR. Can you please
take a look.
--
wcarlson5 commented on code in PR #12549:
URL: https://github.com/apache/kafka/pull/12549#discussion_r952998259
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1575,7 +1576,7 @@ void addTask(final Task task) {
jsancio opened a new pull request, #12550:
URL: https://github.com/apache/kafka/pull/12550
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
cadonna commented on PR #12549:
URL: https://github.com/apache/kafka/pull/12549#issuecomment-1224477175
Call for review: @wcarlson5 @lihaosky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna opened a new pull request, #12549:
URL: https://github.com/apache/kafka/pull/12549
Currently the task manager stores the tasks it manages in an
internally. We recently extracted the code to store and retrieve
tasks into its own class Tasks. However, the task manager creates
C0urante commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1224470640
Yeah, we can make assertions on when/how often `await` is called. If
necessary, we can also manually advance the mock time by invoking `Sleep` on it
in our testing logic when we're
jolshan commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r952935878
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r952935241
##
core/src/test/scala/other/kafka/StressTestLog.scala:
##
@@ -50,7 +50,7 @@ object StressTestLog {
time = time,
maxTransactionTimeoutMs = 5 * 60 * 1000,
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r952934587
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -534,6 +537,9 @@ object KafkaConfig {
val TransactionsAbortTimedOutTransactionCleanupIntervalMsProp =
[
https://issues.apache.org/jira/browse/KAFKA-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583768#comment-17583768
]
Jose Armando Garcia Sancio commented on KAFKA-13950:
Hey [~divijvaidya] , Thanks for
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-6527:
--
Fix Version/s: 3.4.0
(was: 3.3.0)
> Transient
[
https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583765#comment-17583765
]
Jose Armando Garcia Sancio commented on KAFKA-6527:
---
This test is getting skipped.
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-7957:
--
Fix Version/s: 3.4.0
(was: 3.3.0)
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583764#comment-17583764
]
Jose Armando Garcia Sancio commented on KAFKA-7957:
---
This test is currently getting
[
https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-8280:
--
Fix Version/s: 3.4.0
(was: 3.3.0)
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583763#comment-17583763
]
Jose Armando Garcia Sancio commented on KAFKA-8280:
---
This test is currently getting
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13421:
---
Fix Version/s: 3.4.0
(was: 3.3.0)
> Fix
>
[
https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583760#comment-17583760
]
Jose Armando Garcia Sancio commented on KAFKA-13421:
This test is currently getting
[
https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-13736:
---
Fix Version/s: 3.4.0
(was: 3.3.0)
> Flaky
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r952893463
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r952882843
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) {
}
}
yashmayya commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1224289212
>Why construct the latches in Worker? Wouldn't it be cleaner to create them
in the RetryWithToleranceOperator constructor and expose a method in that class
to count down the latch,
divijvaidya commented on PR #12465:
URL: https://github.com/apache/kafka/pull/12465#issuecomment-1224288795
@cadonna requesting your review on this PR related to streams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r952819611
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java:
##
@@ -342,6 +342,7 @@ public void
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r952810999
##
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##
@@ -147,11 +147,14 @@ public ReplicaManagerBuilder setThreadNamePrefix(String
divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r952807299
##
clients/src/main/java/org/apache/kafka/common/network/PlaintextChannelBuilder.java:
##
@@ -54,12 +54,18 @@ public void configure(Map configs) throws
mimaison merged PR #12473:
URL: https://github.com/apache/kafka/pull/12473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #12473:
URL: https://github.com/apache/kafka/pull/12473#issuecomment-1224259431
Tests passed locally, the CI failure `KRaftClusterTest >
testCreateClusterAndCreateListDeleteTopic() FAILED` is unrelated. Merging to
trunk.
--
This is an automated message from the
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952781430
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private
Colin McCabe created KAFKA-14177:
Summary: Correctly support older kraft versions without
FeatureLevelRecord
Key: KAFKA-14177
URL: https://issues.apache.org/jira/browse/KAFKA-14177
Project: Kafka
mimaison commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952775683
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private
C0urante commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1224225930
Why construct the latches in `Worker`? Wouldn't it be cleaner to create them
in the `RetryWithToleranceOperator` constructor and expose a method in that
class to count down the latch,
[
https://issues.apache.org/jira/browse/KAFKA-14160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14160.
Fix Version/s: 3.4.0
Reviewer: Chris Egerton
Resolution: Fixed
>
mimaison merged PR #12536:
URL: https://github.com/apache/kafka/pull/12536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on code in PR #12536:
URL: https://github.com/apache/kafka/pull/12536#discussion_r952748560
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##
@@ -306,6 +310,35 @@ protected static ConfigDef baseConfigDef() {
Mickael Maison created KAFKA-14176:
--
Summary: Reduce visibility of WorkerConfig.lookupKafkaClusterId
Key: KAFKA-14176
URL: https://issues.apache.org/jira/browse/KAFKA-14176
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya reassigned KAFKA-13952:
--
Assignee: Yash Mayya
> Infinite retry timeout is not working
>
[
https://issues.apache.org/jira/browse/KAFKA-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14134:
---
Reviewer: Chris Egerton
> Replace EasyMock with Mockito for WorkerConnectorTest
>
[
https://issues.apache.org/jira/browse/KAFKA-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14012:
--
Reviewer: Chris Egerton
> passing a "method" into the `Utils.closeQuietly` method cause NPE
>
[
https://issues.apache.org/jira/browse/KAFKA-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14007:
--
Reviewer: Chris Egerton
> Connect header converters are never closed
>
[
https://issues.apache.org/jira/browse/KAFKA-14095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14095:
--
Reviewer: Chris Egerton
> Improve handling of sync offset failures in MirrorMaker
>
[
https://issues.apache.org/jira/browse/KAFKA-13809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13809:
--
Reviewer: Chris Egerton
> FileStreamSinkConnector and FileStreamSourceConnector should
[
https://issues.apache.org/jira/browse/KAFKA-13971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-13971.
---
Fix Version/s: 3.4.0
Reviewer: Chris Egerton
Resolution: Fixed
> Atomicity
[
https://issues.apache.org/jira/browse/KAFKA-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14147:
--
Reviewer: Chris Egerton
> Some map objects in KafkaConfigBackingStore grow in size
[
https://issues.apache.org/jira/browse/KAFKA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583654#comment-17583654
]
Chris Egerton commented on KAFKA-14162:
---
It was noted during PR review that we also add immutable
C0urante merged PR #12502:
URL: https://github.com/apache/kafka/pull/12502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14162:
--
Summary: HoistField and MaskField SMTs should not return immutable
maps/lists (was:
C0urante commented on code in PR #12536:
URL: https://github.com/apache/kafka/pull/12536#discussion_r952686683
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##
@@ -306,6 +310,35 @@ protected static ConfigDef baseConfigDef() {
C0urante commented on code in PR #12536:
URL: https://github.com/apache/kafka/pull/12536#discussion_r952685256
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##
@@ -409,6 +412,13 @@ public String groupId() {
return null;
}
+
mimaison commented on PR #12504:
URL: https://github.com/apache/kafka/pull/12504#issuecomment-1224110047
@cmccabe @mumrah Can you take a look at this and confirm this makes sense?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yashmayya commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1224095732
Thanks @C0urante, that makes sense. I think we can maintain a
`Map` in the `Worker` class (let's say
`taskCancelLatch`) which gets populated in the task builder (with the
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952631224
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -556,28 +473,24 @@ public void
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952630756
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -556,28 +473,24 @@ public void
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952614033
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private
mdedetrich commented on code in PR #12534:
URL: https://github.com/apache/kafka/pull/12534#discussion_r952585957
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -78,18 +78,18 @@ class ControllerServer(
val awaitShutdownCond = lock.newCondition()
var
yashmayya commented on code in PR #11890:
URL: https://github.com/apache/kafka/pull/11890#discussion_r952576537
##
docs/connect.html:
##
@@ -283,7 +283,7 @@ REST
API
ssl.client.auth
-The REST API is used not only by users to monitor / manage Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14133:
---
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14133:
---
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952566247
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -412,38 +334,32 @@ public void testBuildRestartPlanForNoRestart() {
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952561099
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private
[
https://issues.apache.org/jira/browse/KAFKA-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-13060:
-
Fix Version/s: 3.4.0
> Replace EasyMock and PowerMock with Mockito in
mimaison commented on code in PR #12534:
URL: https://github.com/apache/kafka/pull/12534#discussion_r952554375
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -78,18 +78,18 @@ class ControllerServer(
val awaitShutdownCond = lock.newCondition()
var
mimaison commented on code in PR #12536:
URL: https://github.com/apache/kafka/pull/12536#discussion_r952552570
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##
@@ -409,6 +412,13 @@ public String groupId() {
return null;
}
+
divijvaidya commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952546082
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -236,31 +200,21 @@ public void connectorStatus() {
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952469065
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952467932
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1223889368
Thanks @dengziming for the review.
@jsancio could you please have a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952440600
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952440334
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
dengziming commented on PR #12548:
URL: https://github.com/apache/kafka/pull/12548#issuecomment-1223860360
> Also, some `MetadataQuorumCommandTest` tests failed due to this change.
FYI.
This is a very simple problem, we changed the output of the tool so the
assertion in the test
divijvaidya commented on code in PR #12459:
URL: https://github.com/apache/kafka/pull/12459#discussion_r952411639
##
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java:
##
@@ -279,449 +310,335 @@ public void
1 - 100 of 113 matches
Mail list logo
