dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023606759
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023604793
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023605151
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java:
##
@@ -28,9 +28,15 @@ public class JoinGroupResponse extends AbstractResponse {
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1021208132
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023603789
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
dajac commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023603444
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ private def
[
https://issues.apache.org/jira/browse/KAFKA-14088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634689#comment-17634689
]
Gao Fei commented on KAFKA-14088:
-
Is it the following question? Here only the version above 2.8 is
showuon commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1316428275
Yes, I have the same thought as Chris. Besides, this bug already exist for a
long long time, it's not that urgent to put it into 3.3. So, let's keep it in
3.4 (trunk branch), which is
jeffkbkim commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023478149
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
NLincoln opened a new pull request, #12863:
URL: https://github.com/apache/kafka/pull/12863
Wanted to try contributing a patch, so here I am :). I noticed that the jira
was already assigned, but hadn't had some activity for a bit, so I figured I'd
give it a try.
This technically
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1316320428
I think 3.4 release is also around the corner(few weeks maybe?). Would it
better to have it in 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the
philipnee opened a new pull request, #12862:
URL: https://github.com/apache/kafka/pull/12862
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
C0urante commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1316289378
@showuon I was thinking about it--IMO the additional complexity here is a
little too risky to backport but I'm almost on the fence here. If you'd like to
see it on 3.3 I wouldn't be
ableegoldman commented on PR #12809:
URL: https://github.com/apache/kafka/pull/12809#issuecomment-1316265528
Oh I just missed that -- if you wouldn't mind backporting it yourself I
would appreciate it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1316140226
One question to @C0urante , do you think we should backport to v3.3 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1316138924
Yeah!!! Thank you @vamossagar12 @C0urante ! Nice team work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gharris1727 commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1023397678
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -43,10 +43,38 @@
import java.util.concurrent.ExecutionException;
gharris1727 commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1023397291
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -43,10 +43,38 @@
import java.util.concurrent.ExecutionException;
mjsax commented on code in PR #12861:
URL: https://github.com/apache/kafka/pull/12861#discussion_r1023379924
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamNewProcessorApiTest.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634565#comment-17634565
]
Jeff Kim commented on KAFKA-14379:
--
sorry for that. got an error when i clicked on create
> consumer
cmccabe commented on PR #12856:
URL: https://github.com/apache/kafka/pull/12856#issuecomment-1315975187
Thanks again for tackling this, @rondagostino . I think this change is
getting a bit too big, though. I'd really suggest just overriding
`request.timeout.ms` in the specific case where
cmccabe commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023331930
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -91,7 +91,8 @@ object AlterPartitionManager {
config = config,
channelName =
cmccabe commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023331930
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -91,7 +91,8 @@ object AlterPartitionManager {
config = config,
channelName =
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023316404
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -283,7 +283,8 @@ class KafkaServer(
config = config,
channelName =
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023315754
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -282,8 +307,9 @@ class BrokerToControllerRequestThread(
config: KafkaConfig,
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023303714
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -319,7 +345,7 @@ class BrokerToControllerRequestThread(
val requestIter =
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023302354
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -211,7 +235,7 @@ class BrokerToControllerChannelManagerImpl(
50,
[
https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-14360.
-
Resolution: Fixed
> Documentation: Streams Security page has broken links
>
mjsax commented on PR #12857:
URL: https://github.com/apache/kafka/pull/12857#issuecomment-1315888651
Thanks for the PR. Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax merged PR #12857:
URL: https://github.com/apache/kafka/pull/12857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante merged PR #12418:
URL: https://github.com/apache/kafka/pull/12418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #12418:
URL: https://github.com/apache/kafka/pull/12418#issuecomment-1315887569
The single test failure is unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-12495.
---
Resolution: Fixed
> Unbalanced connectors/tasks distribution will happen in Connect's
[
https://issues.apache.org/jira/browse/KAFKA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-13764:
--
Fix Version/s: 3.4.0
> Potential improvements for Connect incremental rebalancing logic
>
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023275236
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
[
https://issues.apache.org/jira/browse/KAFKA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634532#comment-17634532
]
Chris Egerton edited comment on KAFKA-13764 at 11/15/22 9:27 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634532#comment-17634532
]
Chris Egerton commented on KAFKA-13764:
---
Addressed in
[
https://issues.apache.org/jira/browse/KAFKA-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-13764.
---
Resolution: Fixed
> Potential improvements for Connect incremental rebalancing logic
>
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12495:
--
Fix Version/s: 3.4.0
> Unbalanced connectors/tasks distribution will happen in Connect's
bbejeck commented on PR #12861:
URL: https://github.com/apache/kafka/pull/12861#issuecomment-1315883975
\cc @jeqo for review as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
C0urante merged PR #12561:
URL: https://github.com/apache/kafka/pull/12561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023272558
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
C0urante commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315882758
The single test failure is unrelated. Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023271511
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023263070
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023270208
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2524,196 +2528,166 @@ class KafkaApisTest {
assertEquals(MemoryRecords.EMPTY,
[
https://issues.apache.org/jira/browse/KAFKA-14325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634529#comment-17634529
]
Jorge Esteban Quilcate Otoya commented on KAFKA-14325:
--
Hi there. Of course,
[
https://issues.apache.org/jira/browse/KAFKA-14360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634527#comment-17634527
]
Shay Lin commented on KAFKA-14360:
--
Thanks [~ableegoldman]. Here is an PR to fix this broken link
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023263070
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-14388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634526#comment-17634526
]
Bill Bejeck commented on KAFKA-14388:
-
PR with details of the bug
bbejeck opened a new pull request, #12861:
URL: https://github.com/apache/kafka/pull/12861
With the addition of the new Processor API the newly added
`FixedKeyProcessorNodeFactory` extends the `ProcessorNodeFactory` class. The
`ProcessorNodeFactory` had a private field `Set
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023261160
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ private def
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023258771
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java:
##
@@ -28,9 +28,15 @@ public class JoinGroupResponse extends AbstractResponse {
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023212872
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java:
##
@@ -28,9 +28,15 @@ public class JoinGroupResponse extends AbstractResponse {
jeqo opened a new pull request, #12859:
URL: https://github.com/apache/kafka/pull/12859
Changes:
- [x] Enable DEBUG log level to trigger exception
- [ ] Handle null processor supplier
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or
philipnee commented on code in PR #12832:
URL: https://github.com/apache/kafka/pull/12832#discussion_r1023219364
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -47,7 +47,7 @@
import java.util.function.Predicate;
import
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023212872
##
clients/src/main/java/org/apache/kafka/common/requests/JoinGroupResponse.java:
##
@@ -28,9 +28,15 @@ public class JoinGroupResponse extends AbstractResponse {
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315804689
error from `testAlterReplicaLogDirs(String)`:
```
[2022-11-15 10:24:37,184] ERROR [ReplicaFetcher replicaId=2, leaderId=0,
fetcherId=0] Unexpected error occurred while processing
dajac opened a new pull request, #12858:
URL: https://github.com/apache/kafka/pull/12858
This patch adds `deleteGroups` to the new `GroupCoordinator` interface and
updates `KafkaApis` to use it.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023210180
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1646,73 +1649,46 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ private def
kirktrue commented on PR #12832:
URL: https://github.com/apache/kafka/pull/12832#issuecomment-1315798716
@vvcephei @hachikuji @philipnee: I'm asserting that the test failures are
unrelated to this change. CMIIW.
Thanks!
--
This is an automated message from the Apache Git Service.
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023204927
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -22,9 +22,8 @@ import java.util
import java.util.concurrent.atomic.AtomicBoolean
import
jolshan commented on code in PR #12845:
URL: https://github.com/apache/kafka/pull/12845#discussion_r1023204927
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -22,9 +22,8 @@ import java.util
import java.util.concurrent.atomic.AtomicBoolean
import
pprovenzano commented on PR #12843:
URL: https://github.com/apache/kafka/pull/12843#issuecomment-1315793588
I see some failed tests that seem to be flaky tests. What do we do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pprovenzano commented on code in PR #12843:
URL: https://github.com/apache/kafka/pull/12843#discussion_r1023201355
##
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##
@@ -200,11 +150,23 @@ abstract class EndToEndAuthorizationTest extends
pprovenzano commented on PR #12843:
URL: https://github.com/apache/kafka/pull/12843#issuecomment-1315791640
The test `DelegationTokenEndToEndAuthorizationWithOwnerTest` inherits from
`DelegationTokenEndToEndAuthorizationTest` which I've updated. Neither test
needs to work in KRAFT mode
pprovenzano commented on code in PR #12843:
URL: https://github.com/apache/kafka/pull/12843#discussion_r1023195105
##
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##
@@ -64,15 +63,10 @@ import scala.jdk.CollectionConverters._
* SaslTestHarness
[
https://issues.apache.org/jira/browse/KAFKA-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy resolved KAFKA-14309.
Resolution: Fixed
> Kafka Streams upgrade tests do not cover for FK-joins
>
lqxshay opened a new pull request, #12857:
URL: https://github.com/apache/kafka/pull/12857
https://issues.apache.org/jira/browse/KAFKA-14360
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
C0urante commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315723471
Thanks @vamossagar12. I've run the tests locally and they've succeeded; will
wait to see what happens with CI but I think this should be okay.
--
This is an automated message from the
C0urante commented on code in PR #12233:
URL: https://github.com/apache/kafka/pull/12233#discussion_r1023143304
##
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##
@@ -142,26 +142,40 @@ public static String randomString(final int len) {
}
/**
- *
omkreddy commented on PR #12843:
URL: https://github.com/apache/kafka/pull/12843#issuecomment-1315720121
looks like we also need to update
`DelegationTokenEndToEndAuthorizationWithOwnerTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please
omkreddy commented on code in PR #12843:
URL: https://github.com/apache/kafka/pull/12843#discussion_r1023127960
##
core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala:
##
@@ -200,11 +150,23 @@ abstract class EndToEndAuthorizationTest extends
cmccabe commented on PR #12856:
URL: https://github.com/apache/kafka/pull/12856#issuecomment-1315706091
`controller.socket.timeout.ms` is not really the right thing here: that is
used by the old ZK based controller to control timeouts for its outbound
requests.
In the short term,
jsancio commented on PR #12856:
URL: https://github.com/apache/kafka/pull/12856#issuecomment-1315702080
@rondagostino should we include this fix in 3.3.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jsancio commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023111417
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl(
50,
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634471#comment-17634471
]
Ron Dagostino commented on KAFKA-14392:
---
One possibility is to continue to use
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Summary: KRaft broker heartbeat timeout should not exceed
broker.session.timeout.ms (was:
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315690896
Thanks @C0urante . i have added back the merge commit and pushed here along
with fixing the checkstyle. I ran the tests locally and a few MM related ones
failed.
--
This is an
rondagostino commented on code in PR #12856:
URL: https://github.com/apache/kafka/pull/12856#discussion_r1023103733
##
core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala:
##
@@ -211,7 +211,7 @@ class BrokerToControllerChannelManagerImpl(
50,
José Armando García Sancio created KAFKA-14393:
--
Summary: Change default size based retention for the cluster
metadata partition
Key: KAFKA-14393
URL:
[
https://issues.apache.org/jira/browse/KAFKA-14307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-14307:
--
Assignee: Colin McCabe (was: José Armando García Sancio)
>
[
https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reassigned KAFKA-14323:
--
Assignee: Colin McCabe (was: José Armando García Sancio)
>
[
https://issues.apache.org/jira/browse/KAFKA-14320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14320:
---
Fix Version/s: 3.4.0
3.3.2
rondagostino opened a new pull request, #12856:
URL: https://github.com/apache/kafka/pull/12856
KRaft brokers maintain their liveness in the cluster by sending
BROKER_HEARTBEAT requests to the active controller; the active controller
fences a broker if it doesn't receive a heartbeat
C0urante commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315647630
@vamossagar12 It looks like the commit is still present in GitHub:
https://github.com/vamossagar12/kafka/tree/422c81fc0a2dd19fee0ed1eb033ef35fc9e27ba1
Can you fetch that commit
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315612700
@C0urante , i did that but looks like my force push cleaned up the PR merge
since I didn't pull the latest :( I see you have deleted the branch. Would it
be possible to create
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1023036927
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -30,17 +30,16 @@
import
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1023035464
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java:
##
@@ -134,7 +134,7 @@ public void configure(final WorkerConfig config)
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1023035089
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -105,33 +112,58 @@ public class KafkaOffsetBackingStoreTest {
clolov commented on code in PR #12418:
URL: https://github.com/apache/kafka/pull/12418#discussion_r1023034803
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStoreTest.java:
##
@@ -385,114 +377,64 @@ public void testSetFailure() throws
jeffkbkim commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315591807
@dajac my bad, i was looking at the wrong test. it's related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
C0urante commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315589024
@vamossagar12 the build is failing with a Checkstyle error; can you take a
look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dajac commented on PR #12783:
URL: https://github.com/apache/kafka/pull/12783#issuecomment-1315579909
@jeffkbkim `testAlterReplicaLogDirs(String)` has failed in the last few
builds. I don't see the same in other PRs. Are you sure that it is not related?
I haven't had the time to
Ron Dagostino created KAFKA-14392:
-
Summary: KRaft should comment controller.socket.timeout.ms <=
broker.session.timeout.ms
Key: KAFKA-14392
URL: https://issues.apache.org/jira/browse/KAFKA-14392
vamossagar12 commented on PR #12826:
URL: https://github.com/apache/kafka/pull/12826#issuecomment-1315551866
hey @gharris1727 , did you get a chance to read my comments above? Do you
think it's something worthy of perceiving further?
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-14357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14357:
--
Assignee: Mickael Maison
> Make it possible to batch describe requests in the Kafka
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1315549977
@C0urante , you want to take a final pass on this one whenever you get the
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-7206.
---
Fix Version/s: 3.0.0
Resolution: Duplicate
Duplicate of
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r1022991333
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java:
##
@@ -270,7 +270,6 @@ public void
1 - 100 of 131 matches
Mail list logo
