Re: [PR] KAFKA-14262: Deletion of MirrorMaker v1 deprecated classes & tests [kafka]

2024-08-15 Thread via GitHub
abhi-ksolves commented on code in PR #16879: URL: https://github.com/apache/kafka/pull/16879#discussion_r1719430641 ## docs/upgrade.html: ## @@ -845,7 +845,7 @@ Notable changes in 3 DefaultReplicationPolicy, cannot prevent replication cycles based on topic names, so ta

Re: [PR] KAFKA-17342: Moved common coordinator code to separate module. [kafka]

2024-08-15 Thread via GitHub
smjn commented on code in PR #16883: URL: https://github.com/apache/kafka/pull/16883#discussion_r1719402485 ## checkstyle/import-control-coordinator-common.xml: ## @@ -0,0 +1,78 @@ +http://www.puppycrawl.com/dtds/import_control_1_1.dtd";> + + + + + + + + + +

Re: [PR] KAFKA-17342: Moved common coordinator code to separate module. [kafka]

2024-08-15 Thread via GitHub
smjn commented on PR #16883: URL: https://github.com/apache/kafka/pull/16883#issuecomment-2292901492 > You also might want to consider correcting suppressions.xml to have classes under coordinator-runtime classification. Though it doesn't make any logical difference but just categorization.

Re: [PR] KAFKA-17331: Throw UnsupportedVersionException if the data in ListOffsetRequest does NOT fit EarliestLocalSpec and LatestTieredSpec. [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16876: URL: https://github.com/apache/kafka/pull/16876#discussion_r1719310204 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -65,7 +66,8 @@ public static Builder forReplica(short allowedVersion, int rep

Re: [PR] KAFKA-17331: Throw UnsupportedVersionException if the data in ListOffsetRequest does NOT fit EarliestLocalSpec and LatestTieredSpec. [kafka]

2024-08-15 Thread via GitHub
frankvicky commented on code in PR #16876: URL: https://github.com/apache/kafka/pull/16876#discussion_r1719302439 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -95,13 +96,33 @@ public Builder setTargetTimes(List topics) { @O

[jira] [Comment Edited] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2024-08-15 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874096#comment-17874096 ] kangning.li edited comment on KAFKA-13588 at 8/16/24 2:12 AM:

[jira] [Comment Edited] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2024-08-15 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874096#comment-17874096 ] kangning.li edited comment on KAFKA-13588 at 8/16/24 2:12 AM:

[jira] [Commented] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2024-08-15 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874096#comment-17874096 ] kangning.li commented on KAFKA-13588: - Hello [~wcarlson5] , I'm interested in this i

Re: [PR] KAFKA-17169: Add an EndpointsTest suite that test all of the public methods [kafka]

2024-08-15 Thread via GitHub
masonyc commented on PR #16659: URL: https://github.com/apache/kafka/pull/16659#issuecomment-2292596008 Thanks @jsancio @OmniaGM for looking into it. Please let me know if I need to update anything. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
m1a2st commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1719155161 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameterized

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
m1a2st commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1719154640 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -35,11 +36,18 @@ class ListOffsetsRequestTest extends BaseRequestTest { val topic = "to

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719113243 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java: ## @@ -53,11 +54,15 @@ public static Builder forMagic(byte magic, ProduceRequestData dat

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719109197 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -368,15 +369,21 @@ public synchronized TransactionalRequestResult s

[jira] [Commented] (KAFKA-17352) Upgrade Gradle Enterprise to develocity plugin

2024-08-15 Thread Clay Johnson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874076#comment-17874076 ] Clay Johnson commented on KAFKA-17352: -- I will submit a PR for this change. I’m wor

[jira] [Commented] (KAFKA-17338) ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

2024-08-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874075#comment-17874075 ] Kirk True commented on KAFKA-17338: --- [~m1a2st]—sounds good! Thanks! > ConsumerConfig

[jira] [Commented] (KAFKA-16221) IllegalStateException from Producer

2024-08-15 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874074#comment-17874074 ] Kirk True commented on KAFKA-16221: --- I'm working in this area of invalid transaction s

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719089935 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -980,6 +998,49 @@ void handleCoordinatorReady() { n

[jira] [Commented] (KAFKA-17339) LocalLogManager should support RaftClient#schedulePreparedAppend

2024-08-15 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874072#comment-17874072 ] TaiJuWu commented on KAFKA-17339: - Hi [~jsancio] , Sorry for late response. Thanks for y

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
CalvinConfluent commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719072601 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -86,7 +86,7 @@ class AddPartitionsToTxnManager( private val verificationFailureRat

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
CalvinConfluent commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719071137 ## clients/src/main/java/org/apache/kafka/common/requests/TxnOffsetCommitRequest.java: ## @@ -93,7 +118,8 @@ public TxnOffsetCommitRequest build(short version)

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
CalvinConfluent commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719070513 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -980,6 +998,49 @@ void handleCoordinatorReady() {

Re: [PR] KAFKA-14563: RemoveClient-Side AddPartitionsToTxn Requests [kafka]

2024-08-15 Thread via GitHub
CalvinConfluent commented on code in PR #16840: URL: https://github.com/apache/kafka/pull/16840#discussion_r1719069953 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -980,6 +998,49 @@ void handleCoordinatorReady() {

Re: [PR] KAFKA-17294: Handle retriable errors when fetching offsets in new consumer [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2292360761 > you refer to the case that the maybeExpire will complete the future exceptionally, so if ever we get a response and attempt to complete the request it won't take effect because the fut

Re: [PR] KAFKA-17346: Refactored share session classes to server module [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on PR #16888: URL: https://github.com/apache/kafka/pull/16888#issuecomment-2292350375 > > @apoorvmittal10 thanks for the patch! Moving out of `:core` makes good sense to me. > > WDYT about putting the new share partition code into a new `:share` module instead of

Re: [PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
jsancio commented on code in PR #16892: URL: https://github.com/apache/kafka/pull/16892#discussion_r1719044640 ## raft/src/main/java/org/apache/kafka/raft/internals/VoterSetHistory.java: ## @@ -83,13 +83,9 @@ public Optional valueAtOrBefore(long offset) { * Returns the lat

Re: [PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
jsancio commented on PR #16892: URL: https://github.com/apache/kafka/pull/16892#issuecomment-2292317726 > @jsancio Sorry making conflicts on this PR. BTW, do you plan to ship (part of/all) [KAFKA-17241](https://issues.apache.org/jira/browse/KAFKA-17241) into 3.9? I assume all tasks of [KAF

Re: [PR] KAFKA-16749: [Minor] Addressed additional review comments [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16890: URL: https://github.com/apache/kafka/pull/16890#discussion_r1719031580 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -697,7 +696,7 @@ private SharePartitionKey sharePartitionKey(String groupId, TopicIdP

Re: [PR] KAFKA-16752: [MINOR] Addressed additional review comments [kafka]

2024-08-15 Thread via GitHub
junrao merged PR #16891: URL: https://github.com/apache/kafka/pull/16891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16274: URL: https://github.com/apache/kafka/pull/16274#discussion_r1719022889 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1719007373 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameteriz

Re: [PR] KAFKA-16749: [Minor] Addressed additional review comments [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16890: URL: https://github.com/apache/kafka/pull/16890#discussion_r1719000989 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -697,7 +696,7 @@ private SharePartitionKey sharePartitionKey(String groupId, TopicIdPartition

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718996395 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameterized

Re: [PR] KAFKA-17327: Add support of group in kafka-configs.sh [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16887: URL: https://github.com/apache/kafka/pull/16887#discussion_r1718910571 ## core/src/test/java/kafka/admin/ConfigCommandTest.java: ## @@ -1918,6 +1918,148 @@ public void shouldNotSupportAlterClientMetricsWithZookeeper() { assertEq

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718977530 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameteriz

Re: [PR] KAFKA-17342: Moved common coordinator code to separate module. [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16883: URL: https://github.com/apache/kafka/pull/16883#discussion_r1718975114 ## checkstyle/import-control-coordinator-common.xml: ## @@ -0,0 +1,78 @@ +http://www.puppycrawl.com/dtds/import_control_1_1.dtd";> + + + + + + + + +

Re: [PR] KAFKA-17342: Moved common coordinator code to separate module. [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16883: URL: https://github.com/apache/kafka/pull/16883#discussion_r1718974680 ## checkstyle/import-control-coordinator-common.xml: ## @@ -0,0 +1,78 @@ +http://www.puppycrawl.com/dtds/import_control_1_1.dtd";> + + + + + + + + +

Re: [PR] KAFKA-17294: Handle retriable errors when fetching offsets in new consumer [kafka]

2024-08-15 Thread via GitHub
lianetm commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2292211682 Ok, I see now how that `maybeExpire` handles the "send at least once" too, great (honestly I didn't remember that, it was probably added with the latest changes for the event reaper).

Re: [PR] KAFKA-17346: Refactored share session classes to server module [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on PR #16888: URL: https://github.com/apache/kafka/pull/16888#issuecomment-2292200948 > @apoorvmittal10 thanks for the patch! Moving out of `:core` makes good sense to me. > > WDYT about putting the new share partition code into a new `:share` module instead

[PR] MINOR add GH action for PR builds [kafka]

2024-08-15 Thread via GitHub
mumrah opened a new pull request, #16895: URL: https://github.com/apache/kafka/pull/16895 This PR adds a GitHub Action for running the junit tests on PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16753: Implement share acknowledge API in partition (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on PR #16339: URL: https://github.com/apache/kafka/pull/16339#issuecomment-2292197605 > @apoorvmittal10 : Thanks for the PR. Left a few late review comments. @junrao Thanks for the review. I have addressed the comments here: https://github.com/apache/kafka/pul

Re: [PR] KAFKA-16753: Implement share acknowledge API in partition (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16339: URL: https://github.com/apache/kafka/pull/16339#discussion_r1718964298 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -632,6 +711,524 @@ private boolean checkForFullMatch(InFlightBatch inFlightBatch, long first

Re: [PR] KAFKA-16753: Implement share acknowledge API in partition (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16339: URL: https://github.com/apache/kafka/pull/16339#discussion_r1718964551 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -632,6 +711,524 @@ private boolean checkForFullMatch(InFlightBatch inFlightBatch, long first

[PR] KAFKA-16753: [MINOR] Addressing additional review comments [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 opened a new pull request, #16894: URL: https://github.com/apache/kafka/pull/16894 The PR addresses comments from @junrao here: https://github.com/apache/kafka/pull/16339#pullrequestreview-2228994667 ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Created] (KAFKA-17352) Upgrade Gradle Enterprise to develocity plugin

2024-08-15 Thread David Arthur (Jira)
David Arthur created KAFKA-17352: Summary: Upgrade Gradle Enterprise to develocity plugin Key: KAFKA-17352 URL: https://issues.apache.org/jira/browse/KAFKA-17352 Project: Kafka Issue Type: Ta

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718953516 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameterized

Re: [PR] KAFKA-16749: Implemented share fetch messages (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16377: URL: https://github.com/apache/kafka/pull/16377#discussion_r1718924430 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -317,6 +364,197 @@ public void close() throws Exception { // TODO: Provide Im

[jira] [Resolved] (KAFKA-17250) Many system tests failing with org.apache.kafka.common.errors.UnsupportedVersionException: Attempted to write a non-default replicaDirectoryId at version 13

2024-08-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17250. Resolution: Duplicate This should be fixed by KAFKA-17276 > Many system tests failing wit

Re: [PR] KAFKA-16749: [Minor] Addressed additional review comments [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16890: URL: https://github.com/apache/kafka/pull/16890#discussion_r1718912928 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -697,7 +696,6 @@ private SharePartitionKey sharePartitionKey(String groupId, TopicIdP

Re: [PR] KAFKA-16749: Implemented share fetch messages (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16377: URL: https://github.com/apache/kafka/pull/16377#discussion_r1718902994 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -328,6 +366,202 @@ public void close() throws Exception { // TODO: Provide Im

Re: [PR] MINOR: add helper function for clusterInstance [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16852: URL: https://github.com/apache/kafka/pull/16852#discussion_r1718887073 ## core/src/test/java/kafka/test/ClusterInstance.java: ## @@ -187,6 +188,21 @@ default void waitTopicDeletion(String topic) throws InterruptedException { wai

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718881868 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameteriz

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16719: URL: https://github.com/apache/kafka/pull/16719#discussion_r1718870214 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -540,24 +572,29 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16719: URL: https://github.com/apache/kafka/pull/16719#discussion_r1718872010 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -487,15 +519,22 @@ private[transaction] class TransactionMetadata(val transaction

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-08-15 Thread via GitHub
apoorvmittal10 commented on code in PR #16274: URL: https://github.com/apache/kafka/pull/16274#discussion_r1718871933 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16719: URL: https://github.com/apache/kafka/pull/16719#discussion_r1718870214 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -540,24 +572,29 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16719: URL: https://github.com/apache/kafka/pull/16719#discussion_r1718870214 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -540,24 +572,29 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-14562 [1/2]: Implement epoch bump after every transaction [kafka]

2024-08-15 Thread via GitHub
jolshan commented on code in PR #16719: URL: https://github.com/apache/kafka/pull/16719#discussion_r1718867195 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -517,9 +526,19 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

Re: [PR] KAFKA-17331: Throw UnsupportedVersionException if the data in ListOffsetRequest does NOT fit EarliestLocalSpec and LatestTieredSpec. [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16876: URL: https://github.com/apache/kafka/pull/16876#discussion_r1718855689 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -95,13 +96,33 @@ public Builder setTargetTimes(List topics) { @Ove

Re: [PR] KAFKA-17331: Throw UnsupportedVersionException if the data in ListOffsetRequest does NOT fit EarliestLocalSpec and LatestTieredSpec. [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16876: URL: https://github.com/apache/kafka/pull/16876#discussion_r1718852127 ## clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java: ## @@ -95,13 +96,33 @@ public Builder setTargetTimes(List topics) { @Ove

Re: [PR] KAFKA-16749: [Minor] Addressed additional review comments [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16890: URL: https://github.com/apache/kafka/pull/16890#discussion_r1718851450 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -697,7 +696,6 @@ private SharePartitionKey sharePartitionKey(String groupId, TopicIdPartition

Re: [PR] KAFKA-16752: Implemented acquire functionality for Fetch (KIP-932) [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16274: URL: https://github.com/apache/kafka/pull/16274#discussion_r1718846109 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -0,0 +1,856 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] KAFKA-16749: Implemented share fetch messages (KIP-932) [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16377: URL: https://github.com/apache/kafka/pull/16377#discussion_r1718828017 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -317,6 +364,197 @@ public void close() throws Exception { // TODO: Provide Implementa

Re: [PR] KAFKA-16749: Implemented share fetch messages (KIP-932) [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16377: URL: https://github.com/apache/kafka/pull/16377#discussion_r1718826252 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -328,6 +366,202 @@ public void close() throws Exception { // TODO: Provide Implementa

[jira] [Resolved] (KAFKA-16818) Move event processing-related tests from ConsumerNetworkThreadTest to ApplicationEventProcessorTest

2024-08-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16818. Resolution: Fixed > Move event processing-related tests from ConsumerNetworkThreadTest to

Re: [PR] KAFKA-16818: Move event processing-related tests from ConsumerNetworkThreadTest to ApplicationEventProcessorTest [kafka]

2024-08-15 Thread via GitHub
chia7712 merged PR #16875: URL: https://github.com/apache/kafka/pull/16875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
mumrah commented on code in PR #16892: URL: https://github.com/apache/kafka/pull/16892#discussion_r1718794970 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -952,32 +954,29 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) if (controll

Re: [PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
mumrah commented on code in PR #16892: URL: https://github.com/apache/kafka/pull/16892#discussion_r1718794105 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -279,19 +279,25 @@ private void handleBatch(Batch batch, OptionalLong o

[jira] [Assigned] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2024-08-15 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-13588: - Assignee: (was: Guozhang Wang) > We should consolidate `changelogFor` methods to si

[jira] [Commented] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2024-08-15 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874026#comment-17874026 ] Guozhang Wang commented on KAFKA-13588: --- With 4.0 on the horizon, we can now final

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
junrao commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718781094 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -35,11 +36,18 @@ class ListOffsetsRequestTest extends BaseRequestTest { val topic = "to

Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]

2024-08-15 Thread via GitHub
frankvicky commented on PR #16775: URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291725574 Hi @jsancio Apologies for the timing of this PR. I should have waited until after the 3.9.0 RC before submitting it. I’ll be more mindful of the timing in the future to avoid any i

Re: [PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on PR #16892: URL: https://github.com/apache/kafka/pull/16892#issuecomment-2291724864 @jsancio Sorry making conflicts on this PR. BTW, do you plan to ship (part of/all) KAFKA-17241 into 3.9? I assume all tasks of KAFKA-17241 are included by 4.0 only. -- This is an aut

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16893: URL: https://github.com/apache/kafka/pull/16893#discussion_r1718708317 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -202,7 +210,17 @@ class ListOffsetsRequestTest extends BaseRequestTest { @Parameteriz

Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on PR #16775: URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291712475 push to 3.9 (https://github.com/apache/kafka/commit/bcf4c73bae59d0425417c24fd526a3a232f6f640) -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Updated] (KAFKA-17238) Move VoterSet and ReplicaKey from raft.internals to raft

2024-08-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-17238: --- Fix Version/s: 3.9.0 > Move VoterSet and ReplicaKey from raft.internals to raft > --

Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on PR #16775: URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291696880 > thanks for the improvements but can we try avoiding this kind of changes until after 3.9.0 RC? This kind of changes tend to cause unnecessary churn on pending PRs that need to get m

Re: [PR] KAFKA-17137: Feat admin client it acl configs [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16648: URL: https://github.com/apache/kafka/pull/16648#discussion_r1718663810 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -96,6 +96,62 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrati

Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]

2024-08-15 Thread via GitHub
jsancio commented on PR #16775: URL: https://github.com/apache/kafka/pull/16775#issuecomment-2291677673 @frankvicky @chia7712 thanks for the improvements but can we try avoiding this kind of changes until after 3.9.0 RC? This kind of changes tend to cause unnecessary churn on pending

[jira] [Updated] (KAFKA-17241) KIP-853 follow-ups

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17241: --- Labels: kraft (was: ) > KIP-853 follow-ups > -- > >

[jira] [Assigned] (KAFKA-17241) KIP-853 follow-ups

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-17241: -- Assignee: José Armando García Sancio > KIP-853 follow-ups > -

[jira] [Commented] (KAFKA-17338) ConsumerConfig should prevent using partition assignors with CONSUMER group protocol

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874004#comment-17874004 ] 黃竣陽 commented on KAFKA-17338: - Hello [~kirktrue], If you wouldn't work on this, may I take t

[jira] [Resolved] (KAFKA-17238) Move VoterSet and ReplicaKey from raft.internals to raft

2024-08-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17238. Fix Version/s: 4.0.0 Resolution: Fixed > Move VoterSet and ReplicaKey from raft.int

[jira] [Updated] (KAFKA-17048) Document how to use KIP-853

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17048: --- Parent: KAFKA-17241 Issue Type: Sub-task (was: Task) > Docu

[jira] [Resolved] (KAFKA-14094) KIP-853: KRaft controller membership changes

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14094. Resolution: Fixed > KIP-853: KRaft controller membership changes >

Re: [PR] KAFKA-17238: Move VoterSet and ReplicaKey from raft.internals to raft [kafka]

2024-08-15 Thread via GitHub
chia7712 merged PR #16775: URL: https://github.com/apache/kafka/pull/16775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-17048) Document how to use KIP-853

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17048: --- Parent: (was: KAFKA-14094) Issue Type: Task (was: Sub-ta

[jira] [Updated] (KAFKA-17048) Document how to use KIP-853

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-17048: --- Fix Version/s: 3.9.0 > Document how to use KIP-853 > ---

Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]

2024-08-15 Thread via GitHub
m1a2st commented on code in PR #16810: URL: https://github.com/apache/kafka/pull/16810#discussion_r1718631839 ## core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala: ## @@ -51,7 +52,8 @@ class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinatorB

[jira] [Resolved] (KAFKA-17318) Introduce ConsumerRecord.deliveryCount()

2024-08-15 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17318. Fix Version/s: 4.0.0 Resolution: Fixed > Introduce ConsumerRecord.deliveryCount() >

Re: [PR] KAFKA-17318: ConsumerRecord.deliveryCount and remove deprecations [kafka]

2024-08-15 Thread via GitHub
chia7712 merged PR #16872: URL: https://github.com/apache/kafka/pull/16872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Fix visibility for classes exposed outside of their scope [kafka]

2024-08-15 Thread via GitHub
jsancio merged PR #16886: URL: https://github.com/apache/kafka/pull/16886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
m1a2st commented on PR #16893: URL: https://github.com/apache/kafka/pull/16893#issuecomment-2291604632 If ListOffsetRequest latestVersionUnstable is true, the `testResponseIncludesLeaderEpochWithUnstableAPIs` should be fail, This is my local test result ![CleanShot 2024-08-16 at 00 00

[jira] [Updated] (KAFKA-16842) Fix KafkaConfig validation and support unknown voters

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16842: --- Description: 1. controller.quorum.bootstrap.server is only allowed t

[jira] [Updated] (KAFKA-16842) Fix KafkaConfig validation and support unknown voters

2024-08-15 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16842: --- Summary: Fix KafkaConfig validation and support unknown voters (was:

Re: [PR] MINOR: Speed up JoinGroupRequestTest, ListGroupsRequestTest, SyncGroupRequestTest by decreased rebalance deplay from 3s to 1s [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on code in PR #16810: URL: https://github.com/apache/kafka/pull/16810#discussion_r1718603603 ## core/src/test/scala/unit/kafka/server/JoinGroupRequestTest.scala: ## @@ -51,7 +52,8 @@ class JoinGroupRequestTest(cluster: ClusterInstance) extends GroupCoordinato

[PR] KAFKA-17336 Add IT to make sure the production MV does not use unstable version of LIST_OFFSET [kafka]

2024-08-15 Thread via GitHub
m1a2st opened a new pull request, #16893: URL: https://github.com/apache/kafka/pull/16893 Jira: https://issues.apache.org/jira/browse/KAFKA-17336 Due to the server config `UNSTABLE_API_VERSIONS_ENABLE_CONFIG` is true, so we can't test the scenario of ListOffsetsRequest is unstable ver

[PR] KAFKA-16842; Fix config validation and support unknown voters [kafka]

2024-08-15 Thread via GitHub
jsancio opened a new pull request, #16892: URL: https://github.com/apache/kafka/pull/16892 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[jira] [Created] (KAFKA-17351) Validate compacted topics start offset handling in Share Partition

2024-08-15 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17351: - Summary: Validate compacted topics start offset handling in Share Partition Key: KAFKA-17351 URL: https://issues.apache.org/jira/browse/KAFKA-17351 Project: Kafka

Re: [PR] KAFKA-17294: Handle retriable errors when fetching offsets in new consumer [kafka]

2024-08-15 Thread via GitHub
chia7712 commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2291571934 > I believe that was intentional so that we ensure that requests are sent at least once even if timeout expired (which is what the classic consumer does). With the classic consumer, the

Re: [PR] KAFKA-17294: Handle retriable errors when fetching offsets in new consumer [kafka]

2024-08-15 Thread via GitHub
lianetm commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2291553679 Hey, regarding this: > The failAndRemoveExpiredFetchRequests method at L1198 clears expired fetch requests from unsentOffsetFetches. However, the partitionedBySendability collectio

  1   2   >