Re: [PR] MINOR: Removing incorrect multi threaded state transition tests [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield merged PR #20436: URL: https://github.com/apache/kafka/pull/20436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-08-28 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-3235698663 Sure @mimaison but in the meanwhile can you please share your view on that thread it would really be very helpful. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-18996 Expose addReadOnlyStateStore in DSL (StreamsBuilder) [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #19621: URL: https://github.com/apache/kafka/pull/19621#issuecomment-3235589457 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-1792: change behavior of --generate to produce assignment config with fair replica distribution and minimal number of reassignments [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #18903: URL: https://github.com/apache/kafka/pull/18903#issuecomment-3235589702 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Optimization of the Murmur2 hash computation [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #20359: URL: https://github.com/apache/kafka/pull/20359#issuecomment-323559 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #20393: URL: https://github.com/apache/kafka/pull/20393#issuecomment-3235588699 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19174 KAFKA-19591 Gradle version upgrade 8 -->> 9 [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3235589490 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3235588735 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] MINOR: Improve the `KAFKA_HEAP_OPTS` definition while run `kafka-server-start.bat` Batch [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #19703: URL: https://github.com/apache/kafka/pull/19703#issuecomment-3235589380 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Feature/openj9 integration [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #20197: URL: https://github.com/apache/kafka/pull/20197#issuecomment-3235589069 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19617: ConsumerPerformance#ConsumerPerfRebListener get corrupted value when the number of partitions is increased [kafka]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #20388: URL: https://github.com/apache/kafka/pull/20388#issuecomment-3235588781 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19589: Reduce number of events generated in AsyncKafkaConsumer.updateFetchPositions() [kafka]

2025-08-28 Thread via GitHub
kirktrue commented on PR #20324: URL: https://github.com/apache/kafka/pull/20324#issuecomment-3235313726 FYI: test failures appear related to the broader flakiness of the tests over the last seven days: - `AclControlManagerTest.testDeleteExceedsMaxRecords()`: [10% flaky](https://deve

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-28 Thread via GitHub
yunchipang commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2308815855 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -240,13 +250,16 @@ public static void main(String[] args) throws Exception { C

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-28 Thread via GitHub
mjsax commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3235299164 If you want to divide the work, a good approach would be to first split up the work to update all integrations test, before we merge any actual code changes? -- This is an automated mess

Re: [PR] KAFKA-19537: Improve Exit Code Handling in StreamsGroupCommand [kafka]

2025-08-28 Thread via GitHub
mjsax commented on code in PR #20293: URL: https://github.com/apache/kafka/pull/20293#discussion_r2308815743 ## tools/src/test/java/org/apache/kafka/tools/streams/ResetStreamsGroupOffsetTest.java: ## @@ -738,4 +755,26 @@ private static void produceMessagesOnTwoPartitions(final

Re: [PR] KAFKA-19537: Improve Exit Code Handling in StreamsGroupCommand [kafka]

2025-08-28 Thread via GitHub
mjsax commented on code in PR #20293: URL: https://github.com/apache/kafka/pull/20293#discussion_r2308814874 ## tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupOffsetTest.java: ## @@ -436,4 +440,26 @@ private StreamsGroupCommand.StreamsGroupService getStrea

Re: [PR] Kafka 16801 FIx Streams upgrade :test target doesn't find any junit tests [kafka]

2025-08-28 Thread via GitHub
mjsax commented on PR #20260: URL: https://github.com/apache/kafka/pull/20260#issuecomment-3235275904 Seems this issue is getting resolved via https://github.com/apache/kafka/pull/19513/commits/6295c8a98262624e5415f581e12530aa602ab95b Should we close this PR, or wait until#19513 got m

[jira] [Commented] (KAFKA-16801) Streams upgrade :test target doesn't find any junit tests

2025-08-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016901#comment-18016901 ] Matthias J. Sax commented on KAFKA-16801: - Sweet! – Thanks for letting us know [

Re: [PR] KAFKA-19588: Reduce number of events generated in AsyncKafkaConsumer.poll() [kafka]

2025-08-28 Thread via GitHub
kirktrue commented on code in PR #20363: URL: https://github.com/apache/kafka/pull/20363#discussion_r2308712762 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java: ## @@ -140,7 +145,7 @@ public abstract class AbstractMembershipMan

Re: [PR] KAFKA-19174 KAFKA-19591 Gradle version upgrade 8 -->> 9 [kafka]

2025-08-28 Thread via GitHub
dejan2609 commented on PR #19513: URL: https://github.com/apache/kafka/pull/19513#issuecomment-3235106658 Update: yet another commit is added (that solves this JIRA sub-ticket): - https://issues.apache.org/jira/browse/KAFKA-16801 Streams upgrade :test target doesn't find any junit tests

[jira] [Commented] (KAFKA-16801) Streams upgrade :test target doesn't find any junit tests

2025-08-28 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016895#comment-18016895 ] Dejan Stojadinović commented on KAFKA-16801: Hi everybody,  I just discover

[PR] MINOR: Removing incorrect multi threaded state transition tests [kafka]

2025-08-28 Thread via GitHub
apoorvmittal10 opened a new pull request, #20436: URL: https://github.com/apache/kafka/pull/20436 These tests were written while finalizing approach for making inflight state class thread safe but later approach changed and the lock is now always required by SharePartition to change infligh

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on PR #20424: URL: https://github.com/apache/kafka/pull/20424#issuecomment-3234969859 > I still don't get this output... Not sure why That’s strange. I tested JDK 17, 21, and 24 according to [this comment](https://github.com/apache/kafka/pull/20424?utm_source=chatgp

[jira] [Commented] (KAFKA-16800) Resolve Gradle 9.0 deprecations

2025-08-28 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016885#comment-18016885 ] Dejan Stojadinović commented on KAFKA-16800: Hi all, (i) I'm linking Gradle

[jira] [Commented] (KAFKA-18087) Revert unnecessary integration testing of both consumer group protocols

2025-08-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016883#comment-18016883 ] Kirk True commented on KAFKA-18087: --- We continue to catch issues with the `AsyncKafkaC

[jira] [Commented] (KAFKA-18061) AddRaftVoter responds with error message "NONE" instead of null

2025-08-28 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016882#comment-18016882 ] Chang Chi Hsu commented on KAFKA-18061: --- Hi [~linsiyuan],  Would it be possible f

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
mjsax commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2308509485 ## server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java: ## @@ -55,35 +55,35 @@ public void testParseEmptyArgAsValid() { List argAr

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
mjsax commented on PR #20424: URL: https://github.com/apache/kafka/pull/20424#issuecomment-3234880507 I still don't get this output... Not sure why 🤷 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] MINOR: fix docs references to missing features that are no longer missing [kafka]

2025-08-28 Thread via GitHub
jim0987795064 opened a new pull request, #20435: URL: https://github.com/apache/kafka/pull/20435 - ""Changes: ""Remove outdated "missing features" references from docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-28 Thread via GitHub
shashankhs11 commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3234745660 That would be awesome! I would really love to collaborate and help resolve the issue. However, I think collaborating might be a difficult task to tackle, but I've got a plan.

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-28 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2308337503 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -842,6 +846,7 @@ public void handleException(Throwable exception) { @Ov

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-28 Thread via GitHub
janchilling commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3234649516 Hi @mjsax , @lucasbru , @shashankhs11 , I’m happy to share this PR with @shashankhs11, and it would be great if I can collaborate with him on this. The main place I got s

[jira] [Updated] (KAFKA-19651) Thread is not marked interrupted even when AsyncKafkaConsumer.close() throws InterruptException

2025-08-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19651: -- Fix Version/s: 4.2.0 > Thread is not marked interrupted even when AsyncKafkaConsumer.close() throws >

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2308284793 ## build.gradle: ## @@ -740,6 +740,7 @@ subprojects { // For more details, refer to https://github.com/gradle/gradle/issues/13762. // As a result, we need t

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-08-28 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016858#comment-18016858 ] Arpit Goyal commented on KAFKA-19259: - Yes [~kirktrue]  sure. Can you share me the p

Re: [PR] KAFKA-19635: KIP-1147 changes for upgrade.html [kafka]

2025-08-28 Thread via GitHub
apoorvmittal10 commented on code in PR #20415: URL: https://github.com/apache/kafka/pull/20415#discussion_r2307354537 ## docs/upgrade.html: ## @@ -41,9 +43,51 @@ Notable changes in 4 The PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG in ProducerConfig was deprecated a

[jira] [Created] (KAFKA-19651) Thread is not marked interrupted even when AsyncKafkaConsumer.close() throws InterruptException

2025-08-28 Thread Kirk True (Jira)
Kirk True created KAFKA-19651: - Summary: Thread is not marked interrupted even when AsyncKafkaConsumer.close() throws InterruptException Key: KAFKA-19651 URL: https://issues.apache.org/jira/browse/KAFKA-19651

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
mjsax commented on PR #20424: URL: https://github.com/apache/kafka/pull/20424#issuecomment-3234426948 Still seeing, but IntelliJ does not highlight anything, and I cannot spot the issue. ``` > Task :server:compileTestJava Note: /Users/matthiassax/IdeaProjects/kafka/server/src/test/

Re: [PR] KAFKA-19635: Minor docs tweaks [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield merged PR #20434: URL: https://github.com/apache/kafka/pull/20434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19626: KIP-1147 Consistency of command-line arguments for remaining CLI tools [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield commented on code in PR #20431: URL: https://github.com/apache/kafka/pull/20431#discussion_r2308006250 ## tools/src/main/java/org/apache/kafka/tools/ClusterTool.java: ## @@ -82,9 +83,13 @@ static void execute(String... args) throws Exception { conne

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-28 Thread via GitHub
aheev commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2308137965 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -335,8 +349,18 @@ public ConsumerPerfOptions(String[] args) { } if

[jira] [Updated] (KAFKA-18087) Revert unnecessary integration testing of both consumer group protocols

2025-08-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18087: -- Fix Version/s: (was: 4.2.0) > Revert unnecessary integration testing of both consumer group protoc

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-08-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016842#comment-18016842 ] Kirk True commented on KAFKA-19259: --- [~goyarpit]—I have a proposed fix linked to this

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
mjsax commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2308051163 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1978,7 +1978,7 @@ public ProductionExceptionHandlerResponse handle(

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-28 Thread via GitHub
junrao commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2308038987 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -716,23 +716,21 @@ public void testInterceptorConstructorClose(GroupProtocol gr

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-28 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2307970537 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## Review Comment: I think it should be sufficient to call `controllerMetrics.upda

Re: [PR] MINOR: Remove default config in AutoTopicCreationManager#createStreamsInternalTopics [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3234132277 @brandboat Perhaps this PR could instead add comments to clarify why it is ncessary to set both the number of partitions and the replication factor in broker -- This is an automated m

Re: [PR] KAFKA-15038: Replace topicIdByPartitionMap with MetadataCache instance in RemoteLogManager [kafka]

2025-08-28 Thread via GitHub
kamalcph commented on code in PR #20256: URL: https://github.com/apache/kafka/pull/20256#discussion_r2307900595 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2347,6 +2347,7 @@ class ReplicaManager(val config: KafkaConfig, // Before taking the lock, comput

Re: [PR] KAFKA-15038: Replace topicIdByPartitionMap with MetadataCache instance in RemoteLogManager [kafka]

2025-08-28 Thread via GitHub
kamalcph commented on code in PR #20256: URL: https://github.com/apache/kafka/pull/20256#discussion_r2307889453 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java: ## @@ -490,8 +479,8 @@ public void onLeadershipChange(Set partitionsBecomeL

Re: [PR] MINOR: Cleanup `toString` methods in Storage Module [kafka]

2025-08-28 Thread via GitHub
sjhajharia commented on PR #20432: URL: https://github.com/apache/kafka/pull/20432#issuecomment-3233777844 Hey @ijuma I spot checked them and indeed none of them seem to be intentional based on their original PRs where they were introduced. Is there something specific I must look at?

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-28 Thread via GitHub
aheev commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2307648334 ## tests/kafkatest/services/performance/consumer_performance.py: ## @@ -40,7 +40,7 @@ class ConsumerPerformanceService(PerformanceService): "socket-buffer-size",

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-28 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2307848113 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -157,8 +164,22 @@ public Long value() { return new

[PR] KAFKA-19635: Minor docs tweaks [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield opened a new pull request, #20434: URL: https://github.com/apache/kafka/pull/20434 Improve the wording in the upgrade doc slightly. Also fix a tiny annoyance in the output from the message generator. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-28 Thread via GitHub
MahsaSeifikar commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2307835951 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -157,8 +164,22 @@ public Long value() { return

Re: [PR] MINOR: Remove default config in AutoTopicCreationManager#createStreamsInternalTopics [kafka]

2025-08-28 Thread via GitHub
brandboat commented on PR #20421: URL: https://github.com/apache/kafka/pull/20421#issuecomment-3234024772 Hi @lucasbru, the original implementation is right, like @chia7712 mentioned, topic apply default replica factor and partition num from broker server. https://github.com/apache/kafka/b

Re: [PR] MINOR: Remove default config in AutoTopicCreationManager#createStreamsInternalTopics [kafka]

2025-08-28 Thread via GitHub
brandboat closed pull request #20421: MINOR: Remove default config in AutoTopicCreationManager#createStreamsInternalTopics URL: https://github.com/apache/kafka/pull/20421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-19467: Add a metric for controller thread idleness [kafka]

2025-08-28 Thread via GitHub
kevin-wu24 commented on code in PR #20422: URL: https://github.com/apache/kafka/pull/20422#discussion_r2307788763 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -157,8 +164,22 @@ public Long value() { return new

[jira] [Resolved] (KAFKA-19635) Update upgrade.html with the changes in Apache Kafka 4.2

2025-08-28 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19635. -- Resolution: Fixed > Update upgrade.html with the changes in Apache Kafka 4.2 > ---

Re: [PR] KAFKA-19635: KIP-1147 changes for upgrade.html [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield merged PR #20415: URL: https://github.com/apache/kafka/pull/20415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2307773588 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -335,8 +349,18 @@ public ConsumerPerfOptions(String[] args) { }

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2307725001 ## tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java: ## @@ -292,13 +296,18 @@ public ConsumerPerfOptions(String[] args) { .

Re: [PR] KAFKA-19647: Implement integration test for offline migration [kafka]

2025-08-28 Thread via GitHub
lucasbru merged PR #20412: URL: https://github.com/apache/kafka/pull/20412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19635: KIP-1147 changes for upgrade.html [kafka]

2025-08-28 Thread via GitHub
apoorvmittal10 commented on code in PR #20415: URL: https://github.com/apache/kafka/pull/20415#discussion_r2307738086 ## docs/upgrade.html: ## @@ -41,9 +43,73 @@ Notable changes in 4 The PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG in ProducerConfig was deprecated a

Re: [PR] KAFKA-19276: Trigger rebalance for streams config update [kafka]

2025-08-28 Thread via GitHub
lucasbru commented on PR #19967: URL: https://github.com/apache/kafka/pull/19967#issuecomment-3233876098 Thanks a lot for the detailed review @squah-confluent ! This is actually very helpful -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-19276: Trigger rebalance for streams config update [kafka]

2025-08-28 Thread via GitHub
lucasbru commented on code in PR #19967: URL: https://github.com/apache/kafka/pull/19967#discussion_r2307714058 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java: ## @@ -52,6 +54,10 @@ public void updateGroupConfig(String groupId, Prop

Re: [PR] KAFKA-19544: Improve `MetadataVersion.fromVersionString()` to take an enableUnstableFeature flag [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on PR #20248: URL: https://github.com/apache/kafka/pull/20248#issuecomment-3233688652 @DL1231 could you please rebase code to run CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-19520: Bump Commons-Lang for CVE-2025-48924 [kafka]

2025-08-28 Thread via GitHub
fvaleri commented on PR #20433: URL: https://github.com/apache/kafka/pull/20433#issuecomment-3233730715 @mimaison @showuon fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] KAFKA-19520: Bump Commons-Lang for CVE-2025-48924 [kafka]

2025-08-28 Thread via GitHub
fvaleri opened a new pull request, #20433: URL: https://github.com/apache/kafka/pull/20433 Bump Commons-Lang for CVE-2025-48924. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] MINOR: Cleanup `toString` methods in Storage Module [kafka]

2025-08-28 Thread via GitHub
ijuma commented on PR #20432: URL: https://github.com/apache/kafka/pull/20432#issuecomment-3233595698 Have you verified that the overrides were not intentional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-19276: Trigger rebalance for streams config update [kafka]

2025-08-28 Thread via GitHub
squah-confluent commented on code in PR #19967: URL: https://github.com/apache/kafka/pull/19967#discussion_r2307416991 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java: ## @@ -52,6 +54,10 @@ public void updateGroupConfig(String groupI

Re: [PR] KAFKA-19635: KIP-1147 changes for upgrade.html [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield commented on code in PR #20415: URL: https://github.com/apache/kafka/pull/20415#discussion_r2307483756 ## docs/upgrade.html: ## @@ -41,9 +43,51 @@ Notable changes in 4 The PARTITIONER_ADPATIVE_PARTITIONING_ENABLE_CONFIG in ProducerConfig was deprecated

Re: [PR] KAFKA-19276: Trigger rebalance for streams config update [kafka]

2025-08-28 Thread via GitHub
squah-confluent commented on code in PR #19967: URL: https://github.com/apache/kafka/pull/19967#discussion_r2307448948 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1913,6 +1914,11 @@ private CoordinatorResult stream

Re: [PR] KAFKA-19616: Add compression type and level support to LogCompactionTester [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on code in PR #20396: URL: https://github.com/apache/kafka/pull/20396#discussion_r2307348317 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -240,13 +250,16 @@ public static void main(String[] args) throws Exception { Com

Re: [PR] MINOR: Updated name from messages to records for consistency in share partition [kafka]

2025-08-28 Thread via GitHub
apoorvmittal10 merged PR #20416: URL: https://github.com/apache/kafka/pull/20416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] MINOR: Cleanup Connect Module (5/n) [kafka]

2025-08-28 Thread via GitHub
sjhajharia commented on PR #20393: URL: https://github.com/apache/kafka/pull/20393#issuecomment-3233152594 Adding @chia7712 as he has been helping with tonnes of reviews in this area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] MINOR: Cleanup `toString` methods in Storage Module [kafka]

2025-08-28 Thread via GitHub
sjhajharia opened a new pull request, #20432: URL: https://github.com/apache/kafka/pull/20432 Getting rid of a bunch of `toString` functions in record classes in Storage Module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-19650) Add message key to org.apache.kafka.clients.producer.RecordMetadata

2025-08-28 Thread Schubert Fernandes (Jira)
Schubert Fernandes created KAFKA-19650: -- Summary: Add message key to org.apache.kafka.clients.producer.RecordMetadata Key: KAFKA-19650 URL: https://issues.apache.org/jira/browse/KAFKA-19650 Proje

[jira] [Commented] (KAFKA-19626) Consistency of command-line arguments for remaining CLI tools

2025-08-28 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18016754#comment-18016754 ] Jhen-Yung Hsu commented on KAFKA-19626: --- Add the PR link here, since it is not sho

[PR] KAFKA-19626: KIP-1147 Consistency of command-line arguments for remaining CLI tools [kafka]

2025-08-28 Thread via GitHub
Yunyung opened a new pull request, #20431: URL: https://github.com/apache/kafka/pull/20431 This implements [KIP-1147](https://cwiki.apache.org/confluence/x/DguWF) for kafka-cluster.sh, kafka-leader-election.sh and kafka-streams-application-reset.sh. Jira: https://issues.apache.org/ji

Re: [PR] MINOR: cleanup String.format [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on code in PR #20425: URL: https://github.com/apache/kafka/pull/20425#discussion_r2306444968 ## storage/src/test/java/org/apache/kafka/server/log/remote/quota/RLMQuotaMetricsTest.java: ## @@ -58,7 +58,7 @@ public void testClose() { // Register the s

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-28 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2307048649 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -713,32 +713,6 @@ public void testInterceptorConstructorClose(GroupProtocol gro

Re: [PR] KAFKA-19112 Unifying LIST-Type Configuration Validation and Default Values [kafka]

2025-08-28 Thread via GitHub
m1a2st commented on code in PR #20334: URL: https://github.com/apache/kafka/pull/20334#discussion_r2307042233 ## server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java: ## @@ -137,7 +144,8 @@ public Map effectiveListenerSecurityProtocolMap( //

Re: [PR] KAFKA-19624: Improving consistency of command-line arguments for consumer performance tests [kafka]

2025-08-28 Thread via GitHub
Yunyung commented on code in PR #20385: URL: https://github.com/apache/kafka/pull/20385#discussion_r2306938202 ## tests/kafkatest/services/performance/consumer_performance.py: ## @@ -40,7 +40,7 @@ class ConsumerPerformanceService(PerformanceService): "socket-buffer-size

[jira] [Comment Edited] (KAFKA-10093) Replace iteration with call to addAll in Utils

2025-08-28 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18015424#comment-18015424 ] Ksolves India Limited edited comment on KAFKA-10093 at 8/28/25 10:13 AM: -

Re: [PR] KAFKA-19550 Integration test for Streams-related Admin APIs[1/N] [kafka]

2025-08-28 Thread via GitHub
lucasbru commented on code in PR #20244: URL: https://github.com/apache/kafka/pull/20244#discussion_r2306898719 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -4363,6 +4401,162 @@ class PlaintextAdminIntegrationTest extends BaseAdminInte

[PR] KAFKA-16263 : Add Kafka Streams docs about available listeners/callback [kafka]

2025-08-28 Thread via GitHub
samarth-ksolves opened a new pull request, #20430: URL: https://github.com/apache/kafka/pull/20430 This PR updated the running-app.html to: 1. Add missing documentation for Kafka Streams listeners and callbacks. 2. Current docs do not explain or list the available listeners, making

Re: [PR] MINOR: Remove OffsetsForLeaderEpochRequest unused static field [kafka]

2025-08-28 Thread via GitHub
frankvicky merged PR #20418: URL: https://github.com/apache/kafka/pull/20418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] MINOR: remove arguments from AsyncKafkaConsumerTest.newConsumer() that are identical [kafka]

2025-08-28 Thread via GitHub
AndrewJSchofield merged PR #20426: URL: https://github.com/apache/kafka/pull/20426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Make InternalStreamsBuilder#addGraphNode public [kafka]

2025-08-28 Thread via GitHub
Chuckame commented on PR #19816: URL: https://github.com/apache/kafka/pull/19816#issuecomment-3232482710 Maybe coming back to the root cause of why I need it: When creating the GraphNode, it needs the build priority to be set. Setting the value to the parent node works, but I'm not su

Re: [PR] MINOR: Make InternalStreamsBuilder#addGraphNode public [kafka]

2025-08-28 Thread via GitHub
Chuckame commented on PR #19816: URL: https://github.com/apache/kafka/pull/19816#issuecomment-3232461991 Yes, I'm doing reflection for some other things to find out all the (de)serializers to build a json file showing the serialization layer with all the types, to be aware of any breaking c

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
frankvicky commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2306633978 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1978,7 +1978,7 @@ public ProductionExceptionHandlerResponse ha

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
frankvicky commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2306547196 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1978,7 +1978,7 @@ public ProductionExceptionHandlerResponse ha

Re: [PR] KAFKA-18185: remove internal.leave.group.on.close config [kafka]

2025-08-28 Thread via GitHub
lucasbru commented on PR #19400: URL: https://github.com/apache/kafka/pull/19400#issuecomment-3232351992 @frankvicky: This makes sense, then. So remaining in group means sending the leave epoch in the static case. Then it is just the code comment that is misleading and could probably be upd

Re: [PR] KAFKA-18913: Remove state.updater.enabled flag from StreamThread and … [kafka]

2025-08-28 Thread via GitHub
lucasbru commented on PR #20392: URL: https://github.com/apache/kafka/pull/20392#issuecomment-3232339210 Sounds good to me. Once @janchilling confirms taking on the whole work, we can close the other PRs. Note that completing the work does not only involve removing code, but also porting /

Re: [PR] MINOR: suppress build warning [kafka]

2025-08-28 Thread via GitHub
chia7712 commented on code in PR #20424: URL: https://github.com/apache/kafka/pull/20424#discussion_r2306491803 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1978,7 +1978,7 @@ public ProductionExceptionHandlerResponse hand

[PR] MINOR: Add doc for external schemas in JSONConverter [kafka]

2025-08-28 Thread via GitHub
JimmyWang6 opened a new pull request, #20429: URL: https://github.com/apache/kafka/pull/20429 This is a follow-up to #19449, which do the following things: 1. Add document to explain `schema.content` only work for sink connector when `schemas.enable` set to true. 2. Handle the cas

Re: [PR] MINOR: Add a missing @Test to test case [kafka]

2025-08-28 Thread via GitHub
chia7712 merged PR #20427: URL: https://github.com/apache/kafka/pull/20427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] [WIP] KAFKA-17302 [kafka]

2025-08-28 Thread via GitHub
abhijeetk88 opened a new pull request, #20428: URL: https://github.com/apache/kafka/pull/20428 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some