[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1205119564 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -3981,23 +4348,13 @@ private void prepareJoinAndSyncResponse(

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1205119564 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -3981,23 +4348,13 @@ private void prepareJoinAndSyncResponse(

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1205089112 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204403475 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204376110 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204361177 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204356253 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204312762 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204162396 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204151150 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204087015 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -489,24 +489,23 @@ class AuthorizerIntegrationTest extends BaseRequestTest { }

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1204079800 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1203992806 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1203965540 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -129,16 +150,19 @@ import static org.junit.jupiter.api.Asser

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1185779424 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void testCommitOffsetUnknownMemb

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1131139080 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1131047710 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1131047710 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1131047710 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1130866578 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129710408 ## clients/src/main/java/org/apache/kafka/common/TopicIdAndNameBiMapping.java: ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129452978 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129482786 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( } publ

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129482786 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( } publ

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129452978 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -119,28 +131,52 @@ public boolean shouldClientThrottle(short version) {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129407685 ## clients/src/main/java/org/apache/kafka/common/TopicResolver.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129371713 ## core/src/main/scala/kafka/server/MetadataCache.scala: ## @@ -90,6 +90,10 @@ trait MetadataCache { def topicIdsToNames(): util.Map[Uuid, String] + def topic

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129311477 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1352,8 +1370,22 @@ public void handle(OffsetCommitResponse commi

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129283573 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -49,7 +46,14 @@ public static class Builder extends AbstractRequest.Builder

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129272424 ## clients/src/main/java/org/apache/kafka/common/TopicResolver.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129266598 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1379,7 +1411,8 @@ public void handle(OffsetCommitResponse commit

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129272424 ## clients/src/main/java/org/apache/kafka/common/TopicResolver.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129267206 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1352,8 +1370,22 @@ public void handle(OffsetCommitResponse commi

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129266598 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1379,7 +1411,8 @@ public void handle(OffsetCommitResponse commit

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129167871 ## clients/src/main/java/org/apache/kafka/common/TopicResolver.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129167871 ## clients/src/main/java/org/apache/kafka/common/TopicResolver.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1126511918 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( } publ

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1125687390 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1328,13 +1335,16 @@ RequestFuture sendOffsetCommitRequest(final

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1125687294 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -59,7 +63,36 @@ public OffsetCommitRequest build(short version) {