apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1793193418
> @apoorvmittal10 : Thanks for filing the jira. It's better to file a
separate jira for each new failed test.
Sure, done.
--
This is an automated message from the Apache
junrao commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1793156198
@apoorvmittal10 : Thanks for the filing the jira. It's better to file a
separate jira for each new failed test.
--
This is an automated message from the Apache Git Service.
To respond
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1793147305
> @apoorvmittal10 : Thanks for the updated PR. LGTM.
>
> For the unrelated failed tests, could we file jiras to track new ones?
Thanks.
Thanks @junrao. I have added
junrao merged PR #14621:
URL: https://github.com/apache/kafka/pull/14621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1793140734
@junrao I can find these 7 unrelated tests from the PR are failing.
```
Build / JDK 17 and Scala 2.13 /
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1380427009
##
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##
@@ -222,6 +222,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_LOGGER_CONFIG, //
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1791154602
> @apoorvmittal10 : Thanks for the updated PR. Just one more comment.
Thanks a lot for the feedback, it was helpful. I have addressed the comments.
--
This is an automated
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1380507922
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -543,7 +547,8 @@ class KafkaServer(
clusterId = clusterId,
time = time,
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379428164
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379426628
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379425234
##
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##
@@ -222,6 +222,7 @@ public enum ConfigSource {
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379117057
##
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##
@@ -222,6 +222,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_LOGGER_CONFIG, //
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379129447
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1379120392
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1789002777
> @apoorvmittal10 : Thanks for the updated PR. Left a few more comments.
Thanks for the feedback @junrao. I have addressed the comments.
--
This is an automated message
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378834332
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -477,6 +479,128 @@ class KafkaApisTest {
testKraftForwarding(ApiKeys.ELECT_LEADERS,
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378834102
##
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##
@@ -101,4 +102,55 @@ class ControllerConfigurationValidatorTest {
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378833820
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378832405
##
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##
@@ -101,4 +102,55 @@ class ControllerConfigurationValidatorTest {
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378831801
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4089,13 +4119,19 @@ public void testIncrementalAlterConfigs() throws
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378830720
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -567,7 +572,8 @@ class KafkaServer(
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378829641
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -106,7 +106,8 @@ class KafkaApis(val requestChannel: RequestChannel,
val clusterId:
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378828818
##
core/src/main/java/kafka/server/ClientMetricsManager.java:
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378827876
##
core/src/test/java/kafka/metrics/ClientMetricsTestUtils.java:
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378825692
##
core/src/main/java/kafka/metrics/ClientMetricsConfigs.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378824753
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -129,6 +130,25 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig,
junrao commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1378220184
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -129,6 +130,25 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1786178001
> > @apoorvmittal10 : Yes, we are gradually moving the codebase to java.
Ideally, all new classes should be written in java.
>
> Thanks @junrao, I ll update the PR by
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376884298
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376884030
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376883781
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376883099
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376882728
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1781794070
> @apoorvmittal10 : Yes, we are gradually moving the codebase to java.
Ideally, all new classes should be written in java.
Thanks @junrao, I ll update the PR by tomorrow
junrao commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1781627127
@apoorvmittal10 : Yes, we are gradually moving the codebase to java.
Ideally, all new classes should be written in java.
--
This is an automated message from the Apache Git Service.
To
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1780865857
> Hi @apoorvmittal10 Thanks for taking my suggestions. I left a few more,
mostly about the aesthetic aspect as scala is a pretty idiomatic language...
>
> Terribly sorry
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372950150
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372949389
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372948398
##
core/src/test/scala/kafka/metrics/ClientMetricsTestUtils.scala:
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372943465
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372939620
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372479451
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372479451
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372471968
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372471968
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1780279268
Hi @apoorvmittal10 Thanks for taking my suggestions. I left a few more,
mostly about the aesthetic aspect as scala is a pretty idiomatic language...
Terribly sorry that I don't
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372471968
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372467166
##
core/src/test/scala/kafka/metrics/ClientMetricsTestUtils.scala:
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372460806
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372457923
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372452303
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372451618
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372047782
##
core/src/test/scala/kafka/metrics/ClientMetricsTestUtils.scala:
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372046737
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372045729
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372047546
##
core/src/main/scala/kafka/server/ZkConfigManager.scala:
##
@@ -38,7 +38,8 @@ object ConfigType {
val User = "users"
val Broker = "brokers"
val Ip =
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372046033
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372045362
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1372044581
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2619,6 +2619,9 @@ private ConfigEntry.ConfigSource
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371125365
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371110225
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371108662
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371112996
##
core/src/test/scala/kafka/metrics/ClientMetricsTestUtils.scala:
##
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371110225
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371108662
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
philipnee commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1371106132
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
AndrewJSchofield commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370842597
##
core/src/main/scala/kafka/server/ZkConfigManager.scala:
##
@@ -38,7 +38,8 @@ object ConfigType {
val User = "users"
val Broker = "brokers"
val Ip
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370337227
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370328410
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1777187883
Thanks @AndrewJSchofield for the feedback, I have addressed comments.
The only think which I do not see is re2/j being used in Kafka yet. I can
see an open ticket which
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370137894
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -483,6 +483,12 @@ class ControllerApis(
} else {
new
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370137491
##
clients/src/main/java/org/apache/kafka/common/resource/ResourceType.java:
##
@@ -68,7 +68,12 @@ public enum ResourceType {
/**
* A user principal
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370136474
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2754,6 +2754,8 @@ class KafkaApis(val requestChannel: RequestChannel,
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370136149
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -57,13 +58,15 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370136799
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2916,6 +2918,8 @@ class KafkaApis(val requestChannel: RequestChannel,
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370134733
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370132784
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370133284
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370132076
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1370131667
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
AndrewJSchofield commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369865768
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1776855456
Build fails because of flaky tests
```
9 tests have failed
There are 0 new tests failing, 9 existing failing and 152 skipped.
```
```
Existing failures - 9
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369416326
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369415500
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369413838
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 opened a new pull request, #14621:
URL: https://github.com/apache/kafka/pull/14621
This PR add resources to store and handle client metrics needed for KIP-714
as defined
86 matches
Mail list logo
