[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-06 Thread GitBox
dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r420615938 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -477,6 +484,27 @@ public void testCreateTopics() throws Ex

[GitHub] [kafka] dajac commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-05-06 Thread GitBox
dajac commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r420625625 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -84,6 +87,15 @@ object ConsumerGroupCommand extends Logging { } } +

[jira] [Assigned] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-06 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-9929: --- Assignee: Jorge Esteban Quilcate Otoya > Support reverse ite

[jira] [Commented] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-06 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100584#comment-17100584 ] Jorge Esteban Quilcate Otoya commented on KAFKA-9929: - If these looks

[GitHub] [kafka] tombentley commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-06 Thread GitBox
tombentley commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r420644795 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1402,6 +1407,15 @@ int numPendingCalls() { retu

[GitHub] [kafka] big-andy-coates commented on a change in pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-05-06 Thread GitBox
big-andy-coates commented on a change in pull request #8483: URL: https://github.com/apache/kafka/pull/8483#discussion_r420651255 ## File path: streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java ## @@ -1643,6 +1663,8 @@ public void process(fi

[GitHub] [kafka] big-andy-coates commented on a change in pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-05-06 Thread GitBox
big-andy-coates commented on a change in pull request #8483: URL: https://github.com/apache/kafka/pull/8483#discussion_r420651255 ## File path: streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java ## @@ -1643,6 +1663,8 @@ public void process(fi

[GitHub] [kafka] big-andy-coates commented on pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

2020-05-06 Thread GitBox
big-andy-coates commented on pull request #8483: URL: https://github.com/apache/kafka/pull/8483#issuecomment-624541783 Hey @mjsax, sorry for the delay. All changes made. Only outstanding issue is the [global table testing](https://github.com/apache/kafka/pull/8483#discussion_r4206512

[GitHub] [kafka] dajac commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-06 Thread GitBox
dajac commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r420664331 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1402,6 +1407,15 @@ int numPendingCalls() { return ru

[GitHub] [kafka] alozano3 commented on pull request #7284: KAFKA-8863 - [WIP] Add InsertHeader and DropHeader transforms for connect

2020-05-06 Thread GitBox
alozano3 commented on pull request #7284: URL: https://github.com/apache/kafka/pull/7284#issuecomment-624548069 > Thanks for the PR, @alozano3. The SMT implementations look pretty good, but unfortunately any changes to `ConfigDef` will require a KIP. My recommendation is to avoid making an

[jira] [Commented] (KAFKA-3240) Replication issues

2020-05-06 Thread shailesh ranjan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100736#comment-17100736 ] shailesh ranjan commented on KAFKA-3240: Did anyone manage to solve the issue? >

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread GitBox
viktorsomogyi commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r420753993 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue]

[GitHub] [kafka] ijuma commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread GitBox
ijuma commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r420802979 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue] = Revi

[GitHub] [kafka] lkokhreidze removed a comment on pull request #8558: KAFKA-8611 / KIP-221 documentation

2020-05-06 Thread GitBox
lkokhreidze removed a comment on pull request #8558: URL: https://github.com/apache/kafka/pull/8558#issuecomment-624660155 test this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation

2020-05-06 Thread GitBox
lkokhreidze commented on pull request #8558: URL: https://github.com/apache/kafka/pull/8558#issuecomment-624660155 test this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-06 Thread GitBox
ijuma commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r420805481 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else Fet

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420806232 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -32,12 +32,23 @@ public class Remov

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420806232 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -32,12 +32,23 @@ public class Remov

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420824271 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3621,24 +3641,37 @@ public RemoveMembersFromConsumerGrou

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420824572 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] rhauch commented on pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-06 Thread GitBox
rhauch commented on pull request #8620: URL: https://github.com/apache/kafka/pull/8620#issuecomment-624682689 okay to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420848223 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] tombentley commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-06 Thread GitBox
tombentley commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r420861864 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1402,6 +1407,15 @@ int numPendingCalls() { retu

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420568190 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-06 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r420568190 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3612,6 +3611,27 @@ private boolean dependsOnSpecificNode

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread GitBox
viktorsomogyi commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r420878993 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue]

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420900467 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -166,27 +244,105 @@ private void pause() {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420895742 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(Tar

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420905737 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1182,28 +1251,47 @@ public Void cal

[GitHub] [kafka] rhauch commented on a change in pull request #8620: KAFKA-9944: Added supporting customized HTTP response headers for Kafka Connect.

2020-05-06 Thread GitBox
rhauch commented on a change in pull request #8620: URL: https://github.com/apache/kafka/pull/8620#discussion_r420837649 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -427,4 +435,62 @@ public void ensureValid(String name,

[GitHub] [kafka] hachikuji commented on pull request #7609: KAFKA-9059: Implement ReassignmentMaxLag

2020-05-06 Thread GitBox
hachikuji commented on pull request #7609: URL: https://github.com/apache/kafka/pull/7609#issuecomment-624745120 The fetchers already have lag tracking through `FetcherLagStats` (in `AbstractFetcherThread`). If we are adding the reassignment lag on the follower as well, that seems like the

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420918078 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -82,6 +82,9 @@ // we need t

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420920161 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java ## @@ -97,6 +100,15 @@ public Connecto

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420919710 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420931273 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420931273 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[jira] [Created] (KAFKA-9962) Admin client throws UnsupportedVersion exception when talking to old broker

2020-05-06 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-9962: - Summary: Admin client throws UnsupportedVersion exception when talking to old broker Key: KAFKA-9962 URL: https://issues.apache.org/jira/browse/KAFKA-996

[jira] [Updated] (KAFKA-9962) Admin client throws UnsupportedVersion exception when talking to old broker

2020-05-06 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-9962: -- Description: Users are getting this error when using a client version 2

[GitHub] [kafka] ijuma commented on a change in pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
ijuma commented on a change in pull request #8602: URL: https://github.com/apache/kafka/pull/8602#discussion_r420942672 ## File path: core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala ## @@ -156,17 +152,26 @@ class TransactionsBounceTest extends KafkaServ

[GitHub] [kafka] zhaohaidao commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-05-06 Thread GitBox
zhaohaidao commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-624766057 @mjsax hi, failed tests have been fixed. Could you retest this? This is an automated message from the Apache Gi

[GitHub] [kafka] hachikuji commented on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread GitBox
hachikuji commented on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-624765632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] bdbyrne opened a new pull request #8624: KAFKA-9942: Fix bootstrap-server default users/clients handling in ConfigCommand.

2020-05-06 Thread GitBox
bdbyrne opened a new pull request #8624: URL: https://github.com/apache/kafka/pull/8624 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade not

[GitHub] [kafka] hachikuji commented on a change in pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
hachikuji commented on a change in pull request #8602: URL: https://github.com/apache/kafka/pull/8602#discussion_r420948852 ## File path: core/src/test/scala/integration/kafka/api/TransactionsBounceTest.scala ## @@ -156,17 +152,26 @@ class TransactionsBounceTest extends Kafka

[jira] [Commented] (KAFKA-9962) Admin client throws UnsupportedVersion exception when talking to old broker

2020-05-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101007#comment-17101007 ] Ismael Juma commented on KAFKA-9962: Good catch. We should update the compatibility s

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420950647 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -193,13 +194,11 @@ public void transitionTo(Targ

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r420963881 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -191,32 +192,61 @@ public synchronized

[jira] [Updated] (KAFKA-9919) Add logging to KafkaBasedLog

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9919: -- Fix Version/s: 2.4.2 2.3.2 > Add logging to KafkaBasedLog >

[jira] [Updated] (KAFKA-9830) DeadLetterQueueReporter leaks KafkaProducer instance

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9830: -- Fix Version/s: 2.4.2 2.3.2 > DeadLetterQueueReporter leaks K

[GitHub] [kafka] C0urante commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-624788853 Thanks for the review, @gharris1727. I've addressed all of your comments with either changes or responses; let me know what you think. @kkonstantine -- there are a few plac

[GitHub] [kafka] hachikuji commented on a change in pull request #8239: KAFKA-9666: Don't increase transactional epoch when trying to fence if the log append fails

2020-05-06 Thread GitBox
hachikuji commented on a change in pull request #8239: URL: https://github.com/apache/kafka/pull/8239#discussion_r420974886 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -487,6 +487,33 @@ class TransactionCoordinator(brokerI

[jira] [Updated] (KAFKA-9633) ConfigProvider.close() not called

2020-05-06 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9633: -- Fix Version/s: 2.4.2 2.3.2 > ConfigProvider.close() not call

[GitHub] [kafka] kkonstantine commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
kkonstantine commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624801890 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] belugabehr commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
belugabehr commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624803800 @kkonstantine I appreciate your help getting this over the finish line This is an automated message from the Ap

[GitHub] [kafka] kkonstantine commented on pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-05-06 Thread GitBox
kkonstantine commented on pull request #7950: URL: https://github.com/apache/kafka/pull/7950#issuecomment-624808716 Definitely. It's a nice fix. Thanks for contributing it @belugabehr This is an automated message from the Ap

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] nizhikov commented on pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

2020-05-06 Thread GitBox
nizhikov commented on pull request #8592: URL: https://github.com/apache/kafka/pull/8592#issuecomment-624815018 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] kkonstantine commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
kkonstantine commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421005156 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r421009491 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[jira] [Resolved] (KAFKA-4969) State-store workload-aware StreamsPartitionAssignor

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-4969. Fix Version/s: (was: 1.1.0) 2.6.0 Resolution: Fixed T

[GitHub] [kafka] gharris1727 commented on a change in pull request #8618: KAFKA-9955: Prevent SinkTask::close from shadowing other exceptions

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8618: URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java ## @@ -856,6 +858,47 @@ public void run() {

[GitHub] [kafka] kkonstantine commented on pull request #8360: KAFKA-9768: Fix handling of rest.advertised.listener config

2020-05-06 Thread GitBox
kkonstantine commented on pull request #8360: URL: https://github.com/apache/kafka/pull/8360#issuecomment-624821936 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Resolved] (KAFKA-8207) StickyPartitionAssignor for KStream

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-8207. Resolution: Not A Problem Closing this as "Not a Problem" as the partition assignor

[jira] [Resolved] (KAFKA-8858) Kafka Streams - Failed to Rebalance Error and stream consumer stuck for some reason

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-8858. Assignee: Guozhang Wang Resolution: Duplicate > Kafka Streams - Failed to Reb

[jira] [Resolved] (KAFKA-6063) StreamsException is thrown after the changing `partitions`

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-6063. Resolution: Not A Problem > StreamsException is thrown after the changing `partitio

[jira] [Resolved] (KAFKA-9112) Combine streams `onAssignment` with `partitionsAssigned` task creation

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-9112. Fix Version/s: 2.6.0 Assignee: Guozhang Wang Resolution: Fixed Thin

[GitHub] [kafka] hachikuji commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-06 Thread GitBox
hachikuji commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r421026806 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else

[GitHub] [kafka] hachikuji opened a new pull request #8625: MINOR: Only add 'Data' suffix for generated request/response/header types

2020-05-06 Thread GitBox
hachikuji opened a new pull request #8625: URL: https://github.com/apache/kafka/pull/8625 Currently we add "Data" to all generated classnames in order to avoid naming collisions. Generated classes for other persistent schema definitions (such as those used in `GroupCoordinator` and `Transa

[GitHub] [kafka] rhauch commented on pull request #8230: KAFKA-9667: Connect JSON serde strip trailing zeros

2020-05-06 Thread GitBox
rhauch commented on pull request #8230: URL: https://github.com/apache/kafka/pull/8230#issuecomment-624837748 okay to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
hachikuji commented on pull request #8602: URL: https://github.com/apache/kafka/pull/8602#issuecomment-624842318 I changed the patch to set the request timeout the same as the delivery timeout for this test case, which was the old behavior.

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1710#comment-1710 ] Georgi Petkov commented on KAFKA-9921: -- [~ableegoldman] Did you get to read my last

[GitHub] [kafka] ijuma commented on a change in pull request #8585: KAFKA-9938; Debug consumer should be able to fetch from followers

2020-05-06 Thread GitBox
ijuma commented on a change in pull request #8585: URL: https://github.com/apache/kafka/pull/8585#discussion_r421039469 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig, else Fet

[GitHub] [kafka] ijuma commented on pull request #8602: KAFKA-9947; Ensure proper shutdown of components in `TransactionsBounceTest`

2020-05-06 Thread GitBox
ijuma commented on pull request #8602: URL: https://github.com/apache/kafka/pull/8602#issuecomment-624845577 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Assigned] (KAFKA-6342) Move workaround for JSON parsing of non-escaped strings

2020-05-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-6342: -- Fix Version/s: 2.6.0 Assignee: Viktor Somogyi-Vass (was: Umesh Chaudhary)

[jira] [Updated] (KAFKA-6342) Remove workaround for JSON parsing of non-escaped strings

2020-05-06 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-6342: --- Summary: Remove workaround for JSON parsing of non-escaped strings (was: Move workaround for

[GitHub] [kafka] cmccabe commented on pull request #8625: MINOR: Only add 'Data' suffix for generated request/response/header types

2020-05-06 Thread GitBox
cmccabe commented on pull request #8625: URL: https://github.com/apache/kafka/pull/8625#issuecomment-624851509 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ableegoldman opened a new pull request #8626: KAFKA-9921: explicit handling of null values with retainDuplicates

2020-05-06 Thread GitBox
ableegoldman opened a new pull request #8626: URL: https://github.com/apache/kafka/pull/8626 In general the behavior of window stores with `retainDuplicates` is not well documented or enforced, so we should attempt to clarify things better in the javadocs and in the code itself. This expli

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101130#comment-17101130 ] Sophie Blee-Goldman commented on KAFKA-9921: Thanks for the reminder, just op

[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-06 Thread GitBox
d8tltanc commented on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586 Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs() This is an aut

[GitHub] [kafka] andrewchoi5 commented on pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-05-06 Thread GitBox
andrewchoi5 commented on pull request #8479: URL: https://github.com/apache/kafka/pull/8479#issuecomment-624858200 @mjsax Hi Matthias, would you happen to know if there were any other reviewers available? I don't mind waiting, but was curious what the ETA usually appears to be. -

[GitHub] [kafka] ableegoldman commented on pull request #8616: KAFKA-9127: don't create StreamThreads for global-only topology (2.4)

2020-05-06 Thread GitBox
ableegoldman commented on pull request #8616: URL: https://github.com/apache/kafka/pull/8616#issuecomment-624859671 @vvcephei Both Java 11 builds passed, Java 8 failed with flaky `DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners` `BranchedMultiLevelRepartitionConnectedTopo

[GitHub] [kafka] d8tltanc edited a comment on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586 Thanks for the review. Since we are adding a unit test, move the argument checking in checkArgs() Edit: Since the existing tests are assuming that alter user entity type

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790 I think `ClientQuotaEntity` is only used in client quota alternation. But the description doesn't use that. Update: I've pushed the my latest local changes if that helps

[GitHub] [kafka] scott-hendricks opened a new pull request #8627: MINOR - Increase Trogdor Histogram buckets for latency to 10000ms

2020-05-06 Thread GitBox
scott-hendricks opened a new pull request #8627: URL: https://github.com/apache/kafka/pull/8627 The current latency histograms for ProduceBenchWorker and ConsumeBenchWorker are limited to 5000ms, causing the histograms to truncate and report 5000ms on requests that take longer. This incre

[GitHub] [kafka] cmccabe commented on pull request #8627: MINOR - Increase Trogdor Histogram buckets for latency to 10000ms

2020-05-06 Thread GitBox
cmccabe commented on pull request #8627: URL: https://github.com/apache/kafka/pull/8627#issuecomment-624872970 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] d8tltanc edited a comment on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-06 Thread GitBox
d8tltanc edited a comment on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790 I think `ClientQuotaEntity` is only used in client quota alternation. But the description doesn't use that. Update: I've pushed my latest local changes if that helps. My

[jira] [Updated] (KAFKA-9780) Deprecate commit records without record metadata

2020-05-06 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9780: - Fix Version/s: 2.6.0 > Deprecate commit records without record metadata > ---

[GitHub] [kafka] gharris1727 commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
gharris1727 commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421079889 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -239,9 +236,10 @@ private synchroni

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421091035 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -239,9 +236,10 @@ private synchronized

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-05-06 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r421091305 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -536,20 +561,37 @@ private void proc

[GitHub] [kafka] rhauch commented on pull request #2604: KAFKA-4794: Add access to OffsetStorageReader from SourceConnector

2020-05-06 Thread GitBox
rhauch commented on pull request #2604: URL: https://github.com/apache/kafka/pull/2604#issuecomment-624891952 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on pull request #8379: KAFKA-9780: Deprecate commit records without record metadata

2020-05-06 Thread GitBox
rhauch commented on pull request #8379: URL: https://github.com/apache/kafka/pull/8379#issuecomment-624894538 Still waiting for final approval of https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata -

[GitHub] [kafka] bdbyrne opened a new pull request #8628: KAFKA-9942: Fixes ConfigCommand client quotas w/ default users.

2020-05-06 Thread GitBox
bdbyrne opened a new pull request #8628: URL: https://github.com/apache/kafka/pull/8628 Fixes ConfigCommand client quotas w/ default users when using --bootstrap-servers. Test is expanded to handle all valid (user, client-id) enumerations. ### Committer Checklist (excluded fro

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-05-06 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101215#comment-17101215 ] Georgi Petkov commented on KAFKA-9921: -- Maybe we can add the same information on the

[jira] [Created] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
Evan Williams created KAFKA-9963: Summary: High CPU Key: KAFKA-9963 URL: https://issues.apache.org/jira/browse/KAFKA-9963 Project: Kafka Issue Type: Bug Components: core Affects

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

[jira] [Updated] (KAFKA-9963) High CPU

2020-05-06 Thread Evan Williams (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Williams updated KAFKA-9963: - Description: When replacing a broker, with an empty data dir, and the same broker ID - we are se

  1   2   >