[GitHub] [kafka] chia7712 commented on pull request #8599: HOTFIX: ambiguous reference of Properties#putAll in java 11 and scala…

chia7712 commented on pull request #8599: URL: https://github.com/apache/kafka/pull/8599#issuecomment-622284362 It seems to me it would be better to have a QA for java 11 + scala 2.12 if the it is still supported by kafka community.

[GitHub] [kafka] d8tltanc commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

d8tltanc commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-622330041 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] chia7712 edited a comment on pull request #8599: HOTFIX: ambiguous reference of Properties#putAll in java 11 and scala…

chia7712 edited a comment on pull request #8599: URL: https://github.com/apache/kafka/pull/8599#issuecomment-622284362 It seems to me it would be better to have a QA for java 11 + scala 2.12 if it is still supported by kafka community.

[GitHub] [kafka] leonardge opened a new pull request #8566: Fix minor code issue

leonardge opened a new pull request #8566: URL: https://github.com/apache/kafka/pull/8566 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r416215513 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java ## @@ -265,12 +270,27 @@ public void

[GitHub] [kafka] bdbyrne commented on pull request #7982: MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.

bdbyrne commented on pull request #7982: URL: https://github.com/apache/kafka/pull/7982#issuecomment-620299402 Test failure unrelated: ```kafka.api.CustomQuotaCallbackTest > testCustomQuotaCallback STARTED

[GitHub] [kafka] bdbyrne edited a comment on pull request #7982: MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.

bdbyrne edited a comment on pull request #7982: URL: https://github.com/apache/kafka/pull/7982#issuecomment-620299402 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on a change in pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

vvcephei commented on a change in pull request #8564: URL: https://github.com/apache/kafka/pull/8564#discussion_r416232363 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java ## @@ -56,6 +59,11 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416237829 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -712,31 +712,32 @@ private

[GitHub] [kafka] michael-trelinski edited a comment on pull request #6295: KIP-382: MirrorMaker 2.0

michael-trelinski edited a comment on pull request #6295: URL: https://github.com/apache/kafka/pull/6295#issuecomment-620318837 Hi @ryannedolan - I just got done setting up Mirror Maker V2 where I work. It was successful, but the documentation doesn't match the code in various

[GitHub] [kafka] michael-trelinski edited a comment on pull request #6295: KIP-382: MirrorMaker 2.0

michael-trelinski edited a comment on pull request #6295: URL: https://github.com/apache/kafka/pull/6295#issuecomment-620318837 https://user-images.githubusercontent.com/4055823/80436066-191bd780-88b3-11ea-8b3d-8e2c6b6c0b87.png;> Hi @ryannedolan - I just got done setting up

[GitHub] [kafka] thspinto commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

thspinto commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-620331815 > @ning2008wisc what happens in a situation where i have a single consumer group subscribing to multiple topics . Let's say we have two sites - Site A and Site B and three

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416179915 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/HighAvailabilityStreamsPartitionAssignorTest.java ## @@ -0,0 +1,326

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416217370 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -147,6 +149,9 @@ private void

[GitHub] [kafka] ijuma commented on pull request #7982: MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.

ijuma commented on pull request #7982: URL: https://github.com/apache/kafka/pull/7982#issuecomment-620302757 LGTM, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416245374 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/FallbackPriorTaskAssignor.java ## @@ -0,0 +1,49 @@ +/* +

[GitHub] [kafka] michael-trelinski edited a comment on pull request #6295: KIP-382: MirrorMaker 2.0

michael-trelinski edited a comment on pull request #6295: URL: https://github.com/apache/kafka/pull/6295#issuecomment-620318837 https://user-images.githubusercontent.com/4055823/80436066-191bd780-88b3-11ea-8b3d-8e2c6b6c0b87.png;> Hi @ryannedolan - I just got done setting up Mirror

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416178865 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -147,6 +149,9 @@ private void

[GitHub] [kafka] leonardge commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

leonardge commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r416186838 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] leonardge commented on pull request #8566: Fix minor code issue

leonardge commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620271135 @junrao here is the follower up PR. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620271189 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416199492 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] hachikuji commented on pull request #6865: KAFKA-8472: Use composition for better isolation of fetcher logic

hachikuji commented on pull request #6865: URL: https://github.com/apache/kafka/pull/6865#issuecomment-620276146 Closing this. I do not have the time to rebase and seems we can do without the changes. I will consider reopening in the future.

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414822929 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416234425 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/FallbackPriorTaskAssignor.java ## @@ -0,0 +1,49 @@ +/* + *

[GitHub] [kafka] d8tltanc commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

d8tltanc commented on pull request #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-62030 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3917/console Link for the system tests ⬆️

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620313280 @vvcephei Looks like we have some flakies. But I think we can get a review in. :) This is an

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416200976 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] ijuma opened a new pull request #8567: KAFKA-9652: Fix throttle metric in RequestChannel and request log due to KIP-219

ijuma opened a new pull request #8567: URL: https://github.com/apache/kafka/pull/8567 After KIP-219, responses are sent immediately and we rely on a combination of clients and muting of the channel to throttle. The result of this is that we need to track `apiThrottleTimeMs` as an

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416223395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] ableegoldman commented on a change in pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

ableegoldman commented on a change in pull request #8564: URL: https://github.com/apache/kafka/pull/8564#discussion_r416233782 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimestampedWindowStoreBuilder.java ## @@ -56,6 +59,11 @@ public

[GitHub] [kafka] guozhangwang commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response

guozhangwang commented on pull request #8548: URL: https://github.com/apache/kafka/pull/8548#issuecomment-620300754 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416233922 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -147,6 +149,9 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416237002 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -86,6 +90,22 @@ private

[GitHub] [kafka] cmccabe commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

cmccabe commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-620310659 thanks for revising this. Let's get rid of the `@Ignore` on the tests here since we still do have the --zookeeper flags

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416249206 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] michael-trelinski commented on pull request #6295: KIP-382: MirrorMaker 2.0

michael-trelinski commented on pull request #6295: URL: https://github.com/apache/kafka/pull/6295#issuecomment-620318837 Hi @ryannedolan - I just got done setting up Mirror Maker V2 where I work. It was successful, but the documentation doesn't match the code in various places.

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416185907 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] junrao commented on pull request #8566: Fix minor code issue

junrao commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620311966 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416248165 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] michael-trelinski edited a comment on pull request #6295: KIP-382: MirrorMaker 2.0

michael-trelinski edited a comment on pull request #6295: URL: https://github.com/apache/kafka/pull/6295#issuecomment-620318837 https://user-images.githubusercontent.com/4055823/80436066-191bd780-88b3-11ea-8b3d-8e2c6b6c0b87.png;> Hi @ryannedolan - I just got done setting up Mirror

[GitHub] [kafka] d8tltanc edited a comment on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

d8tltanc edited a comment on pull request #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-62030 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3918/console Link for the system tests ⬆️

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622372958 oh, sorry I didn't run the Checkstyle and spotbugs quality checks locally, I will update shortly with these fixed

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622417550 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)

vvcephei commented on pull request #8595: URL: https://github.com/apache/kafka/pull/8595#issuecomment-622422628 The only failing test this time was org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin, which is already under investigation.

[GitHub] [kafka] vvcephei commented on pull request #8597: KAFKA-6145: KIP 441 remove balance factor

vvcephei commented on pull request #8597: URL: https://github.com/apache/kafka/pull/8597#issuecomment-622421983 Failing test org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin is already under investigation.

[GitHub] [kafka] viktorsomogyi removed a comment on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

viktorsomogyi removed a comment on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-621919693 ok to test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] nizhikov opened a new pull request #8592: KAFKA-3184: Add Checkpoint for In-memory State Store

nizhikov opened a new pull request #8592: URL: https://github.com/apache/kafka/pull/8592 Persistent mode for InMemoryKeyValueStore. If persistent mode is enabled then: * checkpoint thread started on `KeyValueStore#init` * every `InMemoryKeyValueStore#COUNT_FLUSH_TO_STORE`

[GitHub] [kafka] viktorsomogyi commented on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

viktorsomogyi commented on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-621919693 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] viktorsomogyi commented on pull request #4321: KAFKA-6342 : Move workaround for JSON parsing of non-escaped strings

viktorsomogyi commented on pull request #4321: URL: https://github.com/apache/kafka/pull/4321#issuecomment-621861644 @ijuma can't force push to this branch so I couldn't rebase it. Created #8591 that continues the work that Umesh started. Would you please review that?

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #8151: MINOR: Add missing @Test annotations to miscellaneous tests

stanislavkozlovski commented on a change in pull request #8151: URL: https://github.com/apache/kafka/pull/8151#discussion_r417989966 ## File path: core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala ## @@ -77,17 +80,17 @@ class AdvertiseBrokerTest extends

[GitHub] [kafka] viktorsomogyi opened a new pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

viktorsomogyi opened a new pull request #8591: URL: https://github.com/apache/kafka/pull/8591 PR #4303 introduced parsing for some invalid JSONs, such as escaped SSL names. This PR moves the parsing directly under AclEntry to localize this logic. ### Committer Checklist (excluded

[GitHub] [kafka] ijuma commented on a change in pull request #8151: MINOR: Add missing @Test annotations to miscellaneous tests

ijuma commented on a change in pull request #8151: URL: https://github.com/apache/kafka/pull/8151#discussion_r418038810 ## File path: core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala ## @@ -65,9 +67,10 @@ class AdvertiseBrokerTest extends ZooKeeperTestHarness {

[GitHub] [kafka] ijuma commented on a change in pull request #8151: MINOR: Add missing @Test annotations to miscellaneous tests

ijuma commented on a change in pull request #8151: URL: https://github.com/apache/kafka/pull/8151#discussion_r418039254 ## File path: core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala ## @@ -77,17 +80,17 @@ class AdvertiseBrokerTest extends ZooKeeperTestHarness {

[GitHub] [kafka] edoardocomar commented on pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

edoardocomar commented on pull request #8586: URL: https://github.com/apache/kafka/pull/8586#issuecomment-621942562 Hi @hachikuji as you're working on this ... do you mind taking a look at https://github.com/apache/kafka/pull/4204 ? the test we have added there still fails with this

[GitHub] [kafka] edoardocomar commented on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on pull request #4204: URL: https://github.com/apache/kafka/pull/4204#issuecomment-621942937 @hachikuji would you like to take a look as you're working on https://github.com/apache/kafka/pull/8586

[GitHub] [kafka] edoardocomar commented on pull request #4204: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on pull request #4204: URL: https://github.com/apache/kafka/pull/4204#issuecomment-621934277 rebased and retested This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma commented on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

ijuma commented on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-621875694 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

ijuma commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r418035530 ## File path: core/src/main/scala/kafka/security/authorizer/AclEntry.scala ## @@ -92,6 +95,23 @@ object AclEntry { }.getOrElse(Set.empty) } + /**

[GitHub] [kafka] viktorsomogyi commented on pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

viktorsomogyi commented on pull request #8591: URL: https://github.com/apache/kafka/pull/8591#issuecomment-621919298 Removed `TopicCount`. That was probably a leftover from the rebase, I guess the merge tool didn't delete it correctly or something.

[GitHub] [kafka] edoardocomar commented on pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

edoardocomar commented on pull request #8586: URL: https://github.com/apache/kafka/pull/8586#issuecomment-621943779 cc @mimaison This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #8590: KAFKA-6145: Remove check to reuse previous assignment

vvcephei commented on pull request #8590: URL: https://github.com/apache/kafka/pull/8590#issuecomment-621925124 Test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-622614438 @feyman2016 Only committers can trigger Jenkins retesting... Retest this please. This is an automated

[GitHub] [kafka] mjsax commented on pull request #8555: KAFKA-9920:Fix NetworkDegradeTest.test_rate test error

mjsax commented on pull request #8555: URL: https://github.com/apache/kafka/pull/8555#issuecomment-622648385 I am not familiar with this code. Maybe @mumrah or @cmccabe can help? This is an automated message from the Apache

[GitHub] [kafka] mjsax edited a comment on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax edited a comment on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-618073161 > Ideally, the fix should be to generate a repartition topic name each time to avoid such issues. But IMHO that ship has already sailed because by introducing a new name

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622652864 Version probing test passing locally now, kicked off a branch builder to confirm: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3927/

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418852189 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -789,7 +789,7 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418791000 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -556,14 +548,8 @@ void runLoop() {

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418813975 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java ## @@ -104,6 +114,54 @@ public void

[GitHub] [kafka] mjsax edited a comment on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

mjsax edited a comment on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723 Thanks for the update. I'll wait for Jenkins and do another pass afterwards. This is an automated message

[GitHub] [kafka] mjsax commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

mjsax commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651782 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax edited a comment on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

mjsax edited a comment on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723 Thanks for the update. I'll wait for Jenkins and do another pass afterwards. Btw: the comment "Retest this please" is not for you, but for Jenkins to run the build :)

[GitHub] [kafka] mjsax commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

mjsax commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723 Thanks for the update. I'll wait for Jenkins and do another pass afterwards. Retest this please. This is an

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418837867 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -70,18 +69,16 @@ static void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418838526 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -70,18 +69,16 @@ static void

[GitHub] [kafka] mjsax commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

mjsax commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622632765 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418794862 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1423,22 +1434,44 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] mjsax edited a comment on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

mjsax edited a comment on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622654288 @guozhangwang The failing test run has truncate logs. So it's hard to know what the root cause it. The high level "pattern" seems to be similar to what we have observed

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418840101 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -789,7 +789,7 @@ private void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418838526 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -70,18 +69,16 @@ static void

[GitHub] [kafka] feyman2016 commented on pull request #8020: KAFKA-9146 [WIP]: Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8020: URL: https://github.com/apache/kafka/pull/8020#issuecomment-622673014 @mjsax Thanks for closing this. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418793917 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1338,7 +1346,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

ableegoldman commented on a change in pull request #8596: URL: https://github.com/apache/kafka/pull/8596#discussion_r418793644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1009,14 +1018,18 @@ private

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418816470 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] zhaohaidao commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418817105 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -633,6 +634,43 @@ public final void

[GitHub] [kafka] mjsax commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

mjsax commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-622651059 > we should create two repartiton topics as that's what the user is expecting. Is she? I guess it's clearly document that the name is use for repartition topics, too, but it

[GitHub] [kafka] zhaohaidao commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651191 > Retest this please. @mjsax I have modified the codes according to your suggestion and passed the test. Could you continue to review it?

[GitHub] [kafka] mjsax commented on pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest

mjsax commented on pull request #8600: URL: https://github.com/apache/kafka/pull/8600#issuecomment-622653176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418830079 ## File path: checkstyle/suppressions.xml ## @@ -156,7 +156,7 @@

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622653502 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-622653480 Java 11 passed. Java 8: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]

[GitHub] [kafka] vvcephei commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

vvcephei commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r418851326 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -70,18 +69,16 @@ static void

[GitHub] [kafka] mjsax commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

mjsax commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-622513778 @vvcephei Cherry-picking to 2.4 did not work? There might still be a 2.4.2 releae. This is an automated message

[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)

vvcephei commented on pull request #8595: URL: https://github.com/apache/kafka/pull/8595#issuecomment-622527480 Thanks, @mjsax ! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing

hachikuji commented on pull request #8551: URL: https://github.com/apache/kafka/pull/8551#issuecomment-622590281 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on a change in pull request #8591: KAFKA-6342: Move workaround for JSON parsing of non-escaped strings

ijuma commented on a change in pull request #8591: URL: https://github.com/apache/kafka/pull/8591#discussion_r418778470 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -35,16 +35,7 @@ object Json { */ def parseFull(input: String): Option[JsonValue] =

[GitHub] [kafka] cmccabe commented on pull request #8527: Remove dependencies on deprecated --zookeeper command flags in junit tests

cmccabe commented on pull request #8527: URL: https://github.com/apache/kafka/pull/8527#issuecomment-622610148 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

mjsax commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r418784189 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java ## @@ -104,6 +114,54 @@ public void

<    2   3   4   5   6   7   8   9   10   11   >