D24609: libiris: Stop using qt_wrap_cpp()

2019-10-18 Thread Raphael Kubo da Costa
rakuco closed this revision. REPOSITORY R434 Kopete REVISION DETAIL https://phabricator.kde.org/D24609 To: rakuco, #kopete, #build_system, apol Cc: kopete-devel, himanshuvishwakarma, cochise

D24609: libiris: Stop using qt_wrap_cpp()

2019-10-13 Thread Raphael Kubo da Costa
rakuco added a reviewer: Build System. REPOSITORY R434 Kopete REVISION DETAIL https://phabricator.kde.org/D24609 To: rakuco, #kopete, #build_system Cc: kopete-devel, himanshuvishwakarma, cochise

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2016-12-29 Thread rakuco (Raphael Kubo da Costa)
rakuco added a comment. Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES

Review Request 126413: FindPyKDE4: Make PYKDE4_INSTALL_PYTHON_FILES use PYTHON_INSTALL.

2015-12-18 Thread Raphael Kubo da Costa
ll callers should work now. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 126413: FindPyKDE4: Make PYKDE4_INSTALL_PYTHON_FILES use PYTHON_INSTALL.

2015-12-18 Thread Raphael Kubo da Costa
marked as submitted. Review request for Build System, kdelibs, Alex Merry, and Luca Beltrame. Changes --- Submitted with commit 016841aeb0b180981122085e9b1d49ae66951670 by Raphael Kubo da Costa to branch KDE/4.14. Repository: kdelibs Description --- Review Request 126345

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-16 Thread Raphael Kubo da Costa
marked as submitted. Review request for Build System, kdelibs and Alex Merry. Changes --- Submitted with commit 94f1d2fa9582a2942d5154b85c849cc3c6140e31 by Raphael Kubo da Costa to branch KDE/4.14. Repository: kdelibs Description --- The `PYTHON_INSTALL()` macro is a wrapper around

Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
in pykde4, FreeBSD and openSUSE contain wrong paths in its .pyc files. With this patch, I was able to verify with `hexdump` that the right path is present in the .pyc files installed by pykde4. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
45/#review89485 --- On Dec. 14, 2015, 6:48 p.m., Raphael Kubo da Costa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 126345: PythonMacros: specify destination directory in byte-compiled files

2015-12-14 Thread Raphael Kubo da Costa
> On Dec. 14, 2015, 8:24 p.m., Alex Merry wrote: > > Seems sensible to me. Are there any potential Python2 vs Python3 issues? > > Raphael Kubo da Costa wrote: > I don't think there are any -- the `.pyc/.pyo` files are installed with a > different name into a differe

Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-11-29 Thread Raphael Kubo da Costa
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125236/#review85550 ------- On Sept. 15, 2015, 11:59 a.m., Raphael Kubo da Costa wrote: > >

Re: Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-11-29 Thread Raphael Kubo da Costa
of a C one. Diffs - cmake/modules/FindQt4.cmake e439a72f82c51758830b057b368407e11a6a541e Diff: https://git.reviewboard.kde.org/r/125236/diff/ Testing --- Adding something C++-specific to qglobal.h (e.g. `#include `) works and the right flags are still detected. Thanks, Raphael Kub

Review Request 125236: FindQt4: Use CHECK_CXX_SYMBOL_EXISTS instead of CHECK_C_SYMBOL_EXISTS.

2015-09-15 Thread Raphael Kubo da Costa
e11a6a541e Diff: https://git.reviewboard.kde.org/r/125236/diff/ Testing --- Adding something C++-specific to qglobal.h (e.g. `#include `) works and the right flags are still detected. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailin

Re: Review Request 119696: KDECompilerSettings: Be more portable across libc's.

2014-08-12 Thread Raphael Kubo da Costa
builds on FreeBSD. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request 119260: Missing target dependency for GUI

2014-08-11 Thread Raphael Kubo da Costa
On Aug. 11, 2014, 12:17 a.m., Raphael Kubo da Costa wrote: Hmm, the 2.3 branch still contains the problematic includes in `src/gui/statusbar.cpp`. Robby, how does branching work in Tellico? I can see that 2.3 is regularly merged into master, but the tags seem to be done to the 2.3

Re: Review Request 119696: KDECompilerSettings: Be more portable across libc's.

2014-08-10 Thread Raphael Kubo da Costa
fdc930e48e489696e137c546fd7e00e0c4797243 Diff: https://git.reviewboard.kde.org/r/119696/diff/ Testing --- Attica builds on FreeBSD. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org

Re: Review Request 119260: Missing target dependency for GUI

2014-08-10 Thread Raphael Kubo da Costa
in `src/gui/statusbar.cpp`. Robby, how does branching work in Tellico? I can see that 2.3 is regularly merged into master, but the tags seem to be done to the 2.3 branch, and the tarball releases also seem to come from it, so packagers are still going to have problems. - Raphael Kubo da Costa

Re: Review Request 119339: Copy updates for PyQt4 build system changes from kdelilbs to e-c-m

2014-07-17 Thread Raphael Kubo da Costa
July 17, 2014, 5:54 p.m.) Review request for Extra Cmake Modules, Alex Merry, Luca Beltrame, Raphael Kubo da Costa, and Simon Edwards. Repository: extra-cmake-modules Description --- Since PyQt 4.10, PyQt.pyqtconfig is deprecated and not available unless PyQt is built using

Re: Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-16 Thread Raphael Kubo da Costa
: https://git.reviewboard.kde.org/r/119302/#review62457 --- On July 16, 2014, 12:19 a.m., Raphael Kubo da Costa wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 119302: Make FindPyQt4 work with PyQt's new build system.

2014-07-15 Thread Raphael Kubo da Costa
to make Kate find PyQt by passing `-DPYQT4_SIP_DIR=...` with my PyQt installation without `pyqtconfig.py`, and calling `FindPyQt.py` by hand on a Debian system with `pyqtconfig.py` worked as before. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem

Re: Review Request 119263: misc: Do not call remove_tree with `safe' set to 1.

2014-07-14 Thread Raphael Kubo da Costa
--- Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Review Request 119263: misc: Do not call remove_tree with `safe' set to 1.

2014-07-13 Thread Raphael Kubo da Costa
Auto{gen,moc}Info.cmake.in, which can be 0444 in some systems. Diffs - kdesrc-build 1932e20962a4a3c226f25128cb9c420e95a5abd6 Diff: https://git.reviewboard.kde.org/r/119263/diff/ Testing --- Thanks, Raphael Kubo da Costa ___ Kde

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

2014-03-04 Thread Raphael Kubo da Costa
land looks better than the one in KDE4. - Raphael Kubo da Costa On March 4, 2014, 11:02 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395

Re: Review Request 112137: Move the clang compiler definitions to a separate block.

2013-08-20 Thread Raphael Kubo da Costa
-fvisibility=hidden do not work for clang, as they parse a GCC version number that's larger than 3.x that clang returns. - Raphael Kubo da Costa On Aug. 18, 2013, 2:37 a.m., Raphael Kubo da Costa wrote: --- This is an automatically generated e

Review Request 112136: e-c-m: Add a separate block for clang definitions.

2013-08-17 Thread Raphael Kubo da Costa
- kde-modules/KDECompilerSettings.cmake 4a9f760b971870c8963cb43bf1b13599ff39a265 Diff: http://git.reviewboard.kde.org/r/112136/diff/ Testing --- Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Review Request 112137: Move the clang compiler definitions to a separate block.

2013-08-17 Thread Raphael Kubo da Costa
been shipping locally for quite a while. I've also been using this to build KDE from git for many months without problems. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: internal lib name vs. output lib name, getting internal dependencies?

2012-08-23 Thread Raphael Kubo da Costa
Friedrich W. H. Kossebau kosse...@kde.org writes: So the settings for the library libkasten2core is like this: libs/kasten/core/CMakeLists.txt has: --- 8 --- kde4_add_library( ${kastencore_LIB} SHARED ${kastencore_LIB_SRCS} ) set_target_properties( ${kastencore_LIB} PROPERTIES

Re: Review Request: Make kdepim-runtime configuration less verbose

2012-08-20 Thread Raphael Kubo da Costa
() calls there? - Raphael Kubo da Costa On Aug. 20, 2012, 3:22 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106101

[extra-cmake-modules] kde-modules: Enable the additional GCC compiler flags on all systems.

2012-08-17 Thread Raphael Kubo da Costa
Git commit 9d5fdf0e88183acf04df225b654e3d77105b80b6 by Raphael Kubo da Costa. Committed on 17/08/2012 at 12:15. Pushed by rkcosta into branch 'master'. Enable the additional GCC compiler flags on all systems. There was no reason to add more flags only on Linux/Hurd; in fact, in kdelibs

Re: -ansi and the default CXX flags (was Re: [PATCH 1/3] Pass additional gcc compiler flags regardless of the OS.)

2012-08-16 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: Not really, how much will break when changing this ? Dropping -ansi doesn't sound too bad to me... I don't think things would break, as dropping -ansi actually means being less strict than before. ___

Re: [PATCH 2/3] Do not add some unneeded linker flags when on BSD.

2012-08-15 Thread Raphael Kubo da Costa
Raphael Kubo da Costa rak...@freebsd.org writes: I guess we're good to go here. Done; I've pushed ad89c051cfd9483f2cb90ed1a5bf8462ba0fa1a2 and 7752d6d5b9b67987d4631cca4ce192069697a4e2 to e-c-m, and backported them to KDE/4.9. ___ Kde-buildsystem

Re: -ansi and the default CXX flags (was Re: [PATCH 1/3] Pass additional gcc compiler flags regardless of the OS.)

2012-08-15 Thread Raphael Kubo da Costa
Raphael Kubo da Costa rak...@freebsd.org writes: Today I felt like doing some archeology work, and it looks like this separation between the Linux/non-Linux case was added in SVN r501434 [1], when FindKDE4.cmake was still in kdesdk. At the time, strtoll(3) failed on FreeBSD when -ansi

-ansi and the default CXX flags (was Re: [PATCH 1/3] Pass additional gcc compiler flags regardless of the OS.)

2012-08-12 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Monday 30 July 2012, Raphael Kubo da Costa wrote: Raphael Kubo da Costa rak...@freebsd.org writes: Building picmi on FreeBSD was failing because of -Wlong-long, which should have been disabled by default via _KDE4_PLATFORM_DEFINITIONS

Re: [PATCH 2/3] Do not add some unneeded linker flags when on BSD.

2012-08-12 Thread Raphael Kubo da Costa
Raphael Kubo da Costa rak...@freebsd.org writes: I can still try to talk to some developers about the historical needs for this flag anyway (I don't really have an urgency to commit this specific patch). Checking the commit history again, -lc was added with FindKDE4.cmake itself in r497823 [1

Re: Review Request: properly pass the NOGUI flag

2012-07-29 Thread Raphael Kubo da Costa
, http://lxr.kde.org/search?filestring=string=kde4_add_unit_test+NOGUI - Raphael Kubo da Costa On July 29, 2012, 11:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [PATCH 2/3] Do not add some unneeded linker flags when on BSD.

2012-07-27 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Monday 23 July 2012, Raphael Kubo da Costa wrote: It is not clear why -lc needed to be passed. It seems to have come with commit 4d1789f40ed1cc6e34e55b9edc119ee6389e1368, but things seem to work just fine without that on FreeBSD. Also remove

Re: [PATCH 3/3] Group all scattered compiler settings.

2012-07-27 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Monday 23 July 2012, Raphael Kubo da Costa wrote: No functional changes: simply put all compiler-related changes in a single block to ease maintenance, and add some comments to explain why some calls are made. Are you sure about them, also e.g

[PATCH 0/3] FindKDE4Internal.cmake compiler code cleanups

2012-07-23 Thread Raphael Kubo da Costa
Hi there, I've sent the following patches via git-send-email instead of ReviewBoard to properly represent the dependencies between each patch (it'd be harder to group the 3 patches in a single patchset using RB). Patch 1 is the only one which contains an actual bug fix -- for some reason, many

[PATCH 1/3] Pass additional gcc compiler flags regardless of the OS.

2012-07-23 Thread Raphael Kubo da Costa
Building picmi on FreeBSD was failing because of -Wlong-long, which should have been disabled by default via _KDE4_PLATFORM_DEFINITIONS. However, commit 4e0bbaee43ecf3fe8c880212da8ad6ca96978c2a made the additional gcc flags be passed only when building on Linux (commit

[PATCH 2/3] Do not add some unneeded linker flags when on BSD.

2012-07-23 Thread Raphael Kubo da Costa
It is not clear why -lc needed to be passed. It seems to have come with commit 4d1789f40ed1cc6e34e55b9edc119ee6389e1368, but things seem to work just fine without that on FreeBSD. Also remove the _GNU_SOURCE definition, as that is only needed by glibc (see feature_test_macros(7) on Linux). ---

[PATCH 3/3] Group all scattered compiler settings.

2012-07-23 Thread Raphael Kubo da Costa
No functional changes: simply put all compiler-related changes in a single block to ease maintenance, and add some comments to explain why some calls are made. --- cmake/modules/FindKDE4Internal.cmake | 56 +++- 1 file changed, 29 insertions(+), 27 deletions(-)

Re: Review Request: ksplashx: Adjust erroneous CMake calls.

2012-07-20 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105468/#review16173 --- Ping? - Raphael Kubo da Costa On July 7, 2012, 3:07 a.m

Re: kdelibs/kdecore/cmakelists KDE4_ENABLE_EXCEPTIONS cmake failure (4.8, 4.9)

2012-07-17 Thread Raphael Kubo da Costa
Michael Pyne mp...@kde.org writes: It looks like it's not a pressing issue given KDE apparently compiles even without the flag defined though. I take it FindKDE4Internal.cmake doesn't take action to disable exception support by default on cmake? It looks like it doesn't indeed. OTOH, clang's

Re: kdelibs/kdecore/cmakelists KDE4_ENABLE_EXCEPTIONS cmake failure (4.8, 4.9)

2012-07-15 Thread Raphael Kubo da Costa
Michael Pyne mp...@kde.org writes: On Sunday, July 15, 2012 12:50:12 Shaun Reich wrote: line 393 of kdecore/cmakelists results in: CMake Error at kdecore/CMakeLists.txt:393 (set_source_files_properties): set_source_files_properties called with incorrect number of arguments. the line is:

Review Request: ksplashx: Adjust erroneous CMake calls.

2012-07-06 Thread Raphael Kubo da Costa
both before and after this change Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Review Request: Remove checks for sip, pyqt4 and pykde4. They are unneeded.

2012-04-16 Thread Raphael Kubo da Costa
to the review request. CMakeLists.txt http://git.reviewboard.kde.org/r/104619/#comment9813 I'd rephrase the description as Needed to install the Plasma scriptengine for Python. - Raphael Kubo da Costa On April 16, 2012, 4:29 p.m., Michael Jansen wrote

Review Request: Use exported targets the right way.

2012-04-10 Thread Raphael Kubo da Costa
LibkcddbConfig.cmake.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/104544/diff/ Testing --- With the analogous change made to libkcompactdisc I can finally build kscd again. Thanks, Raphael Kubo da Costa ___ Kde-buildsystem mailing list Kde

Review Request: Use exported targets the right way.

2012-04-10 Thread Raphael Kubo da Costa
Kubo da Costa ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: hidden visibility

2012-02-20 Thread Raphael Kubo da Costa
Thiago Macieira thi...@kde.org writes: On domingo, 19 de fevereiro de 2012 23.50.49, Raphael Kubo da Costa wrote: AFAIU, Apple still ships gcc 4.2.1 (the last GPLv2 version of gcc) with its OS; does it mean another compiler is going to be required for OS X users too? Qt supports gcc 4.2.1

Re: hidden visibility

2012-02-19 Thread Raphael Kubo da Costa
Stephen Kelly steve...@gmail.com writes: For what it's worth, I don't think we should have code in ecm which appears to work with older compilers unless we actually test it. None of us (I presume?) are still using GCC 4.1 or 4.2 and want to use 'the KDE compiler settings' with it. If in the

Re: hidden visibility

2012-02-19 Thread Raphael Kubo da Costa
Stephen Kelly steve...@gmail.com writes: For KDE Frameworks 5, gcc 4.2 is too old. Qt5 requires a much more recent version (I don't recall which exactly). Unfortunately I'm a bit behind in the Qt5 discussions and development. I tried to look for something about this in wiki.qt-project.org and

Re: /usr/local/include in _KDE4_PLATFORM_INCLUDES on FreeBSD?

2012-02-17 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: Hi Raphael, I'm going through FindKDE4Internal.cmake currently to prepare it for KDE frameworks. If came about this patch from you: http://quickgit.kde.org/index.php?p=kdelibs.gita=commith=59066f389a9ae37b0a5e0d66287b326032c2cfae which

Re: [PATCH] FindXine: Make version detection work with xine = 1.2.0.

2012-01-26 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: Another idea would be to try_compile() a small binary and turn the version numbers into a string by doing this, and the parsing that string out of the executable. This is what cmake does e.g. for determining the type sizes. I'm fine with either

Re: [PATCH] FindXine: Make version detection work with xine = 1.2.0.

2012-01-26 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Thursday 26 January 2012, Raphael Kubo da Costa wrote: Alexander Neundorf neund...@kde.org writes: Another idea would be to try_compile() a small binary and turn the version numbers into a string by doing this, and the parsing that string out

Re: FindOpenSSL.cmake - ours vs. the cmake one

2011-11-02 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: I'm still in the process of merging our stuff, e.g. Find-modules from kdelibs, into cmake. Now, attached are the current FindOpenSSL.cmake from CMake and the one from kdelibs. Especially under Windows they do quite different things. The upstream

Re: review FindBlueZ.cmake

2011-09-21 Thread Raphael Kubo da Costa
Michael Jansen k...@michael-jansen.biz writes: Not sure here. After a (short) talk to some kde windows guys i remember he said there is pkgconfig for windows but it is considered completly broken. I think thats why most modules do that magic. Do ignore it on windows even if there. I've often

Re: FindLibUSB1

2011-09-18 Thread Raphael Kubo da Costa
Yury G. Kudryashov urkud.ur...@gmail.com writes: I don't know how to search for KDE code using FindUSB.cmake. lxr.kde.org - general search works if you search for, say, find_library(USB). ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Re: review FindFFMPEG.cmake

2011-09-16 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: what's up with this one ? Wasn't there a lot of discussion about it ? Which one do we want to use ? This one (as it is currently in ECM attic/ ) or another one ? Didn't mjansen unify all the findffmpeg files some time ago?

Re: Buildsystem TODO list

2011-08-23 Thread Raphael Kubo da Costa
Yury G. Kudryashov urkud.ur...@gmail.com writes: Raphael Kubo da Costa wrote: As far as I understand, the proposed scenario for projects with cmake-based buildsystem is: * the project itself installs ProjectNameConfig.cmake; * ecm (or cmake) distribute a short FindProject.cmake

Re: libqjson's cmake support

2011-08-23 Thread Raphael Kubo da Costa
Flavio Castelli fla...@castelli.name writes: On Friday, July 01, 2011 12:01:15 AM David Faure wrote: The issue is: * qjson.git generates a qjson-config.cmake which sets qjson_LIBRARIES (lowercase because the cmake project name is qjson) * qjson.git also installs a FindQJSON.cmake (!!

Re: Buildsystem TODO list

2011-08-22 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: Take care of Strigi, Nepomuk Soprano buildsystem-wise Allen wrote last week to kde-buildsystem that there are multiple

Are the *Nightly.cmake files still valid?

2011-08-15 Thread Raphael Kubo da Costa
Hey there, While working on the kdeutils migration to git I was looking at KDEUtilsNightly.cmake. Was it ever used by someone? It mentions KDECTestNightly.cmake in kdesdk, but I couldn't find it there, for example. I wonder if I should spend some time adapting it to each application or of it can

Splitting CTestConfig.cmake files when migrating to git

2011-08-08 Thread Raphael Kubo da Costa
Hey there, As you may know, kdeutils is in the process of migrating to git. One of the issues I'm facing right now is what to do with the CTestConfig.cmake file that currently exists in the top-level directory. Is there any way to keep all the tests under the kdeutils umbrella in my.cdash.org or

Re: Splitting CTestConfig.cmake files when migrating to git

2011-08-08 Thread Raphael Kubo da Costa
Raphael Kubo da Costa kub...@gmail.com writes: Hey there, As you may know, kdeutils is in the process of migrating to git. One of the issues I'm facing right now is what to do with the CTestConfig.cmake file that currently exists in the top-level directory. Is there any way to keep all

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Sending it only to the lists so it isn't held for approval. ---BeginMessage--- Alexander Neundorf neund...@kde.org writes: On Tuesday 02 August 2011, Alexander Neundorf wrote: On Friday 29 July 2011, Alexander Neundorf wrote: Hi, ... I have set up a doodle poll here:

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Raphael Kubo da Costa kub...@gmail.com writes: So either you'll just be there at 8:00PM, or we walk there together. Then let's meet here at the registration at .30PM. Addendum: .30PM = 6.30PM. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Re: buildsystem BoF at Desktop Summit

2011-08-07 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Tuesday 02 August 2011, Alexander Neundorf wrote: On Friday 29 July 2011, Alexander Neundorf wrote: Hi, ... I have set up a doodle poll here: http://www.doodle.com/v53bgft9xkffdnft Please enter when you can attend (the earlier the

Re: The State of FindFFMPEG.cmake

2011-06-24 Thread Raphael Kubo da Costa
Michael Jansen i...@michael-jansen.biz writes: Perhaps you could READ my first email before this Until then i ignore this message. Gentlemen, there is no need for heated arguments here :) Let us keep the discussion polite. ___ Kde-buildsystem

Re: buildsystem BoF At Akademy/Desktop Summit in Berlin ?

2011-06-22 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: Hi, I'm thinking about setting up a buildsystem BoF for Berlin. Actually I don't have anything fixed planned. It could be just that the people interested in the buildsystem stuff meet. Or we could go again through the plan from Randa, and see how

Re: Separate package for cmake modules

2011-06-21 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: So, how should we call it ? extra-cmake-modules ? (should be easier to read then extracmakemodules) I somehow feel it's missing a 'k' at the beginning ;-) Looks OK from my side. ___ Kde-buildsystem

Re: Review Request: Make rpc library optional for the NFS slave

2011-06-17 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101664/#review3981 --- Ship it! Looks OK to me. lxr says this is the only

Re: Reviewboard

2011-06-13 Thread Raphael Kubo da Costa
Allen Winter win...@kde.org writes: Howdy, Unless I missed it, there is no reviewboard group for buildsystem. So I will request such a group with the default reviewers being kde-buildsystem@kde.org Objections? Not at all! ___ Kde-buildsystem

[libstreams] /: Make commit 695554fb more portable.

2011-06-11 Thread Raphael Kubo da Costa
Git commit 622c6f8fb4072a1b29d5bd4e0276d08c3f3791b3 by Raphael Kubo da Costa. Committed on 11/06/2011 at 22:08. Pushed by rkcosta into branch 'master'. Make commit 695554fb more portable. As suggested six months ago (!) in the kde-buildsystem mailing list [1], commit 695554fb will probably

Re: [Libstreams] 695554f Specify the full path in LIBSTREAMS_LIBRARIES.

2011-06-11 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Saturday 25 December 2010, Raphael Kubo da Costa wrote: commit 695554fbfcaeb0fbeb47a9196ced6cbd485b4433 branch master Author: Raphael Kubo da Costa kub...@gmail.com Date: Sat Dec 25 02:38:35 2010 -0200 snip diff --git

Re: Fixing OpenAL and libsndfile dependencies in kdegames (Was `Re: KDE/kdegames')

2011-05-24 Thread Raphael Kubo da Costa
Ian Wadham iandw...@gmail.com writes: On Thursday 19 May 2011 2:35:13 am Raphael Kubo da Costa wrote: So what I have in mind is the following: * Granatier and KGoldRunner are optional parts of kdegames (ie. one can call cmake with -DBUILD_granatier=OFF and -DBUILD_kgoldrunner=OFF

Re: KDE 4.7 Beta1 (4.6.80) tarballs uploaded (try#1)

2011-05-21 Thread Raphael Kubo da Costa
Dirk Mueller muel...@kde.org writes: Can I get the opinion of the other distro packagers as well please? Personally I was much more happy with the previous module-based layout, though I can cope reasonable with the current situation as well. Any other opinon? On the FreeBSD side, we

Fixing OpenAL and libsndfile dependencies in kdegames (Was `Re: KDE/kdegames')

2011-05-18 Thread Raphael Kubo da Costa
Raphael Kubo da Costa kub...@gmail.com writes: CC'ing kde-buildsystem to this thread. Ian Wadham iandw...@gmail.com writes: SVN commit 1232491 by ianw: Make the dependency of Granatier and KGoldrunner on OpenAL and SndFile optional. The dependency should really be REQUIRED, but that kills

Re: KDE/kdegames

2011-05-17 Thread Raphael Kubo da Costa
CC'ing kde-buildsystem to this thread. Ian Wadham iandw...@gmail.com writes: SVN commit 1232491 by ianw: Make the dependency of Granatier and KGoldrunner on OpenAL and SndFile optional. The dependency should really be REQUIRED, but that kills the whole KDE Games build if OpenAL or SndFile is

Re: Automoc with qt 4.8 issue.

2011-04-28 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Thursday 28 April 2011, you wrote: Hello Alexander, Frederik gladhorn tells me the reason kdelibs wont build with qt 4.8 is because of a problem with automoc. Are you aware of this issue? I'll ask No, I'm not. What's the problem ? I'm

Re: openssl cmake module

2011-04-21 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: I had a look, now I remember. There is now quite a lot of stuff in it which I don't understand, like those eay libraries and and the FindLibraryWithDebug file which will probably break something on Windows if it is removed. The FindOpenSSL.cmake

Re: [PATCH] Clean up FindGObject.cmake.

2011-04-11 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Monday 11 April 2011, Raphael Kubo da Costa wrote: * Remove unnecessary WIN32 check. * Use the pkg-config paths as HINTS, not PATHS. * Use FindPackageHandleStandardArgs instead of duplicating its functionality. Looks good except one

Re: openssl cmake module

2011-04-11 Thread Raphael Kubo da Costa
Raphael Kubo da Costa kub...@gmail.com writes: For now, we need to wait for Alexander Neundorf's instance on FindOpenSSL.cmake. Alex, are you there? :) ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde

[PATCH] Clean up FindGObject.cmake.

2011-04-10 Thread Raphael Kubo da Costa
- Compiler switches required for using GObject +# Copyright (c) 2011, Raphael Kubo da Costa kub...@gmail.com # Copyright (c) 2006, Tim Beaulen tbsc...@gmail.com # # Redistribution and use is allowed according to the terms of the BSD license. # For details see the accompanying COPYING-CMAKE-SCRIPTS

Re: openssl cmake module

2011-04-04 Thread Raphael Kubo da Costa
matthias sweertvaegher matthias.sweertvaeg...@gmail.com writes: so, could someone please have a look at that? I am trying to provide a package for my plasmoid on the opensuse build service but I fail due to this linking problem with openssl. Or maybe I am trying to do something in the wrong

Re: openssl cmake module

2011-04-04 Thread Raphael Kubo da Costa
matthias sweertvaegher matthias.sweertvaeg...@gmail.com writes: In the meanwhile I followed your clue about the linker flags and you're right. -Wl,--no-undefined seems to be the culprit. This forces all external symbols to be found in an explicitly listed dependency. I tried adding the

Installing a FindFoo.cmake file in kde-workspace

2011-02-12 Thread Raphael Kubo da Costa
Hi there, I've noticed some of the FindFoo.cmake files in kde-workspace/cmake/modules are installed into the system. I need to create a new FindXXX.cmake file there, but I'm unsure if I also need to install it, as it is usually frowned upon. Do I need to install it (I see some of the

Question wrt KDE not depending on pkg-config (was Re: Initial support for kde_projects.xml in kdesrc-build)

2011-02-02 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: On Wednesday 02 February 2011, Michael Pyne wrote: ... e.g. worrying about environment variables like PKG_CONFIG_PATH is no idle claim (kdesrc-build sets that as well), along with PATH in order to pick up the right Qt version. Please try to use

Re: Choosing whether a dependency is optional or required.

2011-02-02 Thread Raphael Kubo da Costa
Andreas Pakulat ap...@gmx.de writes: On 29.01.11 11:32:01, Raphael Kubo da Costa wrote: I've recently committed a patch to Kopete's Yahoo! protocol that makes libjasper required when the protocol is built. As I can see, the other Kopete protocols usually check for their dependencies

Choosing whether a dependency is optional or required.

2011-01-29 Thread Raphael Kubo da Costa
Hey there, I've recently committed a patch to Kopete's Yahoo! protocol that makes libjasper required when the protocol is built. As I can see, the other Kopete protocols usually check for their dependencies in the top-level CMakeLists.txt with macro_optional_find_package(Foo)

Re: Automoc hanging for some FreeBSD users

2011-01-11 Thread Raphael Kubo da Costa
On Sun, Dec 12, 2010 at 2:05 AM, Raphael Kubo da Costa kub...@gmail.com wrote: At Thu, 25 Nov 2010 18:42:04 +0100, David Faure wrote: On Wednesday 24 November 2010, Thiago Macieira wrote: 1) the subprocess hasn't exited [...] 1, 2 and 3 are bugs outside of Qt -- either in the subprocess

[Libstreams] 695554f Specify the full path in LIBSTREAMS_LIBRARIES.

2010-12-24 Thread Raphael Kubo da Costa
commit 695554fbfcaeb0fbeb47a9196ced6cbd485b4433 branch master Author: Raphael Kubo da Costa kub...@gmail.com Date: Sat Dec 25 02:38:35 2010 -0200 Specify the full path in LIBSTREAMS_LIBRARIES. libstreamsanalyzer's luceneindexer was not linking properly here because

Re: Automoc hanging for some FreeBSD users

2010-12-11 Thread Raphael Kubo da Costa
At Thu, 25 Nov 2010 18:42:04 +0100, David Faure wrote: On Wednesday 24 November 2010, Thiago Macieira wrote: 1) the subprocess hasn't exited [...] 1, 2 and 3 are bugs outside of Qt -- either in the subprocess Well the subprocess is moc, so we're back into Qt :-) Raphael: is there a

Automoc hanging for some FreeBSD users

2010-11-23 Thread Raphael Kubo da Costa
Hi all, Some FreeBSD users who use -CURRENT (the unstable version) have been experiencing some problems while compiling the KDE ports. automoc seems to hang at random points during compilation. I asked one of the users for a backtrace, and it follows below. I'm still clueless and don't know for

Re: Exporting the compiler version in FindKDE4Internal.cmake?

2010-11-10 Thread Raphael Kubo da Costa
On Wednesday 03 November 2010 10:07:44 Raphael Kubo da Costa wrote: Hey all, So Alex from DragonFly BSD has been trying to contribute to the nightly builds, but kdelibs is failing to compile for him -- see https://bugs.kde.org/show_bug.cgi?id=255922 Apparently, the proxymodeltestsuite

Exporting the compiler version in FindKDE4Internal.cmake?

2010-11-03 Thread Raphael Kubo da Costa
Hey all, So Alex from DragonFly BSD has been trying to contribute to the nightly builds, but kdelibs is failing to compile for him -- see https://bugs.kde.org/show_bug.cgi?id=255922 Apparently, the proxymodeltestsuite only compiles on gcc 4.2+, but the default compiler on DragonFly is still gcc

Re: kde builds on DragonFly

2010-11-01 Thread Raphael Kubo da Costa
First and foremost: I'm CC'ing the kde-buildsystem mailing list, as Alex is probably more capable than I am to help you with these nightly build scripts. List: Alex Hornung is working on making sure KDE builds and works fine on DragonFly BSD. At Mon, 01 Nov 2010 08:07:10 +, Alex Hornung

Re: Automatic recording of required packages...

2010-10-31 Thread Raphael Kubo da Costa
On Sunday 31 October 2010 10:40:39 Alexander Neundorf wrote: I think I'd like to propose that macro_log_feature() ignores the REQUIRED keyword (we can't simply remove it due to compatibility reasons) and that we use REQUIRED in the find_package() calls instead. Pros: - correct listing of

Re: Automatic recording of required packages...

2010-10-31 Thread Raphael Kubo da Costa
On Sunday 31 October 2010 13:34:41 Alexander Neundorf wrote: On Sunday 31 October 2010, you wrote: On Sunday 31 October 2010 10:40:39 Alexander Neundorf wrote: I think I'd like to propose that macro_log_feature() ignores the REQUIRED keyword (we can't simply remove it due to compatibility

Re: Unable to decompress snapshot

2010-10-14 Thread Raphael Kubo da Costa
At Thu, 14 Oct 2010 12:48:04 +0200, David Faure wrote: On Thursday 14 October 2010, Thangalin wrote: ERROR #1 - ~/kdesvn/log/2010-10-13-04/kdebase/cmake.log Could NOT find DBusMenuQt: Found version .., but required is at least 0.6.0 (found /usr/lib/libdbusmenu-qt.so) module

Re: FindXKB.cmake explained please

2010-06-29 Thread Raphael Kubo da Costa
On Tuesday 29 June 2010 21:15:58 lI wrote: ## FindXKB.cmake in kkde-4.4.4 //$KDE_PREFIX/share/apps/cmake/modules/FindXKB.cmake find_path(X11_XKB_INCLUDE_PATH X11/XKBlib.h ${X11_INC_SEARCH_PATH}) if (X11_XKB_INCLUDE_PATH) MACRO_PUSH_REQUIRED_VARS()

KDE/kdelibs/cmake/modules

2010-06-07 Thread Raphael Kubo da Costa
SVN commit 1135642 by rkcosta: Check gcc's include path and add any previously missing entries to CMAKE_{C,CXX}_IMPLICIT_INCLUDE_DIRECTORIES. As discussed on the kde-buildsystem mailing list, this is particularly useful on systems such as FreeBSD, which have most of the libraries and headers

  1   2   >