Re: KDE Builder: request for review

2024-04-09 Thread Harald Sitter
On Tue, Apr 9, 2024 at 11:26 AM Kevin Kofler wrote: > > ash...@linuxcomp.ru wrote: > > I've been working on KDE Builder project. This is a reimplementation of > > kdesrc-build in Python. > > What is the point of rewriting a tool originally written in a stable > language that guarantees long-term

Re: KDE Builder: request for review

2024-04-08 Thread Harald Sitter
On Mon, Apr 8, 2024 at 10:05 AM wrote: > > Hi all! > > I've been working on KDE Builder project. This is a reimplementation of > kdesrc-build in Python. At this point, the tool is rather mature, but some > minor bugs may probably be unnoticed. I'd like to officially request a review > of KDE

Re: Retirement of Binary Factory

2024-02-18 Thread Harald Sitter
On Sun, Feb 18, 2024 at 10:23 AM Ben Cooksley wrote: > > On Sun, Feb 18, 2024 at 2:58 PM Loren Burkholder > wrote: >> >> On Saturday, February 17, 2024 8:35:48 PM EST Ben Cooksley wrote: >> > On Sun, Feb 4, 2024 at 10:26 AM Ben Cooksley wrote: >> > >> > The Binary Factory, alongside it's two

Re: revisiting the sycoca

2024-02-13 Thread Harald Sitter
On Tue, Feb 13, 2024 at 1:13 PM Sune Vuorela wrote: > > On 2024-02-08, Harald Sitter wrote: > > It occurs to me that we should ponder sycoca a bit. > > > > Currently the sycoca contains 3 types of caches: > > At some point I remember David Faure, iirc as part of

revisiting the sycoca

2024-02-08 Thread Harald Sitter
It occurs to me that we should ponder sycoca a bit. Currently the sycoca contains 3 types of caches: - the mime cache: should in fact be unnecessary because there is already a mime.cache in /usr/share/mime? - the menu structure cache: for the most part only loaded once by plasmashell so the

Re: Proposal for using gitlab for kdereview process

2024-02-07 Thread Harald Sitter
https://community.kde.org/Goals/All_about_the_Apps On Wed, Feb 7, 2024 at 11:16 PM Friedrich W. H. Kossebau wrote: > > Long time ago, but perhaps there are still memories... > > Am Dienstag, 4. Juli 2023, 14:32:59 CET schrieb Jonathan Riddell: > > I've gone ahead an updated the Sanity checklist

Re: FileCopyrightText...

2024-01-29 Thread Harald Sitter
On Mon, Jan 29, 2024 at 10:49 AM Carl Schwan wrote: > > On Monday, January 29, 2024 10:43:04 AM CET Harald Sitter wrote: > > do we really need it? > > > > systemd for example only has a spdx license header, resulting in much > > tidier file headers. > > >

FileCopyrightText...

2024-01-29 Thread Harald Sitter
do we really need it? systemd for example only has a spdx license header, resulting in much tidier file headers. I entirely fail to understand why we need to slap a FileCopyrightText on files. The copyright surely applies whether or not I put the FileCopyrightText there. The list is also just

Re: Kandalf: request for review

2023-12-07 Thread Harald Sitter
This isn't going to be very useful, but I'm sure I'm not the only one who has heard of the story that the Tolkien Estate wasn't too happy with our original kandalf. Consequently I'm not sure we should actually name this thing kandalf. But then I wasn't around back then so I don't know if there is

Re: per-issue notifications from sentry

2023-12-01 Thread Harald Sitter
I've removed all of the default alert rules. Everyone should be able to setup rules as they see fit though, don't spam other people though :) HS On Sun, Nov 26, 2023 at 3:38 PM Harald Sitter wrote: > > does anyone else find the emails from sentry when a new issue appears > to be rathe

per-issue notifications from sentry

2023-11-26 Thread Harald Sitter
does anyone else find the emails from sentry when a new issue appears to be rather useless? they are very noisy and often times not interesting since a single crash often doesn't have enough context to act on anyway. should I look into disabling them? HS

CI log verbosity

2023-11-03 Thread Harald Sitter
What are your thoughts on having the CI be less verbose by default and instead have an env var or some other toggle to switch into verbose mode? Specifically I'm talking about the qtlogging rules that are currently enabling everything and the kitchen sink. To my mind we should just use the

Re: drkonqi's many debuggers

2023-08-28 Thread Harald Sitter
On Tue, Aug 29, 2023 at 5:23 AM Thiago Macieira wrote: > > On Monday, 28 August 2023 12:59:01 PDT Adriaan de Groot wrote: > > (puts on FreeBSD hat) On the non-GNU side of the world, lldb is the thing > > that is "installed anyway" and gdb takes extra effort. Though I don't know > > if the lldb

drkonqi's many debuggers

2023-08-28 Thread Harald Sitter
I am wondering: does anyone actually use anything besides the default gdb debugger? We have a lot of code just for supporting multiple debuggers and I am wondering if we couldn't just focus on one debugger and get less code with a better experience (both in writing and reading it). On a related

Re: sentry evaluation

2023-07-06 Thread Harald Sitter
ails if needed. This isn't always needed, but > it sometimes is. Sentry also isn't integrated into our issue priority > tracking system in Bugzilla, but that's a more minor issue. > > Nate > > > > On 6/1/23 04:35, Harald Sitter wrote: > > Hey, > > > > We've had a

Re: KSvg in kdereview

2023-06-21 Thread Harald Sitter
LGTM now +2 On Wed, Jun 21, 2023 at 10:04 AM Marco Martin wrote: > > I fixed CI, passes now > > On Tue, Jun 20, 2023 at 8:44 PM Ben Cooksley wrote: > > > > Hi all, > > > > Sysadmin has just received a request to move this repository to Frameworks, > > however after seeing some of the comments

Re: sentry evaluation

2023-06-13 Thread Harald Sitter
On Mon, Jun 12, 2023 at 11:39 PM David Edmundson wrote: > I'm not sure the teams and groups really work out right now. Do we > need to request access to groups and have that approved? That is how it used to be, yes. I've just sprinkled some code at the instance that should allow us to forgo the

Re: sentry evaluation

2023-06-12 Thread Harald Sitter
On Sun, Jun 11, 2023 at 7:13 PM Albert Vaca Cintora wrote: > > I didn't know we had Sentry! How can we get crash reports from KDE > Connect through it? Because this isn't widely rolled out yet, due to evaluation period, there's only limited data for kdeconnect. Here's one:

Re: sentry evaluation

2023-06-05 Thread Harald Sitter
On Mon, Jun 5, 2023 at 12:20 AM Albert Astals Cid wrote: > > El dijous, 1 de juny de 2023, a les 12:35:41 (CEST), Harald Sitter va > escriure: > > Hey, > > > > We've had almost a year, albeit in a super limited capacity for git > > builds, with sentry (https://e

sentry evaluation

2023-06-01 Thread Harald Sitter
Hey, We've had almost a year, albeit in a super limited capacity for git builds, with sentry (https://errors-eval.kde.org) and we should probably render a final verdict on the evaluation. Did you like it? What could be improved? Should we move ahead with a more permanent setup? The overall game

Re: Moving FutureSQL to KDE review

2023-03-24 Thread Harald Sitter
On Fri, Mar 24, 2023 at 12:23 PM Kevin Kofler wrote: > > Jonah Brüchert wrote: > > I would like to maintain it as an independent library for now, to be > > able to use C++20 features […] > > What is the point of allowing to build KDE Frameworks with an older C++ > standard (what is the minimum

what to do with phonon & why aren't you using it?

2023-03-14 Thread Harald Sitter
Hola! Why don't you use phonon? What would it make it useful? What do you reckon we should do with it? A bit of background perhaps: wy back when phonon was conceived as multimedia abstraction library to serve as multimedia pillar. While it is certainly abstract and a library I'm not so

kde-inotify-survey in kdereview

2022-10-23 Thread Harald Sitter
https://invent.kde.org/system/kde-inotify-survey simple kded that watches inotify resources and informs the user when limits are getting hit (along with a way to bump them slightly) thanks for your time! HS

Re: kio-admin in kdereview

2022-10-16 Thread Harald Sitter
On Sat, Oct 15, 2022 at 9:29 PM Albert Astals Cid wrote: > > El divendres, 14 d’octubre de 2022, a les 10:34:04 (CEST), Harald Sitter va > escriure: > > On Thu, Oct 13, 2022 at 10:32 PM Albert Astals Cid wrote: > > > El dijous, 13 d’octubre de 2022, a les 1:03:53

Re: kio-admin in kdereview

2022-10-14 Thread Harald Sitter
On Thu, Oct 13, 2022 at 10:32 PM Albert Astals Cid wrote: > > El dijous, 13 d’octubre de 2022, a les 1:03:53 (CEST), Harald Sitter va > escriure: > > On Thu, Oct 13, 2022 at 12:46 AM Albert Astals Cid wrote: > > > Did I misunderstood the code? It looks like this

Re: kio-admin in kdereview

2022-10-12 Thread Harald Sitter
On Thu, Oct 13, 2022 at 12:46 AM Albert Astals Cid wrote: > Did I misunderstood the code? It looks like this run all of kio with root > powers? That is correct

kio-admin in kdereview

2022-10-12 Thread Harald Sitter
Hola kio-admin implements an admin worker that gives root level access to the file system https://invent.kde.org/system/kio-admin HS

Re: KJournald in KDE-Review

2022-10-09 Thread Harald Sitter
Neat! - clazy has some hints - you could probably use https://api.kde.org/ecm/module/ECMQtDeclareLoggingCategory.html for loggincategory.cpp/h? - for qml you should probably use Kirigami.Units.gridUnit*N instead of hardcoding sizes - the hardcoded colors also seem a bit of an odd choice - they

Re: Plasma Welcome Center on KDEReview

2022-09-20 Thread Harald Sitter
plasma-disks is a fairly exhaustive example code base On Tue, Sep 20, 2022 at 2:19 AM Nate Graham wrote: > > On 9/18/22 11:03, Harald Sitter wrote: > > Not all code is licensing policy compliant (e.g. appdata is missing > > spdx tags). I'd suggest enabling the reuse linter pipe

Re: Plasma Welcome Center on KDEReview

2022-09-18 Thread Harald Sitter
Not all code is licensing policy compliant (e.g. appdata is missing spdx tags). I'd suggest enabling the reuse linter pipeline. On Fri, Sep 16, 2022 at 6:00 PM Nate Graham wrote: > > Hello folks! > > I've been working with Aleix on an onboarding wizard for Plasma, based > on work originally

Re: Putting Flatpak KCM through kdereview

2022-09-09 Thread Harald Sitter
Amazing! For future reference: there is a sanity check list linked at https://community.kde.org/Policies/Application_Lifecycle#kdereview that you can follow to do a pre-review yourself and find most common issues. - Messages.sh missing (I see there is an MR pending) - you should enable CI and in

Re: Plasma Remote Controllers in KDE Review

2022-08-26 Thread Harald Sitter
- src dir is missing i18n setup (messages.sh and define in cmakelists) - not reuse covered - metainfo.xml missing (appstream) - doesn't have gitlab ci builds apparently? - doesn't have bugzilla product - clazy is not happy On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra wrote: > > Hi, > > Plasma

Re: Plasma Bigscreen is in kdereview again

2022-06-24 Thread Harald Sitter
- not fully reuse compliant. much sad but probably can't be helped this far into the project :(( - kdeconnect.h has include guards for wifi.h - kcm_mediacenter_bigscreen_settings may be missing a -DTRANSLATION_DOMAIN - I would suggest you build with clazy. there are numerous possible container

Re: Eloquens now on KDEREVIEW)

2022-06-22 Thread Harald Sitter
On Wed, Jun 22, 2022 at 12:07 AM Felipe Kinoshita wrote: > > > Could you elaborate why your config.kcfg uses Ints for everything when > > you clearly want booleans (e.g. `Config.code == 1 ? true : false`) > > The API expects ones and zeros for its params, I chose to convert them to > booleans to

Re: Eloquens now on KDEREVIEW

2022-06-21 Thread Harald Sitter
On Mon, Jun 20, 2022 at 10:30 PM Felipe Kinoshita wrote: > > For those who don't know, Eloquens is a simple application targeted at > developers/designers, it generates the lorem ipsum text and allows you to > customize it a little bit like adding heading, bullet lists, etc... > > I would also

Re: Git merge workflow: reverse it?

2022-05-10 Thread Harald Sitter
I'm sure we can, it's one of the technical pillars of the manifesto :) https://manifesto.kde.org/commitments/ On Tue, May 10, 2022 at 10:59 AM Ingo Klöcker wrote: > > On Dienstag, 10. Mai 2022 09:36:17 CEST Kai Uwe Broulik wrote: > > can we get an update on this? > > > > Plasma is full on

Re: KSANECore in KDE review

2022-03-27 Thread Harald Sitter
On Sun, Mar 27, 2022 at 6:29 PM Alexander Stippich wrote: > > Hello everyone, > > KSANECore is now in KDE review. Kåre and I mentioned it in previous emails > before, but as a short summary: > KSANECore is a Qt interface to the SANE scanner library. It is stripped out of > the KSaneWidget of

Re: Should we consider project basenames unique?

2021-11-24 Thread Harald Sitter
On Wed, Nov 24, 2021 at 10:02 AM Ben Cooksley wrote: > Which means you either provide the path (plasma-mobile/plasma-dialer) or you > need to go look in the metadata anyway. If names are unique (not persistent, just unique) and plasma-dialer is what I want to release then I know plasma-dialer

Re: Should we consider project basenames unique?

2021-11-24 Thread Harald Sitter
On Wed, Nov 24, 2021 at 6:00 AM Ben Cooksley wrote: > > On Wed, Nov 24, 2021 at 2:29 PM Aleix Pol wrote: >> >> On Wed, Nov 24, 2021 at 2:10 AM ash...@linuxcomp.ru >> wrote: >> > >> > Hello. >> > There is currently a problem that projects are identified by path in >> > invent.kde.org. But in

Towards Excellent Defect Management

2021-09-14 Thread Harald Sitter
For many years now I've been unhappy with both the quality and volume of crash reports we get for our software. The barrier for crash report submissions is incredibly high because we've never really had tech to help elevate "insufficient" reports to become sufficient, outside the client on which

Re: Skanpage moved to kdereview

2021-08-17 Thread Harald Sitter
On Wed, Aug 11, 2021 at 9:46 PM Alexander Stippich wrote: > > - getUnitString -> can that maybe use > > https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html > > What do you have in mind here? getUnitString just matches the enum of libksane > to a unit suffix string, it does not

Re: Skanpage moved to kdereview

2021-08-09 Thread Harald Sitter
it works amazingly well. good job! I mostly only have some nitpicky stuff - since the code base is really close to complete reuse coverage, it might be nice to push it over the finishing line and then `reuse lint` it to not have it fall behind again - your cmake code is GPL but policy-wise it

Re: Haruna in kdereview

2021-07-21 Thread Harald Sitter
On Wed, Jul 21, 2021 at 4:38 PM George Florea Banus wrote: > > On 21.07.2021 13:53, Harald Sitter wrote: > > - the color-schemes dir seems to do nothing. it installs files that > > don't actually exist in the source. fix it or rm -rf? > > It had the Breeze color sch

Re: Haruna in kdereview

2021-07-21 Thread Harald Sitter
It's an amazing app! Really awesome. - you might want to consider using a newer version in your find_package call for ECM. ECM does enable more modern/useful features but only when used with a suitably high version. so, I'd put this at the actual minimal version you want to support - the

Re: KHealthCertificate in kdereview

2021-07-12 Thread Harald Sitter
My only gripe, besides what Albert already pointed out, is that all the properties are WRITEable but have no NOTIFY signal nor are they CONSTANT. One of those things ought to change. Considering only the certificate objects have properties and they are always constructed by the parsers I guess you

Re: AudioTube in KDEReview

2021-06-20 Thread Harald Sitter
On 16.06.21 21:27, Jonah Brüchert wrote: >> - something is also wonky with the playlist. it doesn't cover the width >> (when data fails to load). it is overlapped by the scrollbar. clear and >> shuffle don't seem to have labels though there would be enough space >> https://i.imgur.com/Q3IoaBj.png

Re: AudioTube in KDEReview

2021-06-16 Thread Harald Sitter
Hola On 16.06.21 00:44, Jonah Brüchert wrote: > I would like to move AudioTube to KDEReview. - the source is almost reuse compliant but not quite. needs some extra data files equipped with CC-0 or the like [1][2]. You could then also add an include on

Re: New repo in kdereview: kasts

2021-05-31 Thread Harald Sitter
On Sat, May 29, 2021 at 10:20 PM Bart De Vries wrote: > > On 27/05/2021 15:09, Harald Sitter wrote: > > - the source is almost reuse compliant but not quite. needs some extra > > data files equipped with CC-0 or the like [1][2]. You could then also > > add an include on &g

Re: New repo in kdereview: kasts

2021-05-27 Thread Harald Sitter
On Thu, May 27, 2021 at 12:20 PM Bart De Vries wrote: > > Hello everyone! > > I would like to move kasts to kdereview. > > https://invent.kde.org/plasma-mobile/kasts > > > Kasts is a podcast app for Plasma Mobile. It was started as a fork of >

Re: Qt5PatchCollection versions (broken QWE)

2021-05-26 Thread Harald Sitter
On Wed, May 26, 2021 at 7:39 PM Antonio Rojas wrote: > > El miércoles, 26 de mayo de 2021 13:19:34 (CEST), Harald Sitter escribió: > > Hola > > > > QWE and QtScript in our kde/5.15 branches currently have unaligned versions. > > > > QWE 5.15.4: > > https

Qt5PatchCollection versions (broken QWE)

2021-05-26 Thread Harald Sitter
Hola QWE and QtScript in our kde/5.15 branches currently have unaligned versions. QWE 5.15.4: https://invent.kde.org/qt/qt/qtwebengine/-/blob/kde/5.15/.qmake.conf QtBase 5.15.3: https://invent.kde.org/qt/qt/qtbase/-/blob/kde/5.15/.qmake.conf This then breaks version alignment expectations. For

Re: Koko in KDEReview

2021-05-05 Thread Harald Sitter
On 04.05.21 17:53, Carl Schwan wrote: > Le mardi, mai 4, 2021 4:53 PM, Adriaan de Groot a écrit : > >> On Tuesday, 4 May 2021 15:50:27 CEST Halla Rempt wrote: >> >>> On Tuesday, 4 May 2021 15:28:30 CEST Nate Graham wrote: >>> I don't see anyone really trying to argue otherwise. >>> >>> I

Re: Koko in KDEReview

2021-05-04 Thread Harald Sitter
On 04.05.21 15:28, Nate Graham wrote: > On 5/4/21 1:16 AM, Harald Sitter wrote: >> Every time the bugz vs gitlab schism comes up I eventually tune out with >> the distinct feeling that there is strong opposition to moving. What I, >> what we all, do not want is to en

Re: Koko in KDEReview

2021-05-04 Thread Harald Sitter
On 04.05.21 00:07, Carl Schwan wrote: > Le lundi, mai 3, 2021 4:35 PM, Harald Sitter a écrit : > >> On 23.04.21 01:00, Carl Schwan wrote: >> > >>>>>>> - please get a bugzilla produce created for it >>>>> > >>>>>

Re: Koko in KDEReview

2021-05-03 Thread Harald Sitter
On 23.04.21 01:00, Carl Schwan wrote: > - please get a bugzilla produce created for it >>> >>> Not a fan of that. This will ends up exactly like the www bugs, something >>> that I look into every 6 months. We already have many issues opened in >>> invent and it's working fine for us. >> >>

Re: Is there (going to be) an auto-retracer service for KDE?

2021-04-29 Thread Harald Sitter
On Tue, Apr 27, 2021 at 2:16 PM Halla Rempt wrote: > > On Monday, 26 April 2021 13:07:17 CEST Harald Sitter wrote: > > Also going off on a tangent: On windows I understand the store already > > has crash tracking and all that stuff implemented, I expect the same > >

Re: Is there (going to be) an auto-retracer service for KDE?

2021-04-26 Thread Harald Sitter
On Mon, Apr 26, 2021 at 12:34 PM Halla Rempt wrote: > > On Monday, 26 April 2021 11:26:38 CEST Harald Sitter wrote: > > * get a core instead of a trace - sounds simpler than it is because > > cores can be huge and network speed may be limited. google's breakpad > > has a

Re: Is there (going to be) an auto-retracer service for KDE?

2021-04-26 Thread Harald Sitter
On Sun, Apr 25, 2021 at 10:38 PM Albert Astals Cid wrote: > KDE can't do retracing because KDE hasn't built the packages people use > (except KDE Neon). I've mused on this in the past and I think it can be done, it's just a lot of work that in particular also will need to involve some web

Re: Including LayerShellQt in Plasma in time for 5.22

2021-04-06 Thread Harald Sitter
- I'm like a broken record at this point: some of the cmake files and the json file lack licensing details. please run `reuse lint` to check the list. it's incredibly close to being fully licensed - you include KDEClangFormat but don't actually seem to enable it - along a similar note: the code

Re: KQuickImageEditor in KDEReview

2021-03-25 Thread Harald Sitter
- really close to 100% reuse cover. plz consider adding data to KQuickImageEditorConfig.cmake.in and src/controls/plugins.qmltypes - in fact... shouldn't the qmltypes file be generated at build time? - there's commented out KDEFrameworkCompilerSettings in CMakeLists, please remove it, Friedrich

Re: Koko in KDEReview

2021-03-23 Thread Harald Sitter
On 16.03.21 20:10, Carl Schwan wrote: > Le mardi, mars 16, 2021 12:55 PM, Harald Sitter a écrit : > >> On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter sit...@kde.org wrote: >> > >>> Yay! > > Thanks for the big review :) > >>>

Re: Koko in KDEReview

2021-03-16 Thread Harald Sitter
On Tue, Mar 16, 2021 at 12:49 PM Harald Sitter wrote: > > Yay! > > - please get a bugzilla produce created for it > - COPYING-CMAKE-SCRIPTS seems unused > - the find_package calls on qt5 probably should be versioned on > whatever version you actually tested with, curre

Re: Koko in KDEReview

2021-03-16 Thread Harald Sitter
Yay! - please get a bugzilla produce created for it - COPYING-CMAKE-SCRIPTS seems unused - the find_package calls on qt5 probably should be versioned on whatever version you actually tested with, currently it's unversioned which I doubt is correct - same for kquickimageeditor - kquickimageeditor

Re: New repo in kdereview: plasma-settings

2021-01-25 Thread Harald Sitter
On 25.01.21 08:05, Bhushan Shah wrote: > Hello everyone! > > I want to move plasma-settings repo to kdereview, it is settings > application used by the Plasma Mobile, it is based on Kirigami. > > https://invent.kde.org/plasma-mobile/plasma-settings > > Main difference between plasma-settings

Re: New repo in kdereview: plasma-angelfish

2021-01-25 Thread Harald Sitter
On 25.01.21 06:55, Bhushan Shah wrote: > Hello everyone! > > Yet another Plasma Mobile repository in kdereview: > > https://invent.kde.org/plasma-mobile/plasma-angelfish > > Plasma Angelfish is browser written in Kirigami which uses the > QtWebengine for rendering web pages. It is optimized

Re: New repo in kdereview: plasma-phonebook

2021-01-25 Thread Harald Sitter
On 25.01.21 06:48, Bhushan Shah wrote: > Hello everyone! > > I am back with more Plasma Mobile related repositories in kdereview. I > want to move plasma-phonebook in kdereview. plasma-phonebook is kirigami > based phonebook application, it uses kpeople backends like kpeoplesink, > kpeoplevcard,

Re: PSA: Please do not use KDEFrameworkCompilerSettings for non-KF projects

2021-01-20 Thread Harald Sitter
On 19.01.21 16:57, Friedrich W. H. Kossebau wrote: > Hi, > > the docs of the module tell us: > "KDEFrameworkCompilerSettings - Set stricter compile and link flags for KDE > Frameworks modules." > https://api.kde.org/ecm/kde-module/KDEFrameworkCompilerSettings.html > > And it has been meant that

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-20 Thread Harald Sitter
On 19.10.20 17:44, Ingo Klöcker wrote: > On Montag, 19. Oktober 2020 17:22:22 CEST Milian Wolff wrote: >> On Montag, 19. Oktober 2020 17:21:28 CEST Harald Sitter wrote: >>> I'm not sure it's a good idea, but we could treat this like >>> KDE_INSTALL_USE_QT_SYS_PATHS. By d

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Harald Sitter
On 19.10.20 17:06, Milian Wolff wrote: > On Montag, 19. Oktober 2020 16:56:27 CEST Harald Sitter wrote: >> On 19.10.20 12:30, Milian Wolff wrote: >>> On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: >>>> Yo >>>> >>>>

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Harald Sitter
On 19.10.20 12:30, Milian Wolff wrote: > On Montag, 19. Oktober 2020 11:27:29 CEST Harald Sitter wrote: >> Yo >> >> On 18.10.20 10:11, Milian Wolff wrote: >>> Hey all, >>> >>> since some time now I'm only compiling parts of KF5 selectively

Re: CMake kauth_install_* with system kauth and user CMAKE_INSTALL_PREFIX

2020-10-19 Thread Harald Sitter
Yo On 18.10.20 10:11, Milian Wolff wrote: > Hey all, > > since some time now I'm only compiling parts of KF5 selectively into a custom > prefix. Most notably, I'm only interested in ktexteditor and syntax- > highlighting, and would like to obtain all other frameworks through my > distribution

Re: stale MR triaging - you can help!

2020-10-16 Thread Harald Sitter
On 16.10.20 10:00, Albert Astals Cid wrote: > El dimarts, 13 d’octubre de 2020, a les 15:53:10 CEST, Harald Sitter va > escriure: >> Moin >> >> As promised in a previous mail I've set up a system that helps us find >> stale MRs to ensure patches don't fall by the

stale MR triaging - you can help!

2020-10-13 Thread Harald Sitter
Moin As promised in a previous mail I've set up a system that helps us find stale MRs to ensure patches don't fall by the wayside. Lists are filed as issues on invent. To help out you can hit the bell to subscribe to `New issue` events at https://invent.kde.org/sysadmin/gitlab-triaging First

Re: KDiagram - Persistent FTBFS for stable branch on Windows

2020-10-12 Thread Harald Sitter
On 12.10.20 11:23, Milian Wolff wrote: > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: >> Hi KDiagram Developers, >> >> The stable branch of KDiagram has been persistently failing to build from >> source now on Windows for a period greater than 5 days. > > Hey Ben, > > can you

Re: plasma-systemmonitor in kdereview

2020-10-01 Thread Harald Sitter
On 01.10.20 14:36, Arjen Hiemstra wrote: > On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: >> On 01.10.20 11:36, Arjen Hiemstra wrote: >>> Hello, >>> >>> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It >>>

Re: plasma-systemmonitor in kdereview

2020-10-01 Thread Harald Sitter
On 01.10.20 11:36, Arjen Hiemstra wrote: > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the

Re: stale MR triage

2020-09-23 Thread Harald Sitter
On 19.09.20 02:18, Albert Astals Cid wrote: > Not really, the thing is, for Okular i knew that all things that were old > didn't need my attention, it was either on the patch author to come back and > fix something or someone else should be the one reviewing, so just looking at > the last

Re: stale MR triage

2020-09-18 Thread Harald Sitter
On Fri, Sep 18, 2020 at 3:09 AM Ben Cooksley wrote: > > On Fri, 18 Sep 2020, 2:58 am Harald Sitter, wrote: >> >> Griaß eich! > > > Hi Harald, > >> >> In the KF6 BOF we were chatting about merge requests not being nearly >> as actively watched be

Re: stale MR triage

2020-09-18 Thread Harald Sitter
On Fri, Sep 18, 2020 at 12:36 AM Albert Astals Cid wrote: > > El dijous, 17 de setembre de 2020, a les 16:57:32 CEST, Harald Sitter va > escriure: > > Griaß eich! > > > > In the KF6 BOF we were chatting about merge requests not being nearly > > as activ

stale MR triage

2020-09-17 Thread Harald Sitter
Griaß eich! In the KF6 BOF we were chatting about merge requests not being nearly as actively watched because people didn't necessarily subscribe to all projects. While that is a solvable problem by asking people to kindly subscribe, it got us thinking that we should have a way to deal with stale

Re: plasma-disks in kdereview

2020-08-25 Thread Harald Sitter
It's been 3 weeks so I'm considering it in good enough shape for moving to plasma. Thanks! :) On Tue, Aug 4, 2020 at 3:46 PM Harald Sitter wrote: > > Hey > > It'd be awesome if I could get some eyes at the new > https://invent.kde.org/system/plasma-disks which implements sma

Re: plasma-disks in kdereview

2020-08-05 Thread Harald Sitter
On Wed, Aug 5, 2020 at 12:00 AM Albert Astals Cid wrote: > > El dimarts, 4 d’agost de 2020, a les 15:46:20 CEST, Harald Sitter va escriure: > > Hey > > > > It'd be awesome if I could get some eyes at the new > > https://invent.kde.org/system/plasma-disks which i

plasma-disks in kdereview

2020-08-04 Thread Harald Sitter
Hey It'd be awesome if I could get some eyes at the new https://invent.kde.org/system/plasma-disks which implements smart monitoring as requested in https://bugs.kde.org/show_bug.cgi?id=254313 I've opted to not put it in kinfocenter directly because it is a bit much with its own kded module and

Re: Blacklisting of PIM from the CI system

2019-12-05 Thread Harald Sitter
It's a good idea. I thought about that briefly. Two problems immediately came to mind that made me discard the idea: a) for builds that are not from git we'd not know the commit count (unless we glue that into the git release commit / tag - which I am not sure we actually want, but is certainly a

Re: Blacklisting of PIM from the CI system

2019-12-05 Thread Harald Sitter
3 AM Kevin Kofler wrote: > > Harald Sitter wrote: > > Random thought to make dependency problems more obvious: glue the git > > sha into the cmake package version for frameworks (when built from > > git) so it finds "5.65.0.abcd123" given us a lead on wha

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Harald Sitter
On Tue, Dec 3, 2019 at 8:55 PM Volker Krause wrote: > > On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: > [...] > > > > Fixing the current set of failures

Re: rekonq to unmaintained

2019-09-18 Thread Harald Sitter
now unmaintained https://commits.kde.org/sysadmin/repo-metadata/67d487fe1262c65cbef2fdc0c10e80ad14fc22fc On Thu, Sep 12, 2019 at 3:45 PM Harald Sitter wrote: > > I'd like to suggest moving rekonq to unmaintained > > Its master branch is still kdelibs4, the frameworks branch hasn'

rekonq to unmaintained

2019-09-12 Thread Harald Sitter
I'd like to suggest moving rekonq to unmaintained Its master branch is still kdelibs4, the frameworks branch hasn't seen any progress in 21 months. Hasn't had a release in years. Very unmaintained all in all. Any objections? HS

Re: Possible to move some KF5 frameworks to invent?

2019-08-13 Thread Harald Sitter
On Tue, Aug 13, 2019 at 12:54 PM Ben Cooksley wrote: > > On Mon, Aug 12, 2019 at 11:48 PM David Faure wrote: > > > > On lundi 12 août 2019 13:04:29 CEST Ben Cooksley wrote: > > > On Mon, Aug 12, 2019 at 10:54 PM Albert Vaca Cintora > > > > > > wrote: > > > > On Mon, Aug 12, 2019, 18:46 Ben

Re: Possible to move some KF5 frameworks to invent?

2019-08-11 Thread Harald Sitter
On Mon, Aug 12, 2019 at 12:23 AM David Faure wrote: > > On dimanche 11 août 2019 22:14:19 CEST Albert Astals Cid wrote: > > without having your own fork of a repository, that is annoying for various > > reasons > > If creating a fork can be scripted, then that could be a fallback solution > (to

Re: binary compatibility and qwidget::event

2019-07-16 Thread Harald Sitter
That makes sense. Thanks all! :) On Fri, Jul 12, 2019 at 1:09 PM Volker Krause wrote: > > On Friday, 12 July 2019 11:24:35 CEST Harald Sitter wrote: > > But why was that BIC to begin with? Which of the "don'ts" did it violate? > > IIUC re-implementing a virt

Re: binary compatibility and qwidget::event

2019-07-12 Thread Harald Sitter
b0743a00b6f > [2] > https://cgit.kde.org/kiconthemes.git/commit/?id=083bb8a80fd5941e6fcbaf1ec12a08d8f8c881a5 > > Am 12.07.19 um 11:14 schrieb Harald Sitter: > > Hey > > > > our binary compatibility page [1] states that one should > > > > "reimplement event in QObjec

binary compatibility and qwidget::event

2019-07-12 Thread Harald Sitter
Hey our binary compatibility page [1] states that one should "reimplement event in QObject-derived classes, even if the body for the function is just calling the base class' implementation." Does anyone know the reason this helps maintain BC? [1]

Re: CI system maintainability

2019-03-28 Thread Harald Sitter
On Thu, Mar 28, 2019 at 3:57 PM David Jarvie wrote: > I agree. Mandatory reviews might work if there is a team of active people > working on a project, but if there is only one person with real knowledge of > the code We do have common ownership of code, so if there is only one person with

Re: KDE's release script not functional on stable openSUSE

2019-01-24 Thread Harald Sitter
2.1 reached EOL almost 2 years ago. I suggest you ruby-build or rvm a newer version isolated from your system's. On Thu, Jan 24, 2019 at 11:29 AM Jaroslaw Staniek wrote: > > Hi Jonathan, > The releaseme tools require ruby 2.3 while openSUSE 42.3 depends on 2.1. And > it lacks multiple ruby

Re: Kdiff3 release.

2018-08-02 Thread Harald Sitter
this should help https://community.kde.org/ReleasingSoftware On Thu, Aug 2, 2018 at 9:25 AM Michael Reeves wrote: > > That's what I'm looking at doing. The translation need some minor updating. > In particular the docs were changed to correct some obsolete information > regarding windows and

Re: http://commitfilter.kde.org/ ?

2017-10-29 Thread Harald Sitter
See http://markmail.org/thread/hekkp2rcdvir732q http://markmail.org/thread/b6neyhjak2h4g2yd On Sun, Oct 29, 2017 at 9:47 PM, Martin Koller wrote: > Should http://commitfilter.kde.org/ still exist ? > Currently I get "unknown host" > > -- > Best regards/Schöne Grüße > > Martin >

Re: Elisa is in kdereview

2017-06-23 Thread Harald Sitter
On Wed, Jun 21, 2017 at 11:15 PM, Matthieu Gallien wrote: > Hello, > On mercredi 21 juin 2017 23:01:23 CEST Albert Astals Cid wrote: >> El divendres, 16 de juny de 2017, a les 22:44:03 CEST, Matthieu Gallien va >> >> escriure: >> > Hello, >> > >> > Elisa is now in

Re: What's kde-core-devel for?

2016-12-19 Thread Harald Sitter
On Thu, Dec 15, 2016 at 10:18 PM, Albert Astals Cid wrote: > In the old days it had kdelibs development discussion but not that that has > moved over to kde-frameworks-devel, waht's kde-core-devel for? *cough* http://markmail.org/thread/opcvfo5h7elrvqdl Everyone kinda agrees that

Re: Can't release applications

2016-07-27 Thread Harald Sitter
On Wed, Jul 27, 2016 at 12:27 PM, Luigi Toscano wrote: > On Wednesday, 27 July 2016 12:22:45 CEST Aleix Pol wrote: >> Hi, >> There's a major blocker when trying to release applications nowadays. >> To update the stable branch one needs to commit to the >>

  1   2   >