Which KIO job is suitable for batching?

duced to ~22 seconds in parallel. It's not a perfect optimization but much faster. But for this to work in KIO the IOSlave needs to receive a bunch of urls to process. Cheers, Mark

Re: The curious case of stuck systemd poweroff

On Thu, Jul 14, 2016 at 8:17 PM, Harald Sitter wrote: > On Thu, Jul 14, 2016 at 8:06 PM, Andreas Hartmetz > wrote: > > On Donnerstag, 14. Juli 2016 16:19:15 CEST Harald Sitter wrote: > >> On Thu, Jul 14, 2016 at 3:43 PM, Andreas Hartmetz > >

Re: Review Request 127866: Oxygen: Fix QCache usage

ference to a local variable since that reference will invalidate as soon as > we return from the function. Of course a reference to a cached QColor may > *also* invalidate with the next call to an insert method of that cache, but > that's a separate story. > >

Re: KDE file dialog

On Wed, Mar 2, 2016 at 9:42 AM, Martin Graesslin wrote: > On Monday, February 29, 2016 9:42:11 PM CET Sven Brauch wrote: > > Hey, > > > > On 02/28/2016 03:58 PM, Luigi Toscano wrote: > > > This is what I use: > > > export QT_QPA_PLATFORMTHEME=kde > > > > > > and you need the

Re: KDE file dialog

On Tue, Mar 1, 2016 at 7:42 PM, Sven Brauch <m...@svenbrauch.de> wrote: > Hey, > > On 03/01/2016 07:37 PM, Mark Gaiser wrote: > > but there is > > undoubtedly going to be a point in time where the plugin only works when > > some very specific plasma pa

Re: KDE file dialog

Op 29 feb. 2016 11:10 p.m. schreef "Thiago Macieira" : > > On segunda-feira, 29 de fevereiro de 2016 21:42:11 PST Sven Brauch wrote: > > Hey, > > > > On 02/28/2016 03:58 PM, Luigi Toscano wrote: > > > This is what I use: > > > export QT_QPA_PLATFORMTHEME=kde > > > > > > and you

Re: Plasma Applet for Audio Volume for kdereview

On Mon, Aug 17, 2015 at 3:10 PM, Sebastian Kügler se...@kde.org wrote: I think we should be peachy now. Can plasma-pa be moved from kdereview to kde/workspace? Just my opinion as a plasma 5 user. Yes, please! Kmix was great under KDE 4.xx, not so much under 5.xx. This feels much better and

Re: KSyCoca, Thread safety, and Cache invalidation

On Tue, Jul 28, 2015 at 4:28 PM, David Faure fa...@kde.org wrote: On Tuesday 14 July 2015 19:28:58 Thomas Lübking wrote: On Dienstag, 14. Juli 2015 19:00:14 CEST, Milian Wolff wrote: On Tuesday, July 14, 2015 11:49:25 AM David Faure wrote: On Friday 26 June 2015 18:03:00 Frank

Re: 3 UDSEntry optimizations

On Fri, Jul 24, 2015 at 10:23 AM, Milian Wolff m...@milianw.de wrote: On Thursday, July 23, 2015 10:15:20 PM Mark Gaiser wrote: On Sun, Jul 19, 2015 at 11:11 PM, Mark Gaiser mark...@gmail.com wrote: Hi, I just pushed 3 UDSEntry changes to gerrit for your reviewing pleasure: 1

Re: 3 UDSEntry optimizations

On Sun, Jul 19, 2015 at 11:11 PM, Mark Gaiser mark...@gmail.com wrote: Hi, I just pushed 3 UDSEntry changes to gerrit for your reviewing pleasure: 1: https://gerrit.vesnicky.cesnet.cz/r/#/c/473/ 2: https://gerrit.vesnicky.cesnet.cz/r/#/c/474/ 3: https://gerrit.vesnicky.cesnet.cz/r

3 UDSEntry optimizations

. I would like to know what you folks think of these improvements. I really wonder how much more performance i can squeeze out of UDSEntry. Regarding gerrit. How can i make patch 2 and 3 dependent on 1? And why is gerrit failing? Best regards, Mark

Re: KDE Frameworks 5.12.0 released

snip Add QQC clone of KColorButton snip This is not a comment for David, but more in general for changelog messages. This specific massage is quite vague, you really need to have knowledge about QQuick classes to know what that line means. A message like: Added QML ColorButton component to

Re: KScreenGenie moved to KDE Review

On Sun, Jun 28, 2015 at 7:27 PM, Eike Hein h...@kde.org wrote: On 06/28/2015 11:10 AM, Martin Gräßlin wrote: In opposite KSnapshot is a very mature application with a decade of development behind it. It's also a rather stagnant one, and a new developer with the desire to improve upon

Frameworks compiler and Qt requirements after Qt 5.7?

version numbers for the compilers. They would now be considered cutting edge but in a year time most distributions will be at those versions or even newer. What's your opinion on this? Cheers, Mark

Re: Re: Frameworks compiler and Qt requirements after Qt 5.7?

reason. Mark, In my opinion you had to start this kind of discussion with emphasizing the new features in Qt 5.{6,7} and in new versions of compilers that would help us make KF5 better. For me this is still unclear. -- Alexander Potashev Your GCC argument is wrong (unless you mistyped

KIO SMB slave performance issue. Any help?

this issue further. Would anyone (preferably with knowledge of the SMB slave) be kind enough to provide some help or pointers where i can find help to tackle this issue? Cheers, Mark

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

is for kdelibs (KDE SC 4.xx). I don't know if that gets another release. Either way, KIO frameworks [1] is where this should be applied to when you get a ship it. [1] http://quickgit.kde.org/?p=kio.git - Mark Gaiser On feb 20, 2015, 9:28 p.m., Stefan Brüns wrote

Re: KDE Frameworks 5.7.0 released

snip http://kde.org/announcements/kde-frameworks-5.7.0.php That link gives me a very white page, no source either. I think you have to re-upload that file.

Re: Help solving this month's Bug of the Month

On Wed, Feb 4, 2015 at 11:53 PM, Martin Sandsmark martin.sandsm...@kde.org wrote: On Wed, Feb 04, 2015 at 09:51:53PM +0100, Albert Astals Cid wrote: Even if it's an upstream bug, in my opinion the BugOfTheMonth+GardeningEffort is showing the users that we care, and if they are affected by a

Re: kdesrc-build: how to set cmake options for one specific framework?

On Wed, Jan 14, 2015 at 8:35 PM, Martin Klapetek martin.klape...@gmail.com wrote: On Wed, Jan 14, 2015 at 8:08 PM, Mark Gaiser mark...@gmail.com wrote: On Wed, Jan 14, 2015 at 7:36 PM, Martin Klapetek martin.klape...@gmail.com wrote: On Wed, Jan 14, 2015 at 7:31 PM, Mark Gaiser mark

Re: kdesrc-build: how to set cmake options for one specific framework?

On Wed, Jan 14, 2015 at 7:36 PM, Martin Klapetek martin.klape...@gmail.com wrote: On Wed, Jan 14, 2015 at 7:31 PM, Mark Gaiser mark...@gmail.com wrote: Hi, Kdesrc-build uses (right?) projects.kde.org to get a list of frameworks and compile them. That works great :) However, a few hours

kdesrc-build: how to set cmake options for one specific framework?

kdesrc-build and just add -DKIOCORE_ONLY to the cmake step. I prefer to keep using kdesrc-build so i wonder how to add a cmake define for just the kio framework. Cheers, Mark [1] https://gerrit.vesnicky.cesnet.cz/r/#/c/322/

Re: Adding experimental parts to a KF5 library

On Fri, Jan 9, 2015 at 5:34 PM, Ivan Čukić ivan.cu...@kde.org wrote: Hi, Because of the short release cycle for the frameworks, it is hard to have bigger new features included into one of them. Slowly evolving APIs while developing stuff leaves a lot of crud and deprecated methods later.

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

if this works in the KIO framework (Qt5), where I ported it to QUrl... Mark Gaiser wrote: Just tried it out on KF5. The issue as described on 335922 is partly present. Input files: f#1.png f%1.png f#2.png f%2.png Command used: kdialog --multiple

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

if this works in the KIO framework (Qt5), where I ported it to QUrl... Mark Gaiser wrote: Just tried it out on KF5. The issue as described on 335922 is partly present. Input files: f#1.png f%1.png f#2.png f%2.png Command used: kdialog --multiple

Re: Review Request 116481: Calculate remaining battery lifetime considering ALL installed batteries

. a/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp https://git.reviewboard.kde.org/r/116481/#comment45844 curly braces.. - Mark Gaiser On feb 28, 2014, 1:53 p.m., Joschi Brauchle wrote: --- This is an automatically

Re: Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

a default dialog and be done with it, no? Sorry if i'm totally wrong since i don't know this code. In that case, please do elaborate on why KIO works the way it does. - Mark Gaiser On July 12, 2014, 9:55 a.m., Marko Käning wrote

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

the option of doing: files += dir.entryList(QStringList() *.desktop, QDir::Files); Cool huh, one liners? :) - Mark Gaiser On jul 5, 2014, 12:50 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 119130: Fix template discovery in KNewFileMenu (incorrect port to QStandardPaths)

On jul 5, 2014, 1:11 p.m., Mark Gaiser wrote: src/filewidgets/knewfilemenu.cpp, lines 875-878 https://git.reviewboard.kde.org/r/119130/diff/1/?file=287354#file287354line875 You should be able to replace this with: files.append(dir.entryList(QStringList() *.desktop, QDir

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

with a QScopedPointer (documentation for it: http://qt-project.org/doc/qt-5/qscopedpointer.html) objects? It kinda takes away the need for you to delete since it will simply run out of scope (and be deleted). Or go the C++11 way and use std::unique_ptr: http://en.cppreference.com/w/cpp/memory/unique_ptr - Mark

Re: Review Request 119088: powerdevil - don't leak job pointer in brightness control

On July 2, 2014, 6:06 p.m., Mark Gaiser wrote: May i suggest to replace those new lines with a QScopedPointer (documentation for it: http://qt-project.org/doc/qt-5/qscopedpointer.html) objects? It kinda takes away the need for you to delete since it will simply run out of scope

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

four files: /home/kde-devel/335922/f#1.png /home/kde-devel/335922/f#2.png /home/kde-devel/335922/f%251.png /home/kde-devel/335922/f%252.png The files with a # in them seem to be parsed just fine in KF5. Those with a percent sign still get replaced by %25. - Mark

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

if this works in the KIO framework (Qt5), where I ported it to QUrl... Mark Gaiser wrote: Just tried it out on KF5. The issue as described on 335922 is partly present. Input files: f#1.png f%1.png f#2.png f%2.png Command used: kdialog --multiple

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

if this works in the KIO framework (Qt5), where I ported it to QUrl... Mark Gaiser wrote: Just tried it out on KF5. The issue as described on 335922 is partly present. Input files: f#1.png f%1.png f#2.png f%2.png Command used: kdialog --multiple

Re: Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

if this works in the KIO framework (Qt5), where I ported it to QUrl... Mark Gaiser wrote: Just tried it out on KF5. The issue as described on 335922 is partly present. Input files: f#1.png f%1.png f#2.png f%2.png Command used: kdialog --multiple

Re: Review Request 117789: Optimize word count in PlainTextExtractor.

://git.reviewboard.kde.org/r/117789/#comment39696 Please update this link since it doesn't exist anymore. http://qt-project.org/doc/qt-5/qregexp.html ? - Mark Gaiser On April 26, 2014, 1:15 p.m., Milian Wolff wrote: --- This is an automatically

kdesrc-build complains about a dependency cycle in kdelibs..

Hi, If i use the default config[1] i get this[2] error. This is in an attempt to build parts of KDE 4.13 git. My kdesrc-build is at git branch 598ad6225ddf1fa1d9701eaa0eb350b57eb337fc (fresh clone). Any idea what might be causing this? Cheers, Mark [1] http://quickgit.kde.org/?p=kdesrc

Re: kdesrc-build complains about a dependency cycle in kdelibs..

On Sat, Mar 15, 2014 at 9:04 PM, Ben Cooksley bcooks...@kde.org wrote: On Sun, Mar 16, 2014 at 6:18 AM, Mark Gaiser mark...@gmail.com wrote: Hi, Hi Mark, If i use the default config[1] i get this[2] error. This is in an attempt to build parts of KDE 4.13 git. My kdesrc-build is at git

Re: kdesrc-build complains about a dependency cycle in kdelibs..

On Sat, Mar 15, 2014 at 10:50 PM, Michael Pyne mp...@kde.org wrote: On Sat, March 15, 2014 21:47:39 Mark Gaiser wrote: Can you try setting up separate builds? Hi Ben, At first i was indeed trying to build both under the same user (but different prefixes and configs). I was expecting

Re: Using kqmlgraphplugin in Plasma Next

On Fri, Jan 31, 2014 at 5:34 AM, Bhushan Shah bhus...@gmail.com wrote: To people from kde-core-devel: please keep me and plasma-devel in CC, I am not subscribed to list Hello, Currently I am working on a QML Canvas based SignalPlotter, to replace the old Plasma1SignalPlotter which is

Re: Using kqmlgraphplugin in Plasma Next

snip Canvas based: I have no experience with that but I guess performance is should be better than with QPaintedItem, since it directly renders to a GPU framebuffer and painting can be done in an separate thread. As far as i know both (canvas and qpainter) are software rendered. However,

Re: Review Request 114956: Add support for getting a samba share's total size and free space through KIO

=4ac893382c76def83f8e6e12698931df243085f9hb=57b8159fb6bed607d7eef6ec580077484d554207f=src%2Fkdecore%2Fkurl.h - Mark --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114956/#review48175

Re: Nepomuk in 4.13 and beyond

On Wed, Dec 18, 2013 at 11:07 PM, Jos Poortvliet jospoortvl...@gmail.com wrote: On Tuesday 17 December 2013 12:22:26 Todd wrote: On Dec 12, 2013 6:36 PM, Vishesh Handa m...@vhanda.in wrote: i’ll say it again here so that it is at least on record: i really disagree with renaming Nepomuk.

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec. 5, 2013

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

. If there still is nothing by next friday (13th dec.) then i will go ahead and push. - Mark Gaiser On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

that include are used at all. Will take a look at it and remove it if possible. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review45466

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

. Thanks, Mark Gaiser

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

Bump. Can anyone look at this? On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: It's been stalled for almost three months now, any chance to see progress or should it be discarded? Mark Gaiser wrote: No, it should most certainly not be disgarded. It was even working when i posted this post up for review

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

in the SMB improvements that you had in mind? - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/#review44515 --- On Sept. 2

Re: KMountPoint::probablySlow and cifs mount points

On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau agat...@kde.org wrote: Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit : On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid aa...@kde.org wrote: In Okular we just got bug https://bugs.kde.org/show_bug.cgi?id=327846 PDF Render time

Re: KMountPoint::probablySlow and cifs mount points

On Mon, Nov 25, 2013 at 5:41 PM, Aurélien Gâteau agat...@kde.org wrote: Le lundi 25 novembre 2013 13:54:38 Mark Gaiser a écrit : On Mon, Nov 25, 2013 at 10:45 AM, Aurélien Gâteau agat...@kde.org wrote: Le dimanche 24 novembre 2013 19:42:25 Mark Gaiser a écrit : On Sun, Nov 24, 2013 at 5:05

Re: KMountPoint::probablySlow and cifs mount points

On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid aa...@kde.org wrote: In Okular we just got bug https://bugs.kde.org/show_bug.cgi?id=327846 PDF Render time is unreasonably slow over cifs on high latency (WAN) network connections Basically the issue is that poppler is quite read-intensive

Re: KMountPoint::probablySlow and cifs mount points

On Sun, Nov 24, 2013 at 10:09 PM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 24 de novembre de 2013, a les 19:42:25, Mark Gaiser va escriure: On Sun, Nov 24, 2013 at 5:05 PM, Albert Astals Cid aa...@kde.org wrote: In Okular we just got bug https://bugs.kde.org/show_bug.cgi?id=327846

Re: Can we make api.kde.org search better?

like it finds more indeed! Awesome job! Can it be tweaked even further to also find for example kio::stat? It doesn't find that and i'm sure it exists :) Cheers, Mark

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

version should only get bug fixes. While this is certainly an improvement, it's not a patch that fixes any bug. On the other hand, memory improvements are always welcome if i recall correctly. - Mark --- This is an automatically generated e

Re: Review Request 111050: Fast mime detection speedup.

On Oct. 27, 2013, 6:50 p.m., Albert Astals Cid wrote: Mark, David, what's the status of this? Are you going to work further on this or shall it be discarded not to clutter the kdelibs group review list? Yes, there would be a speedup by further tweaking this patch. But would it be worth

Re: Review Request 111050: Fast mime detection speedup.

::testURLList() PASS : KUrlMimeTest::testOneURL() PASS : KUrlMimeTest::testFromQUrl() PASS : KUrlMimeTest::testMostLocalUrlList() PASS : KUrlMimeTest::cleanupTestCase() Totals: 6 passed, 0 failed, 0 skipped * Finished testing of KUrlMimeTest * Thanks, Mark Gaiser

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

themes). I disagree with the change, but understand it if you would push it regardless. The general design theme these days seems to be heading back to 16 color monitors anyway. - Mark Gaiser On Oct. 24, 2013, 2:32 p.m., Martin Klapetek wrote

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

and the results thereof. Just awesome! I initially had an idea to drop the hash completely and use QVector, but i didn't see how to properly implement that. I knew it would be possible, just not how. Looking at your code is also teaching me a thing or .. 10 .. :) - Mark Gaiser On Oct. 24, 2013, 10

Re: FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

://llvm.org/bugs/show_bug.cgi?id=15651 -- Mark Kretschmann Amarok Developer Fellow of the Free Software Foundation Europe http://amarok.kde.org - http://fsfe.org

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

usage of those entries. Here storing them is obviously useless, but in reality - in dolphin - this is done as well only encapsulated in KFileItem objects. Good luck! If you need more, just ask. - Mark Gaiser On Oct. 21, 2013, 6:23 p.m., Frank Reininghaus wrote

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

-ebook/dp/B00DESYHRC and am reading it right now :) - Mark Gaiser On Oct. 20, 2013, 5:27 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113355

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f Diff: http://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

On Oct. 14, 2013, 6:47 a.m., Kevin Ottens wrote: Why do it just for result and not finished, suspended, resumed? We end up with both mechanisms for private signals in the same header otherwise. Will do. Will update this patch shortly. - Mark

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

. Diffs (updated) - tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f Diff: http://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

would have expected this to be left-aligned on column 0. Do you want me to left align it for the commit? Both are OK with me, this simply looked better :) - Mark --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

/ Testing --- Works just fine. Thanks, Mark Gaiser

Re: Review Request 112982: copyToFile support for kio_smb

out and report my findings later today. I guess this is the long awaited patch that improves the file copy speed from SMB to local. - Mark Gaiser On Sept. 29, 2013, 4:10 p.m., Dawit Alemayehu wrote: --- This is an automatically generated

Re: Review Request 112982: copyToFile support for kio_smb

this about equal in speed compared to cifs? - Mark Gaiser On Oct. 5, 2013, 3:07 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112982

Re: Review Request 112982: copyToFile support for kio_smb

On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However

Re: Review Request 112982: copyToFile support for kio_smb

On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However

Re: Review Request 112982: copyToFile support for kio_smb

On Oct. 5, 2013, 4:01 p.m., Mark Gaiser wrote: Tested it. PRE patch: ~17MB/s POST patch: ~27MB/s So in functionality terms this patch makes a file copy from a windows share (note: a linux machine sharing through samba, not an actual windows machine) much faster. However

Re: QML-using app developers: use private.* imports

On Wed, Sep 25, 2013 at 11:21 PM, Sebastian Kügler se...@kde.org wrote: On Wednesday, September 25, 2013 17:51:41 Mark wrote: Doesn't your naming proposal completely ruin the org.kde.* stuff? Up until now i could fairly safely assume that all QML KDE imports where hidden under org.kde

Re: QML-using app developers: use private.* imports

On Wed, Sep 25, 2013 at 3:51 PM, Sebastian Kügler se...@kde.org wrote: Hey all, In Plasma, we've been looking into privatizing parts of the QML API we offer. With Qt5, we rely less on setContextProperty() and friends, and use imports more. That's a technical necessity that makes one problem

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

I'm pretty sure it was included already, via one of the kio/* includes below. You can just remove this. It's odd, it (QtCreator) does underline it in red (as if it can't find it) when i remove that line. But compiling seems to be working just fine. So it's removed now. - Mark

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

the ones that are enabled now, the disabled slaves will follow once they themselves are ported. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40016

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

, Mark Gaiser

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

that are there are passing though i doubt they test this case. the KIO file slave also works just fine. Compilation does give me new (expected_ deprecated errors for at least the http slave. I don't know how to test that one. It should just work fine though. Thanks, Mark Gaiser

Review Request 112702: KIO slavebase listEntry improvement and cleanups

- kioslave/file/file_unix.cpp 48bd0ba staging/kio/src/core/slavebase.h b46631e staging/kio/src/core/slavebase.cpp 2e46985 Diff: http://git.reviewboard.kde.org/r/112702/diff/ Testing --- Thanks, Mark Gaiser

Re: Review Request 112529: By default hide SMB shares that end with $

to review it btw ;) - Mark Gaiser On Sept. 5, 2013, 1:32 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529

Re: Review Request 112529: By default hide SMB shares that end with $

://git.reviewboard.kde.org/r/112529/#comment29075 You forgot to remove this one? - Mark Gaiser On Sept. 6, 2013, 12:35 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529

Re: Review Request 112529: By default hide SMB shares that end with $

would have to give a ship it. - Mark Gaiser On Sept. 6, 2013, 1:04 p.m., Dawit Alemayehu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112529

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

would prefer if you make the changes you want to make. Once those are in i will have to rebase my changes against it and request a ship it again :) - Mark --- This is an automatically generated e-mail. To reply, visit: http

Review Request 112463: Port SMB kioslave to KF5/Qt5

try this out and verify that it's either working or broken. Thanks, Mark Gaiser

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

/112463/#comment28914 This will obviously go once i commit. - Mark Gaiser On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463

Re: KF5 Update Meeting Minutes 2013-w35

On Tue, Aug 27, 2013 at 5:50 PM, Kevin Ottens er...@kde.org wrote: On Tuesday 27 August 2013 17:47:10 Alexander Neundorf wrote: On Tuesday 27 August 2013, Kevin Ottens wrote: Hello everyone, This is the minutes of the Week 35 KF5 meeting. As usual it has been held on #kde-devel at 4pm

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111626/#review37921 --- What's up with this one, is it already shipped? - Mark

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

On Aug. 6, 2013, 10:01 p.m., David Faure wrote: Ship It! Thank you very much for the ship it! Since the release is _very_ close i will ask the release team for permission on this one as well. Otherwise i probably push it after the tag. - Mark

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

, Mark Gaiser

Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

haven't seen any issues thus far. Oh and it passes all kio test cases but i specially note the following: kdirwatchtest kdirlistertest kdirmodeltest Thanks, Mark Gaiser

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

? Yes, this works for all cases with inotify. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111870/#review37041 --- On Aug

Re: KDirWatch bug and the analysis. Help is welcome!

On Fri, Aug 2, 2013 at 3:41 PM, David Faure fa...@kde.org wrote: On Friday 02 August 2013 15:07:19 Mark wrote: Just for my view on this. What's the difference between stat() and kio::stat()? Err, you know the answer is in the docs, right? stat() = unix-only, local files only, sync KIO::stat

Re: KDirWatch bug and the analysis. Help is welcome!

On Thu, Aug 1, 2013 at 10:41 AM, David Faure fa...@kde.org wrote: On Thursday 01 August 2013 01:30:08 Mark wrote: However, we have been given the power of inotify which gives more detailed signals and lets us know which files have been created/added/modified which we should be used imho. OK

KDirWatch bug and the analysis. Help is welcome!

for example if my path to this massive folder is: /home/mark/massive_folder (which it actually is) Then the first dirty signal that arrives in KDirLister is: (dirty) /home/mark/massive_folder -- causes full folder rescan Where i would have expected: (dirty) /home/mark/massive_folder/.directory = Why

Re: KDirWatch bug and the analysis. Help is welcome!

On Thu, Aug 1, 2013 at 12:25 AM, Milian Wolff m...@milianw.de wrote: On Wednesday 31 July 2013 20:51:11 Mark wrote: Hi, I'm horrible in clearly explaining issues and i'm going to explain a lot in this mail. Please read it very carefully. snip Subsequent signals (even create, delete

  1   2   3   >