Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-22 Thread David Faure
filterproxymodeltest.cpp <https://git.reviewboard.kde.org/r/120119/#comment51683> also check that child and subchild etc. can be found? kdeui/tests/krecursivefilterproxymodeltest.cpp <https://git.reviewboard.kde.org/r/120119/#comment51684> I would also expect 3 signal emissions here

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > kdeui/tests/krecursivefilterproxymodeltest.cpp, line 126 > > <https://git.reviewboard.kde.org/r/120119/diff/1/?file=310594#file310594line126> > > > > Shouldn't rowsInserted even be emitted 3 times? On

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
> On Jan. 22, 2015, 7:47 a.m., David Faure wrote: > > kdeui/itemviews/krecursivefilterproxymodel.cpp, line 149 > > <https://git.reviewboard.kde.org/r/120119/diff/1/?file=310592#file310592line149> > > > > refreshAll isn't used anymore, the new code

Re: Review Request 120119: KRecursiveFilterProxyModel: Fixed the model

2015-01-23 Thread David Faure
;ll try to find time to improve the test (and then possibly the implementation). - David Faure On Jan. 22, 2015, 4:06 p.m., Christian Mollekopf wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-23 Thread David Faure
l.cpp efa286ad87ded962b20c8a581b659d1b154ebf3a kdeui/tests/krecursivefilterproxymodeltest.cpp 3bcb72980730cb22f887ae8fa5fbd91b5609aeb6 Diff: https://git.reviewboard.kde.org/r/17/diff/ Testing --- Unittest, obviously. + KMail smoke testing. Thanks, David Faure

Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-25 Thread David Faure
y, but the remaining problem is elsewhere). Thanks, David Faure

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread David Faure
ttest, obviously. + KMail smoke testing. Thanks, David Faure

Re: Review Request 122227: KRecursiveFilterProxyModel: many many more unittests, and fixing what they found.

2015-01-26 Thread David Faure
ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/17/#review74725 ------- On Jan. 23, 2015, 6:11 p.m., David Faure wrote: > > --- > This is an

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-29 Thread David Faure
cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/#review74753 --- On Jan. 25, 2015, 6:51 p.m., David Faure wrote: > > --- > This is an

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2015-01-29 Thread David Faure
only be pulled in by the actual mail folder (pim). > > So far I couldn't find the actual problem to write another testcase, but > I have to assume that KRecursiveFilterProxyModel ist still buggy, and the > additional dataChanged signal just happen to rectify the p

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-01 Thread David Faure
omething, to make it clearer that it's a URL. thumbnail/thumbnail.cpp <https://git.reviewboard.kde.org/r/122341/#comment51966> This will be in the current dir, it should probably be QDir::tempPath() + "/kde-" instead.

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-01 Thread David Faure
took care of it, it's committed, will be in s-m-i 1.4. - David Faure On Feb. 1, 2015, 7:28 p.m., Denis Steckelmacher wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-02 Thread David Faure
> On fév. 1, 2015, 2:40 après-midi, David Faure wrote: > > thumbnail/thumbnail.cpp, line 384 > > <https://git.reviewboard.kde.org/r/122341/diff/1/?file=345985#file345985line384> > > > > Why this change? It's very wrong. > > > >

Re: Review Request 122394: Fix OSX library names in kdeinit5.app

2015-02-02 Thread David Faure
name is correct. - David Faure On fév. 2, 2015, 8:51 après-midi, Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-05 Thread David Faure
uot;save to temp file and then move over existing destination" is to use QSaveFile. It's a corner case so I'm ok with it being fixed in a later commit. Maybe in this one a QFile::remove on the dest is enough, with a comment "// not atomic! should use QSaveFile" - D

Re: Review Request 122341: Port Thumbnail KIO Slave Away from KDELibs4Support

2015-02-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75567 --- Ship it! Nice :) - David Faure On Feb. 6, 2015, 3:50 p.m

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Faure
away from KUrl, not QUrl :-) - David Faure On Feb. 7, 2015, 10:23 p.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 122471: Enable Compilation of about Protocol

2015-02-08 Thread David Faure
rated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122471/ > --- > > (Updated Feb. 7, 2015, 10:23 p.m.) > > > Review request for kde-workspace and David Faure. > > > Repository: kio-extras > > > Description > ---

Re: Review Request 122330: Associate *.qmltypes and *.qmlproject files with the text/x-qml mime type

2015-02-14 Thread David Faure
> On Feb. 1, 2015, 8:32 p.m., David Faure wrote: > > -1 for not submitting this upstream for shared-mime-info. > > > > I took care of it, it's committed, will be in s-m-i 1.4. > > Milian Wolff wrote: > Could we add a comment to this file then, tellin

KDE Frameworks 5.7.0 released

2015-02-14 Thread David Faure
14th February 2015. KDE today announces the release of KDE Frameworks 5.7.0. KDE Frameworks are 60 addon libraries to Qt which provide a wide variety of commonly needed functionality in mature, peer reviewed and well tested libraries with friendly licensing terms. For an introduction see the Fr

Re: kio-extras

2015-02-25 Thread David Faure
y, they didn't even need half of the ones that are already in kio. I think kio-extras makes sense (especially since it brings other dependencies, not just "more code"). I just think it should be either a framework or treated like an app, but definitely not a workspace thing. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE Telepathy has an unreleased dependency

2015-02-25 Thread David Faure
to only join on Beta 3 of KDE > Applications 15.04 I see a fourth option: d) make a KPeople 5.7 release NOW If it's ready, I can make that happen with two commands or so. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE Telepathy has an unreleased dependency

2015-02-25 Thread David Faure
playground somewhere. I don't like the optional dependency thing because it will still show up in dependency diagrams, making a mess with baloo being in the middle of frameworks while it was decided that it's not. > This shouldn't be a show-stopper, even less for the Beta versi

Re: kio-extras

2015-02-25 Thread David Faure
se this is written as a compiling-from-scratch type setup, in practice the binary package for dolphin would bring it in as a dependency) Ah. Is this about kio_desktop? That one should *definitely* be in workspace. But it doesn't have to be in kio-extras. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE Frameworks 5.8 released

2015-03-13 Thread David Faure
plasma package ... ### Buildsystem changes (extra-cmake-modules) * Extend ecm_generate_headers macro to also support CamelCase.h headers -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-17 Thread David Faure
> On March 17, 2015, 4:38 p.m., David Faure wrote: > > Ship It! Yes, both in kdelibs 4 and in the kio framework. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 122652: Use correct default value when UDS_ACCESS/UDS_FILE_TYPE is not set

2015-03-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review77642 --- Ship it! Ship It! - David Faure On March 17, 2015, 4:17

Re: Syncing ECM release number with KF5

2015-04-04 Thread David Faure
t change, but in practice there's always at least one change every month, usually more ;) > FWIW the different version doesn't bother me at all as a downstream. And it doesn't bother me as the release dude - I have one if() in the version file ;) (so, I also disagree with "doubles the complexity"). But since both Stephen Kelly and Alex Merry (maintainers of ECM) are in favour of switching, I'll make the switch. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-18 Thread David Faure
> On Nov. 10, 2014, 9:41 p.m., David Faure wrote: > > lib/konq/src/konq_historyentry.h, line 57 > > <https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57> > > > > const ref, no? > > Andrius da Costa Ribas wrote: > before

Re: Review Request 117345: Fix crash in KIO due to exposing inconsistent views of internal data.

2015-04-20 Thread David Faure
unittest improvements that you wrote for KF5. Sorry for the delay before I reviewed it. - David Faure On Dec. 19, 2014, 6:50 p.m., Simeon Bird wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-25 Thread David Faure
> On Nov. 10, 2014, 9:41 p.m., David Faure wrote: > > lib/konq/src/konq_historyentry.h, line 57 > > <https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57> > > > > const ref, no? > > Andrius da Costa Ribas wrote: > before

KDE Frameworks 5.10.0 released

2015-05-08 Thread David Faure
opened with open() or show() with parent were not opened at all. http://kde.org/announcements/kde-frameworks-5.10.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: building kio on Mac

2015-06-08 Thread David Faure
27;t know how things should work on OSX, I am not in a good position to decide. On top of that I come from the KDE world, so I can't really force a KDE patch into Qt if it's a bit controversial. > , and the module > maintainer for QtCore wanted the opinion of a Digia employee

KDE Frameworks 5.11.0 released

2015-06-12 Thread David Faure
away save() calls by calling it once at the end if needed. http://kde.org/announcements/kde-frameworks-5.11.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-13 Thread David Faure
g an old instance meanwhile (the mmap'ed file uses refcounting in the kernel). When the thread finally gets the task it can call KSycoca::notifyDatabaseChanged (it's a private slot, use QMetaObject::invokeMethod for now, if it works we can make it public). -- David Faure, fa...@kde.

Re: Review Request 123965: Encode KBookmark URL to fix compatibility with KDE4 applications

2015-06-14 Thread David Faure
file, but this is still surprising, Qt5's toString should be a valid URL, parsable by KDE4's KUrl, I would have thought. Oh well. - David Faure On May 31, 2015, 1:28 p.m., Andrey Bondrov wrote: > > --- > This is an auto

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-21 Thread David Faure
On Friday 19 June 2015 22:00:09 Vishesh Handa wrote: > On Sat, Jun 13, 2015 at 9:26 PM, David Faure wrote: > > 3 bis: > > I assume the threads without an event loop have some way to get tasks, > > right? So when the gui thread gets notified about ksycoca changes, it >

KDE Frameworks 5.12.0 released

2015-07-10 Thread David Faure
(bug 348154) Whitelist applets/versions for separate engine Introduce a new class ContainmentView Sonnet Allow to use highlight spellchecking in a QPainTextEdit http://kde.org/announcements/kde-frameworks-5.12.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-14 Thread David Faure
sed since the last check, but I wonder if even checking that (e.g. with QElapsedTimer) has a cost in terms of syscalls... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-20 Thread David Faure
ime()? Or maybe QDateTime::currentDateTime() could avoid calling the awful tzset()? Thiago, any input? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-20 Thread David Faure
On Monday 20 July 2015 16:05:06 David Faure wrote: > On Friday 26 June 2015 18:03:00 Frank Reininghaus wrote: > > https://bugs.kde.org/show_bug.cgi?id=346974 > > > > According to the backtrace, the process is busy inside > > QMimeDataBase::mimeTypeForName(QString) do

Re: Fwd: [Krusader-devel] Help needed for Krusader .desktop files

2015-07-26 Thread David Faure
x27;s as easy as that. It will help determining the desktop file for a running app based on the executable name, which is a use case that shows up more and more (on X11 and on wayland). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-28 Thread David Faure
On Tuesday 14 July 2015 19:28:58 Thomas Lübking wrote: > On Dienstag, 14. Juli 2015 19:00:14 CEST, Milian Wolff wrote: > > On Tuesday, July 14, 2015 11:49:25 AM David Faure wrote: > >> On Friday 26 June 2015 18:03:00 Frank Reininghaus wrote: ... > > > > It has. Queryi

[kde-dev-scripts] /: Add support for ninja to makeobj

2015-07-30 Thread David Faure
Git commit cd599de58b44596a5e86a5fe560e2904ef5efe7f by David Faure. Committed on 30/07/2015 at 12:54. Pushed by dfaure into branch 'master'. Add support for ninja to makeobj Usage: alias make=makeobj, as usual. This allows to do "make" and "make install" (etc.) i

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-30 Thread David Faure
On Thursday 30 July 2015 21:23:00 Mark Gaiser wrote: > You can ignore this message if QMimeType::inherits internally calls the > method you optimized thus this function would be greatly improved already. It does. Why not apply existing known fixes before profiling for more issues? :) --

[kdbusaddons] src: KDBusService: document how to raise the active window, in Activate()

2015-08-03 Thread David Faure
Git commit d9a6ce124ee6ece84e6af4c741f2ad0ed2599928 by David Faure. Committed on 03/08/2015 at 23:23. Pushed by dfaure into branch 'master'. KDBusService: document how to raise the active window, in Activate() CCMAIL: kde-core-devel@kde.org M +3-0src/kdbusservi

Re: Review Request 124657: Show URL again in bookmarks view and URL texbox

2015-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124657/#review83584 --- Ship it! Ship It! - David Faure On Aug. 8, 2015, 2:24 p.m

KDE Frameworks 5.13.0 released

2015-08-12 Thread David Faure
::findLookAndFeelPackage() Rename software-updates.svgz to software.svgz Sonnet Add in CMake bits to enable building of Voikko plugin. Implement Sonnet::Client factory for Voikko spell chekers. Implement Voikko based spell checker (Sonnet::SpellerPlugin) http://kde.org/announcements/kde-f

Re: Proposal to improving KDE Software Repository Organization

2015-08-16 Thread David Faure
o make it part of the procedure for new modules. (*) I keep finding the "division" term a bit obscure, and I wonder if this shouldn't be called "product" instead. I.e. matching how we release things. Nowadays we basically have 4 products (frameworks, plasma, ap

Re: What to do with our default hidden visibility for symbols?

2015-08-16 Thread David Faure
scussion is on-going on kde-buildsys...@kde.org, which is the proper place for it. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Proposal to improving KDE Software Repository Organization

2015-08-16 Thread David Faure
'groups' like kdegraphics, kdemultimedia etc. which are useful in order to have a maintainer per 'group' (as reinforced by the release team recently). But yes, only one level, and AFAICS only useful in Applications. kactivities (to pick your example) would be "at the root of"

Re: Proposal to improving KDE Software Repository Organization

2015-08-17 Thread David Faure
On Sunday 16 August 2015 23:36:33 Luigi Toscano wrote: > David Faure ha scritto: > > On Sunday 16 August 2015 13:51:29 Michael Pyne wrote: > >> There's no reason even with our current build metadata that we'd *have* to > >> have project hierarchies, as long a

Re: Best-practise currently for testing internal parts of libs? *_TEST_EXPORT macro?

2015-09-02 Thread David Faure
rted only for unit tests */ #ifdef COMPILING_TESTS # ifndef KONQ_TESTS_EXPORT # define KONQ_TESTS_EXPORT KONQUERORPRIVATE_EXPORT # endif #else /* not compiling tests */ # define KONQ_TESTS_EXPORT #endif See kde/applications/kde-baseapps/konqueror/src/konqprivate_export.h branch frameworks. -- David F

Re: Review Request 125010: konq-plugins: port kttsd plugin to QtSpeech

2015-09-07 Thread David Faure
gin/khtmltts.cpp (line 30) <https://git.reviewboard.kde.org/r/125010/#comment58753> unused konq-plugins/ttsplugin/khtmltts.cpp (line 51) <https://git.reviewboard.kde.org/r/125010/#comment58752> This line seems unused (in which case, remove the comment for it too). - David

Re: Review Request 125010: konq-plugins: port kttsd plugin to QtSpeech

2015-09-08 Thread David Faure
> On Sept. 7, 2015, 7:37 a.m., David Faure wrote: > > konq-plugins/CMakeLists.txt, line 21 > > <https://git.reviewboard.kde.org/r/125010/diff/1/?file=399825#file399825line21> > > > > using macro_log_feature would be better > > Jeremy Whiting wrot

KDE Frameworks 5.14.0 released

2015-09-12 Thread David Faure
ly text cursor fix parenting and popping up policy declare __editMenu add missing cursot handles delegates rewrite the EditMenu implementation use the mobile menu only conditionally reparent the menu to root http://kde.org/announcements/kde-frameworks-5.14.0.php -- David Faure, fa...

Re: SIC/BIC in Frameworks (NOT)

2015-09-13 Thread David Faure
g. We only support X11 on everywhere or off everywhere. Combinations of "some frameworks with X11 enabled and some with X11 purposefully disabled" don't make sense to me. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-09-13 Thread David Faure
tc()? Or to make this all much more intuitive, should there be a mutex in epochMSecsToLocalTime and localMSecsToEpochMSecs? [the same one, obviously] -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KTabWidget vs QTabWidget

2015-09-19 Thread David Faure
tabwidget... (I assume this is what you want, right?). (I'm keeping the CC to kde-core-devel so its readers can see this has been answered, but I suggest we now followup on kde-frameworks-devel only). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 125367: Make kfileplacesmodeltest pass

2015-09-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125367/#review85858 --- Ship it! Ship It! - David Faure On Sept. 23, 2015, 11:34

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-09-28 Thread David Faure
st yet, but I'm open to the idea, see above) * internal, part of apps (e.g. libkdegames) * internal, part of workspace (e.g. libksysguard) * private to one app (e.g. libkonqueror_private, that's just for unittests) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

2015-10-02 Thread David Faure
meant "should have been toLocalFile()" instead of "should have been path()" ;) - David Faure On Oct. 1, 2015, 8:58 p.m., Sergio Martins wrote: > > --- > This is an automatically generated e-m

Re: Review Request 125476: Fix QUrl usage when calling QFileDialog::getExistingDirectory()

2015-10-02 Thread David Faure
> On Oct. 2, 2015, 7:32 a.m., David Faure wrote: > > Looks good, except for a bug in the commit log. You meant "should have been > > toLocalFile()" instead of "should have been path()" ;) > > Sergio Martins wrote: > which return the same thing

Re: Review Request 119892: [Dolphin] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-04 Thread David Faure
an archive Basically, refactor the code in the next hunk, which finds out if ark supports that mimetype, into a separate function that returns true if supported by ark, false if not. Doing the KService lookup twice is not a problem. - David Faure On Sept. 4, 2014, 7:20 a.m., Arj

Re: Review Request 119890: [Ark] Implement "Add to archive" option when dragging and dropping onto an archive file in dolphin

2015-10-04 Thread David Faure
good to me. At this point it should be ported to KF5 though, I suppose. - David Faure On Aug. 21, 2014, 9:11 p.m., Arjun AK wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 125560: Give unique names to the targets created by KDE4Macros.cmake

2015-10-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125560/#review86607 --- Ship it! Ship It! - David Faure On Oct. 8, 2015, 5:38 p.m

KDE Frameworks 5.15.0 released

2015-10-10 Thread David Faure
support static compilation on windows, add windows libreoffice hunspell dict path Do not assume UTF-8 encoded Hunspell dictionaries. (bug 353133) fix Highlighter::setCurrentLanguage() for the case when previous language was invalid (bug 349151) support /usr/share/hunspell as dict location NSSpellChecker-based plugin http://kde.org/announcements/kde-frameworks-5.15.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-10-18 Thread David Faure
On Saturday 17 October 2015 17:53:25 Alexander Potashev wrote: > Hi David, > > 2015-09-28 23:21 GMT+03:00 David Faure : > > Naming: "experimental" sounds like "it will be a framework at some point, > > when it > > stabilizes". Maybe we should say &

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread David Faure
st.cpp (line 399) <https://git.reviewboard.kde.org/r/125613/#comment59826> Typo: premissions -> permissions kio/tests/jobtest.cpp (line 411) <https://git.reviewboard.kde.org/r/125613/#comment59827> please remove trailing space everywhere - David Faure On Oct.

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-19 Thread David Faure
> On Oct. 19, 2015, 7:28 a.m., David Faure wrote: > > kio/kio/job.cpp, line 2671 > > <https://git.reviewboard.kde.org/r/125613/diff/3/?file=411228#file411228line2671> > > > > Same question here. As the comment says, "the result is still OK", >

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-22 Thread David Faure
e idea of using "and" means that on failure we don't know which condition failed. Why not QVERIFY() both statements separately? kio/tests/jobtest.cpp (line 413) <https://git.reviewboard.kde.org/r/125613/#comment59925> alternatively, you could use QSignalSpy, then you do

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-28 Thread David Faure
> I'm no way sure what that code is supposed to do but testing > if (b) >Q_ASSERT(!b); > looks insane. > > In doubt there should be some mutex somewhere or the entire thing doesn't > make much sense. > > It would seem the stricter test to emitResult() causes a later em

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-28 Thread David Faure
homas Lübking wrote: > Smells like a corrupted stack or threading issue. > > if (dirData.listersCurrentlyListing.isEmpty()) { > qWarning() << "PS, nothing in > directoryData.listersCurrentlyListing for" << jobUrlStr; >

Re: Review Request 125983: Give each htmlhandbook target a unique name

2015-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125983/#review88155 --- Ship it! Ship It! - David Faure On Nov. 7, 2015, 1:59 p.m

Re: Review Request 125995: Only install konqpopupmenuplugin.desktop in kde-baseapps if the KF5 version is less than 5.16

2015-11-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125995/#review88169 --- Ship it! Ship It! - David Faure On Nov. 8, 2015, 6:45 p.m

KDE Frameworks 5.16.0 released

2015-11-13 Thread David Faure
Touchpad to 22x22px size Breeze Icon: add widget icon to notes A script to replace hardcoded colors with stylesheets Apply SkipTaskbar on ExposeEvent Don't set SkipTaskbar on every event http://kde.org/announcements/kde-frameworks-5.16.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KDE Frameworks 5.10.0 released

2015-11-14 Thread David Faure
not? They are not, unless someone tells me to redo a tarball. > Should I send a mail to the release team next time, maybe? Yes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: KSyCoca, Thread safety, and Cache invalidation

2015-11-14 Thread David Faure
On Monday 14 September 2015 20:49:26 Thiago Macieira wrote: > On Sunday 13 September 2015 23:04:01 David Faure wrote: > > On Tuesday 14 July 2015 16:01:09 Thiago Macieira wrote: > > > If you need a machine-comparable time with other systems or across > > > r

KDE Frameworks 5.17.0 released

2015-12-12 Thread David Faure
nnecting or disconnecting (bug 354751) [plasmaquick] Don't link OpenGL explicitly [plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency http://kde.org/announcements/kde-frameworks-5.17.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-19 Thread David Faure
call QStyle's CE_PushButton, so I don't see why these two would be working differently. Is this a workaround for KPushButton which doesn't fix QPushButton? - David Faure On Dec. 11, 2015, 4:26 p.m., René J.V. Bertin wrote: > > -

Re: KF5_ADD_KDEINIT_EXECUTABLE linker errors

2016-01-02 Thread David Faure
ectly, since by > default > the visbility of symbols is set to hidden, so this > target_link_libraries(${_target_NAME} kdeinit_${_target_NAME}) > can't work. > cvsaskpass.cpp contains: > extern "C" int kdemain(int argc, char** argv)... > > What am I missing ? Q_DECL_EXPORT before int kdemain. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 126253: kxmlgui.xsd add Separator append attribute

2016-01-02 Thread David Faure
purposes. kxmlgui.xsd is "more recent" (relatively speaking) and can also be used for validating files (xsd is more powerful for this). Maybe we can kill the DTD file these days. - David Faure On Dec. 6, 2015, 2:34 p.m., Allen Wi

Re: Review Request 126204: kdialog: Implement new password dialog

2016-01-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126204/#review90470 --- Ship it! Ship It! - David Faure On Nov. 30, 2015, 9:27

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread David Faure
> On Jan. 7, 2016, 11:15 a.m., David Faure wrote: > > src/ioslaves/ftp/ftp.cpp, line 1775 > > <https://git.reviewboard.kde.org/r/126659/diff/1/?file=428702#file428702line1775> > > > > The porting bug is here. In kdelibs4 tmptr was initialized to the

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126659/#review90750 --- Ship it! Ship It! - David Faure On Jan. 7, 2016, 12:23

KDE Frameworks 5.18.0 released

2016-01-09 Thread David Faure
l applet (bug 356428) [Containment Interface] Fix erratic high precision scrolling Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist [Window Thumbnails] Don't crash if Composite is disabled Let containments override CompactApplet.qml http://kde.org/announcements

Re: KDE Frameworks 5.18.0 released

2016-01-10 Thread David Faure
tion, won't happen again. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 126249: Fix apidoc format

2016-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126249/#review91465 --- Ship it! Ship It! - David Faure On Jan. 23, 2016, 10

Re: Review Request 120127: Don't show overwrite dialog if file name is empty

2016-01-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120127/#review91466 --- Ship it! Ship It! - David Faure On Sept. 12, 2014, 8

KDE Frameworks 5.19.0 released

2016-02-13 Thread David Faure
the button is compose-over-borders paintedWidth/paintedheight for IconItem http://kde.org/announcements/kde-frameworks-5.19.0.php -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Review Request 127006: konqueror: eliminate signal and shortcut warnings

2016-02-13 Thread David Faure
patches, I only noticed this one by chance) - David Faure On Feb. 7, 2016, 9:07 p.m., Jonathan Marten wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127138: Konqueror: Fix window title showing as "/" when URL ends with that

2016-02-22 Thread David Faure
l.adjusted(QUrl::StripTrailingSlash).fileName(); // if empty... } This looks a bit simpler, I think? If you agree, can you test it, and push it if it works? - David Faure On Feb. 22, 2016, 3:12 p.m., Jonathan Marten wrote: > > ---

Re: [Kde-pim] PIM dependency metadata

2016-02-28 Thread David Faure
g/T1147 > > ktimezoned needs to move out of Plasma then, or the relevant classes > need to be rewritten Yep, this sounds like ktimezoned should move to KF5. How are non-plasma users supposed to get correct timezones in e.g. PIM apps otherwise? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: mailing list archive gone ?

2016-03-01 Thread David Faure
On Sunday 28 February 2016 15:42:29 Martin Koller wrote: > > it says: https://mail.kde.org/mailman/listinfo/kde-core-devel I have now updated this page to point to the archives (thanks to Ingo Klöcker for this help). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working

Re: Review Request 127264: Set CMP0064 to OLD to suppress CMake warnings

2016-03-10 Thread David Faure
mmit where I set CMP0054 (not 64) to NEW (not OLD). Setting a policy to OLD means "I know I'm using something deprecated and I don't care", which isn't exactly a good solution in the long term. Can you try actually doing the same as that other commit, i.e. setting CMP0

Re: Product versions on bugs.kde.org

2016-03-10 Thread David Faure
to g...@git.kde.org:sysadmin/release-tools branch frameworks/5.0 Ideally as part of create_sources_inc so I don't have to run yet another script ;-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 signature.asc Description: This is a digitally signed message part.

KDE Frameworks 5.20.0 released

2016-03-13 Thread David Faure
ack/forward buttons and a "Today" button (bugs 336124, 348362, 358536) Sonnet Don't disable language detection just because a language is set Disable automatic disabling of automatic spelling by default Fix TextBreaks Fix Hunspell dictionary search paths missing '/' (

Re: Product versions on bugs.kde.org

2016-03-13 Thread David Faure
). The "users" of the framework are application developers, who know how to find it in bugzilla. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

Re: Product versions on bugs.kde.org

2016-03-19 Thread David Faure
On Wednesday 16 March 2016 21:40:22 Vishesh Handa wrote: > On Sun, Mar 13, 2016 at 7:57 PM, David Faure wrote: > > On Saturday 12 March 2016 20:38:43 Vishesh Handa wrote: > >> > >> And from my point of view the user doesn't care if Baloo is part of > >>

Re: Product versions on bugs.kde.org

2016-03-26 Thread David Faure
ut the bugzilla component is assigned to Frederik Gladhorn. Frederik, can I write you down in metainfo.yaml as well? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

  1   2   3   4   5   6   7   8   9   10   >