Re: Hidden KDED desktop file crashing systemsettings - where to fix?

2010-11-02 Thread David Faure
= KServiceTypeTrader::self()-query(KDEDModule); for(KService::List::ConstIterator it = kdedModules.begin(); it != kdedModules.end(); ++it) { KService::Ptr service = *it; ... } and yes, it skips Hidden=true files, since they are not in ksycoca at all. -- David Faure

Re: -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_TO_ASCII as policy in kde

2010-11-15 Thread David Faure
... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: Using KWallet to store Cookies

2010-11-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8753 ---

Re: Review Request: Make sure to remove KXMLGUIClients from factory on destruction

2010-11-17 Thread David Faure
On 2010-07-03 22:44:14, David Faure wrote: I was initially against this kind of thing (too many problems with intelligent destructors), this is why it hasn't been done before. But after long consideration, I think this one is safe and, as you say, somewhat expected by users

Re: Help make the KDE Platform modular, instead of complicating each single KDE program

2010-11-29 Thread David Faure
for this use case. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: ksnapshot assert fail

2010-12-05 Thread David Faure
the attached patch. Unittest passes, of course. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org). Index: dialogs/kdialog_p.h === --- dialogs/kdialog_p.h

Re: More about kdelibs unittests

2010-12-09 Thread David Faure
On Thursday 09 December 2010, Aurélien Gâteau wrote: On 09/12/2010 17:52, David Faure wrote: On Tuesday 07 December 2010, Jaime wrote: Hi, I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, and the number of failed tests has grown in a noticeable way

Re: Review Request: In System Settings in French the icon's description is badly cut when there is a single quote

2010-12-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6106/#review9226 --- Ship it! A new unittest for a string handling method == great!

Re: Review Request: Adjust the kde fake mimetype fonts/package so desktop-file-utils/shared-mime-info do not complain

2010-12-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6111/#review9347 --- Ship it! Looks good now. lxr finds no other usage of the

Re: Review Request: Use translated folder names for default values in kcm desktoppaths

2010-12-21 Thread David Faure
) Review request for kdelibs and David Faure. Summary --- Using the Defaults button in the desktoppaths kcm resets all folders to the default values, but is currently using the untranslated strings in branch and trunk. Adding some i18n() calls resets the values to the translated

Re: konq plugins (Re: KParts::TextExtension)

2011-01-03 Thread David Faure
On Tuesday 28 September 2010, David Faure wrote: In fact, I don't understand why they are in extragear. I mean, yes, the initial idea for kdeaddons was so that they can be optionally installed, but nowadays it means and they have a separate release cycle which makes no sense whatsoever

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2011-01-03 Thread David Faure
. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: KIO design decision necessary: unique names in KIO listings

2011-01-14 Thread David Faure
see how that would solve the KIO::move issue. IMHO not allowing the renaming of files in a search result listing is not an option since. ... since you can't finish sentences? :-P -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http

Re: Review Request: Makeobj variable substitution in $OBJ_SUBDIR and $OBJ_REPLACEMENT

2011-01-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6354/#review9656 --- Ship it! Good stuff. At some point we should extract the switch

Re: Initial support for kde_projects.xml in kdesrc-build

2011-02-03 Thread David Faure
is very welcome. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: Workaround for the hang (freeze) when opening VLC's file dialog under KDE...

2011-02-04 Thread David Faure
is broken and should be fixed instead. I never got why we needed to run a subprocess in the first place. Good point, I'll post to xdg with a patch for creating a version file. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http

Re: phononserver phonondevicesrc OpenFlag, askToRemove

2011-02-04 Thread David Faure
On Thursday 06 January 2011, Edgar Fuß wrote: Would it be better to have some configuration option in a phononserverrc not to complain about vanishing sound cards? Yes I think this would be a useful configuration option. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored

Re: irc meeting for kdelibs git workflow

2011-02-04 Thread David Faure
On Tuesday 01 February 2011, Aaron J. Seigo wrote: * 3rd party examples we can learn from: http://public.kitware.com/Wiki/Git/Workflow/Topic Qt? http://wiki.videolan.org/Git -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-04 Thread David Faure
, using an intermediate storage for what the underlying get job is emitting. But the only benefit would be being able to upload remote data, not sure if we have a use case for that. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http

Re: Initial merge

2011-02-07 Thread David Faure
no reason not to forwardport immediately [unlike the other way around, as discussed elsewhere in this thread]. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: New KIO::http_post and KIO::StoredHttpPost APIs that accept a QIODevice as input...

2011-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100516/#review1305 --- Ship it! Looks good, but... kio/kio/job.cpp

Re: A Qt replacement for KGlobal::ref and deref

2011-02-14 Thread David Faure
On Thursday 10 February 2011, Thiago Macieira wrote: Em quinta-feira, 10 de fevereiro de 2011, às 12:45:58, David Faure escreveu: I certainly don't expect it to continue running in the background until certain services finish running, in the background. I can tell you, users

Re: A Qt replacement for KGlobal::ref and deref

2011-02-14 Thread David Faure
. It only has a tray icon. Probably the famous exception to the rule? Do I need to change anything in my app for this? A tray icon *is* a GUI. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: A Qt replacement for KGlobal::ref and deref

2011-02-14 Thread David Faure
then :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: A Qt replacement for KGlobal::ref and deref

2011-02-14 Thread David Faure
On Monday 14 February 2011, David Faure wrote: On Monday 14 February 2011, Thiago Macieira wrote: What I don't want is an app that has no way for me to quit it, other than opening a shell and killing it (or the amazing ksysguard). My pet peeve with this issue is kmail 1.x that used

Re: Review Request: KIO::PreviewJob: Respect the enabled plugins from PreviewSettings

2011-02-16 Thread David Faure
/ --- (Updated Feb. 5, 2011, 7:53 p.m.) Review request for kdelibs and David Faure. Summary --- Currently KIO::PreviewJob respects the settings MaximumSize and MaximumRemoteSize from the KConfigGroup PreviewSettings, but completely ignores the Plugins settings. Because

Re: Review Request: Enable kDebug/kWarning/kError colors when sending output to file instead of tty

2011-02-18 Thread David Faure
On Feb. 18, 2011, 2:03 p.m., Sergio Luis Martins wrote: Johannes Sixt wrote: Why a new variable? Wouldn't it be possible to give the value of KDE_COLOR_DEBUG a meaning? For example: KDE_COLOR_DEBUG=always could enable the new behavior, any other value (except empty) the old

Re: Minor Point Relase Policy

2011-03-07 Thread David Faure
official and standarized. Almost. Before, I was adding new API in the stable branch when necessary for a bugfix, without thinking much about it. Now I'll make a review request, for good measure :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl

Re: KSambaShare destructor proposed patch

2011-03-18 Thread David Faure
patches are good ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: Fix handling of FTP urls whose path name ends with a type code

2011-03-18 Thread David Faure
On Wednesday 16 March 2011, Thiago Macieira wrote: Suggestion: path.left(path.length() - sizeof ;type=); Unreadable. sizeof(;type=) == strlen(;type=X) A hidden off-by-one, how nice to have in our code ;) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored

Re: Review Request: Patch for FTP ioslave unnecessarily asks for password

2011-03-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/#review2040 --- Hmm, this whole block is inside if (failedAuth0), so this means

Re: Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager KIO::Scheduler

2011-04-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101037/#review2447 --- Ship it! Thanks for working on this, iirc this is needed by

Re: Please, return removed Konqueror feature bug (embedded advanced text editor) in KDE 4.6

2011-04-15 Thread David Faure
. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
On April 18, 2011, 12:43 p.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 1766 http://git.reviewboard.kde.org/r/101149/diff/1/?file=14721#file14721line1766 Maybe this should be while we haven't read 1024 bytes, but of course the file could be smaller than that so it would have

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101149/ --- (Updated April 18, 2011, 7:39 p.m.) Review request for kdelibs and David Faure. Summary --- The attached patch changes the ftpGet function

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
.) Review request for kdelibs and David Faure. Summary --- The attached patch changes the ftpGet function such that it emits the mime-type of the content it is about to read, before starting to read it. That way kio_ftp will work correctly if and when it is put on hold to be reused

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
On April 18, 2011, 8:31 p.m., David Faure wrote: kioslave/ftp/ftp.cpp, line 2405 http://git.reviewboard.kde.org/r/101149/diff/3/?file=14732#file14732line2405 If m_size is UnknownSize and the file is less than 1024 bytes, this code is going to hit the timeout, waiting for data

Re: Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

2011-04-18 Thread David Faure
18, 2011, 10:29 p.m.) Review request for kdelibs and David Faure. Summary --- The attached patch changes the ftpGet function such that it emits the mime-type of the content it is about to read, before starting to read it. That way kio_ftp will work correctly if and when

Re: Please, return removed Konqueror feature bug (embedded advanced text editor) in KDE 4.6

2011-04-19 Thread David Faure
and toolbars, so adding editing functionality will just make it look like an even bigger beast that only 1% of the existing konqueror users will feel comfortable using. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http

Re: Review Request: Proper All files option when using mime types as filters for KFileDialog's functions

2011-04-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101075/#review2764 --- Ship it! I like it. To answer I am not sure why

Re: Review Request: Do not preserve username information on redirection in KIO

2011-04-21 Thread David Faure
/ --- (Updated April 21, 2011, 2:50 a.m.) Review request for kdelibs and David Faure. Summary --- This patch completely removes the automatic restoration of the user name from the original url to the redirection url at the job level. Even though I tried to lookup why

Re: Replacement for Qt's Undo Framework

2011-04-26 Thread David Faure
for kdelibs-4.0 and then noticing Qt got undo classes... It would be extremely ironic (not to say frustrating) to now see another set of undo classes in kdelibs in their place! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http

Re: Review Request: First part of fixes for password caching in KIO: SlaveBase::openPaswordDialog

2011-04-26 Thread David Faure
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101174/ --- (Updated April 24, 2011, 12:10 a.m.) Review request for kdelibs and David Faure. Summary --- The is the first part

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
/ --- (Updated April 27, 2011, 7:28 a.m.) Review request for kdelibs and David Faure. Summary --- The attached patch addresses most of the FTP login related problems and is a replacement for the previous review request https

Re: Review Request: Fix for a couple of KIO put-slave-on-hold bugs

2011-04-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101244/#review2939 --- kio/kio/scheduler.cpp

Re: Help on .desktop files for oxygen

2011-04-28 Thread David Faure
menu... If it doesn't register to dbus at all, remove these lines completely. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: saving/restoring session in kded module

2011-04-28 Thread David Faure
. IMHO that options is about re-opening old windows, not about ignoring any saved settings. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: Fix for a couple of KIO put-slave-on-hold bugs

2011-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101244/#review2973 --- Ship it! Looks good to me, apart from two small things.

Re: Review kdelibs whiting/fixQByteArrays

2011-04-29 Thread David Faure
. The compiler will tell you ;) ). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: saving/restoring session in kded module

2011-05-02 Thread David Faure
the use of this, unless it's really needed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-05-16 Thread David Faure
: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated May 15, 2011, 7:59 p.m.) Review request for kdelibs and David Faure. Summary --- Attempted patch to make konqueror

Re: Review Request: remove functions *Command::name() which are not used

2011-06-05 Thread David Faure
, 2011, 6:55 a.m.) Review request for KDE Base Apps and David Faure. Summary --- konq-plugins/domtreeviewer builds without there functions. May be these functions were left for future integration of domtreeviewer undoable commands' into Konqueror's undo stack. But for now

Re: Review Request: Rebuild fake locale as soon as possible

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101509/#review3700 --- Ship it! Looks good. - David On June 5, 2011, 12:23 a.m.,

Re: Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101277/#review3701 --- Ship it! Go for it, my friend. - David On May 2, 2011, 9:34

Re: Review Request: KMainWindow::parseGeometry() fails to position with positive coordinates

2011-06-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101492/#review3702 --- Looks good overall, but I think I found a bug with negative

Re: Review Request: Fix keypress stealing issue

2011-06-05 Thread David Faure
/ --- (Updated June 2, 2011, 8:38 a.m.) Review request for kdelibs and David Faure. Summary --- Shortcut context was not set correctly for the new Find Text as You Type action, which can result in the khtmlpart stealing '/'-keypresses from other widgets

Re: Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

2011-06-08 Thread David Faure
On June 6, 2011, 2:10 a.m., David Faure wrote: Looks good. Do you want me to commit this for you, or do you want to get a kde contributor account instead, to be able to commit this directly as well as future patches? :) Lukas Sommer wrote: It would be great to have a kde

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread David Faure
/ --- (Updated June 21, 2011, 11:26 a.m.) Review request for kdelibs and David Faure. Summary --- Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work. This addresses bug 257841

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread David Faure
: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated June 21, 2011, 4:20 p.m.) Review request for kdelibs and David

Re: Review Request: Transparent QListQUrl handling in KUrl::List

2011-06-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101702/#review4073 --- Ship it! OK. - David On June 20, 2011, 11:58 a.m.,

Re: Adding a dependency on libkonq to Gwenview

2011-06-22 Thread David Faure
need exactly? Maybe we can move the functionality to KIO, restoring a file from the trash sounds like a small piece of code. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: kdewebkit compilation fails for Mobile profile in trunk

2011-06-22 Thread David Faure
it), so kdemacros.h was not included, and KDE_NO_DEPRECATED was not set, leading to signals only in the moc file and not in the header file, at compile time. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Command line options stripped for KUniqueApplication

2011-06-22 Thread David Faure
to the code, but it's on a laptop in the south west of France right now :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).

Re: Review Request: Preffer new hunspell library over the old one in the finder

2011-06-22 Thread David Faure
On June 22, 2011, 8:18 p.m., David Faure wrote: Hmm, I can't see any mention of order-related preference in the help for find_library (`cmake --help-command find_library`). I suppose the right thing to do would be to ask the cmake developers to add this in the documentation, so

Re: Review Request: Transparent QListQUrl handling in KUrl::List

2011-06-23 Thread David Faure
On June 22, 2011, 7 p.m., David Faure wrote: OK. Sebastian Trueg wrote: Just to be clear: does this mean: push it now or push it after the release of 4.7? Hmm, true, I think things are pretty frozen right now. In theory, conversion operators is something I'm wary of, they can make

Re: Review Request: Fix for Image URLs opened from external applications are loaded as text

2011-06-30 Thread David Faure
/ --- (Updated June 26, 2011, 8:55 p.m.) Review request for kdelibs and David Faure. Summary --- The attached patch fixes the aforementioned bug report using the last suggestions made by David at http://lists.kde.org/?l=kfm-develm

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102238/#review5499 --- - David On Aug. 7, 2011, 4:07 a.m., Dawit Alemayehu wrote:

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-08 Thread David Faure
On Aug. 8, 2011, 1:53 p.m., David Faure wrote: (Sorry, flaky wifi lost the comment) I am very much against a nested event loop (QEventLoop::exec), it's a well-known fact nowadays that it creates unexpected re-entrancy and crashes. And since I just fixed the crash (missing wait() after

Re: Review Request: Prevent KMessageBox instances with a parent from being application modal

2011-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102246/#review5532 --- API looks ok. Implementation could prevent duplication by

Re: Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

2011-08-09 Thread