=
KServiceTypeTrader::self()-query(KDEDModule);
for(KService::List::ConstIterator it = kdedModules.begin(); it !=
kdedModules.end(); ++it)
{
KService::Ptr service = *it;
...
}
and yes, it skips Hidden=true files, since they are not in ksycoca at all.
--
David Faure
...
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4927/#review8753
---
On 2010-07-03 22:44:14, David Faure wrote:
I was initially against this kind of thing (too many problems with
intelligent destructors), this is why it hasn't been done before.
But after long consideration, I think this one is safe and, as you say,
somewhat expected by users
for this use case.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
the
attached patch. Unittest passes, of course.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
Index: dialogs/kdialog_p.h
===
--- dialogs/kdialog_p.h
On Thursday 09 December 2010, Aurélien Gâteau wrote:
On 09/12/2010 17:52, David Faure wrote:
On Tuesday 07 December 2010, Jaime wrote:
Hi,
I've run the kdelibs with the environment variable
QT_FATAL_WARNINGS=1,
and the number of failed tests has grown in a noticeable way
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6106/#review9226
---
Ship it!
A new unittest for a string handling method == great!
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6111/#review9347
---
Ship it!
Looks good now. lxr finds no other usage of the
)
Review request for kdelibs and David Faure.
Summary
---
Using the Defaults button in the desktoppaths kcm resets all folders to the
default values,
but is currently using the untranslated strings in branch and trunk.
Adding some i18n() calls resets the values to the translated
On Tuesday 28 September 2010, David Faure wrote:
In fact, I don't understand why they are in extragear. I mean, yes, the
initial idea for kdeaddons was so that they can be optionally installed,
but nowadays it means and they have a separate release cycle which
makes no sense whatsoever
.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
see how that would solve the KIO::move issue.
IMHO not allowing the renaming of files in a search result listing is
not an option since.
... since you can't finish sentences? :-P
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6354/#review9656
---
Ship it!
Good stuff.
At some point we should extract the switch
is very welcome.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
is broken and should
be fixed instead. I never got why we needed to run a subprocess in the
first place.
Good point, I'll post to xdg with a patch for creating a version file.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http
On Thursday 06 January 2011, Edgar Fuß wrote:
Would it be better to have some configuration option in a phononserverrc
not to complain about vanishing sound cards?
Yes I think this would be a useful configuration option.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored
On Tuesday 01 February 2011, Aaron J. Seigo wrote:
* 3rd party examples we can learn from:
http://public.kitware.com/Wiki/Git/Workflow/Topic
Qt?
http://wiki.videolan.org/Git
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl
, using an intermediate storage for what
the underlying get job is emitting.
But the only benefit would be being able to upload remote data, not sure if
we have a use case for that.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http
no reason not to forwardport immediately
[unlike the other way around, as discussed elsewhere in this thread].
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100516/#review1305
---
Ship it!
Looks good, but...
kio/kio/job.cpp
On Thursday 10 February 2011, Thiago Macieira wrote:
Em quinta-feira, 10 de fevereiro de 2011, às 12:45:58, David Faure escreveu:
I certainly don't expect it to continue
running in the background until certain services finish running, in the
background.
I can tell you, users
. It only has a
tray icon. Probably the famous exception to the rule? Do I need to change
anything in my app for this?
A tray icon *is* a GUI.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
then :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
On Monday 14 February 2011, David Faure wrote:
On Monday 14 February 2011, Thiago Macieira wrote:
What I don't want is an app that has no way for me to quit it, other than
opening a shell and killing it (or the amazing ksysguard).
My pet peeve with this issue is kmail 1.x that used
/
---
(Updated Feb. 5, 2011, 7:53 p.m.)
Review request for kdelibs and David Faure.
Summary
---
Currently KIO::PreviewJob respects the settings MaximumSize and
MaximumRemoteSize from the KConfigGroup PreviewSettings, but completely
ignores the Plugins settings. Because
On Feb. 18, 2011, 2:03 p.m., Sergio Luis Martins wrote:
Johannes Sixt wrote:
Why a new variable? Wouldn't it be possible to give the value of
KDE_COLOR_DEBUG a meaning? For example:
KDE_COLOR_DEBUG=always
could enable the new behavior, any other value (except empty) the old
official and standarized.
Almost. Before, I was adding new API in the stable branch when necessary for a
bugfix, without thinking much about it. Now I'll make a review request, for
good measure :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl
patches are good ;)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
On Wednesday 16 March 2011, Thiago Macieira wrote:
Suggestion:
path.left(path.length() - sizeof ;type=);
Unreadable.
sizeof(;type=) == strlen(;type=X)
A hidden off-by-one, how nice to have in our code ;)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100873/#review2040
---
Hmm, this whole block is inside if (failedAuth0), so this means
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101037/#review2447
---
Ship it!
Thanks for working on this, iirc this is needed by
.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
On April 18, 2011, 12:43 p.m., David Faure wrote:
kioslave/ftp/ftp.cpp, line 1766
http://git.reviewboard.kde.org/r/101149/diff/1/?file=14721#file14721line1766
Maybe this should be while we haven't read 1024 bytes, but of course
the file could be smaller than that so it would have
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101149/
---
(Updated April 18, 2011, 7:39 p.m.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch changes the ftpGet function
.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch changes the ftpGet function such that it emits the
mime-type of the content it is about to read, before starting to read it.
That way kio_ftp will work correctly if and when it is put on hold to be
reused
On April 18, 2011, 8:31 p.m., David Faure wrote:
kioslave/ftp/ftp.cpp, line 2405
http://git.reviewboard.kde.org/r/101149/diff/3/?file=14732#file14732line2405
If m_size is UnknownSize and the file is less than 1024 bytes, this
code is going to hit the timeout, waiting for data
18, 2011, 10:29 p.m.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch changes the ftpGet function such that it emits the
mime-type of the content it is about to read, before starting to read it.
That way kio_ftp will work correctly if and when
and toolbars, so adding
editing functionality will just make it look like an even bigger beast that
only 1% of the existing konqueror users will feel comfortable using.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101075/#review2764
---
Ship it!
I like it.
To answer I am not sure why
/
---
(Updated April 21, 2011, 2:50 a.m.)
Review request for kdelibs and David Faure.
Summary
---
This patch completely removes the automatic restoration of the user name from
the original url to the redirection url at the job level. Even though I tried
to lookup why
for kdelibs-4.0 and then noticing Qt got undo classes...
It would be extremely ironic (not to say frustrating) to now see another set
of undo classes in kdelibs in their place!
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http
:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101174/
---
(Updated April 24, 2011, 12:10 a.m.)
Review request for kdelibs and David Faure.
Summary
---
The is the first part
/
---
(Updated April 27, 2011, 7:28 a.m.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch addresses most of the FTP login related problems and is a
replacement for the previous review request
https
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101244/#review2939
---
kio/kio/scheduler.cpp
menu...
If it doesn't register to dbus at all, remove these lines completely.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
.
IMHO that options is about re-opening old windows, not about ignoring any
saved settings.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101244/#review2973
---
Ship it!
Looks good to me, apart from two small things.
. The compiler will tell you ;) ).
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
the use of this, unless it's really needed.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
:
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
---
(Updated May 15, 2011, 7:59 p.m.)
Review request for kdelibs and David Faure.
Summary
---
Attempted patch to make konqueror
, 2011, 6:55 a.m.)
Review request for KDE Base Apps and David Faure.
Summary
---
konq-plugins/domtreeviewer builds without there functions.
May be these functions were left for future integration of domtreeviewer
undoable commands' into Konqueror's undo stack. But for now
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101509/#review3700
---
Ship it!
Looks good.
- David
On June 5, 2011, 12:23 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101277/#review3701
---
Ship it!
Go for it, my friend.
- David
On May 2, 2011, 9:34
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101492/#review3702
---
Looks good overall, but I think I found a bug with negative
/
---
(Updated June 2, 2011, 8:38 a.m.)
Review request for kdelibs and David Faure.
Summary
---
Shortcut context was not set correctly for the new Find Text as You Type
action, which can result in the khtmlpart stealing '/'-keypresses from
other widgets
On June 6, 2011, 2:10 a.m., David Faure wrote:
Looks good. Do you want me to commit this for you, or do you want to get a
kde contributor account instead, to be able to commit this directly as well
as future patches? :)
Lukas Sommer wrote:
It would be great to have a kde
/
---
(Updated June 21, 2011, 11:26 a.m.)
Review request for kdelibs and David Faure.
Summary
---
Attempted patch to make konqueror reset the URL when escape is pressed in the
address bar. For reasons beyond my grokledge does not always seem to work.
This addresses bug 257841
:
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
---
(Updated June 21, 2011, 4:20 p.m.)
Review request for kdelibs and David
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101702/#review4073
---
Ship it!
OK.
- David
On June 20, 2011, 11:58 a.m.,
need exactly? Maybe we can move the functionality to
KIO, restoring a file from the trash sounds like a small piece of code.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
it), so kdemacros.h
was not included, and KDE_NO_DEPRECATED was not set, leading to signals
only in the moc file and not in the header file, at compile time.
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
to the code, but it's on a laptop in the south west of
France right now :-)
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
On June 22, 2011, 8:18 p.m., David Faure wrote:
Hmm, I can't see any mention of order-related preference in the help for
find_library (`cmake --help-command find_library`). I suppose the right
thing to do would be to ask the cmake developers to add this in the
documentation, so
On June 22, 2011, 7 p.m., David Faure wrote:
OK.
Sebastian Trueg wrote:
Just to be clear: does this mean: push it now or push it after the
release of 4.7?
Hmm, true, I think things are pretty frozen right now. In theory, conversion
operators is something I'm wary of, they can make
/
---
(Updated June 26, 2011, 8:55 p.m.)
Review request for kdelibs and David Faure.
Summary
---
The attached patch fixes the aforementioned bug report using the last
suggestions made by David at
http://lists.kde.org/?l=kfm-develm
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102238/#review5499
---
- David
On Aug. 7, 2011, 4:07 a.m., Dawit Alemayehu wrote:
On Aug. 8, 2011, 1:53 p.m., David Faure wrote:
(Sorry, flaky wifi lost the comment)
I am very much against a nested event loop (QEventLoop::exec), it's a
well-known fact nowadays that it creates unexpected re-entrancy and crashes.
And since I just fixed the crash (missing wait() after
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/#review5532
---
API looks ok. Implementation could prevent duplication by