Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
Hi, kcm-grub2 has been in kdereview for months. It would be great if it could be moved back or forth. I am planning a new release soon, I wouldn't like to abuse kdereview. Regards, Konstantinos

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: Some of your QtQuick imports are 1.0 and some others 1.1, i guess some consistency there would be nice You need to extract the i18n messages from the qml files And having the keyboard not working seems like a huge regression

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: Very nice work, one of the things where QML makes sense. Are there any i18n string regressions? If possible, I would see it in 4.8 (maybe not 4.8.0, but backport sometimes later, after it has received testing in master), but that

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 5:03 p.m.) Review request for KDE Base Apps and

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Christoph Feck
On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: Very nice work, one of the things where QML makes sense. Are there any i18n string regressions? If possible, I would see it in 4.8 (maybe not 4.8.0, but backport sometimes later, after it has received testing in master), but that

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

2012-01-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9543 --- This review has been submitted with commit

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Albert Astals Cid
El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: My little kded daemon that listens to XF86XK_TouchpadToggle and enables disables the touchpad accordingly has been moved to kdereview. My plan is

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Albert Astals Cid
On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: Some of your QtQuick imports are 1.0 and some others 1.1, i guess some consistency there would be nice You need to extract the i18n messages from the qml files And having the keyboard not working seems like a huge regression

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
On Jan. 4, 2012, 4:58 p.m., Christoph Feck wrote: ksmserver/themes/default/main.qml, line 166 http://git.reviewboard.kde.org/r/103621/diff/1-2/?file=45373#file45373line166 Note that pointSize != pixelSize. With a high DPI display, a 10 pt font could be 30 pixels large, but if you

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: Very nice work, one of the things where QML makes sense. Are there any i18n string regressions? If possible, I would see it in 4.8 (maybe not 4.8.0, but backport sometimes later, after it has received testing in master), but that

Re: Review Request: kcm-grub2

2012-01-04 Thread Albert Astals Cid
El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va escriure: Hi, kcm-grub2 has been in kdereview for months. It would be great if it could be moved back or forth. I am planning a new release soon, I wouldn't like to abuse kdereview. If noone raised extra comments and

Re: Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va escriure: Hi, kcm-grub2 has been in kdereview for months. It would be great if it could be moved back or forth. I am planning a new release soon, I

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 6:41 p.m.) Review request for KDE Base Apps and

Re: Review Request: kcm-grub2

2012-01-04 Thread Albert Astals Cid
El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va escriure: On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va escriure: Hi, kcm-grub2 has been in kdereview for months. It

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Albert Astals Cid
On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: ksmserver/CMakeLists.txt, line 57 http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file45363line57 no variable for kdeclarative? Lamarque Vieira Souza wrote: There is one in shutdowndlg.cpp, in KSMShutdownDlg's

Re: Review Request: kcm-grub2

2012-01-04 Thread Konstantinos Smanis
On Wed, Jan 4, 2012 at 20:46, Albert Astals Cid aa...@kde.org wrote: El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va escriure: On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Thomas Lübking
Am 04.01.2012, 18:51 Uhr, schrieb Albert Astals Cid aa...@kde.org: I don't really see any point in doing that, nothing can be shared between them and the existing ktouchpadenabler so instead of one simple codebase (166 lines with 20 of headers) you end up adding more complexity to existing

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: ksmserver/CMakeLists.txt, line 57 http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file45363line57 no variable for kdeclarative? Lamarque Vieira Souza wrote: There is one in shutdowndlg.cpp, in KSMShutdownDlg's

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 7:19 p.m.) Review request for KDE Base Apps and

Re: Review Request: Port shutdown dialog to QML

2012-01-04 Thread Alexander Neundorf
On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: ksmserver/CMakeLists.txt, line 57 http://git.reviewboard.kde.org/r/103621/diff/1/?file=45363#file45363li ne57 no variable for kdeclarative? Lamarque Vieira

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

2012-01-04 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103593/#review9556 --- ksmserver/shutdown.cpp

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread David Faure
On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: My little kded daemon that listens to XF86XK_TouchpadToggle and enables disables the

libmm-qt and libnm-qt still in KDE Review

2012-01-04 Thread Ben Cooksley
Hi all, Just doing a little spring cleaning of KDE Review and I noticed that libmm-qt and libnm-qt are still there. What was the final decision on where they are going to be moved? Regards, Ben

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Albert Astals Cid
El Dimecres, 4 de gener de 2012, a les 20:15:27, Thomas Lübking va escriure: Am 04.01.2012, 18:51 Uhr, schrieb Albert Astals Cid aa...@kde.org: I don't really see any point in doing that, nothing can be shared between them and the existing ktouchpadenabler so instead of one simple codebase

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Albert Astals Cid
El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: My little

Re: Review Request: Fix KConfigIniBackend::isWritable() when the parent directory doesn't exist

2012-01-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103577/#review9557 --- This review has been submitted with commit

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread David Faure
On Thursday 05 January 2012 00:17:33 Albert Astals Cid wrote: khotkeys is already a kded module, so there won't be no more processes waking up now than before by adding a new kded module. Ah, OK. kglobalaccel seems quite suitable indeed, no? It would, if Qt had a key for

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Lamarque V. Souza
Em Wednesday 04 January 2012, Albert Astals Cid escreveu: El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: On Wednesday

Re: libmm-qt and libnm-qt still in KDE Review

2012-01-04 Thread Lamarque V. Souza
Em Wednesday 04 January 2012, Ben Cooksley escreveu: Hi all, Just doing a little spring cleaning of KDE Review and I noticed that libmm-qt and libnm-qt are still there. What was the final decision on where they are going to be moved? Good question. Does anybody object to moving it

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Christoph Feck
On Thursday 05 January 2012 00:17:33 Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: kglobalaccel seems quite suitable indeed, no? It would, if Qt had a key for XF86XK_TouchpadToggle [...] Albert Bummer, you are right, didn't think of

Re: ktouchpadenabler moved to kdereview

2012-01-04 Thread Michael Jansen
On Thursday, January 05, 2012 12:17:33 AM Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: On

build.kde.org partially down

2012-01-04 Thread Torgny Nyblom
Hi, the host that is hosting our jenkins instance (build.kde.org) has stopped listening to IPv4 connections. As a result build.kde.org is down for most?) people. /Regards Torgny signature.asc Description: This is a digitally signed message part. Visit

Re: build.kde.org partially down

2012-01-04 Thread Torgny Nyblom
On Wednesday 04 January 2012 10.26.05 Torgny Nyblom wrote: Hi, the host that is hosting our jenkins instance (build.kde.org) has stopped listening to IPv4 connections. As a result build.kde.org is down for most?) people. Issue is fixed, turned out to be an issue in jenkins (it needed a

Re: build.kde.org partially down

2012-01-04 Thread Anne-Marie Mahfouf
Hi Torgny, What is build.kde.org exactly? In KDEEDU I only see Marble. What is Jenkins? What are people? Thanks in advance, Anne-Marie - Mail original - De: Torgny Nyblom nyb...@kde.org À: kde-devel@kde.org Envoyé: Mercredi 4 Janvier 2012 10:52:48 Objet: Re: build.kde.org partially

Re: build.kde.org partially down

2012-01-04 Thread Torgny Nyblom
On Wednesday 04 January 2012 11.06.44 Anne-Marie Mahfouf wrote: [...] What is build.kde.org exactly? In KDEEDU I only see Marble. What is Jenkins? build.kde.org is a Jenkins[1] server that builds and tests all commits that are pushed to the KDE git repos. That is those repos and branches that

Possible incomplete error message into kdelibs

2012-01-04 Thread Antoni Bella Pérez
Hi I compiled Calligra from source and .desktop file gives me this error message but is incomplete. See the error: The service '/usr/local/share/applications/kde4/words.desktop' provides no library or the Library key is missing in ## kdelibs/kdecore/util/kpluginloader.cpp: //

widget-taskbar bug : where to start

2012-01-04 Thread Amandeep Singh
Hi, I have succesfully built the kde-source in a directory kde-devel. How can i checkout the effect of changes i make to the code. I tried running a nested session using Xephyr, but i just get a blank window. I followed the steps given here :

Re: Possible incomplete error message into kdelibs

2012-01-04 Thread Albert Astals Cid
El Dimarts, 3 de gener de 2012, a les 15:10:23, Antoni Bella Pérez va escriure: Hi I compiled Calligra from source and .desktop file gives me this error message but is incomplete. It is not incomplete it has an extra in, i.e the message should be The service '%1' provides no library or