D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: broulik, #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: broulik, #frameworks, michaelh

Re: KUserFeedback UUID question

Thanks, Volker, for the answer. Will think more and try it in action provider<->server<->analytic app to see how it works to better understand. However still have some concerns: if I want to get such id from the server I need to write separate logic, API, etc. I see that we can create, subclass,

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. In D11244#223654 , @broulik wrote: > Did you actually properly test this, ie. without scaling? I can't see how this would be working: > 1.) You're missing `import QtQuick.Window 2.2` > 2.) There's no such property

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

davidedmundson added a comment. Thanks for finding bug report. +1 from me. You prompted me to look https://codereview.qt-project.org/222827 turns out it was a ridiculously easy fix. Has the advantage that it'll fix the QQC1 desktop theme labels; but I'm ok with an interim

D11238: filemetadatawidgettest: Enforce en_US locale

broulik added a comment. Many KIO tests also fail for me unless I explicitly set a locale. Can we have a more generic solution for that in e.g. ecm or so? REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11238 To: michaelh, elvisangelaccio, #baloo, #frameworks

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

broulik added a comment. Did you actually properly test this, ie. without scaling? I can't see how this would be working: 1.) You're missing `import QtQuick.Window 2.2` 2.) There's no such property `Window.devicePixelRatio`, it's `Screen.devicePixelRatio` (which is also in the `Window`

Re: KF5 Conversion problems

El diumenge, 11 de març de 2018, a les 14:40:56 CET, Robin Atwood va escriure: > On Sunday 11 March 2018, Michael Pyne wrote: > > > Yes, but the problem is the /usr/include/kdialog.h when it should be > > > finding /usr/include/KF5/KDELibs4Support/kdialog.h. I have > > > find_package(Qt5

Re: Is it possible to mock an external drive (for unit testing)?

El dissabte, 10 de març de 2018, a les 18:27:51 CET, Michael Heidelbach va escriure: > Hi! > > Is it? How? > > Do examples exist? You'll really need to be more specific, my initial answer would be, why would you care if something is a external drive? Cheers, Albert > > > Thanks in

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh added a comment. In D11238#223644 , @elvisangelaccio wrote: > What are these other repositories you are talking about? I did a quick check in kdirmodeltest.cpp from kio and that looks equally broken.

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio added a comment. In D11238#223569 , @michaelh wrote: > In D11238#223419 , @elvisangelaccio wrote: > > > Do you know why `qputenv()` doesn't work? > > > Not at all. I'm totally

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11238 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add prune option to remove stale file index entries

smithjd added a comment. I was going to expose this functionality on the DBus interface and integrate it into the check command, but the lack of external mount enumeration makes this a little risky at the moment. It's probably better to at least provide a simple global prune option. I

D11038: balooctl: Add prune option to remove stale file index entries

smithjd added a comment. I was going to expose this functionality on the DBus interface and integrate it into the check command, but the lack of external mount enumeration makes this a little risky at the moment. It's probably better to at least provide a simple global prune option. I

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29290. smithjd added a comment. - Commit the changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29280=29290 BRANCH master-purgeDb (branched from master) REVISION DETAIL

D11038: balooctl: Add prune option to remove stale file index entries

michaelh added a comment. [New Thread 0x7fffec72b700 (LWP 10669)] ASSERT failure in Transaction: "Permission denied", file /home/otto/kde/src/frameworks/baloo/src/engine/transaction.cpp, line 54 Thread 1 "balooctl" received signal SIGABRT, Aborted. 0x7524f9eb in

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29280. smithjd added a comment. - Open the transaction in read-write mode. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29184=29280 BRANCH master-purgeDb (branched from master) REVISION DETAIL

Re: Q_ASSERT(!FalseSecurity)

On Saturday, 10 March 2018 00:53:24 PDT Michael Heidelbach wrote: > Hi! > > Am I getting something wrong? Or is > > "Q_ASSERT(m_writeTrans); > > m_writeTrans->commit();" > > providing false security? This is not false security. It's not security, period. You use a Q_ASSERT when a

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh updated this revision to Diff 29276. michaelh added a comment. - Remove blank line REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11238?vs=29274=29276 BRANCH enforce-locale (branched from master) REVISION DETAIL

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh added a comment. In D11238#223419 , @elvisangelaccio wrote: > Do you know why `qputenv()` doesn't work? Not at all. I'm totally confused by this. `qputenv()` does work in other repos but not in this one. () REPOSITORY

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh updated this revision to Diff 29274. michaelh added a comment. - Remove unrelated stuff REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11238?vs=29256=29274 BRANCH enforce-locale (branched from master) REVISION DETAIL

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham updated this revision to Diff 29270. ngraham added a comment. Add the Qt bug we're working around into the coments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11244?vs=29268=29270 BRANCH master REVISION DETAIL

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. The closest I could find was https://bugreports.qt.io/browse/QTBUG-42606, which Kai filed for this exact issue, but only for 2x scale factors. It was closed as Cannot Reproduce. I have filed a new one: https://bugreports.qt.io/browse/QTBUG-67007 REPOSITORY R242

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham added a comment. The original workaround from QQC2-desktop-style (which I copied here) doesn't have that, sadly. I'm looking for it... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc:

D10378: Deprecate KFileItemList and introduce KFileItemListV2

dfaure added a comment. Yep, option 2 sounds like an incremental plan, which is good. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10378 To: markg, dfaure Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

davidedmundson added a comment. Working round a Qt bug always needs a Qt bug report referenced in a code comment. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11244 To: ngraham, #plasma, davidedmundson Cc: #frameworks, michaelh

D11244: Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is set

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY When `PLASMA_USE_QT_SCALING=1` is set, Plasma

D11238: filemetadatawidgettest: Enforce en_US locale

elvisangelaccio added a comment. Do you know why `qputenv()` doesn't work? INLINE COMMENTS > filemetadatawidgettest.cpp:41-44 > +#ifndef Q_OS_WIN > +setenv("LC_ALL", "en_US", 1); > +#endif > +QLocale::setDefault(QLocale("en_US")); Why both? `QLocale::setDefault()` seems to be enough

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 17:15:53 + Build duration: 27 min and counting JUnit Tests Name: (root)

D11238: filemetadatawidgettest: Enforce en_US locale

michaelh created this revision. michaelh added reviewers: elvisangelaccio, Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. REVISION SUMMARY Also let common property test fail TEST PLAN `$ make test` `$ LC_ALL=C make test` `$

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 17:15:53 + Build duration: 7 min 36 sec and counting JUnit Tests Name:

D8007: popplerextractor: don't try to guess the title if there isn't one.

michaelh added a comment. Restricted Application added a project: Baloo. @flameeyes, @mgallien: Any reasons why this is not landed? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, mgallien Cc: michaelh, anthonyfieroni,

Re: KF5 Conversion problems

On Sun, Mar 11, 2018 at 08:40:56PM +0700, Robin Atwood wrote: > On Sunday 11 March 2018, Michael Pyne wrote: > > > Yes, but the problem is the /usr/include/kdialog.h when it should be > > > finding /usr/include/KF5/KDELibs4Support/kdialog.h. I have > > > find_package(Qt5 Widgets... already. > > >

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > crashtest.cpp:138 > > - //start drkonqi directly so that drkonqi's output goes to the console > - KCrash::CrashFlags flags = KCrash::AlwaysDirectly; That reasoning does not seem to be true. The output can still be read when started

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 29249. croick added a comment. - remove superfluous include REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=29247=29249 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11235 AFFECTED FILES

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick edited the test plan for this revision. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick created this revision. croick added a reviewer: Frameworks. Restricted Application added a project: Frameworks. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow attaching of processes to a debugger, if - the right to attach to processes

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick created this revision. croick added reviewers: Plasma: Workspaces, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow

D11193: Sonnet : use current hunspell API

rjvbb updated this revision to Diff 29246. rjvbb added a comment. add missing context (patch unchanged) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11193?vs=29116=29246 REVISION DETAIL https://phabricator.kde.org/D11193 AFFECTED FILES src/plugins/hunspell/hunspelldict.cpp

D11193: Sonnet : use current hunspell API

rjvbb set the repository for this revision to R246 Sonnet. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks Cc: kde-frameworks-devel, michaelh

D11183: Sonnet: don't impose the default client

rjvbb added a reviewer: cullmann. rjvbb set the repository for this revision to R246 Sonnet. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann Cc: #frameworks, michaelh

D11183: Sonnet: don't impose the default client

rjvbb updated this revision to Diff 29244. rjvbb added a comment. Add missing context (patch unchanged) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11183?vs=29094=29244 REVISION DETAIL https://phabricator.kde.org/D11183 AFFECTED FILES src/core/loader.cpp To: rjvbb,

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.10/5/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 11 Mar 2018 14:10:29 + Build duration: 26 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 14:20:42 + Build duration: 16 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 SUSEQt5.9 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks threadweaver kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 14:26:30 + Build duration: 5 min 57 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 14:04:12 + Build duration: 27 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 14:21:37 + Build duration: 6 min 23 sec and counting JUnit

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 14:15:06 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 14:15:07 + Build duration: 4 min 33 sec and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 14:15:07 + Build duration: 3 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 14:12:17 + Build duration: 5 min 46 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 171 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/171/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 14:04:12 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 14:09:57 + Build duration: 4 min 40 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/30/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 14:09:57 + Build duration: 2 min 55 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/150/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 14:04:12 + Build duration: 8 min 52 sec and counting JUnit Tests Name:

Re: KF5 Conversion problems

On Sunday 11 March 2018, Michael Pyne wrote: > > Yes, but the problem is the /usr/include/kdialog.h when it should be > > finding /usr/include/KF5/KDELibs4Support/kdialog.h. I have > > find_package(Qt5 Widgets... already. > > Sounds like 2 problems I think. > > First you need to fix the

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/13/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 12:49:51 + Build duration: 4 min 26 sec and counting JUnit

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 12:49:51 + Build duration: 2 min 30 sec and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 12:49:51 + Build duration: 1 min 6 sec and counting JUnit

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.10/6/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 11 Mar 2018 12:33:56 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/46/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 12:39:06 + Build duration: 7 min 17 sec and counting JUnit

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/63/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 12:39:06 + Build duration: 4 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 12:39:06 + Build duration: 4 min 32 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 25 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 12:37:51 + Build duration: 3 min 56 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 12:37:51 + Build duration: 2 min 51 sec and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 15 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 12:37:51 + Build duration: 2 min 22 sec and counting JUnit Tests

D11038: balooctl: Add prune option to remove stale file index entries

michaelh added a comment. ASSERT: "m_writeTrans" in file /home/otto/kde/src/frameworks/baloo/src/engine/transaction.cpp, line 233 Thread 1 "balooctl" received signal SIGABRT, Aborted. 0x7524f9eb in raise () from /lib64/libc.so.6 REPOSITORY R293 Baloo REVISION DETAIL

D11226: autotests: Restructure

This revision was automatically updated to reflect the committed changes. Closed by commit R824:b21a2ceeef83: autotests: Restructure (authored by michaelh). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11226?vs=29219=29222 REVISION DETAIL

D11226: autotests: Restructure

elvisangelaccio accepted this revision as: elvisangelaccio. elvisangelaccio added a comment. This revision is now accepted and ready to land. In D11226#223088 , @michaelh wrote: > In D11226#223085 ,

D11226: autotests: Restructure

michaelh added a comment. In D11226#223085 , @elvisangelaccio wrote: > Doesn't build here: > > ../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found > I wonder why it compiled here? REPOSITORY

D11226: autotests: Restructure

michaelh updated this revision to Diff 29219. michaelh added a comment. - autotests: Remove obsolete includes REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11226?vs=29215=29219 BRANCH tests (branched from master) REVISION DETAIL

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 11:34:21 + Build duration: 6 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 11 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 11:34:21 + Build duration: 5 min 2 sec and counting JUnit Tests Name:

D11226: autotests: Restructure

elvisangelaccio added a comment. Doesn't build here: ../autotests/filemetadatawidgettest.cpp:22:10: fatal error: 'config.h' file not found REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11226 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc:

D11226: autotests: Restructure

michaelh created this revision. michaelh added reviewers: elvisangelaccio, Baloo, Frameworks. Restricted Application added a project: Baloo. michaelh requested review of this revision. REVISION SUMMARY Move sample files to own folder Use QFINDTESTDATA for extractortest TEST PLAN make test

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. In D9973#223039 , @michaelh wrote: > In D9973#223017 , @elvisangelaccio wrote: > > > Thanks! :) > > > Yeah, same to you: Thanks! I'm learning a lot. > Wrt

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 09:41:05 + Build duration: 9 min 5 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 23 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 09:41:05 + Build duration: 6 min 34 sec and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 31 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 09:41:05 + Build duration: 2 min 40 sec and counting JUnit

D9973: ktooltipwidget: Fix tooltip positioning

This revision was automatically updated to reflect the committed changes. Closed by commit R236:f94c55fb190f: ktooltipwidget: Fix tooltip positioning (authored by michaelh). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=29205=29213 REVISION

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added a comment. In D9973#223017 , @elvisangelaccio wrote: > Thanks! :) Yeah, same to you: Thanks! I'm learning a lot. Wrt tooltips offscreen display: As I cannot use baloo-widgets here, I'm trying to mock a

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 170 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/170/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 09:17:41 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 09:10:45 + Build duration: 9 min 45 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 09:10:44 + Build duration: 3 min 29 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 169 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/169/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 08:51:29 + Build duration: 21 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/149/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 08:51:29 + Build duration: 17 min and counting JUnit Tests Name:

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio removed reviewers: Frameworks, Dolphin. Restricted Application added a subscriber: Frameworks. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, ngraham, #dolphin Cc: #frameworks, dfaure, cfeck, michaelh

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks! :) REPOSITORY R236 KWidgetsAddons BRANCH tooltip_and_test (branched from master) REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 08:51:29 + Build duration: 9 min 27 sec and counting JUnit Tests Name: (root)

D10621: Highlighting Indexer: list of suggestions

vkrause added a comment. Very nice idea! RegExp rules are the by far biggest cost factor, so every single one we can get rid of is good :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: vkrause,

D10312: FileUndoManager: don't delete non-existing local files

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f6a2bb0b6836: FileUndoManager: dont delete non-existing local files (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=29183=29210

Re: KUserFeedback UUID question

On Friday, 9 March 2018 13:31:18 CET Aleksey Kontsevich wrote: > Hi Volker, > > Have some questions. I've read Telemetry discussion in kde-community mailing > list, however some KUserFeedback logic is not quite clear: > https://www.mail-archive.com/kde-community@kde.org/msg03898.html > > You

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 29205. michaelh added a comment. - Reinsert white space REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=29204=29205 BRANCH tooltip_and_test (branched from master) REVISION DETAIL

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 29204. michaelh added a comment. - Apply suggested changes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=28731=29204 BRANCH tooltip_and_test (branched from master) REVISION DETAIL