D16165: Don't crash on invalid exiv2 data

astippich added a comment. I guess bugs 352856 353848 361259 will also be fixed by this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun,

D16163: refactor taglibextractor to functions specific for metadata type

astippich updated this revision to Diff 43500. astippich added a comment. - use forward declaration REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16163?vs=43486=43500 BRANCH refactor_taglib REVISION DETAIL https://phabricator.kde.org/D16163

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. In D16163#342057 , @mgallien wrote: > In D16163#342046 , @astippich wrote: > > > To be on the safe side here: I am allowed to modify private member functions regarding

D16135: refactor tests for taglibextractor

astippich updated this revision to Diff 43490. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43409=43490 BRANCH refactor_tests REVISION DETAIL https://phabricator.kde.org/D16135 AFFECTED FILES

D16162: harmonize test data for vorbis comment tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aab09a628ae: harmonize test data for vorbis comment tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16162?vs=43485=43489

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16163 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D16163: refactor taglibextractor to functions specific for metadata type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Refactor the specific extraction funtions in taglibextractor so

D16135: refactor tests for taglibextractor

astippich added a comment. In D16135#341549 , @bruns wrote: > Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring? see D16162

D16162: harmonize test data for vorbis comment tags

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY harmonize the test data for all files with vorbis comments so that

D16135: refactor tests for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY refactors all tests so that they can be reused

D16112: add wma files/asf tags as supported mimetype and add test data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d7c6fa57d243: add wma files/asf tags as supported mimetype and add test data (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16112?vs=43332=43371#toc REPOSITORY R286

D16111: use own extractor for testing the taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d472f470bacb: use own extractor for testing the taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43339=43370

D16111: use own extractor for testing the taglibwriter

astippich marked 2 inline comments as done. astippich added a comment. Sorry, that was really stupid REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16111: use own extractor for testing the taglibwriter

astippich updated this revision to Diff 43339. astippich added a comment. - fix stupid mistakes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43330=43339 BRANCH use_extractor_for_writertest REVISION DETAIL

D16112: add wma files/asf tags as supported mimetype and add test data

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add preliminary support for wma files/asf tags

D16111: use own extractor for testing the taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Instead of querying the tags directly through

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:196b1289152c: add a string suffix to test data and use for unicode testing of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:75 > can you change this to `data[2]` ... > Facepalm myself ... I should have spotted this myself :) REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16059: remove compile time check for taglib version

This revision was automatically updated to reflect the committed changes. Closed by commit R286:d6d86adbd773: remove compile time check for taglib version (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16059?vs=43191=43326

D15833: extend test coverage to all supported mimetypes for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:52920c0003d6: move testing of common tags of test files to a new data-driven test for… (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_taglib_extractor_tests REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16059: remove compile time check for taglib version

astippich created this revision. astippich added reviewers: svuorela, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the check for the taglib version, which is

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. Sorry, I should have written this more clearly, but you got it right. It's for the new formats. For the most common tags, taglib directly provides the implementation for all its supported tag formats and one can call e.g. tag->artist(). For the others, one has to

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43038. astippich added a comment. - fixup spaces REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43034=43038 BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 AFFECTED FILES

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#338296 , @safaalfulaij wrote: > Thanks! > I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43034. astippich added a comment. - add seperate, translatable string for IEC binary prefixes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42563=43034 BRANCH translate_units REVISION DETAIL

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 43031. astippich added a comment. - update aiff and wav test files so that they are smaller REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42551=43031 BRANCH taglib_extractor_additional_tests

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? Forgot to mention it, I added this information to the summary. In D15833#333944

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. In D15825#334087 , @bruns wrote: > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? These are the tags directly supported by taglib (e.g.

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich updated this revision to Diff 43028. astippich added a comment. - explicitly test for supported mimetype REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15825?vs=42529=43028 BRANCH refactor_taglib_extractor_tests REVISION DETAIL

D15829: make units and prefixes of formatValue translatable

astippich added inline comments. INLINE COMMENTS > safaalfulaij wrote in kformatprivate.cpp:168 > Well, I searched other languages and no one seems to do as Arabic does. We do > not abbreviate in this case and just write the whole "Mebi.Byte" ("Byte" is > always written, "M.Byte" > "MB"). >

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 42563. astippich added a comment. - change description for prefixes and make the IEC prefix translatable REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42542=42563 BRANCH translate_units REVISION

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 42551. astippich added a comment. - modify permissions of binary files REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42549=42551 BRANCH taglib_extractor_additional_tests REVISION DETAIL

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a dependent revision: D15833: extend test coverage to all supported mimetypes for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a dependency: D15825: move testing of common tags of test files to a new data-driven test for taglibextractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo,

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add new test files such that all mime types

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#333799 , @safaalfulaij wrote: > Since the joining between number and format is translatable, that's great. I meant that if it is kept untranslatable, problems regarding RTL will happen. Sorry, I

D15829: make units and prefixes of formatValue translatable

astippich added a comment. @bruns please have a look at the changes. In particular, regarding "µ" and windows support. I don't know if this will be able to compile on windows, or how to fix it for tr() function. @safaalfulaij please verify if this fixes the RTL issue for you REPOSITORY

D15829: make units and prefixes of formatValue translatable

astippich created this revision. astippich added reviewers: bruns, safaalfulaij. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY give the possibility to translate the prefix und unit strings

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich marked 5 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42541. astippich added a comment. - fix after rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42525=42541 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich created this revision. astippich added reviewers: bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as a preparation for more test data, move all tags that

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42525. astippich added a comment. - use suggested test pattern REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42270=42525 BRANCH taglib_write_unicode REVISION DETAIL

D15715: remove own implementation of QString to TString conversion for taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:c413d83851c5: remove own implementation of QString to TString conversion for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15704: increase test coverage of taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:ae3c38293421: increase test coverage of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15704?vs=42519=42521#toc REPOSITORY R286 KFileMetaData CHANGES

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:73 > If safeguarding against bad editors is really necessary, better do it here. > Alternatively, you can use C++11 unicode string literals, e.g. > `QString(u"€")` > If you save that one as e.g. latin1 and try

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich added a comment. In D15715#333567 , @bruns wrote: > Thx! Can you also add some line breaks at ~80 chars? ;-) sure :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich,

D15704: increase test coverage of taglibwriter

astippich updated this revision to Diff 42519. astippich added a comment. - remove untested mime types and sort REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15704?vs=42196=42519 BRANCH taglib_write_mimetypes REVISION DETAIL

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15220: implement more basic tags for taglibwriter

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=41856=42518

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > smithjd wrote in taglibwritertest.cpp:60 > Is wrapping in a QString necessary? It does not compile otherwise. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd,

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42270. astippich added a comment. - actually use temporary string variable for unicode REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42264=42270 BRANCH taglib_write_unicode REVISION DETAIL

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich updated this revision to Diff 42264. astippich added a comment. - implement feedback REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42197=42264 BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714

D15704: increase test coverage of taglibwriter

astippich added inline comments. INLINE COMMENTS > svuorela wrote in taglibwriter.cpp:22 > Unrelated. but consider making this static ? Never really though about that, but should be static, yes. None of the writers and extractors I looked at currently do this, so if I find time I will do that

D15220: implement more basic tags for taglibwriter

astippich added a dependent revision: D15715: remove own implementation of QString to TString conversion for taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15220 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich added a dependency: D15220: implement more basic tags for taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich added a comment. since I'm still unsure about those things: the q2t function was not declared static, but was never exported. It is still safe to remove, right? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns,

D15715: remove own implementation of QString to TString conversion for taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY similar to D15614

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added inline comments. INLINE COMMENTS > svuorela wrote in taglibwritertest.cpp:66 > yeah. given you write and read it, if somehow it gets encoded e.g. as > iso-8859-15 rather than utf8, the euro sign would be encoded as 0xa4 rather > than 0x20ac. > > As you write and read it in the

D15614: remove usage of own TString to QString conversion function

This revision was automatically updated to reflect the committed changes. Closed by commit R286:4c760d4588f3: remove usage of own TString to QString conversion function (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15615: bump required taglib version to 1.11.1

This revision was automatically updated to reflect the committed changes. Closed by commit R286:26dcd784b45a: bump required taglib version to 1.11.1 (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15615?vs=41969=42199 REVISION

D15615: bump required taglib version to 1.11.1

astippich retitled this revision from "bump required taglib version" to "bump required taglib version to 1.11.1". REPOSITORY R286 KFileMetaData BRANCH bumb_taglib_version REVISION DETAIL https://phabricator.kde.org/D15615 To: astippich, mgallien, svuorela Cc: kde-frameworks-devel,

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY append a unicode character to all test string such that

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

astippich added a dependency: D15704: increase test coverage of taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15704: increase test coverage of taglibwriter

astippich added a dependent revision: D15714: add a string suffix to test data and use for unicode testing of taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15704 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D15704: increase test coverage of taglibwriter

astippich updated this revision to Diff 42196. astippich added a comment. - don't change test strings for now REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15704?vs=42174=42196 BRANCH taglib_write_mimetypes REVISION DETAIL

D15220: implement more basic tags for taglibwriter

astippich added a dependent revision: D15704: increase test coverage of taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15220 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D15704: increase test coverage of taglibwriter

astippich added a dependency: D15220: implement more basic tags for taglibwriter. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15704 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15704: increase test coverage of taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY increase the test coverage by testing more mimetypes, and

D15615: bump required taglib version

astippich created this revision. astippich added a reviewer: mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY some of the functionality added in D12320

D15614: remove usage of own TString to QString conversion function

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15614: remove usage of own TString to QString conversion function

astippich added a comment. The removal of the convertWCharsToQString function is safe, right? It was never exported REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15614: remove usage of own TString to QString conversion function

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as pointed out in D13700

D13700: implement reading of the replaygain tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:22c0757e6e51: implement reading of the replaygain tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=41429=41948 REVISION

D15220: implement more basic tags for taglibwriter

astippich added a comment. In D15220#325580 , @bruns wrote: > Can you add some Unicode exercising tests? I plan to extend the tests in a later patch, if you don't mind, I would prefer to add this there. INLINE COMMENTS > bruns wrote in

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 41856. astippich added a comment. - check for values greater than zero for tracknumber and year REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40861=41856 BRANCH taglib_write REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich added a comment. @bruns any further comments/objections? REPOSITORY R286 KFileMetaData BRANCH replaygain REVISION DETAIL https://phabricator.kde.org/D13700 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:943 > You should check if the value can be converted to double, and probably also > if it is in a sane range. I added the checks for a successful conversion, but in my opinion kfilemetadata should not judge

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 41429. astippich added a comment. - add checks for conversion to double REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=41119=41429 BRANCH replaygain REVISION DETAIL

D12950: add test which checks the property types

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:50 > This is definitely broken: > http://taglib.org/api/classTagLib_1_1String.html#a0ef8ad270d710863e0bb1c1b18cdb95d > > `const wchar_t* TagLib::String::toCWString() const` > > > Returns a standard

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 41119. astippich marked 2 inline comments as done. astippich added a comment. - remove space and adjust comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40851=41119 BRANCH replaygain REVISION

D15220: implement more basic tags for taglibwriter

astippich updated this revision to Diff 40861. astippich added a comment. - use different test data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=40858=40861 BRANCH taglib_write REVISION DETAIL https://phabricator.kde.org/D15220

D15220: implement more basic tags for taglibwriter

astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY implement all basic tags directly provided by taglib for

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:255 > you can use TStringToQString > `data.replayGainTrackGain = > TStringToQString(userTextFrame->fieldList().back());` toCString() was actually completely unnecessary. I removed it since

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40851. astippich marked 4 inline comments as done. astippich added a comment. - improve readability and add check REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13700?vs=40824=40851 BRANCH replaygain

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:944 > Could you check if it is not faster to use QLatin1String here ? At least if my interpretations of callgrind are correct, it's exactly the same. REPOSITORY R286 KFileMetaData REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40824. astippich marked 5 inline comments as done. astippich added a comment. - add documentation, remove unrelated changes and debug info - get rid of string comparisons for id3v2 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13906: add missing include

This revision was automatically updated to reflect the committed changes. Closed by commit R286:9ba0d27ef263: add missing include (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13906?vs=37210=40405 REVISION DETAIL

D13584: KFormat: Replace byte specific implementation with generic one

astippich added a comment. I've been running with it for a while and found no issues, but only giving +1 this time because of the fallout from the other patch (which I didn't catch, so others should have a look) REPOSITORY R244 KCoreAddons REVISION DETAIL

D14121: KFormat: Add unit tests for mili/micro SI prefixes

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. test itself is fine, but I spotted a typo. INLINE COMMENTS > kformattest.cpp:118 > + > +QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1, > KFormat::UnitPrefix::Mili,

D12950: add test which checks the property types

astippich added a comment. I would like to work on D11365 again where it was suggested to add the test first. As you can see from the tests, the types defined for each property in KFileMetaData do not match the output for the taglibextractor. The types

D13885: taglibextractor: Restore extracting audio props without tags existing

This revision was automatically updated to reflect the committed changes. Closed by commit R286:41c075129d46: taglibextractor: Restore extracting audio props without tags existing (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13906: add missing include

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the include of qmap to the

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich edited the summary of this revision. astippich edited the test plan for this revision. REPOSITORY R286 KFileMetaData BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo,

<    3   4   5   6   7   8   9   10   >