D20078: RFC fix race on kcrash auto-restarts

sitter added subscribers: broulik, davidedmundson. sitter added a comment. Still fairly messy and very verbose but working. @broulik @davidedmundson I'd love some thoughts on this. Also, @davidedmundson since you suggested the registration queuing. I do wonder if that isn't actually

D20078: RFC fix race on kcrash auto-restarts

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY When kcrash is set to auto restart Unique service processes we have potential for a race. Because KCrash will want to

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

sitter accepted this revision. sitter added a comment. Ha, this is also much nicer looking. I love it! :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19439 To: marten, #plasma, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew,

D19779: point readme to the wiki page

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:998982a47cbc: point readme to the wiki page (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST

D19779: point readme to the wiki page

sitter added a comment. I am taking silence as indifference. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19779 To: sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19786: Fix WebDAV directory renaming if KeepAlive is off

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c6b5750b9527: Fix WebDAV directory renaming if KeepAlive is off (authored by hoffmannrobert, committed by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Fair enough. LGTM :) Do you need sponsoring or do you have commit access? REPOSITORY R241 KIO BRANCH fix_webdav_rename_directory REVISION DETAIL

D19786: Fix WebDAV directory renaming if KeepAlive is off

sitter added a comment. setting server to keepalive=false? what is this? the 90's? :O wouldn't it be simpler to `finishDav` and recurse `rename` with the redirected url? the code inside the conditional block is basically a code copy of the code above, so why not just throw away the

D19779: point readme to the wiki page

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the wiki page says the readme is duplicated into the wiki. so, what we end up with is either - they end up out

D19767: Fix malloc/delete mismatch

sitter added inline comments. INLINE COMMENTS > aacid wrote in kio_sftp.cpp:446 > Use ssh_string_free_char ? +1 "The caller needs to free the memory using ssh_string_free_char()." http://api.libssh.org/stable/group__libssh__sftp.html#gab4860a441da019060f78c8d236d9ec91 REPOSITORY R320 KIO

D19508: [kconf_update] move from custom logging tech to qCDebug

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:516f558742df: [kconf_update] move from custom logging tech to qCDebug (authored by sitter). REPOSITORY R237 KConfig

D19599: textfield height based only on clear text

sitter added a comment. LGTM, but do we need the MMM there? Wouldn't one M do? Or if control.text is always a string we don't need the ""+ at all? INLINE COMMENTS > TextFieldStyle.qml:60 > > -implicitHeight: Math.max(control.cursorRectangle.height * 1.6, >

D19514: Add support for detecting avahi crash - cleanup invalid dbus objects in that case

sitter added a comment. I haven't had a proper look, so only style complaints for now... but... Isn't the problem rather that the daemon shouldn't be randomly restarted on a live system? I.e. this ultimately is an integration issue on the distro-level. I doubt many if any avahi clients

D19508: [kconf_update] move from custom logging tech to qCDebug

sitter added reviewers: apol, aacid. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19508 To: sitter, apol, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19508: [kconf_update] move from custom logging tech to qCDebug

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous logging tech got kind of defunct in 2014 (to the point where it was basically qCDebug). seeing as no one

D19385: use KPackage::fileUrl to support rcc KCMs packages

This revision was automatically updated to reflect the committed changes. Closed by commit R296:096d214b67b3: use KPackage::fileUrl to support rcc KCMs packages (authored by sitter). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19385?vs=52716=52889

D19388: improve documentation on global config cascading

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d22f469be6fd: improve documentation on global config cascading (authored by sitter). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19388?vs=52725=52888 REVISION

D19385: use KPackage::fileUrl to support rcc KCMs packages

sitter added a comment. LXR seems to show a whole bunch of these code segments https://lxr.kde.org/search?_filestring=&_string=package.filePath Deprecation is probably a good idea. From where I am standing an application can always grab the path out of an url if absolutely necessary.

Re: kconf_update lost its update.log in 2014

On Thu, Feb 28, 2019 at 8:20 PM Albert Astals Cid wrote: > > El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va > escriure: > > ...and I don't understand why > > > > Hi! > > > > this commit [1] wrapped KonfUpdate::log's update.log s

kconf_update lost its update.log in 2014

...and I don't understand why Hi! this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0` and thus disabling the update.log writing, replacing it with logging to stderr instead. Why it does that eludes me though. It seems entirely unrelated to the rest of the commit. Should the

D19388: improve documentation on global config cascading

sitter added a reviewer: kde-frameworks-devel. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19388 To: sitter, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19388: improve documentation on global config cascading

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous description of IncludeGlobals was a bit lackluster. the new description should make it more obvious what

D19384: extend documentation of kpackage_install_bundled_package

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8040f07625fc: extend documentation of kpackage_install_bundled_package (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19384?vs=52715=52718

D19383: remove kpackage_install_package deprecation warning

This revision was automatically updated to reflect the committed changes. Closed by commit R290:90d9be331715: remove kpackage_install_package deprecation warning (authored by sitter). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19383?vs=52714=52717

D19385: use KPackage::fileUrl to support rcc KCMs packages

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the previous code would construct file:// URIs. instead, leave the url construction to

D19384: extend documentation of kpackage_install_bundled_package

sitter added a dependency: D19383: remove kpackage_install_package deprecation warning. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19384 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19383: remove kpackage_install_package deprecation warning

sitter added a dependent revision: D19384: extend documentation of kpackage_install_bundled_package. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19383 To: sitter, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19384: extend documentation of kpackage_install_bundled_package

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY explains how it is different from the other function and also what to watch out for when

D19383: remove kpackage_install_package deprecation warning

sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY an ad-hoc discussion on #plasma-devel suggests the science isn't quite in on whether

Re: Gitlab Evaluation & Migration

On Tue, Feb 26, 2019 at 10:37 AM Eike Hein wrote: > > > > On 2/26/19 6:26 PM, b...@valdyas.org wrote: > > * I've seen one workboard per project, that's not ideal, otoh, the Krita > > community early on went overboard with workboards, so we can make do > > with that > > I consider this one a

Re: Gitlab Evaluation & Migration

On Mon, Feb 25, 2019 at 2:38 PM Boudewijn Rempt wrote: > > On zaterdag 23 februari 2019 12:08:05 CET Boudewijn Rempt wrote: > > > * Is there anything we can have that can replace tasks and workboards? We > > usually have some very long-running tasks that get a lot of sub-tasks and > > that

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH relyonappimageimportedtarget REVISION DETAIL https://phabricator.kde.org/D18611 To: kossebau, broulik, sitter Cc: sitter, kde-frameworks-devel, kfm-devel, alexde, feverfew,

D19156: port to findcanberra from ECM

This revision was automatically updated to reflect the committed changes. Closed by commit R289:9964b8044974: port to findcanberra from ECM (authored by sitter). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19156?vs=52066=52274 REVISION DETAIL

kdbusaddons racing nameregistration with kcrash'd instance

Hey, I've found a tricky race condition in the startup of kdbusaddons and I need some thoughts on how to deal with it Let's assume binary foo is a dbus unique service on org.kde.foo that uses kcrash with autorestart enabled: - foo1 gets started - registers org.kde.foo - runs normally -

D19156: port to findcanberra from ECM

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY also move to imported target available from that finder TEST PLAN it builds!

D18952: new find module for Canberra

sitter updated this revision to Diff 52042. sitter added a comment. explicitly set FOUND_VAR so it is camelcase too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51976=52042 BRANCH master REVISION DETAIL

D18952: new find module for Canberra

This revision was automatically updated to reflect the committed changes. Closed by commit R240:50e8dd7b2d00: new find module for Canberra (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=52042=52043 REVISION DETAIL

D18952: new find module for Canberra

sitter marked an inline comment as done. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter updated this revision to Diff 51976. sitter added a comment. fix bad copy paste in compat setup REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51952=51976 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d14f77b87dbe: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5 (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D18952: new find module for Canberra

sitter updated this revision to Diff 51952. sitter added a comment. - pkgconfig is now quiet - variables are now camelcase - old variables are still set for compat - new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do) - set package description

D18952: new find module for Canberra

sitter marked 5 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18981: fix off-by-one on the version restriction for dnssd

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ba940a1cba05: fix off-by-one on the version restriction for dnssd (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18981?vs=51587=51590

D18981: fix off-by-one on the version restriction for dnssd

sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY 5.54 had the fix, so anything greater 5.53 would do REPOSITORY R320 KIO Extras BRANCH master

D18981: fix off-by-one on the version restriction for dnssd

sitter added a reviewer: broulik. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18981 To: sitter, broulik Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18952: new find module for Canberra

sitter added a comment. Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess `Canberra::Canberra` would be the preferred target name? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D18952: new find module for Canberra

sitter updated this revision to Diff 51576. sitter added a comment. document in rst syntax REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51491=51576 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952 AFFECTED

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. Oh, we could maybe use GNUInstallDirs.cmake's LIBEXECDIR on !Win32? like so: https://phabricator.kde.org/P317 I am not sure if there are any downsides to this. CMake code-wise I am not sure we should workaround implementation details of ECM in such a way.

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. Generally yes, I am not sure we can do that very well for 5.x though. The LIBEXEC_INSTALL_DIR where `kioslave` is installed is controlled by ECM, that's where the conditional split between suffix-or-not happens, so unless we add another LIBEXEC_INSTALL_DIR_REAL which

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added reviewers: davidedmundson, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18725 To: sitter, davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18952: new find module for Canberra

sitter created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY used by: - knotification - (possibly also knotifyconfig at some point) - plasma-pa

D18878: Force NT1 protocol when listing smb:// network

sitter added a comment. No. This is already unnecessary. If a user requires SMB1 it may be tuned via /etc/samba/smb.conf. And that tuning would never be necessary if we had ws-discovery support I think... there is no Windows version which doesn't have ws-discovery and (all?) non-windows

D18878: Force NT1 protocol when listing smb:// network

sitter added a comment. https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges from sound upstream defaults, goes against advise and practises set forth by Microsoft,

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter added a comment. BTw, am I missing something or shouldn't this entire kioslave lookup be made static? It only needs computing once but currently is run for every new slave that gets started (in fork-mode). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18725

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the kioslave harness is installed to LIBEXEC_KF5 which is '$libexec/' on win32 (technically $bindir) and

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

sitter added a comment. Even with the chances being low of a system having an old version, I'd say it's better to actually make find_package look for at least the version that introduced the import target. other than that  REPOSITORY R320 KIO Extras REVISION DETAIL

Re: KDE's release script not functional on stable openSUSE

2.1 reached EOL almost 2 years ago. I suggest you ruby-build or rvm a newer version isolated from your system's. On Thu, Jan 24, 2019 at 11:29 AM Jaroslaw Staniek wrote: > > Hi Jonathan, > The releaseme tools require ruby 2.3 while openSUSE 42.3 depends on 2.1. And > it lacks multiple ruby

D10716: handle wrong password when using sudo which asks for another password

sitter accepted this revision. sitter added a comment. lgtm REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18178: fix environment setup of klanguagename test

This revision was automatically updated to reflect the committed changes. Closed by commit R265:5ba6283e4ec1: fix environment setup of klanguagename test (authored by sitter). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18178?vs=49224=49433

D18178: fix environment setup of klanguagename test

sitter edited the summary of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18178 To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

sitter added a comment. BUILD_TESTING easy fix: https://phabricator.kde.org/source/knotifyconfig/browse/master/CMakeLists.txt$60 REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: fvogt, kde-frameworks-devel, michaelh, ngraham,

D18178: fix environment setup of klanguagename test

sitter created this revision. sitter added reviewers: aacid, rikmills. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - use correct env vars LANG and LANGUAGE - as an additional safety-net

D10446: Add KLanguageName

sitter added a comment. Oh actually. I have a theory. My environment vars were wrong. Try with s/LANG/LANGUAGE and s/LOCALE/LANG please. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: rikmills, vkrause, dhaumann, hein,

D10446: Add KLanguageName

sitter added a comment. You'll have to debug this for us. It passes on build.kde.org  REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid, apol Cc: rikmills, vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham,

D10446: Add KLanguageName

This revision was automatically updated to reflect the committed changes. Closed by commit R265:91077def022a: Add KLanguageName (authored by aacid, committed by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10446?vs=48854=49079#toc REPOSITORY R265 KConfigWidgets CHANGES

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in klanguagenametest.cpp:80 > Do you think it makes sense adding this? > > void testNoString() > { > // Qt doesn't have za support so no string at all > QCOMPARE(KLanguageName::nameForCode("za"), QString()); > } 

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in klanguagename.cpp:30 > should the second param be code too? > > I mean if we read the docs we say both are code (ISO 639-1), so both should > be the same and not only the first part? Do you mean both being **a** code or both being

D10446: Add KLanguageName

sitter updated this revision to Diff 48853. sitter added a comment. configure_file the fixtures lest they get mangled by scripty on account of being desktop files lookup still goes through qfindtestdata, so we need the output relative to the binary now REPOSITORY R265 KConfigWidgets

D15573: replace custom backtracing in SlaveBase with KCrash

sitter added a comment. I am somewhat indifferent. It certainly has caused some grief for various reasons in various places, so it stands to reason that it should go. Also since auto-init of kcrash is essentially not a thing for application code (what with link-as-needed being a common

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in kf5_entry.desktop:1 > If you look carefully at Messages.sh, you'll see that they never mention > .desktop files, that's because .desktop files are extracted automatically for > translation, so yes, it will be a problem, because

D10446: Add KLanguageName

sitter added inline comments. INLINE COMMENTS > aacid wrote in kf5_entry.desktop:1 > This is going to be a problem, scripty is going to come and whipe these > .desktop files out and then make the translators translate them again. > > Wonder if we could rename them to .desktop.untransltable or

D10446: Add KLanguageName

sitter updated this revision to Diff 47758. sitter added a comment. move env setup to qcorestartup to prevent the env from not getting set up in time and the tests failing as a result REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D10446: Add KLanguageName

sitter added a comment. In D10446#377355 , @aacid wrote: > But you end up repeating that in lots of places (which we should there's lots of places that suffer from trying to guess a language name at this point, and all of them went the bad way

D10446: Add KLanguageName

sitter updated this revision to Diff 47623. sitter added a subscriber: hein. sitter added a comment. iterating the diff a bit as mentioned in a comment. - new unit test which covers all likely scenarios (I think). this uses fixtures and doesn't require anything to be installed etc. -

D10446: Add KLanguageName

sitter added a comment. Stacking the functions seems to work fine QString KLanguageName::nameForCode(const QString ) { const QStringList parts = QLocale().name().split(QChar('_')); return nameForCodeInLocale(code, parts.at(0)); } I do have various

D10446: Add KLanguageName

sitter added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @aacid what were the changes you had planned here? Does anyone else have thoughts on kcoreaddons vs. kconfigwidgets? I suppose we could move the class along with kf5_entry.desktop to

Re: KDE Frameworks web page

On Tue, Dec 11, 2018 at 2:17 PM Alexander Potashev wrote: > > Thanks! > > вт, 11 дек. 2018 г. в 15:32, Jonathan Riddell : > > > 2. Text on the blue grid under "Organisation" is not very readable. > > > > Works for me. Again it's copying what's on the Kirigami page. Suggestions > > welcome but

D17479: Fix build without phonon

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Oh la la, I didn't even realize phonon was optional. New code is much better. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17479 To:

Re: Building KDE (phonon-vlc) fails

On Mon, Dec 10, 2018 at 11:26 AM Frederik Schwarzer wrote: > After installing it, phonon-vlc built fine. this should be easier to diagnose in the future https://commits.kde.org/phonon-vlc/e441972892fe61e361ee9b2c39ce0b319f6d1c9e HS

D16299: fallback to dnssd service discovery if smb listDir failed on root

This revision was automatically updated to reflect the committed changes. Closed by commit R320:55eb68ff6364: fallback to dnssd service discovery if smb listDir failed on root (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D17234: do not attempt to link phononexperimental :O

This revision was automatically updated to reflect the committed changes. Closed by commit R305:f6d55baf5aa8: do not attempt to link phononexperimental :O (authored by sitter). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17234?vs=46460=46461

D17234: do not attempt to link phononexperimental :anguished:

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY ${PHONON_LIBS} as the name suggests links all libraries, that includes the

D17234: do not attempt to link phononexperimental :O

sitter edited the test plan for this revision. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17234 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17234: do not attempt to link phononexperimental :O

sitter retitled this revision from "do not attempt to link phononexperimental :anguished:" to "do not attempt to link phononexperimental :O". REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17234 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham,

D17205: Build kio_nfs against standalone libtirpc

sitter added a comment. LGTM I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits. INLINE COMMENTS > CMakeLists.txt:2 > ## Check for XDR

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. // TODO: it may be better to resolve the host to an ip address. dnssd // being able to find a service doesn't mean name resolution is // properly set up for its domain. So, we may not be able to resolve // this without help from avahi. OTOH KDNSSD

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef,

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter retitled this revision from "RFC fallback to dnssd service discovery if smb listDir failed on root" to "fallback to dnssd service discovery if smb listDir failed on root". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks,

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added inline comments. INLINE COMMENTS > ngraham wrote in kio_smb_browse.cpp:508 > iff -> if https://en.wikipedia.org/wiki/If_and_only_if REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: alexde, bcooksley, ngraham,

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter updated this revision to Diff 45938. sitter marked 4 inline comments as done. sitter added a comment. - check kdnssd version; do not use dnssd discovery if it too old and suffers from signal racing (also see D16298 ) - fix typo in function name -

D17068: actually install the version header

This revision was automatically updated to reflect the committed changes. Closed by commit R272:43543acfee14: actually install the version header (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17068?vs=45936=45937 REVISION DETAIL

D17068: actually install the version header

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY we've generated it but never installed it :| this enables lib consumers to check the kdnssd version without having to

D17068: actually install the version header

sitter added reviewers: Frameworks, broulik. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D17068 To: sitter, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16298: prevent avahi signal racing

This revision was automatically updated to reflect the committed changes. Closed by commit R272:3a41622348b9: prevent avahi signal racing (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16298?vs=43863=45932 REVISION DETAIL

D17067: do not leak resolver in remoteservice

This revision was automatically updated to reflect the committed changes. Closed by commit R272:67dcc1cee877: do not leak resolver in remoteservice (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17067?vs=45931=45933 REVISION DETAIL

D17067: do not leak resolver in remoteservice

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY avahi's dbus api expects us to control the live time of objects. to that end we need

D17019: actually initialize kcrash properly

This revision was automatically updated to reflect the committed changes. Closed by commit R293:5e32846b785b: actually initialize kcrash properly (authored by sitter). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17019?vs=45819=45873 REVISION DETAIL

D17019: actually initialize kcrash properly

sitter created this revision. sitter added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY to successfully use kcrash when linking with as-needed (which is a

Re: firewall-applet icons break breeze auto tests

On Sun, Nov 18, 2018 at 6:33 PM Noah Davis wrote: > > My *guess* is that whoever decided 16, 22 and 32 are "fixed" even if they > > are SVG while 48 is not, is that sometimes in the 16, 22, 32 sizes you have > > to "sacrifice" some details because since you know it'll be shown in small > > sizes

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

sitter added a comment. https://mail.kde.org/pipermail/distributions/2018-October/000298.html REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc: sredman, albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh,

<    2   3   4   5   6   7   8   9   10   11   >