sitter added inline comments.

INLINE COMMENTS

> aacid wrote in kf5_entry.desktop:1
> If you look carefully at Messages.sh, you'll see that they never mention 
> .desktop files, that's because .desktop files are extracted automatically for 
> translation, so yes, it will be a problem, because translations will be 
> dropped (until translators translate them), making the test flaky

Ah, you are absolutely right.

In this case I agree configure_file is the way to go. I'll get on it tomorrow.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

Reply via email to