D24807: Fix incorrect rendering of 22px edit-opacity icon

simgunz accepted this revision. simgunz added a comment. This revision is now accepted and ready to land. The icon is now rendered correctly in Okular and cuttlefish. REPOSITORY R266 Breeze Icons BRANCH fix-edit-opacity-22px-icons (branched from master) REVISION DETAIL

D24753: Add edit-opacity icons

simgunz added a comment. First, thanks for the excellent work on the new icons for Okular. I really like them. I have noticed that the edit-opacity icon does not render correctly in some cases: F7636237: Screenshot_20191020_150623.png

D19692: openwithdialog: use recursive flag in proxy filter

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a7d59e121b15: openwithdialog: use recursive flag in proxy filter (authored by simgunz). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19692?vs=53689=53704 REVISION

D19692: openwithdialog: use recursive flag in proxy filter

simgunz created this revision. simgunz added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. simgunz requested review of this revision. REVISION SUMMARY Use the flag introduced in Qt 5.10 instead of custom code REPOSITORY R241 KIO

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. In D8056#206303 , @rkflx wrote: > @simgunz Thanks again for your patience (first commit in July!). Hope to see more patches from you in the future (both large* like this one, but also smaller things**), as you both have

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. > - [↓] to move focus (this breaks with the completion enabled, though) Only for completion: popup. Still works for completion: auto I have changed the tooltip as suggested. I think we are ready to land it. Can't wait to see the gif! REPOSITORY R241

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 27136. simgunz added a comment. - Improve tooltip to let user know he can type a command REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=27084=27136 BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. I rebased to master and updated the review. I hope I didn't messed up anything. In D8056#205621 , @ngraham wrote: > I was under the impression that the text box gave priority to the app filtering unless you checked

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 27084. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter - Fix code styling - Set appModel and proxyModel together, store

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. In D8056#205614 , @ngraham wrote: > interspersing the CLI command and application filtering would be a mistake. Say I type `kate`. Am I intending to use the `kate` command, or select the "Kate" app? It's ambiguous if we

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. The tooltip of the line edit now says: `Type some text to filter the application tree.\nPress down arrow to navigate the results tree.` I suggest to change it to: `Type to filter the application tree or type the name of a command.\nPress down arrow to navigate the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Fixed the problems reported by @rkflx hopefully without introducing new ones. I did some testing and now everything seems ok, but please check again. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 27079. simgunz added a comment. - Fix OK button not disabled when category is selected - Fix cannot accept selection if filter line edit is empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=24488=27079 BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Good! I cannot push so someone needs to do it for me. Soon, I'll have more free time, and I'll try to polish the code (remove fetch more, use Qt 5.10 recursive filtering). REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. I found some time to implement the suggestions given by @dfaure and I removed all the static_cast. I haven't implemented any UI change for now. I think that if there are not problems we can land it as it is now, and then improve the UI in a second moment (in few

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 24488. simgunz marked 8 inline comments as done. simgunz added a comment. - Avoid cast by using member var to proxyModel - Initialize m_proxyModel to null pointer - Add access method to m_proxyModel, use it to avoid cast - Remove unuseful returns,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. The deadline of my PhD thesis is very close, so my free time is basically zero in this period. Unfortunately, I didn't manage to complete these reviews before entering this critical period. In January I should have free time and I'll complete this. I also can't wait

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added inline comments. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:463 > Use the member var instead of casting. Segmentation fault happens if I use the member var. Accessing the member var is the cause of the fault, because even `qDebug() << d->m_proxyModel` generates the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz marked an inline comment as done. simgunz added a comment. > @simgunz If you have no further changes planned for this Diff and https://phabricator.kde.org/D8670, I could land both on your behalf. Contact information of non-developers are private by default on identity.kde.org, but I

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz marked an inline comment as done. simgunz added a comment. @rkflx I agree on all your points. In general I also prefer to have the categories. Implementing what you propose will require a bit of time. Basically if we want any behavior different from the current one, we need to

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 21990. simgunz marked an inline comment as done. simgunz added a comment. - Use fixed string case insensitive filter REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8056?vs=21925=21990 BRANCH

D8670: Change label "Advanced options" > "Terminal options"

simgunz added reviewers: dfaure, ngraham, fabianr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8670 To: simgunz, dfaure, ngraham, fabianr Cc: #frameworks

D8670: Change label "Advanced options" > "Terminal options"

simgunz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Be more specific with the label as HIG say REPOSITORY R241 KIO BRANCH terminal-options-label REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. I have fixed what dfaure suggested. I couldn't remove the cast at line 463 because a Segmentation fault happens. It is not clear to me why exactly. Regarding removing the categories I need to work on that, because it is not trivial apparently. I thought it was

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 21925. simgunz marked 4 inline comments as done. simgunz added a comment. - Fix code styling - Set appModel and proxyModel together, store proxyModel in data member - Avoid casts using pointer to proxyModel REPOSITORY R241 KIO CHANGES SINCE LAST

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Can you be more specific? Currently, the categories are expanded automatically after 3 characters have been typed. Do you want to make the categories disappear at this point? Or not having them from the beginning? REPOSITORY R241 KIO BRANCH

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz marked 9 inline comments as done. simgunz added a comment. I fixed most of them. I think I'll have time tomorrow. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:398 > Ah. Filipe and I implemented recursive filtering in QSortFilterProxyModel but > that's only in Qt 5.10. Too

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. > Can we not just remove the drop down menu and always show the checkbox for terminal? Actually I've just changed that behaviour few months ago to follow the "simple by default, powerful when needed" philosophy. See this review and the related bug for the

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. @ngraham Great! I don't have commit access. @fabianr I agree on changing that label to "Terminal options". I'll send a new revision request for that. REPOSITORY R241 KIO BRANCH openwithdialog-filter-app-tree REVISION DETAIL

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Ok. Now it should work properly. I've also added a tooltip to the search box to explain the down arrow feature so that it is not hidden. The current text is: "Type some text to filter the application tree.\nPress down arrow to navigate the results tree."

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz updated this revision to Diff 21261. simgunz added a comment. - Automatically select first match of the filter - ArrowDown on lineEdit pass focus to QTreeView - Add tooltip to explain how to use the search filter REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. Here is a picture: F5448036: openwith_filter.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham Cc: abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. In https://phabricator.kde.org/D8056#158939, @ngraham wrote: > @simgunz, have you had a chance to try implementing David's suggestion? Yes. Everything seems to work but I haven't pushed yesterday because I wanted to do an extra test. The current

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. In https://phabricator.kde.org/D8056#155537, @ngraham wrote: > Any progress? This is too good a change to not merge. :) Today I finally had the time to work on this and I've implemented the "select first result by default" and it seems to work nicely.

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. > I see what you mean. How about implementing "down-arrow-changes-focus" only when not using dropdown completion? Seems ok. I'll implement it this way soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz added a comment. > - When the text field has focus, make the down arrow key move to the list of found results so that you can select one with the keyboard and not have to use the mouse at all I like the idea and in my personal opinion it should behave as you suggest, but before

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz edited the test plan for this revision. simgunz added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure Cc: #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

simgunz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The current "open with" dialog implementation does not follow the KDE principle "Simple by default, powerful when needed" for the following

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 0296b89714ce96b247322d9be09b387573d79193 by David Faure on behalf of Simone Gaiarin to branch master. Bugs: 359233 https://bugs.kde.org/show_bug.cgi?id=359233 Repository: kio Description

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

> On Lug. 15, 2017, 7:31 a.m., Simone Gaiarin wrote: > > Inviala! > > Luigi Toscano wrote: > You can't "ship it" you own review. "Ship it" is marked by other > reviewers who thinks that this should go in. > Do you mean to say that you don't

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130180/#review103453 --- Ship it! Inviala! - Simone Gaiarin On Lug. 12, 2017

Re: Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

visit: https://git.reviewboard.kde.org/r/130180/#review103451 --- On Lug. 12, 2017, 6:54 p.m., Simone Gaiarin wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

ck on entry launches the software - Remember program association for mime works - Run in terminal works - Keep open terminal works Thanks, Simone Gaiarin

Review Request 130180: Make advanced options of "open with" dialog collabsible and hidden by default

7413524c99ef61b7967b0ec8b9 Diff: https://git.reviewboard.kde.org/r/130180/diff/ Testing --- Thanks, Simone Gaiarin

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

association for mime works - Run in terminal works - Keep open terminal works Thanks, Simone Gaiarin

Re: Review Request 130179: Improve usability of "Open With" dialog by adding option to filter the application tree

tegory opens it - Double click on entry launches the software - Remember program association for mime works - Run in terminal works - Keep open terminal works Thanks, Simone Gaiarin

Review Request 130179: Disable autocompletion by default

490dd6 Diff: https://git.reviewboard.kde.org/r/130179/diff/ Testing --- With and without some text in the line edit: - Double click on category opens it - Double click on entry launches the software - Remember program association for mime works - Run in terminal works - Keep open terminal works Thanks, Simone Gaiarin

How to use KAuth in a KDModule written in pykde?

Hi all, I'm writing a KCModule with pykde and I need to use KAuth but I haven't found documentation about it (there is documentation only for the C++ version). So I want to ask how can I write an helper for the 'save' function, how can I use it from the KCModule and how can I register the action