Re: KDE Gear projects with failing CI (master) (4 June 2024)

sn't this kind of change forbidden in minor releases? The path is correct at the point it is issued, referring to the same directory. The fact that it is in a different form was not expected to be a breaking change. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Principal Eng

Re: Should we stop distributing source tarballs?

On Thursday 4 April 2024 04:26:57 PDT Sune Vuorela wrote: > 'does it use autotools?' The outcome of this is "please migrate off Autotools". -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Principal Engineer - Intel DCAI Cloud Engineering

Re: Switching to Qt 5.15.11 KDE patched

> fine, but then I wonder about the includes: You have to force the recreation of the includes dir. Just: touch .git Before running configure. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DCAI Cloud Engineering

Re: Deprecation of QSharedMemory and QSystemSemaphore

f memory. For the other ones, the question is what they're using QSharedMemory for (how many processes, what's the ownership model). -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DCAI Cloud Engineering

Re: drkonqi's many debuggers

On Thursday, 31 August 2023 03:42:59 PDT Halla Rempt wrote: > On dinsdag 29 augustus 2023 05:22:56 CEST Thiago Macieira wrote: > > True, but the majority of our user base is still Linux, so if we had to > > choose only one, it would have to be gdb. > > Um, no? The majority is

Re: drkonqi's many debuggers

On Monday, 28 August 2023 21:33:25 PDT Nate Graham wrote: > On 8/28/23 22:25, Thiago Macieira wrote: > > It does because it might be missing in the system far more often than gdb. > > We'd get more backtraces and therefore more data if we focused on gdb > > > >

Re: drkonqi's many debuggers

till pending: https://github.com/llvm/llvm-project/issues/52732 Therefore, I repeat: if there's room for only one, it's gdb. If we do support both, then on Linux gdb must be used in preference. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Inte

Re: drkonqi's many debuggers

I don't know if > I ever bother to interact with DrKonqi (sorry). True, but the majority of our user base is still Linux, so if we had to choose only one, it would have to be gdb. That's probably why we need to have both gdb and lldb supported. -- Thiago Macieira - thiago (AT) macieira.info

Re: drkonqi's many debuggers

rience (both in writing and > reading it). If you want *one* debugger, then it has to be GDB on Linux, because it's the one that most people will have installed. $ lldb --version zsh: command not found: lldb -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Archite

Re: Clarification on QT and kde patch set

chCollection#How_do_I_get_this_integrated_in_my_distribution? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DCAI Cloud Engineering

Re: RFC: Library unit testing and symbol visibility

ra symbols are exported using the Q_AUTOTEST_EXPORT macro. This allows developers and CI systems to enable the extra API without needing to affect users. The CI also tests non-"internal build" builds, so the tests must check whether they are in that mode before using a autotest-exporte

Re: Major QDBus regression in Qt6 with potential impact on KDE

likely a Heisenbug and difficult to debug. It might also be a latent issue in Qt 5 that got exposed by faster functionality somewhere in QtCore, because there have been no changes to QtDBus to account for this (it has barely received any changes since 5.6). Someone needs to debug it and I don't have the

Re: Fwd: KDiff3 v 1.9.6 Windows crash

Qt based > application. Worse a lot the documentation I find assumes you are a) > debugging a drive and/or b) working with msvc project that you can > reproduce the crash in. The same as anywhere else: run the application inside the debugger (gdb if it is MinGW). When it crashes, type "bt

Re: kdesrc -- stuck building kwayland

if you want to build this version of kwayland. > Thank you for kdesrc, there are a few quirks but in general it is great we > can try new stuff in a stable system ! That's not always possible. This is such a case. You'll need an upgrade. -- Thiago Macieira - thiago (AT) macieira.i

Re: Challenge: adding new method overloads when existing consumers use {} with args

t a requirement before, so more like Cat A. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: Challenge: adding new method overloads when existing consumers use {} with args

or one, the mailing list thread linked in the QUIP didn't address it. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: Challenge: adding new method overloads when existing consumers use {} with args

h QLatin1String (or Qt6's QByteArrayView or QAnyStringView or any such other combination) because it makes calling with a character literal ambiguous. But you can if one of them is a weak overload. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect -

Re: NetworkManagerQt

it's a Linux device, that was already the case. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: QtWebengine version

d be have been doing all along. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: The KDE Patchset Collection has been rebased on top of Qt 5.15.3

oning KDE Plasma build is all the patches that exist at the moment you ask that question. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: libksane seems to break QProcess::start calls

what I could grasp, I filed an issue: > https://gitlab.com/sane-project/backends/-/issues/582 > > I fear fixing this is far beyond my programming skills. I hardly understand > what's going on here at all ... I'll add some comments. [1] https://codereview.qt-project.org/c/qt/qtbase/+/

Re: libksane seems to break QProcess::start calls

with this stuff > to learn more about process handling, threads and forks and so on. "If you write buggy code, the application may misbehave" is not documentation. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: libksane seems to break QProcess::start calls

), as that gets shared between parent and child. A memfd would be ideal, but if that fails, you can use a regular QTemporaryFile. On Linux, QSharedMemory is just a memory-mapped file on a tmpfs (/dev/shm) after all, only it's hiding behind two or three layers of abstraction. -- Thiago Macieira -

Re: libksane seems to break QProcess::start calls

On Friday, 4 March 2022 09:02:37 PST Thiago Macieira wrote: > > I uploaded the traces here: > > https://l3u.de/tmp/strace_brscan.txt.xz > > https://l3u.de/tmp/strace_plustek.txt.xz > > > > Thanks again for all help! > > I'll take a look. Let's see... t

Re: libksane seems to break QProcess::start calls

q) != typeid(QProcess)) ffdflags |= FFD_USE_FORK; https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/io/qprocess_unix.cpp? h=5.15#n462 -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: libksane seems to break QProcess::start calls

e, it came from elsewhere. > Apart from that, the scanner in question actually does use the plustek > backend! I fear there's no way to fix this in my code?! Fix the problem where the problem is. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: Please check your QProcess/KProcess invokations

return program; The issue is handling findExecutable() not finding anything. Instead of refusing to run, we return program; which is the name that you had passed, and that goes straight into execve(). -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: global shortcuts

On Saturday, 22 January 2022 04:33:24 PST Martin Koller wrote: > Hi, > > which component is responsible for acting on global shortcuts, e.g. > what triggers that Alt-F2 is opening krunner ? kglobalacceld -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Softwa

Re: Trying to build knotifications framework, kdesrc-build and qt5

On Tuesday, 3 August 2021 05:29:22 PDT Colin Williams wrote: > I don't have a clue regarding 'reduce_relocations'. Is there a way to > disable it and would it make sense to do so? Check the config.log -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Arc

Re: RFC: Konsole profile groups

size in all profiles in the same place. But it looks like it's too well hidden. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: Does Kwin script's callDBus support a{sv} argument type?

omething is broken. You'll need to debug. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

Re: Safely storing an application's API keys

many requests per second it is allowed to make. This happens for example to the rclone API key to use Microsoft One Drive. Please reach out to the services in question and advise them that your software is open source and therefore cannot hide the key at all, and present these two poss

Re: A question relating Arora

e code. Trolltech did use to hire talented developers from the KDE community, which is how quite a few of us ended up there, like Matthias Ettrich (KDE's founder), Lars Knoll (khtml's original author), Simon Hausmann, Roberto Raggi and Harald Fernengel (from KDevelop), Thomas Zander (KOff

Re: How do you deal with incomplete commits?

should always review what you've sent for review anyway and you can notice you pushed something incomplete. At that point don't create the review request or write that it isn't yet ready for review. Second, your reviewers should notice it's incomplete and won't approve. -- Thiago Macieira -

Re: KPluginLoader UBSAN warnings (object has invalid vptr)

re yet if this is an UBSan bug or if there was some weird, duplicate symbol problem. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DPG Cloud Engineering

D28745: Skip caching thumbnails on encrypted filesystems

thiago added a comment. BTW, have you checked if the thumbnails are still generated for non-removable but encrypted filesystems? My whole system is encrypted (except for /boot), so it would be a performance loss if no thumbnails were ever cached. REPOSITORY R320 KIO Extras REVISION

D28745: Skip caching thumbnails on encrypted filesystems

thiago added inline comments. INLINE COMMENTS > marcingu wrote in thumbnail.cpp:776 > "-1 isn't exactly a great value for an unsigned int :-)" > > I believe "-1" guaranties unsigned to be set to its maximum value, due to how > type conversion works, but I could be wrong. > > Do you know if

D28745: Skip caching thumbnails on encrypted filesystems

thiago added a comment. > for (Device device: list) { > StorageAccess *storageAccess = device.as(); > if (canonPath.startsWith(storageAccess->filePath()) && storageAccess->filePath().size() > match_length) { > match_length = storageAccess->filePath().size(); >

D28745: Skip caching thumbnails on encrypted filesystems

thiago added a comment. Use Solid and ask it if the device is on an encrypted device. If Solid does not have such an API, add it. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: thiago,

D28745: Skip caching thumbnails on encrypted filesystems

thiago added inline comments. INLINE COMMENTS > thumbnail.cpp:743 > +const auto mount = mountsList.findByPath(filePath); > +allowCache = !(mount->mountType() == > QLatin1String("fuse.cryfs") || mount->mountType() == > QLatin1String("fuse.encfs")); > +

Re: Is kdeinit still actual?

ave (file.so, that was already running) are sharing 2380 kB between them. The ioslave has a total of 548 kB of additional private memory that isn't shared with anything else in the system. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel System Software Products

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. Still want to see that round-trip. INLINE COMMENTS > smburltest.cpp:112 > +// % character - run through .url() to simulate behavior of our > listDir() > + > QCOMPARE(SMBUrl(QUrl(QUrl("smb://?kio-workgroup=HAX%MAX").url())).toSmbcUrl(), > +

D27802: smb: fix ipv6 support

thiago added a comment. looks good to me. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D27802: smb: fix ipv6 support

thiago added a comment. STD3 also forbids domain labels ending in dash, so can you add a test for `smb://[fe80::]/` too? You'll need to adjust your code REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: thiago, kde-frameworks-devel,

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. Looks good, but testing should be extended. I suggest: 1. A workgroup with non-US-ASCII characters in the name, if that's permitted 2. A workgroup with % in the name: the URL should have "%25" 3. Roundtrip checking. The test only does toSmbcUrl(), so please

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

thiago added a comment. Good catch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25996 To: chehrlic, thiago, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: ELF Dissector in kdereview

On Tuesday, 1 October 2019 05:06:57 PDT Jonathan Riddell wrote: > -isystem > /usr/include/capstone/.. [...] > /usr/include/c++/7/cstdlib:75:15: fatal error: stdlib.h: No such file or > directory That -isystem is the mistake. -- Thiago Macieira - thiago (AT) macieira.info - thiago

Re: Cmake and dbus daemon on the system bus

rivileged user, that's better. That can be as a result of dropping privileges with setuid() or capset() after acquiring the resource you need. If you do that, connect to the bus AFTER you've dropped privileges. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software

D17737: [CopyJob] Create clones in btrf/xfs mount

thiago added a comment. QFile::copy already implements FICLONE, sendfile() and Darwin's clonefile(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17737 To: chinmoyr, dfaure, #frameworks, thiago, ossi Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh

Re: Invoking "kcheckpass" from the terminal

those off. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel System Software Products

D21855: [IdUtils] Fix aliasing warning

thiago added a comment. Alternative: return (quint64(devId) << 32) | inode; Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich,

D21855: [IdUtils] Fix aliasing warning

thiago added a comment. +1 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: How is the Font DPI Scale stored?

On Wednesday, 12 June 2019 08:53:50 PDT Elias Mårtenson wrote: > Thank you. That works beautifully. I do wonder, however, if it's > deprecated, what is meant to replace it? Properly? Wayland. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect -

D21317: Manipulate bytes instead of characters

thiago added a comment. As for truncating UTF-8 multibyte sequences in the middle, when you convert back using QFile::decodeName, it'll be nonsensical. But I don't think it really matters since you're truncating and using the display string anyway, so you're already losing data. This wasn't

D21317: Manipulate bytes instead of characters

thiago added a comment. I cringe a little when you apply QFile to a URL, but this is probably safe enough. LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21317 To: chinmoyr, bruns, dfaure, thiago Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. It looks good to me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. Much better, thanks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > vandenoever wrote in kconfigini.cpp:683 > A check for U+10 > value is needed. > Overlong sequences are caught on line 696 (count < 4). That's not what an overlong sequence is. You can produce 2-, 3- and 4-byte overlong sequences. See the

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > kconfigini.cpp:683 > +// When an additional byte leads to an invalid character, return > false. > +bool addByte(unsigned char b) { > +if (count == 0) { This function does operate properly to find valid syntax UTF-8

Re: KWin testing

DBus.Properties interface, on that object. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

D17015: Fix the Qt doc creation with Qt 5.12.

thiago added a comment. qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip the .0 release and upgrade. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17015 To: cgiboudeaux, kossebau Cc: thiago, tcberner, kde-frameworks-devel,

Re: Time formats / LC_TIME challenge for 4-digit year support

atched in version 5 with such > incompatible change. Hopefully these poor man analysis help some other app > developers If you want that, please submit your patch to unicode.org. They need to update the CLDR to have 4-digit years for the locale of your choice. -- Thiago Macieira - thiago (AT) macieira.i

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

is exactly why 5.11.3 (released today) should be picked. It contains all fixes that 5.9.7 contains, whereas 5.10.1 does not. Moving from 5.9.7 to 5.10.1 means regressing all those fixes. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

Re: auto QString(Builder) considered VERY HARMFUL

On Thursday, 27 September 2018 12:30:30 PDT Elvis Angelaccio wrote: > is it possible to fix Qt instead? No, the C++ language needs to be fixed. Search for "operator auto" for proposals. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect

Re: network connectivity with proxy

On Wednesday, 19 September 2018 15:20:27 PDT Christoph Feck wrote: > On 20.09.2018 00:03, Albert Astals Cid wrote: > > El divendres, 14 de setembre de 2018, a les 18:04:59 CEST, Thiago Macieira va escriure: > >> On Wednesday, 12 September 2018 04:17:35 PDT Harald Sitter wr

Re: network connectivity with proxy

t; Obviously that's not very integrated in plasma. The correct way is to configure your system properly. Qt will use libproxy and will get the settings. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

Re: Installing qml caches

On Sunday, 8 July 2018 09:06:58 PDT Simon Hausmann wrote: > And use the QtQuickCompiler build > option with 5.11. Is that just running qmlcachegen on all the *.qml? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#297515 , @dfaure wrote: > The idea of the old code was: if I can't get the lock, then someone else is already in the process of starting kdeinit, so I'll just wait for that to happen, by locking again, i.e.

D14302: Don't block forever in ensureKdeinitRunning

thiago added inline comments. INLINE COMMENTS > kdeinitinterface.cpp:46 > QLockFile lock(QDir::tempPath() + QLatin1Char('/') + > QLatin1String("startkdeinitlock")); > -if (!lock.tryLock()) { > +if (!lock.tryLock(timeout)) { > lock.lock(); This line doesn't need changing.

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#297159 , @jtamate wrote: > (gdb) disass > Dump of assembler code for function _ZN9QLockFile7tryLockEi: > 0x7f54be8bc752 <+2>: mov$0x,%eax > ... > 0x7f54be8bc76d

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. Quickly checking on openSUSE Tumbleweed In D14302#297185 , @lvsouza wrote: > I think I know what is happening. This line > > QDeadlineTimer timer(qMax(timeout, -1));// QDT only takes -1 as "forever" > >

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. > timer = {t1 = 9223372036854775807, t2 = 0, type = 1} This is indeed Forever. How did it get there? I showed in my debug session that the QDeadlineTimer is passed zero, and then it does initialise properly. So I'm now beginning to question the compiler.

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. Can you print the contents of the timer object inside tryLock()? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D14302 To: jtamate, dfaure, #frameworks, thiago Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#296671 , @jtamate wrote: > Another hypothesis: > > QDeadlineTimer::QDeadlineTimer(qint64 msecs, Qt::TimerType type) Q_DECL_NOTHROW > : t2(0) > { > setRemainingTime(msecs, type); > }

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. Quick testing via gdb: Breakpoint 1, QLockFile::tryLock (this=0x7fffc6d8, timeout=0) at /home/tjmaciei/src/qt/qt5/qtbase/src/corelib/io/qlockfile.cpp:241 241 Q_D(QLockFile); (gdb) n 242 QDeadlineTimer timer(qMax(timeout, -1));

D14302: Don't block forever in ensureKdeinitRunning

thiago added a comment. In D14302#296479 , @dfaure wrote: > I agree about tryLock(0) should return immediately, tryLock(-1) should block forever -- I wrote that code and that docu ;-) > > Thiago wrote QDeadLineTimer later on though, and

Re: Q_ASSERT(!FalseSecurity)

t;commit(); ? It should definitely NOT be this. Use either Q_ASSERT or the if, not both. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

Re: Unable to run the unit test - receiving signal 11

resolve it? The interesting part in the message was replaced by . . . Bring the information back and, if necessary, install debug symbols for the libraries in that backtrace. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

D10273: Create proper SocketAddress

thiago added a comment. That doesn't make sense. There's QFile::encodeName in the code. Is there a section of the library that is used in elevated privilege code, but not all of it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks

D10273: Create proper SocketAddress

thiago added a comment. Looks good. INLINE COMMENTS > fdsender.cpp:24 > > FdSender::FdSender(const std::string ) > : m_socketDes(-1) The problem here is the API. Why is it using std::string in the first place? REPOSITORY R241 KIO REVISION DETAIL

D9966: [KIO] Fix issues with sharing of file descriptor

thiago added a comment. The patch that I can see accomplishes what the description says it should do. And I agree with the idea of the patch. INLINE COMMENTS > dfaure wrote in fdreceiver.cpp:88 > This is UNIX-only, but indeed OSX is missing. Does that support getpeereid? __APPLE__ is

D9966: [KIO] Fix issues with sharing of file descriptor

thiago added a comment. Why do you ask for a rewview then not wait for the review? Belated -1. No actual review of the change done, because I can't tell what you've done. INLINE COMMENTS > fdreceiver.cpp:34 > { > +SocketAddress addr(m_path.toStdString()); > +if

Re: kcrash, fork, and stdout/stderr

t say you're using QProcess. [continued on the other email] -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: kcrash, fork, and stdout/stderr

ild_pid = syscall(__NR_clone, NULL, SIGCHLD, NULL, NULL, 0L); #else child_pid = syscall(__NR_clone, SIGCHLD, NULL, NULL, NULL, 0L); #endif if (child_pid == 0) { /* child process - restore state */ -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.or

Re: kcrash, fork, and stdout/stderr

in the first place? Just exec the process again. It will replace the current process without closing the pipes. The parent won't notice a thing. Of course, that may be a problem: the parent may see the output from the child process again. -- Thiago Macieira - thiago (AT) macieira.info -

Re: kcrash, fork, and stdout/stderr

66611213=2 ("There's still a > fallback to use fork() in case using kdeinit fails for any reason.") Well, I've learnt a lot in the last 11 years. forking inside a signal handler is a bad idea because it may deadlock. If the crash happens while glibc holds some mutexes relating

Re: kcrash, fork, and stdout/stderr

y process that tries to write to it will get SIGPIPE. > Oh. > proc.setProcessChannelMode(QProcess::ForwardedChannels); > fixes it! That makes QProcess not create a pipe and instead pass its own stderr to the child. Then it's SEP. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: releaseme new requirement: non-conflicting files on case-insensitive FS/OS

not including libX11, libGL, libGLES, libGLU, libICE, libSM... -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

Re: releaseme new requirement: non-conflicting files on case-insensitive FS/OS

On segunda-feira, 20 de novembro de 2017 07:58:06 PST Reindl Harald wrote: > hopefully this means also that filenames in the future don't contain > uppercase chars Why would we want that? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Inte

Re: c++11 and workspace

can/should use C++11, KWin/master even requires C++14. Confirm if you mean the core language or the standard library. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

thiago added a comment. This class isn't hooked up to anything. It's technically correct as an FD sender and receiver. What I want to see is how you use it, because that's extremely important to get right. I can confirm to you that anonymous namespace sockets do not work on BSDs (which

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

thiago added a comment. In https://phabricator.kde.org/D5972#112994, @rjvbb wrote: > Yes, here too, haven't had time to read back up on and go through the whole Qt code review process. What branch should I target, anyway? 5.9, with a possible backport to 5.6. There's still time

D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)

thiago added a comment. Makes sense to work around older versions of Qt without the fix. But it needs a fix. That is still pending. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: thiago,

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

thiago added a comment. In https://phabricator.kde.org/D5865#112747, @rjvbb wrote: > In https://phabricator.kde.org/D5865#112743, @thiago wrote: > > > Fix the source code. > > > > If certain third-party libraries can't compile under MSVC 2015 (or even 2017!) with default compiler

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

thiago added a comment. In https://phabricator.kde.org/D5865#112737, @rjvbb wrote: > In https://phabricator.kde.org/D5865#112697, @thiago wrote: > > > Why are we spending time in named operators? It's much easier to fix the source code not to use them and then the problem goes away.

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

thiago added a comment. In https://phabricator.kde.org/D5865#112679, @rjvbb wrote: > > That option only exists in MSVC 2017. > > Should we have deduce that from the docs I cite in the CMake comments? I'm willing to believe that I misread as far as support for named operators is

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

thiago added a comment. In https://phabricator.kde.org/D5865#112549, @rjvbb wrote: > If a compiler is problematic in general it may not be worth it trying to account for it in a macro, trying to coerce it into doing something it cannot handle. I don't think that's a reason not to

Re: QProcess::startDetached and bash stdout capture

On sábado, 25 de março de 2017 09:03:28 PDT David Faure wrote: > On samedi 25 mars 2017 16:50:37 CET Thiago Macieira wrote: > > One problem is because the launched process inherits the pipes to stdout > > and stderr > > Really, even with startDetached? I assumed that was

Re: QProcess::startDetached and bash stdout capture

On sábado, 25 de março de 2017 09:03:28 PDT David Faure wrote: > On samedi 25 mars 2017 16:50:37 CET Thiago Macieira wrote: > > One problem is because the launched process inherits the pipes to stdout > > and stderr > > Really, even with startDetached? I assumed that was

  1   2   3   4   5   6   >