D11825: Fix unitialized value warning, nullptr access

[Stefan Brüns]

bruns added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11825

To: bruns, michaelh, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

[James Smith]

smithjd marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11529

To: smithjd, #baloo, vhanda, michaelh, broulik
Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11826: Simplify Term operator&& and ||

[Stefan Brüns]

bruns added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11826

To: bruns, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Baloo.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  Trivial searches (e.g. baloosearch foo) are expanded to a large list
  of ORed small results sets (e.g. 80 terms with 2...5 entries), thus
  speeding it up is quite beneficial.
  
  Currently, iterators which no longer return any entries are deleted
  and replaced with nullptrs, thus the value has to be checked on each
  iteration. The saved instructions are sufficient to more than amortize
  the cost of moving the remaining elements in the vector.
  
  The or operator has to return the smallest ID of the combined sets.
  Instead of doing a traversal on each next() call, determine the smallest
  ID on the first call and update it when checking if the iterators have
  to be advanced.
  
  Keep the docId in a local variable, as the virtual function call to
  (PostingIterator*)->docId() is somewhat expensive.
  
  According to valgrind, typical execution cost of Baloo::Query::exec()
  is reduced by 25% to 40%.
  
  Signed-off-by: Stefan Brüns 

TEST PLAN
  valgrind --tool=callgrind baloosearch foo OR bar

REPOSITORY
  R293 Baloo

BRANCH
  speedup_orpostingoperator

REVISION DETAIL
  https://phabricator.kde.org/D11828

AFFECTED FILES
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h

To: bruns, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11827: Do not retrieve mtime from database repeatedly when sorting

[Stefan Brüns]

bruns updated this revision to Diff 31007.
bruns added a comment.


  - Do not retrieve document ID for skipped result entries

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11827?vs=31006=31007

BRANCH
  searchstore_speedup_2

REVISION DETAIL
  https://phabricator.kde.org/D11827

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11827: Do not retrieve mtime from database repeatedly when sorting

[Stefan Brüns]

bruns edited the summary of this revision.
bruns edited the test plan for this revision.
bruns added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11827

To: bruns, #baloo
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11827: Do not retrieve mtime from database repeatedly when sorting

[Stefan Brüns]

bruns created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  For larger result sets, querying the mtime (once for lhs and rhs each)
  on each sorting step contributes significantly to the execution time.
  Retrieve the mtime once for each document and use it for searching.
  
  Test results:
  $> build/bin/baloosearch -l 1 type=image
  /home/stefan/DE15_Connector_Pinout.svg
  Elapsed: 0.432438 msecs
  
  $> baloosearch -l 1 type=image
  /home/stefan/DE15_Connector_Pinout.svg
  Elapsed: 3.66243 msecs
  
  $> build/bin/baloosearch  type=image | wc -l
  Elapsed: 3.19816 msecs
  1017
  
  $> baloosearch  type=image | wc -l
  Elapsed: 7.45712 msecs
  1017
  
  Signed-off-by: Stefan Brüns 

REPOSITORY
  R293 Baloo

BRANCH
  searchstore_speedup_1

REVISION DETAIL
  https://phabricator.kde.org/D11827

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

[Stefan Brüns]

bruns created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  The Term(Term, Operator, Term) constructor is identical to the three
  separate calls, but saves two separate function calls.
  
  Signed-off-by: Stefan Brüns 
  
  Try to merge terms with identical operations
  
  (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D), i.e. 2
  instead of 3 intermediate AND/OR terms.
  This is especially useful if terms are combined with a && b && c && d,
  which can be combined into one AND term with 4 subterms, instead of
  3 AND terms with 2 subterms each (((a AND b) AND c) AND d).
  
  Signed-off-by: Stefan Brüns 

REPOSITORY
  R293 Baloo

BRANCH
  baloo_term_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D11826

AFFECTED FILES
  src/lib/term.cpp
  src/lib/term.h

To: bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11825: Fix unitialized value warning, nullptr access

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: michaelh.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added a subscriber: Frameworks.
bruns requested review of this revision.

REVISION SUMMARY
  getVarint32Ptr may return a nullptr (in case of an error), and also will
  not set the value (size resp. n).
  
  Signed-off-by: Stefan Brüns 

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  fix_warnings

REVISION DETAIL
  https://phabricator.kde.org/D11825

AFFECTED FILES
  src/codecs/coding.cpp

To: bruns, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:113
>  info.url = url;
> -info.accessible = !url.isEmpty() && QFileInfo::exists(url);
> +info.accessible = !url.isEmpty() && fileInfo.exists(url);
> +info.symlink = fileInfo.isSymLink()

I think if you initialize fileinfo anyway, you should use fileinfo.exists() ...

> databasesanitizer.cpp:316
> +if (!info.symlink.isEmpty()) {
> +const auto id = 
> m_pimpl->m_transaction->documentId(info.symlink.toLocal8Bit());
> +const auto idInfo = m_pimpl->toIdInfo(id);

I think it is better to use
QT_FSTAT(info.symlink.toLocal8Bit().constData(), ...) here, avoids lots of 
calls to the database, and guarantees more consistent results - symlinkTarget() 
works on the filesystem, so should the lookup here

> databasesanitizer.cpp:317
> +const auto id = 
> m_pimpl->m_transaction->documentId(info.symlink.toLocal8Bit());
> +const auto idInfo = m_pimpl->toIdInfo(id);
> +if (!deviceIdFilter.contains(idInfo.deviceId)) {

missing check id != 0, or the equivalent if the above code is changed to 
QT_FSTAT

> databasesanitizer.cpp:333
> +if (dryRun) {
> +m_pimpl->m_transaction->abort();
> +} else {

why not just make the removeDocument transaction above depend on dryRun? 
removeDocument is expensive ...

> main.cpp:251
>  } else if (command == QStringLiteral("clean")) {
> -/* TODO: add prune command */
> -parser.showHelp(1);
> +auto dbMode = Database::ReadWriteDatabase;
> +if (!db->open(dbMode)) {

make it depend on dry-run?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick updated this revision to Diff 30980.
croick added a comment.


  - change socket file location and delete file after use

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=29248=30980

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks
Cc: michaelh, ngraham

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 30979.
croick added a comment.


  - update socket file location

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=29249=30979

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/queryptrace.cpp
  src/queryptrace.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11822: Make the word/char count a global preference

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added reviewers: KTextEditor, Kate.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
wsdfhjxc requested review of this revision.

REVISION SUMMARY
  This is an attempt to make the word/char count in the status bar
  a global preference covering the whole editor instead of a temporary
  menu option activated on demand for individual documents.
  
  BUG: 386897

TEST PLAN
  1. Open Kate.
  2. Open two new documents.
  3. Go to Settings -> Configure Kate -> Appearance.
  4. Check the "Show Word Count" option and apply changes.
  5. Word counter in the status bar is shown across all documents.
  6. Open another new document and observe the word counter.
  7. Close Kate and open it once again.
  8. The word counter is still there.

REPOSITORY
  R39 KTextEditor

BRANCH
  patch-1

REVISION DETAIL
  https://phabricator.kde.org/D11822

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: wsdfhjxc, #ktexteditor, #kate
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D11820: Handle properties with multiple values

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added a project: Baloo.
michaelh requested review of this revision.

TEST PLAN
  make test

REPOSITORY
  R824 Baloo Widgets

BRANCH
  string-list (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11820

AFFECTED FILES
  autotests/filemetadatawidgettest.cpp
  autotests/filemetadatawidgettest.h
  autotests/samplefiles/test.epub
  autotests/samplefiles/test.odt
  src/filemetadataprovider.cpp
  src/widgetfactory.cpp
  src/widgetfactory.h

To: michaelh, #baloo, #frameworks
Cc: astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, nicolasfella, 
alexeymin

D11820: Handle properties with multiple values

[Michael Heidelbach]

michaelh edited the summary of this revision.
michaelh added a dependency: D10694: epubextractor: Handle multiple subjects 
better.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11820

To: michaelh, #baloo, #frameworks
Cc: astippich, mgallien, elvisangelaccio, ashaposhnikov, spoorun, nicolasfella, 
alexeymin

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a dependent revision: D11820: Handle properties with multiple 
values.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, ngraham, andrebarros, alexeymin, emmanuelp

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh updated this revision to Diff 30972.
michaelh added a comment.


  - Additionally use keywords property
  
  This way the value-type of subject can be preserved

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10694?vs=30858=30972

BRANCH
  multi-subject (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10694

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/samplefiles/test.epub
  src/extractors/epubextractor.cpp

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, ngraham, andrebarros, alexeymin, emmanuelp

D11365: also test for value types in taglibextractortest and fix errors

[Alexander Stippich]

astippich planned changes to this revision.
astippich added a comment.


  In D11365#236274 , @michaelh wrote:
  
  > This patch should be split.
  >
  > 1. Test more properties
  > 2. Change return types of ...
  >
  >   Also 'fix errors' in the title is misleading because currently 
kfilemetadata works well.
  
  
  Sure, I can do that if it is not a problem that the new tests do not pass 
(temporarily). It is probably the best idea to create thorough tests for the 
way we'd like KFileMetaData/taglib to work, as they are lacking in several ways 
(and hence created the confusion I have had) . Then we can start fixing the 
errors.
  Can we reach a consent how it should behave in the end? e.g. should the 
result match the valueType in propertyinfo, should there be multiple properties 
with single strings or stringlists for multiple values? Any other concerns?
  @mgallien, what's your opinion here?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo, mgallien, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg added a comment.


  Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code 
base or could we use the system one? It's only available on Linux? In this case 
could we include it as a dummy only on non-Linunx systems? This way we could 
use the system one on Linux.
  
  Should LinuxDmabufParams subclass Resource?

INLINE COMMENTS

> fredrik wrote in linuxdmabuf_v1_interface.h:39
> Do we want these nested namespaces? We could have LinuxDmabufFlags, 
> LinuxDmabufBuffer etc. instead.

Since there are not yet any namespaces in KWayland below the client/server 
level, I would prefer it without the namespace.

> fredrik wrote in linuxdmabuf_v1_interface.h:65
> Should the Buffer class use a d-pointer?

I think yes. Together with a Private class implemented in the cpp file.

> fredrik wrote in linuxdmabuf_v1_interface.h:107
> Is this the solution we want for interfacing with the compositor?
> 
> My preference would be to use std::function callbacks, with setters in 
> LinuxDmabufUnstableV1Interface. Setting up the interface could then look like 
> this:
> 
>   m_linuxDmabuf = m_display->createLinuxDmabufInterface(m_display);
>   m_linuxDmabuf->setQuerySupportedFormats([]{ return 
> Compositor::self()->scene()->supportedDrmFormats(); });
>   ...
>   m_linuxDmabuf->create();
> 
> This can also be extended without breaking binary compatibility. But I don't 
> think we can use std::function in frameworks. There are also BIC issues when 
> mixing different STL implementations, which we may or may not care about.

I'm not sure what's the canonical way in KWayland to do this. I assume the 
supported formats and modifiers could be saved in a field of the interface's 
Private class on creation.

The buffer could be imported through a signal to the compositor and a function 
in the interface to be called by the compositor afterwards to proceed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, ragreen, schernikov, michaelh, ZrenBot, 
ngraham, alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Burkhard Lück]

lueck retitled this revision from "Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11 to general entities" to "Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11, SDDM to general entities".

REVISION DETAIL
  https://phabricator.kde.org/D11810

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

[Burkhard Lück]

lueck updated this revision to Diff 30968.
lueck added a comment.


  add entity for sddm

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11810?vs=30949=30968

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D10803: handle more tags in taglibextractor

[Michael Heidelbach]

michaelh accepted this revision.
michaelh added a comment.
This revision is now accepted and ready to land.


  Thank you.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 30956.
astippich added a comment.


  - remove duplicate genre property for mp3

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10803?vs=30955=30956

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 30955.
astippich marked an inline comment as done.
astippich added a comment.


  - fix formatting issues during rebase

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10803?vs=30951=30955

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich marked 3 inline comments as done.
astippich added a comment.


  In D10803#237133 , @michaelh wrote:
  
  > Except for the white space stuff I'm still fine with this.
  
  
  Oops, sorry, messed that up during rebase.

INLINE COMMENTS

> michaelh wrote in taglibextractor.cpp:304
> Nitpick: These comments aren't really informative. The tagname is explicit 
> enough. 
> I don't mind if you leave them in.

You're right, I copied them from MP3s, but they make no sense for APE and OGG 
tags

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Michael Heidelbach]

michaelh requested changes to this revision.
michaelh added a comment.
This revision now requires changes to proceed.


  Except for the white space stuff I'm still fine with this.

INLINE COMMENTS

> taglibextractor.cpp:237
>  data.discNumber = itDiscNumber->second.toInt();
> +}   TagLib::MP4::ItemListMap::Iterator itCompilation = 
> allTags.find("cpil");
> +if (itCompilation != allTags.end()) {

New line please

> taglibextractor.cpp:304
>  
> +// Genre.
>  itMPC = lstMusepack.find("GENRE");

Nitpick: These comments aren't really informative. The tagname is explicit 
enough. 
I don't mind if you leave them in.

> taglibextractor.cpp:659
>  extractOgg(stream, mimeType, data);
> +
>  }

Unrelated white-space change

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Sven Brauch]

brauch added a comment.


  Change looks good (the previous code definitely looks like nonsense), but 
what does this mean for existing settings, saved previously?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11811

To: jtamate, #kate, #frameworks
Cc: brauch, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham added a comment.


  Sure, I'll check that out later today.

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D11811: avoid Asan runtime error: shift exponent -1 is negative

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Kate, Frameworks.
Restricted Application added projects: Kate, Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  Avoid doing a 1<<-1.

TEST PLAN
  Before: 
frameworks/ktexteditor/src/completion/katecompletionconfig.cpp:195:33: runtime 
error: shift exponent -1 is negative
  after: silence

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D11811

AFFECTED FILES
  src/completion/katecompletionconfig.cpp

To: jtamate, #kate, #frameworks
Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich added a comment.


  Okay, I changed my mind, I rebased on top of master. Since the other revision 
needs more time and the new properties behave like the old ones, I'd like to 
end this long journey and land this revision if no-one objects :)

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 30951.
astippich added a comment.


  - update value types

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10803?vs=30950=30951

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 30950.
astippich added a comment.


  - rebase on top of master

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10803?vs=28467=30950

BRANCH
  enhance_taglib

REVISION DETAIL
  https://phabricator.kde.org/D10803

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.m4a
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, ngraham, michaelh
Cc: vhanda, dfaure, michaelh, ngraham, #frameworks, ashaposhnikov, astippich, 
spoorun, nicolasfella, alexeymin

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: ltoscano, Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Frameworks.
lueck requested review of this revision.

REVISION SUMMARY
  Falkon new browser
  X11 17 hits in l10n-kf5/documentation
  macOS new name since the release of macOS 10.12 Sierra see 
https://en.wikipedia.org/wiki/MacOS
  Solid > 13 hits in l10n-kf5/documentation

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11569: Improve consistency of "Open With" UI by always showing top app inline

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  Looks good to me. Can you just make sure that 
kde/applications/konqueror/libkonq/autotests/konqpopupmenutest.cpp still passes 
after these changes?

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

Trouble with tool bars

[Robin Atwood]

My first KDE4 to KF5 port has gone well and the app now compiles and runs 
without any warning messages. :) However, I am now trying to improve some 
things. I have a tool bar which is created by the XML support:








Filter Toolbar




I want to add a short-cut to one of the tool bars but I don't have a QAction 
for it. I tried listing the contents of actionCollection()->actions() but 
neither of the tool bars appeared. How do I find the QAction?

Secondly I want to give a line-edit widget in one of the tool bars focus when 
the bar becomes visible, so I tried:

connect( toolBar( fTB ), ::visibilityChanged, this, 
::toolBarVisible );

There are no runtime warning messages but the slot is never driven. What am I 
missing?

Thanks
Robin
-- 








-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Andres Betts]

abetts accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio, abetts
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 194 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/194/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Mar 2018 13:41:05 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31611/59723)38%
(18578/48972)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8608/9158)48%
(5257/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8355/14351)50%
(4878/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1007)42%
(418/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham added a comment.


  Any remaining objections, or can I land this?

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 173 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/173/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 30 Mar 2018 13:41:05 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Nathaniel Graham]

ngraham updated this revision to Diff 30940.
ngraham added a comment.


  Implement review comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11569?vs=30584=30940

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

Re: Changes to networkmanager-qt - breakage in plasma-workspace

[Allen Winter]

krop already fixed that

On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote:
> Hi Jan,
> 
> It seems that as part of your recent changes to networkmanager-qt to
> increase the dependency to 1.0.0 you've made some other changes which
> mean the appropriate include paths are no longer being provided to
> projects that depend on networkmanager-qt.
> 
> This has the unfortunate effect that plasma-workspace is no longer
> able to build on the CI system.
> 
> The error is:
> 
> In file included from /usr/include/libnm/nm-object.h:29:0,
>  from /usr/include/libnm/nm-access-point.h:29,
>  from /usr/include/libnm/NetworkManager.h:26,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/ipconfig.h:31,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/device.h:33,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/networkmanagerqt/manager.h:31,
>  from
> /home/jenkins/install-prefix/include/KF5/NetworkManagerQt/NetworkManagerQt/Manager:1,
>  from /home/jenkins/workspace/Dependency Build Plasma
> kf5-qt5 SUSEQt5.9/plasma-workspace/dataengines/geolocation/geolocation.cpp:25:
> /usr/include/libnm/nm-types.h:24:10: fatal error: gio/gio.h: No such
> file or directory
> 
> Could you please take a look?
> 
> Thanks,
> Ben
> 

D11733: Allow opening items from the open/save dialogs

[Nathaniel Graham]

ngraham added a comment.


  In D11733#236903 , @gregormi wrote:
  
  > I come from Windows where the Open item is also available. Not having it 
feels like a lack of flexibility. I think having it in the context menu will 
not affect the "normal" user.  Your proposed workaround with "Open containing 
Folder" -> Press Enter is certainly ok.
  
  
  Coming from the Mac world, they have an even better solution: you can invoke 
the Quick Look preview from open/save dialogs. So you just select the item, hit 
space bar, and you get a huge preview that you can even make full screen if 
you'd like. Hit space bar (or escape, or hit the close button) to close it 
again. It's super useful and super elegant.
  
  At some point in the Plasma 4 days, we had something similar in the form of 
KLook. Alas, it broke with the 4 -> 5 transition and I have not been able to 
find anyone willing to become a new maintainer. See 
https://bugs.kde.org/show_bug.cgi?id=272539
  
  That would be a really killer solution IMHO, if we could find someone willing 
to resurrect it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: gregormi, rkflx, broulik, michaelh, ngraham

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:3496d899181f: Add entities for Elisa, Markdown, KParts, 
DOT, SVG to general.entities (authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11619?vs=30411=30938

REVISION DETAIL
  https://phabricator.kde.org/D11619

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, ltoscano
Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Luigi Toscano]

ltoscano accepted this revision as: ltoscano.
ltoscano added a comment.
This revision is now accepted and ready to land.


  Uh, sorry, thanks, looks good.

REVISION DETAIL
  https://phabricator.kde.org/D11619

To: lueck, #documentation, ltoscano
Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

lueck added a reviewer: ltoscano.

REVISION DETAIL
  https://phabricator.kde.org/D11619

To: lueck, #documentation, ltoscano
Cc: #frameworks, michaelh, ngraham, skadinna

D11732: Improve protocols documentation

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in outputdevice.xml:67
> earlier you changed all the "compositor" to "server"

The usage of terms compositor and server is not clearly regulated in the 
Wayland world besides that these terms describe the same "application" (for 
example KWin). I try to use "server" whenever I talk about this application 
communicating with clients and "compositor" whenever I talk about this 
application in its capability of arranging surfaces to a final output image.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D11732

To: romangg, #frameworks
Cc: davidedmundson, michaelh, ngraham

D11732: Improve protocols documentation

[Roman Gilg]

romangg updated this revision to Diff 30925.
romangg marked an inline comment as done.
romangg added a comment.


  - Say properties

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11732?vs=30673=30925

BRANCH
  improveOutputManagementDoc

REVISION DETAIL
  https://phabricator.kde.org/D11732

AFFECTED FILES
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml

To: romangg, #frameworks
Cc: davidedmundson, michaelh, ngraham

D11733: Allow opening items from the open/save dialogs

[gregormi]

gregormi added a comment.


  In D11733#235208 , @rkflx wrote:
  
  > and the bug reporter's use case of selecting a file in a web browser for 
upload essentially wants the existing [F11] preview feature and perhaps a 
better preview feature in the web application itself.
  
  
  The inline preview only gives thumbnails which are not usable when one wants 
to read text on the image (zoom to 100%). For me, the preview should take place 
before it is uploaded to the web application because I want to make sure the 
right thing is uploaded.
  
  > Also note that you could just drag-and-drop the file onto Dolphin, which 
should then open the default app, or onto Gwenview's launcher etc.
  
  Interesting. Thanks for the hint.
  
  > My concern is that the naming as well as the concept itself clashes with 
the regular Open button while doing something different.
  
  +1. If the function is added, it should be named Open with... to not be 
confused with the Open button.
  
  > Maybe I'll change my mind if you can come up with a very compelling use 
case which is so great it's worth living with the disadvantages. For now my 
(i.e. take this with a grain of salt) recommendation would be to not add this.
  
  I come from Windows where the Open item is also available. Not having it 
feels like a lack of flexibility. I think having it in the context menu will 
not affect the "normal" user.  Your proposed workaround with "Open containing 
Folder" -> Press Enter is certainly ok.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11733

To: ngraham, #dolphin, #frameworks
Cc: gregormi, rkflx, broulik, michaelh, ngraham

D11740: ktooltipwidget: Subtract margins from available size

[Michael Heidelbach]

michaelh added a comment.


  In D11740#236892 , @cfeck wrote:
  
  > You made CI happy, merci :)
  
  
  I've been watching it 'live'. I'm happy too.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11740

To: michaelh, elvisangelaccio
Cc: #frameworks, elvisangelaccio, cfeck, michaelh, ngraham

D11740: ktooltipwidget: Subtract margins from available size

[Christoph Feck]

cfeck added a comment.


  You made CI happy, merci :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11740

To: michaelh, elvisangelaccio
Cc: #frameworks, elvisangelaccio, cfeck, michaelh, ngraham

There's a stack of diffs...

[Michael Heidelbach]

...waiting to be reviewed.

Hi all!

Please help baloo to (hopefully) improve and have a look at D11753 and 
its ancestors.



Thanks in advance,

Michael

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart added a dependent revision: D11801: remove m_desktopContainments.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11365: also test for value types in taglibextractortest and fix errors

[Michael Heidelbach]

michaelh added a comment.


  Since we're struggling with the same issues: T8196 
 and D10694 


REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo, mgallien, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, nicolasfella, 
ngraham, alexeymin

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart added a comment.


  so, i tried to remove m_desktopContainments in D11801 
, using the new query functions i added 
here.
  
  all seems to keep working, hopefully makes things a bit more robust

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D11361

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D10694: epubextractor: Handle multiple subjects better

[Michael Heidelbach]

michaelh added a comment.


  The semicolons problem is fixed now. See T8196 


REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, 
isidorov, nicolasfella, firef, ngraham, andrebarros, alexeymin, emmanuelp

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart updated this revision to Diff 30915.
mart added a comment.


  - only consider desktop containments

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=30914=30915

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11361: add a version containmentForScreen with activity

[Marco Martin]

mart updated this revision to Diff 30914.
mart added a comment.


  - Merge branch 'master' into arcpatch-D11361
  - add containmentsForActivity and containmentsForScreen

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11361?vs=29622=30914

BRANCH
  arcpatch-D11361

REVISION DETAIL
  https://phabricator.kde.org/D11361

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h
  src/plasma/private/corona_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, #frameworks, michaelh, ngraham

D11569: Improve consistency of "Open With" UI by always showing top app inline

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1 from me, other than the inline comment.

INLINE COMMENTS

> kfileitemactions.cpp:654
> +// Always show the top app inline
> +QAction *act = d->createAppAction(offers.takeFirst(), menu);
> +menu->addAction(act);

Please use `true` rather than `menu` as 2nd argument

REPOSITORY
  R241 KIO

BRANCH
  open-with-usability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11569

To: ngraham, rkflx, #vdg, #frameworks, #dolphin, dfaure, elvisangelaccio
Cc: mmustac, davidedmundson, broulik, dfaure, elvisangelaccio, anthonyfieroni, 
abetts, michaelh, ngraham

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/37/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Mar 2018 09:36:59 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4573/15127)23%
(1933/8400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1695/1714)52%
(990/1912)src44%
(52/117)44%
(52/117)23%
(2878/12285)15%
(943/6311)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/12/
 Project:
Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Mar 2018 09:36:59 +
 Build duration:
7 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)45%
(85/187)45%
(85/187)30%
(4573/15127)23%
(1933/8400)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1695/1714)52%
(990/1912)src44%
(52/117)44%
(52/117)23%
(2878/12285)15%
(943/6311)tests0%
(0/37)0%
(0/37)0%
(0/1128)0%
(0/177)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/29/
 Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 30 Mar 2018 09:36:59 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)

D11740: ktooltipwidget: Subtract margins from available size

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:309c92215e35: ktooltipwidget: Subtract margins from 
available size (authored by michaelh).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11740?vs=30903=30911

REVISION DETAIL
  https://phabricator.kde.org/D11740

AFFECTED FILES
  autotests/ktooltipwidgettest.cpp
  src/ktooltipwidget.cpp

To: michaelh, elvisangelaccio
Cc: #frameworks, elvisangelaccio, cfeck, michaelh, ngraham

Re: KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

[Ben Cooksley]

On Fri, Mar 30, 2018 at 9:36 PM, Michael Heidelbach 
wrote:

> On 30.03.2018 09:51, CI System wrote:
>
> *BUILD UNSTABLE*
> Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%
> 20SUSEQt5.9/22/
> Project: Frameworks baloo kf5-qt5 SUSEQt5.9
> Date of build: Fri, 30 Mar 2018 07:45:09 +
> Build duration: 5 min 51 sec and counting
> * JUnit Tests *
> Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s),
> Total: 39 test(s)
> * - Failed: TestSuite.kinotifytest *
>
> Hi!
>
> Why is kinotifytest making so much trouble? Am I reverting something
> without knowing? Should I revise kinotifytest?
>
> Never in my life I've touched that test. I swear, Your Honour.
>
> Cheers,
>
> Michael
>
Hi Michael,

You are not guilty :)

Tests reliant on inotify will have issues for our Linux based builds due to
kernel bugs/limitations in the overlayfs file system used by Docker. These
were resolved in a later kernel version, which is why it's flaky, as our
Debian based hosts have a newer kernel (where the issue is fixed) while the
Ubuntu LTS based hosts have a kernel which is impacted by this issue.

I expect these tests to pass reliably once Ubuntu releases 18.04 and we
upgrade the Ubuntu physical hosts to that.

Cheers,
Ben

D6313: Support Icon Scale from Icon naming specification 0.13

[Eike Hein]

hein added a comment.


  I also prefer the "Before" images.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11740: ktooltipwidget: Subtract margins from available size

[Elvis Angelaccio]

elvisangelaccio accepted this revision as: elvisangelaccio.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D11740

To: michaelh, #frameworks, elvisangelaccio
Cc: elvisangelaccio, cfeck, michaelh, ngraham

D11740: ktooltipwidget: Subtract margins from available size

[Elvis Angelaccio]

elvisangelaccio removed a reviewer: Frameworks.
This revision is now accepted and ready to land.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  restrict_size

REVISION DETAIL
  https://phabricator.kde.org/D11740

To: michaelh, elvisangelaccio
Cc: #frameworks, elvisangelaccio, cfeck, michaelh, ngraham

Re: KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

[Michael Heidelbach]

On 30.03.2018 09:51, CI System wrote:

*BUILD UNSTABLE*
Build URL 
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/22/

Project:Frameworks baloo kf5-qt5 SUSEQt5.9
Date of build:  Fri, 30 Mar 2018 07:45:09 +
Build duration: 5 min 51 sec and counting


*JUnit Tests *
Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 
test(s), Total: 39 test(s)

# *Failed: TestSuite.kinotifytest
*



Hi!

Why is kinotifytest making so much trouble? Am I reverting something 
without knowing? Should I revise kinotifytest?


Never in my life I've touched that test. I swear, Your Honour.

Cheers,

Michael**
**

D11768: Add Desktop and Downloads to the default list of Places

[Julian Wolff]

progwolff accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D11768

To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff
Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 172 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/172/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 30 Mar 2018 07:52:39 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 193 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/193/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Mar 2018 07:52:39 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31603/59722)38%
(18562/48972)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8610/9158)48%
(5257/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)58%
(8346/14350)50%
(4875/9722)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(520/1007)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/43/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Mar 2018 07:52:39 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(294/442)67%
(294/442)53%
(31658/59723)38%
(18584/48968)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8610/9158)48%
(5257/10861)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(100/119)84%
(100/119)59%
(8407/14351)50%
(4901/9726)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3891/7882)33%
(1636/4940)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(520/1007)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

Re: KDE in prefix install

[Sebastian Kügler]

Very useful, thanks Allan! :)

On woensdag 28 maart 2018 17:37:18 CEST Allan Sandfeld Jensen wrote:
> On Mittwoch, 28. März 2018 17:14:36 CEST Sebastian Kügler wrote:
> > What I usually do is copy the dbus files into the system paths, see
> > attached script. That should also make it work (after dbus restart).
> 
> You don't need that if you just set the dirs:
> 
> /etc/dbus-1/session.d/plasma-opt.conf:
>  1.0// EN"
>  "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd;>
> 
>   /opt/kde5/share/dbus-1/services/
> 
> 
> /etc/dbus-1/system.d/plasma-opt.conf:
>  1.0// EN"
>  "http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd;>
> 
> /opt/kde5/share/dbus-1/system-services
> /opt/kde5/etc/dbus-1/system.d
> 
> 
> But that still leaves the problem that he polkit-1 policy files for actions
> are neither generated nor installed. Any idea why that is the case?
> 
> 'Allan


-- 
sebas

http://www.kde.org | http://vizZzion.org

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 54 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/54/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 30 Mar 2018 07:45:09 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D11643: Fix crash when device emits ready read after job is finished

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:63ef72e8ac54: Fix crash when device emits ready read 
after job is finished (authored by aacid).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11643?vs=30387=30905

REVISION DETAIL
  https://phabricator.kde.org/D11643

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/transferjob.cpp

To: aacid, #frameworks, dfaure
Cc: #kde_connect, michaelh, ngraham

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 22 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/22/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 30 Mar 2018 07:45:09 +
 Build duration:
5 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

D11657: Do not export databasesanitizer by default

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1d977a7d49c5: Do not export databasesanitizer by default 
(authored by michaelh).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11657?vs=30424=30904#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11657?vs=30424=30904

REVISION DETAIL
  https://phabricator.kde.org/D11657

AFFECTED FILES
  CMakeLists.txt
  src/engine/CMakeLists.txt
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/experimental/databasesanitizer.cpp
  src/engine/experimental/databasesanitizer.h
  src/tools/CMakeLists.txt
  src/tools/baloodb/CMakeLists.txt
  src/tools/baloodb/Messages.sh
  src/tools/baloodb/main.cpp
  src/tools/experimental/baloodb/CMakeLists.txt
  src/tools/experimental/baloodb/Messages.sh
  src/tools/experimental/baloodb/main.cpp

To: michaelh, #baloo, davidedmundson
Cc: smithjd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, 
nicolasfella, ngraham, alexeymin

D11740: ktooltipwidget: Subtract margins from available size

[Michael Heidelbach]

michaelh updated this revision to Diff 30903.
michaelh added a comment.


  - Demonstrate respect to old school ;-)

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11740?vs=30888=30903

BRANCH
  restrict_size

REVISION DETAIL
  https://phabricator.kde.org/D11740

AFFECTED FILES
  autotests/ktooltipwidgettest.cpp
  src/ktooltipwidget.cpp

To: michaelh, #frameworks, elvisangelaccio
Cc: elvisangelaccio, cfeck, michaelh, ngraham