D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser

mpyne updated this revision to Diff 17913. mpyne added a comment. Joins the regex for the Type= line with its use. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7170?vs=17792=17913 REVISION DETAIL https://phabricator.kde.org/D7170 AFFECTED FILES

D7170: Fix errorneous whitespace handling in Desktop Entry parsing from DesktopFileParser

mpyne marked an inline comment as done. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D7170 To: mpyne, #frameworks, arichardson Cc: apol

D7169: Fix errorneous whitespace handling in Desktop Entry parsing from KConfigIni

This revision was automatically updated to reflect the committed changes. Closed by commit R237:11ee92d92b1e: kconfigini: Strip leading whitespace when reading entry values. (authored by mpyne). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D7094: Include a module for finding qml imports as runtime dependencies

apol updated this revision to Diff 17911. apol marked 3 inline comments as done. apol added a comment. Address sitter's comments REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7094?vs=17628=17911 BRANCH master REVISION DETAIL

D7094: Include a module for finding qml imports as runtime dependencies

apol added inline comments. INLINE COMMENTS > sitter wrote in ECMFindQMLModule.cmake.in:30 > Not sure if we have a common practice for this, but I am thinking this needs > to have a `find_program()` and give suitable output if qmlplugindump itself > cannot be found. Pointing the user towards

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:15 > if(APPLE) > -target_link_libraries(testtrash "-framework DiskArbitration -framework > CoreFoundation") > +set(testtrash_APPLE_LIBS "-framework DiskArbitration -framework > CoreFoundation") > endif(APPLE) Note that

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

This revision was automatically updated to reflect the committed changes. Closed by commit R241:dec4afb4145b: Use ecm_add_test and benefit from BUILD_TESTING awareness (authored by asturmlechner). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7213?vs=17908=17909

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/45/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 22:36:03 + Build duration: 1 min 56 sec and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/36/ Project: Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7 Date of build: Tue, 08 Aug 2017 22:36:03 + Build duration: 2 min 15 sec and counting

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7213 To: asturmlechner, #frameworks, kfunk Cc: kfunk

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

asturmlechner created this revision. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7213 AFFECTED FILES src/ioslaves/trash/tests/CMakeLists.txt To: asturmlechner, #frameworks Cc: kfunk

D7130: KMoreTools: Update and fix desktopfiles

gregormi added a comment. In https://phabricator.kde.org/D7130#133389, @elvisangelaccio wrote: > In https://phabricator.kde.org/D7130#132809, @gregormi wrote: > > > Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an application is installed by passing the

D7130: KMoreTools: Update and fix desktopfiles

gregormi added a comment. In https://phabricator.kde.org/D7130#132857, @ltoscano wrote: > In https://phabricator.kde.org/D7130#132425, @gregormi wrote: > > > In https://phabricator.kde.org/D7130#132409, @ltoscano wrote: > > > > > Just update the English messages. > > > More

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 20:07:08 + Build duration: 10 min and counting JUnit Tests Name:

D7210: KAuthorized: Fix API documentation for authorizeAction()

dhaumann closed this revision. dhaumann added a comment. Somehow the commit hook did not work. Committed with https://commits.kde.org/kconfig/4f096fd6466a8b5d1e05bbae593f3028fb4ef65a Thanks for the quick review! REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7210

D7210: KAuthorized: Fix API documentation for authorizeAction()

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7210 To: dhaumann, dfaure, elvisangelaccio Cc: #frameworks

D7210: KAuthorized: Fix API documentation for authorizeAction()

dhaumann created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY authorizeKAction() is deprecated, so let's better also fix this in the API documentation and use authorizeAction(). TEST PLAN nothing.

D6774: Fix labels of DeleteFile/RenameFile actions

elvisangelaccio updated this revision to Diff 17901. elvisangelaccio added a comment. - Add documentation REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6774?vs=16883=17901 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6774

D6841: Use "document-close" as icon for KStandardAction::close

This revision was automatically updated to reflect the committed changes. Closed by commit R265:89b36b21701c: Use "document-close" as icon for KStandardAction::close (authored by kossebau). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D6979: in automatic tests, find python interpreter and use it for python test scripts

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6a677507aab0: in automatic tests, find python interpreter and use it for python test scripts (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D7118: Add KPeople recipe

vkrause closed this revision. REPOSITORY R868 Yocto: KDE Frameworks Packaging REVISION DETAIL https://phabricator.kde.org/D7118 To: vkrause, cordlandwehr Cc: #frameworks

D7008: Don't export internal helper executables

habacker added a comment. In https://phabricator.kde.org/D7008#133779, @sitter wrote: > > I think @apol wrote the initial implementation of this magic and can probably answer questions better than me though :) I guess no. He also did not provide a working example see

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.7/21/ Project: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 08 Aug 2017 15:33:48 + Build duration: 1 min 46 sec and counting JUnit

D7008: Don't export internal helper executables

sitter added a subscriber: apol. sitter added a comment. In https://phabricator.kde.org/D7008#133756, @habacker wrote: > In https://phabricator.kde.org/D7008#133755, @sitter wrote: > > > In https://phabricator.kde.org/D7008#133644, @sitter wrote: > > > > >

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#133764, @vkrause wrote: > I assume installation is done for cross-compilation, yes. For Yocto this wouldn't even be necessary though, we manually inject the host executables into the -dev packages there, for this it only

D7094: Include a module for finding qml imports as runtime dependencies

sitter added a comment. qmlplugindump not being found needs to be handled somehow. Other than that only minor nitpicks. (as always I'd also be more confident if it had a test case ;)) INLINE COMMENTS > ECMFindQMLModule.cmake.in:30 > + > +execute_process(COMMAND qmlplugindump

D7008: Don't export internal helper executables

vkrause added a comment. I assume installation is done for cross-compilation, yes. For Yocto this wouldn't even be necessary though, we manually inject the host executables into the -dev packages there, for this it only matters that they are built, not that they are installed (see

D7008: Don't export internal helper executables

habacker added a comment. In https://phabricator.kde.org/D7008#133755, @sitter wrote: > In https://phabricator.kde.org/D7008#133644, @sitter wrote: > > > https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11

D7008: Don't export internal helper executables

sitter added a comment. In https://phabricator.kde.org/D7008#133644, @sitter wrote: > https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11 when not xcompiling the targets are fairly useless and don't need to get

D7008: Don't export internal helper executables

habacker added a comment. In https://phabricator.kde.org/D7008#133644, @sitter wrote: > (kind of off topic: This code should really be changed to use the `KF5_HOST_TOOLING` we use elsewhere You can show me a working example of this KF5_HOST_TOOLING support ? REPOSITORY R246

D6899: support X-KDE-OnlyShowOnQtPlatforms

dfaure added a comment. Ah, this key is already used, for applications? I wasn't aware, if that's the case. Hmm, then maybe better keep the same key indeed. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure,

KDE CI: Frameworks sonnet kf5-qt5 WindowsQt5.7 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsQt5.7/19/ Project: Frameworks sonnet kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:40 + Build duration: 1 hr 16 min and counting JUnit Tests

KDE CI: Frameworks kdesignerplugin kf5-qt5 WindowsQt5.7 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsQt5.7/16/ Project: Frameworks kdesignerplugin kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:26 + Build duration: 1 hr 14 min and counting

KDE CI: Frameworks kded kf5-qt5 WindowsQt5.7 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20WindowsQt5.7/16/ Project: Frameworks kded kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:25 + Build duration: 1 hr 11 min and counting build.log Description: Binary

KDE CI: Frameworks solid kf5-qt5 WindowsQt5.7 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsQt5.7/21/ Project: Frameworks solid kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:23 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

KDE CI: Frameworks kdnssd kf5-qt5 WindowsQt5.7 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20WindowsQt5.7/17/ Project: Frameworks kdnssd kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:20 + Build duration: 1 hr 7 min and counting build.log Description:

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsQt5.7 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsQt5.7/20/ Project: Frameworks kfilemetadata kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:17 + Build duration: 49 min and counting JUnit

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added a comment. In https://phabricator.kde.org/D6899#133625, @dfaure wrote: > "Show" is a bit of a historical name here, this isn't about showing apps in a menu... > > X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no? > > Looks good otherwise. that would

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsQt5.7 - Build # 17 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsQt5.7/17/ Project: Frameworks kglobalaccel kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:16 + Build duration: 47 min and counting JUnit Tests

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsQt5.7 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsQt5.7/67/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:15 + Build duration: 43 min and counting

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsQt5.7 - Build # 24 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsQt5.7/24/ Project: Frameworks kdeclarative kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:13 + Build duration: 41 min and counting JUnit Tests

KDE CI: Frameworks kcrash kf5-qt5 WindowsQt5.7 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsQt5.7/20/ Project: Frameworks kcrash kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:12 + Build duration: 39 min and counting JUnit Tests Name:

KDE CI: Frameworks threadweaver kf5-qt5 WindowsQt5.7 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsQt5.7/15/ Project: Frameworks threadweaver kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:12 + Build duration: 39 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsQt5.7 - Build # 43 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsQt5.7/43/ Project: Frameworks kcoreaddons kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:33 + Build duration: 38 min and counting JUnit Tests

KDE CI: Frameworks kxmlrpcclient kf5-qt5 WindowsQt5.7 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsQt5.7/18/ Project: Frameworks kxmlrpcclient kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:34:11 + Build duration: 37 min and counting JUnit Tests

KDE CI: Frameworks kauth kf5-qt5 WindowsQt5.7 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsQt5.7/23/ Project: Frameworks kauth kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:18 + Build duration: 35 min and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 WindowsQt5.7 - Build # 27 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20WindowsQt5.7/27/ Project: Frameworks kconfig kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:29 + Build duration: 33 min and counting JUnit Tests

KDE CI: Frameworks kcompletion kf5-qt5 WindowsQt5.7 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20WindowsQt5.7/19/ Project: Frameworks kcompletion kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:27 + Build duration: 30 min and counting JUnit Tests

KDE CI: Frameworks kcodecs kf5-qt5 WindowsQt5.7 - Build # 20 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/20/ Project: Frameworks kcodecs kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:24 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsQt5.7/22/ Project: Frameworks kbookmarks kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:20 + Build duration: 25 min and counting JUnit Tests

KDE CI: Frameworks karchive kf5-qt5 WindowsQt5.7 - Build # 21 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsQt5.7/21/ Project: Frameworks karchive kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:14 + Build duration: 23 min and counting JUnit Tests

KDE CI: Frameworks kactivities kf5-qt5 WindowsQt5.7 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20WindowsQt5.7/20/ Project: Frameworks kactivities kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:10 + Build duration: 23 min and counting build.log

KDE CI: Frameworks baloo kf5-qt5 WindowsQt5.7 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsQt5.7/22/ Project: Frameworks baloo kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:33:02 + Build duration: 20 min and counting build.log Description: Binary

KDE CI: Frameworks attica kf5-qt5 WindowsQt5.7 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20attica%20kf5-qt5%20WindowsQt5.7/17/ Project: Frameworks attica kf5-qt5 WindowsQt5.7 Date of build: Tue, 08 Aug 2017 08:32:57 + Build duration: 14 min and counting JUnit Tests Name:

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

dfaure created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY For compatibility reasons, this is only enabled when projects upgrade their find_package(ECM) line to request a version >= 5.38. A little bit like cmake policies: just upgrading

D7008: Don't export internal helper executables

sitter added subscribers: habacker, sandsmark, sitter. sitter added a comment. As per the if below the proposed change it is used for cross compiling. Subscribing original author and committer. (kind of off topic: This code should really be changed to use the `KF5_HOST_TOOLING` we

D7008: Don't export internal helper executables

dfaure added a comment. Why are those executables even installed? For crosscompiling maybe? I'm confused about how that would work. One would build sonnet for host, install it, and then build sonnet for target, importing targets from the host build? Isn't that "import" what this commit

D6992: Fix build on Linux without X11

dfaure added a comment. I think MAC_DISPLAY and WIN_DISPLAY just don't exist, they are historical relics of the first attempts at portability in this code. But I could be wrong. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah,

D6979: in automatic tests, find python interpreter and use it for python test scripts

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6979 To: mgallien, aacid, awilcox, #frameworks, dfaure Cc: #frameworks

D6914: Switch from QtScript to QtQml

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, cool, then please commit this Allen ;=) REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks

D6914: Switch from QtScript to QtQml

dfaure added a comment. I cherry-pick fixes into a local branch, when needed. So there's no reason to wait. It's always summer in master. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D6914 To: carewolf, cullmann, dhaumann, #frameworks Cc: dfaure,

D6899: support X-KDE-OnlyShowOnQtPlatforms

dfaure added a comment. "Show" is a bit of a historical name here, this isn't about showing apps in a menu... X-KDE-OnlyLoadOnQtPlatforms would be closer to the truth, no? Looks good otherwise. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart,

D6841: Use "document-close" as icon for KStandardAction::close

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH fixdocumentcloseactionicon REVISION DETAIL https://phabricator.kde.org/D6841 To: kossebau, #vdg, dfaure Cc: #frameworks

D6774: Fix labels of DeleteFile/RenameFile actions

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Is it possible to document somewhere that DeleteFile/RenameFile can be about files and folders? (I wonder if they shouldn't have been just called Delete and Rename, in fact... it