ltoscano added a reviewer: asturmlechner.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks, dfaure, asturmlechner
Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik
ltoscano added a comment.
I would still ask distributions: some of them may strip the translations in
some cases.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks, dfaure
Cc: ltoscano, aacid, dfaure, elvisangelaccio,
turbov updated this revision to Diff 17993.
turbov added a comment.
Make code block `::` works as again as expected
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17992=17993
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To:
turbov updated this revision to Diff 17992.
turbov added a comment.
Fix attribute name
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7245?vs=17991=17992
REVISION DETAIL
https://phabricator.kde.org/D7245
AFFECTED FILES
data/syntax/rest.xml
To: turbov, #kate,
turbov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
1. make `code-block` directive looks like a "directive" and not like a "code"
2. highlight directive options for `code-block` (and `code`)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/52/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 11 Aug 2017 02:56:27 +
Build duration:
19 min and counting
JUnit Tests
dfaure created this revision.
REVISION SUMMARY
This allows to remove the dependency on the installed file, fixing
"make test" in kpackage before installing it.
I extended the unittest to have a list of deps, but it's really in a
.desktop file that it would matter for checking that the
dfaure created this revision.
REVISION SUMMARY
This make kpackagetool work without installing kpackage.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7242
AFFECTED FILES
src/kpackagetool/CMakeLists.txt
src/kpackagetool/kpackagetool.qrc
To: dfaure, mart
Cc: #frameworks
rkflx added a comment.
Are you sure you are calling updateGeometry() in the right place and that
there are no other places where it should be called? Having a test case clearly
demonstrating the connection between the docs quote and your last sentence of
the summary would be reassuring not
aacid added a comment.
In https://phabricator.kde.org/D7230#134452, @elvisangelaccio wrote:
> In https://phabricator.kde.org/D7230#134391, @dfaure wrote:
>
> > That's one solution. The other is to add bool
KLocalizedString::hasApplicationTranslations() which stops at the first
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah, OK then.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks, dfaure
Cc: dfaure, elvisangelaccio, broulik
elvisangelaccio added a comment.
In https://phabricator.kde.org/D7230#134391, @dfaure wrote:
> That's one solution. The other is to add bool
KLocalizedString::hasApplicationTranslations() which stops at the first
translation found.
>
> Does the argument about shipping translations
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Forgot to git add kiod_agent.mm?
Looks good otherwise.
INLINE COMMENTS
> kiod_main.cpp:132
> +// possibly because of how things have been set up after creating
> +//
brauch added a comment.
I can write a test if you think this helps. I think reading the docs it is
quite clear we must call updateGeometry() here: our sizeHint() changes when
changing the text.
REVISION DETAIL
https://phabricator.kde.org/D7010
To: brauch, cfeck, rkflx
Cc: dhaumann,
rjvbb created this revision.
rjvbb added a project: Frameworks.
REVISION SUMMARY
This introduces a similar change to kiod5 that was already made to other
comparable background applications:
1 the LSUIElement InfoDict key is set, causing the application to run like an
"agent" (without
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This allows to bundle servicetype desktop files into libraries
to make it possible to run executables without the desktop file
installed.
TEST PLAN
kpackage unittests, after adding
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 10 Aug 2017 19:25:36 +
Build duration:
1 min 26 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/38/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 10 Aug 2017 19:24:09 +
Build duration:
1 min 23 sec and counting
JUnit Tests
dfaure added a comment.
That's one solution. The other is to add bool
KLocalizedString::hasApplicationTranslations() which stops at the first
translation found.
Does the argument about shipping translations in tarballs apply to kmail,
dolphin, etc. or just to KF5 and extragear? For
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20XenialQt5.7/43/
Project:
Frameworks extra-cmake-modules kf5-qt5 XenialQt5.7
Date of build:
Thu, 10 Aug 2017 18:29:05 +
Build duration:
3 min 49 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/52/
Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 10 Aug 2017 18:29:05 +
Build duration:
2 min 34 sec and counting
rkflx added a comment.
Looking at the Qt docs, we see:
> Call QWidget::updateGeometry() whenever the size hint, minimum size hint or
size policy changes. This will cause a layout recalculation.
To decide whether this is also meaningful for a squeezable label, a testcase
would be
rkflx updated this revision to Diff 17972.
rkflx added a comment.
Same wording for reimplementation warning as in
https://phabricator.kde.org/D7161.
Make indent, margin and lineWidth Q_PROPERTIES.
Add link to phabricator discussion as KF6 TODO (not sure if we can reach a
conclusion
rkflx added a comment.
Some thoughts, inconclusive though:
Another idea: Sometimes additional functionality for non-virtual functions is
provided by hooking into the changeEvent(). However, for our use case we won't
get such events from QLabel.
Things we might want to consider when
rkflx added inline comments.
INLINE COMMENTS
> dhaumann wrote in ksqueezedtextlabelautotest.cpp:217-234
> Looking at your other change requests: You may want to ignore the note about
> using setProperty(), since this will call QLabel::setIndent(), and not the
> one that you add in
rkflx marked 5 inline comments as done.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D7163
To: rkflx, #frameworks
Cc: dhaumann
rkflx updated this revision to Diff 17971.
rkflx added a comment.
Address comments:
- anonymous namespace
- QString() instead of QStringLiteral("")
- "pixels" for "amount"
- setProperty() instead of pointer to member function, remove switch and enum
REPOSITORY
R236 KWidgetsAddons
rkflx added a comment.
> I think this is already a very good patch. I just have some minor comments.
Thanks for looking at all these patches and taking the time for detailed
feedback. This is very helpful and really appreciated!
> you should consider applying for a KDE developer
Oh, and DrKonqi uses kio_http just fine.
R.
rkflx marked an inline comment as done.
REPOSITORY
R236 KWidgetsAddons
BRANCH
arcpatch-D7162
REVISION DETAIL
https://phabricator.kde.org/D7162
To: rkflx, #frameworks, dhaumann
Cc: dhaumann
rkflx updated this revision to Diff 17970.
rkflx added a comment.
Improve wording to be as elegant as suggested by Dominik.
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7162?vs=17774=17970
BRANCH
arcpatch-D7162
REVISION DETAIL
rkflx updated this revision to Diff 17969.
rkflx added a comment.
> Mabye the "@note" about some methods being not virtual in the base class is
even worth to put into the main class documentation.
Good idea, let's move it to the class description (to be referenced from each
affected
On Thursday August 10 2017 09:37:05 David Faure wrote:
> On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote:
> > ERR_UNKNOWN_URL_SCHEME
>
> Debug KProtocolInfo::isKnownProtocol("http") returning false.
It doesn't (or at least it shouldn't;
elvisangelaccio added a comment.
+1
We bundle translations in tarballs almost everywhere now, so it's safe to
assume that we have > 1 translations around.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks
Cc: elvisangelaccio, broulik
broulik added a comment.
Another idea would be to check it in `aboutToShow` of the menu?
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7230
To: apol, #frameworks
Cc: broulik
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
We are checking if every language known to us is present just to make
sure that we have more than one and show the dialog entry.
Always showing it is not a big deal and we'd save up this penalty
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/37/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 10 Aug 2017 12:07:13 +
Build duration:
1 min 41 sec and counting
JUnit Tests
On Thursday August 10 2017 11:53:21 David Faure wrote:
> > Will do. The http.so binary exists, loads (using a simple dlsym wrapper
> > utility) and also has what looks to be the proper plugin info according to
> > qtplugindump.
>
> Sounds like it's not found then, check Qt's plugin path (qmake
On jeudi 10 août 2017 10:43:54 CEST René J.V. Bertin wrote:
> On Thursday August 10 2017 09:37:05 David Faure wrote:
> >On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote:
> >> ERR_UNKNOWN_URL_SCHEME
> >
> >Debug KProtocolInfo::isKnownProtocol("http") returning false.
> >
>
On Thursday August 10 2017 09:37:05 David Faure wrote:
>On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote:
>> ERR_UNKNOWN_URL_SCHEME
>
>Debug KProtocolInfo::isKnownProtocol("http") returning false.
>
>KProtocolInfoFactory::fillCache() should find plugins/kf5/kio/http.so and make
On mercredi 9 août 2017 18:10:12 CEST René J.V. Bertin wrote:
> ERR_UNKNOWN_URL_SCHEME
Debug KProtocolInfo::isKnownProtocol("http") returning false.
KProtocolInfoFactory::fillCache() should find plugins/kf5/kio/http.so and make
KProtocolInfo return true.
--
David Faure, fa...@kde.org,
dfaure added a comment.
Ooops, sorry. I had heavily tested ... a somewhat different version of the
patch :(
Thanks for the fixes.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: aacid, kfunk, #frameworks,
42 matches
Mail list logo
