KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/68/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 07:51:14 + Build duration: 5 min 6 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/90/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 07:51:14 + Build duration: 1 min 22 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/130/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 07:17:56 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/74/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Nov 2018 07:17:57 + Build duration: 4 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.11/16/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 30 Nov 2018 07:10:46 + Build duration: 5 min 15 sec and counting JUnit Tests

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 273 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/273/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Nov 2018 06:58:57 + Build duration: 3 min 20 sec and counting BUILD ARTIFACTS

D17210: Added proxy and user settings

jgrulich closed this revision. jgrulich added a comment. Closed by https://cgit.kde.org/networkmanager-qt.git/commit/?id=ee74458db6593ed05b89c257de5789d02a0fb64d. REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: cfeck, ngraham, kde-frameworks-devel,

D15999: Add icons with added background to system.svgz

ngraham added a comment. Urgh, never mind, it was my fault all along. There was some cache somewhere; bumping the version number of the plasma theme fixed the issue entirely. I'm sorry for wasting your time. :( I'm happy with this now, though now that it's all working, there are two

D17239: ovs-bridge and ovs-interface setting

jgrulich added inline comments. INLINE COMMENTS > ovsbridgesetting.cpp:25 > +#include > + > +NetworkManager::OvsBridgeSettingPrivate::OvsBridgeSettingPrivate() Add defines for ovs-bridge properties and name in case NM is older than NM 1.10.0. > ovsbridgesetting.cpp:27 >

D15999: Add icons with added background to system.svgz

pstefan added a comment. In D15999#368499 , @filipf wrote: > In D15999#368498 , @ngraham wrote: > > > In D15999#368479 , @ndavis wrote: > > > > > It

D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#368499 , @filipf wrote: > But there is a tangible problem here - imagine what the logout screen when using dark themes would look like if the circles were dark[;] They would be weird looking and would be

D15999: Add icons with added background to system.svgz

filipf added a comment. In D15999#368498 , @ngraham wrote: > In D15999#368479 , @ndavis wrote: > > > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze

D15999: Add icons with added background to system.svgz

ngraham added a comment. In D15999#368479 , @ndavis wrote: > It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the

D15999: Add icons with added background to system.svgz

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. It appears that the background colors are hardcoded. If they are meant to be dark with the Breeze Light Plasma theme and light with Breeze Dark, then they should use the

D17245: Add string formatting function to property info

bruns added inline comments. INLINE COMMENTS > formatstrings.cpp:81 > +case 3: string = i18nc("@item:intable image orientation", "180° > rotated"); break; > +case 4: string = i18nc("@item:intable image orientation", "Vertically > flipped"); break; > +case 5: string =

D15999: Add icons with added background to system.svgz

ngraham added a comment. The existing icons in this style are already in the Plasma Breeze theme though; that was our reasoning for adding them here. In the medium-to-long-term, I strongly support deprecating the concept of the Plasma Breeze icon theme and centralizing everything in the

D15999: Add icons with added background to system.svgz

ndavis added a comment. Could these icons be moved into the breeze-icons repo? That would make it simpler to edit and review these in the future. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg, ndavis Cc: ndavis,

D15999: Add icons with added background to system.svgz

ngraham added a reviewer: ndavis. ngraham added a subscriber: ndavis. ngraham added a comment. Sorry this took a while. I had to stop work on D16031 until other changes got accepted and merged in, which happened today. Back to these icons... I hate

D17200: Avoid writing unchanged data to terms dbs

This revision was automatically updated to reflect the committed changes. Closed by commit R293:aff58c04b5dd: Avoid writing unchanged data to terms dbs (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17200?vs=46351=46515 REVISION DETAIL

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. Also, here's the 16px muted icon with the "No" symbol moved out to the right by 1px and then 2px compared to the 16px full volume icon 1px to the right F6447454: Screenshot_20181129_171423.png 2px to the right F6447452:

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. Also, the semi-transparent sound waves on the audio icons in the Breeze Plasma theme use 25% opacity, not 50% opacity. I think 25% looks better anyway. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg,

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. I'm not sure about this, but I think increasing the size of the red no symbol from 6px to 8px on the 22px mute icon might be a good idea. At 6px, it just seems to lack visual weight. 6px no symbol F6447430: Screenshot_20181129_164625.png

D17220: Improve symbolism for off and muted status icon

ndavis added a comment. In D17220#368147 , @trickyricky26 wrote: > Should this style then also be applied to other "off" status icons like touchpad and camera? I think so. I'm somewhat concerned that on certain icon designs it could

D16617: fix extraction of GPS altitude for exif data

astippich added a comment. gentle ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16617 To: astippich, #frameworks, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17245: Add string formatting function to property info

ngraham added inline comments. INLINE COMMENTS > formatstrings.cpp:82 > +case 4: string = i18nc("@item:intable image orientation", "Vertically > flipped"); break; > +case 5: string = i18nc("@item:intable image orientation", "Transposed"); > break; > +case 6: string =

D17245: Add string formatting function to property info

astippich updated this revision to Diff 46509. astippich added a comment. - make KCoreAddons a required framework REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17245?vs=46508=46509 BRANCH display_value REVISION DETAIL

D17245: Add string formatting function to property info

astippich created this revision. astippich added reviewers: broulik, bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Adds the ability to format the metadata value

D17220: Improve symbolism for off and muted status icon

ngraham added a comment. This stuff looks so good. I'll formally review later. I also think we should update the HIG's icons page to officially recommend a red slash for status icons' off state and a red circle-with-a-slash-through-it for the muted state. All in favor? REPOSITORY R266

D17220: Improve symbolism for off and muted status icon

trickyricky26 retitled this revision from "Use red X in disabled and muted status icons consistently" to "Improve symbolism for off and muted status icon". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: abetts, ndavis,

D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

sars added a comment. Note: this is especially bad when the "on the fly spellchecking" is enabled as visibleRange() is used to "optimize" and only highlight what is currently visible. It is called multiple times. REPOSITORY R39 KTextEditor REVISION DETAIL

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 updated this revision to Diff 46504. trickyricky26 added a comment. - Apply new off and muted styles; add 22px audio-status icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17220?vs=46419=46504 BRANCH streamline-muted-off

D17241: WIP: Disable highlighting for lines longer than 1024 characters.

sars added a comment. If we get it working properly we could make the limit much higher. I tried with 3 characters and it still worked very good. (except when selecting the line) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: sars, cullmann,

D17243: Only cal updateView() in visibleRange() when endPos() is invalid.

sars created this revision. sars added reviewers: cullmann, Kate, dhaumann. sars added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. Herald added a project: Frameworks. sars requested review of this revision. REVISION SUMMARY visibleRange() has a side-effect

D17241: WIP: Disable highlighting for lines longer than 1024 characters.

sars retitled this revision from "Disable highlighting for lines longer than 1024 characters." to "WIP: Disable highlighting for lines longer than 1024 characters.". sars edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To:

D17241: Disable highlighting for lines longer than 1024 characters.

brauch added a comment. Shouldn't this change simultaneously remove the line length limit ...? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: sars, cullmann, vkrause Cc: brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

D17241: Disable highlighting for lines longer than 1024 characters.

shubham added reviewers: cullmann, vkrause. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: sars, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: Disable highlighting for lines longer than 1024 characters.

sars created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. sars requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D17241 AFFECTED FILES

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

ngraham added a comment. Awesome, can't wait to have this in! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17239: ovs-bridge and ovs-interface setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ovs-bridge and ovs-interface setting according to:

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham updated this revision to Diff 46490. shubham added a comment. Change to KF 5.54 Will land it after saturday. This patch actually missed 2 tagging (5.52 and 5.53) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=46235=46490 REVISION DETAIL

D17238: Explicitly create QDateTime with UTC time

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9592e0b69c9: Explicitly create QDateTime with UTC time (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17238?vs=46485=46489 REVISION DETAIL

D17238: Explicitly create QDateTime with UTC time

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep, tzset is really slow. I suppose there are other similar lines of code in KIO that would benefit from the same fix? KFileItem for example? REPOSITORY R241 KIO REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

ngraham added a comment. I agree. Because this contains new strings and we're so close to the 5.53 release, let's land this for Frameworks 5.54 after tagging. @shubham I'm afraid this means you'll now need to change all the instances of `5.53` to `5.54`!  I know it's taken a long time,

D17210: Added proxy and user settings

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46488. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46469=46488 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES autotests/settings/CMakeLists.txt

D17237: KTextEditor::ViewPrivate: S

loh.tar added a comment. I can split it if you like in two diff - 'm_doc->' => 'doc()->' ~100 hits, perhaps not the best idea? A search for doc() has 24 hits (without this patch) - 'm_viewInternal->m_cursor' => 'cursorPosition()' ~10 hits Next would be look for inline candidates,

D17237: KTextEditor::ViewPrivate: S

loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - 'm_doc->' => 'doc()->' -

D17238: Explicitly create QDateTime with UTC time

broulik created this revision. broulik added reviewers: dfaure, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise it spends half of the time doing timezone conversions to

D17210: Added proxy and user settings

jgrulich added inline comments. INLINE COMMENTS > proxysetting.cpp:37 > +: name(NM_SETTING_PROXY_SETTING_NAME) > +, browserOnly(true) > +, method(ProxySetting::None) Default value is false. > usersetting.cpp:94 > +} > + > + One empty line is enough. REPOSITORY R282

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 added a comment. `22px` is okay imo; however I've enlarged it quite a bit for `16px`: F6446668: audio-volume-muted-alt-16.svg.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26,

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. In D17220#368147 , @trickyricky26 wrote: > F6446578: audio-volume-muted-alt-22.svg.png This is really nice, at least at large size. How does it fare in the UI when it's

D17220: Use red X in disabled and muted status icons consistently

abetts added a comment. In D17220#368147 , @trickyricky26 wrote: > I think the distinction is useful. The off icons would then look like this: > F6446567: microphone-sensitivity-high-22.svg.png > >

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 added a comment. I think the distinction is useful. The off icons would then look like this: F6446567: microphone-sensitivity-high-22.svg.png F6446566: audio-volume-high-22.svg.png Also,

D17193: KateViewInternal: Remove unneeded functions

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8b4cd5f37947: KateViewInternal: Remove unneeded functions (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17193: KateViewInternal: Remove unneeded functions

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I am happy with this ;=) Thanks for adding documentation to the header, such stuff is very welcome! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17193

D17210: Added proxy and user settings

pranavgade set the repository for this revision to R282 NetworkManagerQt. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

cfeck added a comment. Could you please set the Repository field? REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

pranavgade marked 3 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

pranavgade marked 3 inline comments as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in proxysetting.cpp:25 > It looks that the proxy setting has been introduced in NetworkManager 1.6. > This means that for all property defines, you have to add ifdef the same way >

D17193: KateViewInternal: Remove unneeded functions

loh.tar updated this revision to Diff 46473. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Prefer function calls for member excess - Merge KateViewInternal::updateView with KateViewInternal::doUpdateView - Add

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46469. pranavgade added a comment. made some changes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46467=46469 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES autotests/settings/CMakeLists.txt

D17210: Added proxy and user settings

jgrulich added inline comments. INLINE COMMENTS > iptunnelsetting.cpp:35 > , encapsulationLimit(0) > -, flags(IpTunnelSetting::Unknown) > +, flags(IpTunnelSetting::None) > , flowLabel(0) This is an unrelated change, submit it in a different review, but thanks for spotting

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46467. pranavgade marked 6 inline comments as done. pranavgade added a comment. Updated code as required, fixed a minor error in iptunnelsettings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46444=46467 REVISION DETAIL

D17191: Perfect alignment between QML and QWidget KCM titles

This revision was automatically updated to reflect the committed changes. Closed by commit R295:bba3150027f3: Perfect alignment between QML and QWidget KCM titles (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17191?vs=46323=46464

D17190: Add level api from Kirigami.Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d3964629cbff: Add level api from Kirigami.Heading (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17190?vs=46322=46463 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 272 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/272/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Nov 2018 12:58:37 + Build duration: 6 min 51 sec and counting BUILD ARTIFACTS

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

davidedmundson added a comment. Also +1 from me. However, I would strongly suggest waiting till after Saturday when frameworks is tagged. Then you'll have a month for translators and for some testing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To:

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17234: do not attempt to link phononexperimental :O

This revision was automatically updated to reflect the committed changes. Closed by commit R305:f6d55baf5aa8: do not attempt to link phononexperimental :O (authored by sitter). REPOSITORY R305 KNotifyConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17234?vs=46460=46461

D17234: do not attempt to link phononexperimental :O

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D17234 To: sitter, broulik, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17234: do not attempt to link phononexperimental :anguished:

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY ${PHONON_LIBS} as the name suggests links all libraries, that includes the

D17234: do not attempt to link phononexperimental :O

sitter edited the test plan for this revision. REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17234 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17234: do not attempt to link phononexperimental :O

sitter retitled this revision from "do not attempt to link phononexperimental :anguished:" to "do not attempt to link phononexperimental :O". REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D17234 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham,

D17210: Added proxy and user settings

jgrulich added inline comments. INLINE COMMENTS > proxysetting.cpp:25 > +#include > + > +NetworkManager::ProxySettingPrivate::ProxySettingPrivate() It looks that the proxy setting has been introduced in NetworkManager 1.6. This means that for all property defines, you have to add ifdef the