D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. In D28606#642513 , @ngraham wrote: > Darn. Maybe we should fix the PC3 tooltips though? :) Maybe, but I don't know what that would entail. For more context: I asked Kai about porting notifications to PC3 so that

D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. In D28606#642514 , @ngraham wrote: > Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) This doesn't actually affect toolbutton sizing, just icon sizing. Although, if you

D28606: Add iconSize property to PC2 ToolButton

ngraham added a reviewer: mart. ngraham added a comment. Adding Marco as a reviewer since I know he just lves ToolButton sizing. :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma, mart Cc: broulik,

D28606: Add iconSize property to PC2 ToolButton

ngraham added a comment. Darn. Maybe we should fix the PC3 tooltips though? :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28606: Add iconSize property to PC2 ToolButton

ndavis added a subscriber: broulik. ndavis added a comment. In D28606#642509 , @ngraham wrote: > If the developer has these needs, why not port to the PC3 version, which has this feature already? @broulik said we can't do that for some

D28606: Add iconSize property to PC2 ToolButton

ngraham added a comment. If the developer has these needs, why not port to the PC3 version, which has this feature already? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: ngraham, kde-frameworks-devel, LeGast00n,

D28606: Add iconSize property to PC2 ToolButton

ndavis added a comment. I'm getting a binding loop: : QML QQuickLayoutAttached: Binding loop detected for property "minimumWidth" I'm guessing that's `Layout.minimumWidth` inside the `ToolButtonStyle` `IconItem` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28606: Add iconSize property to PC2 ToolButton

ndavis edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize to PC2 ToolButton

ndavis created this revision. ndavis added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY iconSize sets the size of the ToolButton's icon if it is set to a value. If no value

D28606: Add iconSize property to PC2 ToolButton

ndavis retitled this revision from "Add iconSize to PC2 ToolButton" to "Add iconSize property to PC2 ToolButton". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28606 To: ndavis, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28573: Add 16px System Settings icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b8b972a547d1: Add 16px System Settings icon (authored by manueljlin, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D14598: Keep checking return value from calling browse_stat_path() in SMBSlave::stat() in sync with SMBSlave::listDir()

habacker closed this revision. habacker added a comment. This review request was superseeded by D16272 . REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14598 To: habacker, dfaure Cc: kde-frameworks-devel, kfm-devel, azyx,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.14 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/11/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 06 Apr 2020 00:22:20 + Build duration: 5 min 14 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 333 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/333/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 06 Apr 2020 00:22:20 + Build duration: 4 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/15/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 06 Apr 2020 00:22:22 + Build duration: 3 min 6 sec and counting JUnit Tests

D28033: Create ExpandableListItem

ngraham added a comment. Fixed in 96d203b4b86e829fa958a8aa2ac42c8f5e1a4d31 . REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma,

D28033: Create ExpandableListItem

ngraham added a comment. Oops, sorry. Will fix. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: dfaure, mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/39/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 22:04:06 + Build duration: 8 min 3 sec and counting JUnit Tests Name: projectroot

D28603: API dox: document more of the default property values of KUrlRequester

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d31ebc6aade3: API dox: document more of the default property values of KUrlRequester (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28603: API dox: document more of the default property values of KUrlRequester

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH documentmorekrulrequesterdefaults REVISION DETAIL https://phabricator.kde.org/D28603 To: kossebau, #frameworks, meven, dfaure, ahmadsamir Cc: kde-frameworks-devel, LeGast00n,

D28601: Fix DirectorySizeJob so it doesn't depend on listing order

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28601 To: dfaure, ahmadsamir Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28603: API dox: document more of the default property values of KUrlRequester

kossebau created this revision. kossebau added reviewers: Frameworks, meven, dfaure, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R241 KIO BRANCH documentmorekrulrequesterdefaults

D28444: WIP/RFC: Add ECMCargo module

cblack updated this revision to Diff 79430. cblack added a comment. Address feedback REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=78925=79430 BRANCH cblack/cargo-integration REVISION DETAIL https://phabricator.kde.org/D28444

D28444: Add ECMCargo module

cblack retitled this revision from "WIP/RFC: Add ECMCargo module" to "Add ECMCargo module". cblack edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks, #build_system Cc: apol, IlyaBizyaev,

D28553: Rename stylesheet color ButtonFocus -> Highlight

ndavis added a comment. @davidhurka Actually, I'm using Highlight. I still can't get ButtonFocus to work reliably and Highlight in icons now changes to white when a UI element gets highlighted, which is good. BTW, join the VDG chat if you haven't already. REPOSITORY R266 Breeze Icons

D28601: Fix DirectorySizeJob so it doesn't depend on listing order

ahmadsamir accepted this revision. ahmadsamir added a comment. This revision is now accepted and ready to land. I am sure the test passed locally many times before I submitted D28472 (and it still passes). But indeed it shouldn't depend on which was

D28579: Improve the look of kcachegrind

This revision was automatically updated to reflect the committed changes. Closed by commit R266:0e3911c84d37: Improve the look of kcachegrind (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28579?vs=79359=79428 REVISION DETAIL

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

dfaure added a comment. Suggested fix in D28601 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28472 To: ahmadsamir, #frameworks, dfaure, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28601: Fix DirectorySizeJob so it doesn't depend on listing order

dfaure created this revision. dfaure added a reviewer: ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN jobtest passes locally again REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

dfaure added a comment. Does the test pass for you now? For me it fails (and it fails on FreeBSD CI too https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/37/testReport/junit/projectroot/autotests/kiocore_jobtest/) FAIL! : JobTest::directorySize() Compared

D28599: [configview] Simplify code / workaround Qt5.15 crash

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > configview.cpp:137 > > + > q->engine()->rootContext()->setContextProperty(QStringLiteral("plasmoid"), > applet.data()->property("_plasma_graphicObject").value());

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/38/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 17:51:46 + Build duration: 6 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 37 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/37/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 17:13:56 + Build duration: 6 min 35 sec and counting JUnit Tests Name:

D28599: [configview] Simplify code / workaround Qt5.15 crash

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY QQmlComponent::beginCreate and completeCreate are useful if you

D28598: KRun: fix assert when failing to start an application

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28598 To: dfaure, ahmadsamir Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28598: KRun: fix assert when failing to start an application

ahmadsamir accepted this revision. ahmadsamir added a comment. This revision is now accepted and ready to land. Of course. That makes much more sense than the band aid fix in the (my) other diff. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28598

D28592: [ApplicationLauncherJob] Guard against m_pids being empty

ahmadsamir abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28592 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27216: [KProcessRunner] Improve error messages on failure

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kprocessrunner.cpp:279 > +if (exitCode != 0) { > +KMessageBox::error(nullptr, i18n("The program '%1' terminated > abnormally.\n" > +

D27216: [KProcessRunner] Improve error messages on failure

dfaure added reviewers: davidedmundson, broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktextwidgets » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 05 Apr 2020 17:02:16 + Build duration: 1 min 55 sec and counting JUnit Tests

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.12 - Build # 77 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.12/77/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 05 Apr 2020 17:02:15 + Build duration: 1 min 44 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktextwidgets » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 05 Apr 2020 17:02:16 + Build duration: 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktextwidgets » kf5-qt5 SUSEQt5.14 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktextwidgets/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 05 Apr 2020 17:02:15 + Build duration: 1 min 47 sec and counting BUILD ARTIFACTS

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R310:d7ec040f5aa0: [KTextWidgets] Port from QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

dfaure added a comment. It's tagged, you can go ahead. REPOSITORY R310 KTextWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D27097 To: ahmadsamir, #frameworks, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28598: KRun: fix assert when failing to start an application

dfaure created this revision. dfaure added a reviewer: ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN 'sudo chmod a-x /usr/bin/gwenview' Try opening a picure file from e.g. dolphin, you get

D28592: [ApplicationLauncherJob] Guard against m_pids being empty

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. This, hmm, sounds wrong. Is the caller calling pid() even though the job finished with an error code? Ah, yes, indeed, in the case of KRun. Whoops. Here's my suggested fix

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

ahmadsamir added a comment. I think I should wait until 5.69 is released before landing, right? REPOSITORY R310 KTextWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D27097 To: ahmadsamir, #frameworks, mlaurent, dfaure Cc:

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. In D28535#642289 , @elvisangelaccio wrote: > In D28535#640833 , @fvogt wrote: > > > I assume there is a reason why `MTPDevice::getDevice()` has code for handling this very

D27097: [KTextWidgets] Port from QRegExp to QRegularExpression

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R310 KTextWidgets BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D27097 To: ahmadsamir, #frameworks, mlaurent,

D28535: [KIO-MTP] Fix null pointer dereference

anthonyfieroni added a comment. @elvisangelaccio this peace of code is purely wrong at least `m_storages` is not updated to new device and not only. This code should never exists or try to hide some other bug. REPOSITORY R320 KIO Extras BRANCH fixNullPtr (branched from master)

D28535: [KIO-MTP] Fix null pointer dereference

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. In D28535#640833 , @fvogt wrote: > I assume there is a reason why `MTPDevice::getDevice()` has code for handling this very

D28528: UDSEntry: add constructor variant with std::initializer_list

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > udsentry.h:132 > +const long long l; > +char s[sizeof(QString)]; > +} m_u; Why not simply QString*? > udsentrybenchmark.cpp:141 > +

D28520: Fix lifetime of slot in KIO-MTP

elvisangelaccio accepted this revision. elvisangelaccio added a comment. Please push to 20.04, there is still time. REPOSITORY R320 KIO Extras BRANCH slotLifetime (branched from master) REVISION DETAIL https://phabricator.kde.org/D28520 To: feverfew, akrutzler, dfaure,

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

meven accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir, #frameworks, dfaure, meven, bruns Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

meven marked an inline comment as done. meven added a comment. In D28590#642133 , @bruns wrote: > Btw, label() is a bad name, it can be confused with the filesystem label to easily. Maybe shortName(). I meant to reuse this name on

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2,

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:146 > set(KDEInstallDirsTest.relative_or_absolute_usr_EXTRA_OPTIONS > --build-options -DCMAKE_INSTALL_PREFIX=/usr > -DKDE_INSTALL_USE_QT_SYS_PATHS=FALSE This test uses /usr and passes on Windows. It's not

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

apol added a comment. Will /tmp then still work on Windows? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28409 To: dfaure, kossebau, apol, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham,

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in jobtest.h:88 > wrong name Of course, the one time I forgot to build before using 'arc diff' in a long time... REPOSITORY R241 KIO REVISION DETAIL

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79411. ahmadsamir added a comment. Fix test name in header Add one more QCOMPARE() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79410=79411 BRANCH l-statx (branched from master) REVISION DETAIL

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

bruns added inline comments. INLINE COMMENTS > jobtest.cpp:1540 > +// On the CI where the two tmp dirs are on the only parition > available > +// in the LXC container, the device ID's would be identical > +} QCOMPARE(device, otherDevice); > jobtest.h:88 > void

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79410. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79339=79410 BRANCH l-statx (branched from master) REVISION

D28592: [ApplicationLauncherJob] Guard against m_pids being empty

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN - 'sudo chmod a-x /usr/bin/gwenview' - Try opening a picure file from e.g. dolphin, you get an error message as

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bc3003f77270: [kio-extras] Port some QRegExp usage to QRegularExpression (authored by ahmadsamir). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

ahmadsamir updated this revision to Diff 79406. ahmadsamir added a comment. Rebase REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28161?vs=78528=79406 BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28161 AFFECTED

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns added a comment. Btw, label() is a bad name, it can be confused with the filesystem label to easily. Maybe shortName(). REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack,

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

bruns added a comment. I think it would be better to not change behaviour for any backend, but just default label() to description() everywhere. Then in the next step, adjust description() and label() for each backend, shorten label where possible, and extend description() so it becomes

D27216: [KProcessRunner] Improve error messages on failure

ahmadsamir added a comment. The QSignalSpy stuff are fixed. However, krununittest won't work with QTEST_GUILESS_MAIN() as there's a dialog that wants to get displayed (from my previous post). However I still can't figure out why the cp command is existing with code 15... REPOSITORY

D27216: [KProcessRunner] Improve error messages on failure

ahmadsamir updated this revision to Diff 79399. ahmadsamir retitled this revision from "[KProcessRunner] Improve error reported to user when exit code != 0" to "[KProcessRunner] Improve error messages on failure". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan

D28590: Add a QString Solid::Device::label, used in Fstab Device for network mounts

meven created this revision. meven added reviewers: Frameworks, bruns, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This adds a label field, so that devices can provide a label and a more

D28561: Remove border from format-border-set-* icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:07487651e13c: Remove border from format-border-set-* icons (authored by davidhurka). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28561?vs=79386=79393

D26113: Places: For mounted volume display mount points instead of description

meven added a comment. In D26113#642028 , @bruns wrote: > I say its the responsibility of Vaults to set the option. For Vaults, there is no fstab anyway, just an options value in the mtab at runtime. My primary concern is for network

D26113: Places: For mounted volume display mount points instead of description

bruns added a comment. In D26113#642022 , @meven wrote: > In D26113#642018 , @bruns wrote: > > > In D26113#641998 , @meven wrote: > > > > > In

D28561: Remove border from format-border-set-* icons

ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

meven added a comment. In D26113#642018 , @bruns wrote: > In D26113#641998 , @meven wrote: > > > In D26113#641190 , @bruns wrote: > > > > > In

D28565: [QueryParser] Replace single-use helper with std::none_of

This revision was automatically updated to reflect the committed changes. Closed by commit R293:8a872e502d22: [QueryParser] Replace single-use helper with std::none_of (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28565?vs=79308=79387

D26113: Places: For mounted volume display mount points instead of description

bruns added a comment. In D26113#641998 , @meven wrote: > In D26113#641190 , @bruns wrote: > > > In D26113#581228 , @ngraham wrote: > > > > > > As

D28561: Remove border from format-border-set-* icons

davidhurka edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH simplify-format-border REVISION DETAIL https://phabricator.kde.org/D28561 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

davidhurka updated this revision to Diff 79386. davidhurka added a comment. - Remove border elements in 22px versions of format-border-* I would like if you accept this new patch version, to be formally correct. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH l-QRE (branched from master) REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol, meven Cc: meven, kfm-devel, kde-frameworks-devel,

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

meven added a comment. Seems good to me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28161 To: ahmadsamir, dfaure, sitter, apol Cc: meven, kfm-devel, kde-frameworks-devel, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2,

D26113: Places: For mounted volume display mount points instead of description

meven added a comment. In D26113#641190 , @bruns wrote: > In D26113#581228 , @ngraham wrote: > > > > As Vaults are not backed by an fstab entry, it would be the responsibility of Vaults to set a

D28221: Don't write default value to configuration file when default value came from /etc/* file

dfaure added a comment. I have a hard time accepting that the documentation was wrong -- and if it was, then this commit has to fix it, and port as much of the app code that does exactly this, as possible. I don't really know what mReference is. What about a test that uses KConfig

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

dfaure closed this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28577: Add StatusBarExtension(KParts::Part *) overloaded constructor.

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH master REVISION DETAIL https://phabricator.kde.org/D28577 To: dfaure, vkrause, aacid, cgiboudeaux, kossebau Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28582: KRunner: Show error message for Actions in dbus runner

alex updated this revision to Diff 79377. alex added a comment. Update comment REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79376=79377 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582

D28582: KRunner: Show error message for Actions in dbus runner

alex updated this revision to Diff 79376. alex added a comment. Update if condition REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79375=79376 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL

D28582: KRunner: Show error message for Actions in dbus runner

alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY KRunner now shows error messages for the Actions dbus

D28573: Add 16px System Settings icon

manueljlin added a comment. manueljlin @ pm.me I'll look into using arc for future patches, thanks :D REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28573 To: manueljlin, #vdg, ndavis, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

bruns added a comment. looks good to me otherwise INLINE COMMENTS > jobtest.cpp:1537 > + > +// this test doesn't make sense on the CI as it's an LXC container with > one partition > +if (otherTmpDirIsOnSamePartition()) { slight rewording // In case the two tmp dirs are on the

D27216: [KProcessRunner] Improve error reported to user when exit code != 0

dfaure added a comment. Oops I totally missed this one, sorry. Does this testcase work better with the new code in kiogui? Hopefully QProcess start should fail? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27216 To: ahmadsamir, #frameworks, dfaure Cc:

D28033: Create ExpandableListItem

dfaure added a comment. This commit broke the i18ndcheck unittest. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.14/job/plasma-framework/job/kf5-qt5%20SUSEQt5.14/9/testReport/junit/projectroot/autotests/i18ndcheck/ Reproducible locally. Works before and breaks