D20013: Use Qt function for string list formatting

astippich updated this revision to Diff 54951. astippich added a comment. - rebase directly on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54653=54951 BRANCH string_list_formatting REVISION DETAIL

D20012: Fix number localization for properties

astippich updated this revision to Diff 54950. astippich added a comment. - remove unit test changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20012?vs=54650=54950 BRANCH fix_value_localization REVISION DETAIL

D20046: Verify mimetypes for all existing sample files, add some more

astippich accepted this revision. astippich added inline comments. INLINE COMMENTS > extractorcoveragetest.cpp:50 > +m_knownFiles = { > +{ "test.aif", "audio/x-aifc"}, > +{ "test.ape", "audio/x-ape"}, Is it really

D20045: Add helper function to determine mime type based on content and extension

astippich accepted this revision. astippich added a comment. Just two small nitpicks INLINE COMMENTS > mimeutils.cpp:39 > +for (auto mime : extensionMimes) { > +// check if the content is a specialized type (child) for a generic > container, e.g.: > +// *.mkv -> [

D20021: Add support for extracting data from ogg and ts files

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2a76b11e1e9f: Add support for extracting data from ogg and ts files (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54726. astippich added a comment. - Add failing ogg video test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54725=54726 BRANCH ffmpeg_ogg_ts REVISION DETAIL

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. forgot rebasing... REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54725. astippich added a comment. - Add failing ogg video test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54707=54725 BRANCH ffmpeg_ogg_ts REVISION DETAIL

D20020: Split ffmpeg tests into video properties and metadata tests

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6ee3df16ab20: Split ffmpeg tests into video properties and metadata tests (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. What I meant is that no metadata is currently extracted at all. Is it possible to mark a complete test row as expected failure? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc:

D20012: Fix number localization for properties

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:97 > This will of course fail as soon as someone translates fps, e.g. german > "B/s", even more in RTL locales. > > Probably the better solution is to provide the whole string verbatim, and > mark it with

D20020: Split ffmpeg tests into video properties and metadata tests

astippich updated this revision to Diff 54708. astippich added a comment. - rephrase comment REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20020?vs=54705=54708 BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020

D20020: Split ffmpeg tests into video properties and metadata tests

astippich retitled this revision from "Split ffmpeg tests into common properties and metadata" to "Split ffmpeg tests into video properties and metadata tests". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc:

D20021: Add support for extracting data from ogg and ts files

astippich updated this revision to Diff 54707. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20021?vs=54686=54707 BRANCH ffmpeg_ogg_ts REVISION DETAIL https://phabricator.kde.org/D20021 AFFECTED FILES

D20020: Split ffmpeg tests into common properties and metadata

astippich updated this revision to Diff 54705. astippich added a comment. - rename tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20020?vs=54685=54705 BRANCH refactor_ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D20020

D20021: Add support for extracting data from ogg and ts files

astippich added a comment. For reasons unknown, the metadata is not correctly extracted and "title" is not found for ogg videos, that's why it is not included there. I would like to investigate this later. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021

D20020: Split ffmpeg tests into common properties and metadata

astippich added a dependent revision: D20021: Add support for extracting data from ogg and ts files. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20020 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20021: Add support for extracting data from ogg and ts files

astippich added reviewers: ngraham, bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20021: Add support for extracting data from ogg and ts files

astippich added a dependency: D20020: Split ffmpeg tests into common properties and metadata. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20021 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20021: Add support for extracting data from ogg and ts files

astippich created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY CCBUG: 399650 REPOSITORY R286 KFileMetaData BRANCH ffmpeg_ogg_ts REVISION DETAIL

D20020: Split ffmpeg tests into common properties and metadata

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_ffmpeg_tests REVISION

D20011: Be more precise with mimetype detection

astippich edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20011 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20011: Be more precise with mimetype detection

astippich added a comment. Ideally Qt would provide this, but I could not find any REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20011 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19445: Handle variant list in formatting functions

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfo.cpp:634 > Don't reinvent Qt functionality: > https://doc.qt.io/qt-5/qlocale.html#createSeparatedList see D20013 REPOSITORY R286

D20013: Use Qt function for string list formatting

astippich added a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19445: Handle variant list in formatting functions

astippich added a dependent revision: D20013: Use Qt function for string list formatting. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D20013: Use Qt function for string list formatting

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Reuse existing Qt function to convert string lists into string

D20012: Fix number localization for properties

astippich added a dependent revision: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20012 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19445: Handle variant list in formatting functions

astippich added a dependency: D20012: Fix number localization for properties. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19445: Handle variant list in formatting functions

astippich updated this revision to Diff 54651. astippich added a comment. - code style REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19445?vs=52905=54651 BRANCH generic_display_list REVISION DETAIL https://phabricator.kde.org/D19445 AFFECTED

D20012: Fix number localization for properties

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Some properties were missing proper number localization

D20011: Be more precise with mimetype detection

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY D18819 changed the mimetype

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > Taglib does not "handle this nicely". For APE and Xiph, it just accepts *any* > unknown key and uses it verbatim, while for MP4 and ASF it rejects any > unknown key. > > The setProperties() is also quite

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

This revision was automatically updated to reflect the committed changes. Closed by commit R286:649555ee3182: Rewrite the taglib extractor to use the generic PropertyMap interface (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18826?vs=53587=53599#toc REPOSITORY

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich abandoned this revision. astippich added a comment. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19097 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19098 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 53587. astippich marked an inline comment as done. astippich added a comment. - spelling fixes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=53585=53587 BRANCH arcpatch-D18826 REVISION DETAIL

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich marked 3 inline comments as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:364 > This intermediate list is not required, you can directly call result->add() > for each attribute in lstASF. After further investigation there is no need to

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 53585. astippich added a comment. - update REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=52890=53585 BRANCH arcpatch-D18826 REVISION DETAIL https://phabricator.kde.org/D18826 AFFECTED FILES

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > I think for **reading** it as generic as possible is fine, but for writing > being a little bit more explicit does not hurt. > > My proposal for Ape and Ogg is to split the writing for these to two >

D17302: Add test for adding properties to result

astippich added a comment. ping REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17302 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19287: [ExtractorCollection] Load extractor plugins lazily

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH lazy_loading REVISION DETAIL https://phabricator.kde.org/D19287 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, gennad, domson,

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: smithjd, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19102: Fix extraction of aspect ratio property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1082b1e009bc: Fix extraction of aspect ratio property (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52114=53021 REVISION

D19101: Increase precision of frame rate property

This revision was automatically updated to reflect the committed changes. Closed by commit R286:2ab37ed086d8: Increase precision of frame rate property (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=52109=53020

D19445: Handle variant list in formatting functions

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Improve the formatting function of KFileMetaData such that

D19442: [Kfilemetada] Make it compile without foreach

astippich added a comment. There are currently larger refactorings ongoing (D19287 , D18826 ), could you please wait for them and rebase afterwards? INLINE COMMENTS > externalextractor.cpp:151 > +const auto

D17302: Add test for adding properties to result

astippich updated this revision to Diff 52894. astippich added a comment. - mark expected fail REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17302?vs=48688=52894 BRANCH test_result REVISION DETAIL https://phabricator.kde.org/D17302 AFFECTED FILES

D18601: Rewrite taglib writer to use property interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwriter.cpp:70 > So **iff** the rating is updated at the same time as another property, taglib > has to adjust some in-memory structure twice. Obviously, for most formats > this poses no problem, but for Ape/Vorbis it does?

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

astippich added a comment. Windows CI seems not to be happy about this https://build.kde.org/job/Applications/job/baloo-widgets/job/kf5-qt5%20WindowsMSVCQt5.11 REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19268 To: bruns, #frameworks, #baloo, ngraham,

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:208 > Can you also use the same style as above, i.e. `const auto` and `for( : )`? Oh, damn copy > smithjd wrote in taglibextractor.cpp:195 > lstASF = asfTags->attribute("WM/Writer"); > ... > > The existing

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52890. astippich marked 8 inline comments as done. astippich added a comment. - rebase on master - implement review comments - cleanup includes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added a comment. I get the feeling that we need to discuss how the PropertyMap should look like and how we achieve a seamless transition in a backwards compatible way. I have slowly been working to resolve T8196 , which is why I am so insisting.

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52679. astippich added a comment. - remove now unnecessary include REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=52675=52679 BRANCH rewrite_taglib_extractor REVISION DETAIL

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > smithjd wrote in taglibextractor.cpp:195 > Can this be moved into the asf-specific extractions? I wanted to do so first, but that will require to also put the PropertyMap into the extractAsfTags

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich updated this revision to Diff 52675. astippich added a comment. - return early if map is empty REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18826?vs=51128=52675 BRANCH rewrite_taglib_extractor REVISION DETAIL

D16579: Remove support for non-standard APE tag field names

astippich added a comment. In D16579#418256 , @smithjd wrote: > > Anyway, most of this special handling of mimetypes goes away with D18826 , where TagLib will do the conversion automatically. > > The test

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

astippich added a comment. This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow and the warning "Trying to construct an instance of an invalid type, type id: 21123393" is given. REPOSITORY R824 Baloo

D17302: Add test for adding properties to result

astippich added a comment. In D17302#417646 , @bruns wrote: > In D17302#410231 , @astippich wrote: > > > In D17302#410189 , @bruns wrote: > > > > >

D12950: add test which checks the property types

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:24359a020a1a: add test which checks the property types (authored by astippich). REPOSITORY R286 KFileMetaData

D16579: Remove support for non-standard APE tag field names

astippich added a comment. In D16579#416446 , @smithjd wrote: > I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertydata.cpp:80 > Actually, I am not sure **if** we need the stringlists as a separate type.. > What is the difference between multiple strings in a stringlist, and multiple > strings as individual dict entries? > > What is

D19109: [Extractor] Add metadata to extractors

astippich added a comment. also T8079 REPOSITORY R286 KFileMetaData BRANCH extractor_properties REVISION DETAIL https://phabricator.kde.org/D19109 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, domson,

D19109: [Extractor] Add metadata to extractors

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. I would also like to remove the aliasing mimetypes. But I guess due to the implementation where the mimetype is given as QString, and there is no guarantee that it is obtained from

D19102: Fix extraction of aspect ratio property

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Thats obviously just avoiding the rules. You can ask for an exception anyway. The intention was to land the fix as soon as possible while complying to the

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich added a comment. In D19098#414973 , @bruns wrote: > In D19098#414729 , @astippich wrote: > > > It already does at two different places, because it fuses different information into a

D19109: [Extractor] Add metadata to extractors

astippich added a comment. In D19109#414968 , @bruns wrote: > In D19109#414758 , @astippich wrote: > > > A few general remarks: > > > > - I really do not like that there are two lists of

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. The stringlist case is still not handled. And a test case for multiple ints (2 ReleaseYear properties) will also likely fail. When going with JSON, I think this has to be

D19102: Fix extraction of aspect ratio property

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in formatstrings.cpp:157 > Proper i18n That was actually done deliberately to get this in for Kf 5.56 since there is string freeze. But if concatenation is a no go, this has to wait

D19102: Fix extraction of aspect ratio property

astippich updated this revision to Diff 52114. astippich added a comment. - do not use QString::number REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=52104=52114 BRANCH ffmpeg_aspectratio REVISION DETAIL

D19101: Increase precision of frame rate property

astippich marked 2 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

astippich updated this revision to Diff 52109. astippich added a comment. - do not use QString::number REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=52103=52109 BRANCH ffmpeg_framerate REVISION DETAIL

D19102: Fix extraction of aspect ratio property

astippich updated this revision to Diff 52104. astippich added a comment. - rebase - use exact value for test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19102?vs=51918=52104 BRANCH ffmpeg_aspectratio REVISION DETAIL

D19101: Increase precision of frame rate property

astippich removed a dependency: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19100: Cleanup ffmpeg extractor

astippich removed a dependent revision: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19101: Increase precision of frame rate property

astippich updated this revision to Diff 52103. astippich added a comment. - rebase on master - use exact value in test REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19101?vs=51917=52103 BRANCH ffmpeg_framerate REVISION DETAIL

D19100: Cleanup ffmpeg extractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:96b08a1a601f: Cleanup ffmpeg extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19100?vs=51916=52102 REVISION DETAIL

D19099: Add a test for ffmpeg extractor

This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:f4c72f517911: Add a test for ffmpeg extractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D19109: [Extractor] Add metadata to extractors

astippich added a comment. A few general remarks: - I really do not like that there are two lists of supported mimetypes now which have to be kept in sync - Do we really need versioning per mimetype? IMHO it is sufficient to have a version number per extractor. From my experience,

D19099: Add a test for ffmpeg extractor

astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in ffmpegextractortest.cpp:45 > I find it somewhat difficult to grasp `Title` is > KFileMetaData::Property::Title. > You can use something like: > > namespace KFMProp =

D19099: Add a test for ffmpeg extractor

astippich updated this revision to Diff 51990. astippich added a comment. - emphasize test properties REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19099?vs=51915=51990 BRANCH ffmpeg_tests REVISION DETAIL https://phabricator.kde.org/D19099

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich added a comment. It already does at two different places, because it fuses different information into a single QMap later on (xattr, file size etc...) https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65

D19101: Increase precision of frame rate property

astippich added a dependency: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19101: Increase precision of frame rate property

astippich added a dependent revision: D19102: Fix extraction of aspect ratio property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19101 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19102: Fix extraction of aspect ratio property

astippich added a dependency: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19102 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D19100: Cleanup ffmpeg extractor

astippich added a dependent revision: D19101: Increase precision of frame rate property. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D19100: Cleanup ffmpeg extractor

astippich added a dependency: D19099: Add a test for ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19100 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

astippich added a dependent revision: D19100: Cleanup ffmpeg extractor. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19099 To: astippich, bruns, ngraham, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D19102: Fix extraction of aspect ratio property

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY The extraction of the aspect ratio was broken for multiple

D19100: Cleanup ffmpeg extractor

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REPOSITORY R286 KFileMetaData BRANCH ffmpeg_cleanup REVISION DETAIL

D19099: Add a test for ffmpeg extractor

astippich created this revision. astippich added reviewers: bruns, ngraham, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Test the ffmpegextractor using a test file. The

D19098: Add PropertyMap to QVariantMap conversion function using names

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a conversion function from a PropertyMap to a

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich added a dependent revision: D19098: Add PropertyMap to QVariantMap conversion function using names. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19097 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D19097: Add a test and document PropertyMap/VariantMap conversion

astippich created this revision. astippich added reviewers: bruns, ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a roundtrip test and document the conversion function.

D18601: Rewrite taglib writer to use property interface

astippich added a comment. ping REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien, broulik, cfeck Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

astippich added a comment. ping. I know this is quite a large diff, but it fixes a potential crash REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18826 To: astippich, ngraham, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

astippich added a comment. I was wondering if using QDataStream would be simpler, but the data size was over twice the amount compared to the size using JSON during my testing. But this would solve a lot of the limitations which JSON imposes, like handling int and doubles, qdatetime

D18972: Format EXIF photo flash data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e2bd6629783e: Format EXIF photo flash data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18972?vs=51548=51555 REVISION DETAIL

D18972: Format EXIF photo flash data

astippich added inline comments. INLINE COMMENTS > ngraham wrote in formatstrings.cpp:103 > Does this one mean "present but did not fire" or "there is no flash with this > hardware"? If the latter, I might suggest instead "None". Otherwise this is > fine the way it is. Strictly this means

D12950: add test which checks the property types

astippich added a comment. If no-one objects, I will land this next week REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

<    1   2   3   4   5   6   7   8   9   10   >